[INFO] fetching crate cashweb-secp256k1 0.19.1... [INFO] linting cashweb-secp256k1-0.19.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cashweb-secp256k1 0.19.1 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate cashweb-secp256k1 0.19.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate cashweb-secp256k1 0.19.1 [INFO] tweaked toml for crates.io crate cashweb-secp256k1 0.19.1 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cashweb-secp256k1 0.19.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cashweb-secp256k1 0.19.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded wasm-bindgen-futures v0.4.19 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.69 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.69 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.69 [INFO] [stderr] Downloaded wasm-bindgen-test v0.3.19 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.69 [INFO] [stderr] Downloaded wasm-bindgen-test-macro v0.3.19 [INFO] [stderr] Downloaded bitcoin_hashes v0.9.4 [INFO] [stderr] Downloaded autocfg v0.1.7 [INFO] [stderr] Downloaded serde_test v1.0.118 [INFO] [stderr] Downloaded cc v1.0.66 [INFO] [stderr] Downloaded log v0.4.11 [INFO] [stderr] Downloaded serde v1.0.118 [INFO] [stderr] Downloaded js-sys v0.3.46 [INFO] [stderr] Downloaded wasm-bindgen v0.2.69 [INFO] [stderr] Downloaded cashweb-secp256k1-sys v0.3.1 [INFO] [stderr] Downloaded syn v1.0.56 [INFO] [stderr] Downloaded console_error_panic_hook v0.1.6 [INFO] [stderr] Downloaded web-sys v0.3.46 [INFO] [stderr] Downloaded libc v0.2.81 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 18575dcf460849a367fee7f83ec3617c67e0718b68b9bbe1402d5a748dc3e73b [INFO] running `Command { std: "docker" "start" "-a" "18575dcf460849a367fee7f83ec3617c67e0718b68b9bbe1402d5a748dc3e73b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "18575dcf460849a367fee7f83ec3617c67e0718b68b9bbe1402d5a748dc3e73b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "18575dcf460849a367fee7f83ec3617c67e0718b68b9bbe1402d5a748dc3e73b", kill_on_drop: false }` [INFO] [stdout] 18575dcf460849a367fee7f83ec3617c67e0718b68b9bbe1402d5a748dc3e73b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] de9218274e55fff2fbf52603d67578addb2e2a2833135fd98976d6b12f97ae8d [INFO] running `Command { std: "docker" "start" "-a" "de9218274e55fff2fbf52603d67578addb2e2a2833135fd98976d6b12f97ae8d", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking rand_core v0.4.2 [INFO] [stderr] Compiling autocfg v0.1.7 [INFO] [stderr] Compiling cc v1.0.66 [INFO] [stderr] Compiling libc v0.2.81 [INFO] [stderr] Compiling serde v1.0.118 [INFO] [stderr] Checking bitcoin_hashes v0.9.4 [INFO] [stderr] Checking rand_core v0.3.1 [INFO] [stderr] Checking rand_jitter v0.1.4 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Checking rand_isaac v0.1.1 [INFO] [stderr] Checking rand_hc v0.1.0 [INFO] [stderr] Checking rand_xorshift v0.1.1 [INFO] [stderr] Compiling cashweb-secp256k1-sys v0.3.1 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking cashweb-secp256k1 v0.19.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/lib.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | #[cfg(any(test))] [INFO] [stdout] | ^^^^^^^^^ help: try: `test` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:772:23 [INFO] [stdout] | [INFO] [stdout] 772 | #[cfg(rust_secp_fuzz)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> src/context.rs:45:1 [INFO] [stdout] | [INFO] [stdout] 45 | pub unsafe trait Context: private::Sealed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/context.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn deallocate(ptr: *mut u8, size: usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 276 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 278 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 312 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 312 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 314 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 348 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 350 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:245:17 [INFO] [stdout] | [INFO] [stdout] 245 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:263:31 [INFO] [stdout] | [INFO] [stdout] 263 | let mut ret_len = constants::PUBLIC_KEY_SIZE as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `constants::PUBLIC_KEY_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:282:31 [INFO] [stdout] | [INFO] [stdout] 282 | let mut ret_len = constants::UNCOMPRESSED_PUBLIC_KEY_SIZE as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `constants::UNCOMPRESSED_PUBLIC_KEY_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/key.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | / impl PartialOrd for PublicKey { [INFO] [stdout] 392 | | fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { [INFO] [stdout] 393 | | self.serialize().partial_cmp(&other.serialize()) [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 392 - fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { [INFO] [stdout] 393 - self.serialize().partial_cmp(&other.serialize()) [INFO] [stdout] 394 - } [INFO] [stdout] 392 + fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:263:29 [INFO] [stdout] | [INFO] [stdout] 263 | Signature::from_der(&self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | (bytes + word_size - 1) / word_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `bytes.div_ceil(word_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:791:9 [INFO] [stdout] | [INFO] [stdout] 791 | return self.sign_grind_with_check(msg, sk, len_check); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return self.sign_grind_with_check(msg, sk, len_check); [INFO] [stdout] 791 + self.sign_grind_with_check(msg, sk, len_check) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:801:9 [INFO] [stdout] | [INFO] [stdout] 801 | return self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 801 - return self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit); [INFO] [stdout] 801 + self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/lib.rs:764:49 [INFO] [stdout] | [INFO] [stdout] 764 | let le_counter_bytes: [u8; 4] = mem::transmute(le_counter); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 764 - let le_counter_bytes: [u8; 4] = mem::transmute(le_counter); [INFO] [stdout] 764 + let le_counter_bytes: [u8; 4] = u32::to_ne_bytes(le_counter); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking serde_test v1.0.118 [INFO] [stdout] warning: unneeded sub `cfg` when there is only one condition [INFO] [stdout] --> src/lib.rs:131:7 [INFO] [stdout] | [INFO] [stdout] 131 | #[cfg(any(test))] [INFO] [stdout] | ^^^^^^^^^ help: try: `test` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_minimal_cfg [INFO] [stdout] = note: `#[warn(clippy::non_minimal_cfg)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/schnorrsig.rs:555:15 [INFO] [stdout] | [INFO] [stdout] 555 | #[cfg(not(rust_secp_fuzz))] // fixed sig vectors can't work with fuzz-sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/schnorrsig.rs:576:15 [INFO] [stdout] | [INFO] [stdout] 576 | #[cfg(not(rust_secp_fuzz))] // fixed sig vectors can't work with fuzz-sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:772:23 [INFO] [stdout] | [INFO] [stdout] 772 | #[cfg(rust_secp_fuzz)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1252:15 [INFO] [stdout] | [INFO] [stdout] 1252 | #[cfg(not(rust_secp_fuzz))] // fixed sig vectors can't work with fuzz-sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1274:15 [INFO] [stdout] | [INFO] [stdout] 1274 | #[cfg(not(rust_secp_fuzz))] // fuzz-sigs have fixed size/format [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1291:15 [INFO] [stdout] | [INFO] [stdout] 1291 | #[cfg(not(rust_secp_fuzz))] // fuzz-sigs have fixed size/format [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1163:23 [INFO] [stdout] | [INFO] [stdout] 1163 | #[cfg(not(rust_secp_fuzz))] // mocked sig generation doesn't produce low-R sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1165:23 [INFO] [stdout] | [INFO] [stdout] 1165 | #[cfg(not(rust_secp_fuzz))] // mocked sig generation doesn't produce low-R sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `rust_secp_fuzz` [INFO] [stdout] --> src/lib.rs:1160:27 [INFO] [stdout] | [INFO] [stdout] 1160 | #[cfg(not(rust_secp_fuzz))] // mocked sig generation doesn't produce low-R sigs [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(rust_secp_fuzz)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(rust_secp_fuzz)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: docs for unsafe trait missing `# Safety` section [INFO] [stdout] --> src/context.rs:45:1 [INFO] [stdout] | [INFO] [stdout] 45 | pub unsafe trait Context: private::Sealed { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/context.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | unsafe fn deallocate(ptr: *mut u8, size: usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:276:9 [INFO] [stdout] | [INFO] [stdout] 276 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 276 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:278:9 [INFO] [stdout] | [INFO] [stdout] 278 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 278 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:312:9 [INFO] [stdout] | [INFO] [stdout] 312 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 312 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:314:9 [INFO] [stdout] | [INFO] [stdout] 314 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 314 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:348:9 [INFO] [stdout] | [INFO] [stdout] 348 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 348 | /// that was generated by *exactly* the same code/version of the libsecp256k1 used here. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/context.rs:350:9 [INFO] [stdout] | [INFO] [stdout] 350 | /// when generating the context. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 350 | /// when generating the context. [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:245:17 [INFO] [stdout] | [INFO] [stdout] 245 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:263:31 [INFO] [stdout] | [INFO] [stdout] 263 | let mut ret_len = constants::PUBLIC_KEY_SIZE as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `constants::PUBLIC_KEY_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/key.rs:282:31 [INFO] [stdout] | [INFO] [stdout] 282 | let mut ret_len = constants::UNCOMPRESSED_PUBLIC_KEY_SIZE as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `constants::UNCOMPRESSED_PUBLIC_KEY_SIZE` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/key.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | / impl PartialOrd for PublicKey { [INFO] [stdout] 392 | | fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { [INFO] [stdout] 393 | | self.serialize().partial_cmp(&other.serialize()) [INFO] [stdout] 394 | | } [INFO] [stdout] 395 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 392 - fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { [INFO] [stdout] 393 - self.serialize().partial_cmp(&other.serialize()) [INFO] [stdout] 394 - } [INFO] [stdout] 392 + fn partial_cmp(&self, other: &PublicKey) -> Option<::core::cmp::Ordering> { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/key.rs:692:32 [INFO] [stdout] | [INFO] [stdout] 692 | let long_str: String = iter::repeat('a').take(1024 * 1024).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"a".repeat(1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] = note: `#[warn(clippy::manual_str_repeat)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/key.rs:692:32 [INFO] [stdout] | [INFO] [stdout] 692 | let long_str: String = iter::repeat('a').take(1024 * 1024).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n('a', 1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/key.rs:856:17 [INFO] [stdout] | [INFO] [stdout] 856 | assert!(!(pk2 < pk1)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(pk2 >= pk1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/key.rs:857:17 [INFO] [stdout] | [INFO] [stdout] 857 | assert!(!(pk1 < pk2)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(pk1 >= pk2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `str::repeat` using iterators [INFO] [stdout] --> src/schnorrsig.rs:679:32 [INFO] [stdout] | [INFO] [stdout] 679 | let long_str: String = iter::repeat('a').take(1024 * 1024).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `"a".repeat(1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_str_repeat [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/schnorrsig.rs:679:32 [INFO] [stdout] | [INFO] [stdout] 679 | let long_str: String = iter::repeat('a').take(1024 * 1024).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n('a', 1024 * 1024)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:263:29 [INFO] [stdout] | [INFO] [stdout] 263 | Signature::from_der(&self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:292:17 [INFO] [stdout] | [INFO] [stdout] 292 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:338:17 [INFO] [stdout] | [INFO] [stdout] 338 | data.len() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `data.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:649:9 [INFO] [stdout] | [INFO] [stdout] 649 | (bytes + word_size - 1) / word_size [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `bytes.div_ceil(word_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:791:9 [INFO] [stdout] | [INFO] [stdout] 791 | return self.sign_grind_with_check(msg, sk, len_check); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 791 - return self.sign_grind_with_check(msg, sk, len_check); [INFO] [stdout] 791 + self.sign_grind_with_check(msg, sk, len_check) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:801:9 [INFO] [stdout] | [INFO] [stdout] 801 | return self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 801 - return self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit); [INFO] [stdout] 801 + self.sign_grind_with_check(msg, sk, compact_sig_has_zero_first_bit) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1083:33 [INFO] [stdout] | [INFO] [stdout] 1083 | Signature::from_str(&hex_str).expect("byte str decode") [INFO] [stdout] | ^^^^^^^^ help: change this to: `hex_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1086:39 [INFO] [stdout] | [INFO] [stdout] 1086 | let sig = Signature::from_str(&hex_str).expect("byte str decode"); [INFO] [stdout] | ^^^^^^^^ help: change this to: `hex_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1117:39 [INFO] [stdout] | [INFO] [stdout] 1117 | let sig = Signature::from_str(&hex_str).expect("byte str decode"); [INFO] [stdout] | ^^^^^^^^ help: change this to: `hex_str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/lib.rs:764:49 [INFO] [stdout] | [INFO] [stdout] 764 | let le_counter_bytes: [u8; 4] = mem::transmute(le_counter); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: there's also `to_le_bytes` and `to_be_bytes` if you expect a particular byte order [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 764 - let le_counter_bytes: [u8; 4] = mem::transmute(le_counter); [INFO] [stdout] 764 + let le_counter_bytes: [u8; 4] = u32::to_ne_bytes(le_counter); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 10.26s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: serde_test v1.0.118 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 1` [INFO] running `Command { std: "docker" "inspect" "de9218274e55fff2fbf52603d67578addb2e2a2833135fd98976d6b12f97ae8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de9218274e55fff2fbf52603d67578addb2e2a2833135fd98976d6b12f97ae8d", kill_on_drop: false }` [INFO] [stdout] de9218274e55fff2fbf52603d67578addb2e2a2833135fd98976d6b12f97ae8d