[INFO] fetching crate cargo-piston 0.4.1... [INFO] linting cargo-piston-0.4.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate cargo-piston 0.4.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate cargo-piston 0.4.1 [INFO] finished tweaking crates.io crate cargo-piston 0.4.1 [INFO] tweaked toml for crates.io crate cargo-piston 0.4.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate cargo-piston 0.4.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate cargo-piston 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded cargo_metadata v0.23.1 [INFO] [stderr] Downloaded current_platform v0.2.0 [INFO] [stderr] Downloaded cargo-platform v0.3.1 [INFO] [stderr] Downloaded cargo-subcommand v0.12.0 [INFO] [stderr] Downloaded zune-jpeg v0.5.7 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 496d035dab76542b241fcd983f8db4eddbef20f99183b454b2fba214b7edf018 [INFO] running `Command { std: "docker" "start" "-a" "496d035dab76542b241fcd983f8db4eddbef20f99183b454b2fba214b7edf018", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "496d035dab76542b241fcd983f8db4eddbef20f99183b454b2fba214b7edf018", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "496d035dab76542b241fcd983f8db4eddbef20f99183b454b2fba214b7edf018", kill_on_drop: false }` [INFO] [stdout] 496d035dab76542b241fcd983f8db4eddbef20f99183b454b2fba214b7edf018 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 8561674dee9e74ddd4f55e3a26bf51008daff2305e61bda7a0626ac16e5c687d [INFO] running `Command { std: "docker" "start" "-a" "8561674dee9e74ddd4f55e3a26bf51008daff2305e61bda7a0626ac16e5c687d", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking flate2 v1.1.5 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Compiling camino v1.2.1 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Compiling current_platform v0.2.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking avif-serialize v0.8.6 [INFO] [stderr] Checking fdeflate v0.3.7 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking zune-core v0.5.0 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking is-terminal v0.4.17 [INFO] [stderr] Checking zune-jpeg v0.5.7 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking semver v1.0.27 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.31 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking zerocopy v0.8.31 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking clap v4.5.53 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking cargo-platform v0.3.1 [INFO] [stderr] Checking toml v0.5.11 [INFO] [stderr] Checking cargo_metadata v0.23.1 [INFO] [stderr] Checking cargo-subcommand v0.12.0 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking cargo-piston v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | release: release, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | cwd: cwd, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:299:13 [INFO] [stdout] | [INFO] [stdout] 299 | build_path: build_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | icon_path: icon_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | cargo_path: cargo_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | gpg_path: gpg_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | app_name: app_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:305:13 [INFO] [stdout] | [INFO] [stdout] 305 | lib_name: lib_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | app_version: app_version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | manifest: manifest, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | manifest_path: manifest_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 313 | build_tools_version: build_tools_version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_tools_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | key_id: key_id, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | key_pass: key_pass, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/ios.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:55:94 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | ... Ok(IOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: car... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:69 [INFO] [stdout] | [INFO] [stdout] 90 | ... Ok(IOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: car... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:98 [INFO] [stdout] | [INFO] [stdout] 90 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:120 [INFO] [stdout] | [INFO] [stdout] 90 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, mi... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:144 [INFO] [stdout] | [INFO] [stdout] 90 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:164 [INFO] [stdout] | [INFO] [stdout] 90 | ...: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_p... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:190 [INFO] [stdout] | [INFO] [stdout] 90 | ... app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:212 [INFO] [stdout] | [INFO] [stdout] 90 | ...rsion, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_os_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:244 [INFO] [stdout] | [INFO] [stdout] 90 | ...e_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | ... Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:71 [INFO] [stdout] | [INFO] [stdout] 70 | ... Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:100 [INFO] [stdout] | [INFO] [stdout] 70 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:122 [INFO] [stdout] | [INFO] [stdout] 70 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homeb... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:146 [INFO] [stdout] | [INFO] [stdout] 70 | ...h: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:166 [INFO] [stdout] | [INFO] [stdout] 70 | ...argo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, ke... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zigbuild_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:196 [INFO] [stdout] | [INFO] [stdout] 70 | ... zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `homebrew_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:226 [INFO] [stdout] | [INFO] [stdout] 70 | ...d_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:246 [INFO] [stdout] | [INFO] [stdout] 70 | ...path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:262 [INFO] [stdout] | [INFO] [stdout] 70 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:27:94 [INFO] [stdout] | [INFO] [stdout] 27 | return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | ... Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:71 [INFO] [stdout] | [INFO] [stdout] 59 | ... Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:100 [INFO] [stdout] | [INFO] [stdout] 59 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:122 [INFO] [stdout] | [INFO] [stdout] 59 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:146 [INFO] [stdout] | [INFO] [stdout] 59 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:166 [INFO] [stdout] | [INFO] [stdout] 59 | ...: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:192 [INFO] [stdout] | [INFO] [stdout] 59 | ...: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | ... Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:73 [INFO] [stdout] | [INFO] [stdout] 65 | ... Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:102 [INFO] [stdout] | [INFO] [stdout] 65 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:124 [INFO] [stdout] | [INFO] [stdout] 65 | ... icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, ke... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `embed_resources_ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:164 [INFO] [stdout] | [INFO] [stdout] 65 | ..._resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:188 [INFO] [stdout] | [INFO] [stdout] 65 | ...resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:208 [INFO] [stdout] | [INFO] [stdout] 65 | ...path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:228 [INFO] [stdout] | [INFO] [stdout] 65 | ... gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:244 [INFO] [stdout] | [INFO] [stdout] 65 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:296:13 [INFO] [stdout] | [INFO] [stdout] 296 | release: release, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:298:13 [INFO] [stdout] | [INFO] [stdout] 298 | cwd: cwd, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:299:13 [INFO] [stdout] | [INFO] [stdout] 299 | build_path: build_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:301:13 [INFO] [stdout] | [INFO] [stdout] 301 | icon_path: icon_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:302:13 [INFO] [stdout] | [INFO] [stdout] 302 | cargo_path: cargo_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:303:13 [INFO] [stdout] | [INFO] [stdout] 303 | gpg_path: gpg_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:304:13 [INFO] [stdout] | [INFO] [stdout] 304 | app_name: app_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:305:13 [INFO] [stdout] | [INFO] [stdout] 305 | lib_name: lib_name, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `lib_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:306:13 [INFO] [stdout] | [INFO] [stdout] 306 | app_version: app_version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:307:13 [INFO] [stdout] | [INFO] [stdout] 307 | manifest: manifest, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:308:13 [INFO] [stdout] | [INFO] [stdout] 308 | manifest_path: manifest_path, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `manifest_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:313:13 [INFO] [stdout] | [INFO] [stdout] 313 | build_tools_version: build_tools_version, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `build_tools_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:315:13 [INFO] [stdout] | [INFO] [stdout] 315 | key_id: key_id, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/android.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | key_pass: key_pass, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `serde_json::Value` [INFO] [stdout] --> src/ios.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use serde_json::Value; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:55:94 [INFO] [stdout] | [INFO] [stdout] 55 | return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:23 [INFO] [stdout] | [INFO] [stdout] 90 | ... Ok(IOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: car... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:69 [INFO] [stdout] | [INFO] [stdout] 90 | ... Ok(IOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: car... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:98 [INFO] [stdout] | [INFO] [stdout] 90 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:120 [INFO] [stdout] | [INFO] [stdout] 90 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, mi... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:144 [INFO] [stdout] | [INFO] [stdout] 90 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:164 [INFO] [stdout] | [INFO] [stdout] 90 | ...: cargo_path, app_name: app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_p... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:190 [INFO] [stdout] | [INFO] [stdout] 90 | ... app_name, app_version: app_version, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `bundle_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:212 [INFO] [stdout] | [INFO] [stdout] 90 | ...rsion, bundle_id: bundle_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `min_os_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/ios.rs:90:244 [INFO] [stdout] | [INFO] [stdout] 90 | ...e_id, min_os_version: min_os_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:25 [INFO] [stdout] | [INFO] [stdout] 70 | ... Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:71 [INFO] [stdout] | [INFO] [stdout] 70 | ... Ok(LinuxBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:100 [INFO] [stdout] | [INFO] [stdout] 70 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:122 [INFO] [stdout] | [INFO] [stdout] 70 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homeb... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:146 [INFO] [stdout] | [INFO] [stdout] 70 | ...h: icon_path, cargo_path: cargo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: a... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:166 [INFO] [stdout] | [INFO] [stdout] 70 | ...argo_path, gpg_path: gpg_path, zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, ke... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `zigbuild_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:196 [INFO] [stdout] | [INFO] [stdout] 70 | ... zigbuild_path: zigbuild_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `homebrew_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:226 [INFO] [stdout] | [INFO] [stdout] 70 | ...d_path, homebrew_path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:246 [INFO] [stdout] | [INFO] [stdout] 70 | ...path: homebrew_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/linux.rs:70:262 [INFO] [stdout] | [INFO] [stdout] 70 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:27:94 [INFO] [stdout] | [INFO] [stdout] 27 | return Err(PistonError::UnsupportedOSError{os: std::env::consts::OS.to_string(), target: target}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `target` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:25 [INFO] [stdout] | [INFO] [stdout] 59 | ... Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:71 [INFO] [stdout] | [INFO] [stdout] 59 | ... Ok(MacOSBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: c... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:100 [INFO] [stdout] | [INFO] [stdout] 59 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, ... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:122 [INFO] [stdout] | [INFO] [stdout] 59 | ..._path: None, icon_path: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:146 [INFO] [stdout] | [INFO] [stdout] 59 | ...h: icon_path, cargo_path: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:166 [INFO] [stdout] | [INFO] [stdout] 59 | ...: cargo_path, app_name: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `app_version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/macos.rs:59:192 [INFO] [stdout] | [INFO] [stdout] 59 | ...: app_name, app_version: app_version, key_path: key_path}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:27 [INFO] [stdout] | [INFO] [stdout] 65 | ... Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou... [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `release` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:73 [INFO] [stdout] | [INFO] [stdout] 65 | ... Ok(WindowsBuilder{release: release, target: target.to_string(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resou... [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cwd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:102 [INFO] [stdout] | [INFO] [stdout] 65 | ...ring(), cwd: cwd, output_path: None, icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_pa... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `icon_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:124 [INFO] [stdout] | [INFO] [stdout] 65 | ... icon_path: icon_path, embed_resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, ke... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `embed_resources_ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:164 [INFO] [stdout] | [INFO] [stdout] 65 | ..._resources_ok: embed_resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `cargo_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:188 [INFO] [stdout] | [INFO] [stdout] 65 | ...resources_ok, cargo_path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `gpg_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:208 [INFO] [stdout] | [INFO] [stdout] 65 | ...path: cargo_path, gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `app_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:228 [INFO] [stdout] | [INFO] [stdout] 65 | ... gpg_path: gpg_path, app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `key_id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/windows.rs:65:244 [INFO] [stdout] | [INFO] [stdout] 65 | ..., app_name: app_name, key_id: key_id, key_pass: key_pass}) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `key_pass` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base_zip` [INFO] [stdout] --> src/android.rs:601:41 [INFO] [stdout] | [INFO] [stdout] 601 | fn zip_base(&self, base_dir: &Path, base_zip: &Path) -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_zip` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `base_zip` [INFO] [stdout] --> src/android.rs:601:41 [INFO] [stdout] | [INFO] [stdout] 601 | fn zip_base(&self, base_dir: &Path, base_zip: &Path) -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_base_zip` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/ios.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | ... .map_err(|e| PistonError::XcodeBuildError("Failed to run xcodebuild -showsdks. Something is likely missing from your installa... [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/ios.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | .map_err(|e| PistonError::XcodeSelectInstallError("Failed to verify xcode tools installation".to_string())); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/ios.rs:125:23 [INFO] [stdout] | [INFO] [stdout] 125 | ... .map_err(|e| PistonError::XcodeBuildError("Failed to run xcodebuild -showsdks. Something is likely missing from your installa... [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `e` [INFO] [stdout] --> src/ios.rs:107:23 [INFO] [stdout] | [INFO] [stdout] 107 | .map_err(|e| PistonError::XcodeSelectInstallError("Failed to verify xcode tools installation".to_string())); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_e` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cargo_path`, `gpg_path`, `app_version`, `key_id`, and `key_pass` are never read [INFO] [stdout] --> src/android.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 220 | pub struct AndroidBuilder { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 227 | cargo_path: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 228 | gpg_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 231 | app_version: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | key_id: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 241 | key_pass: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AndroidRunner` is never constructed [INFO] [stdout] --> src/android.rs:663:8 [INFO] [stdout] | [INFO] [stdout] 663 | struct AndroidRunner{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/android.rs:668:8 [INFO] [stdout] | [INFO] [stdout] 667 | impl AndroidRunner{ [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 668 | fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `IOSMetadata` is never constructed [INFO] [stdout] --> src/ios.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct IOSMetadata { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_path` is never read [INFO] [stdout] --> src/ios.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct IOSBuilder { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | key_path: Option [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `IOSRunner` is never constructed [INFO] [stdout] --> src/ios.rs:282:8 [INFO] [stdout] | [INFO] [stdout] 282 | struct IOSRunner{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `start` and `new` are never used [INFO] [stdout] --> src/ios.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 286 | impl IOSRunner { [INFO] [stdout] | -------------- associated functions in this implementation [INFO] [stdout] 287 | [INFO] [stdout] 288 | pub fn start() -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `icon_path` is never read [INFO] [stdout] --> src/linux.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct LinuxBuilder { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | icon_path: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LinuxRunner` is never constructed [INFO] [stdout] --> src/linux.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | struct LinuxRunner{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/linux.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 164 | impl LinuxRunner{ [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 165 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_path` is never read [INFO] [stdout] --> src/macos.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MacOSBuilder { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | key_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MacOSRunner` is never constructed [INFO] [stdout] --> src/macos.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 210 | struct MacOSRunner{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `start` and `new` are never used [INFO] [stdout] --> src/macos.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 214 | impl MacOSRunner { [INFO] [stdout] | ---------------- associated functions in this implementation [INFO] [stdout] 215 | [INFO] [stdout] 216 | pub fn start() -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 230 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `gpg_path`, `key_id`, and `key_pass` are never read [INFO] [stdout] --> src/windows.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct WindowsBuilder { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | gpg_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | app_name: String, [INFO] [stdout] 21 | key_id: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | key_pass: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `cargo_path`, `gpg_path`, `app_version`, `key_id`, and `key_pass` are never read [INFO] [stdout] --> src/android.rs:227:5 [INFO] [stdout] | [INFO] [stdout] 220 | pub struct AndroidBuilder { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 227 | cargo_path: String, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 228 | gpg_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 231 | app_version: String, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 240 | key_id: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 241 | key_pass: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AndroidRunner` is never constructed [INFO] [stdout] --> src/android.rs:663:8 [INFO] [stdout] | [INFO] [stdout] 663 | struct AndroidRunner{ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/android.rs:668:8 [INFO] [stdout] | [INFO] [stdout] 667 | impl AndroidRunner{ [INFO] [stdout] | ------------------ associated function in this implementation [INFO] [stdout] 668 | fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `IOSMetadata` is never constructed [INFO] [stdout] --> src/ios.rs:29:8 [INFO] [stdout] | [INFO] [stdout] 29 | struct IOSMetadata { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_path` is never read [INFO] [stdout] --> src/ios.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 35 | pub struct IOSBuilder { [INFO] [stdout] | ---------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 46 | key_path: Option [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `IOSRunner` is never constructed [INFO] [stdout] --> src/ios.rs:282:8 [INFO] [stdout] | [INFO] [stdout] 282 | struct IOSRunner{ [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `start` and `new` are never used [INFO] [stdout] --> src/ios.rs:288:12 [INFO] [stdout] | [INFO] [stdout] 286 | impl IOSRunner { [INFO] [stdout] | -------------- associated functions in this implementation [INFO] [stdout] 287 | [INFO] [stdout] 288 | pub fn start() -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | fn new() -> Self{ [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `icon_path` is never read [INFO] [stdout] --> src/linux.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct LinuxBuilder { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 15 | icon_path: Option, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `LinuxRunner` is never constructed [INFO] [stdout] --> src/linux.rs:160:8 [INFO] [stdout] | [INFO] [stdout] 160 | struct LinuxRunner{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `new` is never used [INFO] [stdout] --> src/linux.rs:165:8 [INFO] [stdout] | [INFO] [stdout] 164 | impl LinuxRunner{ [INFO] [stdout] | ---------------- associated function in this implementation [INFO] [stdout] 165 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `key_path` is never read [INFO] [stdout] --> src/macos.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 10 | pub struct MacOSBuilder { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | key_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `MacOSRunner` is never constructed [INFO] [stdout] --> src/macos.rs:210:8 [INFO] [stdout] | [INFO] [stdout] 210 | struct MacOSRunner{ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated functions `start` and `new` are never used [INFO] [stdout] --> src/macos.rs:216:12 [INFO] [stdout] | [INFO] [stdout] 214 | impl MacOSRunner { [INFO] [stdout] | ---------------- associated functions in this implementation [INFO] [stdout] 215 | [INFO] [stdout] 216 | pub fn start() -> Result<(), PistonError> { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 230 | fn new() -> Self { [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `gpg_path`, `key_id`, and `key_pass` are never read [INFO] [stdout] --> src/windows.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 11 | pub struct WindowsBuilder { [INFO] [stdout] | -------------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 19 | gpg_path: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 20 | app_name: String, [INFO] [stdout] 21 | key_id: Option, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 22 | key_pass: Option, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/android.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / manifest.package = android_meta.package [INFO] [stdout] 140 | | .unwrap_or(format!("com.example.{}", crate_name)); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `android::AndroidManifest { package: android_meta.package [INFO] [stdout] .unwrap_or(format!("com.example.{}", crate_name)), version_code: android_meta.version_code [INFO] [stdout] .unwrap_or(1), version_name: android_meta.version_name [INFO] [stdout] .unwrap_or("1.0".to_string()), min_sdk_version: android_meta.min_sdk_version [INFO] [stdout] .unwrap_or(21), target_sdk_version: android_meta.target_sdk_version [INFO] [stdout] .unwrap_or(34), app_label: android_meta.label [INFO] [stdout] .unwrap_or(format!("{} App", crate_name)), app_name: app_name.to_string(), icon: "@mipmap/ic_launcher".to_string() }` and removing relevant reassignments [INFO] [stdout] --> src/android.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let mut manifest = Self::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/android.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | let file = File::create(&dir) [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:272:75 [INFO] [stdout] | [INFO] [stdout] 272 | let build_tools_version: String = Helper::get_build_tools_version(&sdk_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `sdk_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/android.rs:139:9 [INFO] [stdout] | [INFO] [stdout] 139 | / manifest.package = android_meta.package [INFO] [stdout] 140 | | .unwrap_or(format!("com.example.{}", crate_name)); [INFO] [stdout] | |______________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `android::AndroidManifest { package: android_meta.package [INFO] [stdout] .unwrap_or(format!("com.example.{}", crate_name)), version_code: android_meta.version_code [INFO] [stdout] .unwrap_or(1), version_name: android_meta.version_name [INFO] [stdout] .unwrap_or("1.0".to_string()), min_sdk_version: android_meta.min_sdk_version [INFO] [stdout] .unwrap_or(21), target_sdk_version: android_meta.target_sdk_version [INFO] [stdout] .unwrap_or(34), app_label: android_meta.label [INFO] [stdout] .unwrap_or(format!("{} App", crate_name)), app_name: app_name.to_string(), icon: "@mipmap/ic_launcher".to_string() }` and removing relevant reassignments [INFO] [stdout] --> src/android.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | let mut manifest = Self::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:294:27 [INFO] [stdout] | [INFO] [stdout] 294 | manifest.write_to(&manifest_path.as_path())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `manifest_path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:384:28 [INFO] [stdout] | [INFO] [stdout] 384 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &hdpi_target.display().to_string(), 48, 48)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:386:28 [INFO] [stdout] | [INFO] [stdout] 386 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &mdpi_target.display().to_string(), 72, 72)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:388:28 [INFO] [stdout] | [INFO] [stdout] 388 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xhdpi_target.display().to_string(), 96, 96)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:390:28 [INFO] [stdout] | [INFO] [stdout] 390 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxhdpi_target.display().to_string(), 144, 144)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:392:28 [INFO] [stdout] | [INFO] [stdout] 392 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxxhdpi_target.display().to_string(), 192, 192)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/android.rs:201:33 [INFO] [stdout] | [INFO] [stdout] 201 | let file = File::create(&dir) [INFO] [stdout] | ^^^^ help: change this to: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:272:75 [INFO] [stdout] | [INFO] [stdout] 272 | let build_tools_version: String = Helper::get_build_tools_version(&sdk_path)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `sdk_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:294:27 [INFO] [stdout] | [INFO] [stdout] 294 | manifest.write_to(&manifest_path.as_path())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `manifest_path.as_path()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:384:28 [INFO] [stdout] | [INFO] [stdout] 384 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &hdpi_target.display().to_string(), 48, 48)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:386:28 [INFO] [stdout] | [INFO] [stdout] 386 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &mdpi_target.display().to_string(), 72, 72)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:388:28 [INFO] [stdout] | [INFO] [stdout] 388 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xhdpi_target.display().to_string(), 96, 96)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:390:28 [INFO] [stdout] | [INFO] [stdout] 390 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxhdpi_target.display().to_string(), 144, 144)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/android.rs:392:28 [INFO] [stdout] | [INFO] [stdout] 392 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &xxxhdpi_target.display().to_string(), 192, 192)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/android.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | remove_file(&aab_path).map_err(|e| PistonError::RemoveFileError { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `aab_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ios.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/ios.rs:235:33 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 235 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/ios.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 237 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ios.rs:140:53 [INFO] [stdout] | [INFO] [stdout] 140 | let partial_path: PathBuf = if self.release { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 141 | | format!("target/{}/ios/{}.app",release, capitalized).into() [INFO] [stdout] 142 | | }else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ios.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | }else { [INFO] [stdout] | _______________^ [INFO] [stdout] 143 | | format!("target/{}/ios/{}.app",release, capitalized).into() [INFO] [stdout] 144 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/android.rs:632:25 [INFO] [stdout] | [INFO] [stdout] 632 | remove_file(&aab_path).map_err(|e| PistonError::RemoveFileError { [INFO] [stdout] | ^^^^^^^^^ help: change this to: `aab_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ios.rs:235:32 [INFO] [stdout] | [INFO] [stdout] 235 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ios.rs:237:32 [INFO] [stdout] | [INFO] [stdout] 237 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ios.rs:231:12 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/ios.rs:235:33 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 235 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/ios.rs:237:33 [INFO] [stdout] | [INFO] [stdout] 231 | if !self.icon_path.is_none(){ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 237 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/ios.rs:140:53 [INFO] [stdout] | [INFO] [stdout] 140 | let partial_path: PathBuf = if self.release { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 141 | | format!("target/{}/ios/{}.app",release, capitalized).into() [INFO] [stdout] 142 | | }else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/ios.rs:142:15 [INFO] [stdout] | [INFO] [stdout] 142 | }else { [INFO] [stdout] | _______________^ [INFO] [stdout] 143 | | format!("target/{}/ios/{}.app",release, capitalized).into() [INFO] [stdout] 144 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ios.rs:235:32 [INFO] [stdout] | [INFO] [stdout] 235 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path120.display().to_string(), 120, 120)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/ios.rs:237:32 [INFO] [stdout] | [INFO] [stdout] 237 | Helper::resize_png(&self.icon_path.as_ref().unwrap(), &icon_path180.display().to_string(), 180, 180)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.icon_path.as_ref().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macos.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 149 | if !self.icon_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/macos.rs:76:53 [INFO] [stdout] | [INFO] [stdout] 76 | let partial_path: PathBuf = if self.release { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 77 | | format!("target/{}/macos/{}.app/Contents",release, capitalized).into() [INFO] [stdout] 78 | | }else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/macos.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 78 | }else { [INFO] [stdout] | _______________^ [INFO] [stdout] 79 | | format!("target/{}/macos/{}.app/Contents",release, capitalized).into() [INFO] [stdout] 80 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/windows.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | if !self.icon_path.is_none() && self.embed_resources_ok{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/windows.rs:135:69 [INFO] [stdout] | [INFO] [stdout] 99 | if !self.icon_path.is_none() && self.embed_resources_ok{ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 135 | println!("Converted {} to ICO ({}x{}) and saved as {}", self.icon_path.as_ref().unwrap(), 64, 64, icon_output.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/macos.rs:149:12 [INFO] [stdout] | [INFO] [stdout] 149 | if !self.icon_path.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/macos.rs:76:53 [INFO] [stdout] | [INFO] [stdout] 76 | let partial_path: PathBuf = if self.release { [INFO] [stdout] | _____________________________________________________^ [INFO] [stdout] 77 | | format!("target/{}/macos/{}.app/Contents",release, capitalized).into() [INFO] [stdout] 78 | | }else { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/macos.rs:78:15 [INFO] [stdout] | [INFO] [stdout] 78 | }else { [INFO] [stdout] | _______________^ [INFO] [stdout] 79 | | format!("target/{}/macos/{}.app/Contents",release, capitalized).into() [INFO] [stdout] 80 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/windows.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 134 | ).map_err(|e| PistonError::WriteImageError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `PistonError::WriteImageError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | .arg(&target_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `target_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/windows.rs:99:12 [INFO] [stdout] | [INFO] [stdout] 99 | if !self.icon_path.is_none() && self.embed_resources_ok{ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.icon_path.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.icon_path` after checking its variant with `is_none` [INFO] [stdout] --> src/windows.rs:135:69 [INFO] [stdout] | [INFO] [stdout] 99 | if !self.icon_path.is_none() && self.embed_resources_ok{ [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 135 | println!("Converted {} to ICO ({}x{}) and saved as {}", self.icon_path.as_ref().unwrap(), 64, 64, icon_output.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() { [INFO] [stdout] 136 | | if let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 137 | | host_dirs.push(name.to_string()); [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() [INFO] [stdout] 136 ~ && let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 137 | host_dirs.push(name.to_string()); [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/windows.rs:134:23 [INFO] [stdout] | [INFO] [stdout] 134 | ).map_err(|e| PistonError::WriteImageError(e))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `PistonError::WriteImageError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() { [INFO] [stdout] 162 | | if let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 163 | | host_dirs.push(name.to_string()); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() [INFO] [stdout] 162 ~ && let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 163 | host_dirs.push(name.to_string()); [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/helper.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | if key_id.is_none() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 241 | | return false [INFO] [stdout] 242 | | }else if gpg_bin.is_none() { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/helper.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | }else if gpg_bin.is_none() { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 243 | | return false [INFO] [stdout] 244 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/helper.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | / match output { [INFO] [stdout] 251 | | Ok(o) if o.status.success() => true, [INFO] [stdout] 252 | | _=> false, [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 250 - match output { [INFO] [stdout] 251 - Ok(o) if o.status.success() => true, [INFO] [stdout] 252 - _=> false, [INFO] [stdout] 253 - } [INFO] [stdout] 250 + matches!(output, Ok(o) if o.status.success()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()); [INFO] [stdout] 309 + format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/helper.rs:256:110 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn gpg_sign(key_id: Option, key_pass: Option, gpg_path: Option, bundle_path: &PathBuf) -> String{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 256 ~ pub fn gpg_sign(key_id: Option, key_pass: Option, gpg_path: Option, bundle_path: &Path) -> String{ [INFO] [stdout] 257 | //prepare signature path: .asc [INFO] [stdout] 258 ~ let mut sig_path = bundle_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | .arg(&key_id.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:279:18 [INFO] [stdout] | [INFO] [stdout] 279 | .arg(&bundle_path.display().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | / if let Some(pass) = key_pass { [INFO] [stdout] 292 | | if let Some(mut stdin) = child.stdin.take() { [INFO] [stdout] 293 | | match stdin.write(pass.as_bytes()) { [INFO] [stdout] 294 | | Ok(res) => res, [INFO] [stdout] ... | [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 291 ~ if let Some(pass) = key_pass [INFO] [stdout] 292 ~ && let Some(mut stdin) = child.stdin.take() { [INFO] [stdout] 293 | match stdin.write(pass.as_bytes()) { [INFO] [stdout] ... [INFO] [stdout] 296 | }; [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/helper.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 306 | return format!("GPG signing failed: {}", err_msg).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | .arg(&target_name) [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `target_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | / if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() { [INFO] [stdout] 136 | | if let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 137 | | host_dirs.push(name.to_string()); [INFO] [stdout] 138 | | } [INFO] [stdout] 139 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 135 ~ if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() [INFO] [stdout] 136 ~ && let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 137 | host_dirs.push(name.to_string()); [INFO] [stdout] 138 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:161:13 [INFO] [stdout] | [INFO] [stdout] 161 | / if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() { [INFO] [stdout] 162 | | if let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 163 | | host_dirs.push(name.to_string()); [INFO] [stdout] 164 | | } [INFO] [stdout] 165 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 161 ~ if entry.file_type().map_err(|e| PistonError::BuildError(format!("File type error: {}", e)))?.is_dir() [INFO] [stdout] 162 ~ && let Some(name) = entry.file_name().to_str() { [INFO] [stdout] 163 | host_dirs.push(name.to_string()); [INFO] [stdout] 164 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/helper.rs:240:29 [INFO] [stdout] | [INFO] [stdout] 240 | if key_id.is_none() { [INFO] [stdout] | _____________________________^ [INFO] [stdout] 241 | | return false [INFO] [stdout] 242 | | }else if gpg_bin.is_none() { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/helper.rs:242:36 [INFO] [stdout] | [INFO] [stdout] 242 | }else if gpg_bin.is_none() { [INFO] [stdout] | ____________________________________^ [INFO] [stdout] 243 | | return false [INFO] [stdout] 244 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/helper.rs:250:9 [INFO] [stdout] | [INFO] [stdout] 250 | / match output { [INFO] [stdout] 251 | | Ok(o) if o.status.success() => true, [INFO] [stdout] 252 | | _=> false, [INFO] [stdout] 253 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 250 - match output { [INFO] [stdout] 251 - Ok(o) if o.status.success() => true, [INFO] [stdout] 252 - _=> false, [INFO] [stdout] 253 - } [INFO] [stdout] 250 + matches!(output, Ok(o) if o.status.success()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/helper.rs:309:9 [INFO] [stdout] | [INFO] [stdout] 309 | return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 309 - return format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()); [INFO] [stdout] 309 + format!("successfully signed {} with signature at {:?}", bundle_path.display(), sig_path.display()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/helper.rs:256:110 [INFO] [stdout] | [INFO] [stdout] 256 | pub fn gpg_sign(key_id: Option, key_pass: Option, gpg_path: Option, bundle_path: &PathBuf) -> String{ [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 256 ~ pub fn gpg_sign(key_id: Option, key_pass: Option, gpg_path: Option, bundle_path: &Path) -> String{ [INFO] [stdout] 257 | //prepare signature path: .asc [INFO] [stdout] 258 ~ let mut sig_path = bundle_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:276:18 [INFO] [stdout] | [INFO] [stdout] 276 | .arg(&key_id.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `key_id.unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/helper.rs:279:18 [INFO] [stdout] | [INFO] [stdout] 279 | .arg(&bundle_path.display().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `bundle_path.display().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/helper.rs:291:9 [INFO] [stdout] | [INFO] [stdout] 291 | / if let Some(pass) = key_pass { [INFO] [stdout] 292 | | if let Some(mut stdin) = child.stdin.take() { [INFO] [stdout] 293 | | match stdin.write(pass.as_bytes()) { [INFO] [stdout] 294 | | Ok(res) => res, [INFO] [stdout] ... | [INFO] [stdout] 298 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 291 ~ if let Some(pass) = key_pass [INFO] [stdout] 292 ~ && let Some(mut stdin) = child.stdin.take() { [INFO] [stdout] 293 | match stdin.write(pass.as_bytes()) { [INFO] [stdout] ... [INFO] [stdout] 296 | }; [INFO] [stdout] 297 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/helper.rs:306:20 [INFO] [stdout] | [INFO] [stdout] 306 | return format!("GPG signing failed: {}", err_msg).into(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `format!("GPG signing failed: {}", err_msg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.device` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:312:69 [INFO] [stdout] | [INFO] [stdout] 308 | if args.device.is_none() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = args.device` [INFO] [stdout] ... [INFO] [stdout] 312 | println!("run orders received for a target device: {}", args.device.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 267 | / let value = stdout_str.lines() [INFO] [stdout] 268 | | .find(|line| line.starts_with("host:")) [INFO] [stdout] 269 | | .map(|line| line.trim_start_matches("host: ").trim().to_string()) [INFO] [stdout] 270 | | .unwrap_or_else(|| "Unknown".to_string()); [INFO] [stdout] | |__________________________________________________________- unnecessary `let` binding [INFO] [stdout] 271 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 267 ~ [INFO] [stdout] 268 ~ stdout_str.lines() [INFO] [stdout] 269 + .find(|line| line.starts_with("host:")) [INFO] [stdout] 270 + .map(|line| line.trim_start_matches("host: ").trim().to_string()) [INFO] [stdout] 271 + .unwrap_or_else(|| "Unknown".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `args.device` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:312:69 [INFO] [stdout] | [INFO] [stdout] 308 | if args.device.is_none() { [INFO] [stdout] | ------------------------ help: try: `if let Some() = args.device` [INFO] [stdout] ... [INFO] [stdout] 312 | println!("run orders received for a target device: {}", args.device.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:271:13 [INFO] [stdout] | [INFO] [stdout] 267 | / let value = stdout_str.lines() [INFO] [stdout] 268 | | .find(|line| line.starts_with("host:")) [INFO] [stdout] 269 | | .map(|line| line.trim_start_matches("host: ").trim().to_string()) [INFO] [stdout] 270 | | .unwrap_or_else(|| "Unknown".to_string()); [INFO] [stdout] | |__________________________________________________________- unnecessary `let` binding [INFO] [stdout] 271 | value [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 267 ~ [INFO] [stdout] 268 ~ stdout_str.lines() [INFO] [stdout] 269 + .find(|line| line.starts_with("host:")) [INFO] [stdout] 270 + .map(|line| line.trim_start_matches("host: ").trim().to_string()) [INFO] [stdout] 271 + .unwrap_or_else(|| "Unknown".to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.62s [INFO] running `Command { std: "docker" "inspect" "8561674dee9e74ddd4f55e3a26bf51008daff2305e61bda7a0626ac16e5c687d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8561674dee9e74ddd4f55e3a26bf51008daff2305e61bda7a0626ac16e5c687d", kill_on_drop: false }` [INFO] [stdout] 8561674dee9e74ddd4f55e3a26bf51008daff2305e61bda7a0626ac16e5c687d