[INFO] fetching crate cardito 0.2.5...
[INFO] linting cardito-0.2.5 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate cardito 0.2.5 into /workspace/builds/worker-2-tc1/source
[INFO] started tweaking crates.io crate cardito 0.2.5
[INFO] finished tweaking crates.io crate cardito 0.2.5
[INFO] tweaked toml for crates.io crate cardito 0.2.5 written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate cardito 0.2.5 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] crate crates.io crate cardito 0.2.5 already has a lockfile, it will not be regenerated
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]  Downloading crates ...
[INFO] [stderr]   Downloaded card_format v0.2.1
[INFO] [stderr]   Downloaded imagesize v0.8.8
[INFO] [stderr]   Downloaded clone_dyn_types v0.26.0
[INFO] [stderr]   Downloaded err_tools v0.1.1
[INFO] [stderr]   Downloaded tokenate v0.1.0
[INFO] [stderr]   Downloaded iter_tools v0.24.0
[INFO] [stderr]   Downloaded gobble v0.6.3
[INFO] [stderr]   Downloaded templito v0.4.11
[INFO] [stderr]   Downloaded pulldown-cmark v0.7.2
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] 0323e0c9c78bd0f2e1f6251c69e00f778dc579ecae0f3c62bca7b308a36fb794
[INFO] running `Command { std: "docker" "start" "-a" "0323e0c9c78bd0f2e1f6251c69e00f778dc579ecae0f3c62bca7b308a36fb794", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "0323e0c9c78bd0f2e1f6251c69e00f778dc579ecae0f3c62bca7b308a36fb794", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "0323e0c9c78bd0f2e1f6251c69e00f778dc579ecae0f3c62bca7b308a36fb794", kill_on_drop: false }`
[INFO] [stdout] 0323e0c9c78bd0f2e1f6251c69e00f778dc579ecae0f3c62bca7b308a36fb794
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 801df77f9644af4f90a7913f8077fcbe7e07e2ee360ea75d5720b042d4fd86e7
[INFO] running `Command { std: "docker" "start" "-a" "801df77f9644af4f90a7913f8077fcbe7e07e2ee360ea75d5720b042d4fd86e7", kill_on_drop: false }`
[INFO] [stderr]    Compiling proc-macro2 v1.0.94
[INFO] [stderr]    Compiling libc v0.2.171
[INFO] [stderr]    Compiling num-traits v0.2.19
[INFO] [stderr]    Compiling zerocopy v0.8.24
[INFO] [stderr]    Compiling serde v1.0.219
[INFO] [stderr]    Compiling miniz_oxide v0.4.4
[INFO] [stderr]    Compiling anyhow v1.0.97
[INFO] [stderr]     Checking adler32 v1.2.0
[INFO] [stderr]    Compiling num-rational v0.3.2
[INFO] [stderr]     Checking weezl v0.1.8
[INFO] [stderr]     Checking deflate v0.8.6
[INFO] [stderr]     Checking jpeg-decoder v0.1.22
[INFO] [stderr]     Checking miniz_oxide v0.3.7
[INFO] [stderr]    Compiling quote v1.0.40
[INFO] [stderr]     Checking getrandom v0.1.16
[INFO] [stderr]    Compiling indexmap v1.9.3
[INFO] [stderr]    Compiling pulldown-cmark v0.7.2
[INFO] [stderr]     Checking getopts v0.2.21
[INFO] [stderr]     Checking num-integer v0.1.46
[INFO] [stderr]     Checking rand_core v0.5.1
[INFO] [stderr]     Checking gif v0.11.4
[INFO] [stderr]     Checking png v0.16.8
[INFO] [stderr]    Compiling syn v2.0.100
[INFO] [stderr]     Checking tiff v0.6.1
[INFO] [stderr]     Checking itertools v0.11.0
[INFO] [stderr]     Checking num-iter v0.1.45
[INFO] [stderr]     Checking scoped_threadpool v0.1.9
[INFO] [stderr]     Checking clone_dyn_types v0.26.0
[INFO] [stderr]     Checking tokenate v0.1.0
[INFO] [stderr]     Checking bytemuck v1.22.0
[INFO] [stderr]     Checking chrono v0.4.40
[INFO] [stderr]     Checking image v0.23.14
[INFO] [stderr]     Checking atty v0.2.14
[INFO] [stderr]     Checking once_cell v1.21.1
[INFO] [stderr]     Checking ppv-lite86 v0.2.21
[INFO] [stderr]     Checking textwrap v0.16.2
[INFO] [stderr]     Checking imagesize v0.8.8
[INFO] [stderr]     Checking clap v3.2.25
[INFO] [stderr]     Checking iter_tools v0.24.0
[INFO] [stderr]     Checking rand_chacha v0.2.2
[INFO] [stderr]     Checking rand v0.7.3
[INFO] [stderr]     Checking serde_json v1.0.140
[INFO] [stderr]     Checking toml v0.5.11
[INFO] [stderr]    Compiling thiserror-impl v1.0.69
[INFO] [stderr]    Compiling serde_derive v1.0.219
[INFO] [stderr]     Checking thiserror v1.0.69
[INFO] [stderr]     Checking err_tools v0.1.1
[INFO] [stderr]     Checking gobble v0.6.3
[INFO] [stderr]     Checking card_format v0.2.1
[INFO] [stderr]     Checking templito v0.4.11
[INFO] [stderr]     Checking cardito v0.2.5 (/opt/rustwide/workdir)
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/page_builder.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             front: front,
[INFO] [stdout]    |             ^^^^^^^^^^^^ help: replace it with: `front`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/page_builder.rs:17:13
[INFO] [stdout]    |
[INFO] [stdout] 17 |             back: back,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `back`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/template_set.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 | /     ///@return Path of written file
[INFO] [stdout] 109 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 110 |       pub fn build_page_file<'a, IT: Iterator<Item = (usize, (&'a Card, usize, usize))>>(
[INFO] [stdout]     |       ---------------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/templates.rs:4:27
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub const WRAP_SVG_PAGE: &'static str = r##"
[INFO] [stdout]   |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:17:27
[INFO] [stdout]    |
[INFO] [stdout] 17 | pub const WRAP_SVG_CARD: &'static str = r##"{{let u = first .units "mm"}}
[INFO] [stdout]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:22:26
[INFO] [stdout]    |
[INFO] [stdout] 22 | pub const WRAP_PS_FILE: &'static str = r##"%!PS-Adobe-2.0
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:31:26
[INFO] [stdout]    |
[INFO] [stdout] 31 | pub const WRAP_PS_PAGE: &'static str = r##"
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:41:26
[INFO] [stdout]    |
[INFO] [stdout] 41 | pub const WRAP_PS_CARD: &'static str = r##"
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:52:31
[INFO] [stdout]    |
[INFO] [stdout] 52 | pub const WRAP_DEFAULT_FILE: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:57:31
[INFO] [stdout]    |
[INFO] [stdout] 57 | pub const WRAP_DEFAULT_PAGE: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:62:31
[INFO] [stdout]    |
[INFO] [stdout] 62 | pub const WRAP_DEFAULT_CARD: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/page_builder.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             front: front,
[INFO] [stdout]    |             ^^^^^^^^^^^^ help: replace it with: `front`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout]    = note: `#[warn(clippy::redundant_field_names)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: redundant field names in struct initialization
[INFO] [stdout]   --> src/page_builder.rs:17:13
[INFO] [stdout]    |
[INFO] [stdout] 17 |             back: back,
[INFO] [stdout]    |             ^^^^^^^^^^ help: replace it with: `back`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: empty line after doc comment
[INFO] [stdout]    --> src/template_set.rs:108:5
[INFO] [stdout]     |
[INFO] [stdout] 108 | /     ///@return Path of written file
[INFO] [stdout] 109 | |
[INFO] [stdout]     | |_^
[INFO] [stdout] 110 |       pub fn build_page_file<'a, IT: Iterator<Item = (usize, (&'a Card, usize, usize))>>(
[INFO] [stdout]     |       ---------------------- the comment documents this function
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments
[INFO] [stdout]     = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default
[INFO] [stdout]     = help: if the empty line is unintentional, remove it
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]  --> src/templates.rs:4:27
[INFO] [stdout]   |
[INFO] [stdout] 4 | pub const WRAP_SVG_PAGE: &'static str = r##"
[INFO] [stdout]   |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]   |
[INFO] [stdout]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout]   = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:17:27
[INFO] [stdout]    |
[INFO] [stdout] 17 | pub const WRAP_SVG_CARD: &'static str = r##"{{let u = first .units "mm"}}
[INFO] [stdout]    |                          -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:22:26
[INFO] [stdout]    |
[INFO] [stdout] 22 | pub const WRAP_PS_FILE: &'static str = r##"%!PS-Adobe-2.0
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:31:26
[INFO] [stdout]    |
[INFO] [stdout] 31 | pub const WRAP_PS_PAGE: &'static str = r##"
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:41:26
[INFO] [stdout]    |
[INFO] [stdout] 41 | pub const WRAP_PS_CARD: &'static str = r##"
[INFO] [stdout]    |                         -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:52:31
[INFO] [stdout]    |
[INFO] [stdout] 52 | pub const WRAP_DEFAULT_FILE: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:57:31
[INFO] [stdout]    |
[INFO] [stdout] 57 | pub const WRAP_DEFAULT_PAGE: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: constants have by default a `'static` lifetime
[INFO] [stdout]   --> src/templates.rs:62:31
[INFO] [stdout]    |
[INFO] [stdout] 62 | pub const WRAP_DEFAULT_CARD: &'static str = r##"
[INFO] [stdout]    |                              -^^^^^^^---- help: consider removing `'static`: `&str`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::result::Result<build_config::BuildConfig, anyhow::Error>`
[INFO] [stdout]   --> src/build_config.rs:65:36
[INFO] [stdout]    |
[INFO] [stdout] 65 |                     None => return e_str("for --vars keys must have values").into(),
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `e_str("for --vars keys must have values")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:113:12
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if tman.get("page_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("page_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:120:12
[INFO] [stdout]     |
[INFO] [stdout] 120 |         if tman.get("card_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("card_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:127:12
[INFO] [stdout]     |
[INFO] [stdout] 127 |         if tman.get("file_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("file_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/imports.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             return err_tools::e_str("Can only import string and lists of templates");
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -             return err_tools::e_str("Can only import string and lists of templates");
[INFO] [stdout] 16 +             err_tools::e_str("Can only import string and lists of templates")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]   --> src/imports.rs:58:17
[INFO] [stdout]    |
[INFO] [stdout] 58 | /                 for x in dir {
[INFO] [stdout] 59 | |                     if let Ok(f) = x {
[INFO] [stdout] 60 | |                         self.stack.push(f.path());
[INFO] [stdout] 61 | |                     }
[INFO] [stdout] 62 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]   --> src/imports.rs:59:21
[INFO] [stdout]    |
[INFO] [stdout] 59 | /                     if let Ok(f) = x {
[INFO] [stdout] 60 | |                         self.stack.push(f.path());
[INFO] [stdout] 61 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]    = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 58 ~                 for f in dir.flatten() {
[INFO] [stdout] 59 +                     self.stack.push(f.path());
[INFO] [stdout] 60 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         return Self {
[INFO] [stdout] 16 | |             front: front,
[INFO] [stdout] 17 | |             back: back,
[INFO] [stdout] 18 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~         Self {
[INFO] [stdout] 16 +             front: front,
[INFO] [stdout] 17 +             back: back,
[INFO] [stdout] 18 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:32:17
[INFO] [stdout]    |
[INFO] [stdout] 32 |                 return Ok(vec![fname]);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -                 return Ok(vec![fname]);
[INFO] [stdout] 32 +                 Ok(vec![fname])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:35:17
[INFO] [stdout]    |
[INFO] [stdout] 35 |                 return self.build_page_files(cards, bc);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 -                 return self.build_page_files(cards, bc);
[INFO] [stdout] 35 +                 self.build_page_files(cards, bc)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/page_builder.rs:63:16
[INFO] [stdout]    |
[INFO] [stdout] 63 |             if f_res == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `f_res.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/page_builder.rs:97:16
[INFO] [stdout]    |
[INFO] [stdout] 97 |             if f_res == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `f_res.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/page_builder.rs:102:29
[INFO] [stdout]     |
[INFO] [stdout] 102 |         if let Some(wrap) = bc.tman.get("file_wrap").map(|c| c.clone()) {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `bc.tman.get("file_wrap").cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/spread.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         return SpreadIter {
[INFO] [stdout] 12 | |             cards: self.cards,
[INFO] [stdout] 13 | |             n: self.n,
[INFO] [stdout] 14 | |             pos: self.pos,
[INFO] [stdout] 15 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 11 ~         SpreadIter {
[INFO] [stdout] 12 +             cards: self.cards,
[INFO] [stdout] 13 +             n: self.n,
[INFO] [stdout] 14 +             pos: self.pos,
[INFO] [stdout] 15 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `cards.get(0)`
[INFO] [stdout]   --> src/spread.rs:21:17
[INFO] [stdout]    |
[INFO] [stdout] 21 |         let n = cards.get(0).map(|c| c.num).unwrap_or(0);
[INFO] [stdout]    |                 ^^^^^^^^^^^^ help: try: `cards.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> src/templates.rs:84:31
[INFO] [stdout]    |
[INFO] [stdout] 84 |       TreeTemplate::from_str(s).expect(&format!(
[INFO] [stdout]    |  _______________________________^
[INFO] [stdout] 85 | |         "Builtin template should pass: {} - {}",
[INFO] [stdout] 86 | |         wrap_type, format
[INFO] [stdout] 87 | |     ))
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]    = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 84 ~     TreeTemplate::from_str(s).unwrap_or_else(|_| panic!("Builtin template should pass: {} - {}",
[INFO] [stdout] 85 +         wrap_type, format))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: useless conversion to the same type: `std::result::Result<build_config::BuildConfig, anyhow::Error>`
[INFO] [stdout]   --> src/build_config.rs:65:36
[INFO] [stdout]    |
[INFO] [stdout] 65 |                     None => return e_str("for --vars keys must have values").into(),
[INFO] [stdout]    |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `e_str("for --vars keys must have values")`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion
[INFO] [stdout]    = note: `#[warn(clippy::useless_conversion)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:113:12
[INFO] [stdout]     |
[INFO] [stdout] 113 |         if tman.get("page_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("page_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout]     = note: `#[warn(clippy::partialeq_to_none)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:120:12
[INFO] [stdout]     |
[INFO] [stdout] 120 |         if tman.get("card_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("card_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]    --> src/build_config.rs:127:12
[INFO] [stdout]     |
[INFO] [stdout] 127 |         if tman.get("file_wrap") == None {
[INFO] [stdout]     |            ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `tman.get("file_wrap").is_none()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/imports.rs:16:13
[INFO] [stdout]    |
[INFO] [stdout] 16 |             return err_tools::e_str("Can only import string and lists of templates");
[INFO] [stdout]    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout]    = note: `#[warn(clippy::needless_return)]` on by default
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 16 -             return err_tools::e_str("Can only import string and lists of templates");
[INFO] [stdout] 16 +             err_tools::e_str("Can only import string and lists of templates")
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unnecessary `if let` since only the `Ok` variant of the iterator element is used
[INFO] [stdout]   --> src/imports.rs:58:17
[INFO] [stdout]    |
[INFO] [stdout] 58 | /                 for x in dir {
[INFO] [stdout] 59 | |                     if let Ok(f) = x {
[INFO] [stdout] 60 | |                         self.stack.push(f.path());
[INFO] [stdout] 61 | |                     }
[INFO] [stdout] 62 | |                 }
[INFO] [stdout]    | |_________________^
[INFO] [stdout]    |
[INFO] [stdout] help: try `.flatten()` and remove the `if let` statement in the for loop
[INFO] [stdout]   --> src/imports.rs:59:21
[INFO] [stdout]    |
[INFO] [stdout] 59 | /                     if let Ok(f) = x {
[INFO] [stdout] 60 | |                         self.stack.push(f.path());
[INFO] [stdout] 61 | |                     }
[INFO] [stdout]    | |_____________________^
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_flatten
[INFO] [stdout]    = note: `#[warn(clippy::manual_flatten)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 58 ~                 for f in dir.flatten() {
[INFO] [stdout] 59 +                     self.stack.push(f.path());
[INFO] [stdout] 60 +                 }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:15:9
[INFO] [stdout]    |
[INFO] [stdout] 15 | /         return Self {
[INFO] [stdout] 16 | |             front: front,
[INFO] [stdout] 17 | |             back: back,
[INFO] [stdout] 18 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 15 ~         Self {
[INFO] [stdout] 16 +             front: front,
[INFO] [stdout] 17 +             back: back,
[INFO] [stdout] 18 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:32:17
[INFO] [stdout]    |
[INFO] [stdout] 32 |                 return Ok(vec![fname]);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 32 -                 return Ok(vec![fname]);
[INFO] [stdout] 32 +                 Ok(vec![fname])
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/page_builder.rs:35:17
[INFO] [stdout]    |
[INFO] [stdout] 35 |                 return self.build_page_files(cards, bc);
[INFO] [stdout]    |                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 35 -                 return self.build_page_files(cards, bc);
[INFO] [stdout] 35 +                 self.build_page_files(cards, bc)
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/page_builder.rs:63:16
[INFO] [stdout]    |
[INFO] [stdout] 63 |             if f_res == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `f_res.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: binary comparison to literal `Option::None`
[INFO] [stdout]   --> src/page_builder.rs:97:16
[INFO] [stdout]    |
[INFO] [stdout] 97 |             if f_res == None {
[INFO] [stdout]    |                ^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `f_res.is_none()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: you are using an explicit closure for cloning elements
[INFO] [stdout]    --> src/page_builder.rs:102:29
[INFO] [stdout]     |
[INFO] [stdout] 102 |         if let Some(wrap) = bc.tman.get("file_wrap").map(|c| c.clone()) {
[INFO] [stdout]     |                             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `cloned` method: `bc.tman.get("file_wrap").cloned()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone
[INFO] [stdout]     = note: `#[warn(clippy::map_clone)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: unneeded `return` statement
[INFO] [stdout]   --> src/spread.rs:11:9
[INFO] [stdout]    |
[INFO] [stdout] 11 | /         return SpreadIter {
[INFO] [stdout] 12 | |             cards: self.cards,
[INFO] [stdout] 13 | |             n: self.n,
[INFO] [stdout] 14 | |             pos: self.pos,
[INFO] [stdout] 15 | |         };
[INFO] [stdout]    | |_________^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stdout] help: remove `return`
[INFO] [stdout]    |
[INFO] [stdout] 11 ~         SpreadIter {
[INFO] [stdout] 12 +             cards: self.cards,
[INFO] [stdout] 13 +             n: self.n,
[INFO] [stdout] 14 +             pos: self.pos,
[INFO] [stdout] 15 ~         }
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: accessing first element with `cards.get(0)`
[INFO] [stdout]   --> src/spread.rs:21:17
[INFO] [stdout]    |
[INFO] [stdout] 21 |         let n = cards.get(0).map(|c| c.num).unwrap_or(0);
[INFO] [stdout]    |                 ^^^^^^^^^^^^ help: try: `cards.first()`
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first
[INFO] [stdout]    = note: `#[warn(clippy::get_first)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: function call inside of `expect`
[INFO] [stdout]   --> src/templates.rs:84:31
[INFO] [stdout]    |
[INFO] [stdout] 84 |       TreeTemplate::from_str(s).expect(&format!(
[INFO] [stdout]    |  _______________________________^
[INFO] [stdout] 85 | |         "Builtin template should pass: {} - {}",
[INFO] [stdout] 86 | |         wrap_type, format
[INFO] [stdout] 87 | |     ))
[INFO] [stdout]    | |______^
[INFO] [stdout]    |
[INFO] [stdout]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stdout]    = note: `#[warn(clippy::expect_fun_call)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]    |
[INFO] [stdout] 84 ~     TreeTemplate::from_str(s).unwrap_or_else(|_| panic!("Builtin template should pass: {} - {}",
[INFO] [stdout] 85 +         wrap_type, format))
[INFO] [stdout]    |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference
[INFO] [stdout]    --> src/main.rs:108:51
[INFO] [stdout]     |
[INFO] [stdout] 108 |         TemplateSet::try_new("front", &bc.config, &mut bc.tman)?.unwrap(),
[INFO] [stdout]     |                                                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 108 -         TemplateSet::try_new("front", &bc.config, &mut bc.tman)?.unwrap(),
[INFO] [stdout] 108 +         TemplateSet::try_new("front", &bc.config, &bc.tman)?.unwrap(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference
[INFO] [stdout]    --> src/main.rs:109:50
[INFO] [stdout]     |
[INFO] [stdout] 109 |         TemplateSet::try_new("back", &bc.config, &mut bc.tman)?,
[INFO] [stdout]     |                                                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 109 -         TemplateSet::try_new("back", &bc.config, &mut bc.tman)?,
[INFO] [stdout] 109 +         TemplateSet::try_new("back", &bc.config, &bc.tman)?,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:114:8
[INFO] [stdout]     |
[INFO] [stdout] 114 |     if flist.len() == 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flist.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference
[INFO] [stdout]    --> src/main.rs:108:51
[INFO] [stdout]     |
[INFO] [stdout] 108 |         TemplateSet::try_new("front", &bc.config, &mut bc.tman)?.unwrap(),
[INFO] [stdout]     |                                                   ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout]     = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 108 -         TemplateSet::try_new("front", &bc.config, &mut bc.tman)?.unwrap(),
[INFO] [stdout] 108 +         TemplateSet::try_new("front", &bc.config, &bc.tman)?.unwrap(),
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: the function `TemplateSet::try_new` doesn't need a mutable reference
[INFO] [stdout]    --> src/main.rs:109:50
[INFO] [stdout]     |
[INFO] [stdout] 109 |         TemplateSet::try_new("back", &bc.config, &mut bc.tman)?,
[INFO] [stdout]     |                                                  ^^^^^^^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed
[INFO] [stdout] help: remove this `mut`
[INFO] [stdout]     |
[INFO] [stdout] 109 -         TemplateSet::try_new("back", &bc.config, &mut bc.tman)?,
[INFO] [stdout] 109 +         TemplateSet::try_new("back", &bc.config, &bc.tman)?,
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: length comparison to zero
[INFO] [stdout]    --> src/main.rs:114:8
[INFO] [stdout]     |
[INFO] [stdout] 114 |     if flist.len() == 0 {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `flist.is_empty()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stdout]     = note: `#[warn(clippy::len_zero)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:155:8
[INFO] [stdout]     |
[INFO] [stdout] 155 |     if !std::fs::metadata(&card_path).is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&card_path).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/main.rs:155:8
[INFO] [stdout]     |
[INFO] [stdout] 155 |     if !std::fs::metadata(&card_path).is_ok() {
[INFO] [stdout]     |        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::fs::metadata(&card_path).is_err()`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 34.90s
[INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: gobble v0.6.3
[INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3`
[INFO] running `Command { std: "docker" "inspect" "801df77f9644af4f90a7913f8077fcbe7e07e2ee360ea75d5720b042d4fd86e7", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "801df77f9644af4f90a7913f8077fcbe7e07e2ee360ea75d5720b042d4fd86e7", kill_on_drop: false }`
[INFO] [stdout] 801df77f9644af4f90a7913f8077fcbe7e07e2ee360ea75d5720b042d4fd86e7