[INFO] fetching crate bulletin-board-server 0.3.3... [INFO] linting bulletin-board-server-0.3.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bulletin-board-server 0.3.3 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate bulletin-board-server 0.3.3 [INFO] finished tweaking crates.io crate bulletin-board-server 0.3.3 [INFO] tweaked toml for crates.io crate bulletin-board-server 0.3.3 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bulletin-board-server 0.3.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate bulletin-board-server 0.3.3 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bulletin-board-common v0.3.2 [INFO] [stderr] Downloaded anstyle v1.0.9 [INFO] [stderr] Downloaded anstream v0.6.17 [INFO] [stderr] Downloaded cc v1.1.31 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ec2123ed0ce79ea9b4394d4a3ecff6ee71eb2ad8df647fe77513001fcde0d043 [INFO] running `Command { std: "docker" "start" "-a" "ec2123ed0ce79ea9b4394d4a3ecff6ee71eb2ad8df647fe77513001fcde0d043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ec2123ed0ce79ea9b4394d4a3ecff6ee71eb2ad8df647fe77513001fcde0d043", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ec2123ed0ce79ea9b4394d4a3ecff6ee71eb2ad8df647fe77513001fcde0d043", kill_on_drop: false }` [INFO] [stdout] ec2123ed0ce79ea9b4394d4a3ecff6ee71eb2ad8df647fe77513001fcde0d043 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 425f0b0a4f46897f7de423b61ab97c1b0770e0e282499870d976734dba5cb29a [INFO] running `Command { std: "docker" "start" "-a" "425f0b0a4f46897f7de423b61ab97c1b0770e0e282499870d976734dba5cb29a", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.161 [INFO] [stderr] Checking anstyle v1.0.9 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking parse-size v1.1.0 [INFO] [stderr] Checking serde_bytes v0.11.19 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking anstream v0.6.17 [INFO] [stderr] Compiling syn v2.0.85 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking uuid v1.19.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking bulletin-board-common v0.3.2 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking bulletin-board-server v0.3.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:36:48 [INFO] [stdout] | [INFO] [stdout] 36 | BulletinBackend::Archive(_) => Err(std::io::Error::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 37 | | std::io::ErrorKind::Other, [INFO] [stdout] 38 | | "Archive is read only.", [INFO] [stdout] 39 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 36 ~ BulletinBackend::Archive(_) => Err(std::io::Error::other( [INFO] [stdout] 37 ~ "Archive is read only.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | None => Err(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 52 | | std::io::ErrorKind::Other, [INFO] [stdout] 53 | | "File is not opened.", [INFO] [stdout] 54 | | )), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 51 ~ None => Err(std::io::Error::other( [INFO] [stdout] 52 ~ "File is not opened.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:56:48 [INFO] [stdout] | [INFO] [stdout] 56 | BulletinBackend::Archive(_) => Err(std::io::Error::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 57 | | std::io::ErrorKind::Other, [INFO] [stdout] 58 | | "Archive is read only.", [INFO] [stdout] 59 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 56 ~ BulletinBackend::Archive(_) => Err(std::io::Error::other( [INFO] [stdout] 57 ~ "Archive is read only.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:164:22 [INFO] [stdout] | [INFO] [stdout] 164 | _ => Err(std::io::Error::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 165 | | std::io::ErrorKind::Other, [INFO] [stdout] 166 | | "Already moved out of memory.", [INFO] [stdout] 167 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 164 ~ _ => Err(std::io::Error::other( [INFO] [stdout] 165 ~ "Already moved out of memory.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:49:32 [INFO] [stdout] | [INFO] [stdout] 49 | ::fmt(&self, f) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:83:32 [INFO] [stdout] | [INFO] [stdout] 83 | ::fmt(&self, f) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerOptions` [INFO] [stdout] --> src/server.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | Self { [INFO] [stdout] 37 | | debug: false, [INFO] [stdout] 38 | | listen_addr: None, [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for ServerOptions { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:288:24 [INFO] [stdout] | [INFO] [stdout] 288 | if !LISTEN_ADDR.to_socket_addrs().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `LISTEN_ADDR.to_socket_addrs().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / if !LISTEN_ADDR.to_socket_addrs().is_ok() { [INFO] [stdout] 289 | | if std::path::Path::new(&*LISTEN_ADDR).exists() { [INFO] [stdout] 290 | | std::fs::remove_file(&*LISTEN_ADDR)?; [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 288 ~ if !LISTEN_ADDR.to_socket_addrs().is_ok() [INFO] [stdout] 289 ~ && std::path::Path::new(&*LISTEN_ADDR).exists() { [INFO] [stdout] 290 | std::fs::remove_file(&*LISTEN_ADDR)?; [INFO] [stdout] 291 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:436:24 [INFO] [stdout] | [INFO] [stdout] 436 | logging::debug(format!("(version).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(version).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:445:24 [INFO] [stdout] | [INFO] [stdout] 445 | logging::debug(format!("(status).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(status).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:454:24 [INFO] [stdout] | [INFO] [stdout] 454 | logging::debug(format!("(log).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(log).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:467:24 [INFO] [stdout] | [INFO] [stdout] 467 | logging::debug(format!("(view_board).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(view_board).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:552:12 [INFO] [stdout] | [INFO] [stdout] 552 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:579:12 [INFO] [stdout] | [INFO] [stdout] 579 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:595:24 [INFO] [stdout] | [INFO] [stdout] 595 | logging::debug(format!("(list_archive).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(list_archive).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:613:12 [INFO] [stdout] | [INFO] [stdout] 613 | if acv_from.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_from.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:620:12 [INFO] [stdout] | [INFO] [stdout] 620 | if acv_to.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_to.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:636:12 [INFO] [stdout] | [INFO] [stdout] 636 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:652:12 [INFO] [stdout] | [INFO] [stdout] 652 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:668:12 [INFO] [stdout] | [INFO] [stdout] 668 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:681:24 [INFO] [stdout] | [INFO] [stdout] 681 | logging::debug(format!("(clear_log).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(clear_log).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:688:24 [INFO] [stdout] | [INFO] [stdout] 688 | logging::debug(format!("(restore/reset/exit).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(restore/reset/exit).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:36:48 [INFO] [stdout] | [INFO] [stdout] 36 | BulletinBackend::Archive(_) => Err(std::io::Error::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 37 | | std::io::ErrorKind::Other, [INFO] [stdout] 38 | | "Archive is read only.", [INFO] [stdout] 39 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 36 ~ BulletinBackend::Archive(_) => Err(std::io::Error::other( [INFO] [stdout] 37 ~ "Archive is read only.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:51:29 [INFO] [stdout] | [INFO] [stdout] 51 | None => Err(std::io::Error::new( [INFO] [stdout] | _____________________________^ [INFO] [stdout] 52 | | std::io::ErrorKind::Other, [INFO] [stdout] 53 | | "File is not opened.", [INFO] [stdout] 54 | | )), [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 51 ~ None => Err(std::io::Error::other( [INFO] [stdout] 52 ~ "File is not opened.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:56:48 [INFO] [stdout] | [INFO] [stdout] 56 | BulletinBackend::Archive(_) => Err(std::io::Error::new( [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 57 | | std::io::ErrorKind::Other, [INFO] [stdout] 58 | | "Archive is read only.", [INFO] [stdout] 59 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 56 ~ BulletinBackend::Archive(_) => Err(std::io::Error::other( [INFO] [stdout] 57 ~ "Archive is read only.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/bulletin.rs:164:22 [INFO] [stdout] | [INFO] [stdout] 164 | _ => Err(std::io::Error::new( [INFO] [stdout] | ______________________^ [INFO] [stdout] 165 | | std::io::ErrorKind::Other, [INFO] [stdout] 166 | | "Already moved out of memory.", [INFO] [stdout] 167 | | )), [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 164 ~ _ => Err(std::io::Error::other( [INFO] [stdout] 165 ~ "Already moved out of memory.", [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:49:32 [INFO] [stdout] | [INFO] [stdout] 49 | ::fmt(&self, f) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/error.rs:83:32 [INFO] [stdout] | [INFO] [stdout] 83 | ::fmt(&self, f) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ServerOptions` [INFO] [stdout] --> src/server.rs:35:5 [INFO] [stdout] | [INFO] [stdout] 35 | / pub fn new() -> Self { [INFO] [stdout] 36 | | Self { [INFO] [stdout] 37 | | debug: false, [INFO] [stdout] 38 | | listen_addr: None, [INFO] [stdout] ... | [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 34 + impl Default for ServerOptions { [INFO] [stdout] 35 + fn default() -> Self { [INFO] [stdout] 36 + Self::new() [INFO] [stdout] 37 + } [INFO] [stdout] 38 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server.rs:288:24 [INFO] [stdout] | [INFO] [stdout] 288 | if !LISTEN_ADDR.to_socket_addrs().is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `LISTEN_ADDR.to_socket_addrs().is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/server.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / if !LISTEN_ADDR.to_socket_addrs().is_ok() { [INFO] [stdout] 289 | | if std::path::Path::new(&*LISTEN_ADDR).exists() { [INFO] [stdout] 290 | | std::fs::remove_file(&*LISTEN_ADDR)?; [INFO] [stdout] 291 | | } [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 288 ~ if !LISTEN_ADDR.to_socket_addrs().is_ok() [INFO] [stdout] 289 ~ && std::path::Path::new(&*LISTEN_ADDR).exists() { [INFO] [stdout] 290 | std::fs::remove_file(&*LISTEN_ADDR)?; [INFO] [stdout] 291 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:436:24 [INFO] [stdout] | [INFO] [stdout] 436 | logging::debug(format!("(version).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(version).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:445:24 [INFO] [stdout] | [INFO] [stdout] 445 | logging::debug(format!("(status).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(status).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:454:24 [INFO] [stdout] | [INFO] [stdout] 454 | logging::debug(format!("(log).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(log).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:467:24 [INFO] [stdout] | [INFO] [stdout] 467 | logging::debug(format!("(view_board).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(view_board).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:552:12 [INFO] [stdout] | [INFO] [stdout] 552 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:579:12 [INFO] [stdout] | [INFO] [stdout] 579 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:595:24 [INFO] [stdout] | [INFO] [stdout] 595 | logging::debug(format!("(list_archive).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(list_archive).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:613:12 [INFO] [stdout] | [INFO] [stdout] 613 | if acv_from.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_from.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:620:12 [INFO] [stdout] | [INFO] [stdout] 620 | if acv_to.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_to.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:636:12 [INFO] [stdout] | [INFO] [stdout] 636 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:652:12 [INFO] [stdout] | [INFO] [stdout] 652 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/server.rs:668:12 [INFO] [stdout] | [INFO] [stdout] 668 | if acv_name.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `acv_name.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:681:24 [INFO] [stdout] | [INFO] [stdout] 681 | logging::debug(format!("(clear_log).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(clear_log).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/server.rs:688:24 [INFO] [stdout] | [INFO] [stdout] 688 | logging::debug(format!("(restore/reset/exit).")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"(restore/reset/exit).".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 11.85s [INFO] running `Command { std: "docker" "inspect" "425f0b0a4f46897f7de423b61ab97c1b0770e0e282499870d976734dba5cb29a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "425f0b0a4f46897f7de423b61ab97c1b0770e0e282499870d976734dba5cb29a", kill_on_drop: false }` [INFO] [stdout] 425f0b0a4f46897f7de423b61ab97c1b0770e0e282499870d976734dba5cb29a