[INFO] fetching crate bspc_rust_lib 0.2.0... [INFO] linting bspc_rust_lib-0.2.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bspc_rust_lib 0.2.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate bspc_rust_lib 0.2.0 [INFO] finished tweaking crates.io crate bspc_rust_lib 0.2.0 [INFO] tweaked toml for crates.io crate bspc_rust_lib 0.2.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bspc_rust_lib 0.2.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 11 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 21b39d5e6a6c4107f016bb8b364b560fb810c0dc3b0a9be45e839d7bcf055dc5 [INFO] running `Command { std: "docker" "start" "-a" "21b39d5e6a6c4107f016bb8b364b560fb810c0dc3b0a9be45e839d7bcf055dc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "21b39d5e6a6c4107f016bb8b364b560fb810c0dc3b0a9be45e839d7bcf055dc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "21b39d5e6a6c4107f016bb8b364b560fb810c0dc3b0a9be45e839d7bcf055dc5", kill_on_drop: false }` [INFO] [stdout] 21b39d5e6a6c4107f016bb8b364b560fb810c0dc3b0a9be45e839d7bcf055dc5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 679bf1e1b74f7682018f845adf6541d54cadc08a1f96e1d4f209e1d788d2a55e [INFO] running `Command { std: "docker" "start" "-a" "679bf1e1b74f7682018f845adf6541d54cadc08a1f96e1d4f209e1d788d2a55e", kill_on_drop: false }` [INFO] [stderr] Checking bspc_rust_lib v0.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self; [INFO] [stdout] 29 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self; [INFO] [stdout] 33 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/node/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Path` [INFO] [stdout] --> src/bspc/node/path.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Path { [INFO] [stdout] 13 | | Path { [INFO] [stdout] 14 | | desktop_selector: None, [INFO] [stdout] 15 | | jumps: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Path { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self; [INFO] [stdout] 22 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self; [INFO] [stdout] 27 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return self; [INFO] [stdout] 32 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bspc/node/path.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if i == 0 && self.absolute || i != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 - if i == 0 && self.absolute || i != 0 { [INFO] [stdout] 48 + if !(i == 0 && !self.absolute) { [INFO] [stdout] | [INFO] [stdout] 48 - if i == 0 && self.absolute || i != 0 { [INFO] [stdout] 48 + if i != 0 || self.absolute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return result; [INFO] [stdout] 56 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/node/path.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / match &self.desktop_selector { [INFO] [stdout] 39 | | Some(selector) => { [INFO] [stdout] 40 | | result.push_str(&selector.assemble(None)); [INFO] [stdout] 41 | | result.push_str(":"); [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | None => () [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 ~ if let Some(selector) = &self.desktop_selector { [INFO] [stdout] 39 + result.push_str(&selector.assemble(None)); [INFO] [stdout] 40 + result.push_str(":"); [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | result.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | result.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bspc/node/path.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | result.push_str(&format!("{}", next_jump.get_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `next_jump.get_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bspc/node/path.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if self.jumps.len() == 0 && self.absolute { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.jumps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | result.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/bspc/node/path.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / String::from(match self { [INFO] [stdout] 72 | | Jump::First => "first".to_string(), [INFO] [stdout] 73 | | Jump::Second => "second".to_string(), [INFO] [stdout] 74 | | Jump::Brother => "brother".to_string(), [INFO] [stdout] 75 | | Jump::Parent => "parent".to_string(), [INFO] [stdout] 76 | | Jump::Dir(dir) => dir.get_string(), [INFO] [stdout] 77 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 71 ~ (match self { [INFO] [stdout] 72 + Jump::First => "first".to_string(), [INFO] [stdout] 73 + Jump::Second => "second".to_string(), [INFO] [stdout] 74 + Jump::Brother => "brother".to_string(), [INFO] [stdout] 75 + Jump::Parent => "parent".to_string(), [INFO] [stdout] 76 + Jump::Dir(dir) => dir.get_string(), [INFO] [stdout] 77 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self; [INFO] [stdout] 29 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self; [INFO] [stdout] 33 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return result; [INFO] [stdout] 63 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/desktop/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/command.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return result; [INFO] [stdout] 112 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/monitor/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/monitor/command.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return result; [INFO] [stdout] 87 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self; [INFO] [stdout] 29 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/selector.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self; [INFO] [stdout] 33 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/node/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/query.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Vec::new(); [INFO] [stdout] 105 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:11:9 [INFO] [stdout] | [INFO] [stdout] 11 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bspc/query.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / if message.len() > 0 { [INFO] [stdout] 100 | | return message; [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ Some(message) [INFO] [stdout] 99 ~ if message.len() > 0 => { [INFO] [stdout] 100 | return message; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/query.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / match socket_communication::send_message(self.assemble()) { [INFO] [stdout] 98 | | Some(message) => { [INFO] [stdout] 99 | | if message.len() > 0 { [INFO] [stdout] 100 | | return message; [INFO] [stdout] ... | [INFO] [stdout] 103 | | None => {} [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Some(message) = socket_communication::send_message(self.assemble()) { [INFO] [stdout] 98 + if message.len() > 0 { [INFO] [stdout] 99 + return message; [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:23:9 [INFO] [stdout] | [INFO] [stdout] 23 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bspc/query.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if message.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:45:9 [INFO] [stdout] | [INFO] [stdout] 45 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | /// Default descriptor: `Any` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/query.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / match sel { [INFO] [stdout] 118 | | Some(selector) => { [INFO] [stdout] 119 | | push_selector(current_sel, selector); [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ if let Some(selector) = sel { [INFO] [stdout] 118 + push_selector(current_sel, selector); [INFO] [stdout] 119 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:79:9 [INFO] [stdout] | [INFO] [stdout] 79 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:85:9 [INFO] [stdout] | [INFO] [stdout] 85 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:91:9 [INFO] [stdout] | [INFO] [stdout] 91 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:107:9 [INFO] [stdout] | [INFO] [stdout] 107 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:113:9 [INFO] [stdout] | [INFO] [stdout] 113 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:119:9 [INFO] [stdout] | [INFO] [stdout] 119 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:126:9 [INFO] [stdout] | [INFO] [stdout] 126 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:133:9 [INFO] [stdout] | [INFO] [stdout] 133 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/bspc/node/command.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | /// Default descriptor: `Focused` [INFO] [stdout] | ^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SubscriptionHandler` [INFO] [stdout] --> src/bspc/subscription.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> SubscriptionHandler { [INFO] [stdout] 15 | | SubscriptionHandler { [INFO] [stdout] 16 | | thread_handles: Vec::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for SubscriptionHandler { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/socket_communication.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / match std::env::var("BSPWM_SOCKET") { [INFO] [stdout] 40 | | Ok(path) => { [INFO] [stdout] 41 | | if path != "" { [INFO] [stdout] 42 | | return path; [INFO] [stdout] ... | [INFO] [stdout] 45 | | Err(_) => {} [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Ok(path) = std::env::var("BSPWM_SOCKET") { [INFO] [stdout] 40 + if path != "" { [INFO] [stdout] 41 + return path; [INFO] [stdout] 42 + } [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/socket_communication.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if path != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | 1 => return nodes[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - 1 => return nodes[0].clone(), [INFO] [stdout] 16 + 1 => nodes[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | 1 => return nodes[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - 1 => return nodes[0].clone(), [INFO] [stdout] 29 + 1 => nodes[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | _ => return get_focused_node(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - _ => return get_focused_node(), [INFO] [stdout] 30 + _ => get_focused_node(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 71 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - 1 => return desktops[0].clone(), [INFO] [stdout] 71 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - 1 => return desktops[0].clone(), [INFO] [stdout] 87 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | _ => return get_focused_desktop(name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - _ => return get_focused_desktop(name), [INFO] [stdout] 88 + _ => get_focused_desktop(name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | 1 => return Some(nodes[0].clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - 1 => return Some(nodes[0].clone()), [INFO] [stdout] 102 + 1 => Some(nodes[0].clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 103 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - _ => return None, [INFO] [stdout] 103 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return QueryCommand::Desktops(None, None, None, false).get_response(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return QueryCommand::Desktops(None, None, None, false).get_response(); [INFO] [stdout] 109 + QueryCommand::Desktops(None, None, None, false).get_response() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return QueryCommand::Desktops(None, None, None, true).get_response(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return QueryCommand::Desktops(None, None, None, true).get_response(); [INFO] [stdout] 114 + QueryCommand::Desktops(None, None, None, true).get_response() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return result; [INFO] [stdout] 123 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `json_tree.get(0)` [INFO] [stdout] --> src/util.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let json_tree = json_tree.get(0).expect("bspwm should return a valid json object"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `json_tree.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Path` [INFO] [stdout] --> src/bspc/node/path.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | / pub fn new() -> Path { [INFO] [stdout] 13 | | Path { [INFO] [stdout] 14 | | desktop_selector: None, [INFO] [stdout] 15 | | jumps: Vec::new(), [INFO] [stdout] ... | [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 11 + impl Default for Path { [INFO] [stdout] 12 + fn default() -> Self { [INFO] [stdout] 13 + Self::new() [INFO] [stdout] 14 + } [INFO] [stdout] 15 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - 1 => return desktops[0].clone(), [INFO] [stdout] 159 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:160:14 [INFO] [stdout] | [INFO] [stdout] 160 | _ => return "".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - _ => return "".to_string(), [INFO] [stdout] 160 + _ => "".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 22 - return self; [INFO] [stdout] 22 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return self; [INFO] [stdout] 27 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 32 - return self; [INFO] [stdout] 32 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bspc/node/path.rs:48:16 [INFO] [stdout] | [INFO] [stdout] 48 | if i == 0 && self.absolute || i != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 48 - if i == 0 && self.absolute || i != 0 { [INFO] [stdout] 48 + if !(i == 0 && !self.absolute) { [INFO] [stdout] | [INFO] [stdout] 48 - if i == 0 && self.absolute || i != 0 { [INFO] [stdout] 48 + if i != 0 || self.absolute { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/node/path.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 56 - return result; [INFO] [stdout] 56 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/node/path.rs:38:9 [INFO] [stdout] | [INFO] [stdout] 38 | / match &self.desktop_selector { [INFO] [stdout] 39 | | Some(selector) => { [INFO] [stdout] 40 | | result.push_str(&selector.assemble(None)); [INFO] [stdout] 41 | | result.push_str(":"); [INFO] [stdout] 42 | | } [INFO] [stdout] 43 | | None => () [INFO] [stdout] 44 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 38 ~ if let Some(selector) = &self.desktop_selector { [INFO] [stdout] 39 + result.push_str(&selector.assemble(None)); [INFO] [stdout] 40 + result.push_str(":"); [INFO] [stdout] 41 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | result.push_str(":"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push(':')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] = note: `#[warn(clippy::single_char_add_str)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:49:17 [INFO] [stdout] | [INFO] [stdout] 49 | result.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/bspc/node/path.rs:51:30 [INFO] [stdout] | [INFO] [stdout] 51 | result.push_str(&format!("{}", next_jump.get_string())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `next_jump.get_string().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bspc/node/path.rs:53:12 [INFO] [stdout] | [INFO] [stdout] 53 | if self.jumps.len() == 0 && self.absolute { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.jumps.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `push_str()` using a single-character string literal [INFO] [stdout] --> src/bspc/node/path.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | result.push_str("/"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: consider using `push` with a character literal: `result.push('/')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_add_str [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::string::String` [INFO] [stdout] --> src/bspc/node/path.rs:71:9 [INFO] [stdout] | [INFO] [stdout] 71 | / String::from(match self { [INFO] [stdout] 72 | | Jump::First => "first".to_string(), [INFO] [stdout] 73 | | Jump::Second => "second".to_string(), [INFO] [stdout] 74 | | Jump::Brother => "brother".to_string(), [INFO] [stdout] 75 | | Jump::Parent => "parent".to_string(), [INFO] [stdout] 76 | | Jump::Dir(dir) => dir.get_string(), [INFO] [stdout] 77 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `String::from()` [INFO] [stdout] | [INFO] [stdout] 71 ~ (match self { [INFO] [stdout] 72 + Jump::First => "first".to_string(), [INFO] [stdout] 73 + Jump::Second => "second".to_string(), [INFO] [stdout] 74 + Jump::Brother => "brother".to_string(), [INFO] [stdout] 75 + Jump::Parent => "parent".to_string(), [INFO] [stdout] 76 + Jump::Dir(dir) => dir.get_string(), [INFO] [stdout] 77 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:25:9 [INFO] [stdout] | [INFO] [stdout] 25 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 25 - return self; [INFO] [stdout] 25 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:29:9 [INFO] [stdout] | [INFO] [stdout] 29 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return self; [INFO] [stdout] 29 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | return self; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self; [INFO] [stdout] 33 + self [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/selector.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - return result; [INFO] [stdout] 63 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/desktop/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/desktop/command.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return result; [INFO] [stdout] 112 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/monitor/selector.rs:52:17 [INFO] [stdout] | [INFO] [stdout] 52 | / match default { [INFO] [stdout] 53 | | Some(default_value) => { [INFO] [stdout] 54 | | result.push_str(&default_value.get_string()); [INFO] [stdout] ... | [INFO] [stdout] 57 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 52 ~ if let Some(default_value) = default { [INFO] [stdout] 53 + result.push_str(&default_value.get_string()); [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/monitor/command.rs:87:9 [INFO] [stdout] | [INFO] [stdout] 87 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - return result; [INFO] [stdout] 87 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bspc/query.rs:105:9 [INFO] [stdout] | [INFO] [stdout] 105 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 105 - return Vec::new(); [INFO] [stdout] 105 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/bspc/query.rs:99:17 [INFO] [stdout] | [INFO] [stdout] 99 | / if message.len() > 0 { [INFO] [stdout] 100 | | return message; [INFO] [stdout] 101 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 98 ~ Some(message) [INFO] [stdout] 99 ~ if message.len() > 0 => { [INFO] [stdout] 100 | return message; [INFO] [stdout] 101 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/query.rs:97:9 [INFO] [stdout] | [INFO] [stdout] 97 | / match socket_communication::send_message(self.assemble()) { [INFO] [stdout] 98 | | Some(message) => { [INFO] [stdout] 99 | | if message.len() > 0 { [INFO] [stdout] 100 | | return message; [INFO] [stdout] ... | [INFO] [stdout] 103 | | None => {} [INFO] [stdout] 104 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 97 ~ if let Some(message) = socket_communication::send_message(self.assemble()) { [INFO] [stdout] 98 + if message.len() > 0 { [INFO] [stdout] 99 + return message; [INFO] [stdout] 100 + } [INFO] [stdout] 101 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/bspc/query.rs:99:20 [INFO] [stdout] | [INFO] [stdout] 99 | if message.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!message.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/bspc/query.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | / match sel { [INFO] [stdout] 118 | | Some(selector) => { [INFO] [stdout] 119 | | push_selector(current_sel, selector); [INFO] [stdout] ... | [INFO] [stdout] 122 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 117 ~ if let Some(selector) = sel { [INFO] [stdout] 118 + push_selector(current_sel, selector); [INFO] [stdout] 119 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `SubscriptionHandler` [INFO] [stdout] --> src/bspc/subscription.rs:14:5 [INFO] [stdout] | [INFO] [stdout] 14 | / pub fn new() -> SubscriptionHandler { [INFO] [stdout] 15 | | SubscriptionHandler { [INFO] [stdout] 16 | | thread_handles: Vec::new(), [INFO] [stdout] 17 | | } [INFO] [stdout] 18 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 13 + impl Default for SubscriptionHandler { [INFO] [stdout] 14 + fn default() -> Self { [INFO] [stdout] 15 + Self::new() [INFO] [stdout] 16 + } [INFO] [stdout] 17 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/socket_communication.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | / match std::env::var("BSPWM_SOCKET") { [INFO] [stdout] 40 | | Ok(path) => { [INFO] [stdout] 41 | | if path != "" { [INFO] [stdout] 42 | | return path; [INFO] [stdout] ... | [INFO] [stdout] 45 | | Err(_) => {} [INFO] [stdout] 46 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 39 ~ if let Ok(path) = std::env::var("BSPWM_SOCKET") { [INFO] [stdout] 40 + if path != "" { [INFO] [stdout] 41 + return path; [INFO] [stdout] 42 + } [INFO] [stdout] 43 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/socket_communication.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if path != "" { [INFO] [stdout] | ^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!path.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:16:14 [INFO] [stdout] | [INFO] [stdout] 16 | 1 => return nodes[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - 1 => return nodes[0].clone(), [INFO] [stdout] 16 + 1 => nodes[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:29:14 [INFO] [stdout] | [INFO] [stdout] 29 | 1 => return nodes[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - 1 => return nodes[0].clone(), [INFO] [stdout] 29 + 1 => nodes[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:30:14 [INFO] [stdout] | [INFO] [stdout] 30 | _ => return get_focused_node(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - _ => return get_focused_node(), [INFO] [stdout] 30 + _ => get_focused_node(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:71:14 [INFO] [stdout] | [INFO] [stdout] 71 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 71 - 1 => return desktops[0].clone(), [INFO] [stdout] 71 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:87:14 [INFO] [stdout] | [INFO] [stdout] 87 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 - 1 => return desktops[0].clone(), [INFO] [stdout] 87 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:88:14 [INFO] [stdout] | [INFO] [stdout] 88 | _ => return get_focused_desktop(name), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 88 - _ => return get_focused_desktop(name), [INFO] [stdout] 88 + _ => get_focused_desktop(name), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:102:14 [INFO] [stdout] | [INFO] [stdout] 102 | 1 => return Some(nodes[0].clone()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - 1 => return Some(nodes[0].clone()), [INFO] [stdout] 102 + 1 => Some(nodes[0].clone()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:103:14 [INFO] [stdout] | [INFO] [stdout] 103 | _ => return None, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - _ => return None, [INFO] [stdout] 103 + _ => None, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:109:5 [INFO] [stdout] | [INFO] [stdout] 109 | return QueryCommand::Desktops(None, None, None, false).get_response(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 109 - return QueryCommand::Desktops(None, None, None, false).get_response(); [INFO] [stdout] 109 + QueryCommand::Desktops(None, None, None, false).get_response() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | return QueryCommand::Desktops(None, None, None, true).get_response(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return QueryCommand::Desktops(None, None, None, true).get_response(); [INFO] [stdout] 114 + QueryCommand::Desktops(None, None, None, true).get_response() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:123:5 [INFO] [stdout] | [INFO] [stdout] 123 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 123 - return result; [INFO] [stdout] 123 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `json_tree.get(0)` [INFO] [stdout] --> src/util.rs:138:21 [INFO] [stdout] | [INFO] [stdout] 138 | let json_tree = json_tree.get(0).expect("bspwm should return a valid json object"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `json_tree.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:159:14 [INFO] [stdout] | [INFO] [stdout] 159 | 1 => return desktops[0].clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 159 - 1 => return desktops[0].clone(), [INFO] [stdout] 159 + 1 => desktops[0].clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/util.rs:160:14 [INFO] [stdout] | [INFO] [stdout] 160 | _ => return "".to_string(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - _ => return "".to_string(), [INFO] [stdout] 160 + _ => "".to_string(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.49s [INFO] running `Command { std: "docker" "inspect" "679bf1e1b74f7682018f845adf6541d54cadc08a1f96e1d4f209e1d788d2a55e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "679bf1e1b74f7682018f845adf6541d54cadc08a1f96e1d4f209e1d788d2a55e", kill_on_drop: false }` [INFO] [stdout] 679bf1e1b74f7682018f845adf6541d54cadc08a1f96e1d4f209e1d788d2a55e