[INFO] fetching crate brug-macros 0.3.0-alpha0... [INFO] linting brug-macros-0.3.0-alpha0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate brug-macros 0.3.0-alpha0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate brug-macros 0.3.0-alpha0 [INFO] finished tweaking crates.io crate brug-macros 0.3.0-alpha0 [INFO] tweaked toml for crates.io crate brug-macros 0.3.0-alpha0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate brug-macros 0.3.0-alpha0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 4 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 143f1e56e1c6b858a466117ad5b3bb55fb1ac4e701f80f616796f98ec147738c [INFO] running `Command { std: "docker" "start" "-a" "143f1e56e1c6b858a466117ad5b3bb55fb1ac4e701f80f616796f98ec147738c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "143f1e56e1c6b858a466117ad5b3bb55fb1ac4e701f80f616796f98ec147738c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "143f1e56e1c6b858a466117ad5b3bb55fb1ac4e701f80f616796f98ec147738c", kill_on_drop: false }` [INFO] [stdout] 143f1e56e1c6b858a466117ad5b3bb55fb1ac4e701f80f616796f98ec147738c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 3b24edf6eb331854e45c60a1a6ec1db153b44e33b7265a7340a66c17f340561e [INFO] running `Command { std: "docker" "start" "-a" "3b24edf6eb331854e45c60a1a6ec1db153b44e33b7265a7340a66c17f340561e", kill_on_drop: false }` [INFO] [stderr] Checking brug-macros v0.3.0-alpha0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/lib.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | inputs: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | if !func.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `func.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:40:67 [INFO] [stdout] | [INFO] [stdout] 40 | v.ident = Ident::new(&format!("{}Command", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:49:66 [INFO] [stdout] | [INFO] [stdout] 49 | v.ident = Ident::new(&format!("{}Facade", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:54:69 [INFO] [stdout] | [INFO] [stdout] 54 | v.ident = Ident::new(&format!("{}FacadeMut", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / match item { [INFO] [stdout] 68 | | ImplItem::Fn(func) => { [INFO] [stdout] 69 | | let is_async = func.sig.asyncness.is_some(); [INFO] [stdout] 70 | | let name = func.sig.ident.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 116 | | _ => {} [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if let ImplItem::Fn(func) = item { [INFO] [stdout] 68 + let is_async = func.sig.asyncness.is_some(); [INFO] [stdout] 69 + let name = func.sig.ident.to_string(); [INFO] [stdout] 70 + let enum_name = change_casing(&name); [INFO] [stdout] 71 + let mut inputs = vec![]; [INFO] [stdout] 72 + let mut safe_input_names = vec![]; [INFO] [stdout] 73 + let mut input_names = vec![]; [INFO] [stdout] 74 + [INFO] [stdout] 75 + if !func.sig.generics.params.is_empty() { [INFO] [stdout] 76 + panic!("{}::{}() has generic parameters, which can't be supported", receiver_name_str, name); [INFO] [stdout] 77 + } [INFO] [stdout] 78 + [INFO] [stdout] 79 + if !func.sig.variadic.is_none() { [INFO] [stdout] 80 + panic!("{}::{}() is variadic parameters, which can't be supported", receiver_name_str, name); [INFO] [stdout] 81 + } [INFO] [stdout] 82 + [INFO] [stdout] 83 + [INFO] [stdout] 84 + let mut i = 0; [INFO] [stdout] 85 + for input in func.sig.inputs { [INFO] [stdout] 86 + match input { [INFO] [stdout] 87 + FnArg::Receiver(_) => {} [INFO] [stdout] 88 + FnArg::Typed(t) => { [INFO] [stdout] 89 + inputs.push(t.ty); [INFO] [stdout] 90 + safe_input_names.push(format_ident!("arg_{i}")); [INFO] [stdout] 91 + input_names.push(match &*t.pat { [INFO] [stdout] 92 + Pat::Ident(id) => id.ident.clone(), [INFO] [stdout] 93 + _ => format_ident!("arg_{i}"), [INFO] [stdout] 94 + }); [INFO] [stdout] 95 + i += 1; [INFO] [stdout] 96 + } [INFO] [stdout] 97 + } [INFO] [stdout] 98 + } [INFO] [stdout] 99 + [INFO] [stdout] 100 + let output = match func.sig.output { [INFO] [stdout] 101 + ReturnType::Default => quote! { () }, [INFO] [stdout] 102 + ReturnType::Type(_, t) => t.to_token_stream(), [INFO] [stdout] 103 + }; [INFO] [stdout] 104 + [INFO] [stdout] 105 + items.push(Item { [INFO] [stdout] 106 + name, [INFO] [stdout] 107 + enum_name, [INFO] [stdout] 108 + inputs, [INFO] [stdout] 109 + safe_input_names, [INFO] [stdout] 110 + input_names, [INFO] [stdout] 111 + is_async, [INFO] [stdout] 112 + output, [INFO] [stdout] 113 + }) [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `Vec` is already on the heap, the boxing is unnecessary [INFO] [stdout] --> src/lib.rs:10:13 [INFO] [stdout] | [INFO] [stdout] 10 | inputs: Vec>, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `Vec` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_box [INFO] [stdout] = note: `#[warn(clippy::vec_box)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:80:20 [INFO] [stdout] | [INFO] [stdout] 80 | if !func.sig.variadic.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `func.sig.variadic.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:40:67 [INFO] [stdout] | [INFO] [stdout] 40 | v.ident = Ident::new(&format!("{}Command", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:49:66 [INFO] [stdout] | [INFO] [stdout] 49 | v.ident = Ident::new(&format!("{}Facade", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/lib.rs:54:69 [INFO] [stdout] | [INFO] [stdout] 54 | v.ident = Ident::new(&format!("{}FacadeMut", v.ident.to_string()), Span::call_site()); [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / match item { [INFO] [stdout] 68 | | ImplItem::Fn(func) => { [INFO] [stdout] 69 | | let is_async = func.sig.asyncness.is_some(); [INFO] [stdout] 70 | | let name = func.sig.ident.to_string(); [INFO] [stdout] ... | [INFO] [stdout] 116 | | _ => {} [INFO] [stdout] 117 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 67 ~ if let ImplItem::Fn(func) = item { [INFO] [stdout] 68 + let is_async = func.sig.asyncness.is_some(); [INFO] [stdout] 69 + let name = func.sig.ident.to_string(); [INFO] [stdout] 70 + let enum_name = change_casing(&name); [INFO] [stdout] 71 + let mut inputs = vec![]; [INFO] [stdout] 72 + let mut safe_input_names = vec![]; [INFO] [stdout] 73 + let mut input_names = vec![]; [INFO] [stdout] 74 + [INFO] [stdout] 75 + if !func.sig.generics.params.is_empty() { [INFO] [stdout] 76 + panic!("{}::{}() has generic parameters, which can't be supported", receiver_name_str, name); [INFO] [stdout] 77 + } [INFO] [stdout] 78 + [INFO] [stdout] 79 + if !func.sig.variadic.is_none() { [INFO] [stdout] 80 + panic!("{}::{}() is variadic parameters, which can't be supported", receiver_name_str, name); [INFO] [stdout] 81 + } [INFO] [stdout] 82 + [INFO] [stdout] 83 + [INFO] [stdout] 84 + let mut i = 0; [INFO] [stdout] 85 + for input in func.sig.inputs { [INFO] [stdout] 86 + match input { [INFO] [stdout] 87 + FnArg::Receiver(_) => {} [INFO] [stdout] 88 + FnArg::Typed(t) => { [INFO] [stdout] 89 + inputs.push(t.ty); [INFO] [stdout] 90 + safe_input_names.push(format_ident!("arg_{i}")); [INFO] [stdout] 91 + input_names.push(match &*t.pat { [INFO] [stdout] 92 + Pat::Ident(id) => id.ident.clone(), [INFO] [stdout] 93 + _ => format_ident!("arg_{i}"), [INFO] [stdout] 94 + }); [INFO] [stdout] 95 + i += 1; [INFO] [stdout] 96 + } [INFO] [stdout] 97 + } [INFO] [stdout] 98 + } [INFO] [stdout] 99 + [INFO] [stdout] 100 + let output = match func.sig.output { [INFO] [stdout] 101 + ReturnType::Default => quote! { () }, [INFO] [stdout] 102 + ReturnType::Type(_, t) => t.to_token_stream(), [INFO] [stdout] 103 + }; [INFO] [stdout] 104 + [INFO] [stdout] 105 + items.push(Item { [INFO] [stdout] 106 + name, [INFO] [stdout] 107 + enum_name, [INFO] [stdout] 108 + inputs, [INFO] [stdout] 109 + safe_input_names, [INFO] [stdout] 110 + input_names, [INFO] [stdout] 111 + is_async, [INFO] [stdout] 112 + output, [INFO] [stdout] 113 + }) [INFO] [stdout] 114 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.35s [INFO] running `Command { std: "docker" "inspect" "3b24edf6eb331854e45c60a1a6ec1db153b44e33b7265a7340a66c17f340561e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3b24edf6eb331854e45c60a1a6ec1db153b44e33b7265a7340a66c17f340561e", kill_on_drop: false }` [INFO] [stdout] 3b24edf6eb331854e45c60a1a6ec1db153b44e33b7265a7340a66c17f340561e