[INFO] fetching crate brotli-no-stdlib 1.0.4... [INFO] linting brotli-no-stdlib-1.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate brotli-no-stdlib 1.0.4 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate brotli-no-stdlib 1.0.4 [INFO] finished tweaking crates.io crate brotli-no-stdlib 1.0.4 [INFO] tweaked toml for crates.io crate brotli-no-stdlib 1.0.4 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate brotli-no-stdlib 1.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding alloc-no-stdlib v1.0.0 (available: v1.3.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * src/bin/integration_tests.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded alloc-no-stdlib v1.0.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 162bb478d5090e52f1df137628250c2bb9f0f09781375b175fb4a7c625601577 [INFO] running `Command { std: "docker" "start" "-a" "162bb478d5090e52f1df137628250c2bb9f0f09781375b175fb4a7c625601577", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "162bb478d5090e52f1df137628250c2bb9f0f09781375b175fb4a7c625601577", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "162bb478d5090e52f1df137628250c2bb9f0f09781375b175fb4a7c625601577", kill_on_drop: false }` [INFO] [stdout] 162bb478d5090e52f1df137628250c2bb9f0f09781375b175fb4a7c625601577 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 29e109d02947903d0014c442f2f179d21a29cbadde955128fe50f959e8e77937 [INFO] running `Command { std: "docker" "start" "-a" "29e109d02947903d0014c442f2f179d21a29cbadde955128fe50f959e8e77937", kill_on_drop: false }` [INFO] [stderr] warning: An explicit [[bin]] section is specified in Cargo.toml which currently [INFO] [stderr] disables Cargo from automatically inferring other binary targets. [INFO] [stderr] This inference behavior will change in the Rust 2018 edition and the following [INFO] [stderr] files will be included as a binary target: [INFO] [stderr] [INFO] [stderr] * src/bin/integration_tests.rs [INFO] [stderr] [INFO] [stderr] This is likely to break cargo build or cargo test as these files may not be [INFO] [stderr] ready to be compiled as a binary target today. You can future-proof yourself [INFO] [stderr] and disable this warning by adding `autobins = false` to your [package] [INFO] [stderr] section. You may also move the files to a location where Cargo would not [INFO] [stderr] automatically infer them to be a target, such as in subfolders. [INFO] [stderr] [INFO] [stderr] For more information on this warning you can consult [INFO] [stderr] https://github.com/rust-lang/cargo/issues/5330 [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking alloc-no-stdlib v1.0.0 [INFO] [stderr] Checking brotli-no-stdlib v1.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/lib.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first defined here [INFO] [stdout] --> src/lib.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] help: remove this attribute [INFO] [stdout] --> src/lib.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes [INFO] [stdout] = note: `#[warn(clippy::duplicated_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `#[macro_use]` import [INFO] [stdout] --> src/lib.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | #[macro_use] [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: duplicated attribute [INFO] [stdout] --> src/lib.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: first defined here [INFO] [stdout] --> src/lib.rs:2:10 [INFO] [stdout] | [INFO] [stdout] 2 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] help: remove this attribute [INFO] [stdout] --> src/lib.rs:5:10 [INFO] [stdout] | [INFO] [stdout] 5 | #![allow(non_snake_case)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#duplicated_attributes [INFO] [stdout] = note: `#[warn(clippy::duplicated_attributes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/bit_reader/mod.rs:405:43 [INFO] [stdout] | [INFO] [stdout] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove them: `(offset << 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn init(self : &mut Self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 53 - pub fn init(self : &mut Self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] 53 + pub fn init(&mut self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 73 - pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] 73 + pub fn get_tree_mut<'a>(&'a mut self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 78 - pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] 78 + pub fn get_tree<'a>(&'a self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn reset(self : &mut Self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 82 - pub fn reset(self : &mut Self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] 82 + pub fn reset(&mut self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:96:35 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn build_hgroup_cache<'a>(self : &'a Self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 96 - pub fn build_hgroup_cache<'a>(self : &'a Self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] 96 + pub fn build_hgroup_cache<'a>(&'a self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | alloc_u8 : alloc_u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | alloc_u32 : alloc_u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | alloc_hc : alloc_hc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_hc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:337:38 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn BrotliStateMetablockBegin(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 337 - pub fn BrotliStateMetablockBegin(self : &mut Self) { [INFO] [stdout] 337 + pub fn BrotliStateMetablockBegin(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:367:45 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn BrotliStateCleanupAfterMetablock(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 367 - pub fn BrotliStateCleanupAfterMetablock(self : &mut Self) { [INFO] [stdout] 367 + pub fn BrotliStateCleanupAfterMetablock(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:381:30 [INFO] [stdout] | [INFO] [stdout] 381 | pub fn BrotliStateCleanup(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 381 - pub fn BrotliStateCleanup(self : &mut Self) { [INFO] [stdout] 381 + pub fn BrotliStateCleanup(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:396:37 [INFO] [stdout] | [INFO] [stdout] 396 | pub fn BrotliStateIsStreamStart(self : &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 396 - pub fn BrotliStateIsStreamStart(self : &Self) -> bool { [INFO] [stdout] 396 + pub fn BrotliStateIsStreamStart(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:404:35 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn BrotliStateIsStreamEnd(self : &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 404 - pub fn BrotliStateIsStreamEnd(self : &Self) -> bool { [INFO] [stdout] 404 + pub fn BrotliStateIsStreamEnd(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:410:39 [INFO] [stdout] | [INFO] [stdout] 410 | pub fn BrotliHuffmanTreeGroupInit(self :&mut Self, group : WhichTreeGroup, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 410 - pub fn BrotliHuffmanTreeGroupInit(self :&mut Self, group : WhichTreeGroup, [INFO] [stdout] 410 + pub fn BrotliHuffmanTreeGroupInit(&mut self, group : WhichTreeGroup, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | pub fn BrotliHuffmanTreeGroupRelease(self :&mut Self, group : WhichTreeGroup) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 424 - pub fn BrotliHuffmanTreeGroupRelease(self :&mut Self, group : WhichTreeGroup) { [INFO] [stdout] 424 + pub fn BrotliHuffmanTreeGroupRelease(&mut self, group : WhichTreeGroup) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:405:36 [INFO] [stdout] | [INFO] [stdout] 405 | let mask = bit_reader::BitMask((*bits - HUFFMAN_TABLE_BITS)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `*bits - HUFFMAN_TABLE_BITS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `SafeReadBlockLength` [INFO] [stdout] --> src/lib.rs:921:14 [INFO] [stdout] | [INFO] [stdout] 921 | macro_rules! SafeReadBlockLength ( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:1563:40 [INFO] [stdout] | [INFO] [stdout] 1563 | s.ringbuffer = s.alloc_u8.alloc_cell((s.ringbuffer_size as usize + [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1564 | | kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize)); [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] help: remove them [INFO] [stdout] | [INFO] [stdout] 1563 ~ s.ringbuffer = s.alloc_u8.alloc_cell(s.ringbuffer_size as usize + [INFO] [stdout] 1564 ~ kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/bit_reader/mod.rs:405:43 [INFO] [stdout] | [INFO] [stdout] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove them: `(offset << 3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> src/huffman/tests.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / #[cfg(test)] [INFO] [stdout] 2 | | [INFO] [stdout] | |_^ [INFO] [stdout] 3 | use super::*; [INFO] [stdout] | - the attribute applies to this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the attribute should apply to the parent module use an inner attribute [INFO] [stdout] | [INFO] [stdout] 1 | #![cfg(test)] [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:53:17 [INFO] [stdout] | [INFO] [stdout] 53 | pub fn init(self : &mut Self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 53 - pub fn init(self : &mut Self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] 53 + pub fn init(&mut self, mut alloc_u32 : &mut AllocU32, mut alloc_hc : &mut AllocHC, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:73:29 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 73 - pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] 73 + pub fn get_tree_mut<'a>(&'a mut self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:78:25 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 78 - pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] 78 + pub fn get_tree<'a>(&'a self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:82:18 [INFO] [stdout] | [INFO] [stdout] 82 | pub fn reset(self : &mut Self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 82 - pub fn reset(self : &mut Self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] 82 + pub fn reset(&mut self, alloc_u32 : &mut AllocU32, alloc_hc : &mut AllocHC) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/huffman/mod.rs:96:35 [INFO] [stdout] | [INFO] [stdout] 96 | pub fn build_hgroup_cache<'a>(self : &'a Self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 96 - pub fn build_hgroup_cache<'a>(self : &'a Self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] 96 + pub fn build_hgroup_cache<'a>(&'a self) -> [&'a [HuffmanCode]; 256] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:236:13 [INFO] [stdout] | [INFO] [stdout] 236 | alloc_u8 : alloc_u8, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u8` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:237:13 [INFO] [stdout] | [INFO] [stdout] 237 | alloc_u32 : alloc_u32, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/state.rs:238:13 [INFO] [stdout] | [INFO] [stdout] 238 | alloc_hc : alloc_hc, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `alloc_hc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:337:38 [INFO] [stdout] | [INFO] [stdout] 337 | pub fn BrotliStateMetablockBegin(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 337 - pub fn BrotliStateMetablockBegin(self : &mut Self) { [INFO] [stdout] 337 + pub fn BrotliStateMetablockBegin(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:367:45 [INFO] [stdout] | [INFO] [stdout] 367 | pub fn BrotliStateCleanupAfterMetablock(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 367 - pub fn BrotliStateCleanupAfterMetablock(self : &mut Self) { [INFO] [stdout] 367 + pub fn BrotliStateCleanupAfterMetablock(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:381:30 [INFO] [stdout] | [INFO] [stdout] 381 | pub fn BrotliStateCleanup(self : &mut Self) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 381 - pub fn BrotliStateCleanup(self : &mut Self) { [INFO] [stdout] 381 + pub fn BrotliStateCleanup(&mut self) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:396:37 [INFO] [stdout] | [INFO] [stdout] 396 | pub fn BrotliStateIsStreamStart(self : &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 396 - pub fn BrotliStateIsStreamStart(self : &Self) -> bool { [INFO] [stdout] 396 + pub fn BrotliStateIsStreamStart(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:404:35 [INFO] [stdout] | [INFO] [stdout] 404 | pub fn BrotliStateIsStreamEnd(self : &Self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 404 - pub fn BrotliStateIsStreamEnd(self : &Self) -> bool { [INFO] [stdout] 404 + pub fn BrotliStateIsStreamEnd(&self) -> bool { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:410:39 [INFO] [stdout] | [INFO] [stdout] 410 | pub fn BrotliHuffmanTreeGroupInit(self :&mut Self, group : WhichTreeGroup, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 410 - pub fn BrotliHuffmanTreeGroupInit(self :&mut Self, group : WhichTreeGroup, [INFO] [stdout] 410 + pub fn BrotliHuffmanTreeGroupInit(&mut self, group : WhichTreeGroup, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/state.rs:424:42 [INFO] [stdout] | [INFO] [stdout] 424 | pub fn BrotliHuffmanTreeGroupRelease(self :&mut Self, group : WhichTreeGroup) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 424 - pub fn BrotliHuffmanTreeGroupRelease(self :&mut Self, group : WhichTreeGroup) { [INFO] [stdout] 424 + pub fn BrotliHuffmanTreeGroupRelease(&mut self, group : WhichTreeGroup) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:405:36 [INFO] [stdout] | [INFO] [stdout] 405 | let mask = bit_reader::BitMask((*bits - HUFFMAN_TABLE_BITS)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove them: `*bits - HUFFMAN_TABLE_BITS` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused macro definition: `SafeReadBlockLength` [INFO] [stdout] --> src/lib.rs:921:14 [INFO] [stdout] | [INFO] [stdout] 921 | macro_rules! SafeReadBlockLength ( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_macros)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/lib.rs:1563:40 [INFO] [stdout] | [INFO] [stdout] 1563 | s.ringbuffer = s.alloc_u8.alloc_cell((s.ringbuffer_size as usize + [INFO] [stdout] | ________________________________________^ [INFO] [stdout] 1564 | | kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize)); [INFO] [stdout] | |____________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] help: remove them [INFO] [stdout] | [INFO] [stdout] 1563 ~ s.ringbuffer = s.alloc_u8.alloc_cell(s.ringbuffer_size as usize + [INFO] [stdout] 1564 ~ kRingBufferWriteAheadSlack as usize + kBrotliMaxDictionaryWordLength as usize); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transform.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | let mut uppercase = &mut dst[(idx - len) as usize ..]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | mut value : &mut u32, [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1018:7 [INFO] [stdout] | [INFO] [stdout] 1018 | for mut htree_iter in htrees.slice_mut()[s.htree_index as usize .. (group_num_htrees as usize)].iter_mut() { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1152:13 [INFO] [stdout] | [INFO] [stdout] 1152 | let mut context_map = &mut context_map_arg.slice_mut(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1271:45 [INFO] [stdout] | [INFO] [stdout] 1271 | ... mut s : &mut BlockTypeAndLengthState, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1272:45 [INFO] [stdout] | [INFO] [stdout] 1272 | ... mut br : &mut bit_reader::BrotliBitReader, [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1332:45 [INFO] [stdout] | [INFO] [stdout] 1332 | ... mut s : &mut BrotliState src/lib.rs:1377:45 [INFO] [stdout] | [INFO] [stdout] 1377 | ... mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1390:45 [INFO] [stdout] | [INFO] [stdout] 1390 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1398:45 [INFO] [stdout] | [INFO] [stdout] 1398 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1409:45 [INFO] [stdout] | [INFO] [stdout] 1409 | ... mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1424:45 [INFO] [stdout] | [INFO] [stdout] 1424 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1433:45 [INFO] [stdout] | [INFO] [stdout] 1433 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1440:33 [INFO] [stdout] | [INFO] [stdout] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1440:57 [INFO] [stdout] | [INFO] [stdout] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1441:20 [INFO] [stdout] | [INFO] [stdout] 1441 | mut total_out : &mut usize, s : &mut BrotliState) -> BrotliResult { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:2198:3 [INFO] [stdout] | [INFO] [stdout] 2198 | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/dictionary/mod.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub const kBrotliDictionary : [u8;122784] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 23 | | 0x74, 0x69, 0x6d, 0x65, 0x64, 0x6f, 0x77, 0x6e, 0x6c, 0x69, 0x66, 0x65, 0x6c, [INFO] [stdout] 24 | | 0x65, 0x66, 0x74, 0x62, 0x61, 0x63, 0x6b, 0x63, 0x6f, 0x64, 0x65, 0x64, 0x61, [INFO] [stdout] 25 | | 0x74, 0x61, 0x73, 0x68, 0x6f, 0x77, 0x6f, 0x6e, 0x6c, 0x79, 0x73, 0x69, 0x74, [INFO] [stdout] ... | [INFO] [stdout] 9467 | | 0xe0, 0xa4, 0xbf, 0xe0, 0xa4, 0xaf, 0xe0, 0xa4, 0xa4, 0xe0, 0xa4, 0xbe, [INFO] [stdout] 9468 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/transform.rs:284:9 [INFO] [stdout] | [INFO] [stdout] 284 | let mut uppercase = &mut dst[(idx - len) as usize ..]; [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | mut value : &mut u32, [INFO] [stdout] | ----^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1018:7 [INFO] [stdout] | [INFO] [stdout] 1018 | for mut htree_iter in htrees.slice_mut()[s.htree_index as usize .. (group_num_htrees as usize)].iter_mut() { [INFO] [stdout] | ----^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1152:13 [INFO] [stdout] | [INFO] [stdout] 1152 | let mut context_map = &mut context_map_arg.slice_mut(); [INFO] [stdout] | ----^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1271:45 [INFO] [stdout] | [INFO] [stdout] 1271 | ... mut s : &mut BlockTypeAndLengthState, [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1272:45 [INFO] [stdout] | [INFO] [stdout] 1272 | ... mut br : &mut bit_reader::BrotliBitReader, [INFO] [stdout] | ----^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1332:45 [INFO] [stdout] | [INFO] [stdout] 1332 | ... mut s : &mut BrotliState src/lib.rs:1377:45 [INFO] [stdout] | [INFO] [stdout] 1377 | ... mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1390:45 [INFO] [stdout] | [INFO] [stdout] 1390 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1398:45 [INFO] [stdout] | [INFO] [stdout] 1398 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1409:45 [INFO] [stdout] | [INFO] [stdout] 1409 | ... mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1424:45 [INFO] [stdout] | [INFO] [stdout] 1424 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1433:45 [INFO] [stdout] | [INFO] [stdout] 1433 | AllocHC : alloc::Allocator> (mut s : &mut BrotliState, input : &[u8]) -> bool { [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1440:33 [INFO] [stdout] | [INFO] [stdout] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stdout] | ----^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1440:57 [INFO] [stdout] | [INFO] [stdout] 1440 | (available_out : &mut usize, mut output : &mut [u8], mut output_offset : &mut usize, [INFO] [stdout] | ----^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:1441:20 [INFO] [stdout] | [INFO] [stdout] 1441 | mut total_out : &mut usize, s : &mut BrotliState) -> BrotliResult { [INFO] [stdout] | ----^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/lib.rs:2198:3 [INFO] [stdout] | [INFO] [stdout] 2198 | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stdout] | ----^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large array defined as const [INFO] [stdout] --> src/dictionary/mod.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | pub const kBrotliDictionary : [u8;122784] = [ [INFO] [stdout] | ^ ----- help: make this a static item: `static` [INFO] [stdout] | _| [INFO] [stdout] | | [INFO] [stdout] 23 | | 0x74, 0x69, 0x6d, 0x65, 0x64, 0x6f, 0x77, 0x6e, 0x6c, 0x69, 0x66, 0x65, 0x6c, [INFO] [stdout] 24 | | 0x65, 0x66, 0x74, 0x62, 0x61, 0x63, 0x6b, 0x63, 0x6f, 0x64, 0x65, 0x64, 0x61, [INFO] [stdout] 25 | | 0x74, 0x61, 0x73, 0x68, 0x6f, 0x77, 0x6f, 0x6e, 0x6c, 0x79, 0x73, 0x69, 0x74, [INFO] [stdout] ... | [INFO] [stdout] 9467 | | 0xe0, 0xa4, 0xbf, 0xe0, 0xa4, 0xaf, 0xe0, 0xa4, 0xa4, 0xe0, 0xa4, 0xbe, [INFO] [stdout] 9468 | | ]; [INFO] [stdout] | |__^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_const_arrays [INFO] [stdout] = note: `#[warn(clippy::large_const_arrays)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return !((0xffffffffu32) << n); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return !((0xffffffffu32) << n); [INFO] [stdout] 34 + !((0xffffffffu32) << n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return kBitMask[n as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return kBitMask[n as usize]; [INFO] [stdout] 36 + kBitMask[n as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / return BrotliBitReader { [INFO] [stdout] 50 | | val_ : 0, [INFO] [stdout] 51 | | bit_pos_ : 0, [INFO] [stdout] 52 | | next_in : 0, [INFO] [stdout] 53 | | avail_in : 0, [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ BrotliBitReader { [INFO] [stdout] 50 + val_ : 0, [INFO] [stdout] 51 + bit_pos_ : 0, [INFO] [stdout] 52 + next_in : 0, [INFO] [stdout] 53 + avail_in : 0, [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return BrotliBitReaderState { [INFO] [stdout] 68 | | val_ : 0, [INFO] [stdout] 69 | | bit_pos_ : 0, [INFO] [stdout] 70 | | next_in : 0, [INFO] [stdout] 71 | | avail_in : 0, [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ BrotliBitReaderState { [INFO] [stdout] 68 + val_ : 0, [INFO] [stdout] 69 + bit_pos_ : 0, [INFO] [stdout] 70 + next_in : 0, [INFO] [stdout] 71 + avail_in : 0, [INFO] [stdout] 72 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:79:3 [INFO] [stdout] | [INFO] [stdout] 79 | / return BrotliBitReaderState { val_ : from.val_, [INFO] [stdout] 80 | | bit_pos_ : from.bit_pos_, [INFO] [stdout] 81 | | next_in : from.next_in, [INFO] [stdout] 82 | | avail_in : from.avail_in }; [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ BrotliBitReaderState { val_ : from.val_, [INFO] [stdout] 80 + bit_pos_ : from.bit_pos_, [INFO] [stdout] 81 + next_in : from.next_in, [INFO] [stdout] 82 ~ avail_in : from.avail_in } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:95:3 [INFO] [stdout] | [INFO] [stdout] 95 | return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stdout] 95 + ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:101:3 [INFO] [stdout] | [INFO] [stdout] 101 | return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stdout] 101 + br.avail_in + (BrotliGetAvailableBits(br) >> 3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:108:3 [INFO] [stdout] | [INFO] [stdout] 108 | return br.avail_in >= num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return br.avail_in >= num; [INFO] [stdout] 108 + br.avail_in >= num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:117:3 [INFO] [stdout] | [INFO] [stdout] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stdout] 117 + (two_byte[0] as u16) | ((two_byte[1] as u16) << 8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:124:3 [INFO] [stdout] | [INFO] [stdout] 124 | / return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stdout] 125 | | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stdout] 125 ~ | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:132:3 [INFO] [stdout] | [INFO] [stdout] 132 | / return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stdout] 133 | | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stdout] 134 | | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stdout] 135 | | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 ~ (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stdout] 133 + | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stdout] 134 + | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stdout] 135 ~ | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:254:3 [INFO] [stdout] | [INFO] [stdout] 254 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return true; [INFO] [stdout] 254 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:261:3 [INFO] [stdout] | [INFO] [stdout] 261 | return br.val_ >> br.bit_pos_; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return br.val_ >> br.bit_pos_; [INFO] [stdout] 261 + br.val_ >> br.bit_pos_ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:270:3 [INFO] [stdout] | [INFO] [stdout] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stdout] 270 + (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:277:3 [INFO] [stdout] | [INFO] [stdout] 277 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] 277 + (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:285:3 [INFO] [stdout] | [INFO] [stdout] 285 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 285 - return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] 285 + (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return true; [INFO] [stdout] 298 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return val; [INFO] [stdout] 340 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 348 | return low_val | (high_val << 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return low_val | (high_val << 16); [INFO] [stdout] 348 + low_val | (high_val << 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return val; [INFO] [stdout] 361 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:369:5 [INFO] [stdout] | [INFO] [stdout] 369 | return low_val | (high_val << 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return low_val | (high_val << 16); [INFO] [stdout] 369 + low_val | (high_val << 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:383:3 [INFO] [stdout] | [INFO] [stdout] 383 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return true; [INFO] [stdout] 383 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:394:3 [INFO] [stdout] | [INFO] [stdout] 394 | return pad_bits == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return pad_bits == 0; [INFO] [stdout] 394 + pad_bits == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:411:3 [INFO] [stdout] | [INFO] [stdout] 411 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return -1; [INFO] [stdout] 411 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bit_reader/mod.rs:405:43 [INFO] [stdout] | [INFO] [stdout] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((offset << 3))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:456:3 [INFO] [stdout] | [INFO] [stdout] 456 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - return true; [INFO] [stdout] 456 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bit_reader/mod.rs:443:3 [INFO] [stdout] | [INFO] [stdout] 443 | / if BrotliGetAvailableBits(br) == 0 { [INFO] [stdout] 444 | | if !BrotliPullByte(br, input) { [INFO] [stdout] 445 | | return false; [INFO] [stdout] 446 | | } [INFO] [stdout] 447 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ if BrotliGetAvailableBits(br) == 0 [INFO] [stdout] 444 ~ && !BrotliPullByte(br, input) { [INFO] [stdout] 445 | return false; [INFO] [stdout] 446 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `eq` can be confused for the standard trait method `std::cmp::PartialEq::eq` [INFO] [stdout] --> src/huffman/mod.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn eq(&self, other: &Self) -> bool { [INFO] [stdout] 33 | | return self.value == other.value && self.bits == other.bits; [INFO] [stdout] 34 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::cmp::PartialEq` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:33:7 [INFO] [stdout] | [INFO] [stdout] 33 | return self.value == other.value && self.bits == other.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.value == other.value && self.bits == other.bits; [INFO] [stdout] 33 + self.value == other.value && self.bits == other.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 39 | return HuffmanCode { value : 0, bits : 0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return HuffmanCode { value : 0, bits : 0}; [INFO] [stdout] 39 + HuffmanCode { value : 0, bits : 0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | self.reset(&mut alloc_u32, &mut alloc_hc); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `alloc_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | self.reset(&mut alloc_u32, &mut alloc_hc); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `alloc_hc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/huffman/mod.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 73 - pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] 73 + pub fn get_tree_mut(self :&mut Self, index : u32) -> &mut [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return &mut self.codes.slice_mut()[start..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return &mut self.codes.slice_mut()[start..]; [INFO] [stdout] 75 + &mut self.codes.slice_mut()[start..] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/huffman/mod.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 78 - pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] 78 + pub fn get_tree(self :&Self, index : u32) -> &[HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return & self.codes.slice()[start..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return & self.codes.slice()[start..]; [INFO] [stdout] 80 + & self.codes.slice()[start..] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/huffman/mod.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | alloc_u32.free_cell(core::mem::replace(&mut self.htrees, [INFO] [stdout] | _____________________________^ [INFO] [stdout] 84 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/huffman/mod.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | alloc_hc.free_cell(core::mem::replace(&mut self.codes, [INFO] [stdout] | ____________________________^ [INFO] [stdout] 86 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 103 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return ret; [INFO] [stdout] 103 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/huffman/mod.rs:99:7 [INFO] [stdout] | [INFO] [stdout] 99 | for htree in self.htrees.slice() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, htree) in self.htrees.slice().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return HuffmanTreeGroup:: { [INFO] [stdout] 111 | | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stdout] 112 | | codes : AllocHC::AllocatedMemory::default(), [INFO] [stdout] 113 | | alphabet_size : 0, [INFO] [stdout] 114 | | num_htrees : 0, [INFO] [stdout] 115 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ HuffmanTreeGroup:: { [INFO] [stdout] 111 + htrees : AllocU32::AllocatedMemory::default(), [INFO] [stdout] 112 + codes : AllocHC::AllocatedMemory::default(), [INFO] [stdout] 113 + alphabet_size : 0, [INFO] [stdout] 114 + num_htrees : 0, [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:166:3 [INFO] [stdout] | [INFO] [stdout] 166 | return kReverseBits[num as usize] as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - return kReverseBits[num as usize] as u32; [INFO] [stdout] 166 + kReverseBits[num as usize] as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | return len - root_bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return len - root_bits; [INFO] [stdout] 199 + len - root_bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/huffman/mod.rs:269:8 [INFO] [stdout] | [INFO] [stdout] 269 | if !(bits <= BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bits > BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/huffman/mod.rs:211:11 [INFO] [stdout] | [INFO] [stdout] 211 | BROTLI_REVERSE_BITS_MAX as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `BROTLI_REVERSE_BITS_MAX` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:262:22 [INFO] [stdout] | [INFO] [stdout] 262 | ReplicateValue(&mut table, BrotliReverseBits(key) as usize, step, table_size, code); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/huffman/mod.rs:323:8 [INFO] [stdout] | [INFO] [stdout] 323 | if !(bits <= table_bits) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(bits > table_bits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:373:3 [INFO] [stdout] | [INFO] [stdout] 373 | return total_size as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return total_size as u32; [INFO] [stdout] 373 + total_size as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | ReplicateValue(&mut root_table, table_free_offset + BrotliReverseBits(key) as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:365:11 [INFO] [stdout] | [INFO] [stdout] 365 | &mut root_table,table_free_offset + BrotliReverseBits(sub_key) as usize, step, table_size, code); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:466:3 [INFO] [stdout] | [INFO] [stdout] 466 | return goal_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return goal_size; [INFO] [stdout] 466 + goal_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/huffman/mod.rs:415:7 [INFO] [stdout] | [INFO] [stdout] 415 | let last : u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `last` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 ~ let last : u16 = if val.len() > 3 { [INFO] [stdout] 417 ~ val[3] [INFO] [stdout] 418 | } else { [INFO] [stdout] 419 ~ 65535 [INFO] [stdout] 420 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `mval` manually [INFO] [stdout] --> src/huffman/mod.rs:425:13 [INFO] [stdout] | [INFO] [stdout] 425 | / let t : u16 = mval[k]; [INFO] [stdout] 426 | | mval[k] = mval[i]; [INFO] [stdout] 427 | | mval[i] = t; [INFO] [stdout] | |________________________^ help: try: `mval.swap(k, i);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `table` [INFO] [stdout] --> src/huffman/mod.rs:431:16 [INFO] [stdout] | [INFO] [stdout] 431 | for i in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 431 - for i in 0..4 { [INFO] [stdout] 431 + for in table.iter_mut().take(4) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `mval` manually [INFO] [stdout] --> src/huffman/mod.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | / let t : u16 = mval[3]; [INFO] [stdout] 443 | | mval[3] = mval[2]; [INFO] [stdout] 444 | | mval[2] = t; [INFO] [stdout] | |____________________^ help: try: `mval.swap(3, 2);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `table` [INFO] [stdout] --> src/huffman/mod.rs:446:16 [INFO] [stdout] | [INFO] [stdout] 446 | for i in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 446 - for i in 0..7 { [INFO] [stdout] 446 + for (i, ) in table.iter_mut().enumerate().take(7) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/huffman/mod.rs:458:7 [INFO] [stdout] | [INFO] [stdout] 458 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LITERAL` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | LITERAL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Literal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISTANCE` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | DISTANCE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Distance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/state.rs:225:7 [INFO] [stdout] | [INFO] [stdout] 225 | impl <'brotli_state, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | return retval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - return retval; [INFO] [stdout] 335 + retval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:351:33 [INFO] [stdout] | [INFO] [stdout] 351 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 352 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:353:33 [INFO] [stdout] | [INFO] [stdout] 353 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_modes, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 354 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_modes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:355:33 [INFO] [stdout] | [INFO] [stdout] 355 | self.alloc_u8.free_cell(core::mem::replace(&mut self.dist_context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 356 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:368:33 [INFO] [stdout] | [INFO] [stdout] 368 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 369 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_modes, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 371 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_modes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:372:33 [INFO] [stdout] | [INFO] [stdout] 372 | self.alloc_u8.free_cell(core::mem::replace(&mut self.dist_context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 373 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:383:31 [INFO] [stdout] | [INFO] [stdout] 383 | self.alloc_u8.free_cell(core::mem::replace(&mut self.ringbuffer, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 384 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.ringbuffer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:385:31 [INFO] [stdout] | [INFO] [stdout] 385 | self.alloc_hc.free_cell(core::mem::replace(&mut self.block_type_length_state.block_type_trees, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 386 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.block_type_length_state.block_type_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:387:31 [INFO] [stdout] | [INFO] [stdout] 387 | self.alloc_hc.free_cell(core::mem::replace(&mut self.block_type_length_state.block_len_trees, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 388 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.block_type_length_state.block_len_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | self.alloc_hc.free_cell(core::mem::replace(&mut self.context_map_table, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 390 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] 399 + BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:400:18 [INFO] [stdout] | [INFO] [stdout] 400 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - _ => return false, [INFO] [stdout] 400 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stdout] 406 + BrotliRunningState::BROTLI_STATE_DONE => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:407:18 [INFO] [stdout] | [INFO] [stdout] 407 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - _ => return false, [INFO] [stdout] 407 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:252:3 [INFO] [stdout] | [INFO] [stdout] 252 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - return 3; [INFO] [stdout] 252 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/transform.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/transform.rs:240:38 [INFO] [stdout] | [INFO] [stdout] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'z'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - return idx; [INFO] [stdout] 304 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/transform.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | while (suffix[i as usize] != 0) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return BrotliResult::ResultFailure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return BrotliResult::ResultFailure; [INFO] [stdout] 84 + BrotliResult::ResultFailure [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:122:3 [INFO] [stdout] | [INFO] [stdout] 122 | return 17; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return 17; [INFO] [stdout] 122 + 17 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | bit_reader::BrotliTakeBits(&mut br, 1, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:114:30 [INFO] [stdout] | [INFO] [stdout] 114 | bit_reader::BrotliTakeBits(&mut br, 3, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:118:30 [INFO] [stdout] | [INFO] [stdout] 118 | bit_reader::BrotliTakeBits(&mut br, 3, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:137:44 [INFO] [stdout] | [INFO] [stdout] 137 | if !bit_reader::BrotliSafeReadBits(&mut br, 1, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:149:44 [INFO] [stdout] | [INFO] [stdout] 149 | if !bit_reader::BrotliSafeReadBits(&mut br, 3, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:165:44 [INFO] [stdout] | [INFO] [stdout] 165 | if !bit_reader::BrotliSafeReadBits(&mut br, *value, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:311:3 [INFO] [stdout] | [INFO] [stdout] 311 | return table_element.value as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return table_element.value as u32; [INFO] [stdout] 311 + table_element.value as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:319:3 [INFO] [stdout] | [INFO] [stdout] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] 319 + DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:319:71 [INFO] [stdout] | [INFO] [stdout] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:361:3 [INFO] [stdout] | [INFO] [stdout] 361 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return true; [INFO] [stdout] 361 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `bit_reader::BrotliGetAvailableBits` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:327:63 [INFO] [stdout] | [INFO] [stdout] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 327 - let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] 327 + let mut available_bits = bit_reader::BrotliGetAvailableBits(&br); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:327:63 [INFO] [stdout] | [INFO] [stdout] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:51 [INFO] [stdout] | [INFO] [stdout] 335 | let mut val = bit_reader::BrotliGetBitsUnmasked(&br) as u32; [INFO] [stdout] | ^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:340:34 [INFO] [stdout] | [INFO] [stdout] 340 | bit_reader::BrotliDropBits(&mut br, table_element.bits as u32); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:359:30 [INFO] [stdout] | [INFO] [stdout] 359 | bit_reader::BrotliDropBits(&mut br, HUFFMAN_TABLE_BITS + table_sub_element.bits as u32); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:375:3 [INFO] [stdout] | [INFO] [stdout] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] 375 + SafeDecodeSymbol(&table, br, result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | *result = DecodeSymbol(val, &table, br); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:375:27 [INFO] [stdout] | [INFO] [stdout] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:415:3 [INFO] [stdout] | [INFO] [stdout] 415 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return result; [INFO] [stdout] 415 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:424:3 [INFO] [stdout] | [INFO] [stdout] 424 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return result; [INFO] [stdout] 424 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:470:3 [INFO] [stdout] | [INFO] [stdout] 470 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 470 - return BrotliResult::ResultSuccess; [INFO] [stdout] 470 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/lib.rs:480:1 [INFO] [stdout] | [INFO] [stdout] 480 | / fn ProcessSingleCodeLength(code_len : u32, [INFO] [stdout] 481 | | symbol : &mut u32, repeat : &mut u32, space : &mut u32, [INFO] [stdout] 482 | | prev_code_len : &mut u32, symbol_lists : &mut [u16], symbol_list_index_offset : usize, [INFO] [stdout] 483 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/lib.rs:506:1 [INFO] [stdout] | [INFO] [stdout] 506 | / fn ProcessRepeatedCodeLength(code_len : u32, [INFO] [stdout] 507 | | mut repeat_delta : u32, alphabet_size : u32, symbol : &mut u32, [INFO] [stdout] 508 | | repeat : &mut u32, space : &mut u32, prev_code_len : &mut u32, [INFO] [stdout] 509 | | repeat_code_len : &mut u32, symbol_lists : &mut [u16], symbol_lists_index : usize, [INFO] [stdout] 510 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:511:3 [INFO] [stdout] | [INFO] [stdout] 511 | let old_repeat : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 520 | old_repeat = *repeat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `old_repeat` here [INFO] [stdout] | [INFO] [stdout] 511 ~ [INFO] [stdout] 512 | let mut new_len : u32 = 0; [INFO] [stdout] ... [INFO] [stdout] 519 | } [INFO] [stdout] 520 ~ let old_repeat : u32 = *repeat; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:557:5 [INFO] [stdout] | [INFO] [stdout] 557 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:604:3 [INFO] [stdout] | [INFO] [stdout] 604 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 604 - return BrotliResult::ResultSuccess; [INFO] [stdout] 604 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | let code_len : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 588 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code_len` here [INFO] [stdout] | [INFO] [stdout] 574 ~ [INFO] [stdout] 575 | if (!bit_reader::BrotliCheckInputAmount(&s.br, bit_reader::BROTLI_SHORT_FILL_BIT_WINDOW_READ)) { [INFO] [stdout] ... [INFO] [stdout] 587 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); /* Use 1..5 bits */ [INFO] [stdout] 588 ~ let code_len : u32 = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/lib.rs:585:29 [INFO] [stdout] | [INFO] [stdout] 585 | bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:591:59 [INFO] [stdout] | [INFO] [stdout] 591 | &mut prev_code_len, &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:599:39 [INFO] [stdout] | [INFO] [stdout] 599 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:608:5 [INFO] [stdout] | [INFO] [stdout] 608 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:656:3 [INFO] [stdout] | [INFO] [stdout] 656 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 656 - return BrotliResult::ResultSuccess; [INFO] [stdout] 656 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:616:5 [INFO] [stdout] | [INFO] [stdout] 616 | let code_len : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 631 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code_len` here [INFO] [stdout] | [INFO] [stdout] 616 ~ [INFO] [stdout] 617 | let mut bits : u32 = 0; [INFO] [stdout] ... [INFO] [stdout] 630 | } [INFO] [stdout] 631 ~ let code_len : u32 = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/lib.rs:622:43 [INFO] [stdout] | [INFO] [stdout] 622 | p_index += bits & bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:636:39 [INFO] [stdout] | [INFO] [stdout] 636 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:652:39 [INFO] [stdout] | [INFO] [stdout] 652 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:710:3 [INFO] [stdout] | [INFO] [stdout] 710 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 710 - return BrotliResult::ResultSuccess; [INFO] [stdout] 710 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:671:3 [INFO] [stdout] | [INFO] [stdout] 671 | for code_length_code_order in kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, code_length_code_order) in (s.sub_loop_counter..).zip(kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:671:84 [INFO] [stdout] | [INFO] [stdout] 671 | for code_length_code_order in kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `CODE_LENGTH_CODES` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:697:7 [INFO] [stdout] | [INFO] [stdout] 697 | space = space - (32 >> v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `space -= (32 >> v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:786:9 [INFO] [stdout] | [INFO] [stdout] 786 | let table_size : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 796 | / table_size = huffman::BrotliBuildSimpleHuffmanTable( [INFO] [stdout] 797 | | &mut table[offset..], HUFFMAN_TABLE_BITS as i32, &s.symbols_lists_array[..], s.symbol); [INFO] [stdout] | |__________________________________________________________________________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `table_size` here [INFO] [stdout] | [INFO] [stdout] 786 ~ [INFO] [stdout] 787 | if (s.symbol == 3) { [INFO] [stdout] ... [INFO] [stdout] 795 | BROTLI_LOG_UINT!(s.symbol); [INFO] [stdout] 796 ~ let table_size : u32 = huffman::BrotliBuildSimpleHuffmanTable( [INFO] [stdout] 797 ~ &mut table[offset..], HUFFMAN_TABLE_BITS as i32, &s.symbols_lists_array[..], s.symbol); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:798:9 [INFO] [stdout] | [INFO] [stdout] 798 | / match opt_table_size { [INFO] [stdout] 799 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stdout] 800 | | None => {}, [INFO] [stdout] 801 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:815:53 [INFO] [stdout] | [INFO] [stdout] 815 | ... &mut s.code_length_code_lengths, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 815 - &mut s.code_length_code_lengths, [INFO] [stdout] 815 + &s.code_length_code_lengths, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:816:53 [INFO] [stdout] | [INFO] [stdout] 816 | ... &mut s.code_length_histo); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 816 - &mut s.code_length_histo); [INFO] [stdout] 816 + &s.code_length_histo); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:822:9 [INFO] [stdout] | [INFO] [stdout] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, next_symbol_mut) in (0_u32..).zip(s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut())` [INFO] [stdout] | [INFO] [stdout] = note: `i` is of type `u32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:822:48 [INFO] [stdout] | [INFO] [stdout] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:839:9 [INFO] [stdout] | [INFO] [stdout] 839 | let table_size : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 854 | / table_size = huffman::BrotliBuildHuffmanTable(&mut table[offset..], HUFFMAN_TABLE_BITS as i32, [INFO] [stdout] 855 | | &s.symbols_lists_array[..], s.symbol_lists_index, &mut s.code_length_histo); [INFO] [stdout] | |_______________________________________________________________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `table_size` here [INFO] [stdout] | [INFO] [stdout] 839 ~ [INFO] [stdout] 840 | let mut result = ReadSymbolCodeLengths(alphabet_size, s, input); [INFO] [stdout] ... [INFO] [stdout] 853 | } [INFO] [stdout] 854 ~ let table_size : u32 = huffman::BrotliBuildHuffmanTable(&mut table[offset..], HUFFMAN_TABLE_BITS as i32, [INFO] [stdout] 855 ~ &s.symbols_lists_array[..], s.symbol_lists_index, &mut s.code_length_histo); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:841:9 [INFO] [stdout] | [INFO] [stdout] 841 | / match result { [INFO] [stdout] 842 | | BrotliResult::NeedsMoreInput => result = SafeReadSymbolCodeLengths(alphabet_size, s, input), [INFO] [stdout] 843 | | _ => {}, [INFO] [stdout] 844 | | } [INFO] [stdout] | |_________^ help: try: `if let BrotliResult::NeedsMoreInput = result { result = SafeReadSymbolCodeLengths(alphabet_size, s, input) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:856:9 [INFO] [stdout] | [INFO] [stdout] 856 | / match opt_table_size { [INFO] [stdout] 857 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stdout] 858 | | None => {}, [INFO] [stdout] 859 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:875:3 [INFO] [stdout] | [INFO] [stdout] 875 | / return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stdout] 876 | | + bit_reader::BrotliReadBits(br, nbits, input); [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 875 ~ prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stdout] 876 ~ + bit_reader::BrotliReadBits(br, nbits, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:871:3 [INFO] [stdout] | [INFO] [stdout] 871 | let code : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code` here [INFO] [stdout] | [INFO] [stdout] 871 ~ [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] 873 ~ let code : u32 = ReadSymbol(table, br, input); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:872:3 [INFO] [stdout] | [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] 874 | nbits = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `nbits` here [INFO] [stdout] | [INFO] [stdout] 872 ~ [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] 874 ~ let nbits : u32 = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:893:7 [INFO] [stdout] | [INFO] [stdout] 893 | return (true, index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 893 - return (true, index); [INFO] [stdout] 893 + (true, index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:895:10 [INFO] [stdout] | [INFO] [stdout] 895 | _ => return (true, block_length_index), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 895 - _ => return (true, block_length_index), [INFO] [stdout] 895 + _ => (true, block_length_index), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:890:27 [INFO] [stdout] | [INFO] [stdout] 890 | if (!SafeReadSymbol(&table, &mut br, &mut index, input)) { [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:890:35 [INFO] [stdout] | [INFO] [stdout] 890 | if (!SafeReadSymbol(&table, &mut br, &mut index, input)) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:919:5 [INFO] [stdout] | [INFO] [stdout] 919 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 919 - return true; [INFO] [stdout] 919 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:950:3 [INFO] [stdout] | [INFO] [stdout] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, item) in (0_u32..).zip(mtf[0..(upper_bound as usize + 1usize)].iter_mut())` [INFO] [stdout] | [INFO] [stdout] = note: `i` is of type `u32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:980:3 [INFO] [stdout] | [INFO] [stdout] 980 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1060:3 [INFO] [stdout] | [INFO] [stdout] 1060 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1060 - return result; [INFO] [stdout] 1060 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:993:14 [INFO] [stdout] | [INFO] [stdout] 993 | hcodes = mem::replace(&mut s.literal_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.literal_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:994:14 [INFO] [stdout] | [INFO] [stdout] 994 | htrees = mem::replace(&mut s.literal_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.literal_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:998:14 [INFO] [stdout] | [INFO] [stdout] 998 | hcodes = mem::replace(&mut s.insert_copy_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:999:14 [INFO] [stdout] | [INFO] [stdout] 999 | htrees = mem::replace(&mut s.insert_copy_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1004:14 [INFO] [stdout] | [INFO] [stdout] 1004 | hcodes = mem::replace(&mut s.distance_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.distance_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1005:14 [INFO] [stdout] | [INFO] [stdout] 1005 | htrees = mem::replace(&mut s.distance_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.distance_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1024:30 [INFO] [stdout] | [INFO] [stdout] 1024 | ... &mut s, [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1036:18 [INFO] [stdout] | [INFO] [stdout] 1036 | / mem::replace(&mut hcodes, [INFO] [stdout] 1037 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1039:18 [INFO] [stdout] | [INFO] [stdout] 1039 | / mem::replace(&mut htrees, [INFO] [stdout] 1040 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1043:18 [INFO] [stdout] | [INFO] [stdout] 1043 | / mem::replace(&mut hcodes, [INFO] [stdout] 1044 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1046:18 [INFO] [stdout] | [INFO] [stdout] 1046 | / mem::replace(&mut htrees, [INFO] [stdout] 1047 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1050:18 [INFO] [stdout] | [INFO] [stdout] 1050 | / mem::replace(&mut hcodes, [INFO] [stdout] 1051 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1053:18 [INFO] [stdout] | [INFO] [stdout] 1053 | / mem::replace(&mut htrees, [INFO] [stdout] 1054 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:1056:3 [INFO] [stdout] | [INFO] [stdout] 1056 | / match result { [INFO] [stdout] 1057 | | BrotliResult::ResultSuccess => s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE, [INFO] [stdout] 1058 | | _ => {}, [INFO] [stdout] 1059 | | } [INFO] [stdout] | |___^ help: try: `if let BrotliResult::ResultSuccess = result { s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1081:3 [INFO] [stdout] | [INFO] [stdout] 1081 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1135:43 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut local_context_map_table = mem::replace(&mut s.context_map_table, [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 1136 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |___________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1138:34 [INFO] [stdout] | [INFO] [stdout] 1138 | ... &mut local_context_map_table.slice_mut(), 0, None, &mut s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `local_context_map_table.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1138:85 [INFO] [stdout] | [INFO] [stdout] 1138 | ... &mut local_context_map_table.slice_mut(), 0, None, &mut s, input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1139:48 [INFO] [stdout] | [INFO] [stdout] 1139 | mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 1140 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |________________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut local_context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1230:3 [INFO] [stdout] | [INFO] [stdout] 1230 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1265:3 [INFO] [stdout] | [INFO] [stdout] 1265 | return retval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1265 - return retval; [INFO] [stdout] 1265 + retval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:1239:55 [INFO] [stdout] | [INFO] [stdout] 1239 | BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert_eq!(is_dist_context_map, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1239 - BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert_eq!(is_dist_context_map, false), [INFO] [stdout] 1239 + BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert!(!is_dist_context_map), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:1240:55 [INFO] [stdout] | [INFO] [stdout] 1240 | BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert_eq!(is_dist_context_map, true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1240 - BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert_eq!(is_dist_context_map, true), [INFO] [stdout] 1240 + BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert!(is_dist_context_map), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1247:23 [INFO] [stdout] | [INFO] [stdout] 1247 | context_map_arg = mem::replace(&mut s.dist_context_map, [INFO] [stdout] | _______________________^ [INFO] [stdout] 1248 | | AllocU8::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________^ help: consider using: `core::mem::take(&mut s.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1251:23 [INFO] [stdout] | [INFO] [stdout] 1251 | context_map_arg = mem::replace(&mut s.context_map, [INFO] [stdout] | _______________________^ [INFO] [stdout] 1252 | | AllocU8::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________^ help: consider using: `core::mem::take(&mut s.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1255:102 [INFO] [stdout] | [INFO] [stdout] 1255 | let retval = DecodeContextMapInner(context_map_size as u32, &mut num_htrees, &mut context_map_arg, &mut s, input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1258:43 [INFO] [stdout] | [INFO] [stdout] 1258 | mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 1259 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut context_map_arg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1262:38 [INFO] [stdout] | [INFO] [stdout] 1262 | mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1263 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut context_map_arg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1321:3 [INFO] [stdout] | [INFO] [stdout] 1321 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1321 - return true; [INFO] [stdout] 1321 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1349:3 [INFO] [stdout] | [INFO] [stdout] 1349 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1349 - return true; [INFO] [stdout] 1349 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1337:3 [INFO] [stdout] | [INFO] [stdout] 1337 | let context_mode : u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1346 | context_mode = s.context_modes.slice()[s.block_type_length_state.block_type_rb[1] as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `context_mode` here [INFO] [stdout] | [INFO] [stdout] 1337 ~ [INFO] [stdout] 1338 | let context_offset : u32; [INFO] [stdout] ... [INFO] [stdout] 1345 | // s.literal_htree = s.literal_hgroup.htrees[s.literal_htree_index]; // redundant [INFO] [stdout] 1346 ~ let context_mode : u8 = s.context_modes.slice()[s.block_type_length_state.block_type_rb[1] as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1338:3 [INFO] [stdout] | [INFO] [stdout] 1338 | let context_offset : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1342 | context_offset = s.block_type_length_state.block_type_rb[1] << kLiteralContextBits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `context_offset` here [INFO] [stdout] | [INFO] [stdout] 1338 ~ [INFO] [stdout] 1339 | if !DecodeBlockTypeAndLength(safe, &mut s.block_type_length_state, &mut s.br, 0, input) { [INFO] [stdout] 1340 | return false; [INFO] [stdout] 1341 | } [INFO] [stdout] 1342 ~ let context_offset : u32 = s.block_type_length_state.block_type_rb[1] << kLiteralContextBits; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1373:3 [INFO] [stdout] | [INFO] [stdout] 1373 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1382:3 [INFO] [stdout] | [INFO] [stdout] 1382 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1382 - return true; [INFO] [stdout] 1382 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1387:3 [INFO] [stdout] | [INFO] [stdout] 1387 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1395:3 [INFO] [stdout] | [INFO] [stdout] 1395 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1399:3 [INFO] [stdout] | [INFO] [stdout] 1399 | return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1399 - return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stdout] 1399 + DecodeCommandBlockSwitchInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1405:3 [INFO] [stdout] | [INFO] [stdout] 1405 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1416:3 [INFO] [stdout] | [INFO] [stdout] 1416 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1416 - return true; [INFO] [stdout] 1416 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1421:3 [INFO] [stdout] | [INFO] [stdout] 1421 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1430:3 [INFO] [stdout] | [INFO] [stdout] 1430 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1434:3 [INFO] [stdout] | [INFO] [stdout] 1434 | return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1434 - return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stdout] 1434 + DecodeDistanceBlockSwitchInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1437:20 [INFO] [stdout] | [INFO] [stdout] 1437 | fn WriteRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1470:3 [INFO] [stdout] | [INFO] [stdout] 1470 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1470 - return BrotliResult::ResultSuccess; [INFO] [stdout] 1470 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1442:3 [INFO] [stdout] | [INFO] [stdout] 1442 | let pos : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1442 ~ [INFO] [stdout] 1443 ~ let pos : usize = if s.pos > s.ringbuffer_size { [INFO] [stdout] 1444 ~ s.ringbuffer_size as usize [INFO] [stdout] 1445 | } else { [INFO] [stdout] 1446 ~ s.pos as usize [INFO] [stdout] 1447 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1449:8 [INFO] [stdout] | [INFO] [stdout] 1449 | (s.rb_roundtrips as usize * s.ringbuffer_size as usize) + pos as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.rb_roundtrips` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1449:65 [INFO] [stdout] | [INFO] [stdout] 1449 | (s.rb_roundtrips as usize * s.ringbuffer_size as usize) + pos as usize; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1450:18 [INFO] [stdout] | [INFO] [stdout] 1450 | let to_write = (partial_pos_rb - s.partial_pos_out) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(partial_pos_rb - s.partial_pos_out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1451:25 [INFO] [stdout] | [INFO] [stdout] 1451 | let mut num_written = *available_out as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1458:21 [INFO] [stdout] | [INFO] [stdout] 1458 | let start_index = (s.partial_pos_out & s.ringbuffer_mask as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(s.partial_pos_out & s.ringbuffer_mask as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1459:66 [INFO] [stdout] | [INFO] [stdout] 1459 | let start = &s.ringbuffer.slice()[start_index .. start_index + num_written as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1460:45 [INFO] [stdout] | [INFO] [stdout] 1460 | output[*output_offset .. *output_offset + num_written as usize].clone_from_slice(start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1465:24 [INFO] [stdout] | [INFO] [stdout] 1465 | s.partial_pos_out += num_written as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1473:34 [INFO] [stdout] | [INFO] [stdout] 1473 | fn CopyUncompressedBlockToOutput<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:13 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:33 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:46 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:66 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:82 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1527:5 [INFO] [stdout] | [INFO] [stdout] 1527 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1576:3 [INFO] [stdout] | [INFO] [stdout] 1576 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1576 - return true; [INFO] [stdout] 1576 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1565:7 [INFO] [stdout] | [INFO] [stdout] 1565 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1570:7 [INFO] [stdout] | [INFO] [stdout] 1570 | if (s.custom_dict.slice().len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.custom_dict.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1580:25 [INFO] [stdout] | [INFO] [stdout] 1580 | pub fn ReadContextModes<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1602:3 [INFO] [stdout] | [INFO] [stdout] 1602 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1602 - return BrotliResult::ResultSuccess; [INFO] [stdout] 1602 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:1588:3 [INFO] [stdout] | [INFO] [stdout] 1588 | / for context_mode_iter in s.context_modes.slice_mut()[i as usize .. [INFO] [stdout] 1589 | | (s.block_type_length_state.num_block_types[0] [INFO] [stdout] 1590 | | as usize)].iter_mut() { [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] help: consider using [INFO] [stdout] | [INFO] [stdout] 1588 ~ for (i, context_mode_iter) in (s.loop_counter..).zip(s.context_modes.slice_mut()[i as usize .. [INFO] [stdout] 1589 + (s.block_type_length_state.num_block_types[0] [INFO] [stdout] 1590 ~ as usize)].iter_mut()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1605:35 [INFO] [stdout] | [INFO] [stdout] 1605 | pub fn TakeDistanceFromRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1620:17 [INFO] [stdout] | [INFO] [stdout] 1620 | let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] | _________________^ [INFO] [stdout] 1621 | | (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) as i32 & 0x3; [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1620 ~ let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] 1621 ~ (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) & 0x3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1620:18 [INFO] [stdout] | [INFO] [stdout] 1620 | let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.dist_rb_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1621:50 [INFO] [stdout] | [INFO] [stdout] 1621 | (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) as i32 & 0x3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `distance_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1639:5 [INFO] [stdout] | [INFO] [stdout] 1639 | return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1639 - return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stdout] 1639 + bit_reader::BrotliSafeReadBits(br, n_bits, val, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1642:5 [INFO] [stdout] | [INFO] [stdout] 1642 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1642 - return true; [INFO] [stdout] 1642 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1647:29 [INFO] [stdout] | [INFO] [stdout] 1647 | pub fn ReadDistanceInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1707:3 [INFO] [stdout] | [INFO] [stdout] 1707 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1707 - return true; [INFO] [stdout] 1707 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `bit_reader::BrotliBitReaderRestoreState` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1694:62 [INFO] [stdout] | [INFO] [stdout] 1694 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1694 - bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stdout] 1694 + bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1711:28 [INFO] [stdout] | [INFO] [stdout] 1711 | pub fn ReadCommandInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1755:3 [INFO] [stdout] | [INFO] [stdout] 1755 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1755 - return true; [INFO] [stdout] 1755 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1721:3 [INFO] [stdout] | [INFO] [stdout] 1721 | let v : prefix::CmdLutElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1733 | v = prefix::kCmdLut[cmd_code as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `v` here [INFO] [stdout] | [INFO] [stdout] 1721 ~ [INFO] [stdout] 1722 | let mut memento = bit_reader::BrotliBitReaderState::default(); [INFO] [stdout] ... [INFO] [stdout] 1732 | } [INFO] [stdout] 1733 ~ let v : prefix::CmdLutElement = prefix::kCmdLut[cmd_code as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1763:3 [INFO] [stdout] | [INFO] [stdout] 1763 | return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1763 - return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stdout] 1763 + bit_reader::BrotliWarmupBitReader(br, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1771:3 [INFO] [stdout] | [INFO] [stdout] 1771 | return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1771 - return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stdout] 1771 + bit_reader::BrotliCheckInputAmount(br, num) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `clone_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1799:34 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1799 - local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] 1799 + local_array.clone_from_slice(&data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1799:44 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1799:64 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `clone_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1800:70 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1800 - data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] 1800 + data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&local_array); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1800:10 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1800:30 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2173:3 [INFO] [stdout] | [INFO] [stdout] 2173 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2173 - return result; [INFO] [stdout] 2173 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1831:34 [INFO] [stdout] | [INFO] [stdout] 1831 | let mut saved_literal_hgroup = core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] | __________________________________^ [INFO] [stdout] 1832 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.literal_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1833:35 [INFO] [stdout] | [INFO] [stdout] 1833 | let mut saved_distance_hgroup = core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1834 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.distance_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1835:38 [INFO] [stdout] | [INFO] [stdout] 1835 | let mut saved_insert_copy_hgroup = core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1836 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2086:23 [INFO] [stdout] | [INFO] [stdout] 2086 | memmove16(&mut s.ringbuffer.slice_mut(), dst_start, src_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `s.ringbuffer.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2107:27 [INFO] [stdout] | [INFO] [stdout] 2107 | memmove16(&mut s.ringbuffer.slice_mut(), dst_start + 16, src_start + 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `s.ringbuffer.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2162:17 [INFO] [stdout] | [INFO] [stdout] 2162 | / core::mem::replace(&mut saved_literal_hgroup, [INFO] [stdout] 2163 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_literal_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2166:17 [INFO] [stdout] | [INFO] [stdout] 2166 | / core::mem::replace(&mut saved_distance_hgroup, [INFO] [stdout] 2167 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_distance_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2170:17 [INFO] [stdout] | [INFO] [stdout] 2170 | / core::mem::replace(&mut saved_insert_copy_hgroup, [INFO] [stdout] 2171 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_insert_copy_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2177:5 [INFO] [stdout] | [INFO] [stdout] 2177 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2181:5 [INFO] [stdout] | [INFO] [stdout] 2181 | return ProcessCommandsInternal(false, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2181 - return ProcessCommandsInternal(false, s, input); [INFO] [stdout] 2181 + ProcessCommandsInternal(false, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2185:5 [INFO] [stdout] | [INFO] [stdout] 2185 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2189:5 [INFO] [stdout] | [INFO] [stdout] 2189 | return ProcessCommandsInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2189 - return ProcessCommandsInternal(true, s, input); [INFO] [stdout] 2189 + ProcessCommandsInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2195:31 [INFO] [stdout] | [INFO] [stdout] 2195 | pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:2195:1 [INFO] [stdout] | [INFO] [stdout] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stdout] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stdout] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stdout] 2199 | | mut available_out : &mut usize, mut output_offset : &mut usize, mut output : &mut [u8], [INFO] [stdout] 2200 | | mut total_out : &mut usize, mut s : &mut BrotliState) [INFO] [stdout] 2201 | | -> BrotliResult { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2680:3 [INFO] [stdout] | [INFO] [stdout] 2680 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2680 - return result; [INFO] [stdout] 2680 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 8]` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:2205:36 [INFO] [stdout] | [INFO] [stdout] 2205 | let mut saved_buffer : [u8; 8] = s.buffer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2236:16 [INFO] [stdout] | [INFO] [stdout] 2236 | if s.ringbuffer.slice().len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2237:60 [INFO] [stdout] | [INFO] [stdout] 2237 | let _result = WriteRingBuffer(available_out, &mut output, &mut output_offset, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2237:73 [INFO] [stdout] | [INFO] [stdout] 2237 | let _result = WriteRingBuffer(available_out, &mut output, &mut output_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2238:23 [INFO] [stdout] | [INFO] [stdout] 2238 | &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2238:39 [INFO] [stdout] | [INFO] [stdout] 2238 | &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2330:15 [INFO] [stdout] | [INFO] [stdout] 2330 | if (s.block_type_length_state.block_type_trees.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.block_type_length_state.block_type_trees.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2347:42 [INFO] [stdout] | [INFO] [stdout] 2347 | result = DecodeMetaBlockLength(&mut s, local_input); // Reads 2 - 31 bits. [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:2356:11 [INFO] [stdout] | [INFO] [stdout] 2356 | / if (s.is_metadata != 0 || s.is_uncompressed != 0) { [INFO] [stdout] 2357 | | if (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stdout] 2358 | | result = BROTLI_FAILURE(); [INFO] [stdout] 2359 | | break; [INFO] [stdout] 2360 | | } [INFO] [stdout] 2361 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2356 ~ if ((s.is_metadata != 0 || s.is_uncompressed != 0)) { [INFO] [stdout] 2357 ~ && (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stdout] 2358 | result = BROTLI_FAILURE(); [INFO] [stdout] 2359 | break; [INFO] [stdout] 2360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:2370:11 [INFO] [stdout] | [INFO] [stdout] 2370 | / if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] 2371 | | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] 2372 | | result = BROTLI_FAILURE(); [INFO] [stdout] 2373 | | break; [INFO] [stdout] 2374 | | } [INFO] [stdout] 2375 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2370 ~ if (s.ringbuffer.slice().len() == 0) [INFO] [stdout] 2371 ~ && (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] 2372 | result = BROTLI_FAILURE(); [INFO] [stdout] 2373 | break; [INFO] [stdout] 2374 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2370:15 [INFO] [stdout] | [INFO] [stdout] 2370 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2371:43 [INFO] [stdout] | [INFO] [stdout] 2371 | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:15 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:35 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:48 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:68 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:84 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:2406:11 [INFO] [stdout] | [INFO] [stdout] 2406 | / match result { [INFO] [stdout] 2407 | | BrotliResult::ResultSuccess => s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE, [INFO] [stdout] 2408 | | _ => {}, [INFO] [stdout] 2409 | | } [INFO] [stdout] | |___________^ help: try: `if let BrotliResult::ResultSuccess = result { s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2434:39 [INFO] [stdout] | [INFO] [stdout] 2434 | let mut new_huffman_table = mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2435 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.block_type_length_state.block_type_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2438:90 [INFO] [stdout] | [INFO] [stdout] 2438 | ... new_huffman_table.slice_mut(), tree_offset as usize, None, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2450:39 [INFO] [stdout] | [INFO] [stdout] 2450 | let mut new_huffman_table = mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2451 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.block_type_length_state.block_len_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2453:74 [INFO] [stdout] | [INFO] [stdout] 2453 | new_huffman_table.slice_mut(), tree_offset as usize, None, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2496:15 [INFO] [stdout] | [INFO] [stdout] 2496 | if (s.context_modes.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.context_modes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2505:37 [INFO] [stdout] | [INFO] [stdout] 2505 | result = ReadContextModes(&mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:2514:96 [INFO] [stdout] | [INFO] [stdout] 2514 | result = DecodeContextMap((s.block_type_length_state.num_block_types[0] as usize) << kLiteralContextBits as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `kLiteralContextBits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2515:44 [INFO] [stdout] | [INFO] [stdout] 2515 | ... false, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/lib.rs:2522:11 [INFO] [stdout] | [INFO] [stdout] 2522 | ... for context_map_item in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, context_map_item) in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:2522:121 [INFO] [stdout] | [INFO] [stdout] 2522 | ...num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `kLiteralContextBits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2553:17 [INFO] [stdout] | [INFO] [stdout] 2553 | if (s.literal_hgroup.codes.slice().len() == 0 || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.literal_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2554:17 [INFO] [stdout] | [INFO] [stdout] 2554 | s.insert_copy_hgroup.codes.slice().len() == 0 || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.insert_copy_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2555:17 [INFO] [stdout] | [INFO] [stdout] 2555 | s.distance_hgroup.codes.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.distance_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2564:59 [INFO] [stdout] | [INFO] [stdout] 2564 | result = HuffmanTreeGroupDecode(s.loop_counter, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:2589:11 [INFO] [stdout] | [INFO] [stdout] 2589 | / match result { [INFO] [stdout] 2590 | | BrotliResult::NeedsMoreInput => result = SafeProcessCommands(s, local_input), [INFO] [stdout] 2591 | | _ => {}, [INFO] [stdout] 2592 | | } [INFO] [stdout] | |___________^ help: try: `if let BrotliResult::NeedsMoreInput = result { result = SafeProcessCommands(s, local_input) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:36 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:56 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:69 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:89 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:105 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2667:15 [INFO] [stdout] | [INFO] [stdout] 2667 | if (s.ringbuffer.slice().len() != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:38 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:58 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:71 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:91 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:107 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1035:5 [INFO] [stdout] | [INFO] [stdout] 1035 | / mem::replace(&mut s.literal_hgroup.codes, [INFO] [stdout] 1036 | | mem::replace(&mut hcodes, [INFO] [stdout] 1037 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1035 | let _ = mem::replace(&mut s.literal_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1038:5 [INFO] [stdout] | [INFO] [stdout] 1038 | / mem::replace(&mut s.literal_hgroup.htrees, [INFO] [stdout] 1039 | | mem::replace(&mut htrees, [INFO] [stdout] 1040 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1038 | let _ = mem::replace(&mut s.literal_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1042:5 [INFO] [stdout] | [INFO] [stdout] 1042 | / mem::replace(&mut s.insert_copy_hgroup.codes, [INFO] [stdout] 1043 | | mem::replace(&mut hcodes, [INFO] [stdout] 1044 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1042 | let _ = mem::replace(&mut s.insert_copy_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1045:5 [INFO] [stdout] | [INFO] [stdout] 1045 | / mem::replace(&mut s.insert_copy_hgroup.htrees, [INFO] [stdout] 1046 | | mem::replace(&mut htrees, [INFO] [stdout] 1047 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1045 | let _ = mem::replace(&mut s.insert_copy_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1049:5 [INFO] [stdout] | [INFO] [stdout] 1049 | / mem::replace(&mut s.distance_hgroup.codes, [INFO] [stdout] 1050 | | mem::replace(&mut hcodes, [INFO] [stdout] 1051 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1049 | let _ = mem::replace(&mut s.distance_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1052:5 [INFO] [stdout] | [INFO] [stdout] 1052 | / mem::replace(&mut s.distance_hgroup.htrees, [INFO] [stdout] 1053 | | mem::replace(&mut htrees, [INFO] [stdout] 1054 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1052 | let _ = mem::replace(&mut s.distance_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | / mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] 1140 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1139 | let _ = mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1258:5 [INFO] [stdout] | [INFO] [stdout] 1258 | / mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] 1259 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1258 | let _ = mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1262:5 [INFO] [stdout] | [INFO] [stdout] 1262 | / mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] 1263 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1262 | let _ = mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2161:3 [INFO] [stdout] | [INFO] [stdout] 2161 | / core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] 2162 | | core::mem::replace(&mut saved_literal_hgroup, [INFO] [stdout] 2163 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2161 | let _ = core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2165:3 [INFO] [stdout] | [INFO] [stdout] 2165 | / core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] 2166 | | core::mem::replace(&mut saved_distance_hgroup, [INFO] [stdout] 2167 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2165 | let _ = core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2169:3 [INFO] [stdout] | [INFO] [stdout] 2169 | / core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] 2170 | | core::mem::replace(&mut saved_insert_copy_hgroup, [INFO] [stdout] 2171 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2169 | let _ = core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2439:11 [INFO] [stdout] | [INFO] [stdout] 2439 | / mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] 2440 | | new_huffman_table); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2439 | let _ = mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2454:11 [INFO] [stdout] | [INFO] [stdout] 2454 | / mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] 2455 | | new_huffman_table); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2454 | let _ = mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/huffman/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / core::mem::replace(&mut self.htrees, [INFO] [stdout] 59 | | alloc_u32.alloc_cell(ntrees as usize)); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = core::mem::replace(&mut self.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/huffman/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / core::mem::replace(&mut self.codes, [INFO] [stdout] 61 | | alloc_hc.alloc_cell(ntrees as usize * BROTLI_HUFFMAN_MAX_TABLE_SIZE as usize)); [INFO] [stdout] | |_________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 60 | let _ = core::mem::replace(&mut self.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bin/brot.rs:128:15 [INFO] [stdout] | [INFO] [stdout] 128 | try!(_write_all(&mut w, &output.slice()[..output_offset])); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bin/brot.rs:146:11 [INFO] [stdout] | [INFO] [stdout] 146 | try!(_write_all(&mut w, &output.slice()[..output_offset])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/bin/integration_tests.rs:20:13 [INFO] [stdout] | [INFO] [stdout] 20 | fn read(self : &mut Self, buf : &mut [u8]) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] = note: `#[warn(clippy::needless_arbitrary_self_type)]` on by default [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 20 - fn read(self : &mut Self, buf : &mut [u8]) -> io::Result { [INFO] [stdout] 20 + fn read(&mut self, buf : &mut [u8]) -> io::Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/bin/integration_tests.rs:34:14 [INFO] [stdout] | [INFO] [stdout] 34 | fn write(self : &mut Self, buf : &[u8]) -> io::Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 34 - fn write(self : &mut Self, buf : &[u8]) -> io::Result { [INFO] [stdout] 34 + fn write(&mut self, buf : &[u8]) -> io::Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type of the `self` parameter does not need to be arbitrary [INFO] [stdout] --> src/bin/integration_tests.rs:41:14 [INFO] [stdout] | [INFO] [stdout] 41 | fn flush(self : &mut Self) -> io::Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_arbitrary_self_type [INFO] [stdout] help: remove the type [INFO] [stdout] | [INFO] [stdout] 41 - fn flush(self : &mut Self) -> io::Result<()> { [INFO] [stdout] 41 + fn flush(&mut self) -> io::Result<()> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bin/brot.rs:128:15 [INFO] [stdout] | [INFO] [stdout] 128 | try!(_write_all(&mut w, &output.slice()[..output_offset])); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bin/brot.rs:146:11 [INFO] [stdout] | [INFO] [stdout] 146 | try!(_write_all(&mut w, &output.slice()[..output_offset])); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:34:5 [INFO] [stdout] | [INFO] [stdout] 34 | return !((0xffffffffu32) << n); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 34 - return !((0xffffffffu32) << n); [INFO] [stdout] 34 + !((0xffffffffu32) << n) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | return kBitMask[n as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 36 - return kBitMask[n as usize]; [INFO] [stdout] 36 + kBitMask[n as usize] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | / return BrotliBitReader { [INFO] [stdout] 50 | | val_ : 0, [INFO] [stdout] 51 | | bit_pos_ : 0, [INFO] [stdout] 52 | | next_in : 0, [INFO] [stdout] 53 | | avail_in : 0, [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 ~ BrotliBitReader { [INFO] [stdout] 50 + val_ : 0, [INFO] [stdout] 51 + bit_pos_ : 0, [INFO] [stdout] 52 + next_in : 0, [INFO] [stdout] 53 + avail_in : 0, [INFO] [stdout] 54 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | / return BrotliBitReaderState { [INFO] [stdout] 68 | | val_ : 0, [INFO] [stdout] 69 | | bit_pos_ : 0, [INFO] [stdout] 70 | | next_in : 0, [INFO] [stdout] 71 | | avail_in : 0, [INFO] [stdout] 72 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ BrotliBitReaderState { [INFO] [stdout] 68 + val_ : 0, [INFO] [stdout] 69 + bit_pos_ : 0, [INFO] [stdout] 70 + next_in : 0, [INFO] [stdout] 71 + avail_in : 0, [INFO] [stdout] 72 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:79:3 [INFO] [stdout] | [INFO] [stdout] 79 | / return BrotliBitReaderState { val_ : from.val_, [INFO] [stdout] 80 | | bit_pos_ : from.bit_pos_, [INFO] [stdout] 81 | | next_in : from.next_in, [INFO] [stdout] 82 | | avail_in : from.avail_in }; [INFO] [stdout] | |________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 79 ~ BrotliBitReaderState { val_ : from.val_, [INFO] [stdout] 80 + bit_pos_ : from.bit_pos_, [INFO] [stdout] 81 + next_in : from.next_in, [INFO] [stdout] 82 ~ avail_in : from.avail_in } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:95:3 [INFO] [stdout] | [INFO] [stdout] 95 | return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_; [INFO] [stdout] 95 + ((::core::mem::size_of::() as u32) << 3) - br.bit_pos_ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:101:3 [INFO] [stdout] | [INFO] [stdout] 101 | return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return br.avail_in + (BrotliGetAvailableBits(br) >> 3); [INFO] [stdout] 101 + br.avail_in + (BrotliGetAvailableBits(br) >> 3) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:108:3 [INFO] [stdout] | [INFO] [stdout] 108 | return br.avail_in >= num; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 108 - return br.avail_in >= num; [INFO] [stdout] 108 + br.avail_in >= num [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:117:3 [INFO] [stdout] | [INFO] [stdout] 117 | return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return (two_byte[0] as u16) | ((two_byte[1] as u16) << 8); [INFO] [stdout] 117 + (two_byte[0] as u16) | ((two_byte[1] as u16) << 8) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:124:3 [INFO] [stdout] | [INFO] [stdout] 124 | / return (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stdout] 125 | | | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24); [INFO] [stdout] | |_____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 124 ~ (four_byte[0] as u32) | ((four_byte[1] as u32) << 8) [INFO] [stdout] 125 ~ | ((four_byte[2] as u32) << 16) | ((four_byte[3] as u32) << 24) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:132:3 [INFO] [stdout] | [INFO] [stdout] 132 | / return (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stdout] 133 | | | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stdout] 134 | | | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stdout] 135 | | | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56); [INFO] [stdout] | |_______________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 132 ~ (eight_byte[0] as u64) | ((eight_byte[1] as u64) << 8) [INFO] [stdout] 133 + | ((eight_byte[2] as u64) << 16) | ((eight_byte[3] as u64) << 24) [INFO] [stdout] 134 + | ((eight_byte[4] as u64) << 32) | ((eight_byte[5] as u64) << 40) [INFO] [stdout] 135 ~ | ((eight_byte[6] as u64) << 48) | ((eight_byte[7] as u64) << 56) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:254:3 [INFO] [stdout] | [INFO] [stdout] 254 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return true; [INFO] [stdout] 254 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:261:3 [INFO] [stdout] | [INFO] [stdout] 261 | return br.val_ >> br.bit_pos_; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 261 - return br.val_ >> br.bit_pos_; [INFO] [stdout] 261 + br.val_ >> br.bit_pos_ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:270:3 [INFO] [stdout] | [INFO] [stdout] 270 | return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 270 - return (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32; [INFO] [stdout] 270 + (BrotliGetBitsUnmasked(br) & (0xffffffffu32 as reg_t)) as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:277:3 [INFO] [stdout] | [INFO] [stdout] 277 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 277 - return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] 277 + (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:285:3 [INFO] [stdout] | [INFO] [stdout] 285 | return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 285 - return (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits); [INFO] [stdout] 285 + (BrotliGetBitsUnmasked(br) as u32) & BitMask(n_bits) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:298:3 [INFO] [stdout] | [INFO] [stdout] 298 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 298 - return true; [INFO] [stdout] 298 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:340:5 [INFO] [stdout] | [INFO] [stdout] 340 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 340 - return val; [INFO] [stdout] 340 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:348:5 [INFO] [stdout] | [INFO] [stdout] 348 | return low_val | (high_val << 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 348 - return low_val | (high_val << 16); [INFO] [stdout] 348 + low_val | (high_val << 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:361:5 [INFO] [stdout] | [INFO] [stdout] 361 | return val; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return val; [INFO] [stdout] 361 + val [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:369:5 [INFO] [stdout] | [INFO] [stdout] 369 | return low_val | (high_val << 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 369 - return low_val | (high_val << 16); [INFO] [stdout] 369 + low_val | (high_val << 16) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:383:3 [INFO] [stdout] | [INFO] [stdout] 383 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 383 - return true; [INFO] [stdout] 383 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:394:3 [INFO] [stdout] | [INFO] [stdout] 394 | return pad_bits == 0; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 394 - return pad_bits == 0; [INFO] [stdout] 394 + pad_bits == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:411:3 [INFO] [stdout] | [INFO] [stdout] 411 | return -1; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 411 - return -1; [INFO] [stdout] 411 + -1 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/bit_reader/mod.rs:405:43 [INFO] [stdout] | [INFO] [stdout] 405 | return ((BrotliGetBitsUnmasked(br) >> ((offset << 3)) as u32) & 0xFF) as i32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `((offset << 3))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bit_reader/mod.rs:456:3 [INFO] [stdout] | [INFO] [stdout] 456 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 456 - return true; [INFO] [stdout] 456 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/bit_reader/mod.rs:443:3 [INFO] [stdout] | [INFO] [stdout] 443 | / if BrotliGetAvailableBits(br) == 0 { [INFO] [stdout] 444 | | if !BrotliPullByte(br, input) { [INFO] [stdout] 445 | | return false; [INFO] [stdout] 446 | | } [INFO] [stdout] 447 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 443 ~ if BrotliGetAvailableBits(br) == 0 [INFO] [stdout] 444 ~ && !BrotliPullByte(br, input) { [INFO] [stdout] 445 | return false; [INFO] [stdout] 446 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:477:9 [INFO] [stdout] | [INFO] [stdout] 477 | assert_eq!(ret, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 477 - assert_eq!(ret, true); [INFO] [stdout] 477 + assert!(ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:491:9 [INFO] [stdout] | [INFO] [stdout] 491 | assert_eq!(ret, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 491 - assert_eq!(ret, false); [INFO] [stdout] 491 + assert!(!ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:507:12 [INFO] [stdout] | [INFO] [stdout] 507 | assert_eq!(ret, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 507 - assert_eq!(ret, true); [INFO] [stdout] 507 + assert!(ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:521:12 [INFO] [stdout] | [INFO] [stdout] 521 | assert_eq!(ret, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 521 - assert_eq!(ret, true); [INFO] [stdout] 521 + assert!(ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:535:12 [INFO] [stdout] | [INFO] [stdout] 535 | assert_eq!(ret, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 535 - assert_eq!(ret, true); [INFO] [stdout] 535 + assert!(ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/bit_reader/mod.rs:550:12 [INFO] [stdout] | [INFO] [stdout] 550 | assert_eq!(ret, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 550 - assert_eq!(ret, false); [INFO] [stdout] 550 + assert!(!ret); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/huffman/tests.rs:110:66 [INFO] [stdout] | [INFO] [stdout] 110 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 0); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 110 - let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 0); [INFO] [stdout] 110 + let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &val, 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/huffman/tests.rs:123:66 [INFO] [stdout] | [INFO] [stdout] 123 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 123 - let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 1); [INFO] [stdout] 123 + let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &val, 1); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/huffman/tests.rs:140:66 [INFO] [stdout] | [INFO] [stdout] 140 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 2); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 140 - let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 2); [INFO] [stdout] 140 + let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &val, 2); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/huffman/tests.rs:153:66 [INFO] [stdout] | [INFO] [stdout] 153 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 3); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 153 - let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 3); [INFO] [stdout] 153 + let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &val, 3); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `BrotliBuildSimpleHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/huffman/tests.rs:168:66 [INFO] [stdout] | [INFO] [stdout] 168 | let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 4); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 168 - let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &mut val, 4); [INFO] [stdout] 168 + let goal_size = BrotliBuildSimpleHuffmanTable(&mut table, 8, &val, 4); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `eq` can be confused for the standard trait method `std::cmp::PartialEq::eq` [INFO] [stdout] --> src/huffman/mod.rs:32:3 [INFO] [stdout] | [INFO] [stdout] 32 | / pub fn eq(&self, other: &Self) -> bool { [INFO] [stdout] 33 | | return self.value == other.value && self.bits == other.bits; [INFO] [stdout] 34 | | } [INFO] [stdout] | |___^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::cmp::PartialEq` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:33:7 [INFO] [stdout] | [INFO] [stdout] 33 | return self.value == other.value && self.bits == other.bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return self.value == other.value && self.bits == other.bits; [INFO] [stdout] 33 + self.value == other.value && self.bits == other.bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:39:6 [INFO] [stdout] | [INFO] [stdout] 39 | return HuffmanCode { value : 0, bits : 0}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return HuffmanCode { value : 0, bits : 0}; [INFO] [stdout] 39 + HuffmanCode { value : 0, bits : 0} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:55:20 [INFO] [stdout] | [INFO] [stdout] 55 | self.reset(&mut alloc_u32, &mut alloc_hc); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `alloc_u32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | self.reset(&mut alloc_u32, &mut alloc_hc); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `alloc_hc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/huffman/mod.rs:73:25 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 73 - pub fn get_tree_mut<'a>(self :&'a mut Self, index : u32) -> &'a mut [HuffmanCode] { [INFO] [stdout] 73 + pub fn get_tree_mut(self :&mut Self, index : u32) -> &mut [HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:75:9 [INFO] [stdout] | [INFO] [stdout] 75 | return &mut self.codes.slice_mut()[start..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return &mut self.codes.slice_mut()[start..]; [INFO] [stdout] 75 + &mut self.codes.slice_mut()[start..] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/huffman/mod.rs:78:21 [INFO] [stdout] | [INFO] [stdout] 78 | pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 78 - pub fn get_tree<'a>(self :&'a Self, index : u32) -> &'a [HuffmanCode] { [INFO] [stdout] 78 + pub fn get_tree(self :&Self, index : u32) -> &[HuffmanCode] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | return & self.codes.slice()[start..]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 80 - return & self.codes.slice()[start..]; [INFO] [stdout] 80 + & self.codes.slice()[start..] [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/huffman/mod.rs:83:29 [INFO] [stdout] | [INFO] [stdout] 83 | alloc_u32.free_cell(core::mem::replace(&mut self.htrees, [INFO] [stdout] | _____________________________^ [INFO] [stdout] 84 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/huffman/mod.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | alloc_hc.free_cell(core::mem::replace(&mut self.codes, [INFO] [stdout] | ____________________________^ [INFO] [stdout] 86 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:103:7 [INFO] [stdout] | [INFO] [stdout] 103 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 103 - return ret; [INFO] [stdout] 103 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `index` is used as a loop counter [INFO] [stdout] --> src/huffman/mod.rs:99:7 [INFO] [stdout] | [INFO] [stdout] 99 | for htree in self.htrees.slice() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (index, htree) in self.htrees.slice().iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:110:9 [INFO] [stdout] | [INFO] [stdout] 110 | / return HuffmanTreeGroup:: { [INFO] [stdout] 111 | | htrees : AllocU32::AllocatedMemory::default(), [INFO] [stdout] 112 | | codes : AllocHC::AllocatedMemory::default(), [INFO] [stdout] 113 | | alphabet_size : 0, [INFO] [stdout] 114 | | num_htrees : 0, [INFO] [stdout] 115 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 110 ~ HuffmanTreeGroup:: { [INFO] [stdout] 111 + htrees : AllocU32::AllocatedMemory::default(), [INFO] [stdout] 112 + codes : AllocHC::AllocatedMemory::default(), [INFO] [stdout] 113 + alphabet_size : 0, [INFO] [stdout] 114 + num_htrees : 0, [INFO] [stdout] 115 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:166:3 [INFO] [stdout] | [INFO] [stdout] 166 | return kReverseBits[num as usize] as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 166 - return kReverseBits[num as usize] as u32; [INFO] [stdout] 166 + kReverseBits[num as usize] as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:199:3 [INFO] [stdout] | [INFO] [stdout] 199 | return len - root_bits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 199 - return len - root_bits; [INFO] [stdout] 199 + len - root_bits [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/huffman/mod.rs:269:8 [INFO] [stdout] | [INFO] [stdout] 269 | if !(bits <= BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(bits > BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as i32)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/huffman/mod.rs:211:11 [INFO] [stdout] | [INFO] [stdout] 211 | BROTLI_REVERSE_BITS_MAX as usize); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `BROTLI_REVERSE_BITS_MAX` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:262:22 [INFO] [stdout] | [INFO] [stdout] 262 | ReplicateValue(&mut table, BrotliReverseBits(key) as usize, step, table_size, code); [INFO] [stdout] | ^^^^^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/huffman/mod.rs:323:8 [INFO] [stdout] | [INFO] [stdout] 323 | if !(bits <= table_bits) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(bits > table_bits)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:373:3 [INFO] [stdout] | [INFO] [stdout] 373 | return total_size as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return total_size as u32; [INFO] [stdout] 373 + total_size as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:315:22 [INFO] [stdout] | [INFO] [stdout] 315 | ReplicateValue(&mut root_table, table_free_offset + BrotliReverseBits(key) as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/huffman/mod.rs:365:11 [INFO] [stdout] | [INFO] [stdout] 365 | &mut root_table,table_free_offset + BrotliReverseBits(sub_key) as usize, step, table_size, code); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `root_table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/huffman/mod.rs:466:3 [INFO] [stdout] | [INFO] [stdout] 466 | return goal_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 466 - return goal_size; [INFO] [stdout] 466 + goal_size [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/huffman/mod.rs:415:7 [INFO] [stdout] | [INFO] [stdout] 415 | let last : u16; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `last` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 415 ~ [INFO] [stdout] 416 ~ let last : u16 = if val.len() > 3 { [INFO] [stdout] 417 ~ val[3] [INFO] [stdout] 418 | } else { [INFO] [stdout] 419 ~ 65535 [INFO] [stdout] 420 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `mval` manually [INFO] [stdout] --> src/huffman/mod.rs:425:13 [INFO] [stdout] | [INFO] [stdout] 425 | / let t : u16 = mval[k]; [INFO] [stdout] 426 | | mval[k] = mval[i]; [INFO] [stdout] 427 | | mval[i] = t; [INFO] [stdout] | |________________________^ help: try: `mval.swap(k, i);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] = note: `#[warn(clippy::manual_swap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `table` [INFO] [stdout] --> src/huffman/mod.rs:431:16 [INFO] [stdout] | [INFO] [stdout] 431 | for i in 0..4 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 431 - for i in 0..4 { [INFO] [stdout] 431 + for in table.iter_mut().take(4) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this looks like you are swapping elements of `mval` manually [INFO] [stdout] --> src/huffman/mod.rs:442:9 [INFO] [stdout] | [INFO] [stdout] 442 | / let t : u16 = mval[3]; [INFO] [stdout] 443 | | mval[3] = mval[2]; [INFO] [stdout] 444 | | mval[2] = t; [INFO] [stdout] | |____________________^ help: try: `mval.swap(3, 2);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_swap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `table` [INFO] [stdout] --> src/huffman/mod.rs:446:16 [INFO] [stdout] | [INFO] [stdout] 446 | for i in 0..7 { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 446 - for i in 0..7 { [INFO] [stdout] 446 + for (i, ) in table.iter_mut().enumerate().take(7) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/huffman/mod.rs:458:7 [INFO] [stdout] | [INFO] [stdout] 458 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LITERAL` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:15:5 [INFO] [stdout] | [INFO] [stdout] 15 | LITERAL, [INFO] [stdout] | ^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Literal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DISTANCE` contains a capitalized acronym [INFO] [stdout] --> src/state.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | DISTANCE, [INFO] [stdout] | ^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Distance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/state.rs:225:7 [INFO] [stdout] | [INFO] [stdout] 225 | impl <'brotli_state, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:335:9 [INFO] [stdout] | [INFO] [stdout] 335 | return retval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 335 - return retval; [INFO] [stdout] 335 + retval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:351:33 [INFO] [stdout] | [INFO] [stdout] 351 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 352 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:353:33 [INFO] [stdout] | [INFO] [stdout] 353 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_modes, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 354 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_modes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:355:33 [INFO] [stdout] | [INFO] [stdout] 355 | self.alloc_u8.free_cell(core::mem::replace(&mut self.dist_context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 356 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:368:33 [INFO] [stdout] | [INFO] [stdout] 368 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 369 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | self.alloc_u8.free_cell(core::mem::replace(&mut self.context_modes, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 371 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_modes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:372:33 [INFO] [stdout] | [INFO] [stdout] 372 | self.alloc_u8.free_cell(core::mem::replace(&mut self.dist_context_map, [INFO] [stdout] | _________________________________^ [INFO] [stdout] 373 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________^ help: consider using: `core::mem::take(&mut self.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:383:31 [INFO] [stdout] | [INFO] [stdout] 383 | self.alloc_u8.free_cell(core::mem::replace(&mut self.ringbuffer, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 384 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.ringbuffer)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:385:31 [INFO] [stdout] | [INFO] [stdout] 385 | self.alloc_hc.free_cell(core::mem::replace(&mut self.block_type_length_state.block_type_trees, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 386 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.block_type_length_state.block_type_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:387:31 [INFO] [stdout] | [INFO] [stdout] 387 | self.alloc_hc.free_cell(core::mem::replace(&mut self.block_type_length_state.block_len_trees, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 388 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.block_type_length_state.block_len_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/state.rs:389:31 [INFO] [stdout] | [INFO] [stdout] 389 | self.alloc_hc.free_cell(core::mem::replace(&mut self.context_map_table, [INFO] [stdout] | _______________________________^ [INFO] [stdout] 390 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut self.context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:399:17 [INFO] [stdout] | [INFO] [stdout] 399 | return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 399 - return BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] 399 + BrotliGetAvailableBits(&self.br) == 0, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:400:18 [INFO] [stdout] | [INFO] [stdout] 400 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 400 - _ => return false, [INFO] [stdout] 400 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:406:54 [INFO] [stdout] | [INFO] [stdout] 406 | BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 - BrotliRunningState::BROTLI_STATE_DONE => return true, [INFO] [stdout] 406 + BrotliRunningState::BROTLI_STATE_DONE => true, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/state.rs:407:18 [INFO] [stdout] | [INFO] [stdout] 407 | _ => return false, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 407 - _ => return false, [INFO] [stdout] 407 + _ => false, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/brot.rs:76:63 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn decompress (r : &mut InputType, mut w : &mut OutputType) -> Result<(), io::Error> [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:252:3 [INFO] [stdout] | [INFO] [stdout] 252 | return 3; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 252 - return 3; [INFO] [stdout] 252 + 3 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/transform.rs:240:17 [INFO] [stdout] | [INFO] [stdout] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'a'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/transform.rs:240:38 [INFO] [stdout] | [INFO] [stdout] 240 | if (p[0] >= 'a' as u8 && p[0] <= 'z' as u8) { [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'z'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/transform.rs:304:5 [INFO] [stdout] | [INFO] [stdout] 304 | return idx; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 304 - return idx; [INFO] [stdout] 304 + idx [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return SystemTime::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return SystemTime::now(); [INFO] [stdout] 33 + SystemTime::now() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(delta) => return (delta, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - Ok(delta) => return (delta, false), [INFO] [stdout] 39 + Ok(delta) => (delta, false), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/transform.rs:299:19 [INFO] [stdout] | [INFO] [stdout] 299 | while (suffix[i as usize] != 0) { [INFO] [stdout] | ^^^^^^^^^^ help: try: `i` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return (Duration::new(0, 0), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return (Duration::new(0, 0), true), [INFO] [stdout] 40 + _ => (Duration::new(0, 0), true), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/test.rs:33:3 [INFO] [stdout] | [INFO] [stdout] 33 | return (result, input_offset, output_offset); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return (result, input_offset, output_offset); [INFO] [stdout] 33 + (result, input_offset, output_offset) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/test.rs:30:79 [INFO] [stdout] | [INFO] [stdout] 30 | ... &mut available_out, &mut output_offset, &mut output, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/test.rs:44:11 [INFO] [stdout] | [INFO] [stdout] 44 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/test.rs:48:28 [INFO] [stdout] | [INFO] [stdout] 48 | assert_eq!(output[i], 'X' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'X'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/test.rs:49:33 [INFO] [stdout] | [INFO] [stdout] 49 | assert_eq!(output[i + 10], 'Y' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'Y'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/test.rs:66:11 [INFO] [stdout] | [INFO] [stdout] 66 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/test.rs:68:25 [INFO] [stdout] | [INFO] [stdout] 68 | assert_eq!(output[0], 'X' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'X'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/test.rs:81:11 [INFO] [stdout] | [INFO] [stdout] 81 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/test.rs:99:11 [INFO] [stdout] | [INFO] [stdout] 99 | _ => assert!(false), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | return BrotliResult::ResultFailure; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 84 - return BrotliResult::ResultFailure; [INFO] [stdout] 84 + BrotliResult::ResultFailure [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:122:3 [INFO] [stdout] | [INFO] [stdout] 122 | return 17; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return 17; [INFO] [stdout] 122 + 17 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:110:30 [INFO] [stdout] | [INFO] [stdout] 110 | bit_reader::BrotliTakeBits(&mut br, 1, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:114:30 [INFO] [stdout] | [INFO] [stdout] 114 | bit_reader::BrotliTakeBits(&mut br, 3, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:118:30 [INFO] [stdout] | [INFO] [stdout] 118 | bit_reader::BrotliTakeBits(&mut br, 3, &mut n); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:137:44 [INFO] [stdout] | [INFO] [stdout] 137 | if !bit_reader::BrotliSafeReadBits(&mut br, 1, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:149:44 [INFO] [stdout] | [INFO] [stdout] 149 | if !bit_reader::BrotliSafeReadBits(&mut br, 3, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:165:44 [INFO] [stdout] | [INFO] [stdout] 165 | if !bit_reader::BrotliSafeReadBits(&mut br, *value, &mut bits, input) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:311:3 [INFO] [stdout] | [INFO] [stdout] 311 | return table_element.value as u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 311 - return table_element.value as u32; [INFO] [stdout] 311 + table_element.value as u32 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:319:3 [INFO] [stdout] | [INFO] [stdout] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 319 - return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] 319 + DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:319:71 [INFO] [stdout] | [INFO] [stdout] 319 | return DecodeSymbol(bit_reader::BrotliGet16BitsUnmasked(br, input), &table, br); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:361:3 [INFO] [stdout] | [INFO] [stdout] 361 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 361 - return true; [INFO] [stdout] 361 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `bit_reader::BrotliGetAvailableBits` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:327:63 [INFO] [stdout] | [INFO] [stdout] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 327 - let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] 327 + let mut available_bits = bit_reader::BrotliGetAvailableBits(&br); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:327:63 [INFO] [stdout] | [INFO] [stdout] 327 | let mut available_bits = bit_reader::BrotliGetAvailableBits(&mut br); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:335:51 [INFO] [stdout] | [INFO] [stdout] 335 | let mut val = bit_reader::BrotliGetBitsUnmasked(&br) as u32; [INFO] [stdout] | ^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:340:34 [INFO] [stdout] | [INFO] [stdout] 340 | bit_reader::BrotliDropBits(&mut br, table_element.bits as u32); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:359:30 [INFO] [stdout] | [INFO] [stdout] 359 | bit_reader::BrotliDropBits(&mut br, HUFFMAN_TABLE_BITS + table_sub_element.bits as u32); [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:375:3 [INFO] [stdout] | [INFO] [stdout] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 375 - return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] 375 + SafeDecodeSymbol(&table, br, result) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:370:33 [INFO] [stdout] | [INFO] [stdout] 370 | *result = DecodeSymbol(val, &table, br); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:375:27 [INFO] [stdout] | [INFO] [stdout] 375 | return SafeDecodeSymbol(&table, br, result); [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:415:3 [INFO] [stdout] | [INFO] [stdout] 415 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 415 - return result; [INFO] [stdout] 415 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> src/bin/brot.rs:76:63 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn decompress (r : &mut InputType, mut w : &mut OutputType) -> Result<(), io::Error> [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:424:3 [INFO] [stdout] | [INFO] [stdout] 424 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return result; [INFO] [stdout] 424 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:433:5 [INFO] [stdout] | [INFO] [stdout] 433 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:470:3 [INFO] [stdout] | [INFO] [stdout] 470 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 470 - return BrotliResult::ResultSuccess; [INFO] [stdout] 470 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/lib.rs:480:1 [INFO] [stdout] | [INFO] [stdout] 480 | / fn ProcessSingleCodeLength(code_len : u32, [INFO] [stdout] 481 | | symbol : &mut u32, repeat : &mut u32, space : &mut u32, [INFO] [stdout] 482 | | prev_code_len : &mut u32, symbol_lists : &mut [u16], symbol_list_index_offset : usize, [INFO] [stdout] 483 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (12/7) [INFO] [stdout] --> src/lib.rs:506:1 [INFO] [stdout] | [INFO] [stdout] 506 | / fn ProcessRepeatedCodeLength(code_len : u32, [INFO] [stdout] 507 | | mut repeat_delta : u32, alphabet_size : u32, symbol : &mut u32, [INFO] [stdout] 508 | | repeat : &mut u32, space : &mut u32, prev_code_len : &mut u32, [INFO] [stdout] 509 | | repeat_code_len : &mut u32, symbol_lists : &mut [u16], symbol_lists_index : usize, [INFO] [stdout] 510 | | code_length_histo : &mut [u16], next_symbol : &mut [i32]) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:511:3 [INFO] [stdout] | [INFO] [stdout] 511 | let old_repeat : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 520 | old_repeat = *repeat; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `old_repeat` here [INFO] [stdout] | [INFO] [stdout] 511 ~ [INFO] [stdout] 512 | let mut new_len : u32 = 0; [INFO] [stdout] ... [INFO] [stdout] 519 | } [INFO] [stdout] 520 ~ let old_repeat : u32 = *repeat; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:557:5 [INFO] [stdout] | [INFO] [stdout] 557 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:604:3 [INFO] [stdout] | [INFO] [stdout] 604 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 604 - return BrotliResult::ResultSuccess; [INFO] [stdout] 604 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:574:5 [INFO] [stdout] | [INFO] [stdout] 574 | let code_len : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 588 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code_len` here [INFO] [stdout] | [INFO] [stdout] 574 ~ [INFO] [stdout] 575 | if (!bit_reader::BrotliCheckInputAmount(&s.br, bit_reader::BROTLI_SHORT_FILL_BIT_WINDOW_READ)) { [INFO] [stdout] ... [INFO] [stdout] 587 | bit_reader::BrotliDropBits(&mut s.br, p.bits as u32); /* Use 1..5 bits */ [INFO] [stdout] 588 ~ let code_len : u32 = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/lib.rs:585:29 [INFO] [stdout] | [INFO] [stdout] 585 | bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32) as u64; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:591:59 [INFO] [stdout] | [INFO] [stdout] 591 | &mut prev_code_len, &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:599:39 [INFO] [stdout] | [INFO] [stdout] 599 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:608:5 [INFO] [stdout] | [INFO] [stdout] 608 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:656:3 [INFO] [stdout] | [INFO] [stdout] 656 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 656 - return BrotliResult::ResultSuccess; [INFO] [stdout] 656 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:616:5 [INFO] [stdout] | [INFO] [stdout] 616 | let code_len : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 631 | code_len = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code_len` here [INFO] [stdout] | [INFO] [stdout] 616 ~ [INFO] [stdout] 617 | let mut bits : u32 = 0; [INFO] [stdout] ... [INFO] [stdout] 630 | } [INFO] [stdout] 631 ~ let code_len : u32 = p.value as u32; /* code_len == 0..17 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u32` -> `u32`) [INFO] [stdout] --> src/lib.rs:622:43 [INFO] [stdout] | [INFO] [stdout] 622 | p_index += bits & bit_reader::BitMask(huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH as u32); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/integration_tests.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | return ret; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 16 - return ret; [INFO] [stdout] 16 + ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:636:39 [INFO] [stdout] | [INFO] [stdout] 636 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/integration_tests.rs:30:9 [INFO] [stdout] | [INFO] [stdout] 30 | return Ok(bytes_to_read); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 30 - return Ok(bytes_to_read); [INFO] [stdout] 30 + Ok(bytes_to_read) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:652:39 [INFO] [stdout] | [INFO] [stdout] 652 | &mut s.symbols_lists_array, s.symbol_lists_index as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.symbol_lists_index` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:662:5 [INFO] [stdout] | [INFO] [stdout] 662 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/integration_tests.rs:39:9 [INFO] [stdout] | [INFO] [stdout] 39 | return Ok(buf.len()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - return Ok(buf.len()); [INFO] [stdout] 39 + Ok(buf.len()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:710:3 [INFO] [stdout] | [INFO] [stdout] 710 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 710 - return BrotliResult::ResultSuccess; [INFO] [stdout] 710 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:671:3 [INFO] [stdout] | [INFO] [stdout] 671 | for code_length_code_order in kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, code_length_code_order) in (s.sub_loop_counter..).zip(kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:671:84 [INFO] [stdout] | [INFO] [stdout] 671 | for code_length_code_order in kCodeLengthCodeOrder[s.sub_loop_counter as usize.. CODE_LENGTH_CODES as usize].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `CODE_LENGTH_CODES` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/integration_tests.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 42 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Ok(()); [INFO] [stdout] 42 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/lib.rs:697:7 [INFO] [stdout] | [INFO] [stdout] 697 | space = space - (32 >> v); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `space -= (32 >> v)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:727:5 [INFO] [stdout] | [INFO] [stdout] 727 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:57:34 [INFO] [stdout] | [INFO] [stdout] 57 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'X'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stdout] 78 + decompress_internal(r, w, 4096 * 1024, 4096 * 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:58:39 [INFO] [stdout] | [INFO] [stdout] 58 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'Y'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/brot.rs:83:3 [INFO] [stdout] | [INFO] [stdout] 83 | let range : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `range` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 | let mut timing_error : bool = false; [INFO] [stdout] 85 ~ let range : usize = if option_env!("BENCHMARK_MODE").is_some() { [INFO] [stdout] 86 ~ 1000 [INFO] [stdout] 87 | } else { [INFO] [stdout] 88 ~ 1 [INFO] [stdout] 89 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:786:9 [INFO] [stdout] | [INFO] [stdout] 786 | let table_size : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 796 | / table_size = huffman::BrotliBuildSimpleHuffmanTable( [INFO] [stdout] 797 | | &mut table[offset..], HUFFMAN_TABLE_BITS as i32, &s.symbols_lists_array[..], s.symbol); [INFO] [stdout] | |__________________________________________________________________________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `table_size` here [INFO] [stdout] | [INFO] [stdout] 786 ~ [INFO] [stdout] 787 | if (s.symbol == 3) { [INFO] [stdout] ... [INFO] [stdout] 795 | BROTLI_LOG_UINT!(s.symbol); [INFO] [stdout] 796 ~ let table_size : u32 = huffman::BrotliBuildSimpleHuffmanTable( [INFO] [stdout] 797 ~ &mut table[offset..], HUFFMAN_TABLE_BITS as i32, &s.symbols_lists_array[..], s.symbol); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:798:9 [INFO] [stdout] | [INFO] [stdout] 798 | / match opt_table_size { [INFO] [stdout] 799 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stdout] 800 | | None => {}, [INFO] [stdout] 801 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:77:34 [INFO] [stdout] | [INFO] [stdout] 77 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'X'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:815:53 [INFO] [stdout] | [INFO] [stdout] 815 | ... &mut s.code_length_code_lengths, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 815 - &mut s.code_length_code_lengths, [INFO] [stdout] 815 + &s.code_length_code_lengths, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/brot.rs:136:77 [INFO] [stdout] | [INFO] [stdout] 136 | result = BrotliDecompressStream(&mut available_in, &mut input_offset, &input.slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `input.slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:78:39 [INFO] [stdout] | [INFO] [stdout] 78 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'Y'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/brot.rs:137:79 [INFO] [stdout] | [INFO] [stdout] 137 | ... &mut available_out, &mut output_offset, &mut output.slice_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `output.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/brot.rs:144:7 [INFO] [stdout] | [INFO] [stdout] 144 | total = total + delta; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += delta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | Ok(_) => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 190 - Ok(_) => return, [INFO] [stdout] 190 + Ok(_) => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `huffman::BrotliBuildCodeLengthsHuffmanTable` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:816:53 [INFO] [stdout] | [INFO] [stdout] 816 | ... &mut s.code_length_histo); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 816 - &mut s.code_length_histo); [INFO] [stdout] 816 + &s.code_length_histo); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:822:9 [INFO] [stdout] | [INFO] [stdout] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, next_symbol_mut) in (0_u32..).zip(s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut())` [INFO] [stdout] | [INFO] [stdout] = note: `i` is of type `u32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:822:48 [INFO] [stdout] | [INFO] [stdout] 822 | for next_symbol_mut in s.next_symbol[..huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH as usize + 1].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `huffman::BROTLI_HUFFMAN_MAX_CODE_LENGTH` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | assert_eq!(output.data[i], 'X' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'X'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:839:9 [INFO] [stdout] | [INFO] [stdout] 839 | let table_size : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 854 | / table_size = huffman::BrotliBuildHuffmanTable(&mut table[offset..], HUFFMAN_TABLE_BITS as i32, [INFO] [stdout] 855 | | &s.symbols_lists_array[..], s.symbol_lists_index, &mut s.code_length_histo); [INFO] [stdout] | |_______________________________________________________________________________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `table_size` here [INFO] [stdout] | [INFO] [stdout] 839 ~ [INFO] [stdout] 840 | let mut result = ReadSymbolCodeLengths(alphabet_size, s, input); [INFO] [stdout] ... [INFO] [stdout] 853 | } [INFO] [stdout] 854 ~ let table_size : u32 = huffman::BrotliBuildHuffmanTable(&mut table[offset..], HUFFMAN_TABLE_BITS as i32, [INFO] [stdout] 855 ~ &s.symbols_lists_array[..], s.symbol_lists_index, &mut s.code_length_histo); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:841:9 [INFO] [stdout] | [INFO] [stdout] 841 | / match result { [INFO] [stdout] 842 | | BrotliResult::NeedsMoreInput => result = SafeReadSymbolCodeLengths(alphabet_size, s, input), [INFO] [stdout] 843 | | _ => {}, [INFO] [stdout] 844 | | } [INFO] [stdout] | |_________^ help: try: `if let BrotliResult::NeedsMoreInput = result { result = SafeReadSymbolCodeLengths(alphabet_size, s, input) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/brot.rs:171:46 [INFO] [stdout] | [INFO] [stdout] 171 | let mut input = match File::open(&Path::new(&argument)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&argument)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:856:9 [INFO] [stdout] | [INFO] [stdout] 856 | / match opt_table_size { [INFO] [stdout] 857 | | Some(opt_table_size_ref) => *opt_table_size_ref = table_size, [INFO] [stdout] 858 | | None => {}, [INFO] [stdout] 859 | | } [INFO] [stdout] | |_________^ help: try: `if let Some(opt_table_size_ref) = opt_table_size { *opt_table_size_ref = table_size }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/bin/integration_tests.rs:98:39 [INFO] [stdout] | [INFO] [stdout] 98 | assert_eq!(output.data[i + 10], 'Y' as u8); [INFO] [stdout] | ^^^^^^^^^ help: use a byte literal instead: `b'Y'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:875:3 [INFO] [stdout] | [INFO] [stdout] 875 | / return prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stdout] 876 | | + bit_reader::BrotliReadBits(br, nbits, input); [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 875 ~ prefix::kBlockLengthPrefixCode[code as usize].offset as u32 [INFO] [stdout] 876 ~ + bit_reader::BrotliReadBits(br, nbits, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/brot.rs:177:49 [INFO] [stdout] | [INFO] [stdout] 177 | let mut output = match File::create(&Path::new(&oa), ) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(&oa)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:871:3 [INFO] [stdout] | [INFO] [stdout] 871 | let code : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^ created here [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `code` here [INFO] [stdout] | [INFO] [stdout] 871 ~ [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] 873 ~ let code : u32 = ReadSymbol(table, br, input); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:872:3 [INFO] [stdout] | [INFO] [stdout] 872 | let nbits : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] 874 | nbits = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `nbits` here [INFO] [stdout] | [INFO] [stdout] 872 ~ [INFO] [stdout] 873 | code = ReadSymbol(table, br, input); [INFO] [stdout] 874 ~ let nbits : u32 = prefix::kBlockLengthPrefixCode[code as usize].nbits as u32; /* nbits == 2..24 */ [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:893:7 [INFO] [stdout] | [INFO] [stdout] 893 | return (true, index); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 893 - return (true, index); [INFO] [stdout] 893 + (true, index) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:895:10 [INFO] [stdout] | [INFO] [stdout] 895 | _ => return (true, block_length_index), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 895 - _ => return (true, block_length_index), [INFO] [stdout] 895 + _ => (true, block_length_index), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:890:27 [INFO] [stdout] | [INFO] [stdout] 890 | if (!SafeReadSymbol(&table, &mut br, &mut index, input)) { [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:890:35 [INFO] [stdout] | [INFO] [stdout] 890 | if (!SafeReadSymbol(&table, &mut br, &mut index, input)) { [INFO] [stdout] | ^^^^^^^ help: change this to: `br` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:919:5 [INFO] [stdout] | [INFO] [stdout] 919 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 919 - return true; [INFO] [stdout] 919 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:950:3 [INFO] [stdout] | [INFO] [stdout] 950 | for item in mtf[0..(upper_bound as usize + 1usize)].iter_mut() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (i, item) in (0_u32..).zip(mtf[0..(upper_bound as usize + 1usize)].iter_mut())` [INFO] [stdout] | [INFO] [stdout] = note: `i` is of type `u32`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:980:3 [INFO] [stdout] | [INFO] [stdout] 980 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1060:3 [INFO] [stdout] | [INFO] [stdout] 1060 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1060 - return result; [INFO] [stdout] 1060 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:993:14 [INFO] [stdout] | [INFO] [stdout] 993 | hcodes = mem::replace(&mut s.literal_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.literal_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:994:14 [INFO] [stdout] | [INFO] [stdout] 994 | htrees = mem::replace(&mut s.literal_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.literal_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:998:14 [INFO] [stdout] | [INFO] [stdout] 998 | hcodes = mem::replace(&mut s.insert_copy_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:999:14 [INFO] [stdout] | [INFO] [stdout] 999 | htrees = mem::replace(&mut s.insert_copy_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1004:14 [INFO] [stdout] | [INFO] [stdout] 1004 | hcodes = mem::replace(&mut s.distance_hgroup.codes, AllocHC::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.distance_hgroup.codes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1005:14 [INFO] [stdout] | [INFO] [stdout] 1005 | htrees = mem::replace(&mut s.distance_hgroup.htrees, AllocU32::AllocatedMemory::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `core::mem::take(&mut s.distance_hgroup.htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1024:30 [INFO] [stdout] | [INFO] [stdout] 1024 | ... &mut s, [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1036:18 [INFO] [stdout] | [INFO] [stdout] 1036 | / mem::replace(&mut hcodes, [INFO] [stdout] 1037 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1039:18 [INFO] [stdout] | [INFO] [stdout] 1039 | / mem::replace(&mut htrees, [INFO] [stdout] 1040 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1043:18 [INFO] [stdout] | [INFO] [stdout] 1043 | / mem::replace(&mut hcodes, [INFO] [stdout] 1044 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1046:18 [INFO] [stdout] | [INFO] [stdout] 1046 | / mem::replace(&mut htrees, [INFO] [stdout] 1047 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1050:18 [INFO] [stdout] | [INFO] [stdout] 1050 | / mem::replace(&mut hcodes, [INFO] [stdout] 1051 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |__________________________________________________________________^ help: consider using: `core::mem::take(&mut hcodes)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1053:18 [INFO] [stdout] | [INFO] [stdout] 1053 | / mem::replace(&mut htrees, [INFO] [stdout] 1054 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut htrees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:1056:3 [INFO] [stdout] | [INFO] [stdout] 1056 | / match result { [INFO] [stdout] 1057 | | BrotliResult::ResultSuccess => s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE, [INFO] [stdout] 1058 | | _ => {}, [INFO] [stdout] 1059 | | } [INFO] [stdout] | |___^ help: try: `if let BrotliResult::ResultSuccess = result { s.substate_tree_group = BrotliRunningTreeGroupState::BROTLI_STATE_TREE_GROUP_NONE }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1081:3 [INFO] [stdout] | [INFO] [stdout] 1081 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1135:43 [INFO] [stdout] | [INFO] [stdout] 1135 | let mut local_context_map_table = mem::replace(&mut s.context_map_table, [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 1136 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |___________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1138:34 [INFO] [stdout] | [INFO] [stdout] 1138 | ... &mut local_context_map_table.slice_mut(), 0, None, &mut s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `local_context_map_table.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1138:85 [INFO] [stdout] | [INFO] [stdout] 1138 | ... &mut local_context_map_table.slice_mut(), 0, None, &mut s, input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1139:48 [INFO] [stdout] | [INFO] [stdout] 1139 | mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] | ________________________________________________^ [INFO] [stdout] 1140 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |________________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut local_context_map_table)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1230:3 [INFO] [stdout] | [INFO] [stdout] 1230 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1265:3 [INFO] [stdout] | [INFO] [stdout] 1265 | return retval; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1265 - return retval; [INFO] [stdout] 1265 + retval [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:1239:55 [INFO] [stdout] | [INFO] [stdout] 1239 | BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert_eq!(is_dist_context_map, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1239 - BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert_eq!(is_dist_context_map, false), [INFO] [stdout] 1239 + BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_1 => assert!(!is_dist_context_map), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:1240:55 [INFO] [stdout] | [INFO] [stdout] 1240 | BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert_eq!(is_dist_context_map, true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 1240 - BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert_eq!(is_dist_context_map, true), [INFO] [stdout] 1240 + BrotliRunningState::BROTLI_STATE_CONTEXT_MAP_2 => assert!(is_dist_context_map), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1247:23 [INFO] [stdout] | [INFO] [stdout] 1247 | context_map_arg = mem::replace(&mut s.dist_context_map, [INFO] [stdout] | _______________________^ [INFO] [stdout] 1248 | | AllocU8::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________^ help: consider using: `core::mem::take(&mut s.dist_context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1251:23 [INFO] [stdout] | [INFO] [stdout] 1251 | context_map_arg = mem::replace(&mut s.context_map, [INFO] [stdout] | _______________________^ [INFO] [stdout] 1252 | | AllocU8::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________^ help: consider using: `core::mem::take(&mut s.context_map)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1255:102 [INFO] [stdout] | [INFO] [stdout] 1255 | let retval = DecodeContextMapInner(context_map_size as u32, &mut num_htrees, &mut context_map_arg, &mut s, input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | return SystemTime::now(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 33 - return SystemTime::now(); [INFO] [stdout] 33 + SystemTime::now() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:39:22 [INFO] [stdout] | [INFO] [stdout] 39 | Ok(delta) => return (delta, false), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 39 - Ok(delta) => return (delta, false), [INFO] [stdout] 39 + Ok(delta) => (delta, false), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:40:14 [INFO] [stdout] | [INFO] [stdout] 40 | _ => return (Duration::new(0, 0), true), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 40 - _ => return (Duration::new(0, 0), true), [INFO] [stdout] 40 + _ => (Duration::new(0, 0), true), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1258:43 [INFO] [stdout] | [INFO] [stdout] 1258 | mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | ___________________________________________^ [INFO] [stdout] 1259 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________________________________^ help: consider using: `core::mem::take(&mut context_map_arg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1262:38 [INFO] [stdout] | [INFO] [stdout] 1262 | mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1263 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut context_map_arg)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1321:3 [INFO] [stdout] | [INFO] [stdout] 1321 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1321 - return true; [INFO] [stdout] 1321 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1349:3 [INFO] [stdout] | [INFO] [stdout] 1349 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1349 - return true; [INFO] [stdout] 1349 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1337:3 [INFO] [stdout] | [INFO] [stdout] 1337 | let context_mode : u8; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1346 | context_mode = s.context_modes.slice()[s.block_type_length_state.block_type_rb[1] as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `context_mode` here [INFO] [stdout] | [INFO] [stdout] 1337 ~ [INFO] [stdout] 1338 | let context_offset : u32; [INFO] [stdout] ... [INFO] [stdout] 1345 | // s.literal_htree = s.literal_hgroup.htrees[s.literal_htree_index]; // redundant [INFO] [stdout] 1346 ~ let context_mode : u8 = s.context_modes.slice()[s.block_type_length_state.block_type_rb[1] as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1338:3 [INFO] [stdout] | [INFO] [stdout] 1338 | let context_offset : u32; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1342 | context_offset = s.block_type_length_state.block_type_rb[1] << kLiteralContextBits; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `context_offset` here [INFO] [stdout] | [INFO] [stdout] 1338 ~ [INFO] [stdout] 1339 | if !DecodeBlockTypeAndLength(safe, &mut s.block_type_length_state, &mut s.br, 0, input) { [INFO] [stdout] 1340 | return false; [INFO] [stdout] 1341 | } [INFO] [stdout] 1342 ~ let context_offset : u32 = s.block_type_length_state.block_type_rb[1] << kLiteralContextBits; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1373:3 [INFO] [stdout] | [INFO] [stdout] 1373 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1382:3 [INFO] [stdout] | [INFO] [stdout] 1382 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1382 - return true; [INFO] [stdout] 1382 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1387:3 [INFO] [stdout] | [INFO] [stdout] 1387 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1395:3 [INFO] [stdout] | [INFO] [stdout] 1395 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1399:3 [INFO] [stdout] | [INFO] [stdout] 1399 | return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1399 - return DecodeCommandBlockSwitchInternal(true, s, input); [INFO] [stdout] 1399 + DecodeCommandBlockSwitchInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1405:3 [INFO] [stdout] | [INFO] [stdout] 1405 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1416:3 [INFO] [stdout] | [INFO] [stdout] 1416 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1416 - return true; [INFO] [stdout] 1416 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1421:3 [INFO] [stdout] | [INFO] [stdout] 1421 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1430:3 [INFO] [stdout] | [INFO] [stdout] 1430 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1434:3 [INFO] [stdout] | [INFO] [stdout] 1434 | return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1434 - return DecodeDistanceBlockSwitchInternal(true, s, input); [INFO] [stdout] 1434 + DecodeDistanceBlockSwitchInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1437:20 [INFO] [stdout] | [INFO] [stdout] 1437 | fn WriteRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1470:3 [INFO] [stdout] | [INFO] [stdout] 1470 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1470 - return BrotliResult::ResultSuccess; [INFO] [stdout] 1470 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1442:3 [INFO] [stdout] | [INFO] [stdout] 1442 | let pos : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `pos` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 1442 ~ [INFO] [stdout] 1443 ~ let pos : usize = if s.pos > s.ringbuffer_size { [INFO] [stdout] 1444 ~ s.ringbuffer_size as usize [INFO] [stdout] 1445 | } else { [INFO] [stdout] 1446 ~ s.pos as usize [INFO] [stdout] 1447 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1449:8 [INFO] [stdout] | [INFO] [stdout] 1449 | (s.rb_roundtrips as usize * s.ringbuffer_size as usize) + pos as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `s.rb_roundtrips` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1449:65 [INFO] [stdout] | [INFO] [stdout] 1449 | (s.rb_roundtrips as usize * s.ringbuffer_size as usize) + pos as usize; [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1450:18 [INFO] [stdout] | [INFO] [stdout] 1450 | let to_write = (partial_pos_rb - s.partial_pos_out) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(partial_pos_rb - s.partial_pos_out)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1451:25 [INFO] [stdout] | [INFO] [stdout] 1451 | let mut num_written = *available_out as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1458:21 [INFO] [stdout] | [INFO] [stdout] 1458 | let start_index = (s.partial_pos_out & s.ringbuffer_mask as usize) as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(s.partial_pos_out & s.ringbuffer_mask as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1459:66 [INFO] [stdout] | [INFO] [stdout] 1459 | let start = &s.ringbuffer.slice()[start_index .. start_index + num_written as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1460:45 [INFO] [stdout] | [INFO] [stdout] 1460 | output[*output_offset .. *output_offset + num_written as usize].clone_from_slice(start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1465:24 [INFO] [stdout] | [INFO] [stdout] 1465 | s.partial_pos_out += num_written as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `num_written` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1473:34 [INFO] [stdout] | [INFO] [stdout] 1473 | fn CopyUncompressedBlockToOutput<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:13 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:33 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:46 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:66 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:1512:82 [INFO] [stdout] | [INFO] [stdout] 1512 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1527:5 [INFO] [stdout] | [INFO] [stdout] 1527 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1576:3 [INFO] [stdout] | [INFO] [stdout] 1576 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1576 - return true; [INFO] [stdout] 1576 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1565:7 [INFO] [stdout] | [INFO] [stdout] 1565 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:1570:7 [INFO] [stdout] | [INFO] [stdout] 1570 | if (s.custom_dict.slice().len() > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.custom_dict.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1580:25 [INFO] [stdout] | [INFO] [stdout] 1580 | pub fn ReadContextModes<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1602:3 [INFO] [stdout] | [INFO] [stdout] 1602 | return BrotliResult::ResultSuccess; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1602 - return BrotliResult::ResultSuccess; [INFO] [stdout] 1602 + BrotliResult::ResultSuccess [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `i` is used as a loop counter [INFO] [stdout] --> src/lib.rs:1588:3 [INFO] [stdout] | [INFO] [stdout] 1588 | / for context_mode_iter in s.context_modes.slice_mut()[i as usize .. [INFO] [stdout] 1589 | | (s.block_type_length_state.num_block_types[0] [INFO] [stdout] 1590 | | as usize)].iter_mut() { [INFO] [stdout] | |_____________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] help: consider using [INFO] [stdout] | [INFO] [stdout] 1588 ~ for (i, context_mode_iter) in (s.loop_counter..).zip(s.context_modes.slice_mut()[i as usize .. [INFO] [stdout] 1589 + (s.block_type_length_state.num_block_types[0] [INFO] [stdout] 1590 ~ as usize)].iter_mut()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1605:35 [INFO] [stdout] | [INFO] [stdout] 1605 | pub fn TakeDistanceFromRingBuffer<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1620:17 [INFO] [stdout] | [INFO] [stdout] 1620 | let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] | _________________^ [INFO] [stdout] 1621 | | (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) as i32 & 0x3; [INFO] [stdout] | |______________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1620 ~ let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] 1621 ~ (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) & 0x3; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1620:18 [INFO] [stdout] | [INFO] [stdout] 1620 | let mut v = (s.dist_rb_idx as i32 + [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `s.dist_rb_idx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`i32` -> `i32`) [INFO] [stdout] --> src/lib.rs:1621:50 [INFO] [stdout] | [INFO] [stdout] 1621 | (kDistanceShortCodeIndexOffset as i32 >> distance_code as i32)) as i32 & 0x3; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `distance_code` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1639:5 [INFO] [stdout] | [INFO] [stdout] 1639 | return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1639 - return bit_reader::BrotliSafeReadBits(br, n_bits, val, input); [INFO] [stdout] 1639 + bit_reader::BrotliSafeReadBits(br, n_bits, val, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1642:5 [INFO] [stdout] | [INFO] [stdout] 1642 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1642 - return true; [INFO] [stdout] 1642 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1647:29 [INFO] [stdout] | [INFO] [stdout] 1647 | pub fn ReadDistanceInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1707:3 [INFO] [stdout] | [INFO] [stdout] 1707 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1707 - return true; [INFO] [stdout] 1707 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `bit_reader::BrotliBitReaderRestoreState` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1694:62 [INFO] [stdout] | [INFO] [stdout] 1694 | bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1694 - bit_reader::BrotliBitReaderRestoreState(&mut s.br, &mut memento); [INFO] [stdout] 1694 + bit_reader::BrotliBitReaderRestoreState(&mut s.br, &memento); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:1711:28 [INFO] [stdout] | [INFO] [stdout] 1711 | pub fn ReadCommandInternal<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1755:3 [INFO] [stdout] | [INFO] [stdout] 1755 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1755 - return true; [INFO] [stdout] 1755 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/lib.rs:1721:3 [INFO] [stdout] | [INFO] [stdout] 1721 | let v : prefix::CmdLutElement; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] ... [INFO] [stdout] 1733 | v = prefix::kCmdLut[cmd_code as usize]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `v` here [INFO] [stdout] | [INFO] [stdout] 1721 ~ [INFO] [stdout] 1722 | let mut memento = bit_reader::BrotliBitReaderState::default(); [INFO] [stdout] ... [INFO] [stdout] 1732 | } [INFO] [stdout] 1733 ~ let v : prefix::CmdLutElement = prefix::kCmdLut[cmd_code as usize]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1763:3 [INFO] [stdout] | [INFO] [stdout] 1763 | return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1763 - return bit_reader::BrotliWarmupBitReader(br, input); [INFO] [stdout] 1763 + bit_reader::BrotliWarmupBitReader(br, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:1771:3 [INFO] [stdout] | [INFO] [stdout] 1771 | return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1771 - return bit_reader::BrotliCheckInputAmount(br, num); [INFO] [stdout] 1771 + bit_reader::BrotliCheckInputAmount(br, num) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `clone_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1799:34 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1799 - local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] 1799 + local_array.clone_from_slice(&data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1799:44 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1799:64 [INFO] [stdout] | [INFO] [stdout] 1799 | local_array.clone_from_slice(&mut data[off_src as usize .. off_src as usize + 16]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_src` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `clone_from_slice` doesn't need a mutable reference [INFO] [stdout] --> src/lib.rs:1800:70 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 1800 - data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] 1800 + data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&local_array); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1800:10 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:1800:30 [INFO] [stdout] | [INFO] [stdout] 1800 | data[off_dst as usize .. off_dst as usize + 16].clone_from_slice(&mut local_array); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `off_dst` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2173:3 [INFO] [stdout] | [INFO] [stdout] 2173 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2173 - return result; [INFO] [stdout] 2173 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1831:34 [INFO] [stdout] | [INFO] [stdout] 1831 | let mut saved_literal_hgroup = core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] | __________________________________^ [INFO] [stdout] 1832 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.literal_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1833:35 [INFO] [stdout] | [INFO] [stdout] 1833 | let mut saved_distance_hgroup = core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] | ___________________________________^ [INFO] [stdout] 1834 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.distance_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:1835:38 [INFO] [stdout] | [INFO] [stdout] 1835 | let mut saved_insert_copy_hgroup = core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] | ______________________________________^ [INFO] [stdout] 1836 | | HuffmanTreeGroup::::default()); [INFO] [stdout] | |_________________________________________________________________^ help: consider using: `core::mem::take(&mut s.insert_copy_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2086:23 [INFO] [stdout] | [INFO] [stdout] 2086 | memmove16(&mut s.ringbuffer.slice_mut(), dst_start, src_start); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `s.ringbuffer.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2107:27 [INFO] [stdout] | [INFO] [stdout] 2107 | memmove16(&mut s.ringbuffer.slice_mut(), dst_start + 16, src_start + 16); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `s.ringbuffer.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2162:17 [INFO] [stdout] | [INFO] [stdout] 2162 | / core::mem::replace(&mut saved_literal_hgroup, [INFO] [stdout] 2163 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_literal_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2166:17 [INFO] [stdout] | [INFO] [stdout] 2166 | / core::mem::replace(&mut saved_distance_hgroup, [INFO] [stdout] 2167 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_distance_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2170:17 [INFO] [stdout] | [INFO] [stdout] 2170 | / core::mem::replace(&mut saved_insert_copy_hgroup, [INFO] [stdout] 2171 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |___________________________________________________________________^ help: consider using: `core::mem::take(&mut saved_insert_copy_hgroup)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2177:5 [INFO] [stdout] | [INFO] [stdout] 2177 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2181:5 [INFO] [stdout] | [INFO] [stdout] 2181 | return ProcessCommandsInternal(false, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2181 - return ProcessCommandsInternal(false, s, input); [INFO] [stdout] 2181 + ProcessCommandsInternal(false, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2185:5 [INFO] [stdout] | [INFO] [stdout] 2185 | 'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2189:5 [INFO] [stdout] | [INFO] [stdout] 2189 | return ProcessCommandsInternal(true, s, input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2189 - return ProcessCommandsInternal(true, s, input); [INFO] [stdout] 2189 + ProcessCommandsInternal(true, s, input) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> src/lib.rs:2195:31 [INFO] [stdout] | [INFO] [stdout] 2195 | pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:78:5 [INFO] [stdout] | [INFO] [stdout] 78 | return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return decompress_internal(r, w, 4096 * 1024, 4096 * 1024); [INFO] [stdout] 78 + decompress_internal(r, w, 4096 * 1024, 4096 * 1024) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/lib.rs:2195:1 [INFO] [stdout] | [INFO] [stdout] 2195 | / pub fn BrotliDecompressStream<'a, AllocU8 : alloc::Allocator, [INFO] [stdout] 2196 | | AllocU32 : alloc::Allocator, [INFO] [stdout] 2197 | | AllocHC : alloc::Allocator> ( [INFO] [stdout] 2198 | | mut available_in : &mut usize, input_offset : &mut usize, xinput : &[u8], // ugly that we are mutable [INFO] [stdout] 2199 | | mut available_out : &mut usize, mut output_offset : &mut usize, mut output : &mut [u8], [INFO] [stdout] 2200 | | mut total_out : &mut usize, mut s : &mut BrotliState) [INFO] [stdout] 2201 | | -> BrotliResult { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:2680:3 [INFO] [stdout] | [INFO] [stdout] 2680 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 2680 - return result; [INFO] [stdout] 2680 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `[u8; 8]` which implements the `Copy` trait [INFO] [stdout] --> src/lib.rs:2205:36 [INFO] [stdout] | [INFO] [stdout] 2205 | let mut saved_buffer : [u8; 8] = s.buffer.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `s.buffer` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/bin/brot.rs:83:3 [INFO] [stdout] | [INFO] [stdout] 83 | let range : usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `range` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 83 ~ [INFO] [stdout] 84 | let mut timing_error : bool = false; [INFO] [stdout] 85 ~ let range : usize = if option_env!("BENCHMARK_MODE").is_some() { [INFO] [stdout] 86 ~ 1000 [INFO] [stdout] 87 | } else { [INFO] [stdout] 88 ~ 1 [INFO] [stdout] 89 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2236:16 [INFO] [stdout] | [INFO] [stdout] 2236 | if s.ringbuffer.slice().len() != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2237:60 [INFO] [stdout] | [INFO] [stdout] 2237 | let _result = WriteRingBuffer(available_out, &mut output, &mut output_offset, [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2237:73 [INFO] [stdout] | [INFO] [stdout] 2237 | let _result = WriteRingBuffer(available_out, &mut output, &mut output_offset, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2238:23 [INFO] [stdout] | [INFO] [stdout] 2238 | &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/brot.rs:136:77 [INFO] [stdout] | [INFO] [stdout] 136 | result = BrotliDecompressStream(&mut available_in, &mut input_offset, &input.slice(), [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `input.slice()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/bin/brot.rs:137:79 [INFO] [stdout] | [INFO] [stdout] 137 | ... &mut available_out, &mut output_offset, &mut output.slice_mut(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `output.slice_mut()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bin/brot.rs:144:7 [INFO] [stdout] | [INFO] [stdout] 144 | total = total + delta; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `total += delta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2238:39 [INFO] [stdout] | [INFO] [stdout] 2238 | &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bin/brot.rs:190:22 [INFO] [stdout] | [INFO] [stdout] 190 | Ok(_) => return, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: replace `return` with a unit value [INFO] [stdout] | [INFO] [stdout] 190 - Ok(_) => return, [INFO] [stdout] 190 + Ok(_) => (), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2330:15 [INFO] [stdout] | [INFO] [stdout] 2330 | if (s.block_type_length_state.block_type_trees.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.block_type_length_state.block_type_trees.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/brot.rs:171:46 [INFO] [stdout] | [INFO] [stdout] 171 | let mut input = match File::open(&Path::new(&argument)) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `Path::new(&argument)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2347:42 [INFO] [stdout] | [INFO] [stdout] 2347 | result = DecodeMetaBlockLength(&mut s, local_input); // Reads 2 - 31 bits. [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/bin/brot.rs:177:49 [INFO] [stdout] | [INFO] [stdout] 177 | let mut output = match File::create(&Path::new(&oa), ) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `Path::new(&oa)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:2356:11 [INFO] [stdout] | [INFO] [stdout] 2356 | / if (s.is_metadata != 0 || s.is_uncompressed != 0) { [INFO] [stdout] 2357 | | if (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stdout] 2358 | | result = BROTLI_FAILURE(); [INFO] [stdout] 2359 | | break; [INFO] [stdout] 2360 | | } [INFO] [stdout] 2361 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2356 ~ if ((s.is_metadata != 0 || s.is_uncompressed != 0)) { [INFO] [stdout] 2357 ~ && (!bit_reader::BrotliJumpToByteBoundary(&mut s.br)) { [INFO] [stdout] 2358 | result = BROTLI_FAILURE(); [INFO] [stdout] 2359 | break; [INFO] [stdout] 2360 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/lib.rs:2370:11 [INFO] [stdout] | [INFO] [stdout] 2370 | / if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] 2371 | | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] 2372 | | result = BROTLI_FAILURE(); [INFO] [stdout] 2373 | | break; [INFO] [stdout] 2374 | | } [INFO] [stdout] 2375 | | } [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 2370 ~ if (s.ringbuffer.slice().len() == 0) [INFO] [stdout] 2371 ~ && (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] 2372 | result = BROTLI_FAILURE(); [INFO] [stdout] 2373 | break; [INFO] [stdout] 2374 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2370:15 [INFO] [stdout] | [INFO] [stdout] 2370 | if (s.ringbuffer.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2371:43 [INFO] [stdout] | [INFO] [stdout] 2371 | if (!BrotliAllocateRingBuffer(&mut s, local_input)) { [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:15 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:35 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:48 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:68 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2387:84 [INFO] [stdout] | [INFO] [stdout] 2387 | &mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:2406:11 [INFO] [stdout] | [INFO] [stdout] 2406 | / match result { [INFO] [stdout] 2407 | | BrotliResult::ResultSuccess => s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE, [INFO] [stdout] 2408 | | _ => {}, [INFO] [stdout] 2409 | | } [INFO] [stdout] | |___________^ help: try: `if let BrotliResult::ResultSuccess = result { s.state = BrotliRunningState::BROTLI_STATE_METABLOCK_DONE }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2434:39 [INFO] [stdout] | [INFO] [stdout] 2434 | let mut new_huffman_table = mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2435 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.block_type_length_state.block_type_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2438:90 [INFO] [stdout] | [INFO] [stdout] 2438 | ... new_huffman_table.slice_mut(), tree_offset as usize, None, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `core::mem::take` [INFO] [stdout] --> src/lib.rs:2450:39 [INFO] [stdout] | [INFO] [stdout] 2450 | let mut new_huffman_table = mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] | _______________________________________^ [INFO] [stdout] 2451 | | AllocHC::AllocatedMemory::default()); [INFO] [stdout] | |_______________________________________________________________________________________^ help: consider using: `core::mem::take(&mut s.block_type_length_state.block_len_trees)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2453:74 [INFO] [stdout] | [INFO] [stdout] 2453 | new_huffman_table.slice_mut(), tree_offset as usize, None, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2496:15 [INFO] [stdout] | [INFO] [stdout] 2496 | if (s.context_modes.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.context_modes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2505:37 [INFO] [stdout] | [INFO] [stdout] 2505 | result = ReadContextModes(&mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:2514:96 [INFO] [stdout] | [INFO] [stdout] 2514 | result = DecodeContextMap((s.block_type_length_state.num_block_types[0] as usize) << kLiteralContextBits as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `kLiteralContextBits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2515:44 [INFO] [stdout] | [INFO] [stdout] 2515 | ... false, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `j` is used as a loop counter [INFO] [stdout] --> src/lib.rs:2522:11 [INFO] [stdout] | [INFO] [stdout] 2522 | ... for context_map_item in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (j, context_map_item) in s.context_map.slice()[0 .. (s.block_type_length_state.num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/lib.rs:2522:121 [INFO] [stdout] | [INFO] [stdout] 2522 | ...num_block_types[0] as usize) << (kLiteralContextBits as usize)].iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `kLiteralContextBits` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2553:17 [INFO] [stdout] | [INFO] [stdout] 2553 | if (s.literal_hgroup.codes.slice().len() == 0 || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.literal_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2554:17 [INFO] [stdout] | [INFO] [stdout] 2554 | s.insert_copy_hgroup.codes.slice().len() == 0 || [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.insert_copy_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2555:17 [INFO] [stdout] | [INFO] [stdout] 2555 | s.distance_hgroup.codes.slice().len() == 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `s.distance_hgroup.codes.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2564:59 [INFO] [stdout] | [INFO] [stdout] 2564 | result = HuffmanTreeGroupDecode(s.loop_counter, &mut s, local_input); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/lib.rs:2589:11 [INFO] [stdout] | [INFO] [stdout] 2589 | / match result { [INFO] [stdout] 2590 | | BrotliResult::NeedsMoreInput => result = SafeProcessCommands(s, local_input), [INFO] [stdout] 2591 | | _ => {}, [INFO] [stdout] 2592 | | } [INFO] [stdout] | |___________^ help: try: `if let BrotliResult::NeedsMoreInput = result { result = SafeProcessCommands(s, local_input) }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:36 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:56 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:69 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:89 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2598:105 [INFO] [stdout] | [INFO] [stdout] 2598 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/lib.rs:2667:15 [INFO] [stdout] | [INFO] [stdout] 2667 | if (s.ringbuffer.slice().len() != 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!s.ringbuffer.slice().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:38 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `available_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:58 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `output` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:71 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: change this to: `output_offset` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:91 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^^^^^^^^^ help: change this to: `total_out` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:2668:107 [INFO] [stdout] | [INFO] [stdout] 2668 | result = WriteRingBuffer(&mut available_out, &mut output, &mut output_offset, &mut total_out, &mut s); [INFO] [stdout] | ^^^^^^ help: change this to: `s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1035:5 [INFO] [stdout] | [INFO] [stdout] 1035 | / mem::replace(&mut s.literal_hgroup.codes, [INFO] [stdout] 1036 | | mem::replace(&mut hcodes, [INFO] [stdout] 1037 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1035 | let _ = mem::replace(&mut s.literal_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1038:5 [INFO] [stdout] | [INFO] [stdout] 1038 | / mem::replace(&mut s.literal_hgroup.htrees, [INFO] [stdout] 1039 | | mem::replace(&mut htrees, [INFO] [stdout] 1040 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1038 | let _ = mem::replace(&mut s.literal_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1042:5 [INFO] [stdout] | [INFO] [stdout] 1042 | / mem::replace(&mut s.insert_copy_hgroup.codes, [INFO] [stdout] 1043 | | mem::replace(&mut hcodes, [INFO] [stdout] 1044 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1042 | let _ = mem::replace(&mut s.insert_copy_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1045:5 [INFO] [stdout] | [INFO] [stdout] 1045 | / mem::replace(&mut s.insert_copy_hgroup.htrees, [INFO] [stdout] 1046 | | mem::replace(&mut htrees, [INFO] [stdout] 1047 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1045 | let _ = mem::replace(&mut s.insert_copy_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1049:5 [INFO] [stdout] | [INFO] [stdout] 1049 | / mem::replace(&mut s.distance_hgroup.codes, [INFO] [stdout] 1050 | | mem::replace(&mut hcodes, [INFO] [stdout] 1051 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |___________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1049 | let _ = mem::replace(&mut s.distance_hgroup.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1052:5 [INFO] [stdout] | [INFO] [stdout] 1052 | / mem::replace(&mut s.distance_hgroup.htrees, [INFO] [stdout] 1053 | | mem::replace(&mut htrees, [INFO] [stdout] 1054 | | AllocU32::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1052 | let _ = mem::replace(&mut s.distance_hgroup.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1139:9 [INFO] [stdout] | [INFO] [stdout] 1139 | / mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] 1140 | | AllocHC::AllocatedMemory::default())); [INFO] [stdout] | |_________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1139 | let _ = mem::replace(&mut s.context_map_table, mem::replace(&mut local_context_map_table, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1258:5 [INFO] [stdout] | [INFO] [stdout] 1258 | / mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] 1259 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |____________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1258 | let _ = mem::replace(&mut s.dist_context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:1262:5 [INFO] [stdout] | [INFO] [stdout] 1262 | / mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] 1263 | | AllocU8::AllocatedMemory::default())); [INFO] [stdout] | |_______________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 1262 | let _ = mem::replace(&mut s.context_map, mem::replace(&mut context_map_arg, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2161:3 [INFO] [stdout] | [INFO] [stdout] 2161 | / core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] 2162 | | core::mem::replace(&mut saved_literal_hgroup, [INFO] [stdout] 2163 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2161 | let _ = core::mem::replace(&mut s.literal_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2165:3 [INFO] [stdout] | [INFO] [stdout] 2165 | / core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] 2166 | | core::mem::replace(&mut saved_distance_hgroup, [INFO] [stdout] 2167 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2165 | let _ = core::mem::replace(&mut s.distance_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2169:3 [INFO] [stdout] | [INFO] [stdout] 2169 | / core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] 2170 | | core::mem::replace(&mut saved_insert_copy_hgroup, [INFO] [stdout] 2171 | | HuffmanTreeGroup::::default())); [INFO] [stdout] | |____________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2169 | let _ = core::mem::replace(&mut s.insert_copy_hgroup, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2439:11 [INFO] [stdout] | [INFO] [stdout] 2439 | / mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] 2440 | | new_huffman_table); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2439 | let _ = mem::replace(&mut s.block_type_length_state.block_type_trees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/lib.rs:2454:11 [INFO] [stdout] | [INFO] [stdout] 2454 | / mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] 2455 | | new_huffman_table); [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 2454 | let _ = mem::replace(&mut s.block_type_length_state.block_len_trees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/huffman/mod.rs:58:9 [INFO] [stdout] | [INFO] [stdout] 58 | / core::mem::replace(&mut self.htrees, [INFO] [stdout] 59 | | alloc_u32.alloc_cell(ntrees as usize)); [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 58 | let _ = core::mem::replace(&mut self.htrees, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused return value of `core::mem::replace` that must be used [INFO] [stdout] --> src/huffman/mod.rs:60:9 [INFO] [stdout] | [INFO] [stdout] 60 | / core::mem::replace(&mut self.codes, [INFO] [stdout] 61 | | alloc_hc.alloc_cell(ntrees as usize * BROTLI_HUFFMAN_MAX_TABLE_SIZE as usize)); [INFO] [stdout] | |_________________________________________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = note: if you don't need the old value, you can just assign the new value directly [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 60 | let _ = core::mem::replace(&mut self.codes, [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.11s [INFO] running `Command { std: "docker" "inspect" "29e109d02947903d0014c442f2f179d21a29cbadde955128fe50f959e8e77937", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "29e109d02947903d0014c442f2f179d21a29cbadde955128fe50f959e8e77937", kill_on_drop: false }` [INFO] [stdout] 29e109d02947903d0014c442f2f179d21a29cbadde955128fe50f959e8e77937