[INFO] fetching crate brickcheck 0.1.0... [INFO] linting brickcheck-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate brickcheck 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate brickcheck 0.1.0 [INFO] finished tweaking crates.io crate brickcheck 0.1.0 [INFO] tweaked toml for crates.io crate brickcheck 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate brickcheck 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] [stderr] Adding bit-vec v0.4.4 (available: v0.9.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bit-vec v0.4.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] e1a755ca2d143187edab65a1c5fe065a1754a14ce9075f26c1d5e1391f57b86c [INFO] running `Command { std: "docker" "start" "-a" "e1a755ca2d143187edab65a1c5fe065a1754a14ce9075f26c1d5e1391f57b86c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "e1a755ca2d143187edab65a1c5fe065a1754a14ce9075f26c1d5e1391f57b86c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e1a755ca2d143187edab65a1c5fe065a1754a14ce9075f26c1d5e1391f57b86c", kill_on_drop: false }` [INFO] [stdout] e1a755ca2d143187edab65a1c5fe065a1754a14ce9075f26c1d5e1391f57b86c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7f3f459dd0a6911b6091eeb2c10796f94204e2a31eed1d0fcf814f082ebcedf [INFO] running `Command { std: "docker" "start" "-a" "f7f3f459dd0a6911b6091eeb2c10796f94204e2a31eed1d0fcf814f082ebcedf", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking bit-vec v0.4.4 [INFO] [stderr] Checking brickcheck v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | try!(f.seek(SeekFrom::Start(0x400))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | try!(f.read_exact(&mut backdoor_key)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | try!(f.read_exact(&mut fprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | try!(f.read_exact(&mut fdprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | try!(f.read_exact(&mut feprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | try!(f.read_exact(&mut fopt)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | try!(f.read_exact(&mut fsec)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mcu.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | backdoor_key: backdoor_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backdoor_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mcu.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | fprot: fprot, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `fprot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `backdoor_key`, `fprot`, `fdprot`, `feprot`, and `fopt` are never read [INFO] [stdout] --> src/mcu.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct K20 { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 8 | /// Backdoor Comparison Key. [INFO] [stdout] 9 | pub backdoor_key: [u8; 8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 10 | /// Program flash protection bytes. [INFO] [stdout] 11 | pub fprot: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | /// Data flash protection byte. [INFO] [stdout] 13 | pub fdprot: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | /// EEPROM protection byte. [INFO] [stdout] 15 | pub feprot: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | /// Flash nonvolatile option byte. [INFO] [stdout] 17 | pub fopt: u8, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mcu.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !(bv[5] && !bv[4]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!bv[5] || bv[4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mcu.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | !(bv[1] && !bv[0]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!bv[1] || bv[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 24 | try!(f.seek(SeekFrom::Start(0x400))); [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | try!(f.read_exact(&mut backdoor_key)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | try!(f.read_exact(&mut fprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:33:9 [INFO] [stdout] | [INFO] [stdout] 33 | try!(f.read_exact(&mut fdprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:34:9 [INFO] [stdout] | [INFO] [stdout] 34 | try!(f.read_exact(&mut feprot)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | try!(f.read_exact(&mut fopt)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/mcu.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | try!(f.read_exact(&mut fsec)); [INFO] [stdout] | ^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mcu.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | backdoor_key: backdoor_key, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `backdoor_key` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/mcu.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | fprot: fprot, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `fprot` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `backdoor_key`, `fprot`, `fdprot`, `feprot`, and `fopt` are never read [INFO] [stdout] --> src/mcu.rs:9:9 [INFO] [stdout] | [INFO] [stdout] 7 | pub struct K20 { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] 8 | /// Backdoor Comparison Key. [INFO] [stdout] 9 | pub backdoor_key: [u8; 8], [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 10 | /// Program flash protection bytes. [INFO] [stdout] 11 | pub fprot: [u8; 4], [INFO] [stdout] | ^^^^^ [INFO] [stdout] 12 | /// Data flash protection byte. [INFO] [stdout] 13 | pub fdprot: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 14 | /// EEPROM protection byte. [INFO] [stdout] 15 | pub feprot: u8, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] 16 | /// Flash nonvolatile option byte. [INFO] [stdout] 17 | pub fopt: u8, [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mcu.rs:48:9 [INFO] [stdout] | [INFO] [stdout] 48 | !(bv[5] && !bv[4]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!bv[5] || bv[4]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/mcu.rs:52:9 [INFO] [stdout] | [INFO] [stdout] 52 | !(bv[1] && !bv[0]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `!bv[1] || bv[0]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.48s [INFO] running `Command { std: "docker" "inspect" "f7f3f459dd0a6911b6091eeb2c10796f94204e2a31eed1d0fcf814f082ebcedf", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7f3f459dd0a6911b6091eeb2c10796f94204e2a31eed1d0fcf814f082ebcedf", kill_on_drop: false }` [INFO] [stdout] f7f3f459dd0a6911b6091eeb2c10796f94204e2a31eed1d0fcf814f082ebcedf