[INFO] fetching crate breezyshim 0.7.11... [INFO] linting breezyshim-0.7.11 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate breezyshim 0.7.11 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate breezyshim 0.7.11 [INFO] finished tweaking crates.io crate breezyshim 0.7.11 [INFO] tweaked toml for crates.io crate breezyshim 0.7.11 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate breezyshim 0.7.11 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate breezyshim 0.7.11 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded serial_test v3.4.0 [INFO] [stderr] Downloaded lazy-regex v3.6.0 [INFO] [stderr] Downloaded lazy-regex-proc_macros v3.6.0 [INFO] [stderr] Downloaded xmltree v0.12.0 [INFO] [stderr] Downloaded pyo3-filelike v0.5.2 [INFO] [stderr] Downloaded serial_test_derive v3.4.0 [INFO] [stderr] Downloaded dirty-tracker v0.3.0 [INFO] [stderr] Downloaded deb822-derive v0.3.1 [INFO] [stderr] Downloaded deb822-fast v0.2.3 [INFO] [stderr] Downloaded debversion v0.5.1 [INFO] [stderr] Downloaded xml v1.2.1 [INFO] [stderr] Downloaded wadl v0.5.7 [INFO] [stderr] Downloaded debian-changelog v0.2.15 [INFO] [stderr] Downloaded debian-control v0.3.0 [INFO] [stderr] Downloaded patchkit v0.2.2 [INFO] [stderr] Downloaded launchpadlib v0.5.6 [INFO] [stderr] Downloaded deb822-lossless v0.5.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] a022df3ef53193170b1b9c8e3478020ebd912ffb558a2860406aa928ebcb0943 [INFO] running `Command { std: "docker" "start" "-a" "a022df3ef53193170b1b9c8e3478020ebd912ffb558a2860406aa928ebcb0943", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "a022df3ef53193170b1b9c8e3478020ebd912ffb558a2860406aa928ebcb0943", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a022df3ef53193170b1b9c8e3478020ebd912ffb558a2860406aa928ebcb0943", kill_on_drop: false }` [INFO] [stdout] a022df3ef53193170b1b9c8e3478020ebd912ffb558a2860406aa928ebcb0943 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 17d04e354726792fb08d39519d22621591afd3450dc4fa5befdd640617855782 [INFO] running `Command { std: "docker" "start" "-a" "17d04e354726792fb08d39519d22621591afd3450dc4fa5befdd640617855782", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling target-lexicon v0.13.5 [INFO] [stderr] Checking countme v3.0.1 [INFO] [stderr] Checking text-size v1.1.1 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling dtor-proc-macro v0.0.6 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling ctor-proc-macro v0.0.7 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking maplit v1.0.2 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking dtor v0.1.1 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking ctor v0.6.3 [INFO] [stderr] Compiling quote v1.0.44 [INFO] [stderr] Checking rowan v0.16.1 [INFO] [stderr] Compiling pyo3-build-config v0.28.2 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking tempfile v3.26.0 [INFO] [stderr] Compiling pyo3-ffi v0.28.2 [INFO] [stderr] Compiling pyo3-macros-backend v0.28.2 [INFO] [stderr] Compiling pyo3 v0.28.2 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling zerovec-derive v0.11.2 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling lazy-regex-proc_macros v3.6.0 [INFO] [stderr] Compiling serial_test_derive v3.4.0 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.1 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking lazy-regex v3.6.0 [INFO] [stderr] Checking serial_test v3.4.0 [INFO] [stderr] Checking patchkit v0.2.2 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Compiling pyo3-macros v0.28.2 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking pyo3-filelike v0.5.2 [INFO] [stderr] Checking breezyshim v0.7.11 (/opt/rustwide/workdir) [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/controldir.rs:1191:6 [INFO] [stdout] | [INFO] [stdout] 1191 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 1192 | | ( [INFO] [stdout] 1193 | | Box< [INFO] [stdout] 1194 | | dyn ControlDir< [INFO] [stdout] ... | [INFO] [stdout] 1202 | | Error, [INFO] [stdout] 1203 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `subdir` after checking its variant with `is_none` [INFO] [stdout] --> src/export.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 24 | let subdir = if subdir.is_none() || subdir == Some(Path::new("")) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 27 | Some(subdir.unwrap().to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/forge.rs:612:5 [INFO] [stdout] | [INFO] [stdout] 612 | / pub fn publish_derived( [INFO] [stdout] 613 | | &self, [INFO] [stdout] 614 | | local_branch: &dyn PyBranch, [INFO] [stdout] 615 | | base_branch: &dyn PyBranch, [INFO] [stdout] ... | [INFO] [stdout] 620 | | tag_selector: Option bool>>, [INFO] [stdout] 621 | | ) -> Result<(Box, url::Url), crate::error::Error> { [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BareLocalGitControlDirFormat` [INFO] [stdout] --> src/git.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / pub fn new() -> Self { [INFO] [stdout] 70 | | Python::attach(|py| { [INFO] [stdout] 71 | | let m = py [INFO] [stdout] 72 | | .import("breezy.git") [INFO] [stdout] ... | [INFO] [stdout] 84 | | }) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 67 + impl Default for BareLocalGitControlDirFormat { [INFO] [stdout] 68 + fn default() -> Self { [INFO] [stdout] 69 + Self::new() [INFO] [stdout] 70 + } [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GPGContext` [INFO] [stdout] --> src/gpg.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / pub fn new() -> Self { [INFO] [stdout] 229 | | Python::attach(|py| { [INFO] [stdout] 230 | | let gpg = PyModule::import(py, "gpg").unwrap(); [INFO] [stdout] 231 | | let gpg_context = gpg.getattr("Context").unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | }) [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 226 + impl Default for GPGContext { [INFO] [stdout] 227 + fn default() -> Self { [INFO] [stdout] 228 + Self::new() [INFO] [stdout] 229 + } [INFO] [stdout] 230 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph.rs:407:10 [INFO] [stdout] | [INFO] [stdout] 407 | ) -> Result< [INFO] [stdout] | __________^ [INFO] [stdout] 408 | | impl Iterator>, [INFO] [stdout] 409 | | crate::error::Error, [INFO] [stdout] 410 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/groupcompress.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / pub fn from_transport( [INFO] [stdout] 18 | | py: Python, [INFO] [stdout] 19 | | transport: &crate::transport::Transport, [INFO] [stdout] 20 | | index: Option>, [INFO] [stdout] ... | [INFO] [stdout] 25 | | use_chk_index: bool, [INFO] [stdout] 26 | | ) -> PyResult { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/interrepository.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | get_changed_refs: std::sync::Mutex< [INFO] [stdout] | ___________________________^ [INFO] [stdout] 132 | | Box< [INFO] [stdout] 133 | | dyn FnMut( [INFO] [stdout] 134 | | &HashMap, (Vec, Option)>, [INFO] [stdout] ... | [INFO] [stdout] 137 | | >, [INFO] [stdout] 138 | | >, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:414:10 [INFO] [stdout] | [INFO] [stdout] 414 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:423:10 [INFO] [stdout] | [INFO] [stdout] 423 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:492:10 [INFO] [stdout] | [INFO] [stdout] 492 | ) -> Result), Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:498:10 [INFO] [stdout] | [INFO] [stdout] 498 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:519:10 [INFO] [stdout] | [INFO] [stdout] 519 | ) -> Result, Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:526:10 [INFO] [stdout] | [INFO] [stdout] 526 | ) -> Result), Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/controldir.rs:1191:6 [INFO] [stdout] | [INFO] [stdout] 1191 | ) -> Result< [INFO] [stdout] | ______^ [INFO] [stdout] 1192 | | ( [INFO] [stdout] 1193 | | Box< [INFO] [stdout] 1194 | | dyn ControlDir< [INFO] [stdout] ... | [INFO] [stdout] 1202 | | Error, [INFO] [stdout] 1203 | | > { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/versionedfiles.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / fn add_lines( [INFO] [stdout] 103 | | &self, [INFO] [stdout] 104 | | key: &Key, [INFO] [stdout] 105 | | parents: &[Key], [INFO] [stdout] ... | [INFO] [stdout] 111 | | check_content: bool, [INFO] [stdout] 112 | | ) -> Result<(String, usize), Error>; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `subdir` after checking its variant with `is_none` [INFO] [stdout] --> src/export.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 24 | let subdir = if subdir.is_none() || subdir == Some(Path::new("")) { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 27 | Some(subdir.unwrap().to_string_lossy().to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/forge.rs:612:5 [INFO] [stdout] | [INFO] [stdout] 612 | / pub fn publish_derived( [INFO] [stdout] 613 | | &self, [INFO] [stdout] 614 | | local_branch: &dyn PyBranch, [INFO] [stdout] 615 | | base_branch: &dyn PyBranch, [INFO] [stdout] ... | [INFO] [stdout] 620 | | tag_selector: Option bool>>, [INFO] [stdout] 621 | | ) -> Result<(Box, url::Url), crate::error::Error> { [INFO] [stdout] | |_________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `BareLocalGitControlDirFormat` [INFO] [stdout] --> src/git.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | / pub fn new() -> Self { [INFO] [stdout] 70 | | Python::attach(|py| { [INFO] [stdout] 71 | | let m = py [INFO] [stdout] 72 | | .import("breezy.git") [INFO] [stdout] ... | [INFO] [stdout] 84 | | }) [INFO] [stdout] 85 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 67 + impl Default for BareLocalGitControlDirFormat { [INFO] [stdout] 68 + fn default() -> Self { [INFO] [stdout] 69 + Self::new() [INFO] [stdout] 70 + } [INFO] [stdout] 71 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/git.rs:204:47 [INFO] [stdout] | [INFO] [stdout] 204 | let result = std::panic::catch_unwind(|| BareLocalGitControlDirFormat::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BareLocalGitControlDirFormat::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/git.rs:222:47 [INFO] [stdout] | [INFO] [stdout] 222 | let result = std::panic::catch_unwind(|| BareLocalGitControlDirFormat::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `BareLocalGitControlDirFormat::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `GPGContext` [INFO] [stdout] --> src/gpg.rs:228:5 [INFO] [stdout] | [INFO] [stdout] 228 | / pub fn new() -> Self { [INFO] [stdout] 229 | | Python::attach(|py| { [INFO] [stdout] 230 | | let gpg = PyModule::import(py, "gpg").unwrap(); [INFO] [stdout] 231 | | let gpg_context = gpg.getattr("Context").unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 234 | | }) [INFO] [stdout] 235 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 226 + impl Default for GPGContext { [INFO] [stdout] 227 + fn default() -> Self { [INFO] [stdout] 228 + Self::new() [INFO] [stdout] 229 + } [INFO] [stdout] 230 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/graph.rs:407:10 [INFO] [stdout] | [INFO] [stdout] 407 | ) -> Result< [INFO] [stdout] | __________^ [INFO] [stdout] 408 | | impl Iterator>, [INFO] [stdout] 409 | | crate::error::Error, [INFO] [stdout] 410 | | > { [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/groupcompress.rs:17:5 [INFO] [stdout] | [INFO] [stdout] 17 | / pub fn from_transport( [INFO] [stdout] 18 | | py: Python, [INFO] [stdout] 19 | | transport: &crate::transport::Transport, [INFO] [stdout] 20 | | index: Option>, [INFO] [stdout] ... | [INFO] [stdout] 25 | | use_chk_index: bool, [INFO] [stdout] 26 | | ) -> PyResult { [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/interrepository.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | get_changed_refs: std::sync::Mutex< [INFO] [stdout] | ___________________________^ [INFO] [stdout] 132 | | Box< [INFO] [stdout] 133 | | dyn FnMut( [INFO] [stdout] 134 | | &HashMap, (Vec, Option)>, [INFO] [stdout] ... | [INFO] [stdout] 137 | | >, [INFO] [stdout] 138 | | >, [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/osutils.rs:84:36 [INFO] [stdout] | [INFO] [stdout] 84 | let dir_refs: Vec<&Path> = dirs.iter().map(|p| *p).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `dirs.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] = note: `#[warn(clippy::map_clone)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/osutils.rs:96:36 [INFO] [stdout] | [INFO] [stdout] 96 | let dir_refs: Vec<&Path> = dirs.iter().map(|p| *p).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `dirs.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you are using an explicit closure for copying elements [INFO] [stdout] --> src/osutils.rs:111:36 [INFO] [stdout] | [INFO] [stdout] 111 | let dir_refs: Vec<&Path> = dirs.iter().map(|p| *p).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider calling the dedicated `copied` method: `dirs.iter().copied()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/repository.rs:1220:17 [INFO] [stdout] | [INFO] [stdout] 1220 | assert!(!write_lock.is_ok()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `write_lock.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:414:10 [INFO] [stdout] | [INFO] [stdout] 414 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:423:10 [INFO] [stdout] | [INFO] [stdout] 423 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:492:10 [INFO] [stdout] | [INFO] [stdout] 492 | ) -> Result), Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:498:10 [INFO] [stdout] | [INFO] [stdout] 498 | ) -> Result>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:519:10 [INFO] [stdout] | [INFO] [stdout] 519 | ) -> Result, Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/tree.rs:526:10 [INFO] [stdout] | [INFO] [stdout] 526 | ) -> Result), Error>>>, Error>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/tree.rs:1987:24 [INFO] [stdout] | [INFO] [stdout] 1987 | std::fs::write(&path, b"").unwrap(); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tree.rs:1994:33 [INFO] [stdout] | [INFO] [stdout] 1994 | assert!(wt.has_filename(&path)); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/tree.rs:1996:34 [INFO] [stdout] | [INFO] [stdout] 1996 | assert!(!wt.is_versioned(&path)); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/tree.rs:2032:17 [INFO] [stdout] | [INFO] [stdout] 2032 | assert!(entries.len() > 0, "Should have at least some entries"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!entries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/versionedfiles.rs:102:5 [INFO] [stdout] | [INFO] [stdout] 102 | / fn add_lines( [INFO] [stdout] 103 | | &self, [INFO] [stdout] 104 | | key: &Key, [INFO] [stdout] 105 | | parents: &[Key], [INFO] [stdout] ... | [INFO] [stdout] 111 | | check_content: bool, [INFO] [stdout] 112 | | ) -> Result<(String, usize), Error>; [INFO] [stdout] | |_______________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/versionedfiles/tests.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | / mod tests { [INFO] [stdout] 3 | | use crate::graph::Key; [INFO] [stdout] 4 | | use crate::init; [INFO] [stdout] 5 | | use crate::versionedfiles::{AbsentContentFactory, FulltextContentFactory, RecordOrdering}; [INFO] [stdout] ... | [INFO] [stdout] 74 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/osutils.rs:79:20 [INFO] [stdout] | [INFO] [stdout] 79 | let dirs = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 80 | | Path::new("/home/user1"), [INFO] [stdout] 81 | | Path::new("/home/user2"), [INFO] [stdout] 82 | | Path::new("/home/user3"), [INFO] [stdout] 83 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 79 ~ let dirs = [Path::new("/home/user1"), [INFO] [stdout] 80 + Path::new("/home/user2"), [INFO] [stdout] 81 ~ Path::new("/home/user3")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/osutils.rs:91:20 [INFO] [stdout] | [INFO] [stdout] 91 | let dirs = vec![ [INFO] [stdout] | ____________________^ [INFO] [stdout] 92 | | Path::new("/home/user1"), [INFO] [stdout] 93 | | Path::new("/home/user2"), [INFO] [stdout] 94 | | Path::new("/home/user3"), [INFO] [stdout] 95 | | ]; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 91 ~ let dirs = [Path::new("/home/user1"), [INFO] [stdout] 92 + Path::new("/home/user2"), [INFO] [stdout] 93 ~ Path::new("/home/user3")]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/osutils.rs:110:20 [INFO] [stdout] | [INFO] [stdout] 110 | let dirs = vec![Path::new("/home/user"), Path::new("/home/user/subdir")]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: you can use an array directly: `[Path::new("/home/user"), Path::new("/home/user/subdir")]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.69s [INFO] running `Command { std: "docker" "inspect" "17d04e354726792fb08d39519d22621591afd3450dc4fa5befdd640617855782", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "17d04e354726792fb08d39519d22621591afd3450dc4fa5befdd640617855782", kill_on_drop: false }` [INFO] [stdout] 17d04e354726792fb08d39519d22621591afd3450dc4fa5befdd640617855782