[INFO] fetching crate brainfuck-plusplus 1.0.1... [INFO] linting brainfuck-plusplus-1.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate brainfuck-plusplus 1.0.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate brainfuck-plusplus 1.0.1 [INFO] finished tweaking crates.io crate brainfuck-plusplus 1.0.1 [INFO] tweaked toml for crates.io crate brainfuck-plusplus 1.0.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate brainfuck-plusplus 1.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate brainfuck-plusplus 1.0.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded owo-colors v3.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 37dcae5cf0c2e5bc8bf2a1b98938afa12dec98d6042d8657baeb9543295b5821 [INFO] running `Command { std: "docker" "start" "-a" "37dcae5cf0c2e5bc8bf2a1b98938afa12dec98d6042d8657baeb9543295b5821", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "37dcae5cf0c2e5bc8bf2a1b98938afa12dec98d6042d8657baeb9543295b5821", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "37dcae5cf0c2e5bc8bf2a1b98938afa12dec98d6042d8657baeb9543295b5821", kill_on_drop: false }` [INFO] [stdout] 37dcae5cf0c2e5bc8bf2a1b98938afa12dec98d6042d8657baeb9543295b5821 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 50d8e748f03b240175f30383d64300bd94b25e6b1d84f158a69ad4ae3038fc64 [INFO] running `Command { std: "docker" "start" "-a" "50d8e748f03b240175f30383d64300bd94b25e6b1d84f158a69ad4ae3038fc64", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling proc-macro2 v1.0.36 [INFO] [stderr] Compiling libc v0.2.116 [INFO] [stderr] Compiling syn v1.0.86 [INFO] [stderr] Checking unicode-width v0.1.9 [INFO] [stderr] Compiling unicode-segmentation v1.8.0 [INFO] [stderr] Checking owo-colors v3.2.0 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Compiling heck v0.3.3 [INFO] [stderr] Compiling quote v1.0.15 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Compiling structopt-derive v0.4.18 [INFO] [stderr] Checking structopt v0.3.26 [INFO] [stderr] Checking brainfuck-plusplus v1.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return ix; [INFO] [stdout] 46 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return ix; [INFO] [stdout] 69 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return cells; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return cells; [INFO] [stdout] 204 + cells [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if cells[*possition] == 0 { [INFO] [stdout] 173 | | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ '[' [INFO] [stdout] 172 ~ if cells[*possition] == 0 => { [INFO] [stdout] 173 | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if cells[*possition] != 0 { [INFO] [stdout] 180 | | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ ']' [INFO] [stdout] 179 ~ if cells[*possition] != 0 => { [INFO] [stdout] 180 | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*&mut ((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/brainfuck.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `(*possition as usize).saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:32 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(*possition)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::path::Path` [INFO] [stdout] --> src/cli.rs:16:5 [INFO] [stdout] | [INFO] [stdout] 16 | use std::path::Path; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return ix; [INFO] [stdout] 46 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return ix; [INFO] [stdout] 46 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return ix; [INFO] [stdout] 69 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:69:5 [INFO] [stdout] | [INFO] [stdout] 69 | return ix; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return ix; [INFO] [stdout] 69 + ix [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return cells; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return cells; [INFO] [stdout] 204 + cells [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/brainfuck.rs:204:5 [INFO] [stdout] | [INFO] [stdout] 204 | return cells; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 204 - return cells; [INFO] [stdout] 204 + cells [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if cells[*possition] == 0 { [INFO] [stdout] 173 | | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ '[' [INFO] [stdout] 172 ~ if cells[*possition] == 0 => { [INFO] [stdout] 173 | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:172:17 [INFO] [stdout] | [INFO] [stdout] 172 | / if cells[*possition] == 0 { [INFO] [stdout] 173 | | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 171 ~ '[' [INFO] [stdout] 172 ~ if cells[*possition] == 0 => { [INFO] [stdout] 173 | index = do_left_bracket(chars.clone(), index) [INFO] [stdout] 174 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if cells[*possition] != 0 { [INFO] [stdout] 180 | | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ ']' [INFO] [stdout] 179 ~ if cells[*possition] != 0 => { [INFO] [stdout] 180 | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/brainfuck.rs:179:17 [INFO] [stdout] | [INFO] [stdout] 179 | / if cells[*possition] != 0 { [INFO] [stdout] 180 | | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 178 ~ ']' [INFO] [stdout] 179 ~ if cells[*possition] != 0 => { [INFO] [stdout] 180 | index = do_right_bracket(chars.clone(), index) [INFO] [stdout] 181 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*&mut ((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/brainfuck.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `(*possition as usize).saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:32 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(*possition)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `*&mut ((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/brainfuck.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `((*possition as usize).checked_sub(1)).unwrap_or_default()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual saturating arithmetic [INFO] [stdout] --> src/brainfuck.rs:145:31 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `saturating_sub`: `(*possition as usize).saturating_sub(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_saturating_arithmetic [INFO] [stdout] = note: `#[warn(clippy::manual_saturating_arithmetic)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/brainfuck.rs:145:32 [INFO] [stdout] | [INFO] [stdout] 145 | *&mut ((*possition as usize).checked_sub(1)).unwrap_or_default() as usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `(*possition)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> src/repl.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 44 | .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Cannot read stdin")) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 44 - .ok_or_else(|| io::Error::new(io::ErrorKind::Other, "Cannot read stdin")) [INFO] [stdout] 44 + .ok_or_else(|| io::Error::other("Cannot read stdin")) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/cli.rs:50:8 [INFO] [stdout] | [INFO] [stdout] 50 | if !opt.file.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `opt.file.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/cli.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 - brainfuck(contents, bf_config); [INFO] [stdout] 67 - return; [INFO] [stdout] 66 + brainfuck(contents, bf_config); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/cli.rs:47:11 [INFO] [stdout] | [INFO] [stdout] 47 | ..default_bf_config() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 7.31s [INFO] [stdout] warning: called `.as_ref().map(String::as_str)` on an `Option` value [INFO] [stdout] --> src/cli.rs:51:25 [INFO] [stdout] | [INFO] [stdout] 51 | let file_path = opt.file.as_ref().map(String::as_str).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `opt.file.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] running `Command { std: "docker" "inspect" "50d8e748f03b240175f30383d64300bd94b25e6b1d84f158a69ad4ae3038fc64", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "50d8e748f03b240175f30383d64300bd94b25e6b1d84f158a69ad4ae3038fc64", kill_on_drop: false }` [INFO] [stdout] 50d8e748f03b240175f30383d64300bd94b25e6b1d84f158a69ad4ae3038fc64