[INFO] fetching crate binmarshal-macros 1.1.3...
[INFO] linting binmarshal-macros-1.1.3 against nightly for clippy-nonminimal_bool-denied
[INFO] extracting crate binmarshal-macros 1.1.3 into /workspace/builds/worker-2-tc1/source
[INFO] started tweaking crates.io crate binmarshal-macros 1.1.3
[INFO] finished tweaking crates.io crate binmarshal-macros 1.1.3
[INFO] tweaked toml for crates.io crate binmarshal-macros 1.1.3 written to /workspace/builds/worker-2-tc1/source/Cargo.toml
[INFO] validating manifest of crates.io crate binmarshal-macros 1.1.3 on toolchain nightly
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }`
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] [stderr]     Updating crates.io index
[INFO] [stderr]      Locking 10 packages to latest compatible versions
[INFO] [stderr]       Adding darling v0.20.11 (available: v0.23.0)
[INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }`
[INFO] [stdout] c5b316b8006fc84d6a7b76e66f8191816c357cc670082b16dc28dce19abe15e3
[INFO] running `Command { std: "docker" "start" "-a" "c5b316b8006fc84d6a7b76e66f8191816c357cc670082b16dc28dce19abe15e3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "inspect" "c5b316b8006fc84d6a7b76e66f8191816c357cc670082b16dc28dce19abe15e3", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "c5b316b8006fc84d6a7b76e66f8191816c357cc670082b16dc28dce19abe15e3", kill_on_drop: false }`
[INFO] [stdout] c5b316b8006fc84d6a7b76e66f8191816c357cc670082b16dc28dce19abe15e3
[INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }`
[INFO] [stdout] 468acf2b469979512091331685e87e374dd55b22ea35123e0cf06f5d11a0d27b
[INFO] running `Command { std: "docker" "start" "-a" "468acf2b469979512091331685e87e374dd55b22ea35123e0cf06f5d11a0d27b", kill_on_drop: false }`
[INFO] [stderr]     Checking binmarshal-macros v1.1.3 (/opt/rustwide/workdir)
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:235:21
[INFO] [stdout]     |
[INFO] [stdout] 235 |     let magic_write = match attrs.magic {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 236 | |     Some(lit) => {
[INFO] [stdout] 237 | |       Some(quote!{
[INFO] [stdout] 238 | |         writer.write_magic(#lit)?
[INFO] [stdout] ...   |
[INFO] [stdout] 241 | |     None => None
[INFO] [stdout] 242 | |   };
[INFO] [stdout]     | |___^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 235 ~   let magic_write = attrs.magic.map(|lit| quote!{
[INFO] [stdout] 236 +         writer.write_magic(#lit)?
[INFO] [stdout] 237 ~       });
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:377:20
[INFO] [stdout]     |
[INFO] [stdout] 377 |     let magic_read = match attrs.magic {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 378 | |     Some(lit) => {
[INFO] [stdout] 379 | |       Some(quote!{
[INFO] [stdout] 380 | |         view.check_magic(#lit)?
[INFO] [stdout] ...   |
[INFO] [stdout] 383 | |     None => None
[INFO] [stdout] 384 | |   };
[INFO] [stdout]     | |___^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 377 ~   let magic_read = attrs.magic.map(|lit| quote!{
[INFO] [stdout] 378 +         view.check_magic(#lit)?
[INFO] [stdout] 379 ~       });
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:235:21
[INFO] [stdout]     |
[INFO] [stdout] 235 |     let magic_write = match attrs.magic {
[INFO] [stdout]     |  _____________________^
[INFO] [stdout] 236 | |     Some(lit) => {
[INFO] [stdout] 237 | |       Some(quote!{
[INFO] [stdout] 238 | |         writer.write_magic(#lit)?
[INFO] [stdout] ...   |
[INFO] [stdout] 241 | |     None => None
[INFO] [stdout] 242 | |   };
[INFO] [stdout]     | |___^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout]     = note: `#[warn(clippy::manual_map)]` on by default
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 235 ~   let magic_write = attrs.magic.map(|lit| quote!{
[INFO] [stdout] 236 +         writer.write_magic(#lit)?
[INFO] [stdout] 237 ~       });
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:411:47
[INFO] [stdout]     |
[INFO] [stdout] 411 |           let in_tag: TokenStream = parse_str(&tag).unwrap();
[INFO] [stdout]     |                                               ^^^^ help: change this to: `tag`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/lib.rs:460:9
[INFO] [stdout]     |
[INFO] [stdout] 445 | /         let read = match is_paren {
[INFO] [stdout] 446 | |           true => quote!{
[INFO] [stdout] 447 | |             (#tag) => {
[INFO] [stdout] 448 | |               #(#to_read)*
[INFO] [stdout] ...   |
[INFO] [stdout] 457 | |           },
[INFO] [stdout] 458 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 459 |
[INFO] [stdout] 460 |           read
[INFO] [stdout]     |           ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 445 ~         
[INFO] [stdout] 446 |
[INFO] [stdout] 447 ~         match is_paren {
[INFO] [stdout] 448 +           true => quote!{
[INFO] [stdout] 449 +             (#tag) => {
[INFO] [stdout] 450 +               #(#to_read)*
[INFO] [stdout] 451 +               Ok(Self::#name(#(#construct),*))
[INFO] [stdout] 452 +             }
[INFO] [stdout] 453 +           },
[INFO] [stdout] 454 +           false => quote!{
[INFO] [stdout] 455 +             (#tag) => {
[INFO] [stdout] 456 +               #(#to_read)*
[INFO] [stdout] 457 +               Ok(Self::#name { #(#construct),*})
[INFO] [stdout] 458 +             }
[INFO] [stdout] 459 +           },
[INFO] [stdout] 460 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: manual implementation of `Option::map`
[INFO] [stdout]    --> src/lib.rs:377:20
[INFO] [stdout]     |
[INFO] [stdout] 377 |     let magic_read = match attrs.magic {
[INFO] [stdout]     |  ____________________^
[INFO] [stdout] 378 | |     Some(lit) => {
[INFO] [stdout] 379 | |       Some(quote!{
[INFO] [stdout] 380 | |         view.check_magic(#lit)?
[INFO] [stdout] ...   |
[INFO] [stdout] 383 | |     None => None
[INFO] [stdout] 384 | |   };
[INFO] [stdout]     | |___^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_map
[INFO] [stdout] help: try
[INFO] [stdout]     |
[INFO] [stdout] 377 ~   let magic_read = attrs.magic.map(|lit| quote!{
[INFO] [stdout] 378 +         view.check_magic(#lit)?
[INFO] [stdout] 379 ~       });
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:522:47
[INFO] [stdout]     |
[INFO] [stdout] 522 |           let in_tag: TokenStream = parse_str(&tag).unwrap();
[INFO] [stdout]     |                                               ^^^^ help: change this to: `tag`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/lib.rs:561:9
[INFO] [stdout]     |
[INFO] [stdout] 546 | /         let update = match is_paren {
[INFO] [stdout] 547 | |           true => quote! {
[INFO] [stdout] 548 | |             Self::#name(#(#construct),*) => {
[INFO] [stdout] 549 | |               #inner_update;
[INFO] [stdout] ...   |
[INFO] [stdout] 558 | |           },
[INFO] [stdout] 559 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 560 |
[INFO] [stdout] 561 |           update
[INFO] [stdout]     |           ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 546 ~         
[INFO] [stdout] 547 |
[INFO] [stdout] 548 ~         match is_paren {
[INFO] [stdout] 549 +           true => quote! {
[INFO] [stdout] 550 +             Self::#name(#(#construct),*) => {
[INFO] [stdout] 551 +               #inner_update;
[INFO] [stdout] 552 +               #(#to_update;)*
[INFO] [stdout] 553 +             }
[INFO] [stdout] 554 +           },
[INFO] [stdout] 555 +           false => quote! {
[INFO] [stdout] 556 +             Self::#name { #(#construct),* } => {
[INFO] [stdout] 557 +               #inner_update;
[INFO] [stdout] 558 +               #(#to_update;)*
[INFO] [stdout] 559 +             }
[INFO] [stdout] 560 +           },
[INFO] [stdout] 561 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:411:47
[INFO] [stdout]     |
[INFO] [stdout] 411 |           let in_tag: TokenStream = parse_str(&tag).unwrap();
[INFO] [stdout]     |                                               ^^^^ help: change this to: `tag`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout]     = note: `#[warn(clippy::needless_borrow)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/lib.rs:460:9
[INFO] [stdout]     |
[INFO] [stdout] 445 | /         let read = match is_paren {
[INFO] [stdout] 446 | |           true => quote!{
[INFO] [stdout] 447 | |             (#tag) => {
[INFO] [stdout] 448 | |               #(#to_read)*
[INFO] [stdout] ...   |
[INFO] [stdout] 457 | |           },
[INFO] [stdout] 458 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 459 |
[INFO] [stdout] 460 |           read
[INFO] [stdout]     |           ^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout]     = note: `#[warn(clippy::let_and_return)]` on by default
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 445 ~         
[INFO] [stdout] 446 |
[INFO] [stdout] 447 ~         match is_paren {
[INFO] [stdout] 448 +           true => quote!{
[INFO] [stdout] 449 +             (#tag) => {
[INFO] [stdout] 450 +               #(#to_read)*
[INFO] [stdout] 451 +               Ok(Self::#name(#(#construct),*))
[INFO] [stdout] 452 +             }
[INFO] [stdout] 453 +           },
[INFO] [stdout] 454 +           false => quote!{
[INFO] [stdout] 455 +             (#tag) => {
[INFO] [stdout] 456 +               #(#to_read)*
[INFO] [stdout] 457 +               Ok(Self::#name { #(#construct),*})
[INFO] [stdout] 458 +             }
[INFO] [stdout] 459 +           },
[INFO] [stdout] 460 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:596:15
[INFO] [stdout]     |
[INFO] [stdout] 596 |   let clone = !(attrs.no_clone == Some(true));
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(attrs.no_clone != Some(true))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler
[INFO] [stdout]    --> src/lib.rs:522:47
[INFO] [stdout]     |
[INFO] [stdout] 522 |           let in_tag: TokenStream = parse_str(&tag).unwrap();
[INFO] [stdout]     |                                               ^^^^ help: change this to: `tag`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: returning the result of a `let` binding from a block
[INFO] [stdout]    --> src/lib.rs:561:9
[INFO] [stdout]     |
[INFO] [stdout] 546 | /         let update = match is_paren {
[INFO] [stdout] 547 | |           true => quote! {
[INFO] [stdout] 548 | |             Self::#name(#(#construct),*) => {
[INFO] [stdout] 549 | |               #inner_update;
[INFO] [stdout] ...   |
[INFO] [stdout] 558 | |           },
[INFO] [stdout] 559 | |         };
[INFO] [stdout]     | |__________- unnecessary `let` binding
[INFO] [stdout] 560 |
[INFO] [stdout] 561 |           update
[INFO] [stdout]     |           ^^^^^^
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stdout] help: return the expression directly
[INFO] [stdout]     |
[INFO] [stdout] 546 ~         
[INFO] [stdout] 547 |
[INFO] [stdout] 548 ~         match is_paren {
[INFO] [stdout] 549 +           true => quote! {
[INFO] [stdout] 550 +             Self::#name(#(#construct),*) => {
[INFO] [stdout] 551 +               #inner_update;
[INFO] [stdout] 552 +               #(#to_update;)*
[INFO] [stdout] 553 +             }
[INFO] [stdout] 554 +           },
[INFO] [stdout] 555 +           false => quote! {
[INFO] [stdout] 556 +             Self::#name { #(#construct),* } => {
[INFO] [stdout] 557 +               #inner_update;
[INFO] [stdout] 558 +               #(#to_update;)*
[INFO] [stdout] 559 +             }
[INFO] [stdout] 560 +           },
[INFO] [stdout] 561 +         }
[INFO] [stdout]     |
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stdout] warning: this boolean expression can be simplified
[INFO] [stdout]    --> src/lib.rs:596:15
[INFO] [stdout]     |
[INFO] [stdout] 596 |   let clone = !(attrs.no_clone == Some(true));
[INFO] [stdout]     |               ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(attrs.no_clone != Some(true))`
[INFO] [stdout]     |
[INFO] [stdout]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool
[INFO] [stdout]     = note: `#[warn(clippy::nonminimal_bool)]` on by default
[INFO] [stdout] 
[INFO] [stdout] 
[INFO] [stderr]     Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.73s
[INFO] running `Command { std: "docker" "inspect" "468acf2b469979512091331685e87e374dd55b22ea35123e0cf06f5d11a0d27b", kill_on_drop: false }`
[INFO] running `Command { std: "docker" "rm" "-f" "468acf2b469979512091331685e87e374dd55b22ea35123e0cf06f5d11a0d27b", kill_on_drop: false }`
[INFO] [stdout] 468acf2b469979512091331685e87e374dd55b22ea35123e0cf06f5d11a0d27b