[INFO] fetching crate bevy_kot_ecs 0.11.0... [INFO] linting bevy_kot_ecs-0.11.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bevy_kot_ecs 0.11.0 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate bevy_kot_ecs 0.11.0 [INFO] finished tweaking crates.io crate bevy_kot_ecs 0.11.0 [INFO] tweaked toml for crates.io crate bevy_kot_ecs 0.11.0 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bevy_kot_ecs 0.11.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 162 packages to latest compatible versions [INFO] [stderr] Adding bevy v0.12.1 (available: v0.18.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded bevy_kot_utils v0.11.0 [INFO] [stderr] Downloaded bevy_fn_plugin v0.1.2 [INFO] [stderr] Downloaded bevy_kot_derive v0.11.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 66f8f256ffa6d507084c05dbcbf16a2bef56260d1cb4207c08ebf91552f35df8 [INFO] running `Command { std: "docker" "start" "-a" "66f8f256ffa6d507084c05dbcbf16a2bef56260d1cb4207c08ebf91552f35df8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "66f8f256ffa6d507084c05dbcbf16a2bef56260d1cb4207c08ebf91552f35df8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66f8f256ffa6d507084c05dbcbf16a2bef56260d1cb4207c08ebf91552f35df8", kill_on_drop: false }` [INFO] [stdout] 66f8f256ffa6d507084c05dbcbf16a2bef56260d1cb4207c08ebf91552f35df8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6b40e055484ec57a4ff8fdafcf3bd38e3a855c18db7fd704d55326a681f0f499 [INFO] running `Command { std: "docker" "start" "-a" "6b40e055484ec57a4ff8fdafcf3bd38e3a855c18db7fd704d55326a681f0f499", kill_on_drop: false }` [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Compiling toml_datetime v0.6.11 [INFO] [stderr] Compiling winnow v0.5.40 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Compiling getrandom v0.3.4 [INFO] [stderr] Compiling rustc-hash v1.1.0 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking bytemuck v1.25.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking smol_str v0.2.2 [INFO] [stderr] Checking bevy_ptr v0.12.1 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking nu-ansi-term v0.50.3 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Checking sysinfo v0.29.11 [INFO] [stderr] Compiling proc-macro-error-attr v1.0.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking uuid v1.22.0 [INFO] [stderr] Compiling proc-macro-error v1.0.4 [INFO] [stderr] Checking fxhash v0.2.1 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking crossbeam-queue v0.3.12 [INFO] [stderr] Checking crossbeam-deque v0.8.6 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking bevy_tasks v0.12.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling toml_edit v0.20.7 [INFO] [stderr] Compiling bevy_macro_utils v0.12.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.12.1 [INFO] [stderr] Compiling bevy_fn_plugin v0.1.2 [INFO] [stderr] Compiling bevy_reflect_derive v0.12.1 [INFO] [stderr] Compiling bevy_ecs_macros v0.12.1 [INFO] [stderr] Compiling bevy_derive v0.12.1 [INFO] [stderr] Compiling bevy_kot_derive v0.11.0 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking tracing-subscriber v0.3.23 [INFO] [stderr] Checking bevy_utils v0.12.1 [INFO] [stderr] Checking bevy_math v0.12.1 [INFO] [stderr] Checking bevy_reflect v0.12.1 [INFO] [stderr] Checking bevy_ecs v0.12.1 [INFO] [stderr] Checking bevy_app v0.12.1 [INFO] [stderr] Checking bevy_core v0.12.1 [INFO] [stderr] Checking bevy_log v0.12.1 [INFO] [stderr] Checking bevy_input v0.12.1 [INFO] [stderr] Checking bevy_a11y v0.12.1 [INFO] [stderr] Checking bevy_time v0.12.1 [INFO] [stderr] Checking bevy_hierarchy v0.12.1 [INFO] [stderr] Checking bevy_diagnostic v0.12.1 [INFO] [stderr] Checking bevy_transform v0.12.1 [INFO] [stderr] Checking bevy_window v0.12.1 [INFO] [stderr] Checking bevy_internal v0.12.1 [INFO] [stderr] Checking bevy v0.12.1 [INFO] [stderr] Checking bevy_kot_utils v0.11.0 [INFO] [stderr] Checking bevy_kot_ecs v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:24:49 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(callonce: impl FnOnce(&mut World) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:26:55 [INFO] [stdout] | [INFO] [stdout] 26 | Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 26 - Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] 26 + Self{ callonce: Box::new(callonce), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(callonce: impl FnOnce(&mut World, V) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:53:55 [INFO] [stdout] | [INFO] [stdout] 53 | Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 53 - Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] 53 + Self{ callonce: Box::new(callonce), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:58:70 [INFO] [stdout] | [INFO] [stdout] 58 | CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 58 - CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData::default() } [INFO] [stdout] 58 + CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:68:47 [INFO] [stdout] | [INFO] [stdout] 68 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:75:52 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(callonce: impl FnOnce(&mut World, C) -> () + Send + Sync + 'static, call_value: C) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:77:67 [INFO] [stdout] | [INFO] [stdout] 77 | Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 77 - Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 77 + Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:96:38 [INFO] [stdout] | [INFO] [stdout] 96 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:101:78 [INFO] [stdout] | [INFO] [stdout] 101 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 101 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 101 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:105:45 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(callback: impl Fn(&mut World) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:107:55 [INFO] [stdout] | [INFO] [stdout] 107 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 107 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 107 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:126:16 [INFO] [stdout] | [INFO] [stdout] 126 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:126:41 [INFO] [stdout] | [INFO] [stdout] 126 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:131:78 [INFO] [stdout] | [INFO] [stdout] 131 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 131 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 131 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:135:48 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn new(callback: impl Fn(&mut World, V) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:137:55 [INFO] [stdout] | [INFO] [stdout] 137 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 137 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 137 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:142:74 [INFO] [stdout] | [INFO] [stdout] 142 | Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 142 - Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 142 + Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 152 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:152:43 [INFO] [stdout] | [INFO] [stdout] 152 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(callback: impl Fn(&mut World, C) -> () + Send + Sync + 'static, call_value: C) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:161:67 [INFO] [stdout] | [INFO] [stdout] 161 | Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 161 - Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 161 + Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | callback : Arc O + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:185:78 [INFO] [stdout] | [INFO] [stdout] 185 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 185 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 185 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:191:55 [INFO] [stdout] | [INFO] [stdout] 191 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 191 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 191 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | / match &self [INFO] [stdout] 271 | | { [INFO] [stdout] 272 | | CallbackSystem::Empty => true, [INFO] [stdout] 273 | | _ => false [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 270 - match &self [INFO] [stdout] 271 - { [INFO] [stdout] 272 - CallbackSystem::Empty => true, [INFO] [stdout] 273 - _ => false [INFO] [stdout] 274 - } [INFO] [stdout] 270 + matches!(self, CallbackSystem::Empty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | / match &self [INFO] [stdout] 280 | | { [INFO] [stdout] 281 | | CallbackSystem::New(_) => true, [INFO] [stdout] 282 | | _ => false [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 279 - match &self [INFO] [stdout] 280 - { [INFO] [stdout] 281 - CallbackSystem::New(_) => true, [INFO] [stdout] 282 - _ => false [INFO] [stdout] 283 - } [INFO] [stdout] 279 + matches!(self, CallbackSystem::New(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / match &self [INFO] [stdout] 289 | | { [INFO] [stdout] 290 | | CallbackSystem::Initialized(_) => true, [INFO] [stdout] 291 | | _ => false [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 288 - match &self [INFO] [stdout] 289 - { [INFO] [stdout] 290 - CallbackSystem::Initialized(_) => true, [INFO] [stdout] 291 - _ => false [INFO] [stdout] 292 - } [INFO] [stdout] 288 + matches!(self, CallbackSystem::Initialized(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/component_utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | let Some(mut entity_mut) = world.get_entity_mut(entity) else { return None; }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `let mut entity_mut = world.get_entity_mut(entity)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/react/react_cache.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / impl Default for ComponentReactors [INFO] [stdout] 35 | | { [INFO] [stdout] 36 | | fn default() -> Self [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | struct ComponentReactors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_cache.rs:128:76 [INFO] [stdout] | [INFO] [stdout] 128 | let _ = react_to_entity_event_impl(rtype, component_id, &mut commands, &entity_reactors); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `entity_reactors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 326 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 345 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_cache.rs:391:68 [INFO] [stdout] | [INFO] [stdout] 391 | let mut buffer = self.removal_buffer.take().unwrap_or_else(|| Vec::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:401:16 [INFO] [stdout] | [INFO] [stdout] 401 | if buffer.len() == 0 { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_cache.rs:418:29 [INFO] [stdout] | [INFO] [stdout] 418 | ... &entity_reactors [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `entity_reactors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/react/react_commands.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if !(callbacks.len() == 0) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(callbacks.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_commands.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 54 | if !(callbacks.len() == 0) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/react/react_commands.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | / pub fn on_despawn( [INFO] [stdout] 260 | | &mut self, [INFO] [stdout] 261 | | entity : Entity, [INFO] [stdout] 262 | | reactor : impl IntoSystem<(), (), Marker> + Send + Sync + 'static [INFO] [stdout] 263 | | ) -> Result [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 29 | .unwrap_or_else(|| CommandQueue::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `CommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | world.get_resource_or_insert_with(|| ReactCommandQueue::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ReactCommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | world.get_resource_or_insert_with(|| ReactCommandQueue::default()).0.push(queue); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ReactCommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/react/react_component.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | /// break the react framework. Instead use `react_commands.insert(new_entity, react_component.take());`. [INFO] [stdout] | ^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/react/react_events.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn next(&mut self) -> Option<&E> [INFO] [stdout] 78 | | { [INFO] [stdout] 79 | | self.read().next() [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | self.remove_resource::>().map_or(None, |r| Some(r.take())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.remove_resource::>().map(|r| r.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_resource.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | &self.resource::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.resource::>()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | self.get_resource::>().map_or(None, |r| Some(&r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.get_resource::>().map(|r| &r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_resource.rs:219:71 [INFO] [stdout] | [INFO] [stdout] 219 | self.get_resource::>().map_or(None, |r| Some(&r)) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | self.get_resource_mut::>().map_or(None, |r| Some(r.into_inner().get_mut_noreact())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.get_resource_mut::>().map(|r| r.into_inner().get_mut_noreact())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ReactionTriggerBundle` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/react/reaction_trigger.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / pub trait ReactionTriggerBundle [INFO] [stdout] 45 | | { [INFO] [stdout] 46 | | /// Get the number of triggers in the bundle [INFO] [stdout] 47 | | fn len(&self) -> usize; [INFO] [stdout] ... | [INFO] [stdout] 55 | | ); [INFO] [stdout] 56 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:107:80 [INFO] [stdout] | [INFO] [stdout] 107 | impl Default for Insertion { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 107 - impl Default for Insertion { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 107 + impl Default for Insertion { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:125:79 [INFO] [stdout] | [INFO] [stdout] 125 | impl Default for Mutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 125 - impl Default for Mutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 125 + impl Default for Mutation { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:144:78 [INFO] [stdout] | [INFO] [stdout] 144 | impl Default for Removal { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 144 - impl Default for Removal { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 144 + impl Default for Removal { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | EntityInsertion(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 183 - EntityInsertion(entity, PhantomData::default()) [INFO] [stdout] 183 + EntityInsertion(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:211:28 [INFO] [stdout] | [INFO] [stdout] 211 | EntityMutation(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 211 - EntityMutation(entity, PhantomData::default()) [INFO] [stdout] 211 + EntityMutation(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:243:27 [INFO] [stdout] | [INFO] [stdout] 243 | EntityRemoval(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 243 - EntityRemoval(entity, PhantomData::default()) [INFO] [stdout] 243 + EntityRemoval(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:250:86 [INFO] [stdout] | [INFO] [stdout] 250 | impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 250 - impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 250 + impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:268:83 [INFO] [stdout] | [INFO] [stdout] 268 | impl Default for Event { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 268 - impl Default for Event { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 268 + impl Default for Event { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/react/utils.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for EntityReactors [INFO] [stdout] 77 | | { [INFO] [stdout] 78 | | fn default() -> Self [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Default)] [INFO] [stdout] 60 | pub(crate) struct EntityReactors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system_callers.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return result; [INFO] [stdout] 337 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:460:1 [INFO] [stdout] | [INFO] [stdout] 460 | pub fn spawned_syscall(world: &mut World, sys_id: SysId, input: I) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:515:5 [INFO] [stdout] | [INFO] [stdout] 515 | fn insert_system(&mut self, entity: Entity, system: S) -> Result<(), ()> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/system_callers.rs:587:28 [INFO] [stdout] | [INFO] [stdout] 587 | if let Err(_) = spawned_syscall::(world, sys_id, input) [INFO] [stdout] | -------^^^^^^------------------------------------------------- help: try: `if spawned_syscall::(world, sys_id, input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:643:13 [INFO] [stdout] | [INFO] [stdout] 643 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/system_callers.rs:648:15 [INFO] [stdout] | [INFO] [stdout] 648 | match id_mapped_systems.systems.get_mut(&sys_name).map_or(None, |node| node.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `id_mapped_systems.systems.get_mut(&sys_name).and_then(|node| node.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:667:13 [INFO] [stdout] | [INFO] [stdout] 667 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:684:1 [INFO] [stdout] | [INFO] [stdout] 684 | pub fn named_syscall_direct(world: &mut World, sys_name: SysName, input: I) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/system_callers.rs:696:15 [INFO] [stdout] | [INFO] [stdout] 696 | match id_mapped_systems.systems.get_mut(&sys_name).map_or(None, |node| node.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `id_mapped_systems.systems.get_mut(&sys_name).and_then(|node| node.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:710:13 [INFO] [stdout] | [INFO] [stdout] 710 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:754:9 [INFO] [stdout] | [INFO] [stdout] 754 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:18:42 [INFO] [stdout] | [INFO] [stdout] 18 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:24:49 [INFO] [stdout] | [INFO] [stdout] 24 | pub fn new(callonce: impl FnOnce(&mut World) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:26:55 [INFO] [stdout] | [INFO] [stdout] 26 | Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] = note: `#[warn(clippy::default_constructed_unit_structs)]` on by default [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 26 - Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] 26 + Self{ callonce: Box::new(callonce), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:45:16 [INFO] [stdout] | [INFO] [stdout] 45 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:51:52 [INFO] [stdout] | [INFO] [stdout] 51 | pub fn new(callonce: impl FnOnce(&mut World, V) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:53:55 [INFO] [stdout] | [INFO] [stdout] 53 | Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 53 - Self{ callonce: Box::new(callonce), _phantom: PhantomData::default() } [INFO] [stdout] 53 + Self{ callonce: Box::new(callonce), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:58:70 [INFO] [stdout] | [INFO] [stdout] 58 | CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 58 - CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData::default() } [INFO] [stdout] 58 + CallwithOnce{ callonce: self.callonce, call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:68:18 [INFO] [stdout] | [INFO] [stdout] 68 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:68:47 [INFO] [stdout] | [INFO] [stdout] 68 | callonce : Box () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:75:52 [INFO] [stdout] | [INFO] [stdout] 75 | pub fn new(callonce: impl FnOnce(&mut World, C) -> () + Send + Sync + 'static, call_value: C) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:77:67 [INFO] [stdout] | [INFO] [stdout] 77 | Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 77 - Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 77 + Self{ callonce: Box::new(callonce), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:96:38 [INFO] [stdout] | [INFO] [stdout] 96 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:101:78 [INFO] [stdout] | [INFO] [stdout] 101 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 101 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 101 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:105:45 [INFO] [stdout] | [INFO] [stdout] 105 | pub fn new(callback: impl Fn(&mut World) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:107:55 [INFO] [stdout] | [INFO] [stdout] 107 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 107 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 107 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:126:16 [INFO] [stdout] | [INFO] [stdout] 126 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:126:41 [INFO] [stdout] | [INFO] [stdout] 126 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:131:78 [INFO] [stdout] | [INFO] [stdout] 131 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 131 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 131 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:135:48 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn new(callback: impl Fn(&mut World, V) -> () + Send + Sync + 'static) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:137:55 [INFO] [stdout] | [INFO] [stdout] 137 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 137 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 137 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:142:74 [INFO] [stdout] | [INFO] [stdout] 142 | Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 142 - Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 142 + Callwith{ callback: self.callback.clone(), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:152:18 [INFO] [stdout] | [INFO] [stdout] 152 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:152:43 [INFO] [stdout] | [INFO] [stdout] 152 | callback : Arc () + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/callbacks.rs:159:48 [INFO] [stdout] | [INFO] [stdout] 159 | pub fn new(callback: impl Fn(&mut World, C) -> () + Send + Sync + 'static, call_value: C) -> Self [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:161:67 [INFO] [stdout] | [INFO] [stdout] 161 | Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 161 - Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData::default() } [INFO] [stdout] 161 + Self{ callback: Arc::new(callback), call_value, _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/callbacks.rs:180:16 [INFO] [stdout] | [INFO] [stdout] 180 | callback : Arc O + Send + Sync + 'static>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:185:78 [INFO] [stdout] | [INFO] [stdout] 185 | { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 185 - { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData::default() } } } [INFO] [stdout] 185 + { fn clone(&self) -> Self { Self{ callback: self.callback.clone(), _phantom: PhantomData } } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/callbacks.rs:191:55 [INFO] [stdout] | [INFO] [stdout] 191 | Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 191 - Self{ callback: Arc::new(callback), _phantom: PhantomData::default() } [INFO] [stdout] 191 + Self{ callback: Arc::new(callback), _phantom: PhantomData } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:270:9 [INFO] [stdout] | [INFO] [stdout] 270 | / match &self [INFO] [stdout] 271 | | { [INFO] [stdout] 272 | | CallbackSystem::Empty => true, [INFO] [stdout] 273 | | _ => false [INFO] [stdout] 274 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 270 - match &self [INFO] [stdout] 271 - { [INFO] [stdout] 272 - CallbackSystem::Empty => true, [INFO] [stdout] 273 - _ => false [INFO] [stdout] 274 - } [INFO] [stdout] 270 + matches!(self, CallbackSystem::Empty) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | / match &self [INFO] [stdout] 280 | | { [INFO] [stdout] 281 | | CallbackSystem::New(_) => true, [INFO] [stdout] 282 | | _ => false [INFO] [stdout] 283 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 279 - match &self [INFO] [stdout] 280 - { [INFO] [stdout] 281 - CallbackSystem::New(_) => true, [INFO] [stdout] 282 - _ => false [INFO] [stdout] 283 - } [INFO] [stdout] 279 + matches!(self, CallbackSystem::New(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/callbacks.rs:288:9 [INFO] [stdout] | [INFO] [stdout] 288 | / match &self [INFO] [stdout] 289 | | { [INFO] [stdout] 290 | | CallbackSystem::Initialized(_) => true, [INFO] [stdout] 291 | | _ => false [INFO] [stdout] 292 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 288 - match &self [INFO] [stdout] 289 - { [INFO] [stdout] 290 - CallbackSystem::Initialized(_) => true, [INFO] [stdout] 291 - _ => false [INFO] [stdout] 292 - } [INFO] [stdout] 288 + matches!(self, CallbackSystem::Initialized(_)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `let...else` may be rewritten with the `?` operator [INFO] [stdout] --> src/component_utils.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | let Some(mut entity_mut) = world.get_entity_mut(entity) else { return None; }; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `let mut entity_mut = world.get_entity_mut(entity)?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/react/react_cache.rs:34:1 [INFO] [stdout] | [INFO] [stdout] 34 | / impl Default for ComponentReactors [INFO] [stdout] 35 | | { [INFO] [stdout] 36 | | fn default() -> Self [INFO] [stdout] ... | [INFO] [stdout] 44 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 17 + #[derive(Default)] [INFO] [stdout] 18 | struct ComponentReactors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_cache.rs:128:76 [INFO] [stdout] | [INFO] [stdout] 128 | let _ = react_to_entity_event_impl(rtype, component_id, &mut commands, &entity_reactors); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `entity_reactors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:307:12 [INFO] [stdout] | [INFO] [stdout] 307 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:326:12 [INFO] [stdout] | [INFO] [stdout] 326 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:345:12 [INFO] [stdout] | [INFO] [stdout] 345 | if callbacks.len() > 0 { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_cache.rs:391:68 [INFO] [stdout] | [INFO] [stdout] 391 | let mut buffer = self.removal_buffer.take().unwrap_or_else(|| Vec::default()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Vec::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_cache.rs:401:16 [INFO] [stdout] | [INFO] [stdout] 401 | if buffer.len() == 0 { continue; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `buffer.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_cache.rs:418:29 [INFO] [stdout] | [INFO] [stdout] 418 | ... &entity_reactors [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `entity_reactors` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/react/react_commands.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if !(callbacks.len() == 0) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(callbacks.len() != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/react/react_commands.rs:54:10 [INFO] [stdout] | [INFO] [stdout] 54 | if !(callbacks.len() == 0) { return; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `callbacks.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/react/react_commands.rs:259:5 [INFO] [stdout] | [INFO] [stdout] 259 | / pub fn on_despawn( [INFO] [stdout] 260 | | &mut self, [INFO] [stdout] 261 | | entity : Entity, [INFO] [stdout] 262 | | reactor : impl IntoSystem<(), (), Marker> + Send + Sync + 'static [INFO] [stdout] 263 | | ) -> Result [INFO] [stdout] | |________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:29:25 [INFO] [stdout] | [INFO] [stdout] 29 | .unwrap_or_else(|| CommandQueue::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `CommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:26:39 [INFO] [stdout] | [INFO] [stdout] 26 | world.get_resource_or_insert_with(|| ReactCommandQueue::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ReactCommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/react/react_component.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | world.get_resource_or_insert_with(|| ReactCommandQueue::default()).0.push(queue); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `ReactCommandQueue::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/react/react_component.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 83 | /// break the react framework. Instead use `react_commands.insert(new_entity, react_component.take());`. [INFO] [stdout] | ^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `next` can be confused for the standard trait method `std::iter::Iterator::next` [INFO] [stdout] --> src/react/react_events.rs:77:5 [INFO] [stdout] | [INFO] [stdout] 77 | / pub fn next(&mut self) -> Option<&E> [INFO] [stdout] 78 | | { [INFO] [stdout] 79 | | self.read().next() [INFO] [stdout] 80 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: consider implementing the trait `std::iter::Iterator` or choosing a less ambiguous method name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#should_implement_trait [INFO] [stdout] = note: `#[warn(clippy::should_implement_trait)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:189:9 [INFO] [stdout] | [INFO] [stdout] 189 | self.remove_resource::>().map_or(None, |r| Some(r.take())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.remove_resource::>().map(|r| r.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_resource.rs:209:9 [INFO] [stdout] | [INFO] [stdout] 209 | &self.resource::>() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `self.resource::>()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:219:9 [INFO] [stdout] | [INFO] [stdout] 219 | self.get_resource::>().map_or(None, |r| Some(&r)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.get_resource::>().map(|r| &r)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/react/react_resource.rs:219:71 [INFO] [stdout] | [INFO] [stdout] 219 | self.get_resource::>().map_or(None, |r| Some(&r)) [INFO] [stdout] | ^^ help: change this to: `r` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/react/react_resource.rs:224:9 [INFO] [stdout] | [INFO] [stdout] 224 | self.get_resource_mut::>().map_or(None, |r| Some(r.into_inner().get_mut_noreact())) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `map`: `self.get_resource_mut::>().map(|r| r.into_inner().get_mut_noreact())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait `ReactionTriggerBundle` has a `len` method but no (possibly inherited) `is_empty` method [INFO] [stdout] --> src/react/reaction_trigger.rs:44:1 [INFO] [stdout] | [INFO] [stdout] 44 | / pub trait ReactionTriggerBundle [INFO] [stdout] 45 | | { [INFO] [stdout] 46 | | /// Get the number of triggers in the bundle [INFO] [stdout] 47 | | fn len(&self) -> usize; [INFO] [stdout] ... | [INFO] [stdout] 55 | | ); [INFO] [stdout] 56 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:107:80 [INFO] [stdout] | [INFO] [stdout] 107 | impl Default for Insertion { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 107 - impl Default for Insertion { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 107 + impl Default for Insertion { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:125:79 [INFO] [stdout] | [INFO] [stdout] 125 | impl Default for Mutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 125 - impl Default for Mutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 125 + impl Default for Mutation { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:144:78 [INFO] [stdout] | [INFO] [stdout] 144 | impl Default for Removal { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 144 - impl Default for Removal { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 144 + impl Default for Removal { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:183:29 [INFO] [stdout] | [INFO] [stdout] 183 | EntityInsertion(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 183 - EntityInsertion(entity, PhantomData::default()) [INFO] [stdout] 183 + EntityInsertion(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:211:28 [INFO] [stdout] | [INFO] [stdout] 211 | EntityMutation(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 211 - EntityMutation(entity, PhantomData::default()) [INFO] [stdout] 211 + EntityMutation(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:243:27 [INFO] [stdout] | [INFO] [stdout] 243 | EntityRemoval(entity, PhantomData::default()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 243 - EntityRemoval(entity, PhantomData::default()) [INFO] [stdout] 243 + EntityRemoval(entity, PhantomData) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:250:86 [INFO] [stdout] | [INFO] [stdout] 250 | impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 250 - impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 250 + impl Default for ResourceMutation { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `default` to create a unit struct [INFO] [stdout] --> src/react/reaction_triggers_impl.rs:268:83 [INFO] [stdout] | [INFO] [stdout] 268 | impl Default for Event { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#default_constructed_unit_structs [INFO] [stdout] help: remove this call to `default` [INFO] [stdout] | [INFO] [stdout] 268 - impl Default for Event { fn default() -> Self { Self(PhantomData::default()) } } [INFO] [stdout] 268 + impl Default for Event { fn default() -> Self { Self(PhantomData) } } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/react/utils.rs:76:1 [INFO] [stdout] | [INFO] [stdout] 76 | / impl Default for EntityReactors [INFO] [stdout] 77 | | { [INFO] [stdout] 78 | | fn default() -> Self [INFO] [stdout] ... | [INFO] [stdout] 86 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 59 + #[derive(Default)] [INFO] [stdout] 60 | pub(crate) struct EntityReactors [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/system_callers.rs:337:5 [INFO] [stdout] | [INFO] [stdout] 337 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 337 - return result; [INFO] [stdout] 337 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:460:1 [INFO] [stdout] | [INFO] [stdout] 460 | pub fn spawned_syscall(world: &mut World, sys_id: SysId, input: I) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:515:5 [INFO] [stdout] | [INFO] [stdout] 515 | fn insert_system(&mut self, entity: Entity, system: S) -> Result<(), ()> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_err()` [INFO] [stdout] --> src/system_callers.rs:587:28 [INFO] [stdout] | [INFO] [stdout] 587 | if let Err(_) = spawned_syscall::(world, sys_id, input) [INFO] [stdout] | -------^^^^^^------------------------------------------------- help: try: `if spawned_syscall::(world, sys_id, input).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:643:13 [INFO] [stdout] | [INFO] [stdout] 643 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/system_callers.rs:648:15 [INFO] [stdout] | [INFO] [stdout] 648 | match id_mapped_systems.systems.get_mut(&sys_name).map_or(None, |node| node.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `id_mapped_systems.systems.get_mut(&sys_name).and_then(|node| node.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:667:13 [INFO] [stdout] | [INFO] [stdout] 667 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/system_callers.rs:684:1 [INFO] [stdout] | [INFO] [stdout] 684 | pub fn named_syscall_direct(world: &mut World, sys_name: SysName, input: I) -> Result [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:691:13 [INFO] [stdout] | [INFO] [stdout] 691 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/system_callers.rs:696:15 [INFO] [stdout] | [INFO] [stdout] 696 | match id_mapped_systems.systems.get_mut(&sys_name).map_or(None, |node| node.take()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `id_mapped_systems.systems.get_mut(&sys_name).and_then(|node| node.take())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:710:13 [INFO] [stdout] | [INFO] [stdout] 710 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/system_callers.rs:754:9 [INFO] [stdout] | [INFO] [stdout] 754 | || IdMappedSystems::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `IdMappedSystems::default` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 36.90s [INFO] running `Command { std: "docker" "inspect" "6b40e055484ec57a4ff8fdafcf3bd38e3a855c18db7fd704d55326a681f0f499", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6b40e055484ec57a4ff8fdafcf3bd38e3a855c18db7fd704d55326a681f0f499", kill_on_drop: false }` [INFO] [stdout] 6b40e055484ec57a4ff8fdafcf3bd38e3a855c18db7fd704d55326a681f0f499