[INFO] fetching crate bevy_erm_core 0.0.1... [INFO] linting bevy_erm_core-0.0.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bevy_erm_core 0.0.1 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate bevy_erm_core 0.0.1 [INFO] finished tweaking crates.io crate bevy_erm_core 0.0.1 [INFO] tweaked toml for crates.io crate bevy_erm_core 0.0.1 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bevy_erm_core 0.0.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 300 packages to latest compatible versions [INFO] [stderr] Adding bevy_ecs v0.12.1 (available: v0.18.1) [INFO] [stderr] Adding bevy_ecs_macros v0.12.1 (available: v0.18.1) [INFO] [stderr] Adding bevy_mod_index v0.3.0 (available: v0.9.0) [INFO] [stderr] Adding bevy_reflect v0.12.1 (available: v0.18.1) [INFO] [stderr] Adding bevy_utils v0.12.1 (available: v0.18.1) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding sqlx v0.7.4 (available: v0.8.6) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded generational-arena v0.2.9 [INFO] [stderr] Downloaded bevy_utils_proc_macros v0.12.1 [INFO] [stderr] Downloaded casey v0.4.2 [INFO] [stderr] Downloaded bevy_macro_utils v0.12.1 [INFO] [stderr] Downloaded bevy_ptr v0.12.1 [INFO] [stderr] Downloaded bevy_reflect_derive v0.12.1 [INFO] [stderr] Downloaded bevy_utils v0.12.1 [INFO] [stderr] Downloaded bevy_log v0.12.1 [INFO] [stderr] Downloaded bevy_core v0.12.1 [INFO] [stderr] Downloaded bevy_ecs_macros v0.12.1 [INFO] [stderr] Downloaded bevy_diagnostic v0.12.1 [INFO] [stderr] Downloaded bevy_time v0.12.1 [INFO] [stderr] Downloaded bevy_transform v0.12.1 [INFO] [stderr] Downloaded bevy_mod_index v0.3.0 [INFO] [stderr] Downloaded bevy_reflect v0.12.1 [INFO] [stderr] Downloaded bevy_window v0.12.1 [INFO] [stderr] Downloaded bevy_hierarchy v0.12.1 [INFO] [stderr] Downloaded bevy_app v0.12.1 [INFO] [stderr] Downloaded bevy_tasks v0.12.1 [INFO] [stderr] Downloaded bevy_input v0.12.1 [INFO] [stderr] Downloaded bevy_math v0.12.1 [INFO] [stderr] Downloaded bevy_a11y v0.12.1 [INFO] [stderr] Downloaded bevy_derive v0.12.1 [INFO] [stderr] Downloaded bevy_internal v0.12.1 [INFO] [stderr] Downloaded bevy_ecs v0.12.1 [INFO] [stderr] Downloaded bevy v0.12.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 95683cf46f2da06085f83c2a9c6821419eeb0c91aee3a694235035424dabdd8d [INFO] running `Command { std: "docker" "start" "-a" "95683cf46f2da06085f83c2a9c6821419eeb0c91aee3a694235035424dabdd8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "95683cf46f2da06085f83c2a9c6821419eeb0c91aee3a694235035424dabdd8d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "95683cf46f2da06085f83c2a9c6821419eeb0c91aee3a694235035424dabdd8d", kill_on_drop: false }` [INFO] [stdout] 95683cf46f2da06085f83c2a9c6821419eeb0c91aee3a694235035424dabdd8d [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] cf88e28d350f8dba344cff0ce004bc7bcbf342f1d7f14e1a3ff3a5139da7ee5c [INFO] running `Command { std: "docker" "start" "-a" "cf88e28d350f8dba344cff0ce004bc7bcbf342f1d7f14e1a3ff3a5139da7ee5c", kill_on_drop: false }` [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling ahash v0.8.12 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Compiling getrandom v0.4.2 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking event-listener v2.5.3 [INFO] [stderr] Compiling zerofrom v0.1.6 [INFO] [stderr] Compiling toml_edit v0.20.7 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking instant v0.1.13 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Compiling bevy_utils_proc_macros v0.12.1 [INFO] [stderr] Checking nonmax v0.5.5 [INFO] [stderr] Checking fastrand v1.9.0 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Checking bevy_ptr v0.12.1 [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling uuid v1.22.0 [INFO] [stderr] Compiling yoke v0.8.1 [INFO] [stderr] Checking regex-syntax v0.8.10 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Compiling futures-sink v0.3.32 [INFO] [stderr] Compiling zerovec v0.11.5 [INFO] [stderr] Compiling zerotrie v0.2.3 [INFO] [stderr] Compiling libsqlite3-sys v0.27.0 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Checking tracing-log v0.1.4 [INFO] [stderr] Compiling slab v0.4.12 [INFO] [stderr] Checking concurrent-queue v2.5.0 [INFO] [stderr] Compiling allocator-api2 v0.2.21 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling form_urlencoded v1.2.2 [INFO] [stderr] Checking async-channel v1.9.0 [INFO] [stderr] Checking async-executor v1.14.0 [INFO] [stderr] Compiling futures-util v0.3.32 [INFO] [stderr] Compiling hashbrown v0.14.5 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling tokio v1.50.0 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling tinystr v0.8.2 [INFO] [stderr] Compiling potential_utf v0.1.4 [INFO] [stderr] Checking bevy_tasks v0.12.1 [INFO] [stderr] Compiling icu_collections v2.1.1 [INFO] [stderr] Compiling generic-array v0.14.7 [INFO] [stderr] Compiling icu_locale_core v2.1.1 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling unicode_categories v0.1.1 [INFO] [stderr] Compiling crypto-common v0.1.7 [INFO] [stderr] Compiling block-buffer v0.10.4 [INFO] [stderr] Compiling crc-catalog v2.4.0 [INFO] [stderr] Compiling cpufeatures v0.2.17 [INFO] [stderr] Compiling digest v0.10.7 [INFO] [stderr] Compiling crc v3.4.0 [INFO] [stderr] Compiling hashlink v0.8.4 [INFO] [stderr] Compiling sha2 v0.10.9 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Compiling bevy_macro_utils v0.12.1 [INFO] [stderr] Compiling crossbeam-queue v0.3.12 [INFO] [stderr] Compiling futures-intrusive v0.5.0 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling icu_provider v2.1.1 [INFO] [stderr] Compiling sqlformat v0.2.6 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling icu_normalizer v2.1.1 [INFO] [stderr] Compiling icu_properties v2.1.2 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling serde_json v1.0.149 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling byteorder v1.5.0 [INFO] [stderr] Checking accesskit v0.12.3 [INFO] [stderr] Compiling linux-raw-sys v0.12.1 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling atoi v2.0.0 [INFO] [stderr] Compiling flume v0.11.1 [INFO] [stderr] Compiling bevy_reflect_derive v0.12.1 [INFO] [stderr] Compiling bevy_ecs_macros v0.12.1 [INFO] [stderr] Compiling bevy_derive v0.12.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Checking sysinfo v0.29.11 [INFO] [stderr] Checking raw-window-handle v0.5.2 [INFO] [stderr] Compiling urlencoding v2.1.3 [INFO] [stderr] Compiling heck v0.4.1 [INFO] [stderr] Compiling futures-executor v0.3.32 [INFO] [stderr] Compiling idna_adapter v1.2.1 [INFO] [stderr] Compiling idna v1.1.0 [INFO] [stderr] Compiling dotenvy v0.15.7 [INFO] [stderr] Checking dirs-sys-next v0.1.2 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking glam v0.24.2 [INFO] [stderr] Checking erased-serde v0.3.31 [INFO] [stderr] Checking tracing-subscriber v0.3.23 [INFO] [stderr] Compiling url v2.5.8 [INFO] [stderr] Checking bevy_utils v0.12.1 [INFO] [stderr] Checking dirs-next v2.0.0 [INFO] [stderr] Checking csv-core v0.1.13 [INFO] [stderr] Checking term v0.7.0 [INFO] [stderr] Compiling tempfile v3.27.0 [INFO] [stderr] Checking csv v1.4.0 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Checking generational-arena v0.2.9 [INFO] [stderr] Compiling casey v0.4.2 [INFO] [stderr] Checking encode_unicode v1.0.0 [INFO] [stderr] Checking prettytable-rs v0.10.0 [INFO] [stderr] Compiling tokio-stream v0.1.18 [INFO] [stderr] Compiling sqlx-core v0.7.4 [INFO] [stderr] Checking bevy_math v0.12.1 [INFO] [stderr] Checking bevy_reflect v0.12.1 [INFO] [stderr] Checking bevy_ecs v0.12.1 [INFO] [stderr] Compiling sqlx-sqlite v0.7.4 [INFO] [stderr] Compiling sqlx-macros-core v0.7.4 [INFO] [stderr] Compiling sqlx-macros v0.7.4 [INFO] [stderr] Checking bevy_app v0.12.1 [INFO] [stderr] Checking sqlx v0.7.4 [INFO] [stderr] Checking bevy_log v0.12.1 [INFO] [stderr] Checking bevy_core v0.12.1 [INFO] [stderr] Checking bevy_time v0.12.1 [INFO] [stderr] Checking bevy_a11y v0.12.1 [INFO] [stderr] Checking bevy_input v0.12.1 [INFO] [stderr] Checking bevy_hierarchy v0.12.1 [INFO] [stderr] Checking bevy_diagnostic v0.12.1 [INFO] [stderr] Checking bevy_transform v0.12.1 [INFO] [stderr] Checking bevy_window v0.12.1 [INFO] [stderr] Checking bevy_internal v0.12.1 [INFO] [stderr] Checking bevy v0.12.1 [INFO] [stderr] Checking bevy_mod_index v0.3.0 [INFO] [stderr] Checking bevy_erm_core v0.0.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/database_query.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn commit(&self, request: RequestId) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:394:6 [INFO] [stdout] | [INFO] [stdout] 394 | impl<'a, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:401:6 [INFO] [stdout] | [INFO] [stdout] 401 | impl<'a, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:409:6 [INFO] [stdout] | [INFO] [stdout] 409 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/database_query.rs:221:5 [INFO] [stdout] | [INFO] [stdout] 221 | pub fn commit(&self, request: RequestId) -> Result<(), ()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] = note: `#[warn(clippy::result_unit_err)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:486:6 [INFO] [stdout] | [INFO] [stdout] 486 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:494:6 [INFO] [stdout] | [INFO] [stdout] 494 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:394:6 [INFO] [stdout] | [INFO] [stdout] 394 | impl<'a, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:401:6 [INFO] [stdout] | [INFO] [stdout] 401 | impl<'a, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:409:6 [INFO] [stdout] | [INFO] [stdout] 409 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:486:6 [INFO] [stdout] | [INFO] [stdout] 486 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:494:6 [INFO] [stdout] | [INFO] [stdout] 494 | impl<'b, T: ComponentMapper, DbResource: DatabaseResource> [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 691 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 831 | 'b, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:691:9 [INFO] [stdout] | [INFO] [stdout] 691 | 'a, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/database_query.rs:831:9 [INFO] [stdout] | [INFO] [stdout] 831 | 'b, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/database_resource.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut arena = database_handle.tr.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/database_resource.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | let tr = tr_lock_guard.await.a.take().unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] 119 | tr.commit().await.unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this write lock is used only for reading [INFO] [stdout] --> src/database_resource.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | let mut arena = database_handle.tr.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a read lock instead: `database_handle.tr.read()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#readonly_write_lock [INFO] [stdout] = note: `#[warn(clippy::readonly_write_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/database_resource.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / fn update_or_insert_component( [INFO] [stdout] 132 | | db_entity: DatabaseEntity, [INFO] [stdout] 133 | | entity: Entity, [INFO] [stdout] 134 | | component_type_id: TypeId, [INFO] [stdout] ... | [INFO] [stdout] 137 | | world: &mut World, [INFO] [stdout] 138 | | ) -> Result<(), ()>; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `MutexGuard` is held across an await point [INFO] [stdout] --> src/database_resource.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let mut arena = database_handle.tr.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using an async-aware `Mutex` type or ensuring the `MutexGuard` is dropped before calling `await` [INFO] [stdout] note: these are all the await points this lock is held through [INFO] [stdout] --> src/database_resource.rs:118:36 [INFO] [stdout] | [INFO] [stdout] 118 | let tr = tr_lock_guard.await.a.take().unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] 119 | tr.commit().await.unwrap(); [INFO] [stdout] | ^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#await_holding_lock [INFO] [stdout] = note: `#[warn(clippy::await_holding_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this write lock is used only for reading [INFO] [stdout] --> src/database_resource.rs:115:29 [INFO] [stdout] | [INFO] [stdout] 115 | let mut arena = database_handle.tr.write().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a read lock instead: `database_handle.tr.read()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#readonly_write_lock [INFO] [stdout] = note: `#[warn(clippy::readonly_write_lock)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this returns a `Result<_, ()>` [INFO] [stdout] --> src/database_resource.rs:131:5 [INFO] [stdout] | [INFO] [stdout] 131 | / fn update_or_insert_component( [INFO] [stdout] 132 | | db_entity: DatabaseEntity, [INFO] [stdout] 133 | | entity: Entity, [INFO] [stdout] 134 | | component_type_id: TypeId, [INFO] [stdout] ... | [INFO] [stdout] 137 | | world: &mut World, [INFO] [stdout] 138 | | ) -> Result<(), ()>; [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: use a custom `Error` type instead [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_unit_err [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 16s [INFO] running `Command { std: "docker" "inspect" "cf88e28d350f8dba344cff0ce004bc7bcbf342f1d7f14e1a3ff3a5139da7ee5c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cf88e28d350f8dba344cff0ce004bc7bcbf342f1d7f14e1a3ff3a5139da7ee5c", kill_on_drop: false }` [INFO] [stdout] cf88e28d350f8dba344cff0ce004bc7bcbf342f1d7f14e1a3ff3a5139da7ee5c