[INFO] fetching crate bellperson-ed25519 0.3.0... [INFO] linting bellperson-ed25519-0.3.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bellperson-ed25519 0.3.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate bellperson-ed25519 0.3.0 [INFO] finished tweaking crates.io crate bellperson-ed25519 0.3.0 [INFO] tweaked toml for crates.io crate bellperson-ed25519 0.3.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bellperson-ed25519 0.3.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 89 packages to latest compatible versions [INFO] [stderr] Adding bellperson v0.25.0 (available: v0.27.0) [INFO] [stderr] Adding generic-array v0.14.7 (available: v0.14.9) [INFO] [stderr] Adding rand v0.8.5 (available: v0.10.0) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded pairing v0.23.0 [INFO] [stderr] Downloaded execute v0.2.15 [INFO] [stderr] Downloaded bellperson-emulated v0.2.0 [INFO] [stderr] Downloaded flume v0.10.14 [INFO] [stderr] Downloaded execute-command-tokens v0.1.9 [INFO] [stderr] Downloaded yastl v0.1.2 [INFO] [stderr] Downloaded blstrs v0.7.1 [INFO] [stderr] Downloaded ec-gpu v0.2.0 [INFO] [stderr] Downloaded generic-array v1.3.5 [INFO] [stderr] Downloaded ec-gpu-gen v0.6.0 [INFO] [stderr] Downloaded pasta_curves v0.5.1 [INFO] [stderr] Downloaded execute-command-macro-impl v0.1.12 [INFO] [stderr] Downloaded execute-command-macro v0.1.11 [INFO] [stderr] Downloaded bellperson v0.25.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] de5b93f82edcdc4b655a961269ffac25a9b22bf9a8978ff22e519c3a86b36128 [INFO] running `Command { std: "docker" "start" "-a" "de5b93f82edcdc4b655a961269ffac25a9b22bf9a8978ff22e519c3a86b36128", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "de5b93f82edcdc4b655a961269ffac25a9b22bf9a8978ff22e519c3a86b36128", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "de5b93f82edcdc4b655a961269ffac25a9b22bf9a8978ff22e519c3a86b36128", kill_on_drop: false }` [INFO] [stdout] de5b93f82edcdc4b655a961269ffac25a9b22bf9a8978ff22e519c3a86b36128 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] fa7cafba92bb5e62b20c5328354e103157e4a77aa2ec733afbec75c6fa76ff3e [INFO] running `Command { std: "docker" "start" "-a" "fa7cafba92bb5e62b20c5328354e103157e4a77aa2ec733afbec75c6fa76ff3e", kill_on_drop: false }` [INFO] [stderr] Compiling typenum v1.19.0 [INFO] [stderr] Compiling rand_core v0.6.4 [INFO] [stderr] Compiling tap v1.0.1 [INFO] [stderr] Compiling execute-command-tokens v0.1.9 [INFO] [stderr] Compiling crossbeam-utils v0.8.21 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Compiling funty v2.0.0 [INFO] [stderr] Compiling blst v0.3.16 [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling subtle v2.6.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking rand_xorshift v0.3.0 [INFO] [stderr] Compiling ec-gpu-gen v0.6.0 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling wyz v0.5.1 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling rand v0.8.5 [INFO] [stderr] Compiling spin v0.9.8 [INFO] [stderr] Compiling byte-slice-cast v1.2.3 [INFO] [stderr] Compiling hex v0.4.3 [INFO] [stderr] Compiling once_cell v1.21.4 [INFO] [stderr] Compiling ec-gpu v0.2.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking crossbeam-channel v0.5.15 [INFO] [stderr] Compiling flume v0.10.14 [INFO] [stderr] Checking yastl v0.1.2 [INFO] [stderr] Compiling num_cpus v1.17.0 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking blake2s_simd v1.0.4 [INFO] [stderr] Compiling crossbeam-epoch v0.9.18 [INFO] [stderr] Checking memmap2 v0.5.10 [INFO] [stderr] Compiling threadpool v1.8.1 [INFO] [stderr] Checking lazy_static v1.5.0 [INFO] [stderr] Checking blake2b_simd v1.0.4 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Compiling crossbeam-deque v0.8.6 [INFO] [stderr] Compiling rayon-core v1.13.0 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking generic-array v1.3.5 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Checking crypto-common v0.1.7 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking pairing v0.23.0 [INFO] [stderr] Checking pasta_curves v0.5.1 [INFO] [stderr] Compiling execute-command-macro-impl v0.1.12 [INFO] [stderr] Compiling zeroize_derive v1.4.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling zeroize v1.8.2 [INFO] [stderr] Compiling execute-command-macro v0.1.11 [INFO] [stderr] Checking execute v0.2.15 [INFO] [stderr] Compiling thiserror v1.0.69 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Checking blstrs v0.7.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling bellperson v0.25.0 [INFO] [stderr] Checking bellperson-emulated v0.2.0 [INFO] [stderr] Checking bellperson-ed25519 v0.3.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/circuit.rs:291:27 [INFO] [stdout] | [INFO] [stdout] 291 | selector_bits.into_iter().rev(), // mux_tree requires MSB first [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/circuit.rs:296:27 [INFO] [stdout] | [INFO] [stdout] 296 | selector_bits.into_iter().rev(), // mux_tree requires MSB first [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/circuit.rs:320:12 [INFO] [stdout] | [INFO] [stdout] 320 | if !(window_size > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(window_size <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:404:13 [INFO] [stdout] | [INFO] [stdout] 404 | i = i - window_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `i -= window_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/circuit.rs:419:17 [INFO] [stdout] | [INFO] [stdout] 419 | &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `lookup_table` [INFO] [stdout] --> src/circuit.rs:426:22 [INFO] [stdout] | [INFO] [stdout] 426 | for j in 2..(1usize << num_remaining_bits) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 426 - for j in 2..(1usize << num_remaining_bits) { [INFO] [stdout] 426 + for (j, ) in lookup_table.iter().enumerate().take((1usize << num_remaining_bits)).skip(2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `scalar` [INFO] [stdout] --> src/circuit.rs:438:22 [INFO] [stdout] | [INFO] [stdout] 438 | for j in 0..num_remaining_bits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 438 - for j in 0..num_remaining_bits { [INFO] [stdout] 438 + for in scalar.iter().take(num_remaining_bits) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/circuit.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:26:41 [INFO] [stdout] | [INFO] [stdout] 26 | Ed25519Curve::add_points(&self, &rhs) [INFO] [stdout] | ^^^^ help: change this to: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | Ed25519Curve::add_points(self, &rhs) [INFO] [stdout] | ^^^^ help: change this to: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | Ed25519Curve::add_points(&self, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:97:41 [INFO] [stdout] | [INFO] [stdout] 97 | Ed25519Curve::add_points(&self, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bool` [INFO] [stdout] --> src/curve.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if x.is_even().into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `x.is_even()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/curve.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | scaled_scalar = scaled_scalar >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scaled_scalar >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/field.rs:136:6 [INFO] [stdout] | [INFO] [stdout] 136 | impl<'a> Neg for &'a Fe25519 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 136 - impl<'a> Neg for &'a Fe25519 { [INFO] [stdout] 136 + impl Neg for &Fe25519 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bool` [INFO] [stdout] --> src/field.rs:232:26 [INFO] [stdout] | [INFO] [stdout] 232 | let sq_root = if bool::from(neg_not_required) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `bool::from()`: `neg_not_required` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/circuit.rs:291:27 [INFO] [stdout] | [INFO] [stdout] 291 | selector_bits.into_iter().rev(), // mux_tree requires MSB first [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `slice` [INFO] [stdout] --> src/circuit.rs:296:27 [INFO] [stdout] | [INFO] [stdout] 296 | selector_bits.into_iter().rev(), // mux_tree requires MSB first [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/circuit.rs:320:12 [INFO] [stdout] | [INFO] [stdout] 320 | if !(window_size > 0) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `(window_size <= 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:404:13 [INFO] [stdout] | [INFO] [stdout] 404 | i = i - window_size; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace it with: `i -= window_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/circuit.rs:419:17 [INFO] [stdout] | [INFO] [stdout] 419 | &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `lookup_table` [INFO] [stdout] --> src/circuit.rs:426:22 [INFO] [stdout] | [INFO] [stdout] 426 | for j in 2..(1usize << num_remaining_bits) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 426 - for j in 2..(1usize << num_remaining_bits) { [INFO] [stdout] 426 + for (j, ) in lookup_table.iter().enumerate().take((1usize << num_remaining_bits)).skip(2) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is only used to index `scalar` [INFO] [stdout] --> src/circuit.rs:438:22 [INFO] [stdout] | [INFO] [stdout] 438 | for j in 0..num_remaining_bits { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 438 - for j in 0..num_remaining_bits { [INFO] [stdout] 438 + for in scalar.iter().take(num_remaining_bits) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/circuit.rs:461:13 [INFO] [stdout] | [INFO] [stdout] 461 | &self, [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:558:9 [INFO] [stdout] | [INFO] [stdout] 558 | scalar = scalar >> 3; // scalar now has 253 significant bits [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scalar >>= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:568:13 [INFO] [stdout] | [INFO] [stdout] 568 | scalar = scalar >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scalar >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:608:9 [INFO] [stdout] | [INFO] [stdout] 608 | scalar = scalar >> 3; // scalar now has 253 significant bits [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scalar >>= 3` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/circuit.rs:618:13 [INFO] [stdout] | [INFO] [stdout] 618 | scalar = scalar >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scalar >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:26:41 [INFO] [stdout] | [INFO] [stdout] 26 | Ed25519Curve::add_points(&self, &rhs) [INFO] [stdout] | ^^^^ help: change this to: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:34:40 [INFO] [stdout] | [INFO] [stdout] 34 | Ed25519Curve::add_points(self, &rhs) [INFO] [stdout] | ^^^^ help: change this to: `rhs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:97:34 [INFO] [stdout] | [INFO] [stdout] 97 | Ed25519Curve::add_points(&self, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:97:41 [INFO] [stdout] | [INFO] [stdout] 97 | Ed25519Curve::add_points(&self, &self) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bool` [INFO] [stdout] --> src/curve.rs:138:12 [INFO] [stdout] | [INFO] [stdout] 138 | if x.is_even().into() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: consider removing `.into()`: `x.is_even()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/curve.rs:184:13 [INFO] [stdout] | [INFO] [stdout] 184 | scaled_scalar = scaled_scalar >> 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `scaled_scalar >>= 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bool` [INFO] [stdout] --> src/curve.rs:206:16 [INFO] [stdout] | [INFO] [stdout] 206 | if bool::from(x.is_some()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `bool::from()`: `x.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/curve.rs:239:53 [INFO] [stdout] | [INFO] [stdout] 239 | let p = Ed25519Curve::scalar_multiplication(&b, &scalar); [INFO] [stdout] | ^^ help: change this to: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/field.rs:136:6 [INFO] [stdout] | [INFO] [stdout] 136 | impl<'a> Neg for &'a Fe25519 { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 136 - impl<'a> Neg for &'a Fe25519 { [INFO] [stdout] 136 + impl Neg for &Fe25519 { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `bool` [INFO] [stdout] --> src/field.rs:232:26 [INFO] [stdout] | [INFO] [stdout] 232 | let sq_root = if bool::from(neg_not_required) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `bool::from()`: `neg_not_required` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of right operand [INFO] [stdout] --> src/field.rs:306:29 [INFO] [stdout] | [INFO] [stdout] 306 | assert_eq!(&x - &y, &x - &y_ref); [INFO] [stdout] | ^^^^^------ [INFO] [stdout] | | [INFO] [stdout] | help: use the right value directly: `y_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/field.rs:306:34 [INFO] [stdout] | [INFO] [stdout] 306 | assert_eq!(&x - &y, &x - &y_ref); [INFO] [stdout] | ^^^^^^ help: change this to: `y_ref` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 39.87s [INFO] running `Command { std: "docker" "inspect" "fa7cafba92bb5e62b20c5328354e103157e4a77aa2ec733afbec75c6fa76ff3e", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa7cafba92bb5e62b20c5328354e103157e4a77aa2ec733afbec75c6fa76ff3e", kill_on_drop: false }` [INFO] [stdout] fa7cafba92bb5e62b20c5328354e103157e4a77aa2ec733afbec75c6fa76ff3e