[INFO] fetching crate bech32-no_std 0.7.3... [INFO] linting bech32-no_std-0.7.3 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate bech32-no_std 0.7.3 into /workspace/builds/worker-5-tc1/source [INFO] started tweaking crates.io crate bech32-no_std 0.7.3 [INFO] finished tweaking crates.io crate bech32-no_std 0.7.3 [INFO] tweaked toml for crates.io crate bech32-no_std 0.7.3 written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate bech32-no_std 0.7.3 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 84f046b242273f43374ab84816a9b26c6a0b521b2b907a193a4e8bfa10a1a8d3 [INFO] running `Command { std: "docker" "start" "-a" "84f046b242273f43374ab84816a9b26c6a0b521b2b907a193a4e8bfa10a1a8d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "84f046b242273f43374ab84816a9b26c6a0b521b2b907a193a4e8bfa10a1a8d3", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "84f046b242273f43374ab84816a9b26c6a0b521b2b907a193a4e8bfa10a1a8d3", kill_on_drop: false }` [INFO] [stdout] 84f046b242273f43374ab84816a9b26c6a0b521b2b907a193a4e8bfa10a1a8d3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2cd9d8a01de1e8d775467d36a337a40d52610d48784a85447314c1e75b02a269 [INFO] running `Command { std: "docker" "start" "-a" "2cd9d8a01de1e8d775467d36a337a40d52610d48784a85447314c1e75b02a269", kill_on_drop: false }` [INFO] [stderr] Checking bech32-no_std v0.7.3 (/opt/rustwide/workdir) [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | impl Into for u5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 96 ~ impl From for u8 { [INFO] [stdout] 97 ~ fn from(val: u5) -> Self { [INFO] [stdout] 98 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 329 | impl<'f, T: AsRef<[u8]>> CheckBase32> for T { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:362:12 [INFO] [stdout] | [INFO] [stdout] 362 | if b < 33 || b > 126 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(33..=126).contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:366:12 [INFO] [stdout] | [INFO] [stdout] 366 | if b >= b'a' && b <= b'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'a'..=b'z').contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:368:19 [INFO] [stdout] | [INFO] [stdout] 368 | } else if b >= b'A' && b <= b'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'A'..=b'Z').contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:397:37 [INFO] [stdout] | [INFO] [stdout] 397 | let hrp_lower = match check_hrp(&hrp)? { [INFO] [stdout] | ^^^^ help: change this to: `hrp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:446:30 [INFO] [stdout] | [INFO] [stdout] 446 | let mut case = check_hrp(&raw_hrp)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `raw_hrp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:481:16 [INFO] [stdout] | [INFO] [stdout] 481 | if num_value > 31 || num_value < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=31).contains(&num_value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:490:25 [INFO] [stdout] | [INFO] [stdout] 490 | if !verify_checksum(&hrp_lower.as_bytes(), &data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `hrp_lower.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/lib.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | impl Into for u5 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 96 ~ impl From for u8 { [INFO] [stdout] 97 ~ fn from(val: u5) -> Self { [INFO] [stdout] 98 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/lib.rs:329:6 [INFO] [stdout] | [INFO] [stdout] 329 | impl<'f, T: AsRef<[u8]>> CheckBase32> for T { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:362:12 [INFO] [stdout] | [INFO] [stdout] 362 | if b < 33 || b > 126 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: use: `!(33..=126).contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:366:12 [INFO] [stdout] | [INFO] [stdout] 366 | if b >= b'a' && b <= b'z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'a'..=b'z').contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:368:19 [INFO] [stdout] | [INFO] [stdout] 368 | } else if b >= b'A' && b <= b'Z' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: use: `(b'A'..=b'Z').contains(&b)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:397:37 [INFO] [stdout] | [INFO] [stdout] 397 | let hrp_lower = match check_hrp(&hrp)? { [INFO] [stdout] | ^^^^ help: change this to: `hrp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:446:30 [INFO] [stdout] | [INFO] [stdout] 446 | let mut case = check_hrp(&raw_hrp)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `raw_hrp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `!RangeInclusive::contains` implementation [INFO] [stdout] --> src/lib.rs:481:16 [INFO] [stdout] | [INFO] [stdout] 481 | if num_value > 31 || num_value < 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `!(0..=31).contains(&num_value)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:490:25 [INFO] [stdout] | [INFO] [stdout] 490 | if !verify_checksum(&hrp_lower.as_bytes(), &data) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `hrp_lower.as_bytes()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:687:16 [INFO] [stdout] | [INFO] [stdout] 687 | if !decode_result.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `decode_result.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap_err` on `decode_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:691:21 [INFO] [stdout] | [INFO] [stdout] 687 | if !decode_result.is_ok() { [INFO] [stdout] | --------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 691 | decode_result.unwrap_err() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `dec_result` after checking its variant with `is_ok` [INFO] [stdout] --> src/lib.rs:727:34 [INFO] [stdout] | [INFO] [stdout] 726 | if dec_result.is_ok() { [INFO] [stdout] | --------------------- help: try: `if let Ok() = dec_result` [INFO] [stdout] 727 | println!("{:?}", dec_result.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/lib.rs:742:20 [INFO] [stdout] | [INFO] [stdout] 742 | let tests: Vec<(Vec, u32, u32, bool, Vec)> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.40s [INFO] running `Command { std: "docker" "inspect" "2cd9d8a01de1e8d775467d36a337a40d52610d48784a85447314c1e75b02a269", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2cd9d8a01de1e8d775467d36a337a40d52610d48784a85447314c1e75b02a269", kill_on_drop: false }` [INFO] [stdout] 2cd9d8a01de1e8d775467d36a337a40d52610d48784a85447314c1e75b02a269