[INFO] fetching crate backtracking_iterator 0.4.4... [INFO] linting backtracking_iterator-0.4.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate backtracking_iterator 0.4.4 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate backtracking_iterator 0.4.4 [INFO] finished tweaking crates.io crate backtracking_iterator 0.4.4 [INFO] tweaked toml for crates.io crate backtracking_iterator 0.4.4 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate backtracking_iterator 0.4.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 1 package to latest compatible version [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 59aedaa1146baf1ef053ece14762b0accdeb2bac97a26ff6117783e81cc0bca0 [INFO] running `Command { std: "docker" "start" "-a" "59aedaa1146baf1ef053ece14762b0accdeb2bac97a26ff6117783e81cc0bca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "59aedaa1146baf1ef053ece14762b0accdeb2bac97a26ff6117783e81cc0bca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "59aedaa1146baf1ef053ece14762b0accdeb2bac97a26ff6117783e81cc0bca0", kill_on_drop: false }` [INFO] [stdout] 59aedaa1146baf1ef053ece14762b0accdeb2bac97a26ff6117783e81cc0bca0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b0bf06cb7f5c78ebaf92d7aba82de2955134cbdd5538c5c55c3a1b5c5a62dd95 [INFO] running `Command { std: "docker" "start" "-a" "b0bf06cb7f5c78ebaf92d7aba82de2955134cbdd5538c5c55c3a1b5c5a62dd95", kill_on_drop: false }` [INFO] [stderr] Checking backtracking_iterator v0.4.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `BacktrackingState` [INFO] [stdout] --> src/concurrent.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | use super::{BacktrackingState, BacktrackingIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/concurrent.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 26 | static EXPECT_RW: &'static str = "The read-write lock on the history has been poisoned by a thread panic!"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/concurrent.rs:27:23 [INFO] [stdout] | [INFO] [stdout] 27 | static EXPECT_MUTEX: &'static str = "The mutual exclusion lock on the iterator has been poisoned by a thread panic!"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `BacktrackingState` [INFO] [stdout] --> src/concurrent.rs:22:13 [INFO] [stdout] | [INFO] [stdout] 22 | use super::{BacktrackingState, BacktrackingIterator}; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/concurrent.rs:26:20 [INFO] [stdout] | [INFO] [stdout] 26 | static EXPECT_RW: &'static str = "The read-write lock on the history has been poisoned by a thread panic!"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: statics have by default a `'static` lifetime [INFO] [stdout] --> src/concurrent.rs:27:23 [INFO] [stdout] | [INFO] [stdout] 27 | static EXPECT_MUTEX: &'static str = "The mutual exclusion lock on the iterator has been poisoned by a thread panic!"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Backtracking` and `Progressing` [INFO] [stdout] --> src/concurrent.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | use crate::{Backtracking, Progressing}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Backtracking` and `Progressing` [INFO] [stdout] --> src/concurrent.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | use crate::{Backtracking, Progressing}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary trailing semicolon [INFO] [stdout] --> src/concurrent.rs:209:26 [INFO] [stdout] | [INFO] [stdout] 209 | struct Uncloneable {}; [INFO] [stdout] | ^ help: remove this semicolon [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(redundant_semicolons)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Backtracking` and `Progressing` [INFO] [stdout] --> src/concurrent.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | use crate::{Backtracking, Progressing}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused imports: `Backtracking` and `Progressing` [INFO] [stdout] --> src/concurrent.rs:140:17 [INFO] [stdout] | [INFO] [stdout] 140 | use crate::{Backtracking, Progressing}; [INFO] [stdout] | ^^^^^^^^^^^^ ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:34:7 [INFO] [stdout] | [INFO] [stdout] 34 | /// were set to the value of `get_oldest_point()`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// were set to the value of `get_oldest_point()`. [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:36:7 [INFO] [stdout] | [INFO] [stdout] 36 | /// at least up to the element corresponding last-most `RefPoint` obtainable from [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 36 | /// at least up to the element corresponding last-most `RefPoint` obtainable from [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | /// the `BacktrackingIterator` - the slice may or may not contain more elements. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 37 | /// the `BacktrackingIterator` - the slice may or may not contain more elements. [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/copying.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | backtracker: &backtracker.recorder, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `backtracker.recorder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/referencing.rs:144:6 [INFO] [stdout] | [INFO] [stdout] 144 | impl<'history, 'record, Iter> Iterator for ReferencingWalkback<'record, Iter> [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:83:7 [INFO] [stdout] | [INFO] [stdout] 83 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/concurrent.rs:106:1 [INFO] [stdout] | [INFO] [stdout] 106 | / //// COPYING VERSION [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | impl From for ConcurrentCopyingBacktrackingIterator where Iter: Iterator, Iter::Item: Clone { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 106 - //// COPYING VERSION [INFO] [stdout] 107 - [INFO] [stdout] 106 + /// COPYING VERSION [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:151:7 [INFO] [stdout] | [INFO] [stdout] 151 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:34:7 [INFO] [stdout] | [INFO] [stdout] 34 | /// were set to the value of `get_oldest_point()`. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] = note: `#[warn(clippy::doc_lazy_continuation)]` on by default [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 34 | /// were set to the value of `get_oldest_point()`. [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:36:7 [INFO] [stdout] | [INFO] [stdout] 36 | /// at least up to the element corresponding last-most `RefPoint` obtainable from [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 36 | /// at least up to the element corresponding last-most `RefPoint` obtainable from [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item without indentation [INFO] [stdout] --> src/sliceable.rs:37:7 [INFO] [stdout] | [INFO] [stdout] 37 | /// the `BacktrackingIterator` - the slice may or may not contain more elements. [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: if this is supposed to be its own paragraph, add a blank line [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_lazy_continuation [INFO] [stdout] help: indent this line [INFO] [stdout] | [INFO] [stdout] 37 | /// the `BacktrackingIterator` - the slice may or may not contain more elements. [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/copying.rs:117:20 [INFO] [stdout] | [INFO] [stdout] 117 | backtracker: &backtracker.recorder, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: change this to: `backtracker.recorder` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the impl [INFO] [stdout] --> src/referencing.rs:144:6 [INFO] [stdout] | [INFO] [stdout] 144 | impl<'history, 'record, Iter> Iterator for ReferencingWalkback<'record, Iter> [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:83:7 [INFO] [stdout] | [INFO] [stdout] 83 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this item has comments with 4 forward slashes (`////`). These look like doc comments, but they aren't [INFO] [stdout] --> src/concurrent.rs:106:1 [INFO] [stdout] | [INFO] [stdout] 106 | / //// COPYING VERSION [INFO] [stdout] 107 | | [INFO] [stdout] 108 | | impl From for ConcurrentCopyingBacktrackingIterator where Iter: Iterator, Iter::Item: Clone { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#four_forward_slashes [INFO] [stdout] = note: `#[warn(clippy::four_forward_slashes)]` on by default [INFO] [stdout] help: make this a doc comment by removing one `/` [INFO] [stdout] | [INFO] [stdout] 106 - //// COPYING VERSION [INFO] [stdout] 107 - [INFO] [stdout] 106 + /// COPYING VERSION [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/concurrent.rs:151:7 [INFO] [stdout] | [INFO] [stdout] 151 | self.position = self.position + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.position += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:95:15 [INFO] [stdout] | [INFO] [stdout] 95 | assert!(!bt_iter.next().is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `bt_iter.next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "b0bf06cb7f5c78ebaf92d7aba82de2955134cbdd5538c5c55c3a1b5c5a62dd95", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b0bf06cb7f5c78ebaf92d7aba82de2955134cbdd5538c5c55c3a1b5c5a62dd95", kill_on_drop: false }` [INFO] [stdout] b0bf06cb7f5c78ebaf92d7aba82de2955134cbdd5538c5c55c3a1b5c5a62dd95