[INFO] fetching crate axonml-cli 0.4.1... [INFO] linting axonml-cli-0.4.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate axonml-cli 0.4.1 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate axonml-cli 0.4.1 [INFO] removed 0 missing tests [INFO] finished tweaking crates.io crate axonml-cli 0.4.1 [INFO] tweaked toml for crates.io crate axonml-cli 0.4.1 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate axonml-cli 0.4.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate axonml-cli 0.4.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded terminal_size v0.4.3 [INFO] [stderr] Downloaded axonml-data v0.4.1 [INFO] [stderr] Downloaded zune-jpeg v0.5.12 [INFO] [stderr] Downloaded assert_cmd v2.1.2 [INFO] [stderr] Downloaded axonml-optim v0.4.1 [INFO] [stderr] Downloaded prost-derive v0.14.3 [INFO] [stderr] Downloaded prost-types v0.14.3 [INFO] [stderr] Downloaded prost-build v0.14.3 [INFO] [stderr] Downloaded axonml-tui v0.4.1 [INFO] [stderr] Downloaded axonml-nn v0.4.1 [INFO] [stderr] Downloaded axonml-core v0.4.1 [INFO] [stderr] Downloaded prost v0.14.3 [INFO] [stderr] Downloaded axonml-onnx v0.4.1 [INFO] [stderr] Downloaded axonml-serialize v0.4.1 [INFO] [stderr] Downloaded axonml-autograd v0.4.1 [INFO] [stderr] Downloaded axonml-tensor v0.4.1 [INFO] [stderr] Downloaded axonml-vision v0.4.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3691061aa7c44c8260d5ad79dfaae2072d922a781d0595381f042d0b299964b6 [INFO] running `Command { std: "docker" "start" "-a" "3691061aa7c44c8260d5ad79dfaae2072d922a781d0595381f042d0b299964b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3691061aa7c44c8260d5ad79dfaae2072d922a781d0595381f042d0b299964b6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3691061aa7c44c8260d5ad79dfaae2072d922a781d0595381f042d0b299964b6", kill_on_drop: false }` [INFO] [stdout] 3691061aa7c44c8260d5ad79dfaae2072d922a781d0595381f042d0b299964b6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d282a5833a4be890212ba9706d7fa3bd42a38975bd79edfc3b96dcc27d6f7552 [INFO] running `Command { std: "docker" "start" "-a" "d282a5833a4be890212ba9706d7fa3bd42a38975bd79edfc3b96dcc27d6f7552", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.180 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Compiling bytemuck_derive v1.10.2 [INFO] [stderr] Compiling zerocopy-derive v0.8.33 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking yoke v0.8.1 [INFO] [stderr] Checking zerovec v0.11.5 [INFO] [stderr] Compiling find-msvc-tools v0.1.8 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Compiling cc v1.2.54 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Checking mio v1.1.1 [INFO] [stderr] Checking bytemuck v1.24.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking getrandom v0.2.17 [INFO] [stderr] Checking zerocopy v0.8.33 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking socket2 v0.6.2 [INFO] [stderr] Checking sysinfo v0.32.1 [INFO] [stderr] Compiling rustix v1.1.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking tinystr v0.8.2 [INFO] [stderr] Checking http v1.4.0 [INFO] [stderr] Compiling equator-macro v0.4.2 [INFO] [stderr] Checking linux-raw-sys v0.11.0 [INFO] [stderr] Checking tokio v1.49.0 [INFO] [stderr] Checking unicode-width v0.2.0 [INFO] [stderr] Compiling darling_core v0.23.0 [INFO] [stderr] Checking icu_locale_core v2.1.1 [INFO] [stderr] Checking potential_utf v0.1.4 [INFO] [stderr] Checking zerotrie v0.2.3 [INFO] [stderr] Checking equator v0.4.2 [INFO] [stderr] Compiling openssl-sys v0.9.111 [INFO] [stderr] Compiling profiling-procmacros v1.0.17 [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Compiling zmij v1.0.17 [INFO] [stderr] Checking strength_reduce v0.2.4 [INFO] [stderr] Checking transpose v0.2.3 [INFO] [stderr] Checking profiling v1.0.17 [INFO] [stderr] Checking aligned-vec v0.6.4 [INFO] [stderr] Checking icu_collections v2.1.1 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking icu_provider v2.1.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Checking primal-check v0.3.4 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling instability v0.3.11 [INFO] [stderr] Compiling openssl v0.10.75 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Checking rustfft v6.4.1 [INFO] [stderr] Checking axonml-core v0.4.1 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking v_frame v0.3.9 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Checking axonml-tensor v0.4.1 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Checking as-slice v0.2.1 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling av-scenechange v0.14.1 [INFO] [stderr] Checking axonml-autograd v0.4.1 [INFO] [stderr] Compiling built v0.8.0 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Compiling darling_macro v0.23.0 [INFO] [stderr] Checking deranged v0.5.5 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Compiling darling v0.23.0 [INFO] [stderr] Compiling rav1e v0.8.1 [INFO] [stderr] Checking aligned v0.4.3 [INFO] [stderr] Checking signal-hook-mio v0.2.5 [INFO] [stderr] Checking icu_normalizer v2.1.1 [INFO] [stderr] Checking icu_properties v2.1.2 [INFO] [stderr] Checking serde_json v1.0.149 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Compiling naga v23.1.0 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Compiling arg_enum_proc_macro v0.3.4 [INFO] [stderr] Checking tokio-util v0.7.18 [INFO] [stderr] Compiling khronos-egl v6.0.0 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking bit-vec v0.8.0 [INFO] [stderr] Checking y4m v0.8.0 [INFO] [stderr] Compiling pastey v0.1.1 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Compiling ash v0.38.0+1.3.281 [INFO] [stderr] Checking h2 v0.4.13 [INFO] [stderr] Compiling unicase v2.9.0 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking time v0.3.46 [INFO] [stderr] Compiling mime_guess v2.0.5 [INFO] [stderr] Checking codespan-reporting v0.11.1 [INFO] [stderr] Checking bit-set v0.8.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Checking bitstream-io v4.9.0 [INFO] [stderr] Checking flate2 v1.1.8 [INFO] [stderr] Checking axonml-nn v0.4.1 [INFO] [stderr] Compiling wgpu-hal v23.0.1 [INFO] [stderr] Checking sync_wrapper v1.0.2 [INFO] [stderr] Checking maybe-rayon v0.1.1 [INFO] [stderr] Checking gpu-alloc-types v0.3.0 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Checking spirv v0.3.0+sdk-1.3.268.0 [INFO] [stderr] Compiling num-derive v0.4.2 [INFO] [stderr] Compiling fax_derive v0.2.0 [INFO] [stderr] Checking gpu-descriptor-types v0.2.0 [INFO] [stderr] Compiling simd_helpers v0.1.0 [INFO] [stderr] Checking hexf-parse v0.2.1 [INFO] [stderr] Checking new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling noop_proc_macro v0.3.0 [INFO] [stderr] Checking imgref v1.12.0 [INFO] [stderr] Checking unicode-xid v0.2.6 [INFO] [stderr] Checking zune-core v0.4.12 [INFO] [stderr] Compiling rustix v0.38.44 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Checking weezl v0.1.12 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking zune-jpeg v0.4.21 [INFO] [stderr] Checking tower v0.5.3 [INFO] [stderr] Checking fax v0.2.6 [INFO] [stderr] Checking loop9 v0.1.5 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking regex-automata v0.4.13 [INFO] [stderr] Checking av1-grain v0.2.5 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking gpu-descriptor v0.3.2 [INFO] [stderr] Checking gpu-alloc v0.6.0 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking hyper v1.8.1 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking hyper-util v0.1.19 [INFO] [stderr] Checking zune-inflate v0.2.54 [INFO] [stderr] Checking avif-serialize v0.8.8 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling wgpu-core v23.0.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking pxfm v0.1.27 [INFO] [stderr] Checking wgpu-types v23.0.0 [INFO] [stderr] Checking linux-raw-sys v0.4.15 [INFO] [stderr] Compiling portable-atomic v1.13.0 [INFO] [stderr] Checking renderdoc-sys v1.1.0 [INFO] [stderr] Checking bit_field v0.10.3 [INFO] [stderr] Checking glow v0.14.2 [INFO] [stderr] Checking zune-core v0.5.1 [INFO] [stderr] Checking rgb v0.8.52 [INFO] [stderr] Checking lebe v0.5.3 [INFO] [stderr] Checking zune-jpeg v0.5.12 [INFO] [stderr] Checking exr v1.74.0 [INFO] [stderr] Checking image-webp v0.2.4 [INFO] [stderr] Checking tower-http v0.6.8 [INFO] [stderr] Checking moxcms v0.7.11 [INFO] [stderr] Checking gif v0.14.1 [INFO] [stderr] Checking axonml-serialize v0.4.1 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Compiling prost-derive v0.14.3 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Checking png v0.18.0 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking tiff v0.10.3 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking getrandom v0.3.4 [INFO] [stderr] Checking url v2.5.8 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking qoi v0.4.1 [INFO] [stderr] Compiling wgpu v23.0.1 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking clap_lex v0.7.7 [INFO] [stderr] Checking chrono v0.4.43 [INFO] [stderr] Checking reqwest v0.12.28 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking clap_builder v4.5.54 [INFO] [stderr] Checking prost v0.14.3 [INFO] [stderr] Checking ravif v0.12.0 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking regex v1.12.2 [INFO] [stderr] Checking axonml-optim v0.4.1 [INFO] [stderr] Checking axonml-data v0.4.1 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Compiling clap_derive v4.5.49 [INFO] [stderr] Checking float-cmp v0.10.0 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking normalize-line-endings v0.3.0 [INFO] [stderr] Checking difflib v0.4.0 [INFO] [stderr] Compiling assert_cmd v2.1.2 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking colored v2.2.0 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking tempfile v3.24.0 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking axonml-tui v0.4.1 [INFO] [stderr] Checking axonml-onnx v0.4.1 [INFO] [stderr] Checking uuid v1.20.0 [INFO] [stderr] Checking bstr v1.12.1 [INFO] [stderr] Checking wait-timeout v0.2.1 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking pollster v0.4.0 [INFO] [stderr] Checking image v0.25.9 [INFO] [stderr] Checking clap v4.5.54 [INFO] [stderr] Checking axonml-vision v0.4.1 [INFO] [stderr] Checking axonml-cli v0.4.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated associated function `assert_cmd::Command::cargo_bin`: incompatible with a custom cargo build-dir, see instead `cargo::cargo_bin_cmd!` [INFO] [stdout] --> tests/cli_integration_test.rs:20:14 [INFO] [stdout] | [INFO] [stdout] 20 | Command::cargo_bin("axonml").unwrap() [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NotConnected` is never constructed [INFO] [stdout] --> src/api_client.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum ApiError { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ApiError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `refresh_token` and `expires_in` are never read [INFO] [stdout] --> src/api_client.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct LoginResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 41 | pub access_token: Option, [INFO] [stdout] 42 | pub refresh_token: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 43 | pub expires_in: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoginResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_authenticated`, `create_training_run`, `update_training_metrics`, and `upload_model` are never used [INFO] [stdout] --> src/api_client.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 110 | impl ApiClient { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 182 | pub fn is_authenticated(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 268 | pub async fn create_training_run( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | pub async fn update_training_metrics( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 346 | pub async fn upload_model( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `should_sync` is never used [INFO] [stdout] --> src/api_client.rs:404:14 [INFO] [stdout] | [INFO] [stdout] 404 | pub async fn should_sync() -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_empty` is never used [INFO] [stdout] --> src/commands/report.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl TrainingHistory { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `NotConnected` is never constructed [INFO] [stdout] --> src/api_client.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum ApiError { [INFO] [stdout] | -------- variant in this enum [INFO] [stdout] ... [INFO] [stdout] 24 | NotConnected, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `ApiError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `refresh_token` and `expires_in` are never read [INFO] [stdout] --> src/api_client.rs:42:9 [INFO] [stdout] | [INFO] [stdout] 40 | pub struct LoginResponse { [INFO] [stdout] | ------------- fields in this struct [INFO] [stdout] 41 | pub access_token: Option, [INFO] [stdout] 42 | pub refresh_token: Option, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 43 | pub expires_in: Option, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `LoginResponse` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `is_authenticated`, `create_training_run`, `update_training_metrics`, and `upload_model` are never used [INFO] [stdout] --> src/api_client.rs:182:12 [INFO] [stdout] | [INFO] [stdout] 110 | impl ApiClient { [INFO] [stdout] | -------------- methods in this implementation [INFO] [stdout] ... [INFO] [stdout] 182 | pub fn is_authenticated(&self) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 268 | pub async fn create_training_run( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 297 | pub async fn update_training_metrics( [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 346 | pub async fn upload_model( [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `should_sync` is never used [INFO] [stdout] --> src/api_client.rs:404:14 [INFO] [stdout] | [INFO] [stdout] 404 | pub async fn should_sync() -> bool { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `is_empty` is never used [INFO] [stdout] --> src/commands/report.rs:157:12 [INFO] [stdout] | [INFO] [stdout] 83 | impl TrainingHistory { [INFO] [stdout] | -------------------- method in this implementation [INFO] [stdout] ... [INFO] [stdout] 157 | pub fn is_empty(&self) -> bool { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/analyze.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | layer_analysis.sort_by(|a, b| b.num_parameters.cmp(&a.num_parameters)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 195 - layer_analysis.sort_by(|a, b| b.num_parameters.cmp(&a.num_parameters)); [INFO] [stdout] 195 + layer_analysis.sort_by_key(|b| std::cmp::Reverse(b.num_parameters)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/analyze.rs:1003:16 [INFO] [stdout] | [INFO] [stdout] 1003 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | #![warn(clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::map_unwrap_or)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 1003 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 1003 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/convert.rs:158:22 [INFO] [stdout] | [INFO] [stdout] 158 | let input_size = std::fs::metadata(input_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 158 - let input_size = std::fs::metadata(input_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 158 + let input_size = std::fs::metadata(input_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/convert.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | let output_size = std::fs::metadata(output_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 187 - let output_size = std::fs::metadata(output_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 187 + let output_size = std::fs::metadata(output_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/convert.rs:285:34 [INFO] [stdout] | [INFO] [stdout] 285 | exporter.add_initializer(&name, &tensor); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on a `Result` value [INFO] [stdout] --> src/commands/dashboard.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / std::env::var("AXONML_HOME") [INFO] [stdout] 26 | | .map(PathBuf::from) [INFO] [stdout] 27 | | .unwrap_or_else(|_| { [INFO] [stdout] 28 | | dirs::data_dir() [INFO] [stdout] 29 | | .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 30 | | .join("axonml") [INFO] [stdout] 31 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ std::env::var("AXONML_HOME").map_or_else(|_| { [INFO] [stdout] 26 + dirs::data_dir() [INFO] [stdout] 27 + .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 28 + .join("axonml") [INFO] [stdout] 29 + }, PathBuf::from) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on an `Option` value [INFO] [stdout] --> src/commands/dashboard.rs:515:26 [INFO] [stdout] | [INFO] [stdout] 515 | let server_running = server_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_some_and()` instead [INFO] [stdout] | [INFO] [stdout] 515 - let server_running = server_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] 515 + let server_running = server_pid.is_some_and(is_process_running); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on an `Option` value [INFO] [stdout] --> src/commands/dashboard.rs:516:29 [INFO] [stdout] | [INFO] [stdout] 516 | let dashboard_running = dashboard_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_some_and()` instead [INFO] [stdout] | [INFO] [stdout] 516 - let dashboard_running = dashboard_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] 516 + let dashboard_running = dashboard_pid.is_some_and(is_process_running); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/dashboard.rs:631:60 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_for_method_calls)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/commands/dashboard.rs:631:49 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/commands/dashboard.rs:631:34 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/data.rs:444:24 [INFO] [stdout] | [INFO] [stdout] 444 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 444 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 444 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/data.rs:656:16 [INFO] [stdout] | [INFO] [stdout] 656 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 656 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 656 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:322:23 [INFO] [stdout] | [INFO] [stdout] 322 | ds.id.replace("-", "_").to_uppercase(), [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] = note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:323:23 [INFO] [stdout] | [INFO] [stdout] 323 | ds.id.replace("-", "_").to_uppercase(), [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:324:23 [INFO] [stdout] | [INFO] [stdout] 324 | ds.id.replace("-", "_").to_uppercase() [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/dataset.rs:377:22 [INFO] [stdout] | [INFO] [stdout] 377 | let output_dir = output [INFO] [stdout] | ______________________^ [INFO] [stdout] 378 | | .map(PathBuf::from) [INFO] [stdout] 379 | | .unwrap_or_else(|| PathBuf::from("./data")); [INFO] [stdout] | |___________________________________________________^ help: try: `output.map_or_else(|| PathBuf::from("./data"), PathBuf::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:391:84 [INFO] [stdout] | [INFO] [stdout] 391 | let code_path = output_dir.join(format!("{}_loader.rs", dataset_id.replace("-", "_"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:411:37 [INFO] [stdout] | [INFO] [stdout] 411 | let struct_name = ds.id.replace("-", "_").to_uppercase(); [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/export.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | let input_size = std::fs::metadata(model_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 131 - let input_size = std::fs::metadata(model_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 131 + let input_size = std::fs::metadata(model_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/export.rs:150:27 [INFO] [stdout] | [INFO] [stdout] 150 | let output_size = std::fs::metadata(&args.output) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 151 | | .map(|m| m.len()) [INFO] [stdout] 152 | | .unwrap_or(0); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 151 - .map(|m| m.len()) [INFO] [stdout] 152 - .unwrap_or(0); [INFO] [stdout] 151 + .map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/export.rs:222:34 [INFO] [stdout] | [INFO] [stdout] 222 | exporter.add_initializer(&name, &tensor); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/commands/hub.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] = note: `#[warn(clippy::manual_string_new)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else { if .. }` block can be collapsed [INFO] [stdout] --> src/commands/hub.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 329 | | if cache.exists() { [INFO] [stdout] 330 | | let count = fs::read_dir(&cache) [INFO] [stdout] 331 | | .map_err(|e| e.to_string())? [INFO] [stdout] ... | [INFO] [stdout] 340 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_else_if)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 328 ~ } else if cache.exists() { [INFO] [stdout] 329 + let count = fs::read_dir(&cache) [INFO] [stdout] 330 + .map_err(|e| e.to_string())? [INFO] [stdout] 331 + .filter(|e| e.is_ok()) [INFO] [stdout] 332 + .count(); [INFO] [stdout] 333 + [INFO] [stdout] 334 + fs::remove_dir_all(&cache).map_err(|e| e.to_string())?; [INFO] [stdout] 335 ~ println!("{} Cleared {} cached model(s)", "✓".green(), count); [INFO] [stdout] 336 + } else { [INFO] [stdout] 337 + println!("Cache is empty."); [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/hub.rs:332:25 [INFO] [stdout] | [INFO] [stdout] 332 | .filter(|e| e.is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::is_ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter` for `is_ok` on iterator over `Result`s [INFO] [stdout] --> src/commands/hub.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 332 | .filter(|e| e.is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_filter_is_ok [INFO] [stdout] = note: `#[warn(clippy::iter_filter_is_ok)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/inspect.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | let file_size = std::fs::metadata(path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 72 - let file_size = std::fs::metadata(path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 72 + let file_size = std::fs::metadata(path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/commands/inspect.rs:89:27 [INFO] [stdout] | [INFO] [stdout] 89 | let mut layer_params: std::collections::BTreeMap, u64, bool)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/inspect.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 118 | let layer_type = infer_layer_type(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/inspect.rs:121:56 [INFO] [stdout] | [INFO] [stdout] 121 | let (input_shape, output_shape) = infer_shapes(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `to_string` on `&&str` [INFO] [stdout] --> src/commands/inspect.rs:143:28 [INFO] [stdout] | [INFO] [stdout] 143 | metadata.push((key.to_string(), value.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*key).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: `&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string [INFO] [stdout] = note: `#[warn(clippy::inefficient_to_string)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/kaggle.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | let output_dir = output [INFO] [stdout] | ______________________^ [INFO] [stdout] 273 | | .map(PathBuf::from) [INFO] [stdout] 274 | | .unwrap_or_else(|| PathBuf::from("./data")); [INFO] [stdout] | |___________________________________________________^ help: try: `output.map_or_else(|| PathBuf::from("./data"), PathBuf::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/load.rs:433:24 [INFO] [stdout] | [INFO] [stdout] 433 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 433 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 433 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:93:67 [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(epoch) = record.get("epoch").and_then(|v| v.as_u64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:96:71 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(loss) = record.get("train_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:99:69 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(loss) = record.get("val_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:102:74 [INFO] [stdout] | [INFO] [stdout] 102 | if let Some(acc) = record.get("train_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:105:72 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some(acc) = record.get("val_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:108:72 [INFO] [stdout] | [INFO] [stdout] 108 | if let Some(lr) = record.get("learning_rate").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_by_key` [INFO] [stdout] --> src/commands/analyze.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | layer_analysis.sort_by(|a, b| b.num_parameters.cmp(&a.num_parameters)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:40:9 [INFO] [stdout] | [INFO] [stdout] 40 | #![warn(clippy::all)] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 195 - layer_analysis.sort_by(|a, b| b.num_parameters.cmp(&a.num_parameters)); [INFO] [stdout] 195 + layer_analysis.sort_by_key(|b| std::cmp::Reverse(b.num_parameters)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:116:71 [INFO] [stdout] | [INFO] [stdout] 116 | if let Some(epoch) = record.get("epoch").and_then(|v| v.as_u64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:119:75 [INFO] [stdout] | [INFO] [stdout] 119 | if let Some(loss) = record.get("train_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:121:76 [INFO] [stdout] | [INFO] [stdout] 121 | } else if let Some(loss) = record.get("loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:124:73 [INFO] [stdout] | [INFO] [stdout] 124 | if let Some(loss) = record.get("val_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:127:78 [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(acc) = record.get("train_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:129:79 [INFO] [stdout] | [INFO] [stdout] 129 | } else if let Some(acc) = record.get("accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:132:76 [INFO] [stdout] | [INFO] [stdout] 132 | if let Some(acc) = record.get("val_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:135:76 [INFO] [stdout] | [INFO] [stdout] 135 | if let Some(lr) = record.get("learning_rate").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:137:72 [INFO] [stdout] | [INFO] [stdout] 137 | } else if let Some(lr) = record.get("lr").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/analyze.rs:1003:16 [INFO] [stdout] | [INFO] [stdout] 1003 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] note: the lint level is defined here [INFO] [stdout] --> src/main.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | #![warn(clippy::pedantic)] [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(clippy::map_unwrap_or)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 1003 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 1003 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/commands/report.rs:1369:39 [INFO] [stdout] | [INFO] [stdout] 1369 | let train_max = train_loss.iter().cloned().fold(0.0f64, f64::max); [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] = note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/commands/report.rs:1370:35 [INFO] [stdout] | [INFO] [stdout] 1370 | let val_max = val_loss.iter().cloned().fold(0.0f64, f64::max); [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/resume.rs:331:1 [INFO] [stdout] | [INFO] [stdout] 331 | / fn run_resumed_training( [INFO] [stdout] 332 | | checkpoint_info: &CheckpointInfo, [INFO] [stdout] 333 | | start_epoch: usize, [INFO] [stdout] 334 | | additional_epochs: usize, [INFO] [stdout] ... | [INFO] [stdout] 339 | | batch_size: usize, [INFO] [stdout] 340 | | ) -> Result, Box> { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/resume.rs:356:27 [INFO] [stdout] | [INFO] [stdout] 356 | let detected_format = format.map(String::from).unwrap_or_else(|| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 357 | | ResumeDataset::detect_format(&data_path_buf).unwrap_or_else(|| "mnist".to_string()) [INFO] [stdout] 358 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 356 ~ let detected_format = format.map_or_else(|| { [INFO] [stdout] 357 + ResumeDataset::detect_format(&data_path_buf).unwrap_or_else(|| "mnist".to_string()) [INFO] [stdout] 358 ~ }, String::from); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/convert.rs:158:22 [INFO] [stdout] | [INFO] [stdout] 158 | let input_size = std::fs::metadata(input_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 158 - let input_size = std::fs::metadata(input_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 158 + let input_size = std::fs::metadata(input_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/convert.rs:187:31 [INFO] [stdout] | [INFO] [stdout] 187 | let output_size = std::fs::metadata(output_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 187 - let output_size = std::fs::metadata(output_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 187 + let output_size = std::fs::metadata(output_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/convert.rs:285:34 [INFO] [stdout] | [INFO] [stdout] 285 | exporter.add_initializer(&name, &tensor); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on a `Result` value [INFO] [stdout] --> src/commands/dashboard.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | / std::env::var("AXONML_HOME") [INFO] [stdout] 26 | | .map(PathBuf::from) [INFO] [stdout] 27 | | .unwrap_or_else(|_| { [INFO] [stdout] 28 | | dirs::data_dir() [INFO] [stdout] 29 | | .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 30 | | .join("axonml") [INFO] [stdout] 31 | | }) [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 25 ~ std::env::var("AXONML_HOME").map_or_else(|_| { [INFO] [stdout] 26 + dirs::data_dir() [INFO] [stdout] 27 + .unwrap_or_else(|| PathBuf::from(".")) [INFO] [stdout] 28 + .join("axonml") [INFO] [stdout] 29 + }, PathBuf::from) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/wandb_client.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / WandbConfig::load() [INFO] [stdout] 323 | | .map(|c| c.is_configured()) [INFO] [stdout] 324 | | .unwrap_or(false) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 323 - .map(|c| c.is_configured()) [INFO] [stdout] 324 - .unwrap_or(false) [INFO] [stdout] 323 + .is_ok_and(|c| c.is_configured()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on an `Option` value [INFO] [stdout] --> src/commands/dashboard.rs:515:26 [INFO] [stdout] | [INFO] [stdout] 515 | let server_running = server_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_some_and()` instead [INFO] [stdout] | [INFO] [stdout] 515 - let server_running = server_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] 515 + let server_running = server_pid.is_some_and(is_process_running); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on an `Option` value [INFO] [stdout] --> src/commands/dashboard.rs:516:29 [INFO] [stdout] | [INFO] [stdout] 516 | let dashboard_running = dashboard_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_some_and()` instead [INFO] [stdout] | [INFO] [stdout] 516 - let dashboard_running = dashboard_pid.map(is_process_running).unwrap_or(false); [INFO] [stdout] 516 + let dashboard_running = dashboard_pid.is_some_and(is_process_running); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/dashboard.rs:631:60 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] = note: `#[warn(clippy::redundant_closure_for_method_calls)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter_map()` will run forever if the iterator repeatedly produces an `Err` [INFO] [stdout] --> src/commands/dashboard.rs:631:49 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `map_while(Result::ok)` [INFO] [stdout] | [INFO] [stdout] note: this expression returning a `std::io::Lines` may produce an infinite number of `Err` in case of a read error [INFO] [stdout] --> src/commands/dashboard.rs:631:34 [INFO] [stdout] | [INFO] [stdout] 631 | let all_lines: Vec = reader.lines().filter_map(|l| l.ok()).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#lines_filter_map_ok [INFO] [stdout] = note: `#[warn(clippy::lines_filter_map_ok)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:173:56 [INFO] [stdout] | [INFO] [stdout] 173 | commands::kaggle::execute_status().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:184:54 [INFO] [stdout] | [INFO] [stdout] 184 | commands::kaggle::execute_list().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:193:70 [INFO] [stdout] | [INFO] [stdout] 193 | HubSubcommand::List => commands::hub::execute_list().map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:195:67 [INFO] [stdout] | [INFO] [stdout] 195 | commands::hub::execute_info(&info_args.model).map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:199:26 [INFO] [stdout] | [INFO] [stdout] 199 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 202 | commands::hub::execute_cached().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:206:26 [INFO] [stdout] | [INFO] [stdout] 206 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:217:26 [INFO] [stdout] | [INFO] [stdout] 217 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | .map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | .map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 229 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:232:58 [INFO] [stdout] | [INFO] [stdout] 232 | commands::dataset::execute_sources().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `async` for function with no await statements [INFO] [stdout] --> src/commands/sync.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | / pub async fn logout() -> CliResult<()> { [INFO] [stdout] 76 | | match ApiClient::logout() { [INFO] [stdout] 77 | | Ok(()) => { [INFO] [stdout] 78 | | println!("{} Logged out successfully", "✓".green().bold()); [INFO] [stdout] ... | [INFO] [stdout] 85 | | Ok(()) [INFO] [stdout] 86 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the `async` from this function [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async [INFO] [stdout] = note: `#[warn(clippy::unused_async)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/data.rs:444:24 [INFO] [stdout] | [INFO] [stdout] 444 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 444 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 444 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/data.rs:656:16 [INFO] [stdout] | [INFO] [stdout] 656 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 656 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 656 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:322:23 [INFO] [stdout] | [INFO] [stdout] 322 | ds.id.replace("-", "_").to_uppercase(), [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] = note: `#[warn(clippy::single_char_pattern)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:323:23 [INFO] [stdout] | [INFO] [stdout] 323 | ds.id.replace("-", "_").to_uppercase(), [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:324:23 [INFO] [stdout] | [INFO] [stdout] 324 | ds.id.replace("-", "_").to_uppercase() [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/dataset.rs:377:22 [INFO] [stdout] | [INFO] [stdout] 377 | let output_dir = output [INFO] [stdout] | ______________________^ [INFO] [stdout] 378 | | .map(PathBuf::from) [INFO] [stdout] 379 | | .unwrap_or_else(|| PathBuf::from("./data")); [INFO] [stdout] | |___________________________________________________^ help: try: `output.map_or_else(|| PathBuf::from("./data"), PathBuf::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:391:84 [INFO] [stdout] | [INFO] [stdout] 391 | let code_path = output_dir.join(format!("{}_loader.rs", dataset_id.replace("-", "_"))); [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: single-character string constant used as pattern [INFO] [stdout] --> src/commands/dataset.rs:411:37 [INFO] [stdout] | [INFO] [stdout] 411 | let struct_name = ds.id.replace("-", "_").to_uppercase(); [INFO] [stdout] | ^^^ help: consider using a `char`: `'-'` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/export.rs:131:22 [INFO] [stdout] | [INFO] [stdout] 131 | let input_size = std::fs::metadata(model_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 131 - let input_size = std::fs::metadata(model_path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 131 + let input_size = std::fs::metadata(model_path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/export.rs:150:27 [INFO] [stdout] | [INFO] [stdout] 150 | let output_size = std::fs::metadata(&args.output) [INFO] [stdout] | ___________________________^ [INFO] [stdout] 151 | | .map(|m| m.len()) [INFO] [stdout] 152 | | .unwrap_or(0); [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 151 - .map(|m| m.len()) [INFO] [stdout] 152 - .unwrap_or(0); [INFO] [stdout] 151 + .map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/export.rs:222:34 [INFO] [stdout] | [INFO] [stdout] 222 | exporter.add_initializer(&name, &tensor); [INFO] [stdout] | ^^^^^ help: change this to: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty String is being created manually [INFO] [stdout] --> src/commands/hub.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | "".to_string() [INFO] [stdout] | ^^^^^^^^^^^^^^ help: consider using: `String::new()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_string_new [INFO] [stdout] = note: `#[warn(clippy::manual_string_new)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `else { if .. }` block can be collapsed [INFO] [stdout] --> src/commands/hub.rs:328:12 [INFO] [stdout] | [INFO] [stdout] 328 | } else { [INFO] [stdout] | ____________^ [INFO] [stdout] 329 | | if cache.exists() { [INFO] [stdout] 330 | | let count = fs::read_dir(&cache) [INFO] [stdout] 331 | | .map_err(|e| e.to_string())? [INFO] [stdout] ... | [INFO] [stdout] 340 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_else_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_else_if)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 328 ~ } else if cache.exists() { [INFO] [stdout] 329 + let count = fs::read_dir(&cache) [INFO] [stdout] 330 + .map_err(|e| e.to_string())? [INFO] [stdout] 331 + .filter(|e| e.is_ok()) [INFO] [stdout] 332 + .count(); [INFO] [stdout] 333 + [INFO] [stdout] 334 + fs::remove_dir_all(&cache).map_err(|e| e.to_string())?; [INFO] [stdout] 335 ~ println!("{} Cleared {} cached model(s)", "✓".green(), count); [INFO] [stdout] 336 + } else { [INFO] [stdout] 337 + println!("Cache is empty."); [INFO] [stdout] 338 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/hub.rs:332:25 [INFO] [stdout] | [INFO] [stdout] 332 | .filter(|e| e.is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^ help: replace the closure with the method itself: `std::result::Result::is_ok` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `filter` for `is_ok` on iterator over `Result`s [INFO] [stdout] --> src/commands/hub.rs:332:18 [INFO] [stdout] | [INFO] [stdout] 332 | .filter(|e| e.is_ok()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `flatten` instead: `flatten()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_filter_is_ok [INFO] [stdout] = note: `#[warn(clippy::iter_filter_is_ok)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or()` on a `Result` value [INFO] [stdout] --> src/commands/inspect.rs:72:21 [INFO] [stdout] | [INFO] [stdout] 72 | let file_size = std::fs::metadata(path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `map_or(, )` instead [INFO] [stdout] | [INFO] [stdout] 72 - let file_size = std::fs::metadata(path).map(|m| m.len()).unwrap_or(0); [INFO] [stdout] 72 + let file_size = std::fs::metadata(path).map_or(0, |m| m.len()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/commands/inspect.rs:89:27 [INFO] [stdout] | [INFO] [stdout] 89 | let mut layer_params: std::collections::BTreeMap, u64, bool)>> = [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/inspect.rs:118:43 [INFO] [stdout] | [INFO] [stdout] 118 | let layer_type = infer_layer_type(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/commands/inspect.rs:121:56 [INFO] [stdout] | [INFO] [stdout] 121 | let (input_shape, output_shape) = infer_shapes(¶ms); [INFO] [stdout] | ^^^^^^^ help: change this to: `params` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calling `to_string` on `&&str` [INFO] [stdout] --> src/commands/inspect.rs:143:28 [INFO] [stdout] | [INFO] [stdout] 143 | metadata.push((key.to_string(), value.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing the receiver: `(*key).to_string()` [INFO] [stdout] | [INFO] [stdout] = help: `&str` implements `ToString` through a slower blanket impl, but `str` has a fast specialization of `ToString` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#inefficient_to_string [INFO] [stdout] = note: `#[warn(clippy::inefficient_to_string)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/kaggle.rs:272:22 [INFO] [stdout] | [INFO] [stdout] 272 | let output_dir = output [INFO] [stdout] | ______________________^ [INFO] [stdout] 273 | | .map(PathBuf::from) [INFO] [stdout] 274 | | .unwrap_or_else(|| PathBuf::from("./data")); [INFO] [stdout] | |___________________________________________________^ help: try: `output.map_or_else(|| PathBuf::from("./data"), PathBuf::from)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/load.rs:433:24 [INFO] [stdout] | [INFO] [stdout] 433 | if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 433 - if entry.file_type().map(|t| t.is_dir()).unwrap_or(false) { [INFO] [stdout] 433 + if entry.file_type().is_ok_and(|t| t.is_dir()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:93:67 [INFO] [stdout] | [INFO] [stdout] 93 | if let Some(epoch) = record.get("epoch").and_then(|v| v.as_u64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:96:71 [INFO] [stdout] | [INFO] [stdout] 96 | if let Some(loss) = record.get("train_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:99:69 [INFO] [stdout] | [INFO] [stdout] 99 | if let Some(loss) = record.get("val_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:102:74 [INFO] [stdout] | [INFO] [stdout] 102 | if let Some(acc) = record.get("train_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:105:72 [INFO] [stdout] | [INFO] [stdout] 105 | if let Some(acc) = record.get("val_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:108:72 [INFO] [stdout] | [INFO] [stdout] 108 | if let Some(lr) = record.get("learning_rate").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:116:71 [INFO] [stdout] | [INFO] [stdout] 116 | if let Some(epoch) = record.get("epoch").and_then(|v| v.as_u64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_u64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:119:75 [INFO] [stdout] | [INFO] [stdout] 119 | if let Some(loss) = record.get("train_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:121:76 [INFO] [stdout] | [INFO] [stdout] 121 | } else if let Some(loss) = record.get("loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:124:73 [INFO] [stdout] | [INFO] [stdout] 124 | if let Some(loss) = record.get("val_loss").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:127:78 [INFO] [stdout] | [INFO] [stdout] 127 | if let Some(acc) = record.get("train_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:129:79 [INFO] [stdout] | [INFO] [stdout] 129 | } else if let Some(acc) = record.get("accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:132:76 [INFO] [stdout] | [INFO] [stdout] 132 | if let Some(acc) = record.get("val_accuracy").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:135:76 [INFO] [stdout] | [INFO] [stdout] 135 | if let Some(lr) = record.get("learning_rate").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/commands/report.rs:137:72 [INFO] [stdout] | [INFO] [stdout] 137 | } else if let Some(lr) = record.get("lr").and_then(|v| v.as_f64()) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace the closure with the method itself: `serde_json::Value::as_f64` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure_for_method_calls [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/commands/report.rs:1369:39 [INFO] [stdout] | [INFO] [stdout] 1369 | let train_max = train_loss.iter().cloned().fold(0.0f64, f64::max); [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] = note: `#[warn(clippy::cloned_instead_of_copied)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `cloned` where `copied` could be used instead [INFO] [stdout] --> src/commands/report.rs:1370:35 [INFO] [stdout] | [INFO] [stdout] 1370 | let val_max = val_loss.iter().cloned().fold(0.0f64, f64::max); [INFO] [stdout] | ^^^^^^ help: try: `copied` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cloned_instead_of_copied [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/commands/resume.rs:331:1 [INFO] [stdout] | [INFO] [stdout] 331 | / fn run_resumed_training( [INFO] [stdout] 332 | | checkpoint_info: &CheckpointInfo, [INFO] [stdout] 333 | | start_epoch: usize, [INFO] [stdout] 334 | | additional_epochs: usize, [INFO] [stdout] ... | [INFO] [stdout] 339 | | batch_size: usize, [INFO] [stdout] 340 | | ) -> Result, Box> { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or_else()` on an `Option` value [INFO] [stdout] --> src/commands/resume.rs:356:27 [INFO] [stdout] | [INFO] [stdout] 356 | let detected_format = format.map(String::from).unwrap_or_else(|| { [INFO] [stdout] | ___________________________^ [INFO] [stdout] 357 | | ResumeDataset::detect_format(&data_path_buf).unwrap_or_else(|| "mnist".to_string()) [INFO] [stdout] 358 | | }); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 356 ~ let detected_format = format.map_or_else(|| { [INFO] [stdout] 357 + ResumeDataset::detect_format(&data_path_buf).unwrap_or_else(|| "mnist".to_string()) [INFO] [stdout] 358 ~ }, String::from); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map().unwrap_or(false)` on a `Result` value [INFO] [stdout] --> src/commands/wandb_client.rs:322:5 [INFO] [stdout] | [INFO] [stdout] 322 | / WandbConfig::load() [INFO] [stdout] 323 | | .map(|c| c.is_configured()) [INFO] [stdout] 324 | | .unwrap_or(false) [INFO] [stdout] | |_________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_unwrap_or [INFO] [stdout] help: use `is_ok_and()` instead [INFO] [stdout] | [INFO] [stdout] 323 - .map(|c| c.is_configured()) [INFO] [stdout] 324 - .unwrap_or(false) [INFO] [stdout] 323 + .is_ok_and(|c| c.is_configured()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:170:26 [INFO] [stdout] | [INFO] [stdout] 170 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` implied by `#[warn(clippy::all)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:173:56 [INFO] [stdout] | [INFO] [stdout] 173 | commands::kaggle::execute_status().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:177:26 [INFO] [stdout] | [INFO] [stdout] 177 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:181:26 [INFO] [stdout] | [INFO] [stdout] 181 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:184:54 [INFO] [stdout] | [INFO] [stdout] 184 | commands::kaggle::execute_list().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:193:70 [INFO] [stdout] | [INFO] [stdout] 193 | HubSubcommand::List => commands::hub::execute_list().map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:195:67 [INFO] [stdout] | [INFO] [stdout] 195 | commands::hub::execute_info(&info_args.model).map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:199:26 [INFO] [stdout] | [INFO] [stdout] 199 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:202:53 [INFO] [stdout] | [INFO] [stdout] 202 | commands::hub::execute_cached().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:206:26 [INFO] [stdout] | [INFO] [stdout] 206 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:217:26 [INFO] [stdout] | [INFO] [stdout] 217 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | .map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:226:18 [INFO] [stdout] | [INFO] [stdout] 226 | .map_err(|e| error::CliError::Other(e)), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:229:26 [INFO] [stdout] | [INFO] [stdout] 229 | .map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:232:58 [INFO] [stdout] | [INFO] [stdout] 232 | commands::dataset::execute_sources().map_err(|e| error::CliError::Other(e)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the tuple variant itself: `error::CliError::Other` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused `async` for function with no await statements [INFO] [stdout] --> src/commands/sync.rs:75:1 [INFO] [stdout] | [INFO] [stdout] 75 | / pub async fn logout() -> CliResult<()> { [INFO] [stdout] 76 | | match ApiClient::logout() { [INFO] [stdout] 77 | | Ok(()) => { [INFO] [stdout] 78 | | println!("{} Logged out successfully", "✓".green().bold()); [INFO] [stdout] ... | [INFO] [stdout] 85 | | Ok(()) [INFO] [stdout] 86 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing the `async` from this function [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_async [INFO] [stdout] = note: `#[warn(clippy::unused_async)]` implied by `#[warn(clippy::pedantic)]` [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 3m 00s [INFO] running `Command { std: "docker" "inspect" "d282a5833a4be890212ba9706d7fa3bd42a38975bd79edfc3b96dcc27d6f7552", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d282a5833a4be890212ba9706d7fa3bd42a38975bd79edfc3b96dcc27d6f7552", kill_on_drop: false }` [INFO] [stdout] d282a5833a4be890212ba9706d7fa3bd42a38975bd79edfc3b96dcc27d6f7552