[INFO] fetching crate aws-sso-rs 1.5.0... [INFO] linting aws-sso-rs-1.5.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate aws-sso-rs 1.5.0 into /workspace/builds/worker-7-tc1/source [INFO] removed /workspace/builds/worker-7-tc1/source/rust-toolchain.toml [INFO] started tweaking crates.io crate aws-sso-rs 1.5.0 [INFO] finished tweaking crates.io crate aws-sso-rs 1.5.0 [INFO] tweaked toml for crates.io crate aws-sso-rs 1.5.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate aws-sso-rs 1.5.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate aws-sso-rs 1.5.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded libredox v0.1.4 [INFO] [stderr] Downloaded predicates-tree v1.0.12 [INFO] [stderr] Downloaded termtree v0.5.1 [INFO] [stderr] Downloaded predicates-core v1.0.9 [INFO] [stderr] Downloaded mockall v0.13.1 [INFO] [stderr] Downloaded predicates v3.1.3 [INFO] [stderr] Downloaded shellexpand v3.1.1 [INFO] [stderr] Downloaded redox_users v0.5.0 [INFO] [stderr] Downloaded mockall_derive v0.13.1 [INFO] [stderr] Downloaded aws-smithy-xml v0.60.10 [INFO] [stderr] Downloaded aws-credential-types v1.2.3 [INFO] [stderr] Downloaded downcast v0.11.0 [INFO] [stderr] Downloaded aws-smithy-observability v0.1.3 [INFO] [stderr] Downloaded cmake v0.1.54 [INFO] [stderr] Downloaded aws-smithy-http v0.62.1 [INFO] [stderr] Downloaded aws-smithy-json v0.61.4 [INFO] [stderr] Downloaded aws-sigv4 v1.3.3 [INFO] [stderr] Downloaded aws-runtime v1.5.8 [INFO] [stderr] Downloaded aws-sdk-sso v1.74.0 [INFO] [stderr] Downloaded hyper-util v0.1.14 [INFO] [stderr] Downloaded aws-config v1.8.1 [INFO] [stderr] Downloaded cc v1.2.29 [INFO] [stderr] Downloaded aws-smithy-runtime v1.8.3 [INFO] [stderr] Downloaded aws-sdk-sts v1.76.0 [INFO] [stderr] Downloaded h2 v0.4.11 [INFO] [stderr] Downloaded aws-lc-rs v1.13.1 [INFO] [stderr] Downloaded aws-sdk-ssooidc v1.75.0 [INFO] [stderr] Downloaded aws-smithy-http-client v1.0.6 [INFO] [stderr] Downloaded aws-smithy-runtime-api v1.8.1 [INFO] [stderr] Downloaded indicatif v0.18.0 [INFO] [stderr] Downloaded prettyplease v0.2.35 [INFO] [stderr] Downloaded aws-smithy-types v1.3.2 [INFO] [stderr] Downloaded rustls v0.23.28 [INFO] [stderr] Downloaded configparser v3.1.0 [INFO] [stderr] Downloaded aws-smithy-async v1.2.5 [INFO] [stderr] Downloaded aws-types v1.3.7 [INFO] [stderr] Downloaded fragile v2.0.1 [INFO] [stderr] Downloaded console v0.16.0 [INFO] [stderr] Downloaded unit-prefix v0.5.1 [INFO] [stderr] Downloaded tokio v1.46.1 [INFO] [stderr] Downloaded aws-lc-sys v0.29.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 2dfe7c227b1497d5c2f6c79cfec64a8ed9dd6733106ea264eaf3ff5ac02f25ab [INFO] running `Command { std: "docker" "start" "-a" "2dfe7c227b1497d5c2f6c79cfec64a8ed9dd6733106ea264eaf3ff5ac02f25ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "2dfe7c227b1497d5c2f6c79cfec64a8ed9dd6733106ea264eaf3ff5ac02f25ab", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2dfe7c227b1497d5c2f6c79cfec64a8ed9dd6733106ea264eaf3ff5ac02f25ab", kill_on_drop: false }` [INFO] [stdout] 2dfe7c227b1497d5c2f6c79cfec64a8ed9dd6733106ea264eaf3ff5ac02f25ab [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a600fea399a81300c53fdfe753bc30a6f8bf12b2fff796927ba5427f549d13d0 [INFO] running `Command { std: "docker" "start" "-a" "a600fea399a81300c53fdfe753bc30a6f8bf12b2fff796927ba5427f549d13d0", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Checking cfg-if v1.0.1 [INFO] [stderr] Checking smallvec v1.15.1 [INFO] [stderr] Checking bytes v1.10.1 [INFO] [stderr] Compiling parking_lot_core v0.9.11 [INFO] [stderr] Compiling lock_api v0.4.13 [INFO] [stderr] Checking futures-task v0.3.31 [INFO] [stderr] Checking outref v0.5.2 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Checking num-traits v0.2.19 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking base64-simd v0.8.0 [INFO] [stderr] Compiling aws-lc-rs v1.13.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Compiling httparse v1.10.1 [INFO] [stderr] Checking log v0.4.27 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Checking openssl-probe v0.1.6 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking bytes-utils v0.1.4 [INFO] [stderr] Compiling semver v1.0.26 [INFO] [stderr] Compiling rustls v0.23.28 [INFO] [stderr] Checking litemap v0.8.0 [INFO] [stderr] Checking writeable v0.6.1 [INFO] [stderr] Checking rustls-native-certs v0.8.1 [INFO] [stderr] Checking rustls-native-certs v0.6.3 [INFO] [stderr] Compiling icu_normalizer_data v2.0.0 [INFO] [stderr] Compiling icu_properties_data v2.0.1 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking cpufeatures v0.2.17 [INFO] [stderr] Checking anstyle v1.0.11 [INFO] [stderr] Checking uuid v1.17.0 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking anstyle-parse v0.2.7 [INFO] [stderr] Checking option-ext v0.2.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Checking colorchoice v1.0.4 [INFO] [stderr] Checking anstyle-query v1.1.3 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking aws-smithy-xml v0.60.10 [INFO] [stderr] Checking predicates-core v1.0.9 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking anstream v0.6.19 [INFO] [stderr] Checking memchr v2.7.5 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Compiling mockall_derive v0.13.1 [INFO] [stderr] Compiling aws-types v1.3.7 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking socket2 v0.5.10 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking clap_builder v4.5.40 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking console v0.16.0 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking unit-prefix v0.5.1 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking termtree v0.5.1 [INFO] [stderr] Checking shellexpand v3.1.1 [INFO] [stderr] Checking predicates v3.1.3 [INFO] [stderr] Checking fragile v2.0.1 [INFO] [stderr] Checking predicates-tree v1.0.12 [INFO] [stderr] Checking downcast v0.11.0 [INFO] [stderr] Checking configparser v3.1.0 [INFO] [stderr] Checking indicatif v0.18.0 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling aws-lc-sys v0.29.0 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling rustls v0.21.12 [INFO] [stderr] Checking tracing-serde v0.2.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling clap_derive v4.5.40 [INFO] [stderr] Checking rustls-webpki v0.101.7 [INFO] [stderr] Checking sct v0.7.1 [INFO] [stderr] Checking tracing-subscriber v0.3.19 [INFO] [stderr] Checking tokio v1.46.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking zerovec v0.11.2 [INFO] [stderr] Checking clap v4.5.40 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.2 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking mockall v0.13.1 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking tokio-util v0.7.15 [INFO] [stderr] Checking aws-smithy-async v1.2.5 [INFO] [stderr] Checking tokio-rustls v0.24.1 [INFO] [stderr] Checking idna v1.0.3 [INFO] [stderr] Checking url v2.5.4 [INFO] [stderr] Checking aws-smithy-types v1.3.2 [INFO] [stderr] Checking h2 v0.4.11 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking aws-smithy-runtime-api v1.8.1 [INFO] [stderr] Checking aws-smithy-json v0.61.4 [INFO] [stderr] Checking aws-smithy-query v0.60.7 [INFO] [stderr] Checking aws-credential-types v1.2.3 [INFO] [stderr] Checking aws-smithy-http v0.62.1 [INFO] [stderr] Checking aws-smithy-observability v0.1.3 [INFO] [stderr] Checking hyper v1.6.0 [INFO] [stderr] Checking aws-sigv4 v1.3.3 [INFO] [stderr] Checking hyper v0.14.32 [INFO] [stderr] Checking hyper-util v0.1.14 [INFO] [stderr] Checking rustls-webpki v0.103.3 [INFO] [stderr] Checking hyper-rustls v0.24.2 [INFO] [stderr] Checking tokio-rustls v0.26.2 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking aws-smithy-http-client v1.0.6 [INFO] [stderr] Checking aws-smithy-runtime v1.8.3 [INFO] [stderr] Checking aws-runtime v1.5.8 [INFO] [stderr] Checking aws-sdk-sso v1.74.0 [INFO] [stderr] Checking aws-sdk-sts v1.76.0 [INFO] [stderr] Checking aws-sdk-ssooidc v1.75.0 [INFO] [stderr] Checking aws-config v1.8.1 [INFO] [stderr] Checking aws-sso-rs v1.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/aws/sso.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | account_name: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - account_name: &String, [INFO] [stdout] 37 + account_name: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/aws/sso.rs:37:19 [INFO] [stdout] | [INFO] [stdout] 37 | account_name: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 - account_name: &String, [INFO] [stdout] 37 + account_name: &str, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cli.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | format!("Author: containerscrew \nWebsite: github.com/containerscrew/aws-sso-rs\nLicense: GPL 3\nIssues: github.com/containerscrew/aws-sso-rs/issues") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Author: containerscrew \nWebsite: github.com/containerscrew/aws-sso-rs\nLicense: GPL 3\nIssues: github.com/containerscrew/aws-sso-rs/issues".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logger.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn setup_logger(log_level: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 ~ pub fn setup_logger(log_level: &str) { [INFO] [stdout] 2 ~ let log_level = match log_level { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `webbrowser::open(&*url).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/utils.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 10 - if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] 10 + if !webbrowser::open(url).is_ok() { [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&**url).is_ok() { [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | &account_name, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `account_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | pb.set_message(format!("{account_name}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `account_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / match handle.await.unwrap() { [INFO] [stdout] 146 | | Ok(account_credentials) => all_credentials.extend(account_credentials), [INFO] [stdout] 147 | | Err(_) => {} // not necessary to do anything with the error, it's printed above [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_________^ help: try: `if let Ok(account_credentials) = handle.await.unwrap() { all_credentials.extend(account_credentials) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/cli.rs:84:5 [INFO] [stdout] | [INFO] [stdout] 84 | format!("Author: containerscrew \nWebsite: github.com/containerscrew/aws-sso-rs\nLicense: GPL 3\nIssues: github.com/containerscrew/aws-sso-rs/issues") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Author: containerscrew \nWebsite: github.com/containerscrew/aws-sso-rs\nLicense: GPL 3\nIssues: github.com/containerscrew/aws-sso-rs/issues".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/logger.rs:1:32 [INFO] [stdout] | [INFO] [stdout] 1 | pub fn setup_logger(log_level: &String) { [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1 ~ pub fn setup_logger(log_level: &str) { [INFO] [stdout] 2 ~ let log_level = match log_level { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils.rs:10:8 [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `webbrowser::open(&*url).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/utils.rs:10:26 [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 10 - if !webbrowser::open(&*url).is_ok() { [INFO] [stdout] 10 + if !webbrowser::open(url).is_ok() { [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 10 | if !webbrowser::open(&**url).is_ok() { [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | &account_name, [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `account_name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/main.rs:135:28 [INFO] [stdout] | [INFO] [stdout] 135 | pb.set_message(format!("{account_name}")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `account_name.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/main.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | / match handle.await.unwrap() { [INFO] [stdout] 146 | | Ok(account_credentials) => all_credentials.extend(account_credentials), [INFO] [stdout] 147 | | Err(_) => {} // not necessary to do anything with the error, it's printed above [INFO] [stdout] 148 | | }; [INFO] [stdout] | |_________^ help: try: `if let Ok(account_credentials) = handle.await.unwrap() { all_credentials.extend(account_credentials) }` [INFO] [stdout] | [INFO] [stdout] = note: you might want to preserve the comments from inside the `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 01s [INFO] running `Command { std: "docker" "inspect" "a600fea399a81300c53fdfe753bc30a6f8bf12b2fff796927ba5427f549d13d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a600fea399a81300c53fdfe753bc30a6f8bf12b2fff796927ba5427f549d13d0", kill_on_drop: false }` [INFO] [stdout] a600fea399a81300c53fdfe753bc30a6f8bf12b2fff796927ba5427f549d13d0