[INFO] fetching crate autoreply 0.3.5... [INFO] linting autoreply-0.3.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate autoreply 0.3.5 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate autoreply 0.3.5 [INFO] finished tweaking crates.io crate autoreply 0.3.5 [INFO] tweaked toml for crates.io crate autoreply 0.3.5 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate autoreply 0.3.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate autoreply 0.3.5 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded data-encoding-macro v0.1.18 [INFO] [stderr] Downloaded linux-keyutils v0.2.4 [INFO] [stderr] Downloaded ipld-core v0.4.2 [INFO] [stderr] Downloaded match-lookup v0.1.1 [INFO] [stderr] Downloaded data-encoding-macro-internal v0.1.16 [INFO] [stderr] Downloaded serde_ipld_dagcbor v0.6.4 [INFO] [stderr] Downloaded secret-service v3.1.0 [INFO] [stderr] Downloaded reqwest-chain v1.0.0 [INFO] [stderr] Downloaded atproto-client v0.12.0 [INFO] [stderr] Downloaded atproto-record v0.12.0 [INFO] [stderr] Downloaded atproto-identity v0.12.0 [INFO] [stderr] Downloaded reqwest-middleware v0.4.2 [INFO] [stderr] Downloaded cbor4ii v0.2.14 [INFO] [stderr] Downloaded atproto-oauth v0.12.0 [INFO] [stderr] Downloaded keyring v2.3.3 [INFO] [stderr] Downloaded rustix v0.37.28 [INFO] [stderr] Downloaded objc2 v0.6.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 857cb08207669a4dc69c645c3e441ea913ae9441843c6397723854853cf18ca0 [INFO] running `Command { std: "docker" "start" "-a" "857cb08207669a4dc69c645c3e441ea913ae9441843c6397723854853cf18ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "857cb08207669a4dc69c645c3e441ea913ae9441843c6397723854853cf18ca0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "857cb08207669a4dc69c645c3e441ea913ae9441843c6397723854853cf18ca0", kill_on_drop: false }` [INFO] [stdout] 857cb08207669a4dc69c645c3e441ea913ae9441843c6397723854853cf18ca0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a16e7787c5f8235e474f7885e0f725bf3fd7cc4a7e55528f6b027280314cadc5 [INFO] running `Command { std: "docker" "start" "-a" "a16e7787c5f8235e474f7885e0f725bf3fd7cc4a7e55528f6b027280314cadc5", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.176 [INFO] [stderr] Compiling portable-atomic v1.11.1 [INFO] [stderr] Checking critical-section v1.2.0 [INFO] [stderr] Compiling find-msvc-tools v0.1.2 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling serde_json v1.0.145 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking http v1.3.1 [INFO] [stderr] Checking hashbrown v0.16.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Checking data-encoding v2.9.0 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking core2 v0.4.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling cc v1.2.39 [INFO] [stderr] Checking iri-string v0.7.8 [INFO] [stderr] Checking tinyvec v1.10.0 [INFO] [stderr] Checking event-listener v5.4.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking indexmap v2.11.4 [INFO] [stderr] Checking hkdf v0.12.4 [INFO] [stderr] Checking rfc6979 v0.4.0 [INFO] [stderr] Compiling moka v0.12.11 [INFO] [stderr] Compiling memchr v2.7.6 [INFO] [stderr] Checking event-listener-strategy v0.5.4 [INFO] [stderr] Checking http-body v1.0.1 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking block-padding v0.3.3 [INFO] [stderr] Checking http-body-util v0.1.3 [INFO] [stderr] Compiling polling v2.8.0 [INFO] [stderr] Checking futures-lite v2.6.1 [INFO] [stderr] Checking once_cell v1.21.3 [INFO] [stderr] Checking tracing-core v0.1.34 [INFO] [stderr] Compiling memoffset v0.7.1 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Compiling rustix v0.37.28 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Checking waker-fn v1.2.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling toml_edit v0.19.15 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking futures-lite v1.13.0 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking async-channel v2.5.0 [INFO] [stderr] Checking async-lock v2.8.0 [INFO] [stderr] Compiling async-io v1.13.0 [INFO] [stderr] Compiling async-fs v1.6.0 [INFO] [stderr] Checking resolv-conf v0.7.5 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking blocking v1.6.2 [INFO] [stderr] Compiling openssl-sys v0.9.109 [INFO] [stderr] Compiling ring v0.17.14 [INFO] [stderr] Checking deranged v0.5.4 [INFO] [stderr] Checking async-executor v1.13.3 [INFO] [stderr] Checking async-broadcast v0.5.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking num-rational v0.4.2 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking num-complex v0.4.6 [INFO] [stderr] Compiling openssl v0.10.73 [INFO] [stderr] Compiling native-tls v0.2.14 [INFO] [stderr] Checking ordered-stream v0.2.0 [INFO] [stderr] Checking anstream v0.6.20 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking cbc v0.1.2 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking ff v0.13.1 [INFO] [stderr] Checking crypto-bigint v0.5.5 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking group v0.13.0 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking uuid v1.18.1 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking io-lifetimes v1.0.11 [INFO] [stderr] Checking socket2 v0.4.10 [INFO] [stderr] Checking xdg-home v1.3.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking regex-automata v0.4.11 [INFO] [stderr] Checking nix v0.26.4 [INFO] [stderr] Compiling proc-macro-crate v1.3.1 [INFO] [stderr] Checking time v0.3.44 [INFO] [stderr] Checking terminal_size v0.4.3 [INFO] [stderr] Checking num v0.4.3 [INFO] [stderr] Compiling schemars v0.8.22 [INFO] [stderr] Checking ulid v1.2.1 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Checking dirs-sys v0.4.1 [INFO] [stderr] Checking linux-keyutils v0.2.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking pem v3.0.5 [INFO] [stderr] Checking serde_path_to_error v0.1.20 [INFO] [stderr] Checking thread_local v1.1.9 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Compiling autoreply v0.3.5 (/opt/rustwide/workdir) [INFO] [stderr] Checking nu-ansi-term v0.50.1 [INFO] [stderr] Checking dirs v5.0.1 [INFO] [stderr] Checking fs2 v0.4.3 [INFO] [stderr] Checking unicode-normalization v0.1.24 [INFO] [stderr] Checking unsigned-varint v0.7.2 [INFO] [stderr] Checking tempfile v3.23.0 [INFO] [stderr] Compiling zvariant_utils v1.0.1 [INFO] [stderr] Compiling synstructure v0.13.2 [INFO] [stderr] Compiling serde_derive_internals v0.29.1 [INFO] [stderr] Compiling match-lookup v0.1.1 [INFO] [stderr] Compiling zvariant_derive v3.15.2 [INFO] [stderr] Compiling derivative v2.2.0 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerofrom-derive v0.1.6 [INFO] [stderr] Compiling yoke-derive v0.8.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling zerovec-derive v0.11.1 [INFO] [stderr] Compiling displaydoc v0.2.5 [INFO] [stderr] Compiling async-trait v0.1.89 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling thiserror-impl v2.0.17 [INFO] [stderr] Compiling data-encoding-macro-internal v0.1.16 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking rustls-webpki v0.103.6 [INFO] [stderr] Checking data-encoding-macro v0.1.18 [INFO] [stderr] Checking base256emoji v1.0.2 [INFO] [stderr] Compiling enum-as-inner v0.6.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking multibase v0.9.2 [INFO] [stderr] Compiling enumflags2_derive v0.7.12 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling regex v1.11.3 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling schemars_derive v0.8.22 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking zerofrom v0.1.6 [INFO] [stderr] Compiling zbus_macros v3.15.2 [INFO] [stderr] Checking yoke v0.8.0 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Checking thiserror v2.0.17 [INFO] [stderr] Checking simple_asn1 v0.6.3 [INFO] [stderr] Checking zerovec v0.11.4 [INFO] [stderr] Checking zerotrie v0.2.2 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serdect v0.2.0 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking multihash v0.19.3 [INFO] [stderr] Checking cbor4ii v0.2.14 [INFO] [stderr] Checking enumflags2 v0.7.12 [INFO] [stderr] Checking chrono v0.4.42 [INFO] [stderr] Checking jsonwebtoken v9.3.1 [INFO] [stderr] Checking serde_cbor v0.11.2 [INFO] [stderr] Checking tinystr v0.8.1 [INFO] [stderr] Checking potential_utf v0.1.3 [INFO] [stderr] Checking zvariant v3.15.2 [INFO] [stderr] Checking cid v0.11.1 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking icu_collections v2.0.0 [INFO] [stderr] Checking sec1 v0.7.3 [INFO] [stderr] Checking icu_locale_core v2.0.0 [INFO] [stderr] Checking elliptic-curve v0.13.8 [INFO] [stderr] Checking ipld-core v0.4.2 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking axum-core v0.4.5 [INFO] [stderr] Checking serde_ipld_dagcbor v0.6.4 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking icu_provider v2.0.0 [INFO] [stderr] Checking ecdsa v0.16.9 [INFO] [stderr] Checking primeorder v0.13.6 [INFO] [stderr] Checking icu_properties v2.0.1 [INFO] [stderr] Checking icu_normalizer v2.0.0 [INFO] [stderr] Checking p384 v0.13.1 [INFO] [stderr] Checking k256 v0.13.4 [INFO] [stderr] Checking p256 v0.13.2 [INFO] [stderr] Checking zbus_names v2.6.1 [INFO] [stderr] Checking zbus v3.15.2 [INFO] [stderr] Checking tokio-util v0.7.16 [INFO] [stderr] Checking tower v0.5.2 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stderr] Checking tokio-stream v0.1.17 [INFO] [stderr] Checking idna_adapter v1.2.1 [INFO] [stderr] Checking idna v1.1.0 [INFO] [stderr] Checking h2 v0.4.12 [INFO] [stderr] Checking tower-http v0.6.6 [INFO] [stderr] Checking url v2.5.7 [INFO] [stderr] Checking hickory-proto v0.25.2 [INFO] [stderr] Checking webbrowser v1.0.5 [INFO] [stderr] Checking hickory-resolver v0.25.2 [INFO] [stderr] Checking secret-service v3.1.0 [INFO] [stderr] Checking hyper v1.7.0 [INFO] [stderr] Checking keyring v2.3.3 [INFO] [stderr] Checking hyper-util v0.1.17 [INFO] [stderr] Checking hyper-rustls v0.27.7 [INFO] [stderr] Checking hyper-tls v0.6.0 [INFO] [stderr] Checking axum v0.7.9 [INFO] [stderr] Checking reqwest v0.12.23 [INFO] [stderr] Checking atproto-identity v0.12.0 [INFO] [stderr] Checking reqwest-middleware v0.4.2 [INFO] [stderr] Checking reqwest-chain v1.0.0 [INFO] [stderr] Checking atproto-oauth v0.12.0 [INFO] [stderr] Checking atproto-record v0.12.0 [INFO] [stderr] Checking atproto-client v0.12.0 [INFO] [stdout] warning: field `pds_url` is never read [INFO] [stdout] --> src/auth/oauth_atproto.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 891 | pub struct BrowserFlowState { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 903 | pub pds_url: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BrowserFlowState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:465:9 [INFO] [stdout] | [INFO] [stdout] 465 | /// and allows user to select any account during OAuth flow. [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 466 | /// If Some, resolves the handle's PDS and passes it as login_hint. [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | /// When provided, the OAuth server will pre-select this account. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 614 | /// When None, the user can freely select any account. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command.handle` after checking its variant with `is_some` [INFO] [stdout] --> src/tools/login.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 62 | if needs_password && command.handle.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 63 | let handle = command.handle.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post_args.reply_to` after checking its variant with `is_some` [INFO] [stdout] --> src/tools/post.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 122 | let markdown = if post_args.reply_to.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = &post_args.reply_to` [INFO] [stdout] ... [INFO] [stdout] 127 | post_args.reply_to.as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/tools/post_format.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | uri.split('/').last().unwrap_or("unknown") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - uri.split('/').last().unwrap_or("unknown") [INFO] [stdout] 94 + uri.split('/').next_back().unwrap_or("unknown") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/tools/react.rs:235:25 [INFO] [stdout] | [INFO] [stdout] 235 | u.split('/').last().map(|s| s.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 235 - u.split('/').last().map(|s| s.to_string()) [INFO] [stdout] 235 + u.split('/').next_back().map(|s| s.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `pds_url` is never read [INFO] [stdout] --> src/auth/oauth_atproto.rs:903:9 [INFO] [stdout] | [INFO] [stdout] 891 | pub struct BrowserFlowState { [INFO] [stdout] | ---------------- field in this struct [INFO] [stdout] ... [INFO] [stdout] 903 | pub pds_url: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `BrowserFlowState` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: method `set_test_elicitation_hook` is never used [INFO] [stdout] --> src/mcp.rs:178:12 [INFO] [stdout] | [INFO] [stdout] 177 | impl ServerContext { [INFO] [stdout] | ------------------ method in this implementation [INFO] [stdout] 178 | pub fn set_test_elicitation_hook(&mut self, f: F) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/tools/thread.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / enum ThreadNode { [INFO] [stdout] 53 | | #[serde(rename = "app.bsky.feed.defs#threadViewPost")] [INFO] [stdout] 54 | | / ThreadViewPost { [INFO] [stdout] 55 | | | post: ThreadPost, [INFO] [stdout] 56 | | | #[serde(default)] [INFO] [stdout] 57 | | | replies: Vec, [INFO] [stdout] 58 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 248 bytes [INFO] [stdout] 59 | | #[serde(rename = "app.bsky.feed.defs#notFoundPost")] [INFO] [stdout] 60 | | / NotFoundPost { [INFO] [stdout] 61 | | | #[allow(dead_code)] [INFO] [stdout] 62 | | | uri: String, [INFO] [stdout] 63 | | | #[serde(rename = "notFound")] [INFO] [stdout] 64 | | | #[allow(dead_code)] [INFO] [stdout] 65 | | | not_found: bool, [INFO] [stdout] 66 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 25 bytes [INFO] [stdout] ... | [INFO] [stdout] 73 | | }, [INFO] [stdout] 74 | | } [INFO] [stdout] | |___^ the entire enum is at least 248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 55 - post: ThreadPost, [INFO] [stdout] 55 + post: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Post` [INFO] [stdout] --> src/tools/thread.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / enum ThreadNode { [INFO] [stdout] 53 | | #[serde(rename = "app.bsky.feed.defs#threadViewPost")] [INFO] [stdout] 54 | | ThreadViewPost { [INFO] [stdout] 55 | | post: ThreadPost, [INFO] [stdout] ... | [INFO] [stdout] 73 | | }, [INFO] [stdout] 74 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tools/thread.rs:169:36 [INFO] [stdout] | [INFO] [stdout] 169 | 1 + replies.iter().map(|r| count_posts(r)).sum::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `count_posts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/auth/login_flow.rs:385:9 [INFO] [stdout] | [INFO] [stdout] 385 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:465:9 [INFO] [stdout] | [INFO] [stdout] 465 | /// and allows user to select any account during OAuth flow. [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:466:9 [INFO] [stdout] | [INFO] [stdout] 466 | /// If Some, resolves the handle's PDS and passes it as login_hint. [INFO] [stdout] | ^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:613:9 [INFO] [stdout] | [INFO] [stdout] 613 | /// When provided, the OAuth server will pre-select this account. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/auth/oauth_atproto.rs:614:9 [INFO] [stdout] | [INFO] [stdout] 614 | /// When None, the user can freely select any account. [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/auth/oauth_tests.rs:22:9 [INFO] [stdout] | [INFO] [stdout] 22 | assert!(true, "OAuth manager can be created with optional handle support"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/auth/oauth_tests.rs:36:9 [INFO] [stdout] | [INFO] [stdout] 36 | assert!(true, "OAuth manager accepts None handle for account selection"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/mcp.rs:22:32 [INFO] [stdout] | [INFO] [stdout] 22 | pub test_elicitation_hook: Option anyhow::Result + Send + Sync>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `command.handle` after checking its variant with `is_some` [INFO] [stdout] --> src/tools/login.rs:63:26 [INFO] [stdout] | [INFO] [stdout] 62 | if needs_password && command.handle.is_some() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 63 | let handle = command.handle.as_ref().unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `post_args.reply_to` after checking its variant with `is_some` [INFO] [stdout] --> src/tools/post.rs:127:13 [INFO] [stdout] | [INFO] [stdout] 122 | let markdown = if post_args.reply_to.is_some() { [INFO] [stdout] | ------------------------------- help: try: `if let Some() = &post_args.reply_to` [INFO] [stdout] ... [INFO] [stdout] 127 | post_args.reply_to.as_ref().unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/tools/post_format.rs:94:5 [INFO] [stdout] | [INFO] [stdout] 94 | uri.split('/').last().unwrap_or("unknown") [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 94 - uri.split('/').last().unwrap_or("unknown") [INFO] [stdout] 94 + uri.split('/').next_back().unwrap_or("unknown") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/tools/react.rs:235:25 [INFO] [stdout] | [INFO] [stdout] 235 | u.split('/').last().map(|s| s.to_string()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 235 - u.split('/').last().map(|s| s.to_string()) [INFO] [stdout] 235 + u.split('/').next_back().map(|s| s.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> src/tools/thread.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / enum ThreadNode { [INFO] [stdout] 53 | | #[serde(rename = "app.bsky.feed.defs#threadViewPost")] [INFO] [stdout] 54 | | / ThreadViewPost { [INFO] [stdout] 55 | | | post: ThreadPost, [INFO] [stdout] 56 | | | #[serde(default)] [INFO] [stdout] 57 | | | replies: Vec, [INFO] [stdout] 58 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 248 bytes [INFO] [stdout] 59 | | #[serde(rename = "app.bsky.feed.defs#notFoundPost")] [INFO] [stdout] 60 | | / NotFoundPost { [INFO] [stdout] 61 | | | #[allow(dead_code)] [INFO] [stdout] 62 | | | uri: String, [INFO] [stdout] 63 | | | #[serde(rename = "notFound")] [INFO] [stdout] 64 | | | #[allow(dead_code)] [INFO] [stdout] 65 | | | not_found: bool, [INFO] [stdout] 66 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 25 bytes [INFO] [stdout] ... | [INFO] [stdout] 73 | | }, [INFO] [stdout] 74 | | } [INFO] [stdout] | |___^ the entire enum is at least 248 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 55 - post: ThreadPost, [INFO] [stdout] 55 + post: Box, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same postfix: `Post` [INFO] [stdout] --> src/tools/thread.rs:52:1 [INFO] [stdout] | [INFO] [stdout] 52 | / enum ThreadNode { [INFO] [stdout] 53 | | #[serde(rename = "app.bsky.feed.defs#threadViewPost")] [INFO] [stdout] 54 | | ThreadViewPost { [INFO] [stdout] 55 | | post: ThreadPost, [INFO] [stdout] ... | [INFO] [stdout] 73 | | }, [INFO] [stdout] 74 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the postfixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/tools/thread.rs:169:36 [INFO] [stdout] | [INFO] [stdout] 169 | 1 + replies.iter().map(|r| count_posts(r)).sum::() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `count_posts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1m 21s [INFO] running `Command { std: "docker" "inspect" "a16e7787c5f8235e474f7885e0f725bf3fd7cc4a7e55528f6b027280314cadc5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a16e7787c5f8235e474f7885e0f725bf3fd7cc4a7e55528f6b027280314cadc5", kill_on_drop: false }` [INFO] [stdout] a16e7787c5f8235e474f7885e0f725bf3fd7cc4a7e55528f6b027280314cadc5