[INFO] fetching crate atomicslice 0.1.0... [INFO] linting atomicslice-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate atomicslice 0.1.0 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate atomicslice 0.1.0 [INFO] finished tweaking crates.io crate atomicslice 0.1.0 [INFO] tweaked toml for crates.io crate atomicslice 0.1.0 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate atomicslice 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 4eb3a31c3e8037894f9b5ccff0a6fa93af238fb8aef075892415dbb2d7db5c19 [INFO] running `Command { std: "docker" "start" "-a" "4eb3a31c3e8037894f9b5ccff0a6fa93af238fb8aef075892415dbb2d7db5c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "4eb3a31c3e8037894f9b5ccff0a6fa93af238fb8aef075892415dbb2d7db5c19", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4eb3a31c3e8037894f9b5ccff0a6fa93af238fb8aef075892415dbb2d7db5c19", kill_on_drop: false }` [INFO] [stdout] 4eb3a31c3e8037894f9b5ccff0a6fa93af238fb8aef075892415dbb2d7db5c19 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4931a92e93647ec8e1d87ed04737f7ca14f9ddb6fa6143b55145153dd9ec61d0 [INFO] running `Command { std: "docker" "start" "-a" "4931a92e93647ec8e1d87ed04737f7ca14f9ddb6fa6143b55145153dd9ec61d0", kill_on_drop: false }` [INFO] [stderr] Checking atomicslice v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:44:34 [INFO] [stdout] | [INFO] [stdout] 44 | pub const SLICE_1_INC: u64 = 0x00_0000_00_0001_00_00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | pub const SLICE_2_INC: u64 = 0x00_0001_00_0000_00_00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0100_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:47:40 [INFO] [stdout] | [INFO] [stdout] 47 | pub const VALID_STATUS_MASK: u64 = 0x00_FFFF_00_FFFF_00_01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x00FF_FF00_FFFF_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | current_slice: current_slice, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_slice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:44:34 [INFO] [stdout] | [INFO] [stdout] 44 | pub const SLICE_1_INC: u64 = 0x00_0000_00_0001_00_00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0000_0001_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] = note: `#[warn(clippy::unusual_byte_groupings)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:45:34 [INFO] [stdout] | [INFO] [stdout] 45 | pub const SLICE_2_INC: u64 = 0x00_0001_00_0000_00_00; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x0000_0100_0000_0000` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: digits of hex, binary or octal literal not in groups of equal size [INFO] [stdout] --> src/lib.rs:47:40 [INFO] [stdout] | [INFO] [stdout] 47 | pub const VALID_STATUS_MASK: u64 = 0x00_FFFF_00_FFFF_00_01; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: consider: `0x00FF_FF00_FFFF_0001` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unusual_byte_groupings [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lib.rs:166:13 [INFO] [stdout] | [INFO] [stdout] 166 | current_slice: current_slice, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `current_slice` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AtomicSlice` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/lib.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:183:15 [INFO] [stdout] | [INFO] [stdout] 183 | while !self [INFO] [stdout] | _______________^ [INFO] [stdout] 184 | | .currently_writing [INFO] [stdout] 185 | | .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst) [INFO] [stdout] 186 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 183 ~ while self [INFO] [stdout] 184 + .currently_writing [INFO] [stdout] 185 + .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/test.rs:41:39 [INFO] [stdout] | [INFO] [stdout] 41 | let slice: &[T] = &*guard; [INFO] [stdout] | ^^^^^^^ help: try: `&guard` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `cloned` [INFO] [stdout] --> src/test.rs:44:40 [INFO] [stdout] | [INFO] [stdout] 44 | for other_value in slice[1..].iter().cloned() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: remove any references to the binding [INFO] [stdout] | [INFO] [stdout] 44 - for other_value in slice[1..].iter().cloned() { [INFO] [stdout] 44 + for other_value in slice[1..].iter() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `u8` [INFO] [stdout] --> src/test.rs:147:16 [INFO] [stdout] | [INFO] [stdout] 147 | z: value.into(), [INFO] [stdout] | ^^^^^^^^^^^^ help: consider removing `.into()`: `value` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `AtomicSlice` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/lib.rs:122:5 [INFO] [stdout] | [INFO] [stdout] 122 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:183:15 [INFO] [stdout] | [INFO] [stdout] 183 | while !self [INFO] [stdout] | _______________^ [INFO] [stdout] 184 | | .currently_writing [INFO] [stdout] 185 | | .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst) [INFO] [stdout] 186 | | .is_ok() [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 183 ~ while self [INFO] [stdout] 184 + .currently_writing [INFO] [stdout] 185 + .compare_exchange(false, true, Ordering::SeqCst, Ordering::SeqCst).is_err() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.20s [INFO] running `Command { std: "docker" "inspect" "4931a92e93647ec8e1d87ed04737f7ca14f9ddb6fa6143b55145153dd9ec61d0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4931a92e93647ec8e1d87ed04737f7ca14f9ddb6fa6143b55145153dd9ec61d0", kill_on_drop: false }` [INFO] [stdout] 4931a92e93647ec8e1d87ed04737f7ca14f9ddb6fa6143b55145153dd9ec61d0