[INFO] fetching crate ark-ff-macros 0.5.0... [INFO] linting ark-ff-macros-0.5.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate ark-ff-macros 0.5.0 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate ark-ff-macros 0.5.0 [INFO] finished tweaking crates.io crate ark-ff-macros 0.5.0 [INFO] tweaked toml for crates.io crate ark-ff-macros 0.5.0 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate ark-ff-macros 0.5.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 8 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05759d35babab827ba399072c62b1667af653d75bad0a9ac7d28bd57fbf342d8 [INFO] running `Command { std: "docker" "start" "-a" "05759d35babab827ba399072c62b1667af653d75bad0a9ac7d28bd57fbf342d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05759d35babab827ba399072c62b1667af653d75bad0a9ac7d28bd57fbf342d8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05759d35babab827ba399072c62b1667af653d75bad0a9ac7d28bd57fbf342d8", kill_on_drop: false }` [INFO] [stdout] 05759d35babab827ba399072c62b1667af653d75bad0a9ac7d28bd57fbf342d8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] ad76bfe4f5f787a7b1d4f67b109ee92d2e94ad6463bb74107187805c04c45987 [INFO] running `Command { std: "docker" "start" "-a" "ad76bfe4f5f787a7b1d4f67b109ee92d2e94ad6463bb74107187805c04c45987", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking unicode-ident v1.0.24 [INFO] [stderr] Checking proc-macro2 v1.0.106 [INFO] [stderr] Checking quote v1.0.45 [INFO] [stderr] Checking syn v2.0.117 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking num-bigint v0.4.6 [INFO] [stderr] Checking ark-ff-macros v0.5.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: the loop variable `j` is used to index `modulus_limbs` [INFO] [stdout] --> src/montgomery/mul.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | for j in 1..num_limbs { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 97 - for j in 1..num_limbs { [INFO] [stdout] 97 + for (j, ) in modulus_limbs.iter().enumerate().take(num_limbs).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/unroll.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | let &Block { [INFO] [stdout] | _________^ [INFO] [stdout] 64 | | ref brace_token, [INFO] [stdout] 65 | | ref stmts, [INFO] [stdout] 66 | | } = block; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 63 ~ let Block { [INFO] [stdout] 64 ~ brace_token, [INFO] [stdout] 65 ~ stmts, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `by_ref.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:37 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `mutability.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:62 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `subpat.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/lib.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let &ItemFn { [INFO] [stdout] | _________________^ [INFO] [stdout] 92 | | block: ref box_block, [INFO] [stdout] 93 | | .. [INFO] [stdout] 94 | | } = &item_fn; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 91 ~ let ItemFn { [INFO] [stdout] 92 ~ block: box_block, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `modulus_limbs` [INFO] [stdout] --> src/montgomery/mul.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | for j in 1..num_limbs { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 97 - for j in 1..num_limbs { [INFO] [stdout] 97 + for (j, ) in modulus_limbs.iter().enumerate().take(num_limbs).skip(1) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/unroll.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | let &Block { [INFO] [stdout] | _________^ [INFO] [stdout] 64 | | ref brace_token, [INFO] [stdout] 65 | | ref stmts, [INFO] [stdout] 66 | | } = block; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] = note: `#[warn(clippy::needless_borrowed_reference)]` on by default [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 63 ~ let Block { [INFO] [stdout] 64 ~ brace_token, [INFO] [stdout] 65 ~ stmts, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:16 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `by_ref.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:37 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `mutability.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unroll.rs:113:62 [INFO] [stdout] | [INFO] [stdout] 113 | if !by_ref.is_none() || !mutability.is_none() || !subpat.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `subpat.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: dereferencing a struct pattern where every field's pattern takes a reference [INFO] [stdout] --> src/lib.rs:91:17 [INFO] [stdout] | [INFO] [stdout] 91 | let &ItemFn { [INFO] [stdout] | _________________^ [INFO] [stdout] 92 | | block: ref box_block, [INFO] [stdout] 93 | | .. [INFO] [stdout] 94 | | } = &item_fn; [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrowed_reference [INFO] [stdout] help: try removing the `&` and `ref` parts [INFO] [stdout] | [INFO] [stdout] 91 ~ let ItemFn { [INFO] [stdout] 92 ~ block: box_block, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: wildcard pattern covers any other pattern as it will match anyway [INFO] [stdout] --> src/lib.rs:141:17 [INFO] [stdout] | [INFO] [stdout] 141 | Plus | _ => number, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider handling `_` separately [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wildcard_in_or_patterns [INFO] [stdout] = note: `#[warn(clippy::wildcard_in_or_patterns)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/lib.rs:154:65 [INFO] [stdout] | [INFO] [stdout] 154 | let (is_positive, limbs) = utils::str_to_limbs(&format!("{}", string)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `string.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i128::abs()` to u64 [INFO] [stdout] --> src/lib.rs:157:38 [INFO] [stdout] | [INFO] [stdout] 157 | format!("{}u64", signed_number.abs() as u64), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `signed_number.unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.59s [INFO] running `Command { std: "docker" "inspect" "ad76bfe4f5f787a7b1d4f67b109ee92d2e94ad6463bb74107187805c04c45987", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ad76bfe4f5f787a7b1d4f67b109ee92d2e94ad6463bb74107187805c04c45987", kill_on_drop: false }` [INFO] [stdout] ad76bfe4f5f787a7b1d4f67b109ee92d2e94ad6463bb74107187805c04c45987