[INFO] fetching crate arendur 0.0.5... [INFO] linting arendur-0.0.5 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate arendur 0.0.5 into /workspace/builds/worker-7-tc1/source [INFO] started tweaking crates.io crate arendur 0.0.5 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate arendur 0.0.5 [INFO] tweaked toml for crates.io crate arendur 0.0.5 written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate arendur 0.0.5 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 75 packages to latest compatible versions [INFO] [stderr] Adding aren_alloc v0.2.1 (available: v0.3.0) [INFO] [stderr] Adding bitflags v0.7.0 (available: v2.11.0) [INFO] [stderr] Adding cgmath v0.14.1 (available: v0.18.0) [INFO] [stderr] Adding clap v2.34.0 (available: v4.6.0) [INFO] [stderr] Adding env_logger v0.4.3 (available: v0.11.9) [INFO] [stderr] Adding flame v0.1.12 (available: v0.2.2) [INFO] [stderr] Adding image v0.12.4 (available: v0.25.10) [INFO] [stderr] Adding lazy_static v0.2.11 (available: v1.5.0) [INFO] [stderr] Adding log v0.3.9 (available: v0.4.29) [INFO] [stderr] Adding num-traits v0.1.43 (available: v0.2.19) [INFO] [stderr] Adding rand v0.3.23 (available: v0.10.0) [INFO] [stderr] Adding rayon v0.7.1 (available: v1.11.0) [INFO] [stderr] Adding tobj v0.1.12 (available: v4.0.3) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded lazy_static v0.2.11 [INFO] [stderr] Downloaded inflate v0.1.1 [INFO] [stderr] Downloaded thread-id v3.3.0 [INFO] [stderr] Downloaded enum_primitive v0.1.1 [INFO] [stderr] Downloaded copy_arena v0.1.1 [INFO] [stderr] Downloaded rayon v0.7.1 [INFO] [stderr] Downloaded aren_alloc v0.2.1 [INFO] [stderr] Downloaded ucd-util v0.1.10 [INFO] [stderr] Downloaded cgmath v0.14.1 [INFO] [stderr] Downloaded env_logger v0.4.3 [INFO] [stderr] Downloaded image v0.12.4 [INFO] [stderr] Downloaded gif v0.9.2 [INFO] [stderr] Downloaded png v0.6.2 [INFO] [stderr] Downloaded tobj v0.1.12 [INFO] [stderr] Downloaded num-rational v0.1.43 [INFO] [stderr] Downloaded regex v0.2.11 [INFO] [stderr] Downloaded regex-syntax v0.5.6 [INFO] [stderr] Downloaded flame v0.1.12 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 3817fcc6d928a79aee07444d1839c2b2ef8dfb013e0a25dc5e64133484299a17 [INFO] running `Command { std: "docker" "start" "-a" "3817fcc6d928a79aee07444d1839c2b2ef8dfb013e0a25dc5e64133484299a17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "3817fcc6d928a79aee07444d1839c2b2ef8dfb013e0a25dc5e64133484299a17", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "3817fcc6d928a79aee07444d1839c2b2ef8dfb013e0a25dc5e64133484299a17", kill_on_drop: false }` [INFO] [stdout] 3817fcc6d928a79aee07444d1839c2b2ef8dfb013e0a25dc5e64133484299a17 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 24eb6189bdc34eabf48f724cbe08538cc616dfda4f33751f9fabe901289b169c [INFO] running `Command { std: "docker" "start" "-a" "24eb6189bdc34eabf48f724cbe08538cc616dfda4f33751f9fabe901289b169c", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling serde v1.0.228 [INFO] [stderr] Compiling num-rational v0.1.43 [INFO] [stderr] Checking adler32 v1.2.0 [INFO] [stderr] Checking either v1.15.0 [INFO] [stderr] Checking lzw v0.10.0 [INFO] [stderr] Checking bitflags v0.7.0 [INFO] [stderr] Checking ucd-util v0.1.10 [INFO] [stderr] Checking inflate v0.1.1 [INFO] [stderr] Checking num-traits v0.1.43 [INFO] [stderr] Checking rand v0.4.6 [INFO] [stderr] Compiling regex v0.2.11 [INFO] [stderr] Checking color_quant v1.1.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking aho-corasick v0.6.10 [INFO] [stderr] Checking deflate v0.7.20 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking scoped_threadpool v0.1.9 [INFO] [stderr] Checking utf8-ranges v1.0.5 [INFO] [stderr] Checking regex-syntax v0.5.6 [INFO] [stderr] Checking approx v0.1.1 [INFO] [stderr] Checking textwrap v0.11.0 [INFO] [stderr] Checking rayon v1.11.0 [INFO] [stderr] Checking rayon v0.7.1 [INFO] [stderr] Checking atty v0.2.14 [INFO] [stderr] Checking thread-id v3.3.0 [INFO] [stderr] Checking tobj v0.1.12 [INFO] [stderr] Checking vec_map v0.8.2 [INFO] [stderr] Checking ansi_term v0.12.1 [INFO] [stderr] Checking copy_arena v0.1.1 [INFO] [stderr] Checking strsim v0.8.0 [INFO] [stderr] Checking aren_alloc v0.2.1 [INFO] [stderr] Checking clap v2.34.0 [INFO] [stderr] Checking rand v0.3.23 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking png v0.6.2 [INFO] [stderr] Checking jpeg-decoder v0.1.22 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking env_logger v0.4.3 [INFO] [stderr] Checking image v0.12.4 [INFO] [stderr] Checking cgmath v0.14.1 [INFO] [stderr] Checking flame v0.1.12 [INFO] [stderr] Checking arendur v0.0.5 (/opt/rustwide/workdir) [INFO] [stdout] warning: the feature `specialization` is incomplete and may not be safe to use and/or cause compiler crashes [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | #![feature(specialization)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see issue #31844 for more information [INFO] [stdout] = help: consider using `min_specialization` instead, which is more stable and complete [INFO] [stdout] = note: `#[warn(incomplete_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `specialization` is incomplete and may not be safe to use and/or cause compiler crashes [INFO] [stdout] --> src/lib.rs:10:12 [INFO] [stdout] | [INFO] [stdout] 10 | #![feature(specialization)] [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: see issue #31844 for more information [INFO] [stdout] = help: consider using `min_specialization` instead, which is more stable and complete [INFO] [stdout] = note: `#[warn(incomplete_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | origin: origin, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | tmax: tmax, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `tmax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | origin: origin, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `origin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | perm: perm, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `perm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | neg_o: neg_o, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `neg_o` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | tmax: tmax, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `tmax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:218:13 [INFO] [stdout] | [INFO] [stdout] 218 | perm: perm, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `perm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | shear: shear, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shear` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | diffs: diffs, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `diffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | neg_o: neg_o, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `neg_o` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:220:13 [INFO] [stdout] | [INFO] [stdout] 220 | shear: shear, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shear` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:278:13 [INFO] [stdout] | [INFO] [stdout] 278 | diffs: diffs, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `diffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/ray.rs:297:13 [INFO] [stdout] | [INFO] [stdout] 297 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/foundamental.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | theta: theta, phi: phi [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `theta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/foundamental.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | theta: theta, phi: phi [INFO] [stdout] | ^^^^^^^^ help: replace it with: `phi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/geometry/foundamental.rs:180:15 [INFO] [stdout] | [INFO] [stdout] 180 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/geometry/foundamental.rs:191:15 [INFO] [stdout] | [INFO] [stdout] 191 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/foundamental.rs:131:13 [INFO] [stdout] | [INFO] [stdout] 131 | theta: theta, phi: phi [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `theta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/foundamental.rs:131:27 [INFO] [stdout] | [INFO] [stdout] 131 | theta: theta, phi: phi [INFO] [stdout] | ^^^^^^^^ help: replace it with: `phi` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/geometry/foundamental.rs:180:15 [INFO] [stdout] | [INFO] [stdout] 180 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: expected names are: `docsrs`, `feature`, and `test` and 31 more [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/geometry/foundamental.rs:191:15 [INFO] [stdout] | [INFO] [stdout] 191 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | uv: uv, [INFO] [stdout] | ^^^^^^ help: replace it with: `uv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | duv: duv, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `duv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pos: pos, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | wo: wo, [INFO] [stdout] | ^^^^^^ help: replace it with: `wo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | norm: norm, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `norm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | dpdx: dpdx, dpdy: dpdy, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | dpdx: dpdx, dpdy: dpdy, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | ray: ray, diffs: diffs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | ray: ray, diffs: diffs, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `diffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:155:13 [INFO] [stdout] | [INFO] [stdout] 155 | uv: uv, [INFO] [stdout] | ^^^^^^ help: replace it with: `uv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:156:13 [INFO] [stdout] | [INFO] [stdout] 156 | duv: duv, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `duv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:150:17 [INFO] [stdout] | [INFO] [stdout] 150 | pos: pos, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:152:17 [INFO] [stdout] | [INFO] [stdout] 152 | wo: wo, [INFO] [stdout] | ^^^^^^ help: replace it with: `wo` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:153:17 [INFO] [stdout] | [INFO] [stdout] 153 | norm: norm, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `norm` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:217:17 [INFO] [stdout] | [INFO] [stdout] 217 | dpdx: dpdx, dpdy: dpdy, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:217:29 [INFO] [stdout] | [INFO] [stdout] 217 | dpdx: dpdx, dpdy: dpdy, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:249:13 [INFO] [stdout] | [INFO] [stdout] 249 | ray: ray, diffs: diffs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/geometry/interaction.rs:249:23 [INFO] [stdout] | [INFO] [stdout] 249 | ray: ray, diffs: diffs, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `diffs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | zmin: zmin, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `zmin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | zmax: zmax, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `zmax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | thetamin: thetamin, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `thetamin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | thetamax: thetamax, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `thetamax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | phimax: phimax, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `phimax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:285:29 [INFO] [stdout] | [INFO] [stdout] 285 | ... dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:286:29 [INFO] [stdout] | [INFO] [stdout] 286 | ... dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:287:29 [INFO] [stdout] | [INFO] [stdout] 287 | ... dndu: dndu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:288:29 [INFO] [stdout] | [INFO] [stdout] 288 | ... dndv: dndv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:149:13 [INFO] [stdout] | [INFO] [stdout] 149 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | zmin: zmin, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `zmin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | zmax: zmax, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `zmax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | thetamin: thetamin, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `thetamin` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | dndu: dndu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | dndv: dndv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | thetamax: thetamax, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `thetamax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:154:13 [INFO] [stdout] | [INFO] [stdout] 154 | phimax: phimax, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `phimax` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:285:29 [INFO] [stdout] | [INFO] [stdout] 285 | ... dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:286:29 [INFO] [stdout] | [INFO] [stdout] 286 | ... dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:287:29 [INFO] [stdout] | [INFO] [stdout] 287 | ... dndu: dndu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/sphere.rs:288:29 [INFO] [stdout] | [INFO] [stdout] 288 | ... dndv: dndv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:473:17 [INFO] [stdout] | [INFO] [stdout] 473 | dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:474:17 [INFO] [stdout] | [INFO] [stdout] 474 | dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/shape/triangle.rs:499:13 [INFO] [stdout] | [INFO] [stdout] 499 | ... (norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 499 - (norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y)) [INFO] [stdout] 499 + norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:600:13 [INFO] [stdout] | [INFO] [stdout] 600 | pdfpos: pdfpos, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pdfpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:27 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighting_profile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:373:13 [INFO] [stdout] | [INFO] [stdout] 373 | dndu: dndu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | pdfpos: pdfpos, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pdfpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:374:13 [INFO] [stdout] | [INFO] [stdout] 374 | dndv: dndv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dndv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/component/transformed.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | local_parent: local_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | parent_local: parent_local, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:473:17 [INFO] [stdout] | [INFO] [stdout] 473 | dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:474:17 [INFO] [stdout] | [INFO] [stdout] 474 | dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around block return value [INFO] [stdout] --> src/shape/triangle.rs:499:13 [INFO] [stdout] | [INFO] [stdout] 499 | ... (norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 499 - (norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y)) [INFO] [stdout] 499 + norms[self.vidx(0)] * barycentrc.x + norms[self.vidx(1)] * barycentrc.y + norms[self.vidx(2)] * (1. as Float - barycentrc.x - barycentrc.y) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/shape/triangle.rs:600:13 [INFO] [stdout] | [INFO] [stdout] 600 | pdfpos: pdfpos, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pdfpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `shape` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:27 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `material` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:38:47 [INFO] [stdout] | [INFO] [stdout] 38 | shape: shape, material: material, lighting_profile: lighting_profile, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lighting_profile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/shape.rs:141:13 [INFO] [stdout] | [INFO] [stdout] 141 | pdfpos: pdfpos, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pdfpos` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition name: `debug` [INFO] [stdout] --> src/component/transformed.rs:29:15 [INFO] [stdout] | [INFO] [stdout] 29 | #[cfg(debug)] [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using a Cargo feature instead [INFO] [stdout] = help: or consider adding in `Cargo.toml` the `check-cfg` lint config for the lint: [INFO] [stdout] [lints.rust] [INFO] [stdout] unexpected_cfgs = { level = "warn", check-cfg = ['cfg(debug)'] } [INFO] [stdout] = help: or consider adding `println!("cargo::rustc-check-cfg=cfg(debug)");` to the top of the `build.rs` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | local_parent: local_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/transformed.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | parent_local: parent_local, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | elements: elements, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | bbox: bbox, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | bbox: bbox, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spectrum/mod.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | inner: inner [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spectrum/mod.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | inner: inner [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | elements: elements, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `elements` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | bbox: bbox, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/mod.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/component/naive.rs:38:13 [INFO] [stdout] | [INFO] [stdout] 38 | bbox: bbox, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bbox` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spectrum/mod.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | inner: inner [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | view_screen: view_screen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | screen_raster: screen_raster, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_raster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | raster_screen: raster_screen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raster_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | raster_view: raster_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raster_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | screen: screen, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | view_parent: view_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/spectrum/mod.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | inner: inner [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | parent_view: parent_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | proj_info: proj_info, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proj_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | dx: dx, [INFO] [stdout] | ^^^^^^ help: replace it with: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | dy: dy, [INFO] [stdout] | ^^^^^^ help: replace it with: `dy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | lens: lens, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `lens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | film: film, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `film` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/mod.rs:67:13 [INFO] [stdout] | [INFO] [stdout] 67 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | view_screen: view_screen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | screen_raster: screen_raster, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `screen_raster` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | raster_screen: raster_screen, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raster_screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | raster_view: raster_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `raster_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/projective.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | screen: screen, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `screen` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | view_parent: view_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `view_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:50:13 [INFO] [stdout] | [INFO] [stdout] 50 | parent_view: parent_view, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_view` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:51:13 [INFO] [stdout] | [INFO] [stdout] 51 | proj_info: proj_info, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `proj_info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:52:13 [INFO] [stdout] | [INFO] [stdout] 52 | dx: dx, [INFO] [stdout] | ^^^^^^ help: replace it with: `dx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:53:13 [INFO] [stdout] | [INFO] [stdout] 53 | dy: dy, [INFO] [stdout] | ^^^^^^ help: replace it with: `dy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:54:13 [INFO] [stdout] | [INFO] [stdout] 54 | lens: lens, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `lens` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | film: film, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `film` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:142:13 [INFO] [stdout] | [INFO] [stdout] 142 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:397:13 [INFO] [stdout] | [INFO] [stdout] 397 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/ortho.rs:223:13 [INFO] [stdout] | [INFO] [stdout] 223 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | resolution: resolution, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | crop_window: crop_window, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crop_window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | filter: filter, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | filter_radius: filter_radius, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filter_radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | pixels: pixels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | pixels: pixels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:316:13 [INFO] [stdout] | [INFO] [stdout] 316 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | Image { inner: inner } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:397:13 [INFO] [stdout] | [INFO] [stdout] 397 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/perspective.rs:398:13 [INFO] [stdout] | [INFO] [stdout] 398 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | sinkf: sinkf, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `sinkf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | sink2f: sink2f, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sink2f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | sampledx: sampledx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sampledx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | resolution: resolution, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `resolution` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | sampledy: sampledy, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sampledy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | crop_window: crop_window, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `crop_window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | rng: rng, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | filter: filter, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `filter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:76:13 [INFO] [stdout] | [INFO] [stdout] 76 | filter_radius: filter_radius, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `filter_radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:214:13 [INFO] [stdout] | [INFO] [stdout] 214 | pixels: pixels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:226:13 [INFO] [stdout] | [INFO] [stdout] 226 | pixels: pixels, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `pixels` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/filming/film.rs:376:17 [INFO] [stdout] | [INFO] [stdout] 376 | Image { inner: inner } [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::*` [INFO] [stdout] --> src/filming/tests.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | use super::*; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | radius: radius [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::projective::*` [INFO] [stdout] --> src/filming/tests.rs:15:9 [INFO] [stdout] | [INFO] [stdout] 15 | use super::projective::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `super::perspective::*` [INFO] [stdout] --> src/filming/tests.rs:16:9 [INFO] [stdout] | [INFO] [stdout] 16 | use super::perspective::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | radius: radius [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | sinkf: sinkf, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `sinkf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | exp: exp, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | neg_alpha: neg_alpha, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neg_alpha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | inv_radius: inv_radius, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inv_radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | sink2f: sink2f, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `sink2f` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | sampledx: sampledx, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sampledx` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | sampledy: sampledy, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `sampledy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/strata.rs:44:13 [INFO] [stdout] | [INFO] [stdout] 44 | rng: rng, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `rng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | c: c, [INFO] [stdout] | ^^^^ help: replace it with: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:47:13 [INFO] [stdout] | [INFO] [stdout] 47 | radius: radius [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | radius: radius [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/sample/filters.rs:216:33 [INFO] [stdout] | [INFO] [stdout] 216 | LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] | ^^^^^^^^^^^ help: remove them: `x*inv_tau` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/sample/filters.rs:216:33 [INFO] [stdout] | [INFO] [stdout] 216 | LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] 216 + LanczosSincFilter::sinc(x*inv_tau) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:113:13 [INFO] [stdout] | [INFO] [stdout] 113 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:114:13 [INFO] [stdout] | [INFO] [stdout] 114 | exp: exp, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `exp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | neg_alpha: neg_alpha, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `neg_alpha` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:150:13 [INFO] [stdout] | [INFO] [stdout] 150 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:151:13 [INFO] [stdout] | [INFO] [stdout] 151 | inv_radius: inv_radius, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `inv_radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:152:13 [INFO] [stdout] | [INFO] [stdout] 152 | b: b, [INFO] [stdout] | ^^^^ help: replace it with: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:153:13 [INFO] [stdout] | [INFO] [stdout] 153 | c: c, [INFO] [stdout] | ^^^^ help: replace it with: `c` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | func: func, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | cdf: cdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | func_integral: func_integral, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_integral` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:206:13 [INFO] [stdout] | [INFO] [stdout] 206 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses [INFO] [stdout] --> src/sample/filters.rs:216:33 [INFO] [stdout] | [INFO] [stdout] 216 | LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] | ^^^^^^^^^^^ help: remove them: `x*inv_tau` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_parens [INFO] [stdout] = note: `#[warn(clippy::double_parens)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around function argument [INFO] [stdout] --> src/sample/filters.rs:216:33 [INFO] [stdout] | [INFO] [stdout] 216 | LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 216 - LanczosSincFilter::sinc((x*inv_tau)) [INFO] [stdout] 216 + LanczosSincFilter::sinc(x*inv_tau) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/filters.rs:269:13 [INFO] [stdout] | [INFO] [stdout] 269 | radius: radius, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `radius` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | pcv: pcv, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pcv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | pmarginal: pmarginal, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pmarginal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | ndim: ndim, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `ndim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | nsample: nsample, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `nsample` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | func: func, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | cdf: cdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `cdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | func_integral: func_integral, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `func_integral` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bxdf/mod.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / bitflags! { [INFO] [stdout] 120 | | pub flags BxdfType: u32 { [INFO] [stdout] 121 | | const BXDF_REFLECTION = 0x01, [INFO] [stdout] 122 | | const BXDF_TRANSMISSION = 0x02, [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bxdf/mod.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / bitflags! { [INFO] [stdout] 120 | | pub flags BxdfType: u32 { [INFO] [stdout] 121 | | const BXDF_REFLECTION = 0x01, [INFO] [stdout] 122 | | const BXDF_TRANSMISSION = 0x02, [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:181:13 [INFO] [stdout] | [INFO] [stdout] 181 | pcv: pcv, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pcv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/distribution.rs:182:13 [INFO] [stdout] | [INFO] [stdout] 182 | pmarginal: pmarginal, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `pmarginal` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:39:13 [INFO] [stdout] | [INFO] [stdout] 39 | inner: inner, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `inner` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:40:13 [INFO] [stdout] | [INFO] [stdout] 40 | ndim: ndim, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `ndim` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/sample/sink.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | nsample: nsample, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `nsample` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `etai` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `etat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^ help: replace it with: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bxdf/mod.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / bitflags! { [INFO] [stdout] 120 | | pub flags BxdfType: u32 { [INFO] [stdout] 121 | | const BXDF_REFLECTION = 0x01, [INFO] [stdout] 122 | | const BXDF_TRANSMISSION = 0x02, [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/bxdf/mod.rs:119:1 [INFO] [stdout] | [INFO] [stdout] 119 | / bitflags! { [INFO] [stdout] 120 | | pub flags BxdfType: u32 { [INFO] [stdout] 121 | | const BXDF_REFLECTION = 0x01, [INFO] [stdout] 122 | | const BXDF_TRANSMISSION = 0x02, [INFO] [stdout] ... | [INFO] [stdout] 132 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | reflectance: reflectance, fresnel: fresnel [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | reflectance: reflectance, fresnel: fresnel [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `fresnel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | transmittance: transmittance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmittance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/lambertian.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | reflectance: reflectance [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | reflectance: reflectance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | coef_a: coef_a, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coef_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | coef_b: coef_b, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coef_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:13 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `etai` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:25 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `etat` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/fresnel.rs:88:37 [INFO] [stdout] | [INFO] [stdout] 88 | etai: etai, etat: etat, k: k [INFO] [stdout] | ^^^^ help: replace it with: `k` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:27:13 [INFO] [stdout] | [INFO] [stdout] 27 | reflectance: reflectance, fresnel: fresnel [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:27:39 [INFO] [stdout] | [INFO] [stdout] 27 | reflectance: reflectance, fresnel: fresnel [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `fresnel` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/specular.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | transmittance: transmittance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `transmittance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/lambertian.rs:23:13 [INFO] [stdout] | [INFO] [stdout] 23 | reflectance: reflectance [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:28:13 [INFO] [stdout] | [INFO] [stdout] 28 | reflectance: reflectance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `reflectance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | coef_a: coef_a, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coef_a` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/bxdf/oren_nayar.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | coef_b: coef_b, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `coef_b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/mod.rs:80:9 [INFO] [stdout] | [INFO] [stdout] 80 | dpdu: dpdu, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdu` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^^^ help: replace it with: `eta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/mod.rs:81:9 [INFO] [stdout] | [INFO] [stdout] 81 | dpdv: dpdv, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `dpdv` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^^^ help: replace it with: `eta` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:39 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ns` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `bs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:31 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ng` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^ help: replace it with: `kd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `sigma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:35 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bump` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:175:17 [INFO] [stdout] | [INFO] [stdout] 175 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:39 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `ts` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/bsdf.rs:42:47 [INFO] [stdout] | [INFO] [stdout] 42 | eta: eta, ns: ns, ng: ng, ts: ts, bs: bs, sink: Default::default(), [INFO] [stdout] | ^^^^^^ help: replace it with: `bs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:185:21 [INFO] [stdout] | [INFO] [stdout] 185 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:13 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^ help: replace it with: `kd` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | info: info, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `sigma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | pyramid: pyramid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pyramid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/material/matte.rs:33:35 [INFO] [stdout] | [INFO] [stdout] 33 | kd: kd, sigma: sigma, bump: bump, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `bump` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:120:17 [INFO] [stdout] | [INFO] [stdout] 120 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | info: info, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:121:17 [INFO] [stdout] | [INFO] [stdout] 121 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | pyramid: pyramid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pyramid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:129:21 [INFO] [stdout] | [INFO] [stdout] 129 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:130:21 [INFO] [stdout] | [INFO] [stdout] 130 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:175:17 [INFO] [stdout] | [INFO] [stdout] 175 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lighting/mod.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / bitflags! { [INFO] [stdout] 85 | | pub flags LightFlag: u32 { [INFO] [stdout] 86 | | const LIGHT_DPOS = 0x1, [INFO] [stdout] 87 | | const LIGHT_DDIR = 0x2, [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:176:17 [INFO] [stdout] | [INFO] [stdout] 176 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:184:21 [INFO] [stdout] | [INFO] [stdout] 184 | mapping: mapping, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lighting/mod.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / bitflags! { [INFO] [stdout] 85 | | pub flags LightFlag: u32 { [INFO] [stdout] 86 | | const LIGHT_DPOS = 0x1, [INFO] [stdout] 87 | | const LIGHT_DDIR = 0x2, [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:185:21 [INFO] [stdout] | [INFO] [stdout] 185 | mipmap: mipmap, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `mipmap` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | PointLight{ posw: pos, intensity: intensity,} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | info: info, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:254:17 [INFO] [stdout] | [INFO] [stdout] 254 | pyramid: pyramid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pyramid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:326:17 [INFO] [stdout] | [INFO] [stdout] 326 | info: info, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `info` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/texturing/textures/image.rs:327:17 [INFO] [stdout] | [INFO] [stdout] 327 | pyramid: pyramid, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `pyramid` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | intensity: intensity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | local_parent: local_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | parent_local: parent_local, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lighting/mod.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / bitflags! { [INFO] [stdout] 85 | | pub flags LightFlag: u32 { [INFO] [stdout] 86 | | const LIGHT_DPOS = 0x1, [INFO] [stdout] 87 | | const LIGHT_DDIR = 0x2, [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated macro `try`: use the `?` operator instead [INFO] [stdout] --> src/lighting/mod.rs:84:1 [INFO] [stdout] | [INFO] [stdout] 84 | / bitflags! { [INFO] [stdout] 85 | | pub flags LightFlag: u32 { [INFO] [stdout] 86 | | const LIGHT_DPOS = 0x1, [INFO] [stdout] 87 | | const LIGHT_DDIR = 0x2, [INFO] [stdout] ... | [INFO] [stdout] 91 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `bitflags` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:26:32 [INFO] [stdout] | [INFO] [stdout] 26 | PointLight{ posw: pos, intensity: intensity,} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:55:13 [INFO] [stdout] | [INFO] [stdout] 55 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:57:13 [INFO] [stdout] | [INFO] [stdout] 57 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:58:13 [INFO] [stdout] | [INFO] [stdout] 58 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | intensity: intensity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:120:13 [INFO] [stdout] | [INFO] [stdout] 120 | local_parent: local_parent, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | parent_local: parent_local, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:188:13 [INFO] [stdout] | [INFO] [stdout] 188 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:190:13 [INFO] [stdout] | [INFO] [stdout] 190 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:191:13 [INFO] [stdout] | [INFO] [stdout] 191 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/pointlights.rs:201:13 [INFO] [stdout] | [INFO] [stdout] 201 | ray: ray, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | intensity: intensity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lighting/distantlight.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | /// extend accordingly [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 89 | let pdisk = self.world_center + self.world_radius*(pdisk.x * u + pdisk.y * v); [INFO] [stdout] | ------------------------------------------------------------------------------ rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | lights: lights, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `lights` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | light_distribution: light_distribution, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_distribution` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | aggregate: aggregate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aggregate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:29:13 [INFO] [stdout] | [INFO] [stdout] 29 | intensity: intensity, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `intensity` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:30:13 [INFO] [stdout] | [INFO] [stdout] 30 | dir: dir, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `dir` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:77:13 [INFO] [stdout] | [INFO] [stdout] 77 | radiance: radiance, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `radiance` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:78:13 [INFO] [stdout] | [INFO] [stdout] 78 | pfrom: pfrom, [INFO] [stdout] | ^^^^^^^^^^^^ help: replace it with: `pfrom` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:79:13 [INFO] [stdout] | [INFO] [stdout] 79 | pto: pto, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pto` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/lighting/distantlight.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | pdf: pdf, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `pdf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused doc comment [INFO] [stdout] --> src/lighting/distantlight.rs:88:9 [INFO] [stdout] | [INFO] [stdout] 88 | /// extend accordingly [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 89 | let pdisk = self.world_center + self.world_radius*(pdisk.x * u + pdisk.y * v); [INFO] [stdout] | ------------------------------------------------------------------------------ rustdoc does not generate documentation for statements [INFO] [stdout] | [INFO] [stdout] = help: use `//` for a plain comment [INFO] [stdout] = note: `#[warn(unused_doc_comments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | lights: lights, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `lights` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:48:13 [INFO] [stdout] | [INFO] [stdout] 48 | light_distribution: light_distribution, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `light_distribution` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/scene.rs:49:13 [INFO] [stdout] | [INFO] [stdout] 49 | aggregate: aggregate, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `aggregate` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/whitted.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/whitted.rs:34:13 [INFO] [stdout] | [INFO] [stdout] 34 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/whitted.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | camera: camera, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/whitted.rs:35:13 [INFO] [stdout] | [INFO] [stdout] 35 | camera: camera, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | camera: camera, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | max_depth: max_depth, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | multithreaded: multithreaded, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `multithreaded` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:42:13 [INFO] [stdout] | [INFO] [stdout] 42 | sampler: sampler, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace it with: `sampler` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:43:13 [INFO] [stdout] | [INFO] [stdout] 43 | camera: camera, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `camera` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | max_depth: max_depth, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `max_depth` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `float_bits_conv` has been stable since 1.20.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | #![feature(float_bits_conv)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/geometry/ray.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | stc: unsafe {mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/component/bvh.rs:179:18 [INFO] [stdout] | [INFO] [stdout] 179 | mem::uninitialized() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/component/bvh.rs:353:32 [INFO] [stdout] | [INFO] [stdout] 353 | bound: unsafe{mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/filming/film.rs:211:23 [INFO] [stdout] | [INFO] [stdout] 211 | vec![mem::uninitialized(); (diagonal.x * diagonal.y) as usize] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:172:32 [INFO] [stdout] | [INFO] [stdout] 172 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:183:32 [INFO] [stdout] | [INFO] [stdout] 183 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:236:28 [INFO] [stdout] | [INFO] [stdout] 236 | vec![std::mem::uninitialized(); buf.len()] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/filters.rs:268:37 [INFO] [stdout] | [INFO] [stdout] 268 | buf: unsafe { vec![mem::uninitialized(); PREC_FILTER_SIZE] }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/sink.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | vec![std::mem::uninitialized(); ndim * nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/texturing/textures/image.rs:631:1 [INFO] [stdout] | [INFO] [stdout] 631 | / lazy_static! { [INFO] [stdout] 632 | | static ref WEIGHT_LUT: Vec = { [INFO] [stdout] 633 | | let mut v = Vec::with_capacity(WEIGHT_LUT_SIZE); [INFO] [stdout] 634 | | for i in 0..WEIGHT_LUT_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 640 | | }; [INFO] [stdout] 641 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/geometry/interaction.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | pub primitive_hit: Option<&'b Primitive>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 119 | pub primitive_hit: Option<&'b dyn Primitive>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 33 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:34:34 [INFO] [stdout] | [INFO] [stdout] 34 | lighting_profile: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | lighting_profile: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | Arc(Arc), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 193 | Arc(Arc), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | pub lighting_profile: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub lighting_profile: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | pub elements: Vec>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub elements: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | filter: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | filter: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | filter: &'a Filter, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 282 | filter: &'a dyn Filter, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:243:32 [INFO] [stdout] | [INFO] [stdout] 243 | bxdfs: [Option>; 8], [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 243 | bxdfs: [Option>; 8], [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub kd: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub kd: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub sigma: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub sigma: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | pub lights: Vec>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub lights: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | pub aggregate: Arc, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 | pub aggregate: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/whitted.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 | camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/pt.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/renderer/pt.rs:46:13 [INFO] [stdout] | [INFO] [stdout] 46 | multithreaded: multithreaded, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `multithreaded` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the feature `float_bits_conv` has been stable since 1.20.0 and no longer requires an attribute to enable [INFO] [stdout] --> src/lib.rs:12:12 [INFO] [stdout] | [INFO] [stdout] 12 | #![feature(float_bits_conv)] [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(stable_features)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/geometry/ray.rs:79:31 [INFO] [stdout] | [INFO] [stdout] 79 | stc: unsafe {mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/component/bvh.rs:179:18 [INFO] [stdout] | [INFO] [stdout] 179 | mem::uninitialized() [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/component/bvh.rs:353:32 [INFO] [stdout] | [INFO] [stdout] 353 | bound: unsafe{mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/filming/film.rs:211:23 [INFO] [stdout] | [INFO] [stdout] 211 | vec![mem::uninitialized(); (diagonal.x * diagonal.y) as usize] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:172:32 [INFO] [stdout] | [INFO] [stdout] 172 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:183:32 [INFO] [stdout] | [INFO] [stdout] 183 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/strata.rs:236:28 [INFO] [stdout] | [INFO] [stdout] 236 | vec![std::mem::uninitialized(); buf.len()] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/filters.rs:268:37 [INFO] [stdout] | [INFO] [stdout] 268 | buf: unsafe { vec![mem::uninitialized(); PREC_FILTER_SIZE] }, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `std::mem::uninitialized`: use `mem::MaybeUninit` instead [INFO] [stdout] --> src/sample/sink.rs:36:28 [INFO] [stdout] | [INFO] [stdout] 36 | vec![std::mem::uninitialized(); ndim * nsample] [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated constant `std::sync::ONCE_INIT`: the `Once::new()` function is now preferred [INFO] [stdout] --> src/texturing/textures/image.rs:631:1 [INFO] [stdout] | [INFO] [stdout] 631 | / lazy_static! { [INFO] [stdout] 632 | | static ref WEIGHT_LUT: Vec = { [INFO] [stdout] 633 | | let mut v = Vec::with_capacity(WEIGHT_LUT_SIZE); [INFO] [stdout] 634 | | for i in 0..WEIGHT_LUT_SIZE { [INFO] [stdout] ... | [INFO] [stdout] 640 | | }; [INFO] [stdout] 641 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = note: this warning originates in the macro `__lazy_static_create` which comes from the expansion of the macro `lazy_static` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/geometry/interaction.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | pub primitive_hit: Option<&'b Primitive>, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 119 | pub primitive_hit: Option<&'b dyn Primitive>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:33:19 [INFO] [stdout] | [INFO] [stdout] 33 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:34:34 [INFO] [stdout] | [INFO] [stdout] 34 | lighting_profile: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | lighting_profile: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:193:13 [INFO] [stdout] | [INFO] [stdout] 193 | Arc(Arc), [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 193 | Arc(Arc), [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:24:38 [INFO] [stdout] | [INFO] [stdout] 24 | pub lighting_profile: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub lighting_profile: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:16:27 [INFO] [stdout] | [INFO] [stdout] 16 | pub elements: Vec>, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 16 | pub elements: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | filter: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | filter: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:282:17 [INFO] [stdout] | [INFO] [stdout] 282 | filter: &'a Filter, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 282 | filter: &'a dyn Filter, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:243:32 [INFO] [stdout] | [INFO] [stdout] 243 | bxdfs: [Option>; 8], [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 243 | bxdfs: [Option>; 8], [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:21:17 [INFO] [stdout] | [INFO] [stdout] 21 | pub kd: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub kd: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:22:20 [INFO] [stdout] | [INFO] [stdout] 22 | pub sigma: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub sigma: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:23:26 [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 23 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:20:22 [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 20 | pub diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:21:23 [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:22:24 [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 22 | pub roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:24:26 [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub bump: Option>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:24:25 [INFO] [stdout] | [INFO] [stdout] 24 | pub lights: Vec>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 24 | pub lights: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:27:24 [INFO] [stdout] | [INFO] [stdout] 27 | pub aggregate: Arc, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 | pub aggregate: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/whitted.rs:27:17 [INFO] [stdout] | [INFO] [stdout] 27 | camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 27 | camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/pt.rs:28:17 [INFO] [stdout] | [INFO] [stdout] 28 | camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 240 | impl From> for ComponentPointer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 240 | impl From> for ComponentPointer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 40 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:240:15 [INFO] [stdout] | [INFO] [stdout] 240 | impl From> for ComponentPointer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 240 | impl From> for ComponentPointer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | fn get_material(&self) -> &Material; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | fn get_material(&self) -> &dyn Material; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:35:38 [INFO] [stdout] | [INFO] [stdout] 35 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 35 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 69 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 174 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:65:36 [INFO] [stdout] | [INFO] [stdout] 65 | default fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 65 | default fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 85 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:40:28 [INFO] [stdout] | [INFO] [stdout] 40 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 40 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 98 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 98 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:61:32 [INFO] [stdout] | [INFO] [stdout] 61 | fn get_material(&self) -> &Material; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 61 | fn get_material(&self) -> &dyn Material; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:184:36 [INFO] [stdout] | [INFO] [stdout] 184 | default fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 184 | default fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:204:28 [INFO] [stdout] | [INFO] [stdout] 204 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 204 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:217:32 [INFO] [stdout] | [INFO] [stdout] 217 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 217 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:35:38 [INFO] [stdout] | [INFO] [stdout] 35 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 35 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:69:28 [INFO] [stdout] | [INFO] [stdout] 69 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 69 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/shape.rs:174:32 [INFO] [stdout] | [INFO] [stdout] 174 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 174 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:65:36 [INFO] [stdout] | [INFO] [stdout] 65 | default fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 65 | default fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:85:28 [INFO] [stdout] | [INFO] [stdout] 85 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 85 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(&mut self, bxdf: Pointer<'a, Bxdf>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(&mut self, bxdf: Pointer<'a, dyn Bxdf>) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:259:41 [INFO] [stdout] | [INFO] [stdout] 259 | fn add(&mut self, bxdf: Pointer<'a, Bxdf>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 259 | fn add(&mut self, bxdf: Pointer<'a, dyn Bxdf>) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:282:38 [INFO] [stdout] | [INFO] [stdout] 282 | fn next(&mut self) -> Option<&'a Bxdf> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 282 | fn next(&mut self) -> Option<&'a dyn Bxdf> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/texturing/textures/image.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | ) -> Option>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 142 | ) -> Option>>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/texturing/textures/image.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | ) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 197 | ) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/whitted.rs:32:65 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new + ?Sized>(sampler: S, camera: Arc, path: &P) -> WhittedRenderer { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new + ?Sized>(sampler: S, camera: Arc, path: &P) -> WhittedRenderer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/pt.rs:38:33 [INFO] [stdout] | [INFO] [stdout] 38 | sampler: S, camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | sampler: S, camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:274:47 [INFO] [stdout] | [INFO] [stdout] 274 | impl Composable for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 274 | impl Composable for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:303:47 [INFO] [stdout] | [INFO] [stdout] 303 | impl Composable for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 303 | impl Composable for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:333:46 [INFO] [stdout] | [INFO] [stdout] 333 | impl Primitive for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 333 | impl Primitive for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:531:28 [INFO] [stdout] | [INFO] [stdout] 531 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 531 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:346:42 [INFO] [stdout] | [INFO] [stdout] 346 | impl Light for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 346 | impl Light for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:630:32 [INFO] [stdout] | [INFO] [stdout] 630 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 630 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:224:28 [INFO] [stdout] | [INFO] [stdout] 224 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 224 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:242:22 [INFO] [stdout] | [INFO] [stdout] 242 | fn from(arc: Arc) -> ComponentPointer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 242 | fn from(arc: Arc) -> ComponentPointer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:298:28 [INFO] [stdout] | [INFO] [stdout] 298 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 298 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:328:28 [INFO] [stdout] | [INFO] [stdout] 328 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 328 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:341:32 [INFO] [stdout] | [INFO] [stdout] 341 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 341 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:98:32 [INFO] [stdout] | [INFO] [stdout] 98 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 98 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:184:36 [INFO] [stdout] | [INFO] [stdout] 184 | default fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 184 | default fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:204:28 [INFO] [stdout] | [INFO] [stdout] 204 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 204 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:217:32 [INFO] [stdout] | [INFO] [stdout] 217 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 217 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:48:45 [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(&mut self, bxdf: Pointer<'a, Bxdf>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | pub fn add(&mut self, bxdf: Pointer<'a, dyn Bxdf>) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:259:41 [INFO] [stdout] | [INFO] [stdout] 259 | fn add(&mut self, bxdf: Pointer<'a, Bxdf>) { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 259 | fn add(&mut self, bxdf: Pointer<'a, dyn Bxdf>) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:282:38 [INFO] [stdout] | [INFO] [stdout] 282 | fn next(&mut self) -> Option<&'a Bxdf> { [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 282 | fn next(&mut self) -> Option<&'a dyn Bxdf> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/texturing/textures/image.rs:142:21 [INFO] [stdout] | [INFO] [stdout] 142 | ) -> Option>>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 142 | ) -> Option>>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/texturing/textures/image.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | ) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 197 | ) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/whitted.rs:32:65 [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new + ?Sized>(sampler: S, camera: Arc, path: &P) -> WhittedRenderer { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | pub fn new + ?Sized>(sampler: S, camera: Arc, path: &P) -> WhittedRenderer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/pt.rs:38:33 [INFO] [stdout] | [INFO] [stdout] 38 | sampler: S, camera: Arc, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 38 | sampler: S, camera: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:274:47 [INFO] [stdout] | [INFO] [stdout] 274 | impl Composable for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 274 | impl Composable for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:303:47 [INFO] [stdout] | [INFO] [stdout] 303 | impl Composable for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 303 | impl Composable for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:333:46 [INFO] [stdout] | [INFO] [stdout] 333 | impl Primitive for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 333 | impl Primitive for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:531:28 [INFO] [stdout] | [INFO] [stdout] 531 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 531 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:346:42 [INFO] [stdout] | [INFO] [stdout] 346 | impl Light for TransformedComposable> [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 346 | impl Light for TransformedComposable> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:630:32 [INFO] [stdout] | [INFO] [stdout] 630 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 630 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | fn lanczos_default() -> Arc { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | fn lanczos_default() -> Arc { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:224:28 [INFO] [stdout] | [INFO] [stdout] 224 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 224 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:242:22 [INFO] [stdout] | [INFO] [stdout] 242 | fn from(arc: Arc) -> ComponentPointer { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 242 | fn from(arc: Arc) -> ComponentPointer { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:298:28 [INFO] [stdout] | [INFO] [stdout] 298 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 298 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:328:28 [INFO] [stdout] | [INFO] [stdout] 328 | fn as_light(&self) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 328 | fn as_light(&self) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/transformed.rs:341:32 [INFO] [stdout] | [INFO] [stdout] 341 | fn get_material(&self) -> &Material { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 341 | fn get_material(&self) -> &dyn Material { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:47:29 [INFO] [stdout] | [INFO] [stdout] 47 | fn lanczos_default() -> Arc { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 47 | fn lanczos_default() -> Arc { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:281:21 [INFO] [stdout] | [INFO] [stdout] 281 | type Item = &'a Bxdf; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 281 | type Item = &'a dyn Bxdf; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:281:21 [INFO] [stdout] | [INFO] [stdout] 281 | type Item = &'a Bxdf; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 281 | type Item = &'a dyn Bxdf; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 84 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:85:38 [INFO] [stdout] | [INFO] [stdout] 85 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 85 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:124:38 [INFO] [stdout] | [INFO] [stdout] 124 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 124 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(elements: Vec>) -> Naive { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(elements: Vec>) -> Naive { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_one(element: Arc) -> Naive { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_one(element: Arc) -> Naive { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:42:43 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn append(&mut self, element: Arc) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | pub fn append(&mut self, element: Arc) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:55:76 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(resolution: Point2, crop_window: BBox2f, filter: Arc) -> Film { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(resolution: Point2, crop_window: BBox2f, filter: Arc) -> Film { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:84:23 [INFO] [stdout] | [INFO] [stdout] 84 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:85:38 [INFO] [stdout] | [INFO] [stdout] 85 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 85 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:123:23 [INFO] [stdout] | [INFO] [stdout] 123 | material: Arc, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 123 | material: Arc, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/shape/triangle.rs:124:38 [INFO] [stdout] | [INFO] [stdout] 124 | lighting_profile: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 124 | lighting_profile: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:21:34 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(elements: Vec>) -> Naive { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 21 | pub fn new(elements: Vec>) -> Naive { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:33:34 [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_one(element: Arc) -> Naive { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | pub fn from_one(element: Arc) -> Naive { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/naive.rs:42:43 [INFO] [stdout] | [INFO] [stdout] 42 | pub fn append(&mut self, element: Arc) { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 42 | pub fn append(&mut self, element: Arc) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(kd: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(kd: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | sigma: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | sigma: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>>) -> Self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/filming/film.rs:55:76 [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(resolution: Point2, crop_window: BBox2f, filter: Arc) -> Film { [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 55 | pub fn new(resolution: Point2, crop_window: BBox2f, filter: Arc) -> Film { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | lights: Vec>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | lights: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | aggregate: Arc [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | aggregate: Arc [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:54:45 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn get_light(&self, idx: usize) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 54 | pub fn get_light(&self, idx: usize) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | light: &Light, ulight: Point2f, uscattering: Point2f, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | light: &dyn Light, ulight: Point2f, uscattering: Point2f, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn sample_one_light(&self, u: Float) -> (&Light, Float) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 170 | pub fn sample_one_light(&self, u: Float) -> (&dyn Light, Float) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:29:24 [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(kd: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | pub fn new(kd: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:30:16 [INFO] [stdout] | [INFO] [stdout] 30 | sigma: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | sigma: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/matte.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>>) -> Self { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>>) -> Self { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:28:22 [INFO] [stdout] | [INFO] [stdout] 28 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 28 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:29:23 [INFO] [stdout] | [INFO] [stdout] 29 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:30:24 [INFO] [stdout] | [INFO] [stdout] 30 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/plastic.rs:31:26 [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/glass.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:29:22 [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 29 | diffuse: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:30:23 [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 30 | specular: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:31:24 [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 31 | roughness: Arc>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/translucent.rs:33:26 [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 33 | bump: Option>> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[must_use]` attribute cannot be used on inherent impl blocks [INFO] [stdout] --> src/lighting/mod.rs:114:1 [INFO] [stdout] | [INFO] [stdout] 114 | #[must_use] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = help: `#[must_use]` can be applied to data types, functions, and traits [INFO] [stdout] = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:32:25 [INFO] [stdout] | [INFO] [stdout] 32 | lights: Vec>, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 32 | lights: Vec>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:34:24 [INFO] [stdout] | [INFO] [stdout] 34 | aggregate: Arc [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 34 | aggregate: Arc [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:54:45 [INFO] [stdout] | [INFO] [stdout] 54 | pub fn get_light(&self, idx: usize) -> &Light { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 54 | pub fn get_light(&self, idx: usize) -> &dyn Light { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:84:17 [INFO] [stdout] | [INFO] [stdout] 84 | light: &Light, ulight: Point2f, uscattering: Point2f, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 84 | light: &dyn Light, ulight: Point2f, uscattering: Point2f, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/renderer/scene.rs:170:51 [INFO] [stdout] | [INFO] [stdout] 170 | pub fn sample_one_light(&self, u: Float) -> (&Light, Float) { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 170 | pub fn sample_one_light(&self, u: Float) -> (&dyn Light, Float) { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 70 | let mut materials: Vec> = Vec::with_capacity(mtls.len()+1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | let mut materials: Vec> = Vec::with_capacity(mtls.len()+1); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `#[must_use]` attribute cannot be used on inherent impl blocks [INFO] [stdout] --> src/lighting/mod.rs:114:1 [INFO] [stdout] | [INFO] [stdout] 114 | #[must_use] [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this was previously accepted by the compiler but is being phased out; it will become a hard error in a future release! [INFO] [stdout] = help: `#[must_use]` can be applied to data types, functions, and traits [INFO] [stdout] = note: `#[warn(unused_attributes)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/component/mod.rs:70:32 [INFO] [stdout] | [INFO] [stdout] 70 | let mut materials: Vec> = Vec::with_capacity(mtls.len()+1); [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 70 | let mut materials: Vec> = Vec::with_capacity(mtls.len()+1); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type annotations needed [INFO] [stdout] --> src/spectrum/mod.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | ptr.as_ref().unwrap() [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(tyvar_behind_raw_pointer)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type annotations needed [INFO] [stdout] --> src/spectrum/mod.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | ptr.as_mut().unwrap() [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type annotations needed [INFO] [stdout] --> src/spectrum/mod.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | ptr.as_ref().unwrap() [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(tyvar_behind_raw_pointer)]` (part of `#[warn(rust_2018_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type annotations needed [INFO] [stdout] --> src/spectrum/mod.rs:170:17 [INFO] [stdout] | [INFO] [stdout] 170 | ptr.as_mut().unwrap() [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2018! [INFO] [stdout] = note: for more information, see [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:289:37 [INFO] [stdout] | [INFO] [stdout] 289 | let ret: *const Bxdf = &**p; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 289 | let ret: *const dyn Bxdf = &**p; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/material/bsdf.rs:289:37 [INFO] [stdout] | [INFO] [stdout] 289 | let ret: *const Bxdf = &**p; [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 289 | let ret: *const dyn Bxdf = &**p; [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/shape/tests.rs:48:14 [INFO] [stdout] | [INFO] [stdout] 48 | let (t, si) = sphere.intersect_ray(&ray).unwrap(); [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `i` [INFO] [stdout] --> src/shape/tests.rs:59:13 [INFO] [stdout] | [INFO] [stdout] 59 | for i in 0..ROUNDS { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_i` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `j` [INFO] [stdout] --> src/shape/tests.rs:65:17 [INFO] [stdout] | [INFO] [stdout] 65 | for j in 0..ROUNDS { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_j` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `t` [INFO] [stdout] --> src/shape/tests.rs:70:30 [INFO] [stdout] | [INFO] [stdout] 70 | if let Some((t, si)) = spheref.intersect_ray(&ray) { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_t` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shape/sphere.rs:232:66 [INFO] [stdout] | [INFO] [stdout] 232 | if let Some(t) = Sphere::intersect_ray_full(self.radius, &ray) { [INFO] [stdout] | ^^^^ help: change this to: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/shape/triangle.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | debug_assert!(self.indices.len() % 3 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.indices.len().is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | let normals = if model.mesh.normals.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.normals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | let uvs = if model.mesh.texcoords.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.texcoords.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | let normals = if model.mesh.normals.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.normals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 148 | let uvs = if model.mesh.texcoords.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.texcoords.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/shape/triangle.rs:303:23 [INFO] [stdout] | [INFO] [stdout] 303 | debug_assert!(self.idx % 3 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `self.idx.is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/geometry/tests.rs:51:17 [INFO] [stdout] | [INFO] [stdout] 51 | assert!(bbox1.intersect(&bbox)==None); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `bbox1.intersect(&bbox).is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/shape/triangle.rs:419:80 [INFO] [stdout] | [INFO] [stdout] 419 | if det < ZERO && (tscaled >= ZERO || tscaled < ray.max_extend() * det) { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 420 | | return None; [INFO] [stdout] 421 | | } else if det > ZERO && (tscaled <= ZERO || tscaled > ray.max_extend() * det) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/shape/triangle.rs:421:87 [INFO] [stdout] | [INFO] [stdout] 421 | } else if det > ZERO && (tscaled <= ZERO || tscaled > ray.max_extend() * det) { [INFO] [stdout] | _______________________________________________________________________________________^ [INFO] [stdout] 422 | | return None; [INFO] [stdout] 423 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/mod.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | let mut ray = ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/component/mod.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if mtl.diffuse_texture != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mtl.diffuse_texture.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/component/mod.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | if mtl.specular_texture != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mtl.specular_texture.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/component/mod.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | value: ((1000. - mtl.shininess) / 1000.).min(1.).max(0.) as Float [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `((1000. - mtl.shininess) / 1000.).clamp(0., 1.)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/component/mod.rs:126:69 [INFO] [stdout] | [INFO] [stdout] 126 | name: mtl.unknown_param.get("map_bump").map_or_else(|| String::new(), |r| r.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/component/mod.rs:140:24 [INFO] [stdout] | [INFO] [stdout] 140 | let dissolve = mtl.dissolve.max(0.).min(1.) as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `mtl.dissolve.clamp(0., 1.)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/shape/sphere.rs:232:66 [INFO] [stdout] | [INFO] [stdout] 232 | if let Some(t) = Sphere::intersect_ray_full(self.radius, &ray) { [INFO] [stdout] | ^^^^ help: change this to: `ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/shape/triangle.rs:42:23 [INFO] [stdout] | [INFO] [stdout] 42 | debug_assert!(self.indices.len() % 3 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `self.indices.len().is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:60:36 [INFO] [stdout] | [INFO] [stdout] 60 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:74:36 [INFO] [stdout] | [INFO] [stdout] 74 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:102:26 [INFO] [stdout] | [INFO] [stdout] 102 | let normals = if model.mesh.normals.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.normals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:80:36 [INFO] [stdout] | [INFO] [stdout] 80 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:107:22 [INFO] [stdout] | [INFO] [stdout] 107 | let uvs = if model.mesh.texcoords.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.texcoords.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:131:59 [INFO] [stdout] | [INFO] [stdout] 131 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:143:26 [INFO] [stdout] | [INFO] [stdout] 143 | let normals = if model.mesh.normals.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.normals.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/shape/triangle.rs:148:22 [INFO] [stdout] | [INFO] [stdout] 148 | let uvs = if model.mesh.texcoords.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!model.mesh.texcoords.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:174:36 [INFO] [stdout] | [INFO] [stdout] 174 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:179:36 [INFO] [stdout] | [INFO] [stdout] 179 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:193:36 [INFO] [stdout] | [INFO] [stdout] 193 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:199:36 [INFO] [stdout] | [INFO] [stdout] 199 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:250:59 [INFO] [stdout] | [INFO] [stdout] 250 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:288:36 [INFO] [stdout] | [INFO] [stdout] 288 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:293:36 [INFO] [stdout] | [INFO] [stdout] 293 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/shape/triangle.rs:303:23 [INFO] [stdout] | [INFO] [stdout] 303 | debug_assert!(self.idx % 3 == 0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `self.idx.is_multiple_of(3)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:317:36 [INFO] [stdout] | [INFO] [stdout] 317 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:323:36 [INFO] [stdout] | [INFO] [stdout] 323 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:374:59 [INFO] [stdout] | [INFO] [stdout] 374 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:64:44 [INFO] [stdout] | [INFO] [stdout] 64 | let mut cinfo = ComponentInfo::new(&components); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `components` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` has identical blocks [INFO] [stdout] --> src/shape/triangle.rs:419:80 [INFO] [stdout] | [INFO] [stdout] 419 | if det < ZERO && (tscaled >= ZERO || tscaled < ray.max_extend() * det) { [INFO] [stdout] | ________________________________________________________________________________^ [INFO] [stdout] 420 | | return None; [INFO] [stdout] 421 | | } else if det > ZERO && (tscaled <= ZERO || tscaled > ray.max_extend() * det) { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] note: same as this [INFO] [stdout] --> src/shape/triangle.rs:421:87 [INFO] [stdout] | [INFO] [stdout] 421 | } else if det > ZERO && (tscaled <= ZERO || tscaled > ray.max_extend() * det) { [INFO] [stdout] | _______________________________________________________________________________________^ [INFO] [stdout] 422 | | return None; [INFO] [stdout] 423 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else [INFO] [stdout] = note: `#[warn(clippy::if_same_then_else)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/bvh.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | let mut iray = ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/component/bvh.rs:200:16 [INFO] [stdout] | [INFO] [stdout] 200 | fn to_leaf(&mut self, offset: usize, len: usize, bound: BBox3f) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/component/bvh.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | fn to_interior(&mut self, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/component/bvh.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | assert!(components.len()!=0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!components.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:291:73 [INFO] [stdout] | [INFO] [stdout] 291 | ... strategy, midpoint[split_axis], split_axis, &mut ret, bound [INFO] [stdout] | ^^^^^^^^ help: change this to: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:309:52 [INFO] [stdout] | [INFO] [stdout] 309 | strategy, mid, split_axis, &mut ret, bound [INFO] [stdout] | ^^^^^^^^ help: change this to: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/mod.rs:36:23 [INFO] [stdout] | [INFO] [stdout] 36 | let mut ray = ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/component/bvh.rs:417:1 [INFO] [stdout] | [INFO] [stdout] 417 | / fn sort_mid<'a>( [INFO] [stdout] 418 | | alloc: &mut Allocator<'a>, components: &mut [ComponentInfo], offset: usize, [INFO] [stdout] 419 | | node_count: &mut usize, ordered: &mut [ComponentInfo], strategy: BVHStrategy, [INFO] [stdout] 420 | | mid: Float, split_axis: usize, ret: &mut BuildNode<'a>, bound: BBox3f [INFO] [stdout] 421 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/component/bvh.rs:445:1 [INFO] [stdout] | [INFO] [stdout] 445 | / fn handle_tails<'a>( [INFO] [stdout] 446 | | alloc: &mut Allocator<'a>, components: &mut [ComponentInfo], offset: usize, [INFO] [stdout] 447 | | node_count: &mut usize, ordered: &mut [ComponentInfo], strategy: BVHStrategy, [INFO] [stdout] 448 | | i: usize, split_axis: usize, ret: &mut BuildNode<'a>, bound: BBox3f [INFO] [stdout] 449 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/component/mod.rs:88:16 [INFO] [stdout] | [INFO] [stdout] 88 | if mtl.diffuse_texture != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mtl.diffuse_texture.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/component/mod.rs:112:16 [INFO] [stdout] | [INFO] [stdout] 112 | if mtl.specular_texture != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!mtl.specular_texture.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/component/mod.rs:121:20 [INFO] [stdout] | [INFO] [stdout] 121 | value: ((1000. - mtl.shininess) / 1000.).min(1.).max(0.) as Float [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `((1000. - mtl.shininess) / 1000.).clamp(0., 1.)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] = note: `#[warn(clippy::manual_clamp)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/naive.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut ray = min_ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*min_ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/component/mod.rs:126:69 [INFO] [stdout] | [INFO] [stdout] 126 | name: mtl.unknown_param.get("map_bump").map_or_else(|| String::new(), |r| r.to_owned()), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `String::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: clamp-like pattern without using clamp function [INFO] [stdout] --> src/component/mod.rs:140:24 [INFO] [stdout] | [INFO] [stdout] 140 | let dissolve = mtl.dissolve.max(0.).min(1.) as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with clamp: `mtl.dissolve.clamp(0., 1.)` [INFO] [stdout] | [INFO] [stdout] = note: clamp will panic if max < min, min.is_nan(), or max.is_nan() [INFO] [stdout] = note: clamp returns NaN if the input is NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_clamp [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spectrum/mod.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn from_slice<'a>(slice: &'a [T]) -> &'a Self { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 159 - fn from_slice<'a>(slice: &'a [T]) -> &'a Self { [INFO] [stdout] 159 + fn from_slice(slice: &[T]) -> &Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spectrum/mod.rs:167:23 [INFO] [stdout] | [INFO] [stdout] 167 | fn from_slice_mut<'a>(slice: &'a mut [Self::Subpixel]) -> &'a mut Self { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 167 - fn from_slice_mut<'a>(slice: &'a mut [Self::Subpixel]) -> &'a mut Self { [INFO] [stdout] 167 + fn from_slice_mut(slice: &mut [Self::Subpixel]) -> &mut Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:55:36 [INFO] [stdout] | [INFO] [stdout] 55 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] = note: `#[warn(clippy::explicit_auto_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:60:36 [INFO] [stdout] | [INFO] [stdout] 60 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:74:36 [INFO] [stdout] | [INFO] [stdout] 74 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/spectrum/mod.rs:281:44 [INFO] [stdout] | [INFO] [stdout] 281 | (3.240479 as Float) * xyz.x - (1.537150 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 281 - (3.240479 as Float) * xyz.x - (1.537150 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] 281 + (3.240479 as Float) * xyz.x - (1.537_15 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:80:36 [INFO] [stdout] | [INFO] [stdout] 80 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:131:59 [INFO] [stdout] | [INFO] [stdout] 131 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spectrum/mod.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | / !(self.r().is_nan() || self.g().is_nan() || self.b().is_nan()) [INFO] [stdout] 305 | | && !(self.r().is_infinite() || self.g().is_infinite() || self.b().is_infinite()) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(self.r().is_nan() || self.g().is_nan() || self.b().is_nan() || self.r().is_infinite() || self.g().is_infinite() || self.b().is_infinite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:174:36 [INFO] [stdout] | [INFO] [stdout] 174 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:179:36 [INFO] [stdout] | [INFO] [stdout] 179 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:193:36 [INFO] [stdout] | [INFO] [stdout] 193 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:199:36 [INFO] [stdout] | [INFO] [stdout] 199 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:250:59 [INFO] [stdout] | [INFO] [stdout] 250 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:288:36 [INFO] [stdout] | [INFO] [stdout] 288 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:293:36 [INFO] [stdout] | [INFO] [stdout] 293 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:317:36 [INFO] [stdout] | [INFO] [stdout] 317 | *ray = ray.apply_transform(&*self.parent_local); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.parent_local` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:323:36 [INFO] [stdout] | [INFO] [stdout] 323 | *ray = ray.apply_transform(&*self.local_parent); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref which would be done by auto-deref [INFO] [stdout] --> src/component/transformed.rs:374:59 [INFO] [stdout] | [INFO] [stdout] 374 | self.inner.generate_path(samples).apply_transform(&*self.local_parent) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `&self.local_parent` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_auto_deref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | delegate_impl_to_norm!(u8); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u8::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | delegate_impl_to_norm!(u8); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u8::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | delegate_impl_to_norm!(u16); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u16::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | delegate_impl_to_norm!(u16); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u16::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:64:44 [INFO] [stdout] | [INFO] [stdout] 64 | let mut cinfo = ComponentInfo::new(&components); [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `components` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:392:1 [INFO] [stdout] | [INFO] [stdout] 392 | delegate_impl_to_norm!(u32); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u32::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:392:1 [INFO] [stdout] | [INFO] [stdout] 392 | delegate_impl_to_norm!(u32); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u32::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/bvh.rs:108:36 [INFO] [stdout] | [INFO] [stdout] 108 | let mut iray = ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^ help: try dereferencing it: `*ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/component/bvh.rs:200:16 [INFO] [stdout] | [INFO] [stdout] 200 | fn to_leaf(&mut self, offset: usize, len: usize, bound: BBox3f) { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] = note: `#[warn(clippy::wrong_self_convention)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods with the following characteristics: (`to_*` and `self` type is `Copy`) usually take `self` by value [INFO] [stdout] --> src/component/bvh.rs:208:20 [INFO] [stdout] | [INFO] [stdout] 208 | fn to_interior(&mut self, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider choosing a less ambiguous name [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#wrong_self_convention [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/component/bvh.rs:251:13 [INFO] [stdout] | [INFO] [stdout] 251 | assert!(components.len()!=0); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!components.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:291:73 [INFO] [stdout] | [INFO] [stdout] 291 | ... strategy, midpoint[split_axis], split_axis, &mut ret, bound [INFO] [stdout] | ^^^^^^^^ help: change this to: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/component/bvh.rs:309:52 [INFO] [stdout] | [INFO] [stdout] 309 | strategy, mid, split_axis, &mut ret, bound [INFO] [stdout] | ^^^^^^^^ help: change this to: `ret` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/component/bvh.rs:417:1 [INFO] [stdout] | [INFO] [stdout] 417 | / fn sort_mid<'a>( [INFO] [stdout] 418 | | alloc: &mut Allocator<'a>, components: &mut [ComponentInfo], offset: usize, [INFO] [stdout] 419 | | node_count: &mut usize, ordered: &mut [ComponentInfo], strategy: BVHStrategy, [INFO] [stdout] 420 | | mid: Float, split_axis: usize, ret: &mut BuildNode<'a>, bound: BBox3f [INFO] [stdout] 421 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> src/component/bvh.rs:445:1 [INFO] [stdout] | [INFO] [stdout] 445 | / fn handle_tails<'a>( [INFO] [stdout] 446 | | alloc: &mut Allocator<'a>, components: &mut [ComponentInfo], offset: usize, [INFO] [stdout] 447 | | node_count: &mut usize, ordered: &mut [ComponentInfo], strategy: BVHStrategy, [INFO] [stdout] 448 | | i: usize, split_axis: usize, ret: &mut BuildNode<'a>, bound: BBox3f [INFO] [stdout] 449 | | ) { [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `RawRay` which implements the `Copy` trait [INFO] [stdout] --> src/component/naive.rs:59:27 [INFO] [stdout] | [INFO] [stdout] 59 | let mut ray = min_ray.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*min_ray` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:26 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:39 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:26 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spectrum/mod.rs:159:19 [INFO] [stdout] | [INFO] [stdout] 159 | fn from_slice<'a>(slice: &'a [T]) -> &'a Self { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 159 - fn from_slice<'a>(slice: &'a [T]) -> &'a Self { [INFO] [stdout] 159 + fn from_slice(slice: &[T]) -> &Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'a [INFO] [stdout] --> src/spectrum/mod.rs:167:23 [INFO] [stdout] | [INFO] [stdout] 167 | fn from_slice_mut<'a>(slice: &'a mut [Self::Subpixel]) -> &'a mut Self { [INFO] [stdout] | ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 167 - fn from_slice_mut<'a>(slice: &'a mut [Self::Subpixel]) -> &'a mut Self { [INFO] [stdout] 167 + fn from_slice_mut(slice: &mut [Self::Subpixel]) -> &mut Self { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/spectrum/mod.rs:281:44 [INFO] [stdout] | [INFO] [stdout] 281 | (3.240479 as Float) * xyz.x - (1.537150 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] = note: `#[warn(clippy::excessive_precision)]` on by default [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 281 - (3.240479 as Float) * xyz.x - (1.537150 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] 281 + (3.240479 as Float) * xyz.x - (1.537_15 as Float) * xyz.y - (0.498535 as Float) * xyz.z, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/spectrum/mod.rs:304:9 [INFO] [stdout] | [INFO] [stdout] 304 | / !(self.r().is_nan() || self.g().is_nan() || self.b().is_nan()) [INFO] [stdout] 305 | | && !(self.r().is_infinite() || self.g().is_infinite() || self.b().is_infinite()) [INFO] [stdout] | |________________________________________________________________________________________^ help: try: `!(self.r().is_nan() || self.g().is_nan() || self.b().is_nan() || self.r().is_infinite() || self.g().is_infinite() || self.b().is_infinite())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | delegate_impl_to_norm!(u8); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u8::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:390:1 [INFO] [stdout] | [INFO] [stdout] 390 | delegate_impl_to_norm!(u8); [INFO] [stdout] | -------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u8::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | delegate_impl_to_norm!(u16); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u16::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:391:1 [INFO] [stdout] | [INFO] [stdout] 391 | delegate_impl_to_norm!(u16); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u16::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:169:84 [INFO] [stdout] | [INFO] [stdout] 169 | ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:392:1 [INFO] [stdout] | [INFO] [stdout] 392 | delegate_impl_to_norm!(u32); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 169 - ::from(self).unwrap() / ::from(std::$Type::MAX).unwrap() [INFO] [stdout] 169 + ::from(self).unwrap() / ::from(u32::MAX).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/spectrum/macros.rs:175:70 [INFO] [stdout] | [INFO] [stdout] 175 | ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] ::: src/spectrum/mod.rs:392:1 [INFO] [stdout] | [INFO] [stdout] 392 | delegate_impl_to_norm!(u32); [INFO] [stdout] | --------------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: this warning originates in the macro `delegate_impl_to_norm` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 175 - ::from(f * ::from(std::$Type::MAX).unwrap()).unwrap() [INFO] [stdout] 175 + ::from(f * ::from(u32::MAX).unwrap()).unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:13 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:26 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:115:39 [INFO] [stdout] | [INFO] [stdout] 115 | s.x.clone(), u.x.clone(), f.x.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:13 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:26 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:116:39 [INFO] [stdout] | [INFO] [stdout] 116 | s.y.clone(), u.y.clone(), f.y.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.y` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:13 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `s.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:26 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `u.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `f32` which implements the `Copy` trait [INFO] [stdout] --> src/filming/perspective.rs:117:39 [INFO] [stdout] | [INFO] [stdout] 117 | s.z.clone(), u.z.clone(), f.z.clone(), Float::zero(), [INFO] [stdout] | ^^^^^^^^^^^ help: try removing the `clone` call: `f.z` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/sample/mod.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | unsafe fn evaluate_unsafe(&self, p: Point2f) -> Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/sample/naive.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if idx < self.nsample { [INFO] [stdout] 84 | | true [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | false [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `idx < self.nsample` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `isample` is used to index `buf` [INFO] [stdout] --> src/sample/strata.rs:176:32 [INFO] [stdout] | [INFO] [stdout] 176 | for isample in 0..nsample { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 176 - for isample in 0..nsample { [INFO] [stdout] 176 + for (isample, ) in buf.iter().enumerate().take(nsample) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `isample` is used to index `buf` [INFO] [stdout] --> src/sample/strata.rs:187:32 [INFO] [stdout] | [INFO] [stdout] 187 | for isample in 0..nsample { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 187 - for isample in 0..nsample { [INFO] [stdout] 187 + for (isample, ) in buf.iter().enumerate().take(nsample) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/sample/mod.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | unsafe fn evaluate_unsafe(&self, p: Point2f) -> Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this if-then-else expression returns a bool literal [INFO] [stdout] --> src/sample/naive.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | / if idx < self.nsample { [INFO] [stdout] 84 | | true [INFO] [stdout] 85 | | } else { [INFO] [stdout] 86 | | false [INFO] [stdout] 87 | | } [INFO] [stdout] | |_________^ help: you can reduce it to: `idx < self.nsample` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stdout] = note: `#[warn(clippy::needless_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `isample` is used to index `buf` [INFO] [stdout] --> src/sample/strata.rs:176:32 [INFO] [stdout] | [INFO] [stdout] 176 | for isample in 0..nsample { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 176 - for isample in 0..nsample { [INFO] [stdout] 176 + for (isample, ) in buf.iter().enumerate().take(nsample) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `isample` is used to index `buf` [INFO] [stdout] --> src/sample/strata.rs:187:32 [INFO] [stdout] | [INFO] [stdout] 187 | for isample in 0..nsample { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 187 - for isample in 0..nsample { [INFO] [stdout] 187 + for (isample, ) in buf.iter().enumerate().take(nsample) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Distribution1D` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/sample/distribution.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `Distribution1D` has a public `len` method, but no `is_empty` method [INFO] [stdout] --> src/sample/distribution.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | pub fn len(&self) -> usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stdout] = note: `#[warn(clippy::len_without_is_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/bxdf/microfacet.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 176 | let ret = if wo.z < 0. as Float { -wh } else { wh }; [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 177 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 176 ~ [INFO] [stdout] 177 ~ if wo.z < 0. as Float { -wh } else { wh } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bxdf/microfacet.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | w = w - 2.5 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w -= 2.5 as Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | p = 2.81022636e-08 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 319 - p = 2.81022636e-08 as Float; [INFO] [stdout] 319 + p = 2.810_226_4e-8 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | p = 3.43273939e-07 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 320 - p = 3.43273939e-07 as Float + p * w; [INFO] [stdout] 320 + p = 3.432_739_4e-7 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 322 | p = -4.39150654e-06 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 322 - p = -4.39150654e-06 as Float + p * w; [INFO] [stdout] 322 + p = -4.391_506_5e-6 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:324:14 [INFO] [stdout] | [INFO] [stdout] 324 | p = -0.00125372503 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 324 - p = -0.00125372503 as Float + p * w; [INFO] [stdout] 324 + p = -0.001_253_725 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:325:14 [INFO] [stdout] | [INFO] [stdout] 325 | p = -0.00417768164 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 325 - p = -0.00417768164 as Float + p * w; [INFO] [stdout] 325 + p = -0.004_177_681_6 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | p = 0.246640727 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 326 - p = 0.246640727 as Float + p * w; [INFO] [stdout] 326 + p = 0.246_640_73 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | p = 1.50140941 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 327 - p = 1.50140941 as Float + p * w; [INFO] [stdout] 327 + p = 1.501_409_4 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:330:14 [INFO] [stdout] | [INFO] [stdout] 330 | p = -0.000200214257 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 330 - p = -0.000200214257 as Float; [INFO] [stdout] 330 + p = -0.000_200_214_26 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | p = 0.000100950558 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 331 - p = 0.000100950558 as Float + p * w; [INFO] [stdout] 331 + p = 0.000_100_950_56 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:332:13 [INFO] [stdout] | [INFO] [stdout] 332 | p = 0.00134934322 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 332 - p = 0.00134934322 as Float + p * w; [INFO] [stdout] 332 + p = 0.001_349_343_2 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:333:14 [INFO] [stdout] | [INFO] [stdout] 333 | p = -0.00367342844 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 333 - p = -0.00367342844 as Float + p * w; [INFO] [stdout] 333 + p = -0.003_673_428_4 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:334:13 [INFO] [stdout] | [INFO] [stdout] 334 | p = 0.00573950773 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 334 - p = 0.00573950773 as Float + p * w; [INFO] [stdout] 334 + p = 0.005_739_507_7 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | p = 0.00943887047 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 336 - p = 0.00943887047 as Float + p * w; [INFO] [stdout] 336 + p = 0.009_438_870_5 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:337:13 [INFO] [stdout] | [INFO] [stdout] 337 | p = 1.00167406 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 337 - p = 1.00167406 as Float + p * w; [INFO] [stdout] 337 + p = 1.001_674 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | p = 2.83297682 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 338 - p = 2.83297682 as Float + p * w; [INFO] [stdout] 338 + p = 2.832_976_8 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 347 | const A1: Float = 0.254829592 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 347 - const A1: Float = 0.254829592 as Float; [INFO] [stdout] 347 + const A1: Float = 0.254_829_6 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:349:23 [INFO] [stdout] | [INFO] [stdout] 349 | const A3: Float = 1.421413741 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 349 - const A3: Float = 1.421413741 as Float; [INFO] [stdout] 349 + const A3: Float = 1.421_413_8 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:350:24 [INFO] [stdout] | [INFO] [stdout] 350 | const A4: Float = -1.453152027 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 350 - const A4: Float = -1.453152027 as Float; [INFO] [stdout] 350 + const A4: Float = -1.453_152_1 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:351:23 [INFO] [stdout] | [INFO] [stdout] 351 | const A5: Float = 1.061405429 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 351 - const A5: Float = 1.061405429 as Float; [INFO] [stdout] 351 + const A5: Float = 1.061_405_4 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/bxdf/microfacet.rs:177:9 [INFO] [stdout] | [INFO] [stdout] 176 | let ret = if wo.z < 0. as Float { -wh } else { wh }; [INFO] [stdout] | ---------------------------------------------------- unnecessary `let` binding [INFO] [stdout] 177 | ret [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 176 ~ [INFO] [stdout] 177 ~ if wo.z < 0. as Float { -wh } else { wh } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/bxdf/microfacet.rs:318:9 [INFO] [stdout] | [INFO] [stdout] 318 | w = w - 2.5 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `w -= 2.5 as Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:319:13 [INFO] [stdout] | [INFO] [stdout] 319 | p = 2.81022636e-08 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 319 - p = 2.81022636e-08 as Float; [INFO] [stdout] 319 + p = 2.810_226_4e-8 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:320:13 [INFO] [stdout] | [INFO] [stdout] 320 | p = 3.43273939e-07 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 320 - p = 3.43273939e-07 as Float + p * w; [INFO] [stdout] 320 + p = 3.432_739_4e-7 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:322:14 [INFO] [stdout] | [INFO] [stdout] 322 | p = -4.39150654e-06 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 322 - p = -4.39150654e-06 as Float + p * w; [INFO] [stdout] 322 + p = -4.391_506_5e-6 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:324:14 [INFO] [stdout] | [INFO] [stdout] 324 | p = -0.00125372503 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 324 - p = -0.00125372503 as Float + p * w; [INFO] [stdout] 324 + p = -0.001_253_725 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:325:14 [INFO] [stdout] | [INFO] [stdout] 325 | p = -0.00417768164 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 325 - p = -0.00417768164 as Float + p * w; [INFO] [stdout] 325 + p = -0.004_177_681_6 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:326:13 [INFO] [stdout] | [INFO] [stdout] 326 | p = 0.246640727 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 326 - p = 0.246640727 as Float + p * w; [INFO] [stdout] 326 + p = 0.246_640_73 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:327:13 [INFO] [stdout] | [INFO] [stdout] 327 | p = 1.50140941 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 327 - p = 1.50140941 as Float + p * w; [INFO] [stdout] 327 + p = 1.501_409_4 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:330:14 [INFO] [stdout] | [INFO] [stdout] 330 | p = -0.000200214257 as Float; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 330 - p = -0.000200214257 as Float; [INFO] [stdout] 330 + p = -0.000_200_214_26 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:331:13 [INFO] [stdout] | [INFO] [stdout] 331 | p = 0.000100950558 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 331 - p = 0.000100950558 as Float + p * w; [INFO] [stdout] 331 + p = 0.000_100_950_56 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:332:13 [INFO] [stdout] | [INFO] [stdout] 332 | p = 0.00134934322 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 332 - p = 0.00134934322 as Float + p * w; [INFO] [stdout] 332 + p = 0.001_349_343_2 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:333:14 [INFO] [stdout] | [INFO] [stdout] 333 | p = -0.00367342844 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 333 - p = -0.00367342844 as Float + p * w; [INFO] [stdout] 333 + p = -0.003_673_428_4 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:334:13 [INFO] [stdout] | [INFO] [stdout] 334 | p = 0.00573950773 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 334 - p = 0.00573950773 as Float + p * w; [INFO] [stdout] 334 + p = 0.005_739_507_7 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:336:13 [INFO] [stdout] | [INFO] [stdout] 336 | p = 0.00943887047 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 336 - p = 0.00943887047 as Float + p * w; [INFO] [stdout] 336 + p = 0.009_438_870_5 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:337:13 [INFO] [stdout] | [INFO] [stdout] 337 | p = 1.00167406 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 337 - p = 1.00167406 as Float + p * w; [INFO] [stdout] 337 + p = 1.001_674 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:338:13 [INFO] [stdout] | [INFO] [stdout] 338 | p = 2.83297682 as Float + p * w; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 338 - p = 2.83297682 as Float + p * w; [INFO] [stdout] 338 + p = 2.832_976_8 as Float + p * w; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:347:23 [INFO] [stdout] | [INFO] [stdout] 347 | const A1: Float = 0.254829592 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 347 - const A1: Float = 0.254829592 as Float; [INFO] [stdout] 347 + const A1: Float = 0.254_829_6 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:349:23 [INFO] [stdout] | [INFO] [stdout] 349 | const A3: Float = 1.421413741 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 349 - const A3: Float = 1.421413741 as Float; [INFO] [stdout] 349 + const A3: Float = 1.421_413_8 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:350:24 [INFO] [stdout] | [INFO] [stdout] 350 | const A4: Float = -1.453152027 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 350 - const A4: Float = -1.453152027 as Float; [INFO] [stdout] 350 + const A4: Float = -1.453_152_1 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: float has excessive precision [INFO] [stdout] --> src/bxdf/microfacet.rs:351:23 [INFO] [stdout] | [INFO] [stdout] 351 | const A5: Float = 1.061405429 as Float; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stdout] help: consider changing the type or truncating it to [INFO] [stdout] | [INFO] [stdout] 351 - const A5: Float = 1.061405429 as Float; [INFO] [stdout] 351 + const A5: Float = 1.061_405_4 as Float; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/material/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | /// [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/material/mod.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | &*self, si, dxy, alloc [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 36 - &*self, si, dxy, alloc [INFO] [stdout] 36 + self, si, dxy, alloc [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 36 | &**self, si, dxy, alloc [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SurfaceInteraction<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/material/mod.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | let mut sie = si.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*si` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty doc comment [INFO] [stdout] --> src/material/mod.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | /// [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider removing or filling it [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_docs [INFO] [stdout] = note: `#[warn(clippy::empty_docs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/material/mod.rs:36:13 [INFO] [stdout] | [INFO] [stdout] 36 | &*self, si, dxy, alloc [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 36 - &*self, si, dxy, alloc [INFO] [stdout] 36 + self, si, dxy, alloc [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 36 | &**self, si, dxy, alloc [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `SurfaceInteraction<'_>` which implements the `Copy` trait [INFO] [stdout] --> src/material/mod.rs:45:19 [INFO] [stdout] | [INFO] [stdout] 45 | let mut sie = si.clone(); [INFO] [stdout] | ^^^^^^^^^^ help: try dereferencing it: `*si` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/material/bsdf.rs:247:1 [INFO] [stdout] | [INFO] [stdout] 247 | / impl<'a> Default for BsdfSink<'a> { [INFO] [stdout] 248 | | fn default() -> BsdfSink<'a> { [INFO] [stdout] 249 | | BsdfSink{ [INFO] [stdout] 250 | | bxdfs: [None, None, None, None, None, None, None, None], [INFO] [stdout] ... | [INFO] [stdout] 254 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 242 + #[derive(Default)] [INFO] [stdout] 243 | struct BsdfSink<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/material/bsdf.rs:247:1 [INFO] [stdout] | [INFO] [stdout] 247 | / impl<'a> Default for BsdfSink<'a> { [INFO] [stdout] 248 | | fn default() -> BsdfSink<'a> { [INFO] [stdout] 249 | | BsdfSink{ [INFO] [stdout] 250 | | bxdfs: [None, None, None, None, None, None, None, None], [INFO] [stdout] ... | [INFO] [stdout] 254 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 242 + #[derive(Default)] [INFO] [stdout] 243 | struct BsdfSink<'a> { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/texturing/textures/image.rs:373:25 [INFO] [stdout] | [INFO] [stdout] 373 | (p.x % dx as isize).abs() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(p.x % dx as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/texturing/textures/image.rs:374:25 [INFO] [stdout] | [INFO] [stdout] 374 | (p.y % dy as isize).abs() as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(p.y % dy as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/texturing/textures/image.rs:373:25 [INFO] [stdout] | [INFO] [stdout] 373 | (p.x % dx as isize).abs() as usize, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(p.x % dx as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `isize::abs()` to usize [INFO] [stdout] --> src/texturing/textures/image.rs:374:25 [INFO] [stdout] | [INFO] [stdout] 374 | (p.y % dy as isize).abs() as usize [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `(p.y % dy as isize).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/texturing/textures/image.rs:571:15 [INFO] [stdout] | [INFO] [stdout] 571 | pix0.map2(&pix1, |a, b| a+b) [INFO] [stdout] | ^^^^^ help: change this to: `pix1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/texturing/textures/image.rs:571:15 [INFO] [stdout] | [INFO] [stdout] 571 | pix0.map2(&pix1, |a, b| a+b) [INFO] [stdout] | ^^^^^ help: change this to: `pix1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/renderer/pt.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / fn calculate_lighting( [INFO] [stdout] 56 | | mut ray: RayDifferential, [INFO] [stdout] 57 | | scene: &Scene, [INFO] [stdout] 58 | | sampler: &mut S, [INFO] [stdout] ... | [INFO] [stdout] 63 | | rr_threshold: Float [INFO] [stdout] 64 | | ) -> RGBSpectrumf { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/renderer/pt.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / loop { [INFO] [stdout] 71 | | if let Some(mut si) = scene.aggregate.intersect_ray(&mut ray.ray) { [INFO] [stdout] 72 | | if bounces == 0 || specular_bounce { [INFO] [stdout] 73 | | let term = si.le(-ray.ray.direction()); [INFO] [stdout] ... | [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(mut si) = scene.aggregate.intersect_ray(&mut ray.ray) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/renderer/pt.rs:55:1 [INFO] [stdout] | [INFO] [stdout] 55 | / fn calculate_lighting( [INFO] [stdout] 56 | | mut ray: RayDifferential, [INFO] [stdout] 57 | | scene: &Scene, [INFO] [stdout] 58 | | sampler: &mut S, [INFO] [stdout] ... | [INFO] [stdout] 63 | | rr_threshold: Float [INFO] [stdout] 64 | | ) -> RGBSpectrumf { [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this loop could be written as a `while let` loop [INFO] [stdout] --> src/renderer/pt.rs:70:5 [INFO] [stdout] | [INFO] [stdout] 70 | / loop { [INFO] [stdout] 71 | | if let Some(mut si) = scene.aggregate.intersect_ray(&mut ray.ray) { [INFO] [stdout] 72 | | if bounces == 0 || specular_bounce { [INFO] [stdout] 73 | | let term = si.le(-ray.ray.direction()); [INFO] [stdout] ... | [INFO] [stdout] 123 | | } [INFO] [stdout] | |_____^ help: try: `while let Some(mut si) = scene.aggregate.intersect_ray(&mut ray.ray) { .. }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stdout] = note: `#[warn(clippy::while_let_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/renderer/pt.rs:164:43 [INFO] [stdout] | [INFO] [stdout] 164 | tiles.par_iter_mut().for_each(|tile| render_tile(tile)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&render_tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/renderer/pt.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | if let Ok(_) = render_result.save(&self.filename) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if render_result.save(&self.filename).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `geometry::ray::ShearingTransformCache` does not permit being left uninitialized [INFO] [stdout] --> src/geometry/ray.rs:79:26 [INFO] [stdout] | [INFO] [stdout] 79 | stc: unsafe {mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: in this struct field [INFO] [stdout] --> src/geometry/ray.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | perm: Permulation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> src/geometry/ray.rs:184:1 [INFO] [stdout] | [INFO] [stdout] 184 | enum Permulation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/renderer/pt.rs:164:43 [INFO] [stdout] | [INFO] [stdout] 164 | tiles.par_iter_mut().for_each(|tile| render_tile(tile)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the function itself: `&render_tile` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/renderer/pt.rs:171:16 [INFO] [stdout] | [INFO] [stdout] 171 | if let Ok(_) = render_result.save(&self.filename) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if render_result.save(&self.filename).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/mod.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)>; [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/sphere.rs:231:22 [INFO] [stdout] | [INFO] [stdout] 231 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 231 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/triangle.rs:397:22 [INFO] [stdout] | [INFO] [stdout] 397 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 397 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/triangle.rs:514:22 [INFO] [stdout] | [INFO] [stdout] 514 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 514 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `geometry::ray::ShearingTransformCache` does not permit being left uninitialized [INFO] [stdout] --> src/geometry/ray.rs:79:26 [INFO] [stdout] | [INFO] [stdout] 79 | stc: unsafe {mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: in this struct field [INFO] [stdout] --> src/geometry/ray.rs:172:5 [INFO] [stdout] | [INFO] [stdout] 172 | perm: Permulation, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] note: enums with multiple inhabited variants have to be initialized to a variant [INFO] [stdout] --> src/geometry/ray.rs:184:1 [INFO] [stdout] | [INFO] [stdout] 184 | enum Permulation { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] = note: `#[warn(invalid_value)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/mod.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &mut RawRay) -> Option; [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &mut RawRay) -> Option>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/mod.rs:207:22 [INFO] [stdout] | [INFO] [stdout] 207 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 207 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/shape.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 52 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 54 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 73 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 173 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 192 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/mod.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)>; [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:287:22 [INFO] [stdout] | [INFO] [stdout] 287 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 287 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:316:22 [INFO] [stdout] | [INFO] [stdout] 316 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 316 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/sphere.rs:231:22 [INFO] [stdout] | [INFO] [stdout] 231 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 231 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/bvh.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/triangle.rs:397:22 [INFO] [stdout] | [INFO] [stdout] 397 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction)> { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 397 | fn intersect_ray(&self, ray: &RawRay) -> Option<(Float, SurfaceInteraction<'_>)> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `component::bvh::BuildNode<'_>` does not permit being left uninitialized [INFO] [stdout] --> src/component/bvh.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | mem::uninitialized() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: in this struct field [INFO] [stdout] --> src/component/bvh.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | bound: BBox3f, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] note: floats must be initialized (in this struct field) [INFO] [stdout] --> src/geometry/bbox.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub pmin: Point3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/shape/triangle.rs:514:22 [INFO] [stdout] | [INFO] [stdout] 514 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 514 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `geometry::bbox::BBox3` does not permit being left uninitialized [INFO] [stdout] --> src/component/bvh.rs:353:27 [INFO] [stdout] | [INFO] [stdout] 353 | bound: unsafe{mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: floats must be initialized (in this struct field) [INFO] [stdout] --> src/geometry/bbox.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub pmin: Point3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/mod.rs:31:22 [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &mut RawRay) -> Option; [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 31 | fn intersect_ray(&self, ray: &mut RawRay) -> Option>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/naive.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | fn intersect_ray(&self, min_ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 54 | fn intersect_ray(&self, min_ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/mod.rs:207:22 [INFO] [stdout] | [INFO] [stdout] 207 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 207 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/shape.rs:52:22 [INFO] [stdout] | [INFO] [stdout] 52 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 52 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:54:30 [INFO] [stdout] | [INFO] [stdout] 54 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 54 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 73 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:173:30 [INFO] [stdout] | [INFO] [stdout] 173 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 173 | default fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:192:22 [INFO] [stdout] | [INFO] [stdout] 192 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 192 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:287:22 [INFO] [stdout] | [INFO] [stdout] 287 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 287 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/transformed.rs:316:22 [INFO] [stdout] | [INFO] [stdout] 316 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 316 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/filming/film.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn spawn_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 104 | pub fn spawn_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/filming/film.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn spawn_flat_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 138 | pub fn spawn_flat_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/bvh.rs:97:22 [INFO] [stdout] | [INFO] [stdout] 97 | fn intersect_ray(&self, ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | fn intersect_ray(&self, ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `component::bvh::BuildNode<'_>` does not permit being left uninitialized [INFO] [stdout] --> src/component/bvh.rs:179:13 [INFO] [stdout] | [INFO] [stdout] 179 | mem::uninitialized() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: in this struct field [INFO] [stdout] --> src/component/bvh.rs:166:5 [INFO] [stdout] | [INFO] [stdout] 166 | bound: BBox3f, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] note: floats must be initialized (in this struct field) [INFO] [stdout] --> src/geometry/bbox.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub pmin: Point3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `geometry::bbox::BBox3` does not permit being left uninitialized [INFO] [stdout] --> src/component/bvh.rs:353:27 [INFO] [stdout] | [INFO] [stdout] 353 | bound: unsafe{mem::uninitialized()}, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] note: floats must be initialized (in this struct field) [INFO] [stdout] --> src/geometry/bbox.rs:235:5 [INFO] [stdout] | [INFO] [stdout] 235 | pub pmin: Point3, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:172:22 [INFO] [stdout] | [INFO] [stdout] 172 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/component/naive.rs:54:22 [INFO] [stdout] | [INFO] [stdout] 54 | fn intersect_ray(&self, min_ray: &mut RawRay) -> Option { [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 54 | fn intersect_ray(&self, min_ray: &mut RawRay) -> Option> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `cgmath::Point2` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:236:18 [INFO] [stdout] | [INFO] [stdout] 236 | vec![std::mem::uninitialized(); buf.len()] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/filters.rs:268:32 [INFO] [stdout] | [INFO] [stdout] 268 | buf: unsafe { vec![mem::uninitialized(); PREC_FILTER_SIZE] }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/filming/film.rs:104:27 [INFO] [stdout] | [INFO] [stdout] 104 | pub fn spawn_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 104 | pub fn spawn_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/filming/film.rs:138:32 [INFO] [stdout] | [INFO] [stdout] 138 | pub fn spawn_flat_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | ^^^^^ the lifetime is elided here ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 138 | pub fn spawn_flat_tiles(&self, nx: isize, ny: isize) -> Vec> [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:172:22 [INFO] [stdout] | [INFO] [stdout] 172 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `cgmath::Point2` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:183:22 [INFO] [stdout] | [INFO] [stdout] 183 | vec![std::mem::uninitialized(); nsample] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/strata.rs:236:18 [INFO] [stdout] | [INFO] [stdout] 236 | vec![std::mem::uninitialized(); buf.len()] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the type `f32` does not permit being left uninitialized [INFO] [stdout] --> src/sample/filters.rs:268:32 [INFO] [stdout] | [INFO] [stdout] 268 | buf: unsafe { vec![mem::uninitialized(); PREC_FILTER_SIZE] }, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | this code causes undefined behavior when executed [INFO] [stdout] | help: use `MaybeUninit` instead, and only call `assume_init` after initialization is done [INFO] [stdout] | [INFO] [stdout] = note: floats must be initialized [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/texturing/textures/image.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | (mem::transmute::(self.max_aniso)).hash(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 590 - (mem::transmute::(self.max_aniso)).hash(state); [INFO] [stdout] 590 + (f32::to_bits(self.max_aniso)).hash(state); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/texturing/textures/image.rs:591:13 [INFO] [stdout] | [INFO] [stdout] 591 | (mem::transmute::(self.scale)).hash(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 591 - (mem::transmute::(self.scale)).hash(state); [INFO] [stdout] 591 + (f32::to_bits(self.scale)).hash(state); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/texturing/textures/image.rs:590:13 [INFO] [stdout] | [INFO] [stdout] 590 | (mem::transmute::(self.max_aniso)).hash(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unnecessary_transmutes)]` on by default [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 590 - (mem::transmute::(self.max_aniso)).hash(state); [INFO] [stdout] 590 + (f32::to_bits(self.max_aniso)).hash(state); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary transmute [INFO] [stdout] --> src/texturing/textures/image.rs:591:13 [INFO] [stdout] | [INFO] [stdout] 591 | (mem::transmute::(self.scale)).hash(state); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] help: replace this with [INFO] [stdout] | [INFO] [stdout] 591 - (mem::transmute::(self.scale)).hash(state); [INFO] [stdout] 591 + (f32::to_bits(self.scale)).hash(state); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated function `rayon::initialize`: use `ThreadPoolBuilder::build_global` [INFO] [stdout] --> examples/arencli.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | rayon::initialize(rayon::Configuration::new().num_threads(threads)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated struct `rayon::Configuration`: Use `ThreadPoolBuilder` [INFO] [stdout] --> examples/arencli.rs:49:34 [INFO] [stdout] | [INFO] [stdout] 49 | rayon::initialize(rayon::Configuration::new().num_threads(threads)).unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:294:40 [INFO] [stdout] | [INFO] [stdout] 294 | rgbs: &mut HashMap>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 294 | rgbs: &mut HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:295:41 [INFO] [stdout] | [INFO] [stdout] 295 | grays: &mut HashMap>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 295 | grays: &mut HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:298:21 [INFO] [stdout] | [INFO] [stdout] 298 | ) -> Option> { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 298 | ) -> Option> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:393:44 [INFO] [stdout] | [INFO] [stdout] 393 | textures: &mut HashMap>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 393 | textures: &mut HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:395:21 [INFO] [stdout] | [INFO] [stdout] 395 | ) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 395 | ) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:449:44 [INFO] [stdout] | [INFO] [stdout] 449 | textures: &mut HashMap>>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 449 | textures: &mut HashMap>>, [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:451:21 [INFO] [stdout] | [INFO] [stdout] 451 | ) -> Option>> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 451 | ) -> Option>> { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:496:29 [INFO] [stdout] | [INFO] [stdout] 496 | fn to_arc(&self) -> Arc { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 496 | fn to_arc(&self) -> Arc { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:86:40 [INFO] [stdout] | [INFO] [stdout] 86 | let mut primitives: HashMap<_, Arc> = HashMap::new(); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 86 | let mut primitives: HashMap<_, Arc> = HashMap::new(); [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> examples/arencli.rs:136:33 [INFO] [stdout] | [INFO] [stdout] 136 | let sp: Arc = if let Some(transform) = *transform { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2015) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 136 | let sp: Arc = if let Some(transform) = *transform { [INFO] [stdout] | +++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/arencli.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | IOError(std::io::Error), [INFO] [stdout] | ------- ^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 66 - IOError(std::io::Error), [INFO] [stdout] 66 + IOError(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `0` is never read [INFO] [stdout] --> examples/arencli.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | DecodeError(serde_json::error::Error), [INFO] [stdout] | ----------- ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | field in this variant [INFO] [stdout] | [INFO] [stdout] = note: `ParsingError` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field [INFO] [stdout] | [INFO] [stdout] 67 - DecodeError(serde_json::error::Error), [INFO] [stdout] 67 + DecodeError(()), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `as_ref` does nothing [INFO] [stdout] --> examples/arencli.rs:48:39 [INFO] [stdout] | [INFO] [stdout] 48 | let threads = usize::from_str(threads.as_ref()).expect("Invalid input: thread needs to be a number"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `threads` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_asref [INFO] [stdout] = note: `#[warn(clippy::useless_asref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> examples/arencli.rs:72:62 [INFO] [stdout] | [INFO] [stdout] 72 | let mut file = std::fs::File::open(filename).map_err(|e| [INFO] [stdout] | ______________________________________________________________^ [INFO] [stdout] 73 | | ParsingError::IOError(e) [INFO] [stdout] | |____________________________________^ help: replace the closure with the tuple variant itself: `ParsingError::IOError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> examples/arencli.rs:76:55 [INFO] [stdout] | [INFO] [stdout] 76 | let _ = file.read_to_string(&mut buf).map_err(|e| [INFO] [stdout] | _______________________________________________________^ [INFO] [stdout] 77 | | ParsingError::IOError(e) [INFO] [stdout] | |____________________________________^ help: replace the closure with the tuple variant itself: `ParsingError::IOError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> examples/arencli.rs:81:75 [INFO] [stdout] | [INFO] [stdout] 81 | let scenedesc: SceneDesc = serde_json::from_str(buf.as_ref()).map_err(|e| [INFO] [stdout] | ___________________________________________________________________________^ [INFO] [stdout] 82 | | ParsingError::DecodeError(e) [INFO] [stdout] | |____________________________________^ help: replace the closure with the tuple variant itself: `ParsingError::DecodeError` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Sphere` which implements the `Copy` trait [INFO] [stdout] --> examples/arencli.rs:132:33 [INFO] [stdout] | [INFO] [stdout] 132 | ... s.clone(), material.clone(), lt [INFO] [stdout] | ^^^^^^^^^ help: try dereferencing it: `*s` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> examples/arencli.rs:218:1 [INFO] [stdout] | [INFO] [stdout] 218 | / enum ComponentDesc { [INFO] [stdout] 219 | | / Mesh{ [INFO] [stdout] 220 | | | filename: String, [INFO] [stdout] 221 | | | transform: Option, [INFO] [stdout] 222 | | | }, [INFO] [stdout] | | |_____- the second-largest variant contains at least 92 bytes [INFO] [stdout] 223 | | / Shaped{ [INFO] [stdout] 224 | | | shape: ShapeDesc, [INFO] [stdout] 225 | | | material: Named, [INFO] [stdout] 226 | | | light: Option>, [INFO] [stdout] 227 | | | transform: Option, [INFO] [stdout] 228 | | | }, [INFO] [stdout] | | |_____- the largest variant contains at least 524 bytes [INFO] [stdout] ... | [INFO] [stdout] 232 | | }, [INFO] [stdout] 233 | | } [INFO] [stdout] | |___^ the entire enum is at least 528 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 225 - material: Named, [INFO] [stdout] 225 + material: Box>, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `kdt` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:310:25 [INFO] [stdout] | [INFO] [stdout] 308 | if kdt.is_some() && sigmat.is_some() { [INFO] [stdout] | ------------- the check is happening here [INFO] [stdout] 309 | Some(Arc::new(MatteMaterial::new( [INFO] [stdout] 310 | kdt.unwrap(), sigmat.unwrap(), bumpt [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `sigmat` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:310:39 [INFO] [stdout] | [INFO] [stdout] 308 | if kdt.is_some() && sigmat.is_some() { [INFO] [stdout] | ---------------- the check is happening here [INFO] [stdout] 309 | Some(Arc::new(MatteMaterial::new( [INFO] [stdout] 310 | kdt.unwrap(), sigmat.unwrap(), bumpt [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `diffuse` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:327:25 [INFO] [stdout] | [INFO] [stdout] 325 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 326 | Some(Arc::new(GlassMaterial::new( [INFO] [stdout] 327 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `specular` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:327:43 [INFO] [stdout] | [INFO] [stdout] 325 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 326 | Some(Arc::new(GlassMaterial::new( [INFO] [stdout] 327 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `roughness` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:328:25 [INFO] [stdout] | [INFO] [stdout] 325 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 328 | roughness.unwrap(), eta, bump [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `diffuse` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:345:25 [INFO] [stdout] | [INFO] [stdout] 343 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 344 | Some(Arc::new(PlasticMaterial::new( [INFO] [stdout] 345 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `specular` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:345:43 [INFO] [stdout] | [INFO] [stdout] 343 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 344 | Some(Arc::new(PlasticMaterial::new( [INFO] [stdout] 345 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `roughness` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:346:25 [INFO] [stdout] | [INFO] [stdout] 343 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 346 | roughness.unwrap(), bump [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `diffuse` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:363:25 [INFO] [stdout] | [INFO] [stdout] 361 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 362 | Some(Arc::new(TranslucentMaterial::new( [INFO] [stdout] 363 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `specular` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:363:43 [INFO] [stdout] | [INFO] [stdout] 361 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 362 | Some(Arc::new(TranslucentMaterial::new( [INFO] [stdout] 363 | diffuse.unwrap(), specular.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `roughness` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:364:25 [INFO] [stdout] | [INFO] [stdout] 361 | if diffuse.is_some() && specular.is_some() && roughness.is_some() { [INFO] [stdout] | ------------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 364 | roughness.unwrap(), dissolve, bump [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ta` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:420:29 [INFO] [stdout] | [INFO] [stdout] 418 | if ta.is_some() && tb.is_some() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 419 | Some(Arc::new(ProductTexture{ [INFO] [stdout] 420 | t0: ta.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tb` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:421:29 [INFO] [stdout] | [INFO] [stdout] 418 | if ta.is_some() && tb.is_some() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 421 | t1: tb.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> examples/arencli.rs:399:13 [INFO] [stdout] | [INFO] [stdout] 399 | if self.value.is_none() { return None; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] = note: `#[warn(clippy::question_mark)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UVMapping` which implements the `Copy` trait [INFO] [stdout] --> examples/arencli.rs:406:59 [INFO] [stdout] | [INFO] [stdout] 406 | RGBImageTexture::new_as_arc(info.clone(), mapping.clone(), refs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ta` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:476:29 [INFO] [stdout] | [INFO] [stdout] 474 | if ta.is_some() && tb.is_some() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] 475 | Some(Arc::new(ProductTexture{ [INFO] [stdout] 476 | t0: ta.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `tb` after checking its variant with `is_some` [INFO] [stdout] --> examples/arencli.rs:477:29 [INFO] [stdout] | [INFO] [stdout] 474 | if ta.is_some() && tb.is_some() { [INFO] [stdout] | ------------ the check is happening here [INFO] [stdout] ... [INFO] [stdout] 477 | t1: tb.unwrap().clone(), [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this block may be rewritten with the `?` operator [INFO] [stdout] --> examples/arencli.rs:455:13 [INFO] [stdout] | [INFO] [stdout] 455 | if self.value.is_none() { return None; } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `self.value.as_ref()?;` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#question_mark [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `UVMapping` which implements the `Copy` trait [INFO] [stdout] --> examples/arencli.rs:462:60 [INFO] [stdout] | [INFO] [stdout] 462 | LumaImageTexture::new_as_arc(info.clone(), mapping.clone(), refs) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try dereferencing it: `*mapping` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 17.84s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: bitflags v0.7.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "24eb6189bdc34eabf48f724cbe08538cc616dfda4f33751f9fabe901289b169c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24eb6189bdc34eabf48f724cbe08538cc616dfda4f33751f9fabe901289b169c", kill_on_drop: false }` [INFO] [stdout] 24eb6189bdc34eabf48f724cbe08538cc616dfda4f33751f9fabe901289b169c