[INFO] fetching crate aograph 0.6.0... [INFO] linting aograph-0.6.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate aograph 0.6.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate aograph 0.6.0 [INFO] finished tweaking crates.io crate aograph 0.6.0 [INFO] tweaked toml for crates.io crate aograph 0.6.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate aograph 0.6.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate aograph 0.6.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded jsongraph v0.1.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fcc9e7a4ff73604ce4b17b5cc80e3ad221d1bb58ab4b52fe1fc6f16ea8e08a86 [INFO] running `Command { std: "docker" "start" "-a" "fcc9e7a4ff73604ce4b17b5cc80e3ad221d1bb58ab4b52fe1fc6f16ea8e08a86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fcc9e7a4ff73604ce4b17b5cc80e3ad221d1bb58ab4b52fe1fc6f16ea8e08a86", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fcc9e7a4ff73604ce4b17b5cc80e3ad221d1bb58ab4b52fe1fc6f16ea8e08a86", kill_on_drop: false }` [INFO] [stdout] fcc9e7a4ff73604ce4b17b5cc80e3ad221d1bb58ab4b52fe1fc6f16ea8e08a86 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d70a4121cffccea2eb8bda160201b4ef6f6aaec6f4ed04beda445a7044f5892c [INFO] running `Command { std: "docker" "start" "-a" "d70a4121cffccea2eb8bda160201b4ef6f6aaec6f4ed04beda445a7044f5892c", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.103 [INFO] [stderr] Compiling serde_core v1.0.228 [INFO] [stderr] Compiling quote v1.0.42 [INFO] [stderr] Checking foldhash v0.1.5 [INFO] [stderr] Checking fixedbitset v0.5.7 [INFO] [stderr] Checking hashbrown v0.15.5 [INFO] [stderr] Compiling syn v2.0.111 [INFO] [stderr] Checking indexmap v2.12.1 [INFO] [stderr] Checking serde_json v1.0.145 [INFO] [stderr] Checking petgraph v0.8.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking jsongraph v0.1.0 [INFO] [stderr] Checking aograph v0.6.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/convert.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / Ok(Graph::new( [INFO] [stdout] 55 | | nodes.into_iter(), [INFO] [stdout] 56 | | jgf_edges.into_iter().map(|e| (e.source, e.target)), [INFO] [stdout] 57 | | &goal, [INFO] [stdout] 58 | | )?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 54 ~ Graph::new( [INFO] [stdout] 55 | nodes.into_iter(), [INFO] [stdout] 56 | jgf_edges.into_iter().map(|e| (e.source, e.target)), [INFO] [stdout] 57 | &goal, [INFO] [stdout] 58 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/core.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | self.label.as_ref().map(|x| x.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.label.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if !it.next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AndSet` [INFO] [stdout] --> src/core.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | / pub fn new() -> Self { [INFO] [stdout] 468 | | AndSet { [INFO] [stdout] 469 | | set: IndexSet::new(), [INFO] [stdout] 470 | | } [INFO] [stdout] 471 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 465 + impl Default for AndSet { [INFO] [stdout] 466 + fn default() -> Self { [INFO] [stdout] 467 + Self::new() [INFO] [stdout] 468 + } [INFO] [stdout] 469 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrSet` [INFO] [stdout] --> src/core.rs:513:5 [INFO] [stdout] | [INFO] [stdout] 513 | / pub fn new() -> Self { [INFO] [stdout] 514 | | OrSet { [INFO] [stdout] 515 | | set: IndexSet::new(), [INFO] [stdout] 516 | | } [INFO] [stdout] 517 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 511 + impl Default for OrSet { [INFO] [stdout] 512 + fn default() -> Self { [INFO] [stdout] 513 + Self::new() [INFO] [stdout] 514 + } [INFO] [stdout] 515 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/convert.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | / Ok(Graph::new( [INFO] [stdout] 55 | | nodes.into_iter(), [INFO] [stdout] 56 | | jgf_edges.into_iter().map(|e| (e.source, e.target)), [INFO] [stdout] 57 | | &goal, [INFO] [stdout] 58 | | )?) [INFO] [stdout] | |___________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 54 ~ Graph::new( [INFO] [stdout] 55 | nodes.into_iter(), [INFO] [stdout] 56 | jgf_edges.into_iter().map(|e| (e.source, e.target)), [INFO] [stdout] 57 | &goal, [INFO] [stdout] 58 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `.as_ref().map(|x| x.as_str())` on an `Option` value [INFO] [stdout] --> src/core.rs:56:9 [INFO] [stdout] | [INFO] [stdout] 56 | self.label.as_ref().map(|x| x.as_str()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using as_deref: `self.label.as_deref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_as_ref_deref [INFO] [stdout] = note: `#[warn(clippy::option_as_ref_deref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/core.rs:188:16 [INFO] [stdout] | [INFO] [stdout] 188 | if !it.next().is_some() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `it.next().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AndSet` [INFO] [stdout] --> src/core.rs:467:5 [INFO] [stdout] | [INFO] [stdout] 467 | / pub fn new() -> Self { [INFO] [stdout] 468 | | AndSet { [INFO] [stdout] 469 | | set: IndexSet::new(), [INFO] [stdout] 470 | | } [INFO] [stdout] 471 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 465 + impl Default for AndSet { [INFO] [stdout] 466 + fn default() -> Self { [INFO] [stdout] 467 + Self::new() [INFO] [stdout] 468 + } [INFO] [stdout] 469 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `OrSet` [INFO] [stdout] --> src/core.rs:513:5 [INFO] [stdout] | [INFO] [stdout] 513 | / pub fn new() -> Self { [INFO] [stdout] 514 | | OrSet { [INFO] [stdout] 515 | | set: IndexSet::new(), [INFO] [stdout] 516 | | } [INFO] [stdout] 517 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 511 + impl Default for OrSet { [INFO] [stdout] 512 + fn default() -> Self { [INFO] [stdout] 513 + Self::new() [INFO] [stdout] 514 + } [INFO] [stdout] 515 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 14.61s [INFO] running `Command { std: "docker" "inspect" "d70a4121cffccea2eb8bda160201b4ef6f6aaec6f4ed04beda445a7044f5892c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d70a4121cffccea2eb8bda160201b4ef6f6aaec6f4ed04beda445a7044f5892c", kill_on_drop: false }` [INFO] [stdout] d70a4121cffccea2eb8bda160201b4ef6f6aaec6f4ed04beda445a7044f5892c