[INFO] fetching crate anya-security-core 0.3.1... [INFO] linting anya-security-core-0.3.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate anya-security-core 0.3.1 into /workspace/builds/worker-4-tc1/source [INFO] started tweaking crates.io crate anya-security-core 0.3.1 [INFO] removed 0 missing examples [INFO] finished tweaking crates.io crate anya-security-core 0.3.1 [INFO] tweaked toml for crates.io crate anya-security-core 0.3.1 written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate anya-security-core 0.3.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate anya-security-core 0.3.1 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded scroll_derive v0.12.1 [INFO] [stderr] Downloaded scroll v0.12.0 [INFO] [stderr] Downloaded goblin v0.8.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 40ffb6cbe4833af401a2598ab8655e7a4ca4af6ddca9291bb19be20115b04bd8 [INFO] running `Command { std: "docker" "start" "-a" "40ffb6cbe4833af401a2598ab8655e7a4ca4af6ddca9291bb19be20115b04bd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "40ffb6cbe4833af401a2598ab8655e7a4ca4af6ddca9291bb19be20115b04bd8", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "40ffb6cbe4833af401a2598ab8655e7a4ca4af6ddca9291bb19be20115b04bd8", kill_on_drop: false }` [INFO] [stdout] 40ffb6cbe4833af401a2598ab8655e7a4ca4af6ddca9291bb19be20115b04bd8 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 1c50a9a3e1f965d62eb83d1a60857789c095f90fc8b779ca48963f278ce4dfa2 [INFO] running `Command { std: "docker" "start" "-a" "1c50a9a3e1f965d62eb83d1a60857789c095f90fc8b779ca48963f278ce4dfa2", kill_on_drop: false }` [INFO] [stderr] Compiling zerocopy v0.8.39 [INFO] [stderr] Compiling portable-atomic v1.13.1 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking clap_builder v4.5.60 [INFO] [stderr] Checking winnow v0.7.14 [INFO] [stderr] Checking toml_write v0.1.2 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking regex-syntax v0.8.9 [INFO] [stderr] Checking plain v0.2.3 [INFO] [stderr] Checking number_prefix v0.4.0 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Checking md-5 v0.10.6 [INFO] [stderr] Checking tempfile v3.25.0 [INFO] [stderr] Checking indicatif v0.17.11 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Checking regex v1.12.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling zerocopy-derive v0.8.39 [INFO] [stderr] Compiling scroll_derive v0.12.1 [INFO] [stderr] Compiling clap_derive v4.5.55 [INFO] [stderr] Checking scroll v0.12.0 [INFO] [stderr] Checking goblin v0.8.2 [INFO] [stderr] Checking clap v4.5.60 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_spanned v0.6.9 [INFO] [stderr] Checking toml_datetime v0.6.11 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking toml_edit v0.22.27 [INFO] [stderr] Checking toml v0.8.23 [INFO] [stderr] Checking half v2.7.1 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking anya-security-core v0.3.1 (/opt/rustwide/workdir) [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:1097:17 [INFO] [stdout] | [INFO] [stdout] 1097 | assert!(32u8 >= 32 && 32u8 <= 126); // Space [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `32u8 >= 32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:1098:17 [INFO] [stdout] | [INFO] [stdout] 1098 | assert!(65u8 >= 32 && 65u8 <= 126); // 'A' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `65u8 >= 32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:1099:17 [INFO] [stdout] | [INFO] [stdout] 1099 | assert!(126u8 >= 32 && 126u8 <= 126); // '~' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `126u8 >= 32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/main.rs:1097:9 [INFO] [stdout] | [INFO] [stdout] 1097 | assert!(32u8 >= 32 && 32u8 <= 126); // Space [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/main.rs:1098:9 [INFO] [stdout] | [INFO] [stdout] 1098 | assert!(65u8 >= 32 && 65u8 <= 126); // 'A' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/main.rs:1099:9 [INFO] [stdout] | [INFO] [stdout] 1099 | assert!(126u8 >= 32 && 126u8 <= 126); // '~' [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/main.rs:1100:9 [INFO] [stdout] | [INFO] [stdout] 1100 | assert!(!(31u8 >= 32 && 31u8 <= 126)); // Below range [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/main.rs:1101:9 [INFO] [stdout] | [INFO] [stdout] 1101 | assert!(!(127u8 >= 32 && 127u8 <= 126)); // Above range [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/main.rs:1114:16 [INFO] [stdout] | [INFO] [stdout] 1114 | if byte >= 32 && byte <= 126 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(32..=126).contains(&byte)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/output.rs:333:9 [INFO] [stdout] | [INFO] [stdout] 333 | assert_eq!(parsed.aslr_enabled, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 333 - assert_eq!(parsed.aslr_enabled, true); [INFO] [stdout] 333 + assert!(parsed.aslr_enabled); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/output.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 334 | assert_eq!(parsed.dep_enabled, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 334 - assert_eq!(parsed.dep_enabled, false); [INFO] [stdout] 334 + assert!(!parsed.dep_enabled); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/lib.rs:493:9 [INFO] [stdout] | [INFO] [stdout] 493 | summary.total_files = 10; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `BatchSummary { total_files: 10, analysed: 8, failed: 2, duration: 4.0, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/lib.rs:492:9 [INFO] [stdout] | [INFO] [stdout] 492 | let mut summary = BatchSummary::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 18.64s [INFO] running `Command { std: "docker" "inspect" "1c50a9a3e1f965d62eb83d1a60857789c095f90fc8b779ca48963f278ce4dfa2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "1c50a9a3e1f965d62eb83d1a60857789c095f90fc8b779ca48963f278ce4dfa2", kill_on_drop: false }` [INFO] [stdout] 1c50a9a3e1f965d62eb83d1a60857789c095f90fc8b779ca48963f278ce4dfa2