[INFO] fetching crate any_terminal_size 0.1.21... [INFO] linting any_terminal_size-0.1.21 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate any_terminal_size 0.1.21 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate any_terminal_size 0.1.21 [INFO] finished tweaking crates.io crate any_terminal_size 0.1.21 [INFO] tweaked toml for crates.io crate any_terminal_size 0.1.21 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate any_terminal_size 0.1.21 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate any_terminal_size 0.1.21 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 56441b263096109fe2d84152ab9b09171f1bede08b8e397a37da60a304ebe519 [INFO] running `Command { std: "docker" "start" "-a" "56441b263096109fe2d84152ab9b09171f1bede08b8e397a37da60a304ebe519", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "56441b263096109fe2d84152ab9b09171f1bede08b8e397a37da60a304ebe519", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "56441b263096109fe2d84152ab9b09171f1bede08b8e397a37da60a304ebe519", kill_on_drop: false }` [INFO] [stdout] 56441b263096109fe2d84152ab9b09171f1bede08b8e397a37da60a304ebe519 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] dfecdfff8e72286c2b4be679bba157fd6249b8e7ad28391ce6be661714622c13 [INFO] running `Command { std: "docker" "start" "-a" "dfecdfff8e72286c2b4be679bba157fd6249b8e7ad28391ce6be661714622c13", kill_on_drop: false }` [INFO] [stderr] Compiling any_terminal_size v0.1.21 (/opt/rustwide/workdir) [INFO] [stderr] Checking terminal_size v0.1.17 [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return Ok(ppid); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Ok(ppid); [INFO] [stdout] 24 + Ok(ppid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | return Ok(ppid); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 24 - return Ok(ppid); [INFO] [stdout] 24 + Ok(ppid) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return None; [INFO] [stdout] 42 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return None; [INFO] [stdout] 42 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:54:8 [INFO] [stdout] | [INFO] [stdout] 54 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:61:8 [INFO] [stdout] | [INFO] [stdout] 61 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix/unix_impl.rs:65:5 [INFO] [stdout] | [INFO] [stdout] 65 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - return None; [INFO] [stdout] 65 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:70:8 [INFO] [stdout] | [INFO] [stdout] 70 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:74:8 [INFO] [stdout] | [INFO] [stdout] 74 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ppid_ret` after checking its variant with `is_err` [INFO] [stdout] --> src/unix/unix_impl.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 85 | if ppid_ret.is_err() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = ppid_ret` [INFO] [stdout] ... [INFO] [stdout] 88 | ppid = ppid_ret.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:78:8 [INFO] [stdout] | [INFO] [stdout] 78 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/unix/unix_impl.rs:92:12 [INFO] [stdout] | [INFO] [stdout] 92 | if !size.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `size.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `ppid_ret` after checking its variant with `is_err` [INFO] [stdout] --> src/unix/unix_impl.rs:88:20 [INFO] [stdout] | [INFO] [stdout] 85 | if ppid_ret.is_err() { [INFO] [stdout] | -------------------- help: try: `if let Ok() = ppid_ret` [INFO] [stdout] ... [INFO] [stdout] 88 | ppid = ppid_ret.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return unix_impl::terminal_size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return unix_impl::terminal_size(); [INFO] [stdout] 10 + unix_impl::terminal_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | return unix_impl::terminal_size(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 10 - return unix_impl::terminal_size(); [INFO] [stdout] 10 + unix_impl::terminal_size() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return unix_impl::terminal_size_of_process(process_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return unix_impl::terminal_size_of_process(process_id); [INFO] [stdout] 18 + unix_impl::terminal_size_of_process(process_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/unix.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | return unix_impl::terminal_size_of_process(process_id); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 18 - return unix_impl::terminal_size_of_process(process_id); [INFO] [stdout] 18 + unix_impl::terminal_size_of_process(process_id) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.24s [INFO] running `Command { std: "docker" "inspect" "dfecdfff8e72286c2b4be679bba157fd6249b8e7ad28391ce6be661714622c13", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "dfecdfff8e72286c2b4be679bba157fd6249b8e7ad28391ce6be661714622c13", kill_on_drop: false }` [INFO] [stdout] dfecdfff8e72286c2b4be679bba157fd6249b8e7ad28391ce6be661714622c13