[INFO] fetching crate alphadb 1.0.0-beta.37... [INFO] linting alphadb-1.0.0-beta.37 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate alphadb 1.0.0-beta.37 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate alphadb 1.0.0-beta.37 [INFO] finished tweaking crates.io crate alphadb 1.0.0-beta.37 [INFO] tweaked toml for crates.io crate alphadb 1.0.0-beta.37 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate alphadb 1.0.0-beta.37 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate alphadb 1.0.0-beta.37 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded saturating v0.1.0 [INFO] [stderr] Downloaded named_pipe v0.4.1 [INFO] [stderr] Downloaded thiserror-impl v1.0.65 [INFO] [stderr] Downloaded thiserror v1.0.65 [INFO] [stderr] Downloaded frunk_proc_macros v0.1.2 [INFO] [stderr] Downloaded rkyv_derive v0.7.44 [INFO] [stderr] Downloaded bufstream v0.1.4 [INFO] [stderr] Downloaded btoi v0.4.3 [INFO] [stderr] Downloaded derive_utils v0.14.1 [INFO] [stderr] Downloaded io-enum v1.1.3 [INFO] [stderr] Downloaded frunk_proc_macro_helpers v0.1.2 [INFO] [stderr] Downloaded frunk_core v0.4.2 [INFO] [stderr] Downloaded frunk v0.4.2 [INFO] [stderr] Downloaded borsh v1.3.1 [INFO] [stderr] Downloaded rkyv v0.7.44 [INFO] [stderr] Downloaded bigdecimal v0.4.7 [INFO] [stderr] Downloaded num-bigint v0.4.4 [INFO] [stderr] Downloaded mysql v25.0.1 [INFO] [stderr] Downloaded mysql_common v0.32.4 [INFO] [stderr] Downloaded rust_decimal v1.34.3 [INFO] [stderr] Downloaded darling_core v0.20.8 [INFO] [stderr] Downloaded darling v0.20.8 [INFO] [stderr] Downloaded borsh-derive v1.3.1 [INFO] [stderr] Downloaded darling_macro v0.20.8 [INFO] [stderr] Downloaded mysql-common-derive v0.31.2 [INFO] [stderr] Downloaded foldhash v0.1.3 [INFO] [stderr] Downloaded frunk_derives v0.4.2 [INFO] [stderr] Downloaded libz-sys v1.1.15 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] efd981b018067e19c1a3fb330b4df686a31c70980586fac46839e1bb9ec474ea [INFO] running `Command { std: "docker" "start" "-a" "efd981b018067e19c1a3fb330b4df686a31c70980586fac46839e1bb9ec474ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "efd981b018067e19c1a3fb330b4df686a31c70980586fac46839e1bb9ec474ea", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "efd981b018067e19c1a3fb330b4df686a31c70980586fac46839e1bb9ec474ea", kill_on_drop: false }` [INFO] [stdout] efd981b018067e19c1a3fb330b4df686a31c70980586fac46839e1bb9ec474ea [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] e9493b25077892586d96963d950ddb9b172311ac95723dae449340094183eb45 [INFO] running `Command { std: "docker" "start" "-a" "e9493b25077892586d96963d950ddb9b172311ac95723dae449340094183eb45", kill_on_drop: false }` [INFO] [stderr] warning: only one of `license` or `license-file` is necessary [INFO] [stderr] `license` should be used if the package license can be expressed with a standard SPDX expression. [INFO] [stderr] `license-file` should be used if the package uses a non-standard license. [INFO] [stderr] See https://doc.rust-lang.org/cargo/reference/manifest.html#the-license-and-license-file-fields for more information. [INFO] [stderr] Compiling crossbeam-utils v0.8.19 [INFO] [stderr] Compiling regex-syntax v0.8.2 [INFO] [stderr] Compiling memchr v2.7.1 [INFO] [stderr] Compiling serde v1.0.197 [INFO] [stderr] Compiling num-traits v0.2.18 [INFO] [stderr] Compiling num-bigint v0.4.4 [INFO] [stderr] Compiling frunk_core v0.4.2 [INFO] [stderr] Compiling bindgen v0.69.4 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling clang-sys v1.7.0 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Compiling either v1.10.0 [INFO] [stderr] Compiling toml_datetime v0.6.5 [INFO] [stderr] Compiling crc32fast v1.4.0 [INFO] [stderr] Compiling zstd-safe v7.2.1 [INFO] [stderr] Compiling cc v1.0.90 [INFO] [stderr] Compiling itertools v0.12.1 [INFO] [stderr] Compiling syn v2.0.52 [INFO] [stderr] Compiling toml_edit v0.21.1 [INFO] [stderr] Compiling subprocess v0.2.9 [INFO] [stderr] Compiling proc-macro-error-attr2 v2.0.0 [INFO] [stderr] Compiling nom v7.1.3 [INFO] [stderr] Compiling bigdecimal v0.4.7 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling serde_json v1.0.114 [INFO] [stderr] Checking bitflags v2.4.2 [INFO] [stderr] Compiling rust_decimal v1.34.3 [INFO] [stderr] Compiling openssl v0.10.64 [INFO] [stderr] Compiling cmake v0.1.50 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Compiling num-integer v0.1.46 [INFO] [stderr] Compiling regex-automata v0.4.6 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking foldhash v0.1.3 [INFO] [stderr] Checking arrayvec v0.7.4 [INFO] [stderr] Checking time v0.3.34 [INFO] [stderr] Compiling cexpr v0.6.0 [INFO] [stderr] Compiling openssl-sys v0.9.101 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Compiling libz-sys v1.1.15 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking btoi v0.4.3 [INFO] [stderr] Compiling proc-macro-crate v3.1.0 [INFO] [stderr] Checking flate2 v1.0.28 [INFO] [stderr] Compiling regex v1.10.3 [INFO] [stderr] Compiling native-tls v0.2.11 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking crossbeam-queue v0.3.11 [INFO] [stderr] Checking crossbeam-channel v0.5.12 [INFO] [stderr] Checking uuid v1.7.0 [INFO] [stderr] Checking saturating v0.1.0 [INFO] [stderr] Checking log v0.4.21 [INFO] [stderr] Compiling mysql v25.0.1 [INFO] [stderr] Checking base64 v0.22.1 [INFO] [stderr] Checking smallvec v1.13.1 [INFO] [stderr] Checking twox-hash v1.6.3 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking crossbeam v0.8.4 [INFO] [stderr] Checking url v2.5.0 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Checking bufstream v0.1.4 [INFO] [stderr] Checking pem v3.0.4 [INFO] [stderr] Compiling darling_core v0.20.8 [INFO] [stderr] Compiling frunk_proc_macro_helpers v0.1.2 [INFO] [stderr] Compiling proc-macro-error2 v2.0.1 [INFO] [stderr] Compiling derive_utils v0.14.1 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Compiling serde_derive v1.0.197 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Compiling frunk_proc_macros v0.1.2 [INFO] [stderr] Compiling frunk_derives v0.4.2 [INFO] [stderr] Compiling darling_macro v0.20.8 [INFO] [stderr] Compiling io-enum v1.1.3 [INFO] [stderr] Checking frunk v0.4.2 [INFO] [stderr] Compiling darling v0.20.8 [INFO] [stderr] Compiling mysql-common-derive v0.31.2 [INFO] [stderr] Checking zstd v0.13.2 [INFO] [stderr] Compiling mysql_common v0.32.4 [INFO] [stderr] Checking alphadb v1.0.0-beta.37 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `query::default_data::default_data` [INFO] [stdout] --> src/utils/consolidate/version_source.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | query::default_data::default_data, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `query::default_data::default_data` [INFO] [stdout] --> src/utils/consolidate/version_source.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | query::default_data::default_data, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `query` is never read [INFO] [stdout] --> src/query/column/definecolumn.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | let mut query = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version_number` [INFO] [stdout] --> src/version_source_verification.rs:140:77 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn createtable(&mut self, createtable: Value, version_output: &str, version_number: Option<&str>) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version_index` [INFO] [stdout] --> src/version_source_verification.rs:184:53 [INFO] [stdout] | [INFO] [stdout] 184 | ...altertable: Value, version_index: usize, version_output: &str, version_number: Option<&str>) -> Result<(), AlphaDBError> { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `object_is_empty` is never used [INFO] [stdout] --> src/verification/json.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn object_is_empty(object: &serde_json::Value, issues: &mut Vec, version_trace: Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `object_iter` is never used [INFO] [stdout] --> src/verification/json.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn object_iter<'a>(object: &'a serde_json::Value, issues: &mut Vec, version_trace: Vec) -> serde_jso... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 44 | ConnectError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - ConnectError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 44 + ConnectError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:45:44 [INFO] [stdout] | [INFO] [stdout] 45 | ConnectError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - ConnectError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 45 + ConnectError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return Ok(pool.get_conn()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Ok(pool.get_conn()?); [INFO] [stdout] 67 + Ok(pool.get_conn()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | InitError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - InitError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 52 + InitError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:53:41 [INFO] [stdout] | [INFO] [stdout] 53 | InitError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - InitError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 53 + InitError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(Init::Success); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(Init::Success); [INFO] [stdout] 97 + Ok(Init::Success) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/status.rs:54:45 [INFO] [stdout] | [INFO] [stdout] 54 | StatusError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - StatusError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 54 + StatusError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/status.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | StatusError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - StatusError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 55 + StatusError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fetched` after checking its variant with `is_some` [INFO] [stdout] --> src/methods/status.rs:92:58 [INFO] [stdout] | [INFO] [stdout] 91 | if fetched.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = fetched` [INFO] [stdout] 92 | let c = from_row::<(String, Option)>(fetched.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | UpdateQueriesError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - UpdateQueriesError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 63 + UpdateQueriesError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:64:51 [INFO] [stdout] | [INFO] [stdout] 64 | UpdateQueriesError::StatusError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - UpdateQueriesError::StatusError(_) => return Vec::new(), [INFO] [stdout] 64 + UpdateQueriesError::StatusError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:65:50 [INFO] [stdout] | [INFO] [stdout] 65 | UpdateQueriesError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - UpdateQueriesError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 65 + UpdateQueriesError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/methods/update_queries.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 159 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/methods/update_queries.rs:168:53 [INFO] [stdout] | [INFO] [stdout] 168 | let database_version_int = parse_version_number(&database_version.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `database_version.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/methods/update_queries.rs:186:30 [INFO] [stdout] | [INFO] [stdout] 186 | message: format!("Missing a version number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing a version number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/methods/update_queries.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | / if no_data == false { [INFO] [stdout] 228 | | if version_keys.contains(&&"default_data".to_string()) { [INFO] [stdout] 229 | | for table in object_iter(&version["default_data"])? { [INFO] [stdout] 230 | | for item in array_iter(&version["default_data"][table])? { [INFO] [stdout] ... | [INFO] [stdout] 235 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 227 ~ if no_data == false [INFO] [stdout] 228 ~ && version_keys.contains(&&"default_data".to_string()) { [INFO] [stdout] 229 | for table in object_iter(&version["default_data"])? { [INFO] [stdout] ... [INFO] [stdout] 233 | } [INFO] [stdout] 234 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/methods/update_queries.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 227 | if no_data == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!no_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | UpdateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - UpdateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 53 + UpdateError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update.rs:54:51 [INFO] [stdout] | [INFO] [stdout] 54 | UpdateError::UpdateQueriesError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - UpdateError::UpdateQueriesError(_) => return Vec::new(), [INFO] [stdout] 54 + UpdateError::UpdateQueriesError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/vacate.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | VacateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - VacateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 45 + VacateError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/vacate.rs:46:43 [INFO] [stdout] | [INFO] [stdout] 46 | VacateError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - VacateError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 46 + VacateError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/table/altertable.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return Ok(query); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return Ok(query); [INFO] [stdout] 203 + Ok(query) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:46:42 [INFO] [stdout] | [INFO] [stdout] 46 | let version_list = get_version_array(&version_source)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `version_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `c` is used as a loop counter [INFO] [stdout] --> src/query/table/altertable.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | for table in array_iter(&version_source["version"])? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (c, table) in array_iter(&version_source["version"])?.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | if exists_in_object(&table, "_id")? { [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:76:64 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(old_primary_key) = get_primary_key(&version_list, table_name, Some(version))? { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | let column_renames = get_column_renames(&version_list, old_primary_key, table_name, "ASC")?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 127 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:143:115 [INFO] [stdout] | [INFO] [stdout] 143 | ...ycolumn"][column] = consolidate_column(&version_list, column, table_name)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:149:28 [INFO] [stdout] | [INFO] [stdout] 149 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/query/table/altertable.rs:185:33 [INFO] [stdout] | [INFO] [stdout] 185 | query = format!("DROP PRIMARY KEY"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DROP PRIMARY KEY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/table/createtable.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(query + ") ENGINE = InnoDB;"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(query + ") ENGINE = InnoDB;"); [INFO] [stdout] 76 + Ok(query + ") ENGINE = InnoDB;") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/createtable.rs:37:56 [INFO] [stdout] | [INFO] [stdout] 37 | for (column_name, column_value) in get_json_object(&table_data)? { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/createtable.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if column_queries != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!column_queries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/query/table/createtable.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 42 | column_queries = format!("{}", column); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `column.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/createtable.rs:48:38 [INFO] [stdout] | [INFO] [stdout] 48 | let table_keys = get_object_keys(&table_data)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/column/definecolumn.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok(Some(query)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok(Some(query)); [INFO] [stdout] 144 + Ok(Some(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/query/column/definecolumn.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / if column_keys.iter().any(|&i| i == "null") { [INFO] [stdout] 51 | | if column_data["null"] == true { [INFO] [stdout] 52 | | null = true; [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ if column_keys.iter().any(|&i| i == "null") [INFO] [stdout] 51 ~ && column_data["null"] == true { [INFO] [stdout] 52 | null = true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/query/column/definecolumn.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | if !SUPPORTED_COLUMN_TYPES.iter().any(|&i| i == column_type) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `SUPPORTED_COLUMN_TYPES.contains(&column_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/column/modifycolumn.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return Ok(Some(query)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Ok(Some(query)); [INFO] [stdout] 47 + Ok(Some(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/default_data.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return Ok(Query { query: q, data: Some(values) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Ok(Query { query: q, data: Some(values) }); [INFO] [stdout] 57 + Ok(Query { query: q, data: Some(values) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / return AlphaDBError { [INFO] [stdout] 29 | | message: message.to_string(), [INFO] [stdout] 30 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 31 | | ..Default::default() [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ AlphaDBError { [INFO] [stdout] 29 + message: message.to_string(), [INFO] [stdout] 30 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 31 + ..Default::default() [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / return AlphaDBError { [INFO] [stdout] 39 | | message: format!("Missing required key '{key}'."), [INFO] [stdout] 40 | | error: "incomplete-version-object".to_string(), [INFO] [stdout] 41 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 42 | | ..Default::default() [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ AlphaDBError { [INFO] [stdout] 39 + message: format!("Missing required key '{key}'."), [INFO] [stdout] 40 + error: "incomplete-version-object".to_string(), [INFO] [stdout] 41 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 42 + ..Default::default() [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/error_messages.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / return AlphaDBError { [INFO] [stdout] 51 | | message: format!("Column attributes '{attribute1}' and '{attribute2}' are not compatible."), [INFO] [stdout] 52 | | error: "incompatible-version-attributes".to_string(), [INFO] [stdout] 53 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 54 | | ..Default::default() [INFO] [stdout] 55 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ AlphaDBError { [INFO] [stdout] 51 + message: format!("Column attributes '{attribute1}' and '{attribute2}' are not compatible."), [INFO] [stdout] 52 + error: "incompatible-version-attributes".to_string(), [INFO] [stdout] 53 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 54 + ..Default::default() [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/error_messages.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 54 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_number.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | Err(_) => Err(AlphaDBError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | message: format!("'{}' is not a valid version number", version_number), [INFO] [stdout] 35 | | error: "invalid-version-number".to_string(), [INFO] [stdout] 36 | | version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] ... | [INFO] [stdout] 39 | | .into()), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 33 ~ Err(_) => Err(AlphaDBError { [INFO] [stdout] 34 + message: format!("'{}' is not a valid version number", version_number), [INFO] [stdout] 35 + error: "invalid-version-number".to_string(), [INFO] [stdout] 36 + version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] 37 + ..Default::default() [INFO] [stdout] 38 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_number.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 56 | Err(_) => Err(AlphaDBError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 57 | | message: format!("'{}' is not a valid version number. It can not be parsed to an integer", version_number), [INFO] [stdout] 58 | | error: "invalid-version-number".to_string(), [INFO] [stdout] 59 | | version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] ... | [INFO] [stdout] 62 | | .into()), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 56 ~ Err(_) => Err(AlphaDBError { [INFO] [stdout] 57 + message: format!("'{}' is not a valid version number. It can not be parsed to an integer", version_number), [INFO] [stdout] 58 + error: "invalid-version-number".to_string(), [INFO] [stdout] 59 + version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] 60 + ..Default::default() [INFO] [stdout] 61 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/version_number.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn get_latest_version(versions: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - pub fn get_latest_version(versions: &Vec) -> Result { [INFO] [stdout] 76 + pub fn get_latest_version(versions: &[serde_json::Value]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils/version_number.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | message: format!("No version number specified"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No version number specified".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(primary_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(primary_key); [INFO] [stdout] 75 + Ok(primary_key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | let version_keys = version.as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version.as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | let createtables = version["createtable"].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["createtable"].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:44:34 [INFO] [stdout] | [INFO] [stdout] 44 | let table_keys = version["createtable"][table_name].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["createtable"][table_name].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:53:31 [INFO] [stdout] | [INFO] [stdout] 53 | let altertables = version["altertable"].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["altertable"].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:55:34 [INFO] [stdout] | [INFO] [stdout] 55 | let table_keys = version["altertable"][table_name].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["altertable"][table_name].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | / if table_keys.iter().any(|&p| p == "dropcolumn") { [INFO] [stdout] 63 | | if primary_key.is_some() { [INFO] [stdout] 64 | | for dropcol in version["altertable"][table_name]["dropcolumn"].as_array().unwrap() { [INFO] [stdout] 65 | | if dropcol.as_str() == primary_key { [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if table_keys.iter().any(|&p| p == "dropcolumn") [INFO] [stdout] 63 ~ && primary_key.is_some() { [INFO] [stdout] 64 | for dropcol in version["altertable"][table_name]["dropcolumn"].as_array().unwrap() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return Ok(column); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Ok(column); [INFO] [stdout] 118 + Ok(column) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if version.as_object().unwrap().keys().any(|k| k == "createtable") { [INFO] [stdout] 64 | | if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if version.as_object().unwrap().keys().any(|k| k == "createtable") [INFO] [stdout] 64 ~ && version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] ... [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 67 | | column[attr] = json!(version["createtable"][table_name][version_column_name][attr]); [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 64 ~ if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) [INFO] [stdout] 65 ~ && version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 67 | column[attr] = json!(version["createtable"][table_name][version_column_name][attr]); [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if version.as_object().unwrap().keys().any(|k| k == "altertable") { [INFO] [stdout] 75 | | if version["altertable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 76 | | // Modify column [INFO] [stdout] 77 | | if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") { [INFO] [stdout] ... | [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if version.as_object().unwrap().keys().any(|k| k == "altertable") [INFO] [stdout] 75 ~ && version["altertable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 76 | // Modify column [INFO] [stdout] ... [INFO] [stdout] 113 | } [INFO] [stdout] 114 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | / if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") { [INFO] [stdout] 78 | | if version["altertable"][table_name]["modifycolumn"] [INFO] [stdout] 79 | | .as_object() [INFO] [stdout] 80 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") [INFO] [stdout] 78 ~ && version["altertable"][table_name]["modifycolumn"] [INFO] [stdout] 79 | .as_object() [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "dropcolumn") { [INFO] [stdout] 101 | | ... if version["altertable"][table_name]["dropcolumn"].as_array().unwrap().iter().any(|m| m == version_column_name) { [INFO] [stdout] 102 | | ... column = json!({}); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "dropcolumn") [INFO] [stdout] 101 ~ && version["altertable"][table_name]["dropcolumn"].as_array().unwrap().iter().any(|m| m == version_column_name) { [INFO] [stdout] 102 | column = json!({}); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / ... if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "addcolumn") { [INFO] [stdout] 108 | | ... if version["altertable"][table_name]["addcolumn"].as_object().unwrap().keys().any(|m| m == version_column_name) { [INFO] [stdout] 109 | | ... for attr in version["altertable"][table_name]["addcolumn"][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 110 | | ... column[attr] = json!(version["altertable"][table_name]["addcolumn"][version_column_name][attr]); [INFO] [stdout] ... | [INFO] [stdout] 113 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "addcolumn") [INFO] [stdout] 108 ~ && version["altertable"][table_name]["addcolumn"].as_object().unwrap().keys().any(|m| m == version_column_name) { [INFO] [stdout] 109 | for attr in version["altertable"][table_name]["addcolumn"][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 110 | column[attr] = json!(version["altertable"][table_name]["addcolumn"][version_column_name][attr]); [INFO] [stdout] 111 | } [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | return Ok(rename_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return Ok(rename_data); [INFO] [stdout] 230 + Ok(rename_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Ok(false); [INFO] [stdout] 208 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / if version.as_object().unwrap().keys().any(|i| i == "altertable") { [INFO] [stdout] 147 | | if version["altertable"].as_object().unwrap().keys().any(|t| t == table_name) { [INFO] [stdout] 148 | | let v = parse_version_number(get_json_string(&version["_id"]).unwrap()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ if version.as_object().unwrap().keys().any(|i| i == "altertable") [INFO] [stdout] 147 ~ && version["altertable"].as_object().unwrap().keys().any(|t| t == table_name) { [INFO] [stdout] 148 | let v = parse_version_number(get_json_string(&version["_id"]).unwrap()).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | / if order == "DESC" { [INFO] [stdout] 152 | | if rename_data.iter().any(|r| r.rename_version <= v) { [INFO] [stdout] 153 | | return Ok(false); [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ if order == "DESC" [INFO] [stdout] 152 ~ && rename_data.iter().any(|r| r.rename_version <= v) { [INFO] [stdout] 153 | return Ok(false); [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | / if order == "ASC" { [INFO] [stdout] 157 | | if rename_data.iter().any(|r| r.rename_version >= v) { [INFO] [stdout] 158 | | return Ok(false); [INFO] [stdout] 159 | | } [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 156 ~ if order == "ASC" [INFO] [stdout] 157 ~ && rename_data.iter().any(|r| r.rename_version >= v) { [INFO] [stdout] 158 | return Ok(false); [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils/consolidate/column.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | let name: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 178 ~ [INFO] [stdout] 179 ~ let name: &str = if order == "DESC" { [INFO] [stdout] 180 ~ renamecolumn_keys[renamecolumn_values.into_iter().position(|n| n == column_name).unwrap()] [INFO] [stdout] 181 | } else { [INFO] [stdout] 182 ~ renamecolumn_values[renamecolumn_keys.into_iter().position(|n| n == column_name).unwrap()].as_str().unwrap() [INFO] [stdout] 183 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/table.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return Ok(table); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Ok(table); [INFO] [stdout] 73 + Ok(table) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / if exists_in_object(version, "createtable")? { [INFO] [stdout] 32 | | if exists_in_object(&version["createtable"], table_name)? { [INFO] [stdout] 33 | | let cols = get_object_keys(&version["createtable"][table_name])?; [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if exists_in_object(version, "createtable")? [INFO] [stdout] 32 ~ && exists_in_object(&version["createtable"], table_name)? { [INFO] [stdout] 33 | let cols = get_object_keys(&version["createtable"][table_name])?; [INFO] [stdout] ... [INFO] [stdout] 39 | } [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils/consolidate/table.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | if *col != "primary_key".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / if exists_in_object(version, "altertable")? { [INFO] [stdout] 45 | | if exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if exists_in_object(version, "altertable")? [INFO] [stdout] 45 ~ && exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] ... [INFO] [stdout] 52 | } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if exists_in_object(&version["altertable"], table_name)? [INFO] [stdout] 46 ~ && exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... [INFO] [stdout] 51 | } [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/consolidate/version_source.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | let methods = get_object_keys(&version)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/consolidate/version_source.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let latest_version = get_latest_version(&versions)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `versions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/consolidate/default_data.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn consolidate_default_data(version_list: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn consolidate_default_data(version_list: &Vec) -> Result { [INFO] [stdout] 21 + pub fn consolidate_default_data(version_list: &[Value]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/check.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if !table_check.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_check.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return "".to_string(); [INFO] [stdout] 59 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/errors.rs:45:48 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn get_version_trace_string(version_trace: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn get_version_trace_string(version_trace: &Vec) -> String { [INFO] [stdout] 45 + pub fn get_version_trace_string(version_trace: &[String]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/errors.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if version_trace.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!version_trace.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return self.message.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return self.message.clone(); [INFO] [stdout] 70 + self.message.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return self.error.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return self.error.clone(); [INFO] [stdout] 74 + self.error.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return self.version_trace.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return self.version_trace.clone(); [INFO] [stdout] 78 + self.version_trace.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/utils/errors.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / impl Default for AlphaDBError { [INFO] [stdout] 97 | | fn default() -> Self { [INFO] [stdout] 98 | | AlphaDBError { [INFO] [stdout] 99 | | message: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 22 + #[derive(Default)] [INFO] [stdout] 23 | pub struct AlphaDBError { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/json.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(obj.keys().into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `obj.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/json.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | Ok(obj.keys().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `obj.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/json.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return Ok(obj.keys().any(|k| k == key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(obj.keys().any(|k| k == key)); [INFO] [stdout] 95 + Ok(obj.keys().any(|k| k == key)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:120:87 [INFO] [stdout] | [INFO] [stdout] 120 | message: format!("The value {} could not be parsed as a string", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:142:85 [INFO] [stdout] | [INFO] [stdout] 142 | message: format!("The value '{}' could not be parsed as a string", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:163:84 [INFO] [stdout] | [INFO] [stdout] 163 | message: format!("The value {} could not be parsed as a boolean", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:210:93 [INFO] [stdout] | [INFO] [stdout] 210 | message: format!("The value {} could not be parsed as an integer", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `query` is never read [INFO] [stdout] --> src/query/column/definecolumn.rs:31:21 [INFO] [stdout] | [INFO] [stdout] 31 | let mut query = String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:216:89 [INFO] [stdout] | [INFO] [stdout] 216 | message: format!("The value {} could not be parsed as an integer", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:243:90 [INFO] [stdout] | [INFO] [stdout] 243 | message: format!("The value {} could not be parsed as a float", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:249:86 [INFO] [stdout] | [INFO] [stdout] 249 | message: format!("The value {} could not be parsed as a float", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/helpers.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok((db_name, connection)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok((db_name, connection)); [INFO] [stdout] 49 + Ok((db_name, connection)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/version_source.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return Ok(version_source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Ok(version_source); [INFO] [stdout] 27 + Ok(version_source) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_source.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(AlphaDBError { [INFO] [stdout] | ________________________^ [INFO] [stdout] 20 | | message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 21 | | ..Default::default() [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | .into()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 19 ~ return Err(AlphaDBError { [INFO] [stdout] 20 + message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 21 + ..Default::default() [INFO] [stdout] 22 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/version_source.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(versions); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(versions); [INFO] [stdout] 51 + Ok(versions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_source.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 44 | ... return Err(AlphaDBError { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | ... message: "Version information data not complete. Must contain 'version' and 'name'. Latest is the latest version number,... [INFO] [stdout] 46 | | ... ..Default::default() [INFO] [stdout] 47 | | ... }.into()); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 44 ~ return Err(AlphaDBError { [INFO] [stdout] 45 + message: "Version information data not complete. Must contain 'version' and 'name'. Latest is the latest version number, version is a JSON object containing the database structure and name is the database template name.".to_string(), [INFO] [stdout] 46 + ..Default::default() [INFO] [stdout] 47 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return false; [INFO] [stdout] 41 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Map::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Map::new(); [INFO] [stdout] 61 + Map::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return ""; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return ""; [INFO] [stdout] 81 + "" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return true; [INFO] [stdout] 101 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Vec::new(); [INFO] [stdout] 121 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | return EMPTY_MAP.keys(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return EMPTY_MAP.keys(); [INFO] [stdout] 143 + EMPTY_MAP.keys() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/verification/json.rs:136:92 [INFO] [stdout] | [INFO] [stdout] 136 | static EMPTY_MAP: LazyLock> = LazyLock::new(|| serde_json::Map::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `serde_json::Map::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return 0; [INFO] [stdout] 163 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/version_source_verification.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(AlphaDBError { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 45 | | message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 46 | | ..Default::default() [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | .into()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 44 ~ return Err(AlphaDBError { [INFO] [stdout] 45 + message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 46 + ..Default::default() [INFO] [stdout] 47 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version_source_verification.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - return Ok(()); [INFO] [stdout] 133 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version_source_verification.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | return Err(self.issues.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Err(self.issues.clone()); [INFO] [stdout] 135 + Err(self.issues.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | message: format!("Missing a version number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing a version number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:124:59 [INFO] [stdout] | [INFO] [stdout] 124 | ... version_trace: Vec::from([format!("{version_output}")]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `version_output.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:147:34 [INFO] [stdout] | [INFO] [stdout] 147 | message: format!("Does not contain any data"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain any data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:166:63 [INFO] [stdout] | [INFO] [stdout] 166 | ... version_trace: Vec::from([format!("{version_output}"), "createtable".to_string(), format!("table:{table}")]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `version_output.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:188:26 [INFO] [stdout] | [INFO] [stdout] 188 | message: format!("Does not contain any data"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain any data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/version_source_verification.rs:238:25 [INFO] [stdout] | [INFO] [stdout] 238 | let data_keys = data.as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `data.as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:250:26 [INFO] [stdout] | [INFO] [stdout] 250 | message: format!("Column attributes NULL and AUTO_INCREMENT are incompatible"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Column attributes NULL and AUTO_INCREMENT are incompatible".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/version_source_verification.rs:257:67 [INFO] [stdout] | [INFO] [stdout] 257 | if !data_keys.contains(&&String::from("recreate")) || data["recreate"].as_bool().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data["recreate"].as_bool().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:260:30 [INFO] [stdout] | [INFO] [stdout] 260 | message: format!("Does not contain a column type"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain a column type".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version_source_verification.rs:266:43 [INFO] [stdout] | [INFO] [stdout] 266 | ...f INCOMPATIBLE_W_AI.contains(&&data["type"].as_str().unwrap().to_lowercase().as_str()) && data_keys.contains(&&String::from("a_i... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&data["type"].as_str().unwrap().to_lowercase().as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version_source_verification.rs:275:47 [INFO] [stdout] | [INFO] [stdout] 275 | ...COMPATIBLE_W_UNIQUE.contains(&&data["type"].as_str().unwrap().to_lowercase().as_str()) && data_keys.contains(&&String::from("uni... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&data["type"].as_str().unwrap().to_lowercase().as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AlphaDB<'a>` [INFO] [stdout] --> src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> AlphaDB<'a> { [INFO] [stdout] 46 | | AlphaDB { connection: None, db_name: None, is_connected: false } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 40 + impl<'a> Default for AlphaDB<'a> { [INFO] [stdout] 41 + fn default() -> Self { [INFO] [stdout] 42 + Self::new() [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return init(db_name, connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return init(db_name, connection); [INFO] [stdout] 83 + init(db_name, connection) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return status(db_name, connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return status(db_name, connection); [INFO] [stdout] 95 + status(db_name, connection) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return update_queries(db_name, connection, version_source, update_to_version, no_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return update_queries(db_name, connection, version_source, update_to_version, no_data); [INFO] [stdout] 112 + update_queries(db_name, connection, version_source, update_to_version, no_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return update( [INFO] [stdout] 139 | | db_name, [INFO] [stdout] 140 | | connection, [INFO] [stdout] 141 | | version_source, [INFO] [stdout] ... | [INFO] [stdout] 145 | | allowed_error_priority, [INFO] [stdout] 146 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ update( [INFO] [stdout] 139 + db_name, [INFO] [stdout] 140 + connection, [INFO] [stdout] 141 + version_source, [INFO] [stdout] 142 + update_to_version, [INFO] [stdout] 143 + no_data, [INFO] [stdout] 144 + verify, [INFO] [stdout] 145 + allowed_error_priority, [INFO] [stdout] 146 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version_number` [INFO] [stdout] --> src/version_source_verification.rs:140:77 [INFO] [stdout] | [INFO] [stdout] 140 | pub fn createtable(&mut self, createtable: Value, version_output: &str, version_number: Option<&str>) { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version_number` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `version_index` [INFO] [stdout] --> src/version_source_verification.rs:184:53 [INFO] [stdout] | [INFO] [stdout] 184 | ...altertable: Value, version_index: usize, version_output: &str, version_number: Option<&str>) -> Result<(), AlphaDBError> { [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_version_index` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `object_is_empty` is never used [INFO] [stdout] --> src/verification/json.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | pub fn object_is_empty(object: &serde_json::Value, issues: &mut Vec, version_trace: Vec) -> bool { [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `object_iter` is never used [INFO] [stdout] --> src/verification/json.rs:135:8 [INFO] [stdout] | [INFO] [stdout] 135 | pub fn object_iter<'a>(object: &'a serde_json::Value, issues: &mut Vec, version_trace: Vec) -> serde_jso... [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:44:46 [INFO] [stdout] | [INFO] [stdout] 44 | ConnectError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 44 - ConnectError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 44 + ConnectError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:45:44 [INFO] [stdout] | [INFO] [stdout] 45 | ConnectError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - ConnectError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 45 + ConnectError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/connect.rs:67:5 [INFO] [stdout] | [INFO] [stdout] 67 | return Ok(pool.get_conn()?); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Ok(pool.get_conn()?); [INFO] [stdout] 67 + Ok(pool.get_conn()?) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:52:43 [INFO] [stdout] | [INFO] [stdout] 52 | InitError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 52 - InitError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 52 + InitError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:53:41 [INFO] [stdout] | [INFO] [stdout] 53 | InitError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - InitError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 53 + InitError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/init.rs:97:5 [INFO] [stdout] | [INFO] [stdout] 97 | return Ok(Init::Success); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 97 - return Ok(Init::Success); [INFO] [stdout] 97 + Ok(Init::Success) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/status.rs:54:45 [INFO] [stdout] | [INFO] [stdout] 54 | StatusError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - StatusError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 54 + StatusError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/status.rs:55:43 [INFO] [stdout] | [INFO] [stdout] 55 | StatusError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 55 - StatusError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 55 + StatusError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `fetched` after checking its variant with `is_some` [INFO] [stdout] --> src/methods/status.rs:92:58 [INFO] [stdout] | [INFO] [stdout] 91 | if fetched.is_some() { [INFO] [stdout] | -------------------- help: try: `if let Some() = fetched` [INFO] [stdout] 92 | let c = from_row::<(String, Option)>(fetched.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:63:52 [INFO] [stdout] | [INFO] [stdout] 63 | UpdateQueriesError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 63 - UpdateQueriesError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 63 + UpdateQueriesError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:64:51 [INFO] [stdout] | [INFO] [stdout] 64 | UpdateQueriesError::StatusError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 64 - UpdateQueriesError::StatusError(_) => return Vec::new(), [INFO] [stdout] 64 + UpdateQueriesError::StatusError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update_queries.rs:65:50 [INFO] [stdout] | [INFO] [stdout] 65 | UpdateQueriesError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 65 - UpdateQueriesError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 65 + UpdateQueriesError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/methods/update_queries.rs:159:23 [INFO] [stdout] | [INFO] [stdout] 159 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] = note: `#[warn(clippy::needless_update)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/methods/update_queries.rs:168:53 [INFO] [stdout] | [INFO] [stdout] 168 | let database_version_int = parse_version_number(&database_version.as_str())?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `database_version.as_str()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/methods/update_queries.rs:186:30 [INFO] [stdout] | [INFO] [stdout] 186 | message: format!("Missing a version number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing a version number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/methods/update_queries.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | / if no_data == false { [INFO] [stdout] 228 | | if version_keys.contains(&&"default_data".to_string()) { [INFO] [stdout] 229 | | for table in object_iter(&version["default_data"])? { [INFO] [stdout] 230 | | for item in array_iter(&version["default_data"][table])? { [INFO] [stdout] ... | [INFO] [stdout] 235 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 227 ~ if no_data == false [INFO] [stdout] 228 ~ && version_keys.contains(&&"default_data".to_string()) { [INFO] [stdout] 229 | for table in object_iter(&version["default_data"])? { [INFO] [stdout] ... [INFO] [stdout] 233 | } [INFO] [stdout] 234 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against false can be replaced by a negation [INFO] [stdout] --> src/methods/update_queries.rs:227:12 [INFO] [stdout] | [INFO] [stdout] 227 | if no_data == false { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: try: `!no_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update.rs:53:45 [INFO] [stdout] | [INFO] [stdout] 53 | UpdateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 53 - UpdateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 53 + UpdateError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/update.rs:54:51 [INFO] [stdout] | [INFO] [stdout] 54 | UpdateError::UpdateQueriesError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 54 - UpdateError::UpdateQueriesError(_) => return Vec::new(), [INFO] [stdout] 54 + UpdateError::UpdateQueriesError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/vacate.rs:45:45 [INFO] [stdout] | [INFO] [stdout] 45 | VacateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 45 - VacateError::AlphaDbError(e) => return e.version_trace.clone(), [INFO] [stdout] 45 + VacateError::AlphaDbError(e) => e.version_trace.clone(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/methods/vacate.rs:46:43 [INFO] [stdout] | [INFO] [stdout] 46 | VacateError::MySqlError(_) => return Vec::new(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - VacateError::MySqlError(_) => return Vec::new(), [INFO] [stdout] 46 + VacateError::MySqlError(_) => Vec::new(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/table/altertable.rs:203:5 [INFO] [stdout] | [INFO] [stdout] 203 | return Ok(query); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 203 - return Ok(query); [INFO] [stdout] 203 + Ok(query) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:46:42 [INFO] [stdout] | [INFO] [stdout] 46 | let version_list = get_version_array(&version_source)?; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `version_source` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `c` is used as a loop counter [INFO] [stdout] --> src/query/table/altertable.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | for table in array_iter(&version_source["version"])? { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (c, table) in array_iter(&version_source["version"])?.iter().enumerate()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:50:29 [INFO] [stdout] | [INFO] [stdout] 50 | if exists_in_object(&table, "_id")? { [INFO] [stdout] | ^^^^^^ help: change this to: `table` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:76:64 [INFO] [stdout] | [INFO] [stdout] 76 | if let Some(old_primary_key) = get_primary_key(&version_list, table_name, Some(version))? { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:77:61 [INFO] [stdout] | [INFO] [stdout] 77 | let column_renames = get_column_renames(&version_list, old_primary_key, table_name, "ASC")?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:113:24 [INFO] [stdout] | [INFO] [stdout] 113 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:127:28 [INFO] [stdout] | [INFO] [stdout] 127 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/altertable.rs:143:115 [INFO] [stdout] | [INFO] [stdout] 143 | ...ycolumn"][column] = consolidate_column(&version_list, column, table_name)?; [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `version_list` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:149:28 [INFO] [stdout] | [INFO] [stdout] 149 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:162:24 [INFO] [stdout] | [INFO] [stdout] 162 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/altertable.rs:184:24 [INFO] [stdout] | [INFO] [stdout] 184 | if query == "" { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `query.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/query/table/altertable.rs:185:33 [INFO] [stdout] | [INFO] [stdout] 185 | query = format!("DROP PRIMARY KEY"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"DROP PRIMARY KEY".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/table/createtable.rs:76:5 [INFO] [stdout] | [INFO] [stdout] 76 | return Ok(query + ") ENGINE = InnoDB;"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 76 - return Ok(query + ") ENGINE = InnoDB;"); [INFO] [stdout] 76 + Ok(query + ") ENGINE = InnoDB;") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/createtable.rs:37:56 [INFO] [stdout] | [INFO] [stdout] 37 | for (column_name, column_value) in get_json_object(&table_data)? { [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> src/query/table/createtable.rs:39:16 [INFO] [stdout] | [INFO] [stdout] 39 | if column_queries != "" { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!column_queries.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/query/table/createtable.rs:42:34 [INFO] [stdout] | [INFO] [stdout] 42 | column_queries = format!("{}", column); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `column.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/query/table/createtable.rs:48:38 [INFO] [stdout] | [INFO] [stdout] 48 | let table_keys = get_object_keys(&table_data)?; [INFO] [stdout] | ^^^^^^^^^^^ help: change this to: `table_data` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/column/definecolumn.rs:144:5 [INFO] [stdout] | [INFO] [stdout] 144 | return Ok(Some(query)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 144 - return Ok(Some(query)); [INFO] [stdout] 144 + Ok(Some(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/query/column/definecolumn.rs:50:9 [INFO] [stdout] | [INFO] [stdout] 50 | / if column_keys.iter().any(|&i| i == "null") { [INFO] [stdout] 51 | | if column_data["null"] == true { [INFO] [stdout] 52 | | null = true; [INFO] [stdout] 53 | | } [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 50 ~ if column_keys.iter().any(|&i| i == "null") [INFO] [stdout] 51 ~ && column_data["null"] == true { [INFO] [stdout] 52 | null = true; [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `contains()` instead of `iter().any()` is more efficient [INFO] [stdout] --> src/query/column/definecolumn.rs:102:13 [INFO] [stdout] | [INFO] [stdout] 102 | if !SUPPORTED_COLUMN_TYPES.iter().any(|&i| i == column_type) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `SUPPORTED_COLUMN_TYPES.contains(&column_type)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_contains [INFO] [stdout] = note: `#[warn(clippy::manual_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/column/modifycolumn.rs:47:5 [INFO] [stdout] | [INFO] [stdout] 47 | return Ok(Some(query)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 47 - return Ok(Some(query)); [INFO] [stdout] 47 + Ok(Some(query)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/query/default_data.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | return Ok(Query { query: q, data: Some(values) }); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 57 - return Ok(Query { query: q, data: Some(values) }); [INFO] [stdout] 57 + Ok(Query { query: q, data: Some(values) }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | / return AlphaDBError { [INFO] [stdout] 29 | | message: message.to_string(), [INFO] [stdout] 30 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 31 | | ..Default::default() [INFO] [stdout] 32 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 28 ~ AlphaDBError { [INFO] [stdout] 29 + message: message.to_string(), [INFO] [stdout] 30 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 31 + ..Default::default() [INFO] [stdout] 32 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:38:5 [INFO] [stdout] | [INFO] [stdout] 38 | / return AlphaDBError { [INFO] [stdout] 39 | | message: format!("Missing required key '{key}'."), [INFO] [stdout] 40 | | error: "incomplete-version-object".to_string(), [INFO] [stdout] 41 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 42 | | ..Default::default() [INFO] [stdout] 43 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 38 ~ AlphaDBError { [INFO] [stdout] 39 + message: format!("Missing required key '{key}'."), [INFO] [stdout] 40 + error: "incomplete-version-object".to_string(), [INFO] [stdout] 41 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 42 + ..Default::default() [INFO] [stdout] 43 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/error_messages.rs:42:11 [INFO] [stdout] | [INFO] [stdout] 42 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/error_messages.rs:50:5 [INFO] [stdout] | [INFO] [stdout] 50 | / return AlphaDBError { [INFO] [stdout] 51 | | message: format!("Column attributes '{attribute1}' and '{attribute2}' are not compatible."), [INFO] [stdout] 52 | | error: "incompatible-version-attributes".to_string(), [INFO] [stdout] 53 | | version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 54 | | ..Default::default() [INFO] [stdout] 55 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 50 ~ AlphaDBError { [INFO] [stdout] 51 + message: format!("Column attributes '{attribute1}' and '{attribute2}' are not compatible."), [INFO] [stdout] 52 + error: "incompatible-version-attributes".to_string(), [INFO] [stdout] 53 + version_trace: version_trace.iter().map(|&s| s.to_string()).collect(), [INFO] [stdout] 54 + ..Default::default() [INFO] [stdout] 55 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/error_messages.rs:54:11 [INFO] [stdout] | [INFO] [stdout] 54 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_number.rs:33:23 [INFO] [stdout] | [INFO] [stdout] 33 | Err(_) => Err(AlphaDBError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 34 | | message: format!("'{}' is not a valid version number", version_number), [INFO] [stdout] 35 | | error: "invalid-version-number".to_string(), [INFO] [stdout] 36 | | version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] ... | [INFO] [stdout] 39 | | .into()), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 33 ~ Err(_) => Err(AlphaDBError { [INFO] [stdout] 34 + message: format!("'{}' is not a valid version number", version_number), [INFO] [stdout] 35 + error: "invalid-version-number".to_string(), [INFO] [stdout] 36 + version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] 37 + ..Default::default() [INFO] [stdout] 38 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_number.rs:56:23 [INFO] [stdout] | [INFO] [stdout] 56 | Err(_) => Err(AlphaDBError { [INFO] [stdout] | _______________________^ [INFO] [stdout] 57 | | message: format!("'{}' is not a valid version number. It can not be parsed to an integer", version_number), [INFO] [stdout] 58 | | error: "invalid-version-number".to_string(), [INFO] [stdout] 59 | | version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] ... | [INFO] [stdout] 62 | | .into()), [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 56 ~ Err(_) => Err(AlphaDBError { [INFO] [stdout] 57 + message: format!("'{}' is not a valid version number. It can not be parsed to an integer", version_number), [INFO] [stdout] 58 + error: "invalid-version-number".to_string(), [INFO] [stdout] 59 + version_trace: Vec::from([version_number.to_string()]), [INFO] [stdout] 60 + ..Default::default() [INFO] [stdout] 61 ~ }), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/version_number.rs:76:37 [INFO] [stdout] | [INFO] [stdout] 76 | pub fn get_latest_version(versions: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 76 - pub fn get_latest_version(versions: &Vec) -> Result { [INFO] [stdout] 76 + pub fn get_latest_version(versions: &[serde_json::Value]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct update has no effect, all the fields in the struct have already been specified [INFO] [stdout] --> src/utils/version_number.rs:83:15 [INFO] [stdout] | [INFO] [stdout] 83 | ..Default::default() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_update [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/utils/version_number.rs:80:22 [INFO] [stdout] | [INFO] [stdout] 80 | message: format!("No version number specified"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"No version number specified".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return Ok(primary_key); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Ok(primary_key); [INFO] [stdout] 75 + Ok(primary_key) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:39:28 [INFO] [stdout] | [INFO] [stdout] 39 | let version_keys = version.as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version.as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:42:32 [INFO] [stdout] | [INFO] [stdout] 42 | let createtables = version["createtable"].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["createtable"].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:44:34 [INFO] [stdout] | [INFO] [stdout] 44 | let table_keys = version["createtable"][table_name].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["createtable"][table_name].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:53:31 [INFO] [stdout] | [INFO] [stdout] 53 | let altertables = version["altertable"].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["altertable"].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:55:34 [INFO] [stdout] | [INFO] [stdout] 55 | let table_keys = version["altertable"][table_name].as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `version["altertable"][table_name].as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:62:17 [INFO] [stdout] | [INFO] [stdout] 62 | / if table_keys.iter().any(|&p| p == "dropcolumn") { [INFO] [stdout] 63 | | if primary_key.is_some() { [INFO] [stdout] 64 | | for dropcol in version["altertable"][table_name]["dropcolumn"].as_array().unwrap() { [INFO] [stdout] 65 | | if dropcol.as_str() == primary_key { [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 62 ~ if table_keys.iter().any(|&p| p == "dropcolumn") [INFO] [stdout] 63 ~ && primary_key.is_some() { [INFO] [stdout] 64 | for dropcol in version["altertable"][table_name]["dropcolumn"].as_array().unwrap() { [INFO] [stdout] ... [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:95:75 [INFO] [stdout] | [INFO] [stdout] 95 | assert_eq!(get_primary_key(get_version_array(&versions).unwrap(), &"table".to_string(), None).unwrap(), Some("col")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"table"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:116:75 [INFO] [stdout] | [INFO] [stdout] 116 | assert_eq!(get_primary_key(get_version_array(&versions).unwrap(), &"table".to_string(), None).unwrap(), Some("other_col")); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"table"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_string` [INFO] [stdout] --> src/utils/consolidate/primary_key.rs:137:75 [INFO] [stdout] | [INFO] [stdout] 137 | assert_eq!(get_primary_key(get_version_array(&versions).unwrap(), &"table".to_string(), None).unwrap(), None) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: use: `"table"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:118:5 [INFO] [stdout] | [INFO] [stdout] 118 | return Ok(column); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 118 - return Ok(column); [INFO] [stdout] 118 + Ok(column) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | / if version.as_object().unwrap().keys().any(|k| k == "createtable") { [INFO] [stdout] 64 | | if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] ... | [INFO] [stdout] 71 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 63 ~ if version.as_object().unwrap().keys().any(|k| k == "createtable") [INFO] [stdout] 64 ~ && version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] ... [INFO] [stdout] 69 | } [INFO] [stdout] 70 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 65 | | if version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 67 | | column[attr] = json!(version["createtable"][table_name][version_column_name][attr]); [INFO] [stdout] ... | [INFO] [stdout] 70 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 64 ~ if version["createtable"].as_object().unwrap().keys().any(|c| c == table_name) [INFO] [stdout] 65 ~ && version["createtable"][table_name].as_object().unwrap().keys().any(|t| t == version_column_name) { [INFO] [stdout] 66 | for attr in version["createtable"][table_name][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 67 | column[attr] = json!(version["createtable"][table_name][version_column_name][attr]); [INFO] [stdout] 68 | } [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / if version.as_object().unwrap().keys().any(|k| k == "altertable") { [INFO] [stdout] 75 | | if version["altertable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 76 | | // Modify column [INFO] [stdout] 77 | | if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") { [INFO] [stdout] ... | [INFO] [stdout] 115 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 74 ~ if version.as_object().unwrap().keys().any(|k| k == "altertable") [INFO] [stdout] 75 ~ && version["altertable"].as_object().unwrap().keys().any(|c| c == table_name) { [INFO] [stdout] 76 | // Modify column [INFO] [stdout] ... [INFO] [stdout] 113 | } [INFO] [stdout] 114 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:77:17 [INFO] [stdout] | [INFO] [stdout] 77 | / if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") { [INFO] [stdout] 78 | | if version["altertable"][table_name]["modifycolumn"] [INFO] [stdout] 79 | | .as_object() [INFO] [stdout] 80 | | .unwrap() [INFO] [stdout] ... | [INFO] [stdout] 97 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 77 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "modifycolumn") [INFO] [stdout] 78 ~ && version["altertable"][table_name]["modifycolumn"] [INFO] [stdout] 79 | .as_object() [INFO] [stdout] ... [INFO] [stdout] 95 | } [INFO] [stdout] 96 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:100:17 [INFO] [stdout] | [INFO] [stdout] 100 | / ... if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "dropcolumn") { [INFO] [stdout] 101 | | ... if version["altertable"][table_name]["dropcolumn"].as_array().unwrap().iter().any(|m| m == version_column_name) { [INFO] [stdout] 102 | | ... column = json!({}); [INFO] [stdout] 103 | | ... } [INFO] [stdout] 104 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 100 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "dropcolumn") [INFO] [stdout] 101 ~ && version["altertable"][table_name]["dropcolumn"].as_array().unwrap().iter().any(|m| m == version_column_name) { [INFO] [stdout] 102 | column = json!({}); [INFO] [stdout] 103 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | / ... if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "addcolumn") { [INFO] [stdout] 108 | | ... if version["altertable"][table_name]["addcolumn"].as_object().unwrap().keys().any(|m| m == version_column_name) { [INFO] [stdout] 109 | | ... for attr in version["altertable"][table_name]["addcolumn"][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 110 | | ... column[attr] = json!(version["altertable"][table_name]["addcolumn"][version_column_name][attr]); [INFO] [stdout] ... | [INFO] [stdout] 113 | | ... } [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 107 ~ if version["altertable"][table_name].as_object().unwrap().keys().any(|t| t == "addcolumn") [INFO] [stdout] 108 ~ && version["altertable"][table_name]["addcolumn"].as_object().unwrap().keys().any(|m| m == version_column_name) { [INFO] [stdout] 109 | for attr in version["altertable"][table_name]["addcolumn"][version_column_name].as_object().unwrap().keys() { [INFO] [stdout] 110 | column[attr] = json!(version["altertable"][table_name]["addcolumn"][version_column_name][attr]); [INFO] [stdout] 111 | } [INFO] [stdout] 112 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:230:5 [INFO] [stdout] | [INFO] [stdout] 230 | return Ok(rename_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 230 - return Ok(rename_data); [INFO] [stdout] 230 + Ok(rename_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/column.rs:208:9 [INFO] [stdout] | [INFO] [stdout] 208 | return Ok(false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 208 - return Ok(false); [INFO] [stdout] 208 + Ok(false) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | / if version.as_object().unwrap().keys().any(|i| i == "altertable") { [INFO] [stdout] 147 | | if version["altertable"].as_object().unwrap().keys().any(|t| t == table_name) { [INFO] [stdout] 148 | | let v = parse_version_number(get_json_string(&version["_id"]).unwrap()).unwrap(); [INFO] [stdout] ... | [INFO] [stdout] 206 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 146 ~ if version.as_object().unwrap().keys().any(|i| i == "altertable") [INFO] [stdout] 147 ~ && version["altertable"].as_object().unwrap().keys().any(|t| t == table_name) { [INFO] [stdout] 148 | let v = parse_version_number(get_json_string(&version["_id"]).unwrap()).unwrap(); [INFO] [stdout] ... [INFO] [stdout] 204 | } [INFO] [stdout] 205 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:151:17 [INFO] [stdout] | [INFO] [stdout] 151 | / if order == "DESC" { [INFO] [stdout] 152 | | if rename_data.iter().any(|r| r.rename_version <= v) { [INFO] [stdout] 153 | | return Ok(false); [INFO] [stdout] 154 | | } [INFO] [stdout] 155 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 151 ~ if order == "DESC" [INFO] [stdout] 152 ~ && rename_data.iter().any(|r| r.rename_version <= v) { [INFO] [stdout] 153 | return Ok(false); [INFO] [stdout] 154 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/column.rs:156:17 [INFO] [stdout] | [INFO] [stdout] 156 | / if order == "ASC" { [INFO] [stdout] 157 | | if rename_data.iter().any(|r| r.rename_version >= v) { [INFO] [stdout] 158 | | return Ok(false); [INFO] [stdout] 159 | | } [INFO] [stdout] 160 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 156 ~ if order == "ASC" [INFO] [stdout] 157 ~ && rename_data.iter().any(|r| r.rename_version >= v) { [INFO] [stdout] 158 | return Ok(false); [INFO] [stdout] 159 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/utils/consolidate/column.rs:178:21 [INFO] [stdout] | [INFO] [stdout] 178 | let name: &str; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `name` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 178 ~ [INFO] [stdout] 179 ~ let name: &str = if order == "DESC" { [INFO] [stdout] 180 ~ renamecolumn_keys[renamecolumn_values.into_iter().position(|n| n == column_name).unwrap()] [INFO] [stdout] 181 | } else { [INFO] [stdout] 182 ~ renamecolumn_values[renamecolumn_keys.into_iter().position(|n| n == column_name).unwrap()].as_str().unwrap() [INFO] [stdout] 183 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/consolidate/table.rs:73:5 [INFO] [stdout] | [INFO] [stdout] 73 | return Ok(table); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 73 - return Ok(table); [INFO] [stdout] 73 + Ok(table) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:31:9 [INFO] [stdout] | [INFO] [stdout] 31 | / if exists_in_object(version, "createtable")? { [INFO] [stdout] 32 | | if exists_in_object(&version["createtable"], table_name)? { [INFO] [stdout] 33 | | let cols = get_object_keys(&version["createtable"][table_name])?; [INFO] [stdout] ... | [INFO] [stdout] 41 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 31 ~ if exists_in_object(version, "createtable")? [INFO] [stdout] 32 ~ && exists_in_object(&version["createtable"], table_name)? { [INFO] [stdout] 33 | let cols = get_object_keys(&version["createtable"][table_name])?; [INFO] [stdout] ... [INFO] [stdout] 39 | } [INFO] [stdout] 40 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/utils/consolidate/table.rs:36:24 [INFO] [stdout] | [INFO] [stdout] 36 | if *col != "primary_key".to_string() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ try implementing the comparison without allocating [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:44:9 [INFO] [stdout] | [INFO] [stdout] 44 | / if exists_in_object(version, "altertable")? { [INFO] [stdout] 45 | | if exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... | [INFO] [stdout] 54 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 44 ~ if exists_in_object(version, "altertable")? [INFO] [stdout] 45 ~ && exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] ... [INFO] [stdout] 52 | } [INFO] [stdout] 53 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/utils/consolidate/table.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | / if exists_in_object(&version["altertable"], table_name)? { [INFO] [stdout] 46 | | if exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... | [INFO] [stdout] 53 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 45 ~ if exists_in_object(&version["altertable"], table_name)? [INFO] [stdout] 46 ~ && exists_in_object(&version["altertable"][table_name], "addcolumn")? { [INFO] [stdout] 47 | let cols = get_object_keys(&version["altertable"][table_name]["addcolumn"])?; [INFO] [stdout] ... [INFO] [stdout] 51 | } [INFO] [stdout] 52 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/consolidate/version_source.rs:38:39 [INFO] [stdout] | [INFO] [stdout] 38 | let methods = get_object_keys(&version)?; [INFO] [stdout] | ^^^^^^^^ help: change this to: `version` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/utils/consolidate/version_source.rs:59:45 [INFO] [stdout] | [INFO] [stdout] 59 | let latest_version = get_latest_version(&versions)?; [INFO] [stdout] | ^^^^^^^^^ help: change this to: `versions` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/consolidate/default_data.rs:21:47 [INFO] [stdout] | [INFO] [stdout] 21 | pub fn consolidate_default_data(version_list: &Vec) -> Result { [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 21 - pub fn consolidate_default_data(version_list: &Vec) -> Result { [INFO] [stdout] 21 + pub fn consolidate_default_data(version_list: &[Value]) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/utils/check.rs:59:8 [INFO] [stdout] | [INFO] [stdout] 59 | if !table_check.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `table_check.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:59:5 [INFO] [stdout] | [INFO] [stdout] 59 | return "".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 59 - return "".to_string(); [INFO] [stdout] 59 + "".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/utils/errors.rs:45:48 [INFO] [stdout] | [INFO] [stdout] 45 | pub fn get_version_trace_string(version_trace: &Vec) -> String { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 45 - pub fn get_version_trace_string(version_trace: &Vec) -> String { [INFO] [stdout] 45 + pub fn get_version_trace_string(version_trace: &[String]) -> String { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/utils/errors.rs:48:8 [INFO] [stdout] | [INFO] [stdout] 48 | if version_trace.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!version_trace.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:70:9 [INFO] [stdout] | [INFO] [stdout] 70 | return self.message.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 70 - return self.message.clone(); [INFO] [stdout] 70 + self.message.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | return self.error.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 - return self.error.clone(); [INFO] [stdout] 74 + self.error.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/errors.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return self.version_trace.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return self.version_trace.clone(); [INFO] [stdout] 78 + self.version_trace.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `impl` can be derived [INFO] [stdout] --> src/utils/errors.rs:96:1 [INFO] [stdout] | [INFO] [stdout] 96 | / impl Default for AlphaDBError { [INFO] [stdout] 97 | | fn default() -> Self { [INFO] [stdout] 98 | | AlphaDBError { [INFO] [stdout] 99 | | message: String::new(), [INFO] [stdout] ... | [INFO] [stdout] 104 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#derivable_impls [INFO] [stdout] = note: `#[warn(clippy::derivable_impls)]` on by default [INFO] [stdout] help: replace the manual implementation with a derive attribute [INFO] [stdout] | [INFO] [stdout] 22 + #[derive(Default)] [INFO] [stdout] 23 | pub struct AlphaDBError { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/json.rs:31:12 [INFO] [stdout] | [INFO] [stdout] 31 | Ok(obj.keys().into_iter().collect::>()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `obj.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/utils/json.rs:52:12 [INFO] [stdout] | [INFO] [stdout] 52 | Ok(obj.keys().into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `obj.keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/json.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return Ok(obj.keys().any(|k| k == key)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return Ok(obj.keys().any(|k| k == key)); [INFO] [stdout] 95 + Ok(obj.keys().any(|k| k == key)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:120:87 [INFO] [stdout] | [INFO] [stdout] 120 | message: format!("The value {} could not be parsed as a string", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] = note: `#[warn(clippy::to_string_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:142:85 [INFO] [stdout] | [INFO] [stdout] 142 | message: format!("The value '{}' could not be parsed as a string", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:163:84 [INFO] [stdout] | [INFO] [stdout] 163 | message: format!("The value {} could not be parsed as a boolean", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:210:93 [INFO] [stdout] | [INFO] [stdout] 210 | message: format!("The value {} could not be parsed as an integer", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:216:89 [INFO] [stdout] | [INFO] [stdout] 216 | message: format!("The value {} could not be parsed as an integer", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:243:90 [INFO] [stdout] | [INFO] [stdout] 243 | message: format!("The value {} could not be parsed as a float", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `to_string` applied to a type that implements `Display` in `format!` args [INFO] [stdout] --> src/utils/json.rs:249:86 [INFO] [stdout] | [INFO] [stdout] 249 | message: format!("The value {} could not be parsed as a float", value.to_string()), [INFO] [stdout] | ^^^^^^^^^^^^ help: remove this [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#to_string_in_format_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/helpers.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | return Ok((db_name, connection)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return Ok((db_name, connection)); [INFO] [stdout] 49 + Ok((db_name, connection)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/version_source.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | return Ok(version_source); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 27 - return Ok(version_source); [INFO] [stdout] 27 + Ok(version_source) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_source.rs:19:24 [INFO] [stdout] | [INFO] [stdout] 19 | return Err(AlphaDBError { [INFO] [stdout] | ________________________^ [INFO] [stdout] 20 | | message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 21 | | ..Default::default() [INFO] [stdout] 22 | | } [INFO] [stdout] 23 | | .into()) [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 19 ~ return Err(AlphaDBError { [INFO] [stdout] 20 + message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 21 + ..Default::default() [INFO] [stdout] 22 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/utils/version_source.rs:51:5 [INFO] [stdout] | [INFO] [stdout] 51 | return Ok(versions); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 51 - return Ok(versions); [INFO] [stdout] 51 + Ok(versions) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/utils/version_source.rs:44:24 [INFO] [stdout] | [INFO] [stdout] 44 | ... return Err(AlphaDBError { [INFO] [stdout] | __________________^ [INFO] [stdout] 45 | | ... message: "Version information data not complete. Must contain 'version' and 'name'. Latest is the latest version number,... [INFO] [stdout] 46 | | ... ..Default::default() [INFO] [stdout] 47 | | ... }.into()); [INFO] [stdout] | |______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 44 ~ return Err(AlphaDBError { [INFO] [stdout] 45 + message: "Version information data not complete. Must contain 'version' and 'name'. Latest is the latest version number, version is a JSON object containing the database structure and name is the database template name.".to_string(), [INFO] [stdout] 46 + ..Default::default() [INFO] [stdout] 47 ~ }); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:41:13 [INFO] [stdout] | [INFO] [stdout] 41 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 41 - return false; [INFO] [stdout] 41 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:61:13 [INFO] [stdout] | [INFO] [stdout] 61 | return Map::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 61 - return Map::new(); [INFO] [stdout] 61 + Map::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | return ""; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 81 - return ""; [INFO] [stdout] 81 + "" [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:101:13 [INFO] [stdout] | [INFO] [stdout] 101 | return true; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 101 - return true; [INFO] [stdout] 101 + true [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:121:13 [INFO] [stdout] | [INFO] [stdout] 121 | return Vec::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 - return Vec::new(); [INFO] [stdout] 121 + Vec::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:143:13 [INFO] [stdout] | [INFO] [stdout] 143 | return EMPTY_MAP.keys(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 143 - return EMPTY_MAP.keys(); [INFO] [stdout] 143 + EMPTY_MAP.keys() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/verification/json.rs:136:92 [INFO] [stdout] | [INFO] [stdout] 136 | static EMPTY_MAP: LazyLock> = LazyLock::new(|| serde_json::Map::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `serde_json::Map::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/verification/json.rs:163:13 [INFO] [stdout] | [INFO] [stdout] 163 | return 0; [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 163 - return 0; [INFO] [stdout] 163 + 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `utils::errors::AlphaDBError` [INFO] [stdout] --> src/version_source_verification.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | return Err(AlphaDBError { [INFO] [stdout] | ____________________________^ [INFO] [stdout] 45 | | message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 46 | | ..Default::default() [INFO] [stdout] 47 | | } [INFO] [stdout] 48 | | .into()) [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing `.into()` [INFO] [stdout] | [INFO] [stdout] 44 ~ return Err(AlphaDBError { [INFO] [stdout] 45 + message: "The provided version source can not be deserialized. Not valid JSON.".to_string(), [INFO] [stdout] 46 + ..Default::default() [INFO] [stdout] 47 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version_source_verification.rs:133:13 [INFO] [stdout] | [INFO] [stdout] 133 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 133 - return Ok(()); [INFO] [stdout] 133 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/version_source_verification.rs:135:13 [INFO] [stdout] | [INFO] [stdout] 135 | return Err(self.issues.clone()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Err(self.issues.clone()); [INFO] [stdout] 135 + Err(self.issues.clone()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:89:34 [INFO] [stdout] | [INFO] [stdout] 89 | message: format!("Missing a version number"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Missing a version number".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:124:59 [INFO] [stdout] | [INFO] [stdout] 124 | ... version_trace: Vec::from([format!("{version_output}")]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `version_output.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:147:34 [INFO] [stdout] | [INFO] [stdout] 147 | message: format!("Does not contain any data"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain any data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:166:63 [INFO] [stdout] | [INFO] [stdout] 166 | ... version_trace: Vec::from([format!("{version_output}"), "createtable".to_string(), format!("table:{table}")]), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `version_output.to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:188:26 [INFO] [stdout] | [INFO] [stdout] 188 | message: format!("Does not contain any data"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain any data".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `serde_json::map::Keys<'_>` [INFO] [stdout] --> src/version_source_verification.rs:238:25 [INFO] [stdout] | [INFO] [stdout] 238 | let data_keys = data.as_object().unwrap().keys().into_iter().collect::>(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `data.as_object().unwrap().keys()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:250:26 [INFO] [stdout] | [INFO] [stdout] 250 | message: format!("Column attributes NULL and AUTO_INCREMENT are incompatible"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Column attributes NULL and AUTO_INCREMENT are incompatible".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/version_source_verification.rs:257:67 [INFO] [stdout] | [INFO] [stdout] 257 | if !data_keys.contains(&&String::from("recreate")) || data["recreate"].as_bool().unwrap() == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `data["recreate"].as_bool().unwrap()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/version_source_verification.rs:260:30 [INFO] [stdout] | [INFO] [stdout] 260 | message: format!("Does not contain a column type"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"Does not contain a column type".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version_source_verification.rs:266:43 [INFO] [stdout] | [INFO] [stdout] 266 | ...f INCOMPATIBLE_W_AI.contains(&&data["type"].as_str().unwrap().to_lowercase().as_str()) && data_keys.contains(&&String::from("a_i... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&data["type"].as_str().unwrap().to_lowercase().as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/version_source_verification.rs:275:47 [INFO] [stdout] | [INFO] [stdout] 275 | ...COMPATIBLE_W_UNIQUE.contains(&&data["type"].as_str().unwrap().to_lowercase().as_str()) && data_keys.contains(&&String::from("uni... [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `(&data["type"].as_str().unwrap().to_lowercase().as_str())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `AlphaDB<'a>` [INFO] [stdout] --> src/lib.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> AlphaDB<'a> { [INFO] [stdout] 46 | | AlphaDB { connection: None, db_name: None, is_connected: false } [INFO] [stdout] 47 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 40 + impl<'a> Default for AlphaDB<'a> { [INFO] [stdout] 41 + fn default() -> Self { [INFO] [stdout] 42 + Self::new() [INFO] [stdout] 43 + } [INFO] [stdout] 44 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:83:9 [INFO] [stdout] | [INFO] [stdout] 83 | return init(db_name, connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 83 - return init(db_name, connection); [INFO] [stdout] 83 + init(db_name, connection) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:95:9 [INFO] [stdout] | [INFO] [stdout] 95 | return status(db_name, connection); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 95 - return status(db_name, connection); [INFO] [stdout] 95 + status(db_name, connection) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:112:9 [INFO] [stdout] | [INFO] [stdout] 112 | return update_queries(db_name, connection, version_source, update_to_version, no_data); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 112 - return update_queries(db_name, connection, version_source, update_to_version, no_data); [INFO] [stdout] 112 + update_queries(db_name, connection, version_source, update_to_version, no_data) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lib.rs:138:9 [INFO] [stdout] | [INFO] [stdout] 138 | / return update( [INFO] [stdout] 139 | | db_name, [INFO] [stdout] 140 | | connection, [INFO] [stdout] 141 | | version_source, [INFO] [stdout] ... | [INFO] [stdout] 145 | | allowed_error_priority, [INFO] [stdout] 146 | | ); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 138 ~ update( [INFO] [stdout] 139 + db_name, [INFO] [stdout] 140 + connection, [INFO] [stdout] 141 + version_source, [INFO] [stdout] 142 + update_to_version, [INFO] [stdout] 143 + no_data, [INFO] [stdout] 144 + verify, [INFO] [stdout] 145 + allowed_error_priority, [INFO] [stdout] 146 ~ ) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:202:9 [INFO] [stdout] | [INFO] [stdout] 202 | assert_eq!(checked.check, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 202 - assert_eq!(checked.check, true); [INFO] [stdout] 202 + assert!(checked.check); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:207:9 [INFO] [stdout] | [INFO] [stdout] 207 | assert_eq!(status.init, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 207 - assert_eq!(status.init, true); [INFO] [stdout] 207 + assert!(status.init); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:223:9 [INFO] [stdout] | [INFO] [stdout] 223 | assert_eq!(checked.check, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 223 - assert_eq!(checked.check, false); [INFO] [stdout] 223 + assert!(!checked.check); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/lib.rs:227:9 [INFO] [stdout] | [INFO] [stdout] 227 | assert_eq!(status.init, false); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 227 - assert_eq!(status.init, false); [INFO] [stdout] 227 + assert!(!status.init); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 37.72s [INFO] running `Command { std: "docker" "inspect" "e9493b25077892586d96963d950ddb9b172311ac95723dae449340094183eb45", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "e9493b25077892586d96963d950ddb9b172311ac95723dae449340094183eb45", kill_on_drop: false }` [INFO] [stdout] e9493b25077892586d96963d950ddb9b172311ac95723dae449340094183eb45