[INFO] fetching crate alphabet 0.2.2... [INFO] linting alphabet-0.2.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate alphabet 0.2.2 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate alphabet 0.2.2 [INFO] finished tweaking crates.io crate alphabet 0.2.2 [INFO] tweaked toml for crates.io crate alphabet 0.2.2 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate alphabet 0.2.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 6 packages to latest compatible versions [INFO] [stderr] Adding more-asserts v0.2.2 (available: v0.3.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded alphabet-macro v0.1.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 209f14481003d66ca11a11767e1f7124b7ac5fd9ebdb547e01d3d5366d91735b [INFO] running `Command { std: "docker" "start" "-a" "209f14481003d66ca11a11767e1f7124b7ac5fd9ebdb547e01d3d5366d91735b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "209f14481003d66ca11a11767e1f7124b7ac5fd9ebdb547e01d3d5366d91735b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "209f14481003d66ca11a11767e1f7124b7ac5fd9ebdb547e01d3d5366d91735b", kill_on_drop: false }` [INFO] [stdout] 209f14481003d66ca11a11767e1f7124b7ac5fd9ebdb547e01d3d5366d91735b [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 4b6325344501c6fd0ab4157110d342e38ff16f057eb74df8fdaf938b5162d003 [INFO] running `Command { std: "docker" "start" "-a" "4b6325344501c6fd0ab4157110d342e38ff16f057eb74df8fdaf938b5162d003", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Checking more-asserts v0.2.2 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling alphabet-macro v0.1.2 [INFO] [stderr] Checking alphabet v0.2.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:9:40 [INFO] [stdout] | [INFO] [stdout] 9 | VectorAccess::Direct(v) => &v, [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/util.rs:21:9 [INFO] [stdout] | [INFO] [stdout] 21 | / let mut vec: Vec = Vec::new(); [INFO] [stdout] 22 | | vec.push(5); [INFO] [stdout] | |____________________^ help: consider using the `vec![]` macro: `let vec: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/util.rs:41:9 [INFO] [stdout] | [INFO] [stdout] 41 | / let mut vec: Vec = Vec::new(); [INFO] [stdout] 42 | | vec.push(5); [INFO] [stdout] | |____________________^ help: consider using the `vec![]` macro: `let vec: Vec = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/counting_iter.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if self.counter.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.counter.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/word/counting_iter.rs:113:21 [INFO] [stdout] | [INFO] [stdout] 113 | assert!(!iter.next().is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/word/counting_iter.rs:144:17 [INFO] [stdout] | [INFO] [stdout] 144 | assert!(!needle.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `needle.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/word_iter.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if self.source.get().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.source.get().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/word_iter.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | if self.counter.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.counter.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/word/word_iter.rs:92:21 [INFO] [stdout] | [INFO] [stdout] 92 | assert!(!iter.next().is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `iter.next().is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/util.rs:9:40 [INFO] [stdout] | [INFO] [stdout] 9 | VectorAccess::Direct(v) => &v, [INFO] [stdout] | ^^ help: change this to: `v` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/word/word_iter.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | assert!(!needle.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `needle.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/word/word_iter.rs:123:17 [INFO] [stdout] | [INFO] [stdout] 123 | assert!(!needle.is_none()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `needle.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:143:56 [INFO] [stdout] | [INFO] [stdout] 143 | word::WordIterator::new(VectorAccess::Indirect(&self)) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:147:60 [INFO] [stdout] | [INFO] [stdout] 147 | word::CountingIterator::new(VectorAccess::Indirect(&self)) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/counting_iter.rs:25:16 [INFO] [stdout] | [INFO] [stdout] 25 | if self.counter.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.counter.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/word_iter.rs:22:12 [INFO] [stdout] | [INFO] [stdout] 22 | if self.source.get().len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.source.get().is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/word/word_iter.rs:23:16 [INFO] [stdout] | [INFO] [stdout] 23 | if self.counter.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.counter.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:143:56 [INFO] [stdout] | [INFO] [stdout] 143 | word::WordIterator::new(VectorAccess::Indirect(&self)) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:147:60 [INFO] [stdout] | [INFO] [stdout] 147 | word::CountingIterator::new(VectorAccess::Indirect(&self)) [INFO] [stdout] | ^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 4.75s [INFO] running `Command { std: "docker" "inspect" "4b6325344501c6fd0ab4157110d342e38ff16f057eb74df8fdaf938b5162d003", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "4b6325344501c6fd0ab4157110d342e38ff16f057eb74df8fdaf938b5162d003", kill_on_drop: false }` [INFO] [stdout] 4b6325344501c6fd0ab4157110d342e38ff16f057eb74df8fdaf938b5162d003