[INFO] fetching crate alexcrichton-cranelift-wasm 0.53.0... [INFO] linting alexcrichton-cranelift-wasm-0.53.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate alexcrichton-cranelift-wasm 0.53.0 into /workspace/builds/worker-3-tc1/source [INFO] started tweaking crates.io crate alexcrichton-cranelift-wasm 0.53.0 [INFO] finished tweaking crates.io crate alexcrichton-cranelift-wasm 0.53.0 [INFO] tweaked toml for crates.io crate alexcrichton-cranelift-wasm 0.53.0 written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate alexcrichton-cranelift-wasm 0.53.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Updating crates.io index [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Locking 44 packages to latest compatible versions [INFO] [stderr] Adding hashbrown v0.6.3 (available: v0.16.1) [INFO] [stderr] Adding target-lexicon v0.10.0 (available: v0.13.5) [INFO] [stderr] Adding thiserror v1.0.69 (available: v2.0.18) [INFO] [stderr] Adding wabt v0.9.1 (available: v0.10.0) [INFO] [stderr] Adding wasmparser v0.45.2 (available: v0.245.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded alexcrichton-cranelift-frontend v0.53.0 [INFO] [stderr] Downloaded wasmparser v0.45.2 [INFO] [stderr] Downloaded wabt v0.9.1 [INFO] [stderr] Downloaded wabt-sys v0.6.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 05463badc4eafd3402d2edffceb8ad0e1f662f87df3769a6c5eab09a86f827cb [INFO] running `Command { std: "docker" "start" "-a" "05463badc4eafd3402d2edffceb8ad0e1f662f87df3769a6c5eab09a86f827cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "05463badc4eafd3402d2edffceb8ad0e1f662f87df3769a6c5eab09a86f827cb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "05463badc4eafd3402d2edffceb8ad0e1f662f87df3769a6c5eab09a86f827cb", kill_on_drop: false }` [INFO] [stdout] 05463badc4eafd3402d2edffceb8ad0e1f662f87df3769a6c5eab09a86f827cb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c6b14ffdf32ef23556142146163e5780cf25d079a05c3ad1021202e19880a16b [INFO] running `Command { std: "docker" "start" "-a" "c6b14ffdf32ef23556142146163e5780cf25d079a05c3ad1021202e19880a16b", kill_on_drop: false }` [INFO] [stderr] Compiling alexcrichton-cranelift-entity v0.53.0 [INFO] [stderr] Compiling alexcrichton-cranelift-codegen-shared v0.53.0 [INFO] [stderr] Compiling target-lexicon v0.10.0 [INFO] [stderr] Compiling cmake v0.1.57 [INFO] [stderr] Checking wasmparser v0.45.2 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking alexcrichton-cranelift-bforest v0.53.0 [INFO] [stderr] Compiling wabt-sys v0.6.1 [INFO] [stderr] Compiling alexcrichton-cranelift-codegen-meta v0.53.0 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling alexcrichton-cranelift-codegen v0.53.0 [INFO] [stderr] Checking alexcrichton-cranelift-frontend v0.53.0 [INFO] [stderr] Checking alexcrichton-cranelift-wasm v0.53.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::new_without_default))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/code_translator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/code_translator.rs:1420:12 [INFO] [stdout] | [INFO] [stdout] 1420 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::unneeded_field_pattern))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/environ/spec.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "clippy", plugin(clippy(conf_file = "../../clippy.toml")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::new_without_default))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/code_translator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/code_translator.rs:1420:12 [INFO] [stdout] | [INFO] [stdout] 1420 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::unneeded_field_pattern))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/environ/spec.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/translation_utils.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use wasmparser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sections_translator.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | Signature::new(ModuleEnvironment::target_config(environ).default_call_conv); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | Signature::new(::target_config(environ).default_call_conv); [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/code_translator.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | //! is; [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/code_translator.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | use core::{i32, u32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/code_translator.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | use core::{i32, u32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/code_translator.rs:58:66 [INFO] [stdout] | [INFO] [stdout] 58 | translate_unreachable_operator(module_translation_state, &op, builder, state, environ)?; [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/code_translator.rs:443:48 [INFO] [stdout] | [INFO] [stdout] 443 | bitcast_arguments(return_args, &return_types, builder); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `return_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1151:63 [INFO] [stdout] | [INFO] [stdout] 1151 | let extracted = builder.ins().extractlane(vector, lane.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1156:59 [INFO] [stdout] | [INFO] [stdout] 1156 | state.push1(builder.ins().extractlane(vector, lane.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1164:59 [INFO] [stdout] | [INFO] [stdout] 1164 | state.push1(builder.ins().extractlane(vector, lane.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1177:37 [INFO] [stdout] | [INFO] [stdout] 1177 | .insertlane(vector, lane.clone(), replacement_value); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/code_translator.rs:1563:8 [INFO] [stdout] | [INFO] [stdout] 1563 | if offset_guard_size != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] 1564 | adjusted_offset = adjusted_offset / offset_guard_size * offset_guard_size; [INFO] [stdout] | ----------------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/environ/spec.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | / fn translate_call_indirect( [INFO] [stdout] 220 | | &mut self, [INFO] [stdout] 221 | | pos: FuncCursor, [INFO] [stdout] 222 | | table_index: TableIndex, [INFO] [stdout] ... | [INFO] [stdout] 227 | | call_args: &[ir::Value], [INFO] [stdout] 228 | | ) -> WasmResult; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FuncTranslator` [INFO] [stdout] --> src/func_translator.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | func_ctx: FunctionBuilderContext::new(), [INFO] [stdout] 34 | | state: FuncTranslationState::new(), [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 29 + impl Default for FuncTranslator { [INFO] [stdout] 30 + fn default() -> Self { [INFO] [stdout] 31 + Self::new() [INFO] [stdout] 32 + } [INFO] [stdout] 33 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/func_translator.rs:138:38 [INFO] [stdout] | [INFO] [stdout] 138 | if environ.is_wasm_parameter(&builder.func, i) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `builder.func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/func_translator.rs:249:57 [INFO] [stdout] | [INFO] [stdout] 249 | bitcast_arguments(&mut state.stack, &return_types, builder); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `return_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sections_translator.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | if num_functions == std::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 145 - if num_functions == std::u32::MAX { [INFO] [stdout] 145 + if num_functions == u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sections_translator.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | if index == std::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 424 - if index == std::u32::MAX { [INFO] [stdout] 424 + if index == u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ModuleTranslationState` [INFO] [stdout] --> src/state/module_state.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn new() -> Self { [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | wasm_types: PrimaryMap::new(), [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for ModuleTranslationState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/translation_utils.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use core::u32; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/translation_utils.rs:180:14 [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &*returns) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 180 - (&*params, &*returns) [INFO] [stdout] 180 + (params, &*returns) [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 180 | (&**params, &*returns) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/translation_utils.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &*returns) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 180 - (&*params, &*returns) [INFO] [stdout] 180 + (&*params, returns) [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &**returns) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/environ/dummy.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn func_env(&self) -> DummyFuncEnvironment { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 150 | pub fn func_env(&self) -> DummyFuncEnvironment<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wabt v0.9.1 [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::new_without_default))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] = note: `#[warn(clippy::deprecated_clippy_cfg_attr)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/code_translator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/code_translator.rs:1420:12 [INFO] [stdout] | [INFO] [stdout] 1420 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::unneeded_field_pattern))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `feature = "cargo-clippy"` was replaced by `clippy` [INFO] [stdout] --> src/environ/spec.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `clippy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deprecated_clippy_cfg_attr [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `clippy` [INFO] [stdout] --> src/lib.rs:15:13 [INFO] [stdout] | [INFO] [stdout] 15 | #![cfg_attr(feature = "clippy", plugin(clippy(conf_file = "../../clippy.toml")))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:16:13 [INFO] [stdout] | [INFO] [stdout] 16 | #![cfg_attr(feature = "cargo-clippy", allow(clippy::new_without_default))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/lib.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 18 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/code_translator.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | feature = "cargo-clippy", [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/code_translator.rs:1420:12 [INFO] [stdout] | [INFO] [stdout] 1420 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::unneeded_field_pattern))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `cargo-clippy` [INFO] [stdout] --> src/environ/spec.rs:218:16 [INFO] [stdout] | [INFO] [stdout] 218 | #[cfg_attr(feature = "cargo-clippy", allow(clippy::too_many_arguments))] [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: expected values for `feature` are: `basic-blocks`, `core`, `default`, `enable-serde`, `hashbrown`, `serde`, and `std` [INFO] [stdout] = help: consider adding `cargo-clippy` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> tests/wasm_testsuite.rs:44:28 [INFO] [stdout] | [INFO] [stdout] 44 | let data = read_module(&path); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/translation_utils.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | use wasmparser; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: panic message is not a string literal [INFO] [stdout] --> tests/wasm_testsuite.rs:113:38 [INFO] [stdout] | [INFO] [stdout] 113 | .map_err(|errors| panic!(pretty_verifier_error(func, Some(&*isa), None, errors))) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: this usage of `panic!()` is deprecated; it will be a hard error in Rust 2021 [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(non_fmt_panics)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: add a "{}" format string to `Display` the message [INFO] [stdout] | [INFO] [stdout] 113 | .map_err(|errors| panic!("{}", pretty_verifier_error(func, Some(&*isa), None, errors))) [INFO] [stdout] | +++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: trait objects without an explicit `dyn` are deprecated [INFO] [stdout] --> src/sections_translator.rs:48:36 [INFO] [stdout] | [INFO] [stdout] 48 | Signature::new(ModuleEnvironment::target_config(environ).default_call_conv); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = warning: this is accepted in the current edition (Rust 2018) but is a hard error in Rust 2021! [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(bare_trait_objects)]` (part of `#[warn(rust_2021_compatibility)]`) on by default [INFO] [stdout] help: if this is a dyn-compatible trait, use `dyn` [INFO] [stdout] | [INFO] [stdout] 48 | Signature::new(::target_config(environ).default_call_conv); [INFO] [stdout] | ++++ + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: doc list item overindented [INFO] [stdout] --> src/code_translator.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | //! is; [INFO] [stdout] | ^^^ help: try using ` ` (2 spaces) [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#doc_overindented_list_items [INFO] [stdout] = note: `#[warn(clippy::doc_overindented_list_items)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/code_translator.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | use core::{i32, u32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `i32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] = note: `#[warn(clippy::legacy_numeric_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/code_translator.rs:33:17 [INFO] [stdout] | [INFO] [stdout] 33 | use core::{i32, u32}; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/code_translator.rs:58:66 [INFO] [stdout] | [INFO] [stdout] 58 | translate_unreachable_operator(module_translation_state, &op, builder, state, environ)?; [INFO] [stdout] | ^^^ help: change this to: `op` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/code_translator.rs:443:48 [INFO] [stdout] | [INFO] [stdout] 443 | bitcast_arguments(return_args, &return_types, builder); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `return_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1151:63 [INFO] [stdout] | [INFO] [stdout] 1151 | let extracted = builder.ins().extractlane(vector, lane.clone()); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1156:59 [INFO] [stdout] | [INFO] [stdout] 1156 | state.push1(builder.ins().extractlane(vector, lane.clone())); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1164:59 [INFO] [stdout] | [INFO] [stdout] 1164 | state.push1(builder.ins().extractlane(vector, lane.clone())) [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `u8` which implements the `Copy` trait [INFO] [stdout] --> src/code_translator.rs:1177:37 [INFO] [stdout] | [INFO] [stdout] 1177 | .insertlane(vector, lane.clone(), replacement_value); [INFO] [stdout] | ^^^^^^^^^^^^ help: try dereferencing it: `*lane` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual checked division [INFO] [stdout] --> src/code_translator.rs:1563:8 [INFO] [stdout] | [INFO] [stdout] 1563 | if offset_guard_size != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ check performed here [INFO] [stdout] 1564 | adjusted_offset = adjusted_offset / offset_guard_size * offset_guard_size; [INFO] [stdout] | ----------------------------------- division performed here [INFO] [stdout] | [INFO] [stdout] = help: consider using `checked_div` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_checked_ops [INFO] [stdout] = note: `#[warn(clippy::manual_checked_ops)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (8/7) [INFO] [stdout] --> src/environ/spec.rs:219:5 [INFO] [stdout] | [INFO] [stdout] 219 | / fn translate_call_indirect( [INFO] [stdout] 220 | | &mut self, [INFO] [stdout] 221 | | pos: FuncCursor, [INFO] [stdout] 222 | | table_index: TableIndex, [INFO] [stdout] ... | [INFO] [stdout] 227 | | call_args: &[ir::Value], [INFO] [stdout] 228 | | ) -> WasmResult; [INFO] [stdout] | |_____________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `FuncTranslator` [INFO] [stdout] --> src/func_translator.rs:31:5 [INFO] [stdout] | [INFO] [stdout] 31 | / pub fn new() -> Self { [INFO] [stdout] 32 | | Self { [INFO] [stdout] 33 | | func_ctx: FunctionBuilderContext::new(), [INFO] [stdout] 34 | | state: FuncTranslationState::new(), [INFO] [stdout] 35 | | } [INFO] [stdout] 36 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 29 + impl Default for FuncTranslator { [INFO] [stdout] 30 + fn default() -> Self { [INFO] [stdout] 31 + Self::new() [INFO] [stdout] 32 + } [INFO] [stdout] 33 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/func_translator.rs:138:38 [INFO] [stdout] | [INFO] [stdout] 138 | if environ.is_wasm_parameter(&builder.func, i) { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `builder.func` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/func_translator.rs:249:57 [INFO] [stdout] | [INFO] [stdout] 249 | bitcast_arguments(&mut state.stack, &return_types, builder); [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `return_types` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sections_translator.rs:145:25 [INFO] [stdout] | [INFO] [stdout] 145 | if num_functions == std::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 145 - if num_functions == std::u32::MAX { [INFO] [stdout] 145 + if num_functions == u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of a legacy numeric constant [INFO] [stdout] --> src/sections_translator.rs:424:21 [INFO] [stdout] | [INFO] [stdout] 424 | if index == std::u32::MAX { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] help: use the associated constant instead [INFO] [stdout] | [INFO] [stdout] 424 - if index == std::u32::MAX { [INFO] [stdout] 424 + if index == u32::MAX { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `ModuleTranslationState` [INFO] [stdout] --> src/state/module_state.rs:26:5 [INFO] [stdout] | [INFO] [stdout] 26 | / pub fn new() -> Self { [INFO] [stdout] 27 | | Self { [INFO] [stdout] 28 | | wasm_types: PrimaryMap::new(), [INFO] [stdout] 29 | | } [INFO] [stdout] 30 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 24 + impl Default for ModuleTranslationState { [INFO] [stdout] 25 + fn default() -> Self { [INFO] [stdout] 26 + Self::new() [INFO] [stdout] 27 + } [INFO] [stdout] 28 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: importing legacy numeric constants [INFO] [stdout] --> src/translation_utils.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use core::u32; [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove this import [INFO] [stdout] = note: then `u32::` will resolve to the respective associated constant [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#legacy_numeric_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/translation_utils.rs:180:14 [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &*returns) [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] = note: `#[warn(clippy::borrow_deref_ref)]` on by default [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 180 - (&*params, &*returns) [INFO] [stdout] 180 + (params, &*returns) [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 180 | (&**params, &*returns) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: deref on an immutable reference [INFO] [stdout] --> src/translation_utils.rs:180:24 [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &*returns) [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#borrow_deref_ref [INFO] [stdout] help: if you would like to reborrow, try removing `&*` [INFO] [stdout] | [INFO] [stdout] 180 - (&*params, &*returns) [INFO] [stdout] 180 + (&*params, returns) [INFO] [stdout] | [INFO] [stdout] help: if you would like to deref, try using `&**` [INFO] [stdout] | [INFO] [stdout] 180 | (&*params, &**returns) [INFO] [stdout] | + [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/environ/dummy.rs:150:21 [INFO] [stdout] | [INFO] [stdout] 150 | pub fn func_env(&self) -> DummyFuncEnvironment { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 150 | pub fn func_env(&self) -> DummyFuncEnvironment<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 35.35s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: alexcrichton-cranelift-codegen-meta v0.53.0 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 5` [INFO] running `Command { std: "docker" "inspect" "c6b14ffdf32ef23556142146163e5780cf25d079a05c3ad1021202e19880a16b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c6b14ffdf32ef23556142146163e5780cf25d079a05c3ad1021202e19880a16b", kill_on_drop: false }` [INFO] [stdout] c6b14ffdf32ef23556142146163e5780cf25d079a05c3ad1021202e19880a16b