[INFO] fetching crate adduce 0.1.6... [INFO] linting adduce-0.1.6 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate adduce 0.1.6 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate adduce 0.1.6 [INFO] finished tweaking crates.io crate adduce 0.1.6 [INFO] tweaked toml for crates.io crate adduce 0.1.6 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate adduce 0.1.6 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate adduce 0.1.6 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded optional_struct_export v0.4.1 [INFO] [stderr] Downloaded optional_struct v0.4.1 [INFO] [stderr] Downloaded optional_struct_macro_impl v0.4.1 [INFO] [stderr] Downloaded atom_syndication v0.12.2 [INFO] [stderr] Downloaded diligent-date-parser v0.1.4 [INFO] [stderr] Downloaded pulldown-cmark v0.11.0 [INFO] [stderr] Downloaded rss v2.0.6 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9f73cd57ccff959e1e6ed390a2eae3895a25d23dbb8710abf902cb764cac94f4 [INFO] running `Command { std: "docker" "start" "-a" "9f73cd57ccff959e1e6ed390a2eae3895a25d23dbb8710abf902cb764cac94f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9f73cd57ccff959e1e6ed390a2eae3895a25d23dbb8710abf902cb764cac94f4", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9f73cd57ccff959e1e6ed390a2eae3895a25d23dbb8710abf902cb764cac94f4", kill_on_drop: false }` [INFO] [stdout] 9f73cd57ccff959e1e6ed390a2eae3895a25d23dbb8710abf902cb764cac94f4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] c28f354e16c615b8cbccde5b1e3c92b5d69389daa98a96fe44d71dc40c4f92e9 [INFO] running `Command { std: "docker" "start" "-a" "c28f354e16c615b8cbccde5b1e3c92b5d69389daa98a96fe44d71dc40c4f92e9", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Checking hashbrown v0.14.0 [INFO] [stderr] Checking winnow v0.5.15 [INFO] [stderr] Checking never v0.1.0 [INFO] [stderr] Compiling pulldown-cmark v0.11.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking quick-xml v0.30.0 [INFO] [stderr] Checking chrono v0.4.31 [INFO] [stderr] Checking indexmap v2.0.0 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking diligent-date-parser v0.1.4 [INFO] [stderr] Compiling syn v2.0.41 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling optional_struct_macro_impl v0.4.1 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling optional_struct_export v0.4.1 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking atom_syndication v0.12.2 [INFO] [stderr] Checking rss v2.0.6 [INFO] [stderr] Checking toml_datetime v0.6.5 [INFO] [stderr] Checking serde_spanned v0.6.4 [INFO] [stderr] Checking optional_struct v0.4.1 [INFO] [stderr] Checking toml_edit v0.21.0 [INFO] [stderr] Checking toml v0.8.8 [INFO] [stderr] Checking adduce v0.1.6 (/opt/rustwide/workdir) [INFO] [stdout] warning: enum `GenMethod` is never used [INFO] [stdout] --> src/config/html.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum GenMethod { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/feed.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if !fs::metadata(folder_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(folder_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enum `GenMethod` is never used [INFO] [stdout] --> src/config/html.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub enum GenMethod { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `toml.main` after checking its variant with `is_none` [INFO] [stdout] --> src/lib/feed.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 149 | if toml.main.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &mut toml.main` [INFO] [stdout] ... [INFO] [stdout] 152 | toml.main.as_mut().unwrap().block.push(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib/feed.rs:71:8 [INFO] [stdout] | [INFO] [stdout] 71 | if !fs::metadata(folder_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(folder_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `toml.main` after checking its variant with `is_none` [INFO] [stdout] --> src/lib/feed.rs:152:9 [INFO] [stdout] | [INFO] [stdout] 149 | if toml.main.is_none() { [INFO] [stdout] | ---------------------- help: try: `if let Some() = &mut toml.main` [INFO] [stdout] ... [INFO] [stdout] 152 | toml.main.as_mut().unwrap().block.push(text); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/markdown.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | divs += &html.trim_end_matches('\n'); // Avoid trailing newline for the last element [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `html.trim_end_matches('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib/markdown.rs:12:25 [INFO] [stdout] | [INFO] [stdout] 12 | divs += &html.trim_end_matches('\n'); // Avoid trailing newline for the last element [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `html.trim_end_matches('\n')` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if args.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!args.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/main.rs:43:8 [INFO] [stdout] | [INFO] [stdout] 43 | if args.len() % 2 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: replace with: `!args.len().is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 9.24s [INFO] running `Command { std: "docker" "inspect" "c28f354e16c615b8cbccde5b1e3c92b5d69389daa98a96fe44d71dc40c4f92e9", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c28f354e16c615b8cbccde5b1e3c92b5d69389daa98a96fe44d71dc40c4f92e9", kill_on_drop: false }` [INFO] [stdout] c28f354e16c615b8cbccde5b1e3c92b5d69389daa98a96fe44d71dc40c4f92e9