[INFO] fetching crate acap 0.4.0... [INFO] linting acap-0.4.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate acap 0.4.0 into /workspace/builds/worker-6-tc1/source [INFO] started tweaking crates.io crate acap 0.4.0 [INFO] finished tweaking crates.io crate acap 0.4.0 [INFO] tweaked toml for crates.io crate acap 0.4.0 written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate acap 0.4.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate acap 0.4.0 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded oorandom v11.1.4 [INFO] [stderr] Downloaded unicode-ident v1.0.16 [INFO] [stderr] Downloaded is-terminal v0.4.15 [INFO] [stderr] Downloaded rand_core v0.9.1 [INFO] [stderr] Downloaded clap v4.5.30 [INFO] [stderr] Downloaded clap_builder v4.5.30 [INFO] [stderr] Downloaded zerocopy-derive v0.8.18 [INFO] [stderr] Downloaded serde_json v1.0.138 [INFO] [stderr] Downloaded zerocopy v0.8.18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5f0f7ad3792341b586bfaaa199c6a59cd80e8da8d3f832a761fd350600de3f18 [INFO] running `Command { std: "docker" "start" "-a" "5f0f7ad3792341b586bfaaa199c6a59cd80e8da8d3f832a761fd350600de3f18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5f0f7ad3792341b586bfaaa199c6a59cd80e8da8d3f832a761fd350600de3f18", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5f0f7ad3792341b586bfaaa199c6a59cd80e8da8d3f832a761fd350600de3f18", kill_on_drop: false }` [INFO] [stdout] 5f0f7ad3792341b586bfaaa199c6a59cd80e8da8d3f832a761fd350600de3f18 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 11749c0828cb19d3bb78d400e4ff890f861391238ac8619973239d67f5b2b271 [INFO] running `Command { std: "docker" "start" "-a" "11749c0828cb19d3bb78d400e4ff890f861391238ac8619973239d67f5b2b271", kill_on_drop: false }` [INFO] [stderr] Compiling unicode-ident v1.0.16 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.217 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling zerocopy v0.8.18 [INFO] [stderr] Compiling getrandom v0.3.1 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde_json v1.0.138 [INFO] [stderr] Checking itoa v1.0.14 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking half v2.4.1 [INFO] [stderr] Checking ciborium-io v0.2.2 [INFO] [stderr] Checking ryu v1.0.19 [INFO] [stderr] Checking plotters-backend v0.3.7 [INFO] [stderr] Checking clap_lex v0.7.4 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Compiling proc-macro2 v1.0.93 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking clap_builder v4.5.30 [INFO] [stderr] Checking cast v0.3.0 [INFO] [stderr] Checking once_cell v1.20.3 [INFO] [stderr] Checking plotters-svg v0.3.7 [INFO] [stderr] Checking ciborium-ll v0.2.2 [INFO] [stderr] Checking oorandom v11.1.4 [INFO] [stderr] Checking anes v0.1.6 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Compiling quote v1.0.38 [INFO] [stderr] Compiling syn v2.0.98 [INFO] [stderr] Checking is-terminal v0.4.15 [INFO] [stderr] Checking criterion-plot v0.5.0 [INFO] [stderr] Checking clap v4.5.30 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking plotters v0.3.7 [INFO] [stderr] Checking acap v0.4.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking rand_core v0.9.1 [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cos.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if value >= 0.0 && value <= core::$f::consts::PI { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=core::$f::consts::PI).contains(&value)` [INFO] [stdout] ... [INFO] [stdout] 488 | impl_distance!(f32); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_distance` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cos.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if value >= 0.0 && value <= core::$f::consts::PI { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=core::$f::consts::PI).contains(&value)` [INFO] [stdout] ... [INFO] [stdout] 489 | impl_distance!(f64); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: this warning originates in the macro `impl_distance` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k [INFO] [stdout] --> src/distance.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | impl<'k, 'v, K: Proximity, V> Proximity<&'v V> for &'k K { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 124 - impl<'k, 'v, K: Proximity, V> Proximity<&'v V> for &'k K { [INFO] [stdout] 124 + impl<'v, K: Proximity, V> Proximity<&'v V> for &K { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k, 'v [INFO] [stdout] --> src/distance.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 162 | impl<'k, 'v, K: Metric, V> Metric<&'v V> for &'k K {} [INFO] [stdout] | ^^ ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 162 - impl<'k, 'v, K: Metric, V> Metric<&'v V> for &'k K {} [INFO] [stdout] 162 + impl, V> Metric<&V> for &K {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 102 - self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] 102 + self.threshold.is_none_or(|t| distance <= t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if threshold.map_or(true, |t| distance <= t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 148 - if threshold.map_or(true, |t| distance <= t) { [INFO] [stdout] 148 + if threshold.is_none_or(|t| distance <= t) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:225:23 [INFO] [stdout] | [INFO] [stdout] 225 | self.k > 0 && self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 225 - self.k > 0 && self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] 225 + self.k > 0 && self.threshold.is_none_or(|t| distance <= t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k, 'v [INFO] [stdout] --> src/lp.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | impl<'k, 'v, K: Minkowski, V> Minkowski<&'v V> for &'k K {} [INFO] [stdout] | ^^ ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 65 - impl<'k, 'v, K: Minkowski, V> Minkowski<&'v V> for &'k K {} [INFO] [stdout] 65 + impl, V> Minkowski<&V> for &K {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Compiling serde_derive v1.0.217 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.0 [INFO] [stderr] Checking ciborium v0.2.2 [INFO] [stderr] Checking tinytemplate v1.2.1 [INFO] [stderr] Checking criterion v0.5.1 [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cos.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if value >= 0.0 && value <= core::$f::consts::PI { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=core::$f::consts::PI).contains(&value)` [INFO] [stdout] ... [INFO] [stdout] 488 | impl_distance!(f32); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] = note: this warning originates in the macro `impl_distance` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/cos.rs:439:20 [INFO] [stdout] | [INFO] [stdout] 439 | if value >= 0.0 && value <= core::$f::consts::PI { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=core::$f::consts::PI).contains(&value)` [INFO] [stdout] ... [INFO] [stdout] 489 | impl_distance!(f64); [INFO] [stdout] | ------------------- in this macro invocation [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: this warning originates in the macro `impl_distance` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k [INFO] [stdout] --> src/distance.rs:124:6 [INFO] [stdout] | [INFO] [stdout] 124 | impl<'k, 'v, K: Proximity, V> Proximity<&'v V> for &'k K { [INFO] [stdout] | ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] = note: `#[warn(clippy::needless_lifetimes)]` on by default [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 124 - impl<'k, 'v, K: Proximity, V> Proximity<&'v V> for &'k K { [INFO] [stdout] 124 + impl<'v, K: Proximity, V> Proximity<&'v V> for &K { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k, 'v [INFO] [stdout] --> src/distance.rs:162:6 [INFO] [stdout] | [INFO] [stdout] 162 | impl<'k, 'v, K: Metric, V> Metric<&'v V> for &'k K {} [INFO] [stdout] | ^^ ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 162 - impl<'k, 'v, K: Metric, V> Metric<&'v V> for &'k K {} [INFO] [stdout] 162 + impl, V> Metric<&V> for &K {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] = note: `#[warn(clippy::unnecessary_map_or)]` on by default [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 102 - self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] 102 + self.threshold.is_none_or(|t| distance <= t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:148:16 [INFO] [stdout] | [INFO] [stdout] 148 | if threshold.map_or(true, |t| distance <= t) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 148 - if threshold.map_or(true, |t| distance <= t) { [INFO] [stdout] 148 + if threshold.is_none_or(|t| distance <= t) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `map_or` can be simplified [INFO] [stdout] --> src/knn.rs:225:23 [INFO] [stdout] | [INFO] [stdout] 225 | self.k > 0 && self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_map_or [INFO] [stdout] help: use `is_none_or` instead [INFO] [stdout] | [INFO] [stdout] 225 - self.k > 0 && self.threshold.map_or(true, |t| distance <= t) [INFO] [stdout] 225 + self.k > 0 && self.threshold.is_none_or(|t| distance <= t) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the following explicit lifetimes could be elided: 'k, 'v [INFO] [stdout] --> src/lp.rs:65:6 [INFO] [stdout] | [INFO] [stdout] 65 | impl<'k, 'v, K: Minkowski, V> Minkowski<&'v V> for &'k K {} [INFO] [stdout] | ^^ ^^ ^^ ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stdout] help: elide the lifetimes [INFO] [stdout] | [INFO] [stdout] 65 - impl<'k, 'v, K: Minkowski, V> Minkowski<&'v V> for &'k K {} [INFO] [stdout] 65 + impl, V> Minkowski<&V> for &K {} [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:57:17 [INFO] [stdout] | [INFO] [stdout] 57 | assert!(!(one < nan)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(one >= nan)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/util.rs:58:17 [INFO] [stdout] | [INFO] [stdout] 58 | assert!(!(nan < one)); [INFO] [stdout] | ^^^^^^^^^^^^ help: try: `(nan >= one)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 16.92s [INFO] running `Command { std: "docker" "inspect" "11749c0828cb19d3bb78d400e4ff890f861391238ac8619973239d67f5b2b271", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "11749c0828cb19d3bb78d400e4ff890f861391238ac8619973239d67f5b2b271", kill_on_drop: false }` [INFO] [stdout] 11749c0828cb19d3bb78d400e4ff890f861391238ac8619973239d67f5b2b271