[INFO] fetching crate abpfiff 0.1.1-alpha.with.debug... [INFO] linting abpfiff-0.1.1-alpha.with.debug against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate abpfiff 0.1.1-alpha.with.debug into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate abpfiff 0.1.1-alpha.with.debug [INFO] finished tweaking crates.io crate abpfiff 0.1.1-alpha.with.debug [INFO] tweaked toml for crates.io crate abpfiff 0.1.1-alpha.with.debug written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate abpfiff 0.1.1-alpha.with.debug on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 2 packages to latest compatible versions [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 88111f64a88bac7c31732eb94b40820d0bf8447d405e8d31f19715e2524734b0 [INFO] running `Command { std: "docker" "start" "-a" "88111f64a88bac7c31732eb94b40820d0bf8447d405e8d31f19715e2524734b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "88111f64a88bac7c31732eb94b40820d0bf8447d405e8d31f19715e2524734b0", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "88111f64a88bac7c31732eb94b40820d0bf8447d405e8d31f19715e2524734b0", kill_on_drop: false }` [INFO] [stdout] 88111f64a88bac7c31732eb94b40820d0bf8447d405e8d31f19715e2524734b0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 57b8a91692306d0a0ef265f6e213a7a28dcf35c195095d463f3d3f596b6d9785 [INFO] running `Command { std: "docker" "start" "-a" "57b8a91692306d0a0ef265f6e213a7a28dcf35c195095d463f3d3f596b6d9785", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Checking abpfiff v0.1.1-alpha.with.debug (/opt/rustwide/workdir) [INFO] [stdout] warning: unexpected `cfg` condition value: `elf` [INFO] [stdout] --> src/lib.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(feature = "elf")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `elf` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BpfBtfInfo` is never constructed [INFO] [stdout] --> src/bpf.rs:424:8 [INFO] [stdout] | [INFO] [stdout] 424 | struct BpfBtfInfo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `BpfProgRun` is never used [INFO] [stdout] --> src/bpf.rs:484:11 [INFO] [stdout] | [INFO] [stdout] 482 | impl BpfCmd { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] 483 | #[allow(non_upper_case_globals)] [INFO] [stdout] 484 | const BpfProgRun: Self = Self::ProgTestRun; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_xdp_info` is never used [INFO] [stdout] --> src/netlink.rs:416:8 [INFO] [stdout] | [INFO] [stdout] 43 | impl Netlink { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 416 | fn get_xdp_info() -> ControlFlow<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/nlattr.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum IflaType { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 7 | IFLA_UNSPEC, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 8 | IFLA_ADDRESS, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | IFLA_BROADCAST, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 10 | IFLA_IFNAME, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 11 | IFLA_MTU, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 12 | IFLA_LINK, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 13 | IFLA_QDISC, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 14 | IFLA_STATS, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | IFLA_COST, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 16 | IFLA_PRIORITY, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 17 | IFLA_MASTER, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 18 | IFLA_WIRELESS, /* Wireless Extension event - see wireless.h */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | IFLA_PROTINFO, /* Protocol specific information for a link */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 20 | IFLA_TXQLEN, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | IFLA_MAP, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | IFLA_WEIGHT, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | IFLA_OPERSTATE, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | IFLA_LINKMODE, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 25 | IFLA_LINKINFO, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 26 | IFLA_NET_NS_PID, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | IFLA_IFALIAS, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 28 | IFLA_NUM_VF, /* Number of VFs if device is SR-IOV PF */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 29 | IFLA_VFINFO_LIST, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 30 | IFLA_STATS64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 31 | IFLA_VF_PORTS, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 32 | IFLA_PORT_SELF, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 33 | IFLA_AF_SPEC, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 34 | IFLA_GROUP, /* Group the device belongs to */ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 35 | IFLA_NET_NS_FD, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 36 | IFLA_EXT_MASK, /* Extended info mask, VFs, etc */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | IFLA_PROMISCUITY, /* Promiscuity count: > 0 means acts PROMISC */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 38 | IFLA_NUM_TX_QUEUES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | IFLA_NUM_RX_QUEUES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | IFLA_CARRIER, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 41 | IFLA_PHYS_PORT_ID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 42 | IFLA_CARRIER_CHANGES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 43 | IFLA_PHYS_SWITCH_ID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 44 | IFLA_LINK_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 45 | IFLA_PHYS_PORT_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | IFLA_PROTO_DOWN, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | IFLA_GSO_MAX_SEGS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 48 | IFLA_GSO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 49 | IFLA_PAD, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 50 | IFLA_XDP, [INFO] [stdout] 51 | IFLA_EVENT, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | IFLA_NEW_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 53 | // IFLA_IF_NETNSID, /* has a new new alias, below */ [INFO] [stdout] 54 | IFLA_TARGET_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 55 | IFLA_CARRIER_UP_COUNT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 56 | IFLA_CARRIER_DOWN_COUNT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | IFLA_NEW_IFINDEX, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | IFLA_MIN_MTU, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 59 | IFLA_MAX_MTU, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 60 | IFLA_PROP_LIST, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 61 | IFLA_ALT_IFNAME, /* Alternative ifname */ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 62 | IFLA_PERM_ADDRESS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 63 | IFLA_PROTO_DOWN_REASON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | IFLA_PARENT_DEV_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 69 | IFLA_PARENT_DEV_BUS_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 70 | IFLA_GRO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | IFLA_TSO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | IFLA_TSO_MAX_SEGS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NLA_F_NET_BYTEORDER` is never used [INFO] [stdout] --> src/nlattr.rs:78:11 [INFO] [stdout] | [INFO] [stdout] 78 | pub const NLA_F_NET_BYTEORDER: u16 = 1 << 15; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IFLA_XDP_UNSPEC` is never constructed [INFO] [stdout] --> src/nlattr.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub enum IflaXdp { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] 83 | IFLA_XDP_UNSPEC, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bpf.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | return Err(self.errno()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Err(self.errno()); [INFO] [stdout] 147 + Err(self.errno()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bpf.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | return Err(self.errno()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Err(self.errno()); [INFO] [stdout] 185 + Err(self.errno()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/bpf.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | pub unsafe fn raw_info_by_fd(&self, fd: libc::c_int, info: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/netlink.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / if { [INFO] [stdout] 60 | | let one: libc::c_int = 1; [INFO] [stdout] 61 | | let size = core::mem::size_of_val(&one) as libc::socklen_t; [INFO] [stdout] ... | [INFO] [stdout] 72 | | } < 0 [INFO] [stdout] 73 | | {} [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] help: you can remove it [INFO] [stdout] | [INFO] [stdout] 59 ~ ({ [INFO] [stdout] 60 + let one: libc::c_int = 1; [INFO] [stdout] 61 + let size = core::mem::size_of_val(&one) as libc::socklen_t; [INFO] [stdout] 62 + [INFO] [stdout] 63 + unsafe { [INFO] [stdout] 64 + (sys.setsockopt)( [INFO] [stdout] 65 + sock.0, [INFO] [stdout] 66 + libc::SOL_NETLINK, [INFO] [stdout] 67 + Self::EXT_ACK, [INFO] [stdout] 68 + (&one) as *const _ as *const libc::c_void, [INFO] [stdout] 69 + size, [INFO] [stdout] 70 + ) [INFO] [stdout] 71 + } [INFO] [stdout] 72 + } < 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NetlinkRecvBuffer` [INFO] [stdout] --> src/netlink.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | / pub const fn new() -> Self { [INFO] [stdout] 423 | | let iovec = libc::iovec { [INFO] [stdout] 424 | | iov_base: core::ptr::null_mut(), [INFO] [stdout] 425 | | iov_len: 0, [INFO] [stdout] ... | [INFO] [stdout] 444 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 421 + impl Default for NetlinkRecvBuffer { [INFO] [stdout] 422 + fn default() -> Self { [INFO] [stdout] 423 + Self::new() [INFO] [stdout] 424 + } [INFO] [stdout] 425 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nlattr.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | if !(core::mem::size_of::() <= len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(core::mem::size_of::() > len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/sys.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / pub fn new() -> ArcTable { [INFO] [stdout] 69 | | unsafe extern "C" fn _open(msg: *const c_char, flags: c_int, mode: libc::mode_t) -> c_int { [INFO] [stdout] 70 | | libc::open(msg, flags, mode) [INFO] [stdout] ... | [INFO] [stdout] 102 | | ArcTable(Arc::new(FakeSys)) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sys.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return libc::syscall(libc::SYS_bpf, cmd, attr, size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return libc::syscall(libc::SYS_bpf, cmd, attr, size); [INFO] [stdout] 284 + libc::syscall(libc::SYS_bpf, cmd, attr, size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bpf_object__find_map_by_name` should have a snake case name [INFO] [stdout] --> src/lib.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn bpf_object__find_map_by_name() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `bpf_object_find_map_by_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unexpected `cfg` condition value: `elf` [INFO] [stdout] --> src/lib.rs:23:7 [INFO] [stdout] | [INFO] [stdout] 23 | #[cfg(feature = "elf")] [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove the condition [INFO] [stdout] | [INFO] [stdout] = note: no expected values for `feature` [INFO] [stdout] = help: consider adding `elf` as a feature in `Cargo.toml` [INFO] [stdout] = note: see for more information about checking conditional configuration [INFO] [stdout] = note: `#[warn(unexpected_cfgs)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `BpfBtfInfo` is never constructed [INFO] [stdout] --> src/bpf.rs:424:8 [INFO] [stdout] | [INFO] [stdout] 424 | struct BpfBtfInfo { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated constant `BpfProgRun` is never used [INFO] [stdout] --> src/bpf.rs:484:11 [INFO] [stdout] | [INFO] [stdout] 482 | impl BpfCmd { [INFO] [stdout] | ----------- associated constant in this implementation [INFO] [stdout] 483 | #[allow(non_upper_case_globals)] [INFO] [stdout] 484 | const BpfProgRun: Self = Self::ProgTestRun; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: associated function `get_xdp_info` is never used [INFO] [stdout] --> src/netlink.rs:416:8 [INFO] [stdout] | [INFO] [stdout] 43 | impl Netlink { [INFO] [stdout] | ------------ associated function in this implementation [INFO] [stdout] ... [INFO] [stdout] 416 | fn get_xdp_info() -> ControlFlow<()> { [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple variants are never constructed [INFO] [stdout] --> src/nlattr.rs:7:5 [INFO] [stdout] | [INFO] [stdout] 6 | pub enum IflaType { [INFO] [stdout] | -------- variants in this enum [INFO] [stdout] 7 | IFLA_UNSPEC, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 8 | IFLA_ADDRESS, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 9 | IFLA_BROADCAST, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 10 | IFLA_IFNAME, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 11 | IFLA_MTU, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 12 | IFLA_LINK, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 13 | IFLA_QDISC, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 14 | IFLA_STATS, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 15 | IFLA_COST, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] 16 | IFLA_PRIORITY, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 17 | IFLA_MASTER, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 18 | IFLA_WIRELESS, /* Wireless Extension event - see wireless.h */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 19 | IFLA_PROTINFO, /* Protocol specific information for a link */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 20 | IFLA_TXQLEN, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 21 | IFLA_MAP, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 22 | IFLA_WEIGHT, [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 23 | IFLA_OPERSTATE, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 24 | IFLA_LINKMODE, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 25 | IFLA_LINKINFO, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 26 | IFLA_NET_NS_PID, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 27 | IFLA_IFALIAS, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 28 | IFLA_NUM_VF, /* Number of VFs if device is SR-IOV PF */ [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] 29 | IFLA_VFINFO_LIST, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 30 | IFLA_STATS64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 31 | IFLA_VF_PORTS, [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 32 | IFLA_PORT_SELF, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 33 | IFLA_AF_SPEC, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 34 | IFLA_GROUP, /* Group the device belongs to */ [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 35 | IFLA_NET_NS_FD, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 36 | IFLA_EXT_MASK, /* Extended info mask, VFs, etc */ [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] 37 | IFLA_PROMISCUITY, /* Promiscuity count: > 0 means acts PROMISC */ [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 38 | IFLA_NUM_TX_QUEUES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 39 | IFLA_NUM_RX_QUEUES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 40 | IFLA_CARRIER, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 41 | IFLA_PHYS_PORT_ID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 42 | IFLA_CARRIER_CHANGES, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 43 | IFLA_PHYS_SWITCH_ID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 44 | IFLA_LINK_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 45 | IFLA_PHYS_PORT_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 46 | IFLA_PROTO_DOWN, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 47 | IFLA_GSO_MAX_SEGS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 48 | IFLA_GSO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 49 | IFLA_PAD, [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] 50 | IFLA_XDP, [INFO] [stdout] 51 | IFLA_EVENT, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] 52 | IFLA_NEW_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 53 | // IFLA_IF_NETNSID, /* has a new new alias, below */ [INFO] [stdout] 54 | IFLA_TARGET_NETNSID, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 55 | IFLA_CARRIER_UP_COUNT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 56 | IFLA_CARRIER_DOWN_COUNT, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 57 | IFLA_NEW_IFINDEX, [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] 58 | IFLA_MIN_MTU, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 59 | IFLA_MAX_MTU, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 60 | IFLA_PROP_LIST, [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] 61 | IFLA_ALT_IFNAME, /* Alternative ifname */ [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] 62 | IFLA_PERM_ADDRESS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 63 | IFLA_PROTO_DOWN_REASON, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 68 | IFLA_PARENT_DEV_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 69 | IFLA_PARENT_DEV_BUS_NAME, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] 70 | IFLA_GRO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 71 | IFLA_TSO_MAX_SIZE, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] 72 | IFLA_TSO_MAX_SEGS, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant `NLA_F_NET_BYTEORDER` is never used [INFO] [stdout] --> src/nlattr.rs:78:11 [INFO] [stdout] | [INFO] [stdout] 78 | pub const NLA_F_NET_BYTEORDER: u16 = 1 << 15; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variant `IFLA_XDP_UNSPEC` is never constructed [INFO] [stdout] --> src/nlattr.rs:83:5 [INFO] [stdout] | [INFO] [stdout] 82 | pub enum IflaXdp { [INFO] [stdout] | ------- variant in this enum [INFO] [stdout] 83 | IFLA_XDP_UNSPEC, [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bpf.rs:147:13 [INFO] [stdout] | [INFO] [stdout] 147 | return Err(self.errno()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 147 - return Err(self.errno()); [INFO] [stdout] 147 + Err(self.errno()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/bpf.rs:185:13 [INFO] [stdout] | [INFO] [stdout] 185 | return Err(self.errno()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 185 - return Err(self.errno()); [INFO] [stdout] 185 + Err(self.errno()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unsafe function's docs are missing a `# Safety` section [INFO] [stdout] --> src/bpf.rs:191:5 [INFO] [stdout] | [INFO] [stdout] 191 | pub unsafe fn raw_info_by_fd(&self, fd: libc::c_int, info: &mut [u8]) -> Result { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#missing_safety_doc [INFO] [stdout] = note: `#[warn(clippy::missing_safety_doc)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` branch is empty [INFO] [stdout] --> src/netlink.rs:59:9 [INFO] [stdout] | [INFO] [stdout] 59 | / if { [INFO] [stdout] 60 | | let one: libc::c_int = 1; [INFO] [stdout] 61 | | let size = core::mem::size_of_val(&one) as libc::socklen_t; [INFO] [stdout] ... | [INFO] [stdout] 72 | | } < 0 [INFO] [stdout] 73 | | {} [INFO] [stdout] | |__________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_ifs [INFO] [stdout] = note: `#[warn(clippy::needless_ifs)]` on by default [INFO] [stdout] help: you can remove it [INFO] [stdout] | [INFO] [stdout] 59 ~ ({ [INFO] [stdout] 60 + let one: libc::c_int = 1; [INFO] [stdout] 61 + let size = core::mem::size_of_val(&one) as libc::socklen_t; [INFO] [stdout] 62 + [INFO] [stdout] 63 + unsafe { [INFO] [stdout] 64 + (sys.setsockopt)( [INFO] [stdout] 65 + sock.0, [INFO] [stdout] 66 + libc::SOL_NETLINK, [INFO] [stdout] 67 + Self::EXT_ACK, [INFO] [stdout] 68 + (&one) as *const _ as *const libc::c_void, [INFO] [stdout] 69 + size, [INFO] [stdout] 70 + ) [INFO] [stdout] 71 + } [INFO] [stdout] 72 + } < 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `NetlinkRecvBuffer` [INFO] [stdout] --> src/netlink.rs:422:5 [INFO] [stdout] | [INFO] [stdout] 422 | / pub const fn new() -> Self { [INFO] [stdout] 423 | | let iovec = libc::iovec { [INFO] [stdout] 424 | | iov_base: core::ptr::null_mut(), [INFO] [stdout] 425 | | iov_len: 0, [INFO] [stdout] ... | [INFO] [stdout] 444 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 421 + impl Default for NetlinkRecvBuffer { [INFO] [stdout] 422 + fn default() -> Self { [INFO] [stdout] 423 + Self::new() [INFO] [stdout] 424 + } [INFO] [stdout] 425 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nlattr.rs:132:12 [INFO] [stdout] | [INFO] [stdout] 132 | if !(core::mem::size_of::() <= len) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(core::mem::size_of::() > len)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods called `new` usually return `Self` [INFO] [stdout] --> src/sys.rs:68:5 [INFO] [stdout] | [INFO] [stdout] 68 | / pub fn new() -> ArcTable { [INFO] [stdout] 69 | | unsafe extern "C" fn _open(msg: *const c_char, flags: c_int, mode: libc::mode_t) -> c_int { [INFO] [stdout] 70 | | libc::open(msg, flags, mode) [INFO] [stdout] ... | [INFO] [stdout] 102 | | ArcTable(Arc::new(FakeSys)) [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_ret_no_self [INFO] [stdout] = note: `#[warn(clippy::new_ret_no_self)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/sys.rs:284:5 [INFO] [stdout] | [INFO] [stdout] 284 | return libc::syscall(libc::SYS_bpf, cmd, attr, size); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 284 - return libc::syscall(libc::SYS_bpf, cmd, attr, size); [INFO] [stdout] 284 + libc::syscall(libc::SYS_bpf, cmd, attr, size) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `bpf_object__find_map_by_name` should have a snake case name [INFO] [stdout] --> src/lib.rs:87:8 [INFO] [stdout] | [INFO] [stdout] 87 | pub fn bpf_object__find_map_by_name() {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: convert the identifier to snake case: `bpf_object_find_map_by_name` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.17s [INFO] running `Command { std: "docker" "inspect" "57b8a91692306d0a0ef265f6e213a7a28dcf35c195095d463f3d3f596b6d9785", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "57b8a91692306d0a0ef265f6e213a7a28dcf35c195095d463f3d3f596b6d9785", kill_on_drop: false }` [INFO] [stdout] 57b8a91692306d0a0ef265f6e213a7a28dcf35c195095d463f3d3f596b6d9785