[INFO] fetching crate TEST_zap 0.6.1... [INFO] linting TEST_zap-0.6.1 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate TEST_zap 0.6.1 into /workspace/builds/worker-0-tc1/source [INFO] started tweaking crates.io crate TEST_zap 0.6.1 [INFO] finished tweaking crates.io crate TEST_zap 0.6.1 [INFO] tweaked toml for crates.io crate TEST_zap 0.6.1 written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate TEST_zap 0.6.1 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 70 packages to latest compatible versions [INFO] [stderr] Adding codespan-reporting v0.11.1 (available: v0.13.1) [INFO] [stderr] Adding lalrpop v0.20.2 (available: v0.23.1) [INFO] [stderr] Adding lalrpop-util v0.20.2 (available: v0.23.1) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded ena v0.14.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5af4e908031fc94072e6b4fe898ae1bd64947dedcdb7d2f98d2e10d92a698536 [INFO] running `Command { std: "docker" "start" "-a" "5af4e908031fc94072e6b4fe898ae1bd64947dedcdb7d2f98d2e10d92a698536", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5af4e908031fc94072e6b4fe898ae1bd64947dedcdb7d2f98d2e10d92a698536", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5af4e908031fc94072e6b4fe898ae1bd64947dedcdb7d2f98d2e10d92a698536", kill_on_drop: false }` [INFO] [stdout] 5af4e908031fc94072e6b4fe898ae1bd64947dedcdb7d2f98d2e10d92a698536 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0ea0b20fd170d4d3d2e4b261546ae022248dd255e140d49c708845e533b3b5d2 [INFO] running `Command { std: "docker" "start" "-a" "0ea0b20fd170d4d3d2e4b261546ae022248dd255e140d49c708845e533b3b5d2", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling wasm-bindgen-shared v0.2.114 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling smallvec v1.15.1 [INFO] [stderr] Compiling scopeguard v1.2.0 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling tiny-keccak v2.0.2 [INFO] [stderr] Compiling parking_lot_core v0.9.12 [INFO] [stderr] Compiling crunchy v0.2.4 [INFO] [stderr] Compiling bit-vec v0.6.3 [INFO] [stderr] Compiling precomputed-hash v0.1.1 [INFO] [stderr] Compiling fixedbitset v0.4.2 [INFO] [stderr] Compiling new_debug_unreachable v1.0.6 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling ena v0.14.4 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling bumpalo v3.20.2 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling lock_api v0.4.14 [INFO] [stderr] Compiling bit-set v0.5.3 [INFO] [stderr] Compiling petgraph v0.6.5 [INFO] [stderr] Compiling pico-args v0.5.0 [INFO] [stderr] Compiling wasm-bindgen v0.2.114 [INFO] [stderr] Checking once_cell v1.21.4 [INFO] [stderr] Compiling itertools v0.11.0 [INFO] [stderr] Checking aho-corasick v1.1.4 [INFO] [stderr] Checking regex-automata v0.4.14 [INFO] [stderr] Compiling dirs-sys-next v0.1.2 [INFO] [stderr] Compiling dirs-next v2.0.0 [INFO] [stderr] Compiling parking_lot v0.12.5 [INFO] [stderr] Compiling term v0.7.0 [INFO] [stderr] Compiling ascii-canvas v3.0.0 [INFO] [stderr] Compiling string_cache v0.8.9 [INFO] [stderr] Checking lalrpop-util v0.20.2 [INFO] [stderr] Compiling wasm-bindgen-macro-support v0.2.114 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling lalrpop v0.20.2 [INFO] [stderr] Compiling wasm-bindgen-macro v0.2.114 [INFO] [stderr] Compiling TEST_zap v0.6.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/TEST_zap-9dc0389007268cf5/out/grammar.rs:18885:1 [INFO] [stdout] | [INFO] [stdout] 18885 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 18886 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18887 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after outer attribute [INFO] [stdout] --> /opt/rustwide/target/debug/build/TEST_zap-9dc0389007268cf5/out/grammar.rs:18885:1 [INFO] [stdout] | [INFO] [stdout] 18885 | / #[allow(clippy::type_complexity, dead_code)] [INFO] [stdout] 18886 | | [INFO] [stdout] | |_^ [INFO] [stdout] 18887 | pub trait __ToTriple<'input, > [INFO] [stdout] | --------------------- the attribute applies to this trait [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_outer_attr [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_outer_attr)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `start`, `end`, and `len` are never used [INFO] [stdout] --> src/parser/syntax_tree.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Spanned { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 8 | fn start(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn end(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.min` after checking its variant with `is_some` [INFO] [stdout] --> src/config.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 333 | if self.min.is_some() && self.min == self.max { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 334 | Some(self.min.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `class` after checking its variant with `is_some` [INFO] [stdout] --> src/output/luau/mod.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 390 | if checks && class.is_some() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 393 | class = class.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: methods `start`, `end`, and `len` are never used [INFO] [stdout] --> src/parser/syntax_tree.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 5 | pub trait Spanned { [INFO] [stdout] | ------- methods in this trait [INFO] [stdout] ... [INFO] [stdout] 8 | fn start(&self) -> usize { [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 12 | fn end(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] ... [INFO] [stdout] 16 | fn len(&self) -> usize { [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `self.min` after checking its variant with `is_some` [INFO] [stdout] --> src/config.rs:334:9 [INFO] [stdout] | [INFO] [stdout] 333 | if self.min.is_some() && self.min == self.max { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 334 | Some(self.min.unwrap()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/convert.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 315 | } else if !max.is_some_and(|max| max < self.max_unreliable_size) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `max.is_none_or(|max| max >= self.max_unreliable_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_some` [INFO] [stdout] --> src/parser/convert.rs:306:21 [INFO] [stdout] | [INFO] [stdout] 305 | if data.is_some() && evty == EvType::Unreliable { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 306 | let (min, max) = data.as_ref().unwrap().size(tydecls, &mut HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_none()` [INFO] [stdout] --> src/parser/convert.rs:431:23 [INFO] [stdout] | [INFO] [stdout] 431 | if self.tydecls.get(name).is_none() { [INFO] [stdout] | -------------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.tydecls.contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `class` after checking its variant with `is_some` [INFO] [stdout] --> src/output/luau/mod.rs:393:16 [INFO] [stdout] | [INFO] [stdout] 390 | if checks && class.is_some() { [INFO] [stdout] | --------------- the check is happening here [INFO] [stdout] ... [INFO] [stdout] 393 | class = class.unwrap(), [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/parser/convert.rs:315:14 [INFO] [stdout] | [INFO] [stdout] 315 | } else if !max.is_some_and(|max| max < self.max_unreliable_size) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `max.is_none_or(|max| max >= self.max_unreliable_size)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `data` after checking its variant with `is_some` [INFO] [stdout] --> src/parser/convert.rs:306:21 [INFO] [stdout] | [INFO] [stdout] 305 | if data.is_some() && evty == EvType::Unreliable { [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 306 | let (min, max) = data.as_ref().unwrap().size(tydecls, &mut HashSet::new()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `get(name).is_none()` [INFO] [stdout] --> src/parser/convert.rs:431:23 [INFO] [stdout] | [INFO] [stdout] 431 | if self.tydecls.get(name).is_none() { [INFO] [stdout] | -------------^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: replace it with: `!self.tydecls.contains_key(name)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_get_then_check [INFO] [stdout] = note: `#[warn(clippy::unnecessary_get_then_check)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `TEST_zap` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `test_zap` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 26.13s [INFO] running `Command { std: "docker" "inspect" "0ea0b20fd170d4d3d2e4b261546ae022248dd255e140d49c708845e533b3b5d2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0ea0b20fd170d4d3d2e4b261546ae022248dd255e140d49c708845e533b3b5d2", kill_on_drop: false }` [INFO] [stdout] 0ea0b20fd170d4d3d2e4b261546ae022248dd255e140d49c708845e533b3b5d2