[INFO] fetching crate IMAPServer-shared 0.1.0... [INFO] linting IMAPServer-shared-0.1.0 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate IMAPServer-shared 0.1.0 into /workspace/builds/worker-1-tc1/source [INFO] started tweaking crates.io crate IMAPServer-shared 0.1.0 [INFO] finished tweaking crates.io crate IMAPServer-shared 0.1.0 [INFO] tweaked toml for crates.io crate IMAPServer-shared 0.1.0 written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate IMAPServer-shared 0.1.0 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "generate-lockfile" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Locking 152 packages to latest compatible versions [INFO] [stderr] Adding diesel v1.4.8 (available: v2.3.7) [INFO] [stderr] Adding diesel_migrations v1.4.0 (available: v2.3.1) [INFO] [stderr] Adding rand v0.7.3 (available: v0.10.0) [INFO] [stderr] Adding serde_yaml v0.8.26 (available: v0.9.34+deprecated) [INFO] [stderr] Adding tokio v0.2.25 (available: v1.50.0) [INFO] [stderr] Adding tokio-util v0.2.0 (available: v0.7.18) [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded clang-sys v0.26.4 [INFO] [stderr] Downloaded which v2.0.1 [INFO] [stderr] Downloaded cexpr v0.3.6 [INFO] [stderr] Downloaded bindgen v0.48.1 [INFO] [stderr] Downloaded rustc-demangle v0.1.27 [INFO] [stderr] Downloaded tokio v0.2.25 [INFO] [stderr] Downloaded argonautica v0.2.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8c53b93346dcbcbbc97bca8e1097ffff4e2bcb9a867ed734467c61b386617d04 [INFO] running `Command { std: "docker" "start" "-a" "8c53b93346dcbcbbc97bca8e1097ffff4e2bcb9a867ed734467c61b386617d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8c53b93346dcbcbbc97bca8e1097ffff4e2bcb9a867ed734467c61b386617d04", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8c53b93346dcbcbbc97bca8e1097ffff4e2bcb9a867ed734467c61b386617d04", kill_on_drop: false }` [INFO] [stdout] 8c53b93346dcbcbbc97bca8e1097ffff4e2bcb9a867ed734467c61b386617d04 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d3f343c88124380f10cc20684088a7b16ddff9ce8ed4887eb2520ef45d868c07 [INFO] running `Command { std: "docker" "start" "-a" "d3f343c88124380f10cc20684088a7b16ddff9ce8ed4887eb2520ef45d868c07", kill_on_drop: false }` [INFO] [stderr] Compiling libc v0.2.183 [INFO] [stderr] Compiling quote v1.0.45 [INFO] [stderr] Compiling memchr v2.8.0 [INFO] [stderr] Compiling object v0.37.3 [INFO] [stderr] Compiling failure_derive v0.1.8 [INFO] [stderr] Compiling unicode-xid v0.2.6 [INFO] [stderr] Compiling autocfg v0.1.8 [INFO] [stderr] Compiling libsqlite3-sys v0.22.2 [INFO] [stderr] Compiling nom v4.2.3 [INFO] [stderr] Compiling gimli v0.32.3 [INFO] [stderr] Compiling glob v0.2.11 [INFO] [stderr] Compiling miniz_oxide v0.8.9 [INFO] [stderr] Compiling regex-syntax v0.8.10 [INFO] [stderr] Compiling proc-macro2 v0.4.30 [INFO] [stderr] Checking slab v0.4.12 [INFO] [stderr] Compiling rustc-demangle v0.1.27 [INFO] [stderr] Checking log v0.4.29 [INFO] [stderr] Checking futures-core v0.3.32 [INFO] [stderr] Compiling unicode-width v0.1.14 [INFO] [stderr] Compiling humantime v1.3.0 [INFO] [stderr] Compiling textwrap v0.11.0 [INFO] [stderr] Compiling strsim v0.8.0 [INFO] [stderr] Checking futures v0.1.31 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Compiling vec_map v0.8.2 [INFO] [stderr] Compiling zerocopy v0.8.42 [INFO] [stderr] Compiling bindgen v0.48.1 [INFO] [stderr] Checking futures-sink v0.3.32 [INFO] [stderr] Compiling clang-sys v0.26.4 [INFO] [stderr] Compiling termcolor v1.4.1 [INFO] [stderr] Compiling scopeguard v0.3.3 [INFO] [stderr] Compiling ansi_term v0.12.1 [INFO] [stderr] Compiling hashbrown v0.1.8 [INFO] [stderr] Compiling rand_chacha v0.1.1 [INFO] [stderr] Compiling rand_pcg v0.1.2 [INFO] [stderr] Compiling aho-corasick v1.1.4 [INFO] [stderr] Compiling remove_dir_all v0.5.3 [INFO] [stderr] Compiling peeking_take_while v0.1.2 [INFO] [stderr] Checking futures-channel v0.3.32 [INFO] [stderr] Compiling quote v0.6.13 [INFO] [stderr] Compiling rand v0.6.5 [INFO] [stderr] Compiling indexmap v1.9.3 [INFO] [stderr] Checking pin-project-lite v0.2.17 [INFO] [stderr] Checking futures-io v0.3.32 [INFO] [stderr] Checking futures-task v0.3.32 [INFO] [stderr] Checking net2 v0.2.39 [INFO] [stderr] Checking iovec v0.1.4 [INFO] [stderr] Checking num_cpus v1.17.0 [INFO] [stderr] Checking errno v0.3.14 [INFO] [stderr] Compiling cexpr v0.3.6 [INFO] [stderr] Checking getrandom v0.1.16 [INFO] [stderr] Checking signal-hook-registry v1.4.8 [INFO] [stderr] Compiling jobserver v0.1.34 [INFO] [stderr] Compiling addr2line v0.25.1 [INFO] [stderr] Compiling atty v0.2.14 [INFO] [stderr] Compiling rand v0.4.6 [INFO] [stderr] Checking mio v0.6.23 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Compiling cc v1.2.57 [INFO] [stderr] Compiling clap v2.34.0 [INFO] [stderr] Checking rand_os v0.1.3 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling tempdir v0.3.7 [INFO] [stderr] Checking pin-project-lite v0.1.12 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Compiling regex-automata v0.4.14 [INFO] [stderr] Checking mio-uds v0.6.8 [INFO] [stderr] Checking futures-cpupool v0.1.8 [INFO] [stderr] Checking base64 v0.10.1 [INFO] [stderr] Checking scopeguard v1.2.0 [INFO] [stderr] Compiling libloading v0.5.2 [INFO] [stderr] Compiling regex v1.12.3 [INFO] [stderr] Compiling synstructure v0.12.6 [INFO] [stderr] Compiling env_logger v0.6.2 [INFO] [stderr] Compiling futures-macro v0.3.32 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling backtrace v0.3.76 [INFO] [stderr] Checking ppv-lite86 v0.2.21 [INFO] [stderr] Compiling diesel_derives v1.4.1 [INFO] [stderr] Compiling tokio-macros v0.2.6 [INFO] [stderr] Checking futures-util v0.3.32 [INFO] [stderr] Compiling failure v0.1.8 [INFO] [stderr] Checking tokio v0.2.25 [INFO] [stderr] Checking rand_chacha v0.2.2 [INFO] [stderr] Compiling which v2.0.1 [INFO] [stderr] Checking rand v0.7.3 [INFO] [stderr] Compiling diesel v1.4.8 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking serde_yaml v0.8.26 [INFO] [stderr] Checking tokio-util v0.2.0 [INFO] [stderr] Checking futures-executor v0.3.32 [INFO] [stderr] Checking futures v0.3.32 [INFO] [stderr] Compiling argonautica v0.2.0 [INFO] [stderr] Checking migrations_internals v1.4.1 [INFO] [stderr] Compiling migrations_macros v1.4.2 [INFO] [stderr] Checking diesel_migrations v1.4.0 [INFO] [stderr] Checking IMAPServer-shared v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/mailbox/mod.rs:49:59 [INFO] [stdout] | [INFO] [stdout] 49 | let random_number_int: i32 = rng.gen_range(0, 2 ^ 32 - 1); [INFO] [stdout] | ^^^^^^^^^^ help: consider parenthesizing your expression: `2 ^ (32 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/tests.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use diesel; [INFO] [stdout] | ^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: operator precedence might not be obvious [INFO] [stdout] --> src/mailbox/mod.rs:49:59 [INFO] [stdout] | [INFO] [stdout] 49 | let random_number_int: i32 = rng.gen_range(0, 2 ^ 32 - 1); [INFO] [stdout] | ^^^^^^^^^^ help: consider parenthesizing your expression: `2 ^ (32 - 1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#precedence [INFO] [stdout] = note: `#[warn(clippy::precedence)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `uid_validity_identifier` are never read [INFO] [stdout] --> src/models.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct User { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 5 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 8 | pub uid_validity_identifier: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `User` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return Some(config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Some(config); [INFO] [stdout] 42 + Some(config) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return None; [INFO] [stdout] 46 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | return Some(deserialized_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Some(deserialized_config); [INFO] [stdout] 67 + Some(deserialized_config) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | return Config::new().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Config::new().await; [INFO] [stdout] 69 + Config::new().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return Config::new().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Config::new().await; [INFO] [stdout] 75 + Config::new().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | / return Some(Mailbox { [INFO] [stdout] 68 | | mailbox_root, [INFO] [stdout] 69 | | user, [INFO] [stdout] 70 | | password_hash: m.password_hash, [INFO] [stdout] 71 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ Some(Mailbox { [INFO] [stdout] 68 + mailbox_root, [INFO] [stdout] 69 + user, [INFO] [stdout] 70 + password_hash: m.password_hash, [INFO] [stdout] 71 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / return Some(Mailbox { [INFO] [stdout] 88 | | mailbox_root, [INFO] [stdout] 89 | | user: user_local, [INFO] [stdout] 90 | | password_hash: password_hash_new, [INFO] [stdout] 91 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Some(Mailbox { [INFO] [stdout] 88 + mailbox_root, [INFO] [stdout] 89 + user: user_local, [INFO] [stdout] 90 + password_hash: password_hash_new, [INFO] [stdout] 91 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(()); [INFO] [stdout] 156 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(()); [INFO] [stdout] 158 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(()); [INFO] [stdout] 162 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `id` and `uid_validity_identifier` are never read [INFO] [stdout] --> src/models.rs:5:9 [INFO] [stdout] | [INFO] [stdout] 4 | pub struct User { [INFO] [stdout] | ---- fields in this struct [INFO] [stdout] 5 | pub id: i32, [INFO] [stdout] | ^^ [INFO] [stdout] ... [INFO] [stdout] 8 | pub uid_validity_identifier: String, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `User` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `args.get(args.len() - 1)` [INFO] [stdout] --> src/mailbox/mod.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | let searched = args.get(args.len() - 1).expect("unable to get searched path").replace("\"", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mailbox/mod.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if dirs_lsub.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dirs_lsub.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `args.get(args.len() - 1)` [INFO] [stdout] --> src/mailbox/mod.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 225 | let searched = args.get(args.len() - 1).expect("unable to get searched path").replace("\"", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mailbox/mod.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 263 | if dirs_list.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dirs_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mailbox/mod.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | let path = path.join(&path_part.as_ref().to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path_part.as_ref().to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/mailbox/mod.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | let path = path.join(&path_part.as_ref().to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `path_part.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/mailbox/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | / match metadata { [INFO] [stdout] 284 | | Err(_) => { [INFO] [stdout] 285 | | warn!("Mailbox folder {:?} was missing. Recreating", &path); [INFO] [stdout] ... | [INFO] [stdout] 289 | | Ok(_) => {} [INFO] [stdout] 290 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ if let Err(_) = metadata { [INFO] [stdout] 284 + warn!("Mailbox folder {:?} was missing. Recreating", &path); [INFO] [stdout] 285 + [INFO] [stdout] 286 + create_dir_all(path).await? [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/database.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | .expect(&format!("Error connecting to {}", database_url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:42:17 [INFO] [stdout] | [INFO] [stdout] 42 | return Some(config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 42 - return Some(config); [INFO] [stdout] 42 + Some(config) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:46:17 [INFO] [stdout] | [INFO] [stdout] 46 | return None; [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 46 - return None; [INFO] [stdout] 46 + None [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | return Some(deserialized_config); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 - return Some(deserialized_config); [INFO] [stdout] 67 + Some(deserialized_config) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:69:21 [INFO] [stdout] | [INFO] [stdout] 69 | return Config::new().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 69 - return Config::new().await; [INFO] [stdout] 69 + Config::new().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/config/mod.rs:75:17 [INFO] [stdout] | [INFO] [stdout] 75 | return Config::new().await; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return Config::new().await; [INFO] [stdout] 75 + Config::new().await [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:67:17 [INFO] [stdout] | [INFO] [stdout] 67 | / return Some(Mailbox { [INFO] [stdout] 68 | | mailbox_root, [INFO] [stdout] 69 | | user, [INFO] [stdout] 70 | | password_hash: m.password_hash, [INFO] [stdout] 71 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 67 ~ Some(Mailbox { [INFO] [stdout] 68 + mailbox_root, [INFO] [stdout] 69 + user, [INFO] [stdout] 70 + password_hash: m.password_hash, [INFO] [stdout] 71 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:87:17 [INFO] [stdout] | [INFO] [stdout] 87 | / return Some(Mailbox { [INFO] [stdout] 88 | | mailbox_root, [INFO] [stdout] 89 | | user: user_local, [INFO] [stdout] 90 | | password_hash: password_hash_new, [INFO] [stdout] 91 | | }); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 87 ~ Some(Mailbox { [INFO] [stdout] 88 + mailbox_root, [INFO] [stdout] 89 + user: user_local, [INFO] [stdout] 90 + password_hash: password_hash_new, [INFO] [stdout] 91 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tests.rs:8:24 [INFO] [stdout] | [INFO] [stdout] 8 | pub fn with_db(f: F) -> () [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] = note: `#[warn(clippy::unused_unit)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded unit return type [INFO] [stdout] --> src/tests.rs:10:29 [INFO] [stdout] | [INFO] [stdout] 10 | F: Fn(&SqliteConnection) -> (), [INFO] [stdout] | ^^^^^^ help: remove the `-> ()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_unit [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Queryable)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Queryable` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_queryable_for_user` [INFO] [stdout] 4 | pub struct User { [INFO] [stdout] | ---- `User` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Queryable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Queryable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Queryable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | ^--------- [INFO] [stdout] | | [INFO] [stdout] | `Insertable` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | -^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Insertable` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | ^--------- [INFO] [stdout] | | [INFO] [stdout] | `UndecoratedInsertRecord` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:156:21 [INFO] [stdout] | [INFO] [stdout] 156 | return Ok(()); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 156 - return Ok(()); [INFO] [stdout] 156 + Ok(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | `table` is not local [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_table` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:158:21 [INFO] [stdout] | [INFO] [stdout] 158 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 158 - return Err(()); [INFO] [stdout] 158 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/mailbox/mod.rs:162:17 [INFO] [stdout] | [INFO] [stdout] 162 | return Err(()); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 162 - return Err(()); [INFO] [stdout] 162 + Err(()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `args.get(args.len() - 1)` [INFO] [stdout] --> src/mailbox/mod.rs:174:24 [INFO] [stdout] | [INFO] [stdout] 174 | let searched = args.get(args.len() - 1).expect("unable to get searched path").replace("\"", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] = note: `#[warn(clippy::get_last_with_len)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] | | -- `id` is not local [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_id` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mailbox/mod.rs:210:12 [INFO] [stdout] | [INFO] [stdout] 210 | if dirs_lsub.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dirs_lsub.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] | | ----- `email` is not local [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_email` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] 5 | | password_hash -> Text, [INFO] [stdout] | | ------------- `password_hash` is not local [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_password_hash` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing last element with `args.get(args.len() - 1)` [INFO] [stdout] --> src/mailbox/mod.rs:225:24 [INFO] [stdout] | [INFO] [stdout] 225 | let searched = args.get(args.len() - 1).expect("unable to get searched path").replace("\"", ""); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `args.last()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_last_with_len [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/mailbox/mod.rs:263:12 [INFO] [stdout] | [INFO] [stdout] 263 | if dirs_list.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!dirs_list.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] 5 | | password_hash -> Text, [INFO] [stdout] 6 | | uid_validity_identifier -> Text, [INFO] [stdout] | | ----------------------- `uid_validity_identifier` is not local [INFO] [stdout] 7 | | } [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_uid_validity_identifier` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/mailbox/mod.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | let path = path.join(&path_part.as_ref().to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `path_part.as_ref().to_owned()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `to_owned` [INFO] [stdout] --> src/mailbox/mod.rs:281:30 [INFO] [stdout] | [INFO] [stdout] 281 | let path = path.join(&path_part.as_ref().to_owned()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `path_part.as_ref()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/mailbox/mod.rs:283:9 [INFO] [stdout] | [INFO] [stdout] 283 | / match metadata { [INFO] [stdout] 284 | | Err(_) => { [INFO] [stdout] 285 | | warn!("Mailbox folder {:?} was missing. Recreating", &path); [INFO] [stdout] ... | [INFO] [stdout] 289 | | Ok(_) => {} [INFO] [stdout] 290 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 283 ~ if let Err(_) = metadata { [INFO] [stdout] 284 + warn!("Mailbox folder {:?} was missing. Recreating", &path); [INFO] [stdout] 285 + [INFO] [stdout] 286 + create_dir_all(path).await? [INFO] [stdout] 287 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/database.rs:11:10 [INFO] [stdout] | [INFO] [stdout] 11 | .expect(&format!("Error connecting to {}", database_url)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Error connecting to {}", database_url))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: crate `IMAPServer_shared` should have a snake case name [INFO] [stdout] | [INFO] [stdout] = help: convert the identifier to snake case: `imapserver_shared` [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:3:17 [INFO] [stdout] | [INFO] [stdout] 3 | #[derive(Debug, Queryable)] [INFO] [stdout] | ^-------- [INFO] [stdout] | | [INFO] [stdout] | `Queryable` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_queryable_for_user` [INFO] [stdout] 4 | pub struct User { [INFO] [stdout] | ---- `User` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Queryable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Queryable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: `#[warn(non_local_definitions)]` on by default [INFO] [stdout] = note: this warning originates in the derive macro `Queryable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | ^--------- [INFO] [stdout] | | [INFO] [stdout] | `Insertable` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | -^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | `Insertable` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/models.rs:11:17 [INFO] [stdout] | [INFO] [stdout] 11 | #[derive(Debug, Insertable)] [INFO] [stdout] | ^--------- [INFO] [stdout] | | [INFO] [stdout] | `UndecoratedInsertRecord` is not local [INFO] [stdout] | `table` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_insertable_for_newuser` [INFO] [stdout] 12 | #[table_name = "users"] [INFO] [stdout] 13 | pub struct NewUser<'a> { [INFO] [stdout] | ------- `NewUser` is not local [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `Insertable` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `Insertable` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `Insertable` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | | `table` is not local [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_table` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] | | -- `id` is not local [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_id` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] | | ----- `email` is not local [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_email` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] 5 | | password_hash -> Text, [INFO] [stdout] | | ------------- `password_hash` is not local [INFO] [stdout] ... | [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_password_hash` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-local `impl` definition, `impl` blocks should be written at the same level as their item [INFO] [stdout] --> src/schema.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | / table! { [INFO] [stdout] 2 | | users (id) { [INFO] [stdout] 3 | | id -> Integer, [INFO] [stdout] 4 | | email -> Text, [INFO] [stdout] 5 | | password_hash -> Text, [INFO] [stdout] 6 | | uid_validity_identifier -> Text, [INFO] [stdout] | | ----------------------- `uid_validity_identifier` is not local [INFO] [stdout] 7 | | } [INFO] [stdout] 8 | | } [INFO] [stdout] | | ^ [INFO] [stdout] | | | [INFO] [stdout] | |_`QueryId` is not local [INFO] [stdout] | move the `impl` block outside of this function `_impl_query_id_for_uid_validity_identifier` [INFO] [stdout] | [INFO] [stdout] = note: the derive macro `QueryId` defines the non-local `impl`, and may need to be changed [INFO] [stdout] = note: the derive macro `QueryId` may come from an old version of the `diesel_derives` crate, try updating your dependency with `cargo update -p diesel_derives` [INFO] [stdout] = note: an `impl` is never scoped, even when it is nested inside an item, as it may impact type checking outside of that item, which can be the case if neither the trait or the self type are at the same nesting level as the `impl` [INFO] [stdout] = note: this warning originates in the derive macro `QueryId` which comes from the expansion of the macro `table` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 54.28s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: cexpr v0.3.6, migrations_internals v1.4.1, nom v4.2.3 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "d3f343c88124380f10cc20684088a7b16ddff9ce8ed4887eb2520ef45d868c07", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d3f343c88124380f10cc20684088a7b16ddff9ce8ed4887eb2520ef45d868c07", kill_on_drop: false }` [INFO] [stdout] d3f343c88124380f10cc20684088a7b16ddff9ce8ed4887eb2520ef45d868c07