[INFO] fetching crate HPGO 0.9.2... [INFO] linting HPGO-0.9.2 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate HPGO 0.9.2 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate HPGO 0.9.2 [INFO] finished tweaking crates.io crate HPGO 0.9.2 [INFO] tweaked toml for crates.io crate HPGO 0.9.2 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate HPGO 0.9.2 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate HPGO 0.9.2 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded structopt-derive v0.4.0 [INFO] [stderr] Downloaded quickcheck v0.8.5 [INFO] [stderr] Downloaded rustversion v1.0.1 [INFO] [stderr] Downloaded structopt v0.3.7 [INFO] [stderr] Downloaded rand_os v0.2.2 [INFO] [stderr] Downloaded tinytemplate v1.0.3 [INFO] [stderr] Downloaded csv-core v0.1.6 [INFO] [stderr] Downloaded synstructure v0.12.3 [INFO] [stderr] Downloaded criterion-plot v0.4.0 [INFO] [stderr] Downloaded failure_derive v0.1.6 [INFO] [stderr] Downloaded blake2b_simd v0.5.9 [INFO] [stderr] Downloaded syn v1.0.13 [INFO] [stderr] Downloaded prettytable-rs v0.8.0 [INFO] [stderr] Downloaded criterion v0.3.0 [INFO] [stderr] Downloaded regex-automata v0.1.8 [INFO] [stderr] Downloaded inventory-impl v0.1.5 [INFO] [stderr] Downloaded proc-macro2 v1.0.7 [INFO] [stderr] Downloaded rand_xoshiro v0.3.1 [INFO] [stderr] Downloaded inventory v0.1.5 [INFO] [stderr] Downloaded quickcheck_macros v0.8.0 [INFO] [stderr] Downloaded proc-macro-error-attr v0.4.3 [INFO] [stderr] Downloaded proc-macro-error v0.4.4 [INFO] [stderr] Downloaded csv v1.1.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 54e28934bf40c4c371c1b25b7da2a6543e3f9b9961b7ad9efb03b254c8b015b5 [INFO] running `Command { std: "docker" "start" "-a" "54e28934bf40c4c371c1b25b7da2a6543e3f9b9961b7ad9efb03b254c8b015b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "54e28934bf40c4c371c1b25b7da2a6543e3f9b9961b7ad9efb03b254c8b015b5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "54e28934bf40c4c371c1b25b7da2a6543e3f9b9961b7ad9efb03b254c8b015b5", kill_on_drop: false }` [INFO] [stdout] 54e28934bf40c4c371c1b25b7da2a6543e3f9b9961b7ad9efb03b254c8b015b5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] f7290b6ac000fa7887df1c64431da0ffcfa7874c35ffb1fbb91b860d840e6148 [INFO] running `Command { std: "docker" "start" "-a" "f7290b6ac000fa7887df1c64431da0ffcfa7874c35ffb1fbb91b860d840e6148", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Compiling proc-macro2 v1.0.7 [INFO] [stderr] Compiling syn v1.0.13 [INFO] [stderr] Compiling memchr v2.2.1 [INFO] [stderr] Compiling crossbeam-utils v0.7.0 [INFO] [stderr] Compiling memoffset v0.5.3 [INFO] [stderr] Compiling crossbeam-epoch v0.8.0 [INFO] [stderr] Compiling num-traits v0.2.10 [INFO] [stderr] Checking either v1.5.3 [INFO] [stderr] Checking scopeguard v1.0.0 [INFO] [stderr] Checking itoa v0.4.4 [INFO] [stderr] Compiling thread_local v0.3.6 [INFO] [stderr] Checking regex-automata v0.1.8 [INFO] [stderr] Compiling ryu v1.0.2 [INFO] [stderr] Checking atty v0.2.13 [INFO] [stderr] Compiling regex-syntax v0.6.12 [INFO] [stderr] Compiling getrandom v0.1.13 [INFO] [stderr] Compiling quote v1.0.2 [INFO] [stderr] Compiling rayon-core v1.7.0 [INFO] [stderr] Checking csv-core v0.1.6 [INFO] [stderr] Checking crossbeam-queue v0.2.1 [INFO] [stderr] Checking num_cpus v1.11.1 [INFO] [stderr] Checking crossbeam-deque v0.7.2 [INFO] [stderr] Compiling unindent v0.1.5 [INFO] [stderr] Checking clap v2.33.0 [INFO] [stderr] Compiling aho-corasick v0.7.6 [INFO] [stderr] Compiling cast v0.2.3 [INFO] [stderr] Checking dirs v1.0.5 [INFO] [stderr] Checking term v0.5.2 [INFO] [stderr] Checking rand_core v0.5.1 [INFO] [stderr] Checking rayon v1.3.0 [INFO] [stderr] Compiling syn v0.15.44 [INFO] [stderr] Compiling regex v1.3.1 [INFO] [stderr] Checking encode_unicode v0.3.6 [INFO] [stderr] Checking ordered-float v1.0.2 [INFO] [stderr] Checking itertools v0.7.11 [INFO] [stderr] Checking itertools v0.8.2 [INFO] [stderr] Checking same-file v1.0.5 [INFO] [stderr] Checking walkdir v2.2.9 [INFO] [stderr] Checking rand_xoshiro v0.3.1 [INFO] [stderr] Checking rand_os v0.2.2 [INFO] [stderr] Checking criterion-plot v0.4.0 [INFO] [stderr] Checking env_logger v0.6.2 [INFO] [stderr] Checking quickcheck v0.8.5 [INFO] [stderr] Compiling syn-mid v0.4.0 [INFO] [stderr] Compiling pyo3-derive-backend v0.8.4 [INFO] [stderr] Compiling serde_derive v1.0.104 [INFO] [stderr] Compiling rustversion v1.0.1 [INFO] [stderr] Compiling proc-macro-hack v0.5.11 [INFO] [stderr] Compiling inventory-impl v0.1.5 [INFO] [stderr] Compiling ghost v0.1.1 [INFO] [stderr] Compiling ctor v0.1.12 [INFO] [stderr] Compiling quickcheck_macros v0.8.0 [INFO] [stderr] Compiling indoc-impl v0.3.4 [INFO] [stderr] Compiling paste-impl v0.1.6 [INFO] [stderr] Checking inventory v0.1.5 [INFO] [stderr] Compiling proc-macro-error v0.4.4 [INFO] [stderr] Compiling proc-macro-error-attr v0.4.3 [INFO] [stderr] Checking indoc v0.3.4 [INFO] [stderr] Compiling pyo3cls v0.8.4 [INFO] [stderr] Checking paste v0.1.6 [INFO] [stderr] Compiling structopt-derive v0.4.0 [INFO] [stderr] Checking structopt v0.3.7 [INFO] [stderr] Checking serde v1.0.104 [INFO] [stderr] Checking bstr v0.2.8 [INFO] [stderr] Checking serde_json v1.0.44 [INFO] [stderr] Checking csv v1.1.1 [INFO] [stderr] Checking tinytemplate v1.0.3 [INFO] [stderr] Checking prettytable-rs v0.8.0 [INFO] [stderr] Checking criterion v0.3.0 [INFO] [stderr] Compiling pyo3 v0.8.4 [INFO] [stderr] Checking HPGO v0.9.2 (/opt/rustwide/workdir) [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/analysis/cc_overlap.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | available_time: available_time, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | ETA: ETA, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ETA` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parallelism::*` [INFO] [stdout] --> src/analysis/gpu_memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use parallelism::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/analysis/gpu_memory.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | seps: seps, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `seps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | strategy: strategy, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strategy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | gids: gids, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `gids` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | desc: desc, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | compute_time: compute_time, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | activation_size: activation_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | output_activation_size: output_activation_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_activation_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | parameter_size: parameter_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/input/torch_graph_py.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | pub const TORCH_GRAPH_PY: &'static str = r#" [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | layers: layers, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | perf: perf, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `perf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | states: states, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::sorted` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use itertools::sorted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bitset` should have an upper camel case name [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | pub type bitset = Vec; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Bitset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | m: m, [INFO] [stdout] | ^^^^ help: replace it with: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | optimal_split: optimal_split, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optimal_split` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:585:13 [INFO] [stdout] | [INFO] [stdout] 585 | rp: rp, [INFO] [stdout] | ^^^^^^ help: replace it with: `rp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `environment::device` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use environment::device; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::sorted` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use itertools::sorted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bitset` should have an upper camel case name [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub type bitset = Vec; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Bitset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | m: m, [INFO] [stdout] | ^^^^ help: replace it with: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:464:25 [INFO] [stdout] | [INFO] [stdout] 464 | optimal_split: optimal_split, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optimal_split` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parallelism::*` [INFO] [stdout] --> src/parallelism/gpipe.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use parallelism::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/parallelism/gradient_accumulation.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/analysis/cc_overlap.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:60:13 [INFO] [stdout] | [INFO] [stdout] 60 | available_time: available_time, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `available_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:62:13 [INFO] [stdout] | [INFO] [stdout] 62 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/analysis/cc_overlap.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | ETA: ETA, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `ETA` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parallelism::*` [INFO] [stdout] --> src/analysis/gpu_memory.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use parallelism::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/analysis/gpu_memory.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:45:13 [INFO] [stdout] | [INFO] [stdout] 45 | seps: seps, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `seps` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | strategy: strategy, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `strategy` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/environment/device.rs:283:21 [INFO] [stdout] | [INFO] [stdout] 283 | gids: gids, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `gids` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:107:17 [INFO] [stdout] | [INFO] [stdout] 107 | id: id, [INFO] [stdout] | ^^^^^^ help: replace it with: `id` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:108:17 [INFO] [stdout] | [INFO] [stdout] 108 | name: name, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `name` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:109:17 [INFO] [stdout] | [INFO] [stdout] 109 | desc: desc, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `desc` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:110:17 [INFO] [stdout] | [INFO] [stdout] 110 | compute_time: compute_time, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:111:17 [INFO] [stdout] | [INFO] [stdout] 111 | activation_size: activation_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `activation_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:112:17 [INFO] [stdout] | [INFO] [stdout] 112 | output_activation_size: output_activation_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `output_activation_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/input/torch_graph.rs:113:17 [INFO] [stdout] | [INFO] [stdout] 113 | parameter_size: parameter_size, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `parameter_size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/input/torch_graph_py.rs:1:28 [INFO] [stdout] | [INFO] [stdout] 1 | pub const TORCH_GRAPH_PY: &'static str = r#" [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:68:13 [INFO] [stdout] | [INFO] [stdout] 68 | layers: layers, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `layers` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:69:13 [INFO] [stdout] | [INFO] [stdout] 69 | perf: perf, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `perf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/model/model.rs:70:13 [INFO] [stdout] | [INFO] [stdout] 70 | states: states, [INFO] [stdout] | ^^^^^^^^^^^^^^ help: replace it with: `states` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::sorted` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use itertools::sorted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bitset` should have an upper camel case name [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:15:10 [INFO] [stdout] | [INFO] [stdout] 15 | pub type bitset = Vec; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Bitset` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_camel_case_types)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:66:13 [INFO] [stdout] | [INFO] [stdout] 66 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:74:13 [INFO] [stdout] | [INFO] [stdout] 74 | m: m, [INFO] [stdout] | ^^^^ help: replace it with: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:75:13 [INFO] [stdout] | [INFO] [stdout] 75 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:369:25 [INFO] [stdout] | [INFO] [stdout] 369 | optimal_split: optimal_split, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optimal_split` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:585:13 [INFO] [stdout] | [INFO] [stdout] 585 | rp: rp, [INFO] [stdout] | ^^^^^^ help: replace it with: `rp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `environment::device` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:1:5 [INFO] [stdout] | [INFO] [stdout] 1 | use environment::device; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `itertools::sorted` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use itertools::sorted; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: type `bitset` should have an upper camel case name [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:14:10 [INFO] [stdout] | [INFO] [stdout] 14 | pub type bitset = Vec; [INFO] [stdout] | ^^^^^^ help: convert the identifier to upper camel case: `Bitset` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:72:13 [INFO] [stdout] | [INFO] [stdout] 72 | m: m, [INFO] [stdout] | ^^^^ help: replace it with: `m` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:73:13 [INFO] [stdout] | [INFO] [stdout] 73 | d: d, [INFO] [stdout] | ^^^^ help: replace it with: `d` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:464:25 [INFO] [stdout] | [INFO] [stdout] 464 | optimal_split: optimal_split, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `optimal_split` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `parallelism::*` [INFO] [stdout] --> src/parallelism/gpipe.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use parallelism::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> src/parallelism/gradient_accumulation.rs:5:5 [INFO] [stdout] | [INFO] [stdout] 5 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::prelude` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use rayon::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::prelude` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | use rayon::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/input/tensorflow_timeline.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | filename: &str, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `filename` [INFO] [stdout] --> src/input/tensorflow_timeline.rs:12:9 [INFO] [stdout] | [INFO] [stdout] 12 | filename: &str, [INFO] [stdout] | ^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_filename` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_activation_size` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let cur_activation_size = activation_sizes[0][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_activation_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_parameter_size` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | let cur_parameter_size = parameter_sizes[0][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_parameter_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_predecessor_ids` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:433:13 [INFO] [stdout] | [INFO] [stdout] 433 | let all_predecessor_ids = &self.m.perf.all_predecessor_ids; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_predecessor_ids` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `empty` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 437 | let empty: bitset = vec![false; d.num_gpus as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_empty` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_activation_size` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | let cur_activation_size = activation_sizes[i][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_activation_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let activation_sizes = &self.m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_activation_sizes` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let output_activation_sizes = &self.m.perf.output_activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_predecessor_ids` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let all_predecessor_ids = &self.m.perf.all_predecessor_ids; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_predecessor_ids` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/parallelism/gpipe.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | d: &device::Devices, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/parallelism/gpipe.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | m: &model::Model, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rp` [INFO] [stdout] --> src/parallelism/gpipe.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | rp: u32, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pipeline_time` [INFO] [stdout] --> src/parallelism/gpipe.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | pipeline_time: f64, [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pipeline_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/parallelism/gpipe.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | p: Vec<(u32, u32, u32, BTreeSet)>, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/parallelism/split_concat.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | d: &device::Devices, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `from` [INFO] [stdout] --> src/parallelism/split_concat.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | from: &BTreeSet, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_from` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to` [INFO] [stdout] --> src/parallelism/split_concat.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | to: &BTreeSet, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_to` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/parallelism/split_concat.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | size: f64, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let activation_sizes = &m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let activation_sizes = &m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_activation_size` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:115:17 [INFO] [stdout] | [INFO] [stdout] 115 | let cur_activation_size = activation_sizes[0][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_activation_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_parameter_size` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:116:17 [INFO] [stdout] | [INFO] [stdout] 116 | let cur_parameter_size = parameter_sizes[0][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_parameter_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `size`, `actual_start`, and `actual_end` are never read [INFO] [stdout] --> src/analysis/cc_overlap.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | struct DataBlock { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | size: f64, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | actual_start: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | actual_end: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataBlock` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TensorflowTimelineImporter` is never constructed [INFO] [stdout] --> src/input/tensorflow_timeline.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct TensorflowTimelineImporter {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/analysis/cc_overlap.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] 43 + assert!(partial <= 1.0 && partial >= 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/analysis/cc_overlap.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&partial)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_predecessor_ids` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:433:13 [INFO] [stdout] | [INFO] [stdout] 433 | let all_predecessor_ids = &self.m.perf.all_predecessor_ids; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_predecessor_ids` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `empty` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:437:13 [INFO] [stdout] | [INFO] [stdout] 437 | let empty: bitset = vec![false; d.num_gpus as usize]; [INFO] [stdout] | ^^^^^ help: if this is intentional, prefix it with an underscore: `_empty` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/analysis/cc_overlap.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | cur_ts += &m.layers[i].compute_time * partial / 2.0; // TODO: Fwd Time [INFO] [stdout] | -------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `m.layers[i].compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/analysis/cc_overlap.rs:82:38 [INFO] [stdout] | [INFO] [stdout] 82 | ds.blocks[i].comp_time = &m.layers[i].compute_time * partial / 2.0; [INFO] [stdout] | -------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `m.layers[i].compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/environment/device.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `machine_availability` [INFO] [stdout] --> src/environment/device.rs:113:30 [INFO] [stdout] | [INFO] [stdout] 113 | for i in 0..machine_availability.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 113 - for i in 0..machine_availability.len() { [INFO] [stdout] 113 + for (i, ) in machine_availability.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/environment/device.rs:117:38 [INFO] [stdout] | [INFO] [stdout] 117 | ... _ => *&self.seps[i - 1], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.seps[i - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | ... while t_ret.occupied[j as usize] == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `cur_activation_size` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:67:21 [INFO] [stdout] | [INFO] [stdout] 67 | let cur_activation_size = activation_sizes[i][j]; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_cur_activation_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `machine_availability` [INFO] [stdout] --> src/environment/device.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | for i in 0..machine_availability.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 139 - for i in 0..machine_availability.len() { [INFO] [stdout] 139 + for (i, ) in machine_availability.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:148:35 [INFO] [stdout] | [INFO] [stdout] 148 | ... while t_ret.occupied[j as usize] == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | ... while t_ret.occupied[j as usize] == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/environment/device.rs:163:39 [INFO] [stdout] | [INFO] [stdout] 163 | ... while j < *&self.seps[i] { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `self.seps[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | return t_ret; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 - return t_ret; [INFO] [stdout] 228 + t_ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/environment/device.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | assert_eq!((left_total >= need), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 205 - assert_eq!((left_total >= need), true); [INFO] [stdout] 205 + assert!(left_total >= need); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/environment/device.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | (&self).next_cards_with_strategy(bs.clone(), need, machine_availability.clone(), s); [INFO] [stdout] | ^^^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/environment/device.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | / match t { [INFO] [stdout] 217 | | Some(result) => { [INFO] [stdout] 218 | | exist.insert(result.gids.clone(), result); [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 216 ~ if let Some(result) = t { [INFO] [stdout] 217 + exist.insert(result.gids.clone(), result); [INFO] [stdout] 218 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return res; [INFO] [stdout] 254 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return res; [INFO] [stdout] 292 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:81:13 [INFO] [stdout] | [INFO] [stdout] 81 | let activation_sizes = &self.m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `output_activation_sizes` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:82:13 [INFO] [stdout] | [INFO] [stdout] 82 | let output_activation_sizes = &self.m.perf.output_activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_output_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `all_predecessor_ids` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:84:13 [INFO] [stdout] | [INFO] [stdout] 84 | let all_predecessor_ids = &self.m.perf.all_predecessor_ids; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_all_predecessor_ids` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/input/torch_graph.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | let result: ( [INFO] [stdout] | _____________________^ [INFO] [stdout] 41 | | PyObject, [INFO] [stdout] 42 | | PyObject, [INFO] [stdout] 43 | | Vec>, [INFO] [stdout] ... | [INFO] [stdout] 47 | | Vec>, [INFO] [stdout] 48 | | ) = graph [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/model/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod model; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/parallelism/gpipe.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | d: &device::Devices, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `m` [INFO] [stdout] --> src/parallelism/gpipe.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | m: &model::Model, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_m` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Model` [INFO] [stdout] --> src/model/model.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> Model { [INFO] [stdout] 46 | | println!("For now, don't call new(), construct from perf results instead"); [INFO] [stdout] 47 | | panic!() [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 44 + impl Default for Model { [INFO] [stdout] 45 + fn default() -> Self { [INFO] [stdout] 46 + Self::new() [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `rp` [INFO] [stdout] --> src/parallelism/gpipe.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | rp: u32, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_rp` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `pipeline_time` [INFO] [stdout] --> src/parallelism/gpipe.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | pipeline_time: f64, [INFO] [stdout] | ^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_pipeline_time` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `p` [INFO] [stdout] --> src/parallelism/gpipe.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | p: Vec<(u32, u32, u32, BTreeSet)>, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_p` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `d` [INFO] [stdout] --> src/parallelism/split_concat.rs:42:5 [INFO] [stdout] | [INFO] [stdout] 42 | d: &device::Devices, [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_d` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `from` [INFO] [stdout] --> src/parallelism/split_concat.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | from: &BTreeSet, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_from` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `to` [INFO] [stdout] --> src/parallelism/split_concat.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | to: &BTreeSet, [INFO] [stdout] | ^^ help: if this is intentional, prefix it with an underscore: `_to` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `size` [INFO] [stdout] --> src/parallelism/split_concat.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | size: f64, [INFO] [stdout] | ^^^^ help: if this is intentional, prefix it with an underscore: `_size` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 35 | let activation_sizes = &m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `activation_sizes` [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:146:9 [INFO] [stdout] | [INFO] [stdout] 146 | let activation_sizes = &m.perf.activation_sizes; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: if this is intentional, prefix it with an underscore: `_activation_sizes` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model_perf.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model_perf.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `size`, `actual_start`, and `actual_end` are never read [INFO] [stdout] --> src/analysis/cc_overlap.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 8 | struct DataBlock { [INFO] [stdout] | --------- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 11 | size: f64, [INFO] [stdout] | ^^^^ [INFO] [stdout] ... [INFO] [stdout] 15 | actual_start: f64, [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] 16 | actual_end: f64, [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `DataBlock` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct `TensorflowTimelineImporter` is never constructed [INFO] [stdout] --> src/input/tensorflow_timeline.rs:4:8 [INFO] [stdout] | [INFO] [stdout] 4 | struct TensorflowTimelineImporter {} [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/analysis/cc_overlap.rs:43:5 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 43 - assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] 43 + assert!(partial <= 1.0 && partial >= 0.0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual `RangeInclusive::contains` implementation [INFO] [stdout] --> src/analysis/cc_overlap.rs:43:16 [INFO] [stdout] | [INFO] [stdout] 43 | assert_eq!((partial <= 1.0 && partial >= 0.0), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use: `(0.0..=1.0).contains(&partial)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_range_contains [INFO] [stdout] = note: `#[warn(clippy::manual_range_contains)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/analysis/cc_overlap.rs:80:23 [INFO] [stdout] | [INFO] [stdout] 80 | cur_ts += &m.layers[i].compute_time * partial / 2.0; // TODO: Fwd Time [INFO] [stdout] | -------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `m.layers[i].compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] = note: `#[warn(clippy::op_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: needlessly taken reference of left operand [INFO] [stdout] --> src/analysis/cc_overlap.rs:82:38 [INFO] [stdout] | [INFO] [stdout] 82 | ds.blocks[i].comp_time = &m.layers[i].compute_time * partial / 2.0; [INFO] [stdout] | -------------------------^^^^^^^^^^ [INFO] [stdout] | | [INFO] [stdout] | help: use the left value directly: `m.layers[i].compute_time` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | let cur_A: &MatrixCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `cur_A` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ let cur_A: &MatrixCell = if cur_A_bt.contains_key(&ph) { [INFO] [stdout] 224 ~ cur_A_bt.get(&ph).unwrap() [INFO] [stdout] 225 | } else { [INFO] [stdout] 226 ~ &empty_cell [INFO] [stdout] 227 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/environment/device.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:406:15 [INFO] [stdout] | [INFO] [stdout] 406 | while !next_split.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_split.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `machine_availability` [INFO] [stdout] --> src/environment/device.rs:113:30 [INFO] [stdout] | [INFO] [stdout] 113 | for i in 0..machine_availability.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 113 - for i in 0..machine_availability.len() { [INFO] [stdout] 113 + for (i, ) in machine_availability.iter_mut().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | return best_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 529 - return best_result; [INFO] [stdout] 529 + best_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/environment/device.rs:117:38 [INFO] [stdout] | [INFO] [stdout] 117 | ... _ => *&self.seps[i - 1], [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `self.seps[i - 1]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] = note: `#[warn(clippy::deref_addrof)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:119:35 [INFO] [stdout] | [INFO] [stdout] 119 | ... while t_ret.occupied[j as usize] == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `machine_availability` [INFO] [stdout] --> src/environment/device.rs:139:26 [INFO] [stdout] | [INFO] [stdout] 139 | for i in 0..machine_availability.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 139 - for i in 0..machine_availability.len() { [INFO] [stdout] 139 + for (i, ) in machine_availability.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:148:35 [INFO] [stdout] | [INFO] [stdout] 148 | ... while t_ret.occupied[j as usize] == true [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:548:13 [INFO] [stdout] | [INFO] [stdout] 548 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/environment/device.rs:160:35 [INFO] [stdout] | [INFO] [stdout] 160 | ... while t_ret.occupied[j as usize] == true { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `t_ret.occupied[j as usize]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: immediately dereferencing a reference [INFO] [stdout] --> src/environment/device.rs:163:39 [INFO] [stdout] | [INFO] [stdout] 163 | ... while j < *&self.seps[i] { [INFO] [stdout] | ^^^^^^^^^^^^^^ help: try: `self.seps[i]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#deref_addrof [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:228:9 [INFO] [stdout] | [INFO] [stdout] 228 | return t_ret; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 228 - return t_ret; [INFO] [stdout] 228 + t_ret [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/environment/device.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | assert_eq!((left_total >= need), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 205 - assert_eq!((left_total >= need), true); [INFO] [stdout] 205 + assert!(left_total >= need); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/environment/device.rs:215:17 [INFO] [stdout] | [INFO] [stdout] 215 | (&self).next_cards_with_strategy(bs.clone(), need, machine_availability.clone(), s); [INFO] [stdout] | ^^^^^^^ help: change this to: `self` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/environment/device.rs:216:13 [INFO] [stdout] | [INFO] [stdout] 216 | / match t { [INFO] [stdout] 217 | | Some(result) => { [INFO] [stdout] 218 | | exist.insert(result.gids.clone(), result); [INFO] [stdout] ... | [INFO] [stdout] 221 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 216 ~ if let Some(result) = t { [INFO] [stdout] 217 + exist.insert(result.gids.clone(), result); [INFO] [stdout] 218 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:254:9 [INFO] [stdout] | [INFO] [stdout] 254 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 254 - return res; [INFO] [stdout] 254 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:590:18 [INFO] [stdout] | [INFO] [stdout] 590 | for j in 0..A.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 590 - for j in 0..A.len() { [INFO] [stdout] 590 + for (j, ) in A.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:591:22 [INFO] [stdout] | [INFO] [stdout] 591 | for m in 0..A[j].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 591 - for m in 0..A[j].len() { [INFO] [stdout] 591 + for (m, ) in A.iter().enumerate().take(A[j].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/environment/device.rs:292:9 [INFO] [stdout] | [INFO] [stdout] 292 | return res; [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 292 - return res; [INFO] [stdout] 292 + res [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:614:37 [INFO] [stdout] | [INFO] [stdout] 614 | fn py_orchestrate(&mut self) -> PyResult<(f64, Vec<(u32, u32, u32, Vec)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | let py_stages: Vec<(u32, u32, u32, Vec)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 623 | / py_stages = best_hp [INFO] [stdout] 624 | | .stages [INFO] [stdout] 625 | | .par_iter() [INFO] [stdout] 626 | | .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 627 | | .collect(); [INFO] [stdout] | |______________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `py_stages` here [INFO] [stdout] | [INFO] [stdout] 622 ~ [INFO] [stdout] 623 ~ let py_stages: Vec<(u32, u32, u32, Vec)> = best_hp [INFO] [stdout] 624 + .stages [INFO] [stdout] 625 + .par_iter() [INFO] [stdout] 626 + .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 627 ~ .collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/input/torch_graph.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | let result: ( [INFO] [stdout] | _____________________^ [INFO] [stdout] 41 | | PyObject, [INFO] [stdout] 42 | | PyObject, [INFO] [stdout] 43 | | Vec>, [INFO] [stdout] ... | [INFO] [stdout] 47 | | Vec>, [INFO] [stdout] 48 | | ) = graph [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:656:28 [INFO] [stdout] | [INFO] [stdout] 656 | if num_gpus > 2 && num_gpus % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `num_gpus.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: module has the same name as its containing module [INFO] [stdout] --> src/model/mod.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | pub mod model; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#module_inception [INFO] [stdout] = note: `#[warn(clippy::module_inception)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | for i in 0..compute_times.len() as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_times.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | for j in i..compute_times[0].len() as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_times[0].len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | for m in 0..max_m as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 70 - for m in 0..max_m as usize { [INFO] [stdout] 70 + for (m, ) in A.iter_mut().enumerate().take(max_m as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:120:32 [INFO] [stdout] | [INFO] [stdout] 120 | ... if A[i][*k as usize][m - mp].current_maxmin_block == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `A[i][*k as usize][m - mp].current_maxmin_block.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model.rs:24:1 [INFO] [stdout] | [INFO] [stdout] 24 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you should consider adding a `Default` implementation for `Model` [INFO] [stdout] --> src/model/model.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | / pub fn new() -> Model { [INFO] [stdout] 46 | | println!("For now, don't call new(), construct from perf results instead"); [INFO] [stdout] 47 | | panic!() [INFO] [stdout] 48 | | } [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stdout] = note: `#[warn(clippy::new_without_default)]` on by default [INFO] [stdout] help: try adding this [INFO] [stdout] | [INFO] [stdout] 44 + impl Default for Model { [INFO] [stdout] 45 + fn default() -> Self { [INFO] [stdout] 46 + Self::new() [INFO] [stdout] 47 + } [INFO] [stdout] 48 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model_perf.rs:2:1 [INFO] [stdout] | [INFO] [stdout] 2 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:222:13 [INFO] [stdout] | [INFO] [stdout] 222 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/model/model_perf.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | let cur_A: &MatrixCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `cur_A` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 253 ~ [INFO] [stdout] 254 ~ let cur_A: &MatrixCell = if cur_A_bt.contains_key(&ph) { [INFO] [stdout] 255 ~ cur_A_bt.get(&ph).unwrap() [INFO] [stdout] 256 | } else { [INFO] [stdout] 257 ~ &empty_cell [INFO] [stdout] 258 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:30:1 [INFO] [stdout] | [INFO] [stdout] 30 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:39:1 [INFO] [stdout] | [INFO] [stdout] 39 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:501:15 [INFO] [stdout] | [INFO] [stdout] 501 | while !next_split.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_split.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:106:13 [INFO] [stdout] | [INFO] [stdout] 106 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] = note: `#[warn(clippy::same_item_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:109:13 [INFO] [stdout] | [INFO] [stdout] 109 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 536 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:565:18 [INFO] [stdout] | [INFO] [stdout] 565 | for j in 0..A.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 565 - for j in 0..A.len() { [INFO] [stdout] 565 + for (j, ) in A.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | let cur_A: &MatrixCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `cur_A` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 222 ~ [INFO] [stdout] 223 ~ let cur_A: &MatrixCell = if cur_A_bt.contains_key(&ph) { [INFO] [stdout] 224 ~ cur_A_bt.get(&ph).unwrap() [INFO] [stdout] 225 | } else { [INFO] [stdout] 226 ~ &empty_cell [INFO] [stdout] 227 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:566:22 [INFO] [stdout] | [INFO] [stdout] 566 | for m in 0..A[j].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 566 - for m in 0..A[j].len() { [INFO] [stdout] 566 + for (m, ) in A.iter().enumerate().take(A[j].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:594:10 [INFO] [stdout] | [INFO] [stdout] 594 | ) -> PyResult<(f64, Vec<(u32, u32, u32, Vec)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:597:9 [INFO] [stdout] | [INFO] [stdout] 597 | let py_stages: Vec<(u32, u32, u32, Vec)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 598 | / py_stages = res [INFO] [stdout] 599 | | .stages [INFO] [stdout] 600 | | .iter() [INFO] [stdout] 601 | | .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 602 | | .collect(); [INFO] [stdout] | |______________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `py_stages` here [INFO] [stdout] | [INFO] [stdout] 597 ~ [INFO] [stdout] 598 ~ let py_stages: Vec<(u32, u32, u32, Vec)> = res [INFO] [stdout] 599 + .stages [INFO] [stdout] 600 + .iter() [INFO] [stdout] 601 + .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 602 ~ .collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:406:15 [INFO] [stdout] | [INFO] [stdout] 406 | while !next_split.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_split.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:391:13 [INFO] [stdout] | [INFO] [stdout] 391 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parallelism/gradient_accumulation.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | if bs_per_device % iter != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bs_per_device.is_multiple_of(iter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:529:9 [INFO] [stdout] | [INFO] [stdout] 529 | return best_result; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 529 - return best_result; [INFO] [stdout] 529 + best_result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parallelism/split_concat.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if cross_machine_gids.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cross_machine_gids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return res_speedup; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return res_speedup; [INFO] [stdout] 134 + res_speedup [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:548:13 [INFO] [stdout] | [INFO] [stdout] 548 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:590:18 [INFO] [stdout] | [INFO] [stdout] 590 | for j in 0..A.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 590 - for j in 0..A.len() { [INFO] [stdout] 590 + for (j, ) in A.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:591:22 [INFO] [stdout] | [INFO] [stdout] 591 | for m in 0..A[j].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 591 - for m in 0..A[j].len() { [INFO] [stdout] 591 + for (m, ) in A.iter().enumerate().take(A[j].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:614:37 [INFO] [stdout] | [INFO] [stdout] 614 | fn py_orchestrate(&mut self) -> PyResult<(f64, Vec<(u32, u32, u32, Vec)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:622:9 [INFO] [stdout] | [INFO] [stdout] 622 | let py_stages: Vec<(u32, u32, u32, Vec)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 623 | / py_stages = best_hp [INFO] [stdout] 624 | | .stages [INFO] [stdout] 625 | | .par_iter() [INFO] [stdout] 626 | | .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 627 | | .collect(); [INFO] [stdout] | |______________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `py_stages` here [INFO] [stdout] | [INFO] [stdout] 622 ~ [INFO] [stdout] 623 ~ let py_stages: Vec<(u32, u32, u32, Vec)> = best_hp [INFO] [stdout] 624 + .stages [INFO] [stdout] 625 + .par_iter() [INFO] [stdout] 626 + .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 627 ~ .collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/orchestration/orchestrate_async.rs:656:28 [INFO] [stdout] | [INFO] [stdout] 656 | if num_gpus > 2 && num_gpus % 2 == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace with: `num_gpus.is_multiple_of(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:224:1 [INFO] [stdout] | [INFO] [stdout] 224 | / fn sync_pipeline_speedup_resursive_helper_f( [INFO] [stdout] 225 | | f: &mut Vec>>, [INFO] [stdout] 226 | | b: &mut Vec>>, [INFO] [stdout] 227 | | F: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 233 | | phi: usize, [INFO] [stdout] 234 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:64:21 [INFO] [stdout] | [INFO] [stdout] 64 | for i in 0..compute_times.len() as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_times.len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`usize` -> `usize`) [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:65:25 [INFO] [stdout] | [INFO] [stdout] 65 | for j in i..compute_times[0].len() as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `compute_times[0].len()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:70:26 [INFO] [stdout] | [INFO] [stdout] 70 | for m in 0..max_m as usize { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 70 - for m in 0..max_m as usize { [INFO] [stdout] 70 + for (m, ) in A.iter_mut().enumerate().take(max_m as usize) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return f[i as usize][x as usize].unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return f[i as usize][x as usize].unwrap(); [INFO] [stdout] 263 + f[i as usize][x as usize].unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:266:1 [INFO] [stdout] | [INFO] [stdout] 266 | / fn sync_pipeline_speedup_resursive_helper_b( [INFO] [stdout] 267 | | f: &mut Vec>>, [INFO] [stdout] 268 | | b: &mut Vec>>, [INFO] [stdout] 269 | | F: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 275 | | phi: usize, [INFO] [stdout] 276 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 306 | return b[i as usize][x as usize].unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return b[i as usize][x as usize].unwrap(); [INFO] [stdout] 306 + b[i as usize][x as usize].unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/orchestration/orchestrate_hierarchical.rs:120:32 [INFO] [stdout] | [INFO] [stdout] 120 | ... if A[i][*k as usize][m - mp].current_maxmin_block == None [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `A[i][*k as usize][m - mp].current_maxmin_block.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:29:1 [INFO] [stdout] | [INFO] [stdout] 29 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:37:1 [INFO] [stdout] | [INFO] [stdout] 37 | #[pyclass] [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: this warning originates in the attribute macro `pyclass` (in Nightly builds, run with -Z macro-backtrace for more info) [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/environment/device.rs:209:18 [INFO] [stdout] | [INFO] [stdout] 209 | for s in vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 210 | | AllocationStrategy::FreshFirst, [INFO] [stdout] 211 | | AllocationStrategy::AppendFirst, [INFO] [stdout] 212 | | AllocationStrategy::ScatterFirst, [INFO] [stdout] 213 | | ] { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 209 ~ for s in [AllocationStrategy::FreshFirst, [INFO] [stdout] 210 + AllocationStrategy::AppendFirst, [INFO] [stdout] 211 ~ AllocationStrategy::ScatterFirst] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:105:13 [INFO] [stdout] | [INFO] [stdout] 105 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:108:13 [INFO] [stdout] | [INFO] [stdout] 108 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:219:13 [INFO] [stdout] | [INFO] [stdout] 219 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:222:13 [INFO] [stdout] | [INFO] [stdout] 222 | empty.push(false); [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![false;SIZE]` [INFO] [stdout] = help: or `empty.extend(std::iter::repeat_n(false, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:253:17 [INFO] [stdout] | [INFO] [stdout] 253 | let cur_A: &MatrixCell; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `cur_A` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 253 ~ [INFO] [stdout] 254 ~ let cur_A: &MatrixCell = if cur_A_bt.contains_key(&ph) { [INFO] [stdout] 255 ~ cur_A_bt.get(&ph).unwrap() [INFO] [stdout] 256 | } else { [INFO] [stdout] 257 ~ &empty_cell [INFO] [stdout] 258 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:501:15 [INFO] [stdout] | [INFO] [stdout] 501 | while !next_split.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `next_split.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:486:13 [INFO] [stdout] | [INFO] [stdout] 486 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: it looks like the same item is being pushed into this `Vec` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:536:13 [INFO] [stdout] | [INFO] [stdout] 536 | ph.push(true); [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `vec![true;SIZE]` [INFO] [stdout] = help: or `ph.extend(std::iter::repeat_n(true, SIZE))` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#same_item_push [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:565:18 [INFO] [stdout] | [INFO] [stdout] 565 | for j in 0..A.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 565 - for j in 0..A.len() { [INFO] [stdout] 565 + for (j, ) in A.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:566:22 [INFO] [stdout] | [INFO] [stdout] 566 | for m in 0..A[j].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 566 - for m in 0..A[j].len() { [INFO] [stdout] 566 + for (m, ) in A.iter().enumerate().take(A[j].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:594:10 [INFO] [stdout] | [INFO] [stdout] 594 | ) -> PyResult<(f64, Vec<(u32, u32, u32, Vec)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/orchestration/orchestrate_sync.rs:597:9 [INFO] [stdout] | [INFO] [stdout] 597 | let py_stages: Vec<(u32, u32, u32, Vec)>; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ created here [INFO] [stdout] 598 | / py_stages = res [INFO] [stdout] 599 | | .stages [INFO] [stdout] 600 | | .iter() [INFO] [stdout] 601 | | .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 602 | | .collect(); [INFO] [stdout] | |______________________^ initialised here [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] help: move the declaration `py_stages` here [INFO] [stdout] | [INFO] [stdout] 597 ~ [INFO] [stdout] 598 ~ let py_stages: Vec<(u32, u32, u32, Vec)> = res [INFO] [stdout] 599 + .stages [INFO] [stdout] 600 + .iter() [INFO] [stdout] 601 + .map(|s| (s.0, s.1, s.2, s.3.iter().cloned().collect())) [INFO] [stdout] 602 ~ .collect(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/parallelism/gradient_accumulation.rs:26:16 [INFO] [stdout] | [INFO] [stdout] 26 | if bs_per_device % iter != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bs_per_device.is_multiple_of(iter)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/parallelism/split_concat.rs:21:16 [INFO] [stdout] | [INFO] [stdout] 21 | if cross_machine_gids.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!cross_machine_gids.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:134:5 [INFO] [stdout] | [INFO] [stdout] 134 | return res_speedup; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 134 - return res_speedup; [INFO] [stdout] 134 + res_speedup [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:224:1 [INFO] [stdout] | [INFO] [stdout] 224 | / fn sync_pipeline_speedup_resursive_helper_f( [INFO] [stdout] 225 | | f: &mut Vec>>, [INFO] [stdout] 226 | | b: &mut Vec>>, [INFO] [stdout] 227 | | F: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 233 | | phi: usize, [INFO] [stdout] 234 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:263:5 [INFO] [stdout] | [INFO] [stdout] 263 | return f[i as usize][x as usize].unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 263 - return f[i as usize][x as usize].unwrap(); [INFO] [stdout] 263 + f[i as usize][x as usize].unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:266:1 [INFO] [stdout] | [INFO] [stdout] 266 | / fn sync_pipeline_speedup_resursive_helper_b( [INFO] [stdout] 267 | | f: &mut Vec>>, [INFO] [stdout] 268 | | b: &mut Vec>>, [INFO] [stdout] 269 | | F: &Vec, [INFO] [stdout] ... | [INFO] [stdout] 275 | | phi: usize, [INFO] [stdout] 276 | | ) -> (f64, f64) { [INFO] [stdout] | |_______________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/parallelism/sync_pipeline.rs:306:5 [INFO] [stdout] | [INFO] [stdout] 306 | return b[i as usize][x as usize].unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 306 - return b[i as usize][x as usize].unwrap(); [INFO] [stdout] 306 + b[i as usize][x as usize].unwrap() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> src/environment/device.rs:209:18 [INFO] [stdout] | [INFO] [stdout] 209 | for s in vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 210 | | AllocationStrategy::FreshFirst, [INFO] [stdout] 211 | | AllocationStrategy::AppendFirst, [INFO] [stdout] 212 | | AllocationStrategy::ScatterFirst, [INFO] [stdout] 213 | | ] { [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 209 ~ for s in [AllocationStrategy::FreshFirst, [INFO] [stdout] 210 + AllocationStrategy::AppendFirst, [INFO] [stdout] 211 ~ AllocationStrategy::ScatterFirst] { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> tests/speedup_test.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> tests/speedup_test.rs:79:15 [INFO] [stdout] | [INFO] [stdout] 79 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 79 - .map(|(gbs)| { [INFO] [stdout] 79 + .map(|gbs | { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constant division of `0.0` with `0.0` will always result in NaN [INFO] [stdout] --> tests/speedup_test.rs:100:73 [INFO] [stdout] | [INFO] [stdout] 100 | let pipeline_speedup = c.res.iter().map(|s| s.speedup).fold(0. / 0., f64::max); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: consider using `f64::NAN` if you would like a constant representing NaN [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#zero_divided_by_zero [INFO] [stdout] = note: `#[warn(clippy::zero_divided_by_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/bert_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/bert_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/bert_speedup.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - .map(|(gbs)| { [INFO] [stdout] 27 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pipeline_speedup` is never read [INFO] [stdout] --> examples/bert_speedup.rs:49:40 [INFO] [stdout] | [INFO] [stdout] 49 | let mut pipeline_speedup = 0.0; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/split_concat_test.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | assert_eq!((calculated_time - expect).abs() < 0.001, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 19 - assert_eq!((calculated_time - expect).abs() < 0.001, true); [INFO] [stdout] 19 + assert!((calculated_time - expect).abs() < 0.001); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/gnmt_scalability.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/gnmt_scalability.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/gnmt_scalability.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/gnmt_scalability.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|(cur_d)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 40 - .map(|(cur_d)| { [INFO] [stdout] 40 + .map(|cur_d| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/vgg19_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/vgg19_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/vgg19_speedup.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - .map(|(gbs)| { [INFO] [stdout] 27 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pipeline_speedup` is never read [INFO] [stdout] --> examples/vgg19_speedup.rs:52:40 [INFO] [stdout] | [INFO] [stdout] 52 | let mut pipeline_speedup = 0.0; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/xlnet_scalability.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/xlnet_scalability.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/xlnet_scalability.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/xlnet_scalability.rs:34:15 [INFO] [stdout] | [INFO] [stdout] 34 | .map(|(cur_d)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 34 - .map(|(cur_d)| { [INFO] [stdout] 34 + .map(|cur_d| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/amoebanet_scalability.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/amoebanet_scalability.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/amoebanet_scalability.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/amoebanet_scalability.rs:49:15 [INFO] [stdout] | [INFO] [stdout] 49 | .map(|(cur_d)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 49 - .map(|(cur_d)| { [INFO] [stdout] 49 + .map(|cur_d| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/xlnet_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/xlnet_speedup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/xlnet_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/xlnet_speedup.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - .map(|(gbs)| { [INFO] [stdout] 27 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/orchestrate_test.rs:14:9 [INFO] [stdout] | [INFO] [stdout] 14 | let mut c = orchestrate_async::AsyncOrchestrate::new_from_torch_graph( [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_mut)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/orchestrate_test.rs:63:9 [INFO] [stdout] | [INFO] [stdout] 63 | let mut c = orchestrate_async::AsyncOrchestrate::new_from_model_device(model, d16); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/orchestrate_test.rs:82:9 [INFO] [stdout] | [INFO] [stdout] 82 | let mut c = orchestrate_async::AsyncOrchestrate::new_from_model_device(model, d16); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/orchestrate_test.rs:99:9 [INFO] [stdout] | [INFO] [stdout] 99 | let mut c = orchestrate_async::AsyncOrchestrate::new_from_model_device(model, d16); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable does not need to be mutable [INFO] [stdout] --> tests/orchestrate_test.rs:155:9 [INFO] [stdout] | [INFO] [stdout] 155 | let mut c = orchestrate_async::AsyncOrchestrate::new_from_model_device(model, d16); [INFO] [stdout] | ----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove this `mut` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `j` is used to index `A` [INFO] [stdout] --> tests/orchestrate_test.rs:22:14 [INFO] [stdout] | [INFO] [stdout] 22 | for j in 0..A.len() { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 22 - for j in 0..A.len() { [INFO] [stdout] 22 + for (j, ) in A.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `m` is used to index `A` [INFO] [stdout] --> tests/orchestrate_test.rs:23:18 [INFO] [stdout] | [INFO] [stdout] 23 | for m in 0..A[j].len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 23 - for m in 0..A[j].len() { [INFO] [stdout] 23 + for (m, ) in A.iter().enumerate().take(A[j].len()) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/amoebanet_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/amoebanet_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/amoebanet_speedup.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - .map(|(gbs)| { [INFO] [stdout] 27 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::input::*` [INFO] [stdout] --> tests/orchestrate_hierarchical_test.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use HPGO::input::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `planning_results` [INFO] [stdout] --> tests/orchestrate_test.rs:104:14 [INFO] [stdout] | [INFO] [stdout] 104 | for i in 0..planning_results.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 104 - for i in 0..planning_results.len() { [INFO] [stdout] 104 + for (i, ) in planning_results.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pipeline_speedup` is never read [INFO] [stdout] --> examples/amoebanet_speedup.rs:49:40 [INFO] [stdout] | [INFO] [stdout] 49 | let mut pipeline_speedup = 0.0; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> tests/ga_test.rs:4:5 [INFO] [stdout] | [INFO] [stdout] 4 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> tests/orchestrate_test.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 20 | let A = c.compute_plan_sync(8, 1, false); [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(non_snake_case)]` (part of `#[warn(nonstandard_style)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused variable: `y` [INFO] [stdout] --> tests/torch_graph_test.rs:16:24 [INFO] [stdout] | [INFO] [stdout] 16 | (Some(x), Some(y)) => { [INFO] [stdout] | ^ help: if this is intentional, prefix it with an underscore: `_y` [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_variables)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: variable `A` should have a snake case name [INFO] [stdout] --> tests/orchestrate_test.rs:64:9 [INFO] [stdout] | [INFO] [stdout] 64 | let A = c.compute_plan_sync(16, 1, false); [INFO] [stdout] | ^ help: convert the identifier to snake case: `a` [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/gnmt_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/gnmt_speedup.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/gnmt_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/gnmt_speedup.rs:27:15 [INFO] [stdout] | [INFO] [stdout] 27 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 27 - .map(|(gbs)| { [INFO] [stdout] 27 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `rayon::prelude` [INFO] [stdout] --> tests/ga_test.rs:3:5 [INFO] [stdout] | [INFO] [stdout] 3 | use rayon::prelude::*; [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `vec!` [INFO] [stdout] --> tests/ga_test.rs:13:18 [INFO] [stdout] | [INFO] [stdout] 13 | let models = vec![ [INFO] [stdout] | __________________^ [INFO] [stdout] 14 | | ("vgg16", 32, 1, -1.0), [INFO] [stdout] 15 | | ("vgg19", 32, 1, 70000000.0), [INFO] [stdout] 16 | | ("xlnet", 1, 3, 3942774528.0), [INFO] [stdout] ... | [INFO] [stdout] 21 | | ]; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_vec [INFO] [stdout] = note: `#[warn(clippy::useless_vec)]` on by default [INFO] [stdout] help: you can use an array directly [INFO] [stdout] | [INFO] [stdout] 13 ~ let models = [("vgg16", 32, 1, -1.0), [INFO] [stdout] 14 + ("vgg19", 32, 1, 70000000.0), [INFO] [stdout] 15 + ("xlnet", 1, 3, 3942774528.0), [INFO] [stdout] 16 + ("amoebanet", 8, 4, 250845152.0), [INFO] [stdout] 17 + ("bert_large", 2, 3, 1733171968.0), [INFO] [stdout] 18 ~ ("gnmt_large", 128, 3, 173317190.0)]; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/bert_scalability.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::collections::BTreeSet` [INFO] [stdout] --> examples/bert_scalability.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | use std::collections::BTreeSet; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/bert_scalability.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/bert_scalability.rs:40:15 [INFO] [stdout] | [INFO] [stdout] 40 | .map(|(cur_d)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 40 - .map(|(cur_d)| { [INFO] [stdout] 40 + .map(|cur_d| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Opt { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | verbose: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | speed: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | output: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | nb_cars: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | level: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | files: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/data_parallel_test.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | assert_eq!((calculated_time - expected_time).abs() < 0.001, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 20 - assert_eq!((calculated_time - expected_time).abs() < 0.001, true); [INFO] [stdout] 20 + assert!((calculated_time - expected_time).abs() < 0.001); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> tests/data_parallel_test.rs:33:5 [INFO] [stdout] | [INFO] [stdout] 33 | assert_eq!((calculated_time - expected_time).abs() < 0.001, true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 33 - assert_eq!((calculated_time - expected_time).abs() < 0.001, true); [INFO] [stdout] 33 + assert!((calculated_time - expected_time).abs() < 0.001); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `std::cmp::min` [INFO] [stdout] --> examples/model_speedup.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | use std::cmp::min; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_imports)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused import: `HPGO::analysis::*` [INFO] [stdout] --> examples/model_speedup.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | use HPGO::analysis::*; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary parentheses around pattern [INFO] [stdout] --> examples/model_speedup.rs:61:15 [INFO] [stdout] | [INFO] [stdout] 61 | .map(|(gbs)| { [INFO] [stdout] | ^ ^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_parens)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: remove these parentheses [INFO] [stdout] | [INFO] [stdout] 61 - .map(|(gbs)| { [INFO] [stdout] 61 + .map(|gbs| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty line after doc comment [INFO] [stdout] --> examples/model_speedup.rs:125:1 [INFO] [stdout] | [INFO] [stdout] 125 | / /// Data Area [INFO] [stdout] 126 | | [INFO] [stdout] | |_^ [INFO] [stdout] 127 | // Seps Array for Flat and Hierarchical [INFO] [stdout] 128 | fn get_hierarchical_devices() -> device::Devices { [INFO] [stdout] | --------------------------- the comment documents this function [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty line is unintentional, remove it [INFO] [stdout] help: if the doc comment should not document function `get_hierarchical_devices` then comment it out [INFO] [stdout] | [INFO] [stdout] 125 | // /// Data Area [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/model_speedup.rs:145:9 [INFO] [stdout] | [INFO] [stdout] 145 | gbs: gbs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `gbs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/model_speedup.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | gbs: gbs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `gbs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/model_speedup.rs:190:9 [INFO] [stdout] | [INFO] [stdout] 190 | gbs: gbs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `gbs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/model_speedup.rs:205:9 [INFO] [stdout] | [INFO] [stdout] 205 | gbs: gbs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `gbs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> examples/model_speedup.rs:220:9 [INFO] [stdout] | [INFO] [stdout] 220 | gbs: gbs, [INFO] [stdout] | ^^^^^^^^ help: replace it with: `gbs` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: value assigned to `pipeline_speedup` is never read [INFO] [stdout] --> examples/model_speedup.rs:78:40 [INFO] [stdout] | [INFO] [stdout] 78 | let mut pipeline_speedup = 0.0; [INFO] [stdout] | ^^^ [INFO] [stdout] | [INFO] [stdout] = help: maybe it is overwritten before being read? [INFO] [stdout] = note: `#[warn(unused_assignments)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_vgg19_model_config` is never used [INFO] [stdout] --> examples/model_speedup.rs:139:4 [INFO] [stdout] | [INFO] [stdout] 139 | fn get_vgg19_model_config() -> ModelConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_gnmt32_model_config` is never used [INFO] [stdout] --> examples/model_speedup.rs:184:4 [INFO] [stdout] | [INFO] [stdout] 184 | fn get_gnmt32_model_config() -> ModelConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_gnmt16_model_config` is never used [INFO] [stdout] --> examples/model_speedup.rs:199:4 [INFO] [stdout] | [INFO] [stdout] 199 | fn get_gnmt16_model_config() -> ModelConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function `get_bert48_model_config` is never used [INFO] [stdout] --> examples/model_speedup.rs:214:4 [INFO] [stdout] | [INFO] [stdout] 214 | fn get_bert48_model_config() -> ModelConfig { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> examples/model_speedup.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | let d: device::Devices; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `d` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 29 ~ [INFO] [stdout] 30 ~ let d: device::Devices = if flat { [INFO] [stdout] 31 ~ get_flat_devices() [INFO] [stdout] 32 | } else { [INFO] [stdout] 33 ~ get_hierarchical_devices() [INFO] [stdout] 34 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: multiple fields are never read [INFO] [stdout] --> src/main.rs:18:5 [INFO] [stdout] | [INFO] [stdout] 12 | struct Opt { [INFO] [stdout] | --- fields in this struct [INFO] [stdout] ... [INFO] [stdout] 18 | debug: bool, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 23 | verbose: u8, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 27 | speed: f64, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 31 | output: PathBuf, [INFO] [stdout] | ^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 37 | nb_cars: Option, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] ... [INFO] [stdout] 41 | level: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] ... [INFO] [stdout] 45 | files: Vec, [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Opt` has a derived impl for the trait `Debug`, but this is intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 57.17s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: criterion v0.3.0, pyo3 v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 4` [INFO] running `Command { std: "docker" "inspect" "f7290b6ac000fa7887df1c64431da0ffcfa7874c35ffb1fbb91b860d840e6148", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f7290b6ac000fa7887df1c64431da0ffcfa7874c35ffb1fbb91b860d840e6148", kill_on_drop: false }` [INFO] [stdout] f7290b6ac000fa7887df1c64431da0ffcfa7874c35ffb1fbb91b860d840e6148