[INFO] fetching crate DEWQ 0.0.4... [INFO] linting DEWQ-0.0.4 against nightly for clippy-nonminimal_bool-denied [INFO] extracting crate DEWQ 0.0.4 into /workspace/builds/worker-2-tc1/source [INFO] started tweaking crates.io crate DEWQ 0.0.4 [INFO] finished tweaking crates.io crate DEWQ 0.0.4 [INFO] tweaked toml for crates.io crate DEWQ 0.0.4 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of crates.io crate DEWQ 0.0.4 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate crates.io crate DEWQ 0.0.4 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ca44e4b8bba346ca4d4d8f71a908522828b4f225e73607800d695d3dd87a87bb [INFO] running `Command { std: "docker" "start" "-a" "ca44e4b8bba346ca4d4d8f71a908522828b4f225e73607800d695d3dd87a87bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ca44e4b8bba346ca4d4d8f71a908522828b4f225e73607800d695d3dd87a87bb", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ca44e4b8bba346ca4d4d8f71a908522828b4f225e73607800d695d3dd87a87bb", kill_on_drop: false }` [INFO] [stdout] ca44e4b8bba346ca4d4d8f71a908522828b4f225e73607800d695d3dd87a87bb [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 147a403a8eca9f0aa4eba8826605ef3a733871634159df50806a7a66d97e3be2 [INFO] running `Command { std: "docker" "start" "-a" "147a403a8eca9f0aa4eba8826605ef3a733871634159df50806a7a66d97e3be2", kill_on_drop: false }` [INFO] [stderr] Checking DEWQ v0.0.4 (/opt/rustwide/workdir) [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/bit_utils/bitmap.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / /// ``` [INFO] [stdout] 23 | | [INFO] [stdout] 24 | | [INFO] [stdout] | |_^ [INFO] [stdout] 25 | use super::bit::Bit; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A bitmap representation for storing and manipulating bit-level data [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! # Structure [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! The `BitMap` stores a 2D grid of bits as a vector of bytes, optimized for space efficiency [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! # Methods [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Provides methods to: [INFO] [stdout] 10 ~ //! - Create a new bitmap [INFO] [stdout] 11 ~ //! - Set and get individual bits [INFO] [stdout] 12 ~ //! - Invert bits [INFO] [stdout] 13 ~ //! - Get bitmap size [INFO] [stdout] 14 ~ //! - Save bitmap to a file [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! # Example [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! ```rust [INFO] [stdout] 19 ~ //! let mut bitmap = BitMap::new(10); [INFO] [stdout] 20 ~ //! bitmap.set(5, 7, 1); [INFO] [stdout] 21 ~ //! assert_eq!(bitmap.get(5, 7), Bit::One); [INFO] [stdout] 22 ~ //! ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/bit_utils/bitmap.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / /// ``` [INFO] [stdout] 23 | | [INFO] [stdout] 24 | | [INFO] [stdout] | |_^ [INFO] [stdout] 25 | use super::bit::Bit; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A bitmap representation for storing and manipulating bit-level data [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! # Structure [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! The `BitMap` stores a 2D grid of bits as a vector of bytes, optimized for space efficiency [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! # Methods [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Provides methods to: [INFO] [stdout] 10 ~ //! - Create a new bitmap [INFO] [stdout] 11 ~ //! - Set and get individual bits [INFO] [stdout] 12 ~ //! - Invert bits [INFO] [stdout] 13 ~ //! - Get bitmap size [INFO] [stdout] 14 ~ //! - Save bitmap to a file [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! # Example [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! ```rust [INFO] [stdout] 19 ~ //! let mut bitmap = BitMap::new(10); [INFO] [stdout] 20 ~ //! bitmap.set(5, 7, 1); [INFO] [stdout] 21 ~ //! assert_eq!(bitmap.get(5, 7), Bit::One); [INFO] [stdout] 22 ~ //! ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bit` which implements the `Copy` trait [INFO] [stdout] --> src/bit_utils/bit_string.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | self.push_bit(b.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/bit_utils/bit_string.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | if let Ok(bit) = self.get_bit(index) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 100 | match bit { [INFO] [stdout] 101 | Bit::One => val |= 1, [INFO] [stdout] | ^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ help: try: `if bit == Bit::One { val |= 1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bit` which implements the `Copy` trait [INFO] [stdout] --> src/bit_utils/bit_string.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | self.push_bit(b.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/bit_utils/bit_string.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | if let Ok(bit) = self.get_bit(index) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 100 | match bit { [INFO] [stdout] 101 | Bit::One => val |= 1, [INFO] [stdout] | ^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ help: try: `if bit == Bit::One { val |= 1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/bit_utils/bit_string.rs:207:17 [INFO] [stdout] | [INFO] [stdout] 207 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/bit_utils/bit_string.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match self.notation { [INFO] [stdout] 77 | | Notation::Integer => { [INFO] [stdout] 78 | | for elem in self.data.get_mut() { [INFO] [stdout] 79 | | *elem = get_antilog(*elem); [INFO] [stdout] ... | [INFO] [stdout] 84 | | _ => {} [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Notation::Integer = self.notation { [INFO] [stdout] 77 + for elem in self.data.get_mut() { [INFO] [stdout] 78 + *elem = get_antilog(*elem); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + [INFO] [stdout] 81 + self.notation = Notation::Exponent; [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self.notation { [INFO] [stdout] 90 | | Notation::Exponent => { [INFO] [stdout] 91 | | for elem in self.data.get_mut() { [INFO] [stdout] 92 | | *elem = get_log(*elem); [INFO] [stdout] ... | [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Notation::Exponent = self.notation { [INFO] [stdout] 90 + for elem in self.data.get_mut() { [INFO] [stdout] 91 + *elem = get_log(*elem); [INFO] [stdout] 92 + } [INFO] [stdout] 93 + [INFO] [stdout] 94 + self.notation = Notation::Integer; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match self.notation { [INFO] [stdout] 77 | | Notation::Integer => { [INFO] [stdout] 78 | | for elem in self.data.get_mut() { [INFO] [stdout] 79 | | *elem = get_antilog(*elem); [INFO] [stdout] ... | [INFO] [stdout] 84 | | _ => {} [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Notation::Integer = self.notation { [INFO] [stdout] 77 + for elem in self.data.get_mut() { [INFO] [stdout] 78 + *elem = get_antilog(*elem); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + [INFO] [stdout] 81 + self.notation = Notation::Exponent; [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self.notation { [INFO] [stdout] 90 | | Notation::Exponent => { [INFO] [stdout] 91 | | for elem in self.data.get_mut() { [INFO] [stdout] 92 | | *elem = get_log(*elem); [INFO] [stdout] ... | [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Notation::Exponent = self.notation { [INFO] [stdout] 90 + for elem in self.data.get_mut() { [INFO] [stdout] 91 + *elem = get_log(*elem); [INFO] [stdout] 92 + } [INFO] [stdout] 93 + [INFO] [stdout] 94 + self.notation = Notation::Integer; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | if is_numeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:297:35 [INFO] [stdout] | [INFO] [stdout] 297 | } else if is_alphanumeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | if is_numeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:297:35 [INFO] [stdout] | [INFO] [stdout] 297 | } else if is_alphanumeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_code/mod.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | return bit_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 - return bit_string; [INFO] [stdout] 589 + bit_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_code/mod.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | return bit_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 - return bit_string; [INFO] [stdout] 589 + bit_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_code/mod.rs:517:21 [INFO] [stdout] | [INFO] [stdout] 517 | let out: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 517 ~ [INFO] [stdout] 518 ~ let out: usize = if (bqr.version + 1) < 10 { [INFO] [stdout] 519 ~ 8 [INFO] [stdout] 520 | } else { [INFO] [stdout] 521 ~ 16 [INFO] [stdout] 522 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/qr_code/mod.rs:557:15 [INFO] [stdout] | [INFO] [stdout] 557 | while bit_string.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bit_string.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_code/mod.rs:517:21 [INFO] [stdout] | [INFO] [stdout] 517 | let out: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 517 ~ [INFO] [stdout] 518 ~ let out: usize = if (bqr.version + 1) < 10 { [INFO] [stdout] 519 ~ 8 [INFO] [stdout] 520 | } else { [INFO] [stdout] 521 ~ 16 [INFO] [stdout] 522 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/qr_code/mod.rs:557:15 [INFO] [stdout] | [INFO] [stdout] 557 | while bit_string.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bit_string.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:623:23 [INFO] [stdout] | [INFO] [stdout] 623 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:623:23 [INFO] [stdout] | [INFO] [stdout] 623 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:634:23 [INFO] [stdout] | [INFO] [stdout] 634 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:634:23 [INFO] [stdout] | [INFO] [stdout] 634 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qr_code/mod.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | / if (row + column) % 2 == 0 { [INFO] [stdout] 860 | | if reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | | bit_map.invert_bit(row, column); [INFO] [stdout] 862 | | } [INFO] [stdout] 863 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if (row + column) % 2 == 0 [INFO] [stdout] 860 ~ && reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | bit_map.invert_bit(row, column); [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qr_code/mod.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | / if (row + column) % 2 == 0 { [INFO] [stdout] 860 | | if reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | | bit_map.invert_bit(row, column); [INFO] [stdout] 862 | | } [INFO] [stdout] 863 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if (row + column) % 2 == 0 [INFO] [stdout] 860 ~ && reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | bit_map.invert_bit(row, column); [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/qr_code/mod.rs:1052:16 [INFO] [stdout] | [INFO] [stdout] 1052 | if (x == 0 && y == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 1053 | | || (x == 0 && y == coords.len() - 1) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if !(x != 0 || y != 0 && y != coords.len() - 1) [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if (y == coords.len() - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1028:23 [INFO] [stdout] | [INFO] [stdout] 1028 | for x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1036:35 [INFO] [stdout] | [INFO] [stdout] 1036 | for reservation_x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1037:39 [INFO] [stdout] | [INFO] [stdout] 1037 | for reservation_y in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/qr_code/mod.rs:1052:16 [INFO] [stdout] | [INFO] [stdout] 1052 | if (x == 0 && y == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 1053 | | || (x == 0 && y == coords.len() - 1) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if !(x != 0 || y != 0 && y != coords.len() - 1) [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if (y == coords.len() - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1028:23 [INFO] [stdout] | [INFO] [stdout] 1028 | for x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1036:35 [INFO] [stdout] | [INFO] [stdout] 1036 | for reservation_x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1037:39 [INFO] [stdout] | [INFO] [stdout] 1037 | for reservation_y in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/bit_utils/bitmap.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / /// ``` [INFO] [stdout] 23 | | [INFO] [stdout] 24 | | [INFO] [stdout] | |_^ [INFO] [stdout] 25 | use super::bit::Bit; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A bitmap representation for storing and manipulating bit-level data [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! # Structure [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! The `BitMap` stores a 2D grid of bits as a vector of bytes, optimized for space efficiency [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! # Methods [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Provides methods to: [INFO] [stdout] 10 ~ //! - Create a new bitmap [INFO] [stdout] 11 ~ //! - Set and get individual bits [INFO] [stdout] 12 ~ //! - Invert bits [INFO] [stdout] 13 ~ //! - Get bitmap size [INFO] [stdout] 14 ~ //! - Save bitmap to a file [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! # Example [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! ```rust [INFO] [stdout] 19 ~ //! let mut bitmap = BitMap::new(10); [INFO] [stdout] 20 ~ //! bitmap.set(5, 7, 1); [INFO] [stdout] 21 ~ //! assert_eq!(bitmap.get(5, 7), Bit::One); [INFO] [stdout] 22 ~ //! ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty lines after doc comment [INFO] [stdout] --> src/bit_utils/bitmap.rs:22:1 [INFO] [stdout] | [INFO] [stdout] 22 | / /// ``` [INFO] [stdout] 23 | | [INFO] [stdout] 24 | | [INFO] [stdout] | |_^ [INFO] [stdout] 25 | use super::bit::Bit; [INFO] [stdout] | - the comment documents this `use` import [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_line_after_doc_comments [INFO] [stdout] = note: `#[warn(clippy::empty_line_after_doc_comments)]` on by default [INFO] [stdout] = help: if the empty lines are unintentional, remove them [INFO] [stdout] help: if the comment should document the parent module use an inner doc comment [INFO] [stdout] | [INFO] [stdout] 1 ~ //! A bitmap representation for storing and manipulating bit-level data [INFO] [stdout] 2 ~ //! [INFO] [stdout] 3 ~ //! # Structure [INFO] [stdout] 4 ~ //! [INFO] [stdout] 5 ~ //! The `BitMap` stores a 2D grid of bits as a vector of bytes, optimized for space efficiency [INFO] [stdout] 6 ~ //! [INFO] [stdout] 7 ~ //! # Methods [INFO] [stdout] 8 ~ //! [INFO] [stdout] 9 ~ //! Provides methods to: [INFO] [stdout] 10 ~ //! - Create a new bitmap [INFO] [stdout] 11 ~ //! - Set and get individual bits [INFO] [stdout] 12 ~ //! - Invert bits [INFO] [stdout] 13 ~ //! - Get bitmap size [INFO] [stdout] 14 ~ //! - Save bitmap to a file [INFO] [stdout] 15 ~ //! [INFO] [stdout] 16 ~ //! # Example [INFO] [stdout] 17 ~ //! [INFO] [stdout] 18 ~ //! ```rust [INFO] [stdout] 19 ~ //! let mut bitmap = BitMap::new(10); [INFO] [stdout] 20 ~ //! bitmap.set(5, 7, 1); [INFO] [stdout] 21 ~ //! assert_eq!(bitmap.get(5, 7), Bit::One); [INFO] [stdout] 22 ~ //! ``` [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bit` which implements the `Copy` trait [INFO] [stdout] --> src/bit_utils/bit_string.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | self.push_bit(b.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/bit_utils/bit_string.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | if let Ok(bit) = self.get_bit(index) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 100 | match bit { [INFO] [stdout] 101 | Bit::One => val |= 1, [INFO] [stdout] | ^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ help: try: `if bit == Bit::One { val |= 1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match self.notation { [INFO] [stdout] 77 | | Notation::Integer => { [INFO] [stdout] 78 | | for elem in self.data.get_mut() { [INFO] [stdout] 79 | | *elem = get_antilog(*elem); [INFO] [stdout] ... | [INFO] [stdout] 84 | | _ => {} [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Notation::Integer = self.notation { [INFO] [stdout] 77 + for elem in self.data.get_mut() { [INFO] [stdout] 78 + *elem = get_antilog(*elem); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + [INFO] [stdout] 81 + self.notation = Notation::Exponent; [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self.notation { [INFO] [stdout] 90 | | Notation::Exponent => { [INFO] [stdout] 91 | | for elem in self.data.get_mut() { [INFO] [stdout] 92 | | *elem = get_log(*elem); [INFO] [stdout] ... | [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Notation::Exponent = self.notation { [INFO] [stdout] 90 + for elem in self.data.get_mut() { [INFO] [stdout] 91 + *elem = get_log(*elem); [INFO] [stdout] 92 + } [INFO] [stdout] 93 + [INFO] [stdout] 94 + self.notation = Notation::Integer; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | if is_numeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:297:35 [INFO] [stdout] | [INFO] [stdout] 297 | } else if is_alphanumeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_code/mod.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | return bit_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 - return bit_string; [INFO] [stdout] 589 + bit_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_code/mod.rs:517:21 [INFO] [stdout] | [INFO] [stdout] 517 | let out: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 517 ~ [INFO] [stdout] 518 ~ let out: usize = if (bqr.version + 1) < 10 { [INFO] [stdout] 519 ~ 8 [INFO] [stdout] 520 | } else { [INFO] [stdout] 521 ~ 16 [INFO] [stdout] 522 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/qr_code/mod.rs:557:15 [INFO] [stdout] | [INFO] [stdout] 557 | while bit_string.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bit_string.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:623:23 [INFO] [stdout] | [INFO] [stdout] 623 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:634:23 [INFO] [stdout] | [INFO] [stdout] 634 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Bit` which implements the `Copy` trait [INFO] [stdout] --> src/bit_utils/bit_string.rs:52:27 [INFO] [stdout] | [INFO] [stdout] 52 | self.push_bit(b.clone()); [INFO] [stdout] | ^^^^^^^^^ help: try removing the `clone` call: `b` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `match` can be collapsed into the outer `if let` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] help: the outer pattern can be modified to include the inner pattern [INFO] [stdout] --> src/bit_utils/bit_string.rs:99:27 [INFO] [stdout] | [INFO] [stdout] 99 | if let Ok(bit) = self.get_bit(index) { [INFO] [stdout] | ^^^ replace this binding [INFO] [stdout] 100 | match bit { [INFO] [stdout] 101 | Bit::One => val |= 1, [INFO] [stdout] | ^^^^^^^^ with this pattern [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for an equality check. Consider using `if` [INFO] [stdout] --> src/bit_utils/bit_string.rs:100:21 [INFO] [stdout] | [INFO] [stdout] 100 | / match bit { [INFO] [stdout] 101 | | Bit::One => val |= 1, [INFO] [stdout] 102 | | _ => {} [INFO] [stdout] 103 | | } [INFO] [stdout] | |_____________________^ help: try: `if bit == Bit::One { val |= 1 }` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] = note: `#[warn(clippy::single_match)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qr_code/mod.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | / if (row + column) % 2 == 0 { [INFO] [stdout] 860 | | if reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | | bit_map.invert_bit(row, column); [INFO] [stdout] 862 | | } [INFO] [stdout] 863 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if (row + column) % 2 == 0 [INFO] [stdout] 860 ~ && reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | bit_map.invert_bit(row, column); [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:197:21 [INFO] [stdout] | [INFO] [stdout] 197 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:204:17 [INFO] [stdout] | [INFO] [stdout] 204 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/bit_utils/bit_string.rs:207:17 [INFO] [stdout] | [INFO] [stdout] 207 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/qr_code/mod.rs:1052:16 [INFO] [stdout] | [INFO] [stdout] 1052 | if (x == 0 && y == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 1053 | | || (x == 0 && y == coords.len() - 1) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if !(x != 0 || y != 0 && y != coords.len() - 1) [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if (y == coords.len() - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:225:17 [INFO] [stdout] | [INFO] [stdout] 225 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1028:23 [INFO] [stdout] | [INFO] [stdout] 1028 | for x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:234:17 [INFO] [stdout] | [INFO] [stdout] 234 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:243:17 [INFO] [stdout] | [INFO] [stdout] 243 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/bit_utils/bit_string.rs:249:17 [INFO] [stdout] | [INFO] [stdout] 249 | assert!(false); [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `true` [INFO] [stdout] --> src/bit_utils/bit_string.rs:252:17 [INFO] [stdout] | [INFO] [stdout] 252 | assert!(true); [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: remove the assertion [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1036:35 [INFO] [stdout] | [INFO] [stdout] 1036 | for reservation_x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1037:39 [INFO] [stdout] | [INFO] [stdout] 1037 | for reservation_y in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:76:9 [INFO] [stdout] | [INFO] [stdout] 76 | / match self.notation { [INFO] [stdout] 77 | | Notation::Integer => { [INFO] [stdout] 78 | | for elem in self.data.get_mut() { [INFO] [stdout] 79 | | *elem = get_antilog(*elem); [INFO] [stdout] ... | [INFO] [stdout] 84 | | _ => {} [INFO] [stdout] 85 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 76 ~ if let Notation::Integer = self.notation { [INFO] [stdout] 77 + for elem in self.data.get_mut() { [INFO] [stdout] 78 + *elem = get_antilog(*elem); [INFO] [stdout] 79 + } [INFO] [stdout] 80 + [INFO] [stdout] 81 + self.notation = Notation::Exponent; [INFO] [stdout] 82 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: you seem to be trying to use `match` for destructuring a single pattern. Consider using `if let` [INFO] [stdout] --> src/galios/mod.rs:89:9 [INFO] [stdout] | [INFO] [stdout] 89 | / match self.notation { [INFO] [stdout] 90 | | Notation::Exponent => { [INFO] [stdout] 91 | | for elem in self.data.get_mut() { [INFO] [stdout] 92 | | *elem = get_log(*elem); [INFO] [stdout] ... | [INFO] [stdout] 97 | | _ => {} [INFO] [stdout] 98 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 89 ~ if let Notation::Exponent = self.notation { [INFO] [stdout] 90 + for elem in self.data.get_mut() { [INFO] [stdout] 91 + *elem = get_log(*elem); [INFO] [stdout] 92 + } [INFO] [stdout] 93 + [INFO] [stdout] 94 + self.notation = Notation::Integer; [INFO] [stdout] 95 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:269:23 [INFO] [stdout] | [INFO] [stdout] 269 | if is_numeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/qr_code/mod.rs:297:35 [INFO] [stdout] | [INFO] [stdout] 297 | } else if is_alphanumeric(&converted_input) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `converted_input` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/qr_code/mod.rs:589:9 [INFO] [stdout] | [INFO] [stdout] 589 | return bit_string; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 589 - return bit_string; [INFO] [stdout] 589 + bit_string [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded late initialization [INFO] [stdout] --> src/qr_code/mod.rs:517:21 [INFO] [stdout] | [INFO] [stdout] 517 | let out: usize; [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_late_init [INFO] [stdout] = note: `#[warn(clippy::needless_late_init)]` on by default [INFO] [stdout] help: move the declaration `out` here and remove the assignments from the branches [INFO] [stdout] | [INFO] [stdout] 517 ~ [INFO] [stdout] 518 ~ let out: usize = if (bqr.version + 1) < 10 { [INFO] [stdout] 519 ~ 8 [INFO] [stdout] 520 | } else { [INFO] [stdout] 521 ~ 16 [INFO] [stdout] 522 ~ }; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `.is_multiple_of()` [INFO] [stdout] --> src/qr_code/mod.rs:557:15 [INFO] [stdout] | [INFO] [stdout] 557 | while bit_string.len() % 8 != 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace with: `!bit_string.len().is_multiple_of(8)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_is_multiple_of [INFO] [stdout] = note: `#[warn(clippy::manual_is_multiple_of)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:623:23 [INFO] [stdout] | [INFO] [stdout] 623 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::vec::Vec` [INFO] [stdout] --> src/qr_code/mod.rs:634:23 [INFO] [stdout] | [INFO] [stdout] 634 | data.push(Vec::from(block.clone())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Vec::from()`: `block.clone()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/qr_code/mod.rs:859:13 [INFO] [stdout] | [INFO] [stdout] 859 | / if (row + column) % 2 == 0 { [INFO] [stdout] 860 | | if reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | | bit_map.invert_bit(row, column); [INFO] [stdout] 862 | | } [INFO] [stdout] 863 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 859 ~ if (row + column) % 2 == 0 [INFO] [stdout] 860 ~ && reservations.get(row, column) == Bit::Zero { [INFO] [stdout] 861 | bit_map.invert_bit(row, column); [INFO] [stdout] 862 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/qr_code/mod.rs:1052:16 [INFO] [stdout] | [INFO] [stdout] 1052 | if (x == 0 && y == 0) [INFO] [stdout] | ________________^ [INFO] [stdout] 1053 | | || (x == 0 && y == coords.len() - 1) [INFO] [stdout] | |____________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if !(x != 0 || y != 0 && y != coords.len() - 1) [INFO] [stdout] | [INFO] [stdout] 1052 - if (x == 0 && y == 0) [INFO] [stdout] 1053 - || (x == 0 && y == coords.len() - 1) [INFO] [stdout] 1052 + if (y == coords.len() - 1 || y == 0) && x == 0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1028:23 [INFO] [stdout] | [INFO] [stdout] 1028 | for x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1036:35 [INFO] [stdout] | [INFO] [stdout] 1036 | for reservation_x in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `isize` is unnecessary [INFO] [stdout] --> src/qr_code/mod.rs:1037:39 [INFO] [stdout] | [INFO] [stdout] 1037 | for reservation_y in -2..=2 as isize { [INFO] [stdout] | ^^^^^^^^^^ help: try: `2_isize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 1.01s [INFO] running `Command { std: "docker" "inspect" "147a403a8eca9f0aa4eba8826605ef3a733871634159df50806a7a66d97e3be2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "147a403a8eca9f0aa4eba8826605ef3a733871634159df50806a7a66d97e3be2", kill_on_drop: false }` [INFO] [stdout] 147a403a8eca9f0aa4eba8826605ef3a733871634159df50806a7a66d97e3be2