[INFO] cloning repository https://github.com/zyla/withoutbuffers [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zyla/withoutbuffers" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzyla%2Fwithoutbuffers", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzyla%2Fwithoutbuffers'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 8c2cf42ac49cb3af191736110c008af6fb5d1604 [INFO] linting zyla/withoutbuffers against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzyla%2Fwithoutbuffers" "/workspace/builds/worker-7-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-7-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zyla/withoutbuffers [INFO] finished tweaking git repo https://github.com/zyla/withoutbuffers [INFO] tweaked toml for git repo https://github.com/zyla/withoutbuffers written to /workspace/builds/worker-7-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zyla/withoutbuffers on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zyla/withoutbuffers already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded errno v0.3.5 [INFO] [stderr] Downloaded atomic-polyfill v0.1.11 [INFO] [stderr] Downloaded rustix v0.38.20 [INFO] [stderr] Downloaded libc v0.2.149 [INFO] [stderr] Downloaded linux-raw-sys v0.4.10 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 58aef521cce57e706e56d2db48e614bf628bba2c008a4a62860046b849e7b612 [INFO] running `Command { std: "docker" "start" "-a" "58aef521cce57e706e56d2db48e614bf628bba2c008a4a62860046b849e7b612", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "58aef521cce57e706e56d2db48e614bf628bba2c008a4a62860046b849e7b612", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "58aef521cce57e706e56d2db48e614bf628bba2c008a4a62860046b849e7b612", kill_on_drop: false }` [INFO] [stdout] 58aef521cce57e706e56d2db48e614bf628bba2c008a4a62860046b849e7b612 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-7-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] b079355e4197ae2acbf4ee4a4fd056368d03a95107e24cc16d5a44cf03b80c7d [INFO] running `Command { std: "docker" "start" "-a" "b079355e4197ae2acbf4ee4a4fd056368d03a95107e24cc16d5a44cf03b80c7d", kill_on_drop: false }` [INFO] [stderr] Compiling semver v1.0.20 [INFO] [stderr] Compiling rustix v0.38.20 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking linux-raw-sys v0.4.10 [INFO] [stderr] Checking termcolor v1.3.0 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Checking hash32 v0.2.1 [INFO] [stderr] Checking spin v0.9.8 [INFO] [stderr] Compiling rustc_version v0.4.0 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Compiling heapless v0.7.16 [INFO] [stderr] Checking is-terminal v0.4.9 [INFO] [stderr] Checking regex-automata v0.4.3 [INFO] [stderr] Checking regex v1.10.2 [INFO] [stderr] Checking env_logger v0.10.0 [INFO] [stderr] Checking incr-memcached v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | const ERROR_RESPONSE: &'static [u8] = b"ERROR\r\n"; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/main.rs:10:24 [INFO] [stdout] | [INFO] [stdout] 10 | const ERROR_RESPONSE: &'static [u8] = b"ERROR\r\n"; [INFO] [stdout] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / match self { [INFO] [stdout] 67 | | Self::SendingError { .. } => true, [INFO] [stdout] 68 | | Self::SendingGetVALUE { .. } => true, [INFO] [stdout] 69 | | Self::SendingGetKey { .. } => true, [INFO] [stdout] ... | [INFO] [stdout] 76 | | _ => false, [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 66 - match self { [INFO] [stdout] 67 - Self::SendingError { .. } => true, [INFO] [stdout] 68 - Self::SendingGetVALUE { .. } => true, [INFO] [stdout] 69 - Self::SendingGetKey { .. } => true, [INFO] [stdout] 70 - Self::SendingGetFlags { .. } => true, [INFO] [stdout] 71 - Self::SendingGetFlagsSpace { .. } => true, [INFO] [stdout] 72 - Self::SendingGetLen { .. } => true, [INFO] [stdout] 73 - Self::SendingGetNewline { .. } => true, [INFO] [stdout] 74 - Self::SendingGetData { .. } => true, [INFO] [stdout] 75 - Self::SendingEnd { .. } => true, [INFO] [stdout] 76 - _ => false, [INFO] [stdout] 77 - } [INFO] [stdout] 66 + matches!(self, Self::SendingError { .. } | Self::SendingGetVALUE { .. } | Self::SendingGetKey { .. } | Self::SendingGetFlags { .. } | Self::SendingGetFlagsSpace { .. } | Self::SendingGetLen { .. } | Self::SendingGetNewline { .. } | Self::SendingGetData { .. } | Self::SendingEnd { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:141:27 [INFO] [stdout] | [INFO] [stdout] 141 | while buf.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 175 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:286:40 [INFO] [stdout] | [INFO] [stdout] 286 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:331:32 [INFO] [stdout] | [INFO] [stdout] 331 | ... if !cmd.push(c).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.push(c).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:362:32 [INFO] [stdout] | [INFO] [stdout] 362 | ... if !key.push(c).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `key.push(c).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:372:29 [INFO] [stdout] | [INFO] [stdout] 372 | / ... if *flush_line { [INFO] [stdout] 373 | | ... if c == b'\n' { [INFO] [stdout] 374 | | ... *flush_line = false; [INFO] [stdout] 375 | | ... } [INFO] [stdout] 376 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ if *flush_line [INFO] [stdout] 373 ~ && c == b'\n' { [INFO] [stdout] 374 | *flush_line = false; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:66:9 [INFO] [stdout] | [INFO] [stdout] 66 | / match self { [INFO] [stdout] 67 | | Self::SendingError { .. } => true, [INFO] [stdout] 68 | | Self::SendingGetVALUE { .. } => true, [INFO] [stdout] 69 | | Self::SendingGetKey { .. } => true, [INFO] [stdout] ... | [INFO] [stdout] 76 | | _ => false, [INFO] [stdout] 77 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 66 - match self { [INFO] [stdout] 67 - Self::SendingError { .. } => true, [INFO] [stdout] 68 - Self::SendingGetVALUE { .. } => true, [INFO] [stdout] 69 - Self::SendingGetKey { .. } => true, [INFO] [stdout] 70 - Self::SendingGetFlags { .. } => true, [INFO] [stdout] 71 - Self::SendingGetFlagsSpace { .. } => true, [INFO] [stdout] 72 - Self::SendingGetLen { .. } => true, [INFO] [stdout] 73 - Self::SendingGetNewline { .. } => true, [INFO] [stdout] 74 - Self::SendingGetData { .. } => true, [INFO] [stdout] 75 - Self::SendingEnd { .. } => true, [INFO] [stdout] 76 - _ => false, [INFO] [stdout] 77 - } [INFO] [stdout] 66 + matches!(self, Self::SendingError { .. } | Self::SendingGetVALUE { .. } | Self::SendingGetKey { .. } | Self::SendingGetFlags { .. } | Self::SendingGetFlagsSpace { .. } | Self::SendingGetLen { .. } | Self::SendingGetNewline { .. } | Self::SendingGetData { .. } | Self::SendingEnd { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:141:27 [INFO] [stdout] | [INFO] [stdout] 141 | while buf.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:155:40 [INFO] [stdout] | [INFO] [stdout] 155 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:175:40 [INFO] [stdout] | [INFO] [stdout] 175 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/main.rs:286:40 [INFO] [stdout] | [INFO] [stdout] 286 | ... if remaining.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `remaining.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:331:32 [INFO] [stdout] | [INFO] [stdout] 331 | ... if !cmd.push(c).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `cmd.push(c).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:362:32 [INFO] [stdout] | [INFO] [stdout] 362 | ... if !key.push(c).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `key.push(c).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/main.rs:372:29 [INFO] [stdout] | [INFO] [stdout] 372 | / ... if *flush_line { [INFO] [stdout] 373 | | ... if c == b'\n' { [INFO] [stdout] 374 | | ... *flush_line = false; [INFO] [stdout] 375 | | ... } [INFO] [stdout] 376 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 372 ~ if *flush_line [INFO] [stdout] 373 ~ && c == b'\n' { [INFO] [stdout] 374 | *flush_line = false; [INFO] [stdout] 375 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 6.67s [INFO] running `Command { std: "docker" "inspect" "b079355e4197ae2acbf4ee4a4fd056368d03a95107e24cc16d5a44cf03b80c7d", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "b079355e4197ae2acbf4ee4a4fd056368d03a95107e24cc16d5a44cf03b80c7d", kill_on_drop: false }` [INFO] [stdout] b079355e4197ae2acbf4ee4a4fd056368d03a95107e24cc16d5a44cf03b80c7d