[INFO] cloning repository https://github.com/zukigit/learn-rust [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zukigit/learn-rust" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzukigit%2Flearn-rust", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzukigit%2Flearn-rust'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9d04e1c7a8568b6d1ea55055c3754c3fecd39f8c [INFO] linting zukigit/learn-rust against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzukigit%2Flearn-rust" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-0-tc1/source/rust-toolchain.toml [INFO] started tweaking git repo https://github.com/zukigit/learn-rust [INFO] finished tweaking git repo https://github.com/zukigit/learn-rust [INFO] tweaked toml for git repo https://github.com/zukigit/learn-rust written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zukigit/learn-rust on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zukigit/learn-rust already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ce70b50180063764ed09fd47c30f82bf71f19d05317912fa85a2594b6c055611 [INFO] running `Command { std: "docker" "start" "-a" "ce70b50180063764ed09fd47c30f82bf71f19d05317912fa85a2594b6c055611", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ce70b50180063764ed09fd47c30f82bf71f19d05317912fa85a2594b6c055611", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ce70b50180063764ed09fd47c30f82bf71f19d05317912fa85a2594b6c055611", kill_on_drop: false }` [INFO] [stdout] ce70b50180063764ed09fd47c30f82bf71f19d05317912fa85a2594b6c055611 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 0260adbfdfc3c061cb74c471f5592ee266ba0be40affbde0d55dee648b67b70f [INFO] running `Command { std: "docker" "start" "-a" "0260adbfdfc3c061cb74c471f5592ee266ba0be40affbde0d55dee648b67b70f", kill_on_drop: false }` [INFO] [stderr] Checking learn-rust v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/formatted_print.rs:6:56 [INFO] [stdout] | [INFO] [stdout] 6 | println!("{0} lives in {1}. {2} lives in {1} too", "zuki", "Rangoon", "wai"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - println!("{0} lives in {1}. {2} lives in {1} too", "zuki", "Rangoon", "wai"); [INFO] [stdout] 6 + println!("zuki lives in {0}. wai lives in {0} too", "Rangoon"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/formatted_print.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | sub="he", [INFO] [stdout] | _____________^ [INFO] [stdout] 10 | | verb="is", [INFO] [stdout] 11 | | obj="good"); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 8 - println!("{sub} {verb} {obj}", [INFO] [stdout] 9 - sub="he", [INFO] [stdout] 10 - verb="is", [INFO] [stdout] 11 - obj="good"); [INFO] [stdout] 8 + println!("he is good"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/formatted_print.rs:6:56 [INFO] [stdout] | [INFO] [stdout] 6 | println!("{0} lives in {1}. {2} lives in {1} too", "zuki", "Rangoon", "wai"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] = note: `#[warn(clippy::print_literal)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 6 - println!("{0} lives in {1}. {2} lives in {1} too", "zuki", "Rangoon", "wai"); [INFO] [stdout] 6 + println!("zuki lives in {0}. wai lives in {0} too", "Rangoon"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: literal with an empty format string [INFO] [stdout] --> src/modules/formatted_print.rs:9:13 [INFO] [stdout] | [INFO] [stdout] 9 | sub="he", [INFO] [stdout] | _____________^ [INFO] [stdout] 10 | | verb="is", [INFO] [stdout] 11 | | obj="good"); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#print_literal [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 8 - println!("{sub} {verb} {obj}", [INFO] [stdout] 9 - sub="he", [INFO] [stdout] 10 - verb="is", [INFO] [stdout] 11 - obj="good"); [INFO] [stdout] 8 + println!("he is good"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:10:38 [INFO] [stdout] | [INFO] [stdout] 10 | println!("true AND false is {}", true && false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:11:37 [INFO] [stdout] | [INFO] [stdout] 11 | println!("true OR false is {}", true || false); [INFO] [stdout] | ^^^^^^^^^^^^^ help: try: `true` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/modules/operators.rs:12:32 [INFO] [stdout] | [INFO] [stdout] 12 | println!("NOT true is {}", !true); [INFO] [stdout] | ^^^^^ help: try: `false` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/modules/enums.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | Self::PageLoad => format!("It is pageload"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It is pageload".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/modules/enums.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | Self::PageUnload => format!("It is pageunload"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It is pageunload".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/modules/enums.rs:12:31 [INFO] [stdout] | [INFO] [stdout] 12 | Self::PageLoad => format!("It is pageload"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It is pageload".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/modules/enums.rs:13:33 [INFO] [stdout] | [INFO] [stdout] 13 | Self::PageUnload => format!("It is pageunload"), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `"It is pageunload".to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/modules/from_and_into.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | impl Into for i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 19 ~ impl From for NumberStore1 { [INFO] [stdout] 20 ~ fn from(val: i32) -> Self { [INFO] [stdout] 21 ~ NumberStore1 { owner: "default_owner".to_string(), number: val } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/modules/from_and_into.rs:19:1 [INFO] [stdout] | [INFO] [stdout] 19 | impl Into for i32 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 19 ~ impl From for NumberStore1 { [INFO] [stdout] 20 ~ fn from(val: i32) -> Self { [INFO] [stdout] 21 ~ NumberStore1 { owner: "default_owner".to_string(), number: val } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.25s [INFO] running `Command { std: "docker" "inspect" "0260adbfdfc3c061cb74c471f5592ee266ba0be40affbde0d55dee648b67b70f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0260adbfdfc3c061cb74c471f5592ee266ba0be40affbde0d55dee648b67b70f", kill_on_drop: false }` [INFO] [stdout] 0260adbfdfc3c061cb74c471f5592ee266ba0be40affbde0d55dee648b67b70f