[INFO] cloning repository https://github.com/zowens/paxos-rs [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zowens/paxos-rs" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzowens%2Fpaxos-rs", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzowens%2Fpaxos-rs'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3de3f1ed9f33787f29a959a15f090077db9cb3c2 [INFO] linting zowens/paxos-rs against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzowens%2Fpaxos-rs" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zowens/paxos-rs [INFO] finished tweaking git repo https://github.com/zowens/paxos-rs [INFO] tweaked toml for git repo https://github.com/zowens/paxos-rs written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zowens/paxos-rs on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zowens/paxos-rs already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded rand_core v0.9.0 [INFO] [stderr] Downloaded getrandom v0.3.0 [INFO] [stderr] Downloaded wit-bindgen-rt v0.33.0 [INFO] [stderr] Downloaded zerocopy-derive v0.8.14 [INFO] [stderr] Downloaded hyper v0.14.30 [INFO] [stderr] Downloaded wasi v0.13.3+wasi-0.2.2 [INFO] [stderr] Downloaded zerocopy v0.8.14 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 8a876c3cadae9d8dc8ca48c584167e212519d863f0e5b1c7503b9d12376e467a [INFO] running `Command { std: "docker" "start" "-a" "8a876c3cadae9d8dc8ca48c584167e212519d863f0e5b1c7503b9d12376e467a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "8a876c3cadae9d8dc8ca48c584167e212519d863f0e5b1c7503b9d12376e467a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "8a876c3cadae9d8dc8ca48c584167e212519d863f0e5b1c7503b9d12376e467a", kill_on_drop: false }` [INFO] [stdout] 8a876c3cadae9d8dc8ca48c584167e212519d863f0e5b1c7503b9d12376e467a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 26af2ff0d31b2ac3b36161d6e90b29ba8447e83ec98319a177a20e4d60a10f48 [INFO] running `Command { std: "docker" "start" "-a" "26af2ff0d31b2ac3b36161d6e90b29ba8447e83ec98319a177a20e4d60a10f48", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.89 [INFO] [stderr] Compiling libc v0.2.169 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Checking pin-project-lite v0.2.13 [INFO] [stderr] Compiling getrandom v0.3.0 [INFO] [stderr] Checking memchr v2.7.1 [INFO] [stderr] Compiling zerocopy v0.8.14 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking regex-syntax v0.8.2 [INFO] [stderr] Checking itoa v1.0.10 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking anstream v0.6.13 [INFO] [stderr] Checking aho-corasick v1.1.2 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking humantime v2.1.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Compiling quote v1.0.35 [INFO] [stderr] Checking mio v0.8.11 [INFO] [stderr] Checking socket2 v0.5.6 [INFO] [stderr] Compiling syn v2.0.87 [INFO] [stderr] Checking regex-automata v0.4.6 [INFO] [stderr] Checking rand_core v0.9.0 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking regex v1.10.3 [INFO] [stderr] Checking env_filter v0.1.0 [INFO] [stderr] Checking env_logger v0.11.5 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling tokio-macros v2.2.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Checking tokio v1.36.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking bytes v1.11.1 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Checking paxos v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/acceptor.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | if let AcceptorState::Resolved { .. } = self.state { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - if let AcceptorState::Resolved { .. } = self.state { true } else { false } [INFO] [stdout] 47 + matches!(self.state, AcceptorState::Resolved { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/config.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | impl Into for NodeMetadata { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 15 ~ impl From for Bytes { [INFO] [stdout] 16 ~ fn from(val: NodeMetadata) -> Self { [INFO] [stdout] 17 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator + '_` [INFO] [stdout] --> src/node.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | for node in self.config.peer_node_ids().into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.config.peer_node_ids()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/node.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / if let SlotMutRef::Resolved(..) = self.window.slot_mut(*slot) { [INFO] [stdout] 289 | | false [INFO] [stdout] 290 | | } else { [INFO] [stdout] 291 | | true [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 288 - if let SlotMutRef::Resolved(..) = self.window.slot_mut(*slot) { [INFO] [stdout] 289 - false [INFO] [stdout] 290 - } else { [INFO] [stdout] 291 - true [INFO] [stdout] 292 - } [INFO] [stdout] 288 + !matches!(self.window.slot_mut(*slot), SlotMutRef::Resolved(..)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `run_bal` after checking its variant with `is_some` [INFO] [stdout] --> src/node.rs:334:49 [INFO] [stdout] | [INFO] [stdout] 333 | if !buf.is_empty() && run_bal.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 334 | self.send(node, Command::Resolution(run_bal.unwrap(), buf)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | let lost_leadership = match self.state { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 52 | | ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader => { [INFO] [stdout] 53 | | true [INFO] [stdout] ... | [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - let lost_leadership = match self.state { [INFO] [stdout] 52 - ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader => { [INFO] [stdout] 53 - true [INFO] [stdout] 54 - } [INFO] [stdout] 55 - _ => false, [INFO] [stdout] 56 - }; [INFO] [stdout] 51 + let lost_leadership = matches!(self.state, ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/proposer.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | mem::replace(&mut self.proposal_queue, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.proposal_queue)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | if let ProposerState::Leader { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 176 - if let ProposerState::Leader { .. } = *self { true } else { false } [INFO] [stdout] 176 + matches!(*self, ProposerState::Leader { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | if let ProposerState::Candidate { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 181 - if let ProposerState::Candidate { .. } = *self { true } else { false } [INFO] [stdout] 181 + matches!(*self, ProposerState::Candidate { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 186 - if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] 186 + matches!(*self, ProposerState::Follower { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/proposer.rs:186:39 [INFO] [stdout] | [INFO] [stdout] 186 | if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/window.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / let mut open = Vec::new(); [INFO] [stdout] 33 | | // add the first slot [INFO] [stdout] 34 | | open.push(Acceptor::new(None, quorum)); [INFO] [stdout] | |_______________________________________________^ help: consider using the `vec![]` macro: `let open = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/window.rs:191:36 [INFO] [stdout] | [INFO] [stdout] 191 | DecisionIterator { window: &self.window, i: 0, end: self.window.decided.len() } [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/window.rs:211:36 [INFO] [stdout] | [INFO] [stdout] 211 | DecisionIterator { window: &self.window, i: start, end } [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/lib.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | / impl PartialOrd for Ballot { [INFO] [stdout] 72 | | fn partial_cmp(&self, other: &Ballot) -> Option { [INFO] [stdout] 73 | | match self.0.cmp(&other.0) { [INFO] [stdout] 74 | | cmp::Ordering::Equal => self.1.partial_cmp(&other.1), [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn partial_cmp(&self, other: &Ballot) -> Option { [INFO] [stdout] 73 - match self.0.cmp(&other.0) { [INFO] [stdout] 74 - cmp::Ordering::Equal => self.1.partial_cmp(&other.1), [INFO] [stdout] 75 - o => Some(o), [INFO] [stdout] 76 - } [INFO] [stdout] 77 - } [INFO] [stdout] 72 + fn partial_cmp(&self, other: &Ballot) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | fn decisions(&self) -> DecisionSet; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | fn decisions(&self) -> DecisionSet<'_>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/config.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn peers<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stdout] | -- ^^^^^^^^^^^^^ -- the same lifetime is named here [INFO] [stdout] | | | [INFO] [stdout] | the lifetime is named here the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn peers<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/liveness.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/node.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 360 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/statemachine.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 58 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn slot_mut(&mut self, slot: Slot) -> SlotMutRef { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 40 | pub fn slot_mut(&mut self, slot: Slot) -> SlotMutRef<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn next_slot(&mut self) -> OpenSlotMutRef { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 73 | pub fn next_slot(&mut self) -> OpenSlotMutRef<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 92 | pub fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> DecisionIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> DecisionIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:194:21 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn range(&self, range: R) -> DecisionIterator [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 194 | pub fn range(&self, range: R) -> DecisionIterator<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> examples/http-paxos/kvstore.rs:1:1 [INFO] [stdout] | [INFO] [stdout] 1 | use bincode; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/config.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | use test; [INFO] [stdout] | ^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> examples/http-paxos/kvstore.rs:18:1 [INFO] [stdout] | [INFO] [stdout] 18 | impl Into for KvCommand { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 18 ~ impl From for Bytes { [INFO] [stdout] 19 ~ fn from(val: KvCommand) -> Self { [INFO] [stdout] 20 ~ bincode::serialize(&val).unwrap().into() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the function `bincode::deserialize` doesn't need a mutable reference [INFO] [stdout] --> examples/http-paxos/kvstore.rs:29:30 [INFO] [stdout] | [INFO] [stdout] 29 | bincode::deserialize(&mut value).map_err(|e| { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 29 - bincode::deserialize(&mut value).map_err(|e| { [INFO] [stdout] 29 + bincode::deserialize(&value).map_err(|e| { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary operation [INFO] [stdout] --> examples/http-paxos/kvstore.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | &inner.pending_get.insert(id, snd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: statement can be reduced to: `inner.pending_get.insert(id, snd);` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_operation [INFO] [stdout] = note: `#[warn(clippy::unnecessary_operation)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `skip(..).next()` on an iterator [INFO] [stdout] --> examples/http-paxos/main.rs:26:35 [INFO] [stdout] | [INFO] [stdout] 26 | let node_id_str = match args().skip(1).next() { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: use `nth` instead: `.nth(1)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#iter_skip_next [INFO] [stdout] = note: `#[warn(clippy::iter_skip_next)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this call to `from_str_radix` can be replaced with a call to `str::parse` [INFO] [stdout] --> examples/http-paxos/main.rs:34:25 [INFO] [stdout] | [INFO] [stdout] 34 | let node_id = match u32::from_str_radix(&node_id_str, 10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `node_id_str.parse::()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_str_radix_10 [INFO] [stdout] = note: `#[warn(clippy::from_str_radix_10)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unused borrow that must be used [INFO] [stdout] --> examples/http-paxos/kvstore.rs:63:13 [INFO] [stdout] | [INFO] [stdout] 63 | &inner.pending_get.insert(id, snd); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the borrow produces a value [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(unused_must_use)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] help: use `let _ = ...` to ignore the resulting value [INFO] [stdout] | [INFO] [stdout] 63 | let _ = &inner.pending_get.insert(id, snd); [INFO] [stdout] | +++++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/acceptor.rs:47:9 [INFO] [stdout] | [INFO] [stdout] 47 | if let AcceptorState::Resolved { .. } = self.state { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 47 - if let AcceptorState::Resolved { .. } = self.state { true } else { false } [INFO] [stdout] 47 + matches!(self.state, AcceptorState::Resolved { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/config.rs:15:1 [INFO] [stdout] | [INFO] [stdout] 15 | impl Into for NodeMetadata { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: `impl From for Foreign` is allowed by the orphan rules, for more information see [INFO] [stdout] https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 15 ~ impl From for Bytes { [INFO] [stdout] 16 ~ fn from(val: NodeMetadata) -> Self { [INFO] [stdout] 17 ~ val.0 [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `impl std::iter::Iterator + '_` [INFO] [stdout] --> src/node.rs:101:21 [INFO] [stdout] | [INFO] [stdout] 101 | for node in self.config.peer_node_ids().into_iter() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `self.config.peer_node_ids()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/node.rs:288:21 [INFO] [stdout] | [INFO] [stdout] 288 | / if let SlotMutRef::Resolved(..) = self.window.slot_mut(*slot) { [INFO] [stdout] 289 | | false [INFO] [stdout] 290 | | } else { [INFO] [stdout] 291 | | true [INFO] [stdout] 292 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 288 - if let SlotMutRef::Resolved(..) = self.window.slot_mut(*slot) { [INFO] [stdout] 289 - false [INFO] [stdout] 290 - } else { [INFO] [stdout] 291 - true [INFO] [stdout] 292 - } [INFO] [stdout] 288 + !matches!(self.window.slot_mut(*slot), SlotMutRef::Resolved(..)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `run_bal` after checking its variant with `is_some` [INFO] [stdout] --> src/node.rs:334:49 [INFO] [stdout] | [INFO] [stdout] 333 | if !buf.is_empty() && run_bal.is_some() { [INFO] [stdout] | ----------------- the check is happening here [INFO] [stdout] 334 | self.send(node, Command::Resolution(run_bal.unwrap(), buf)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/node.rs:644:17 [INFO] [stdout] | [INFO] [stdout] 644 | assert!(match replica.window.slot_mut(4) { [INFO] [stdout] | _________________^ [INFO] [stdout] 645 | | SlotMutRef::Resolved(Ballot(1, 2), val) if val == "123" => true, [INFO] [stdout] 646 | | _ => false, [INFO] [stdout] 647 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 644 - assert!(match replica.window.slot_mut(4) { [INFO] [stdout] 645 - SlotMutRef::Resolved(Ballot(1, 2), val) if val == "123" => true, [INFO] [stdout] 646 - _ => false, [INFO] [stdout] 647 - }); [INFO] [stdout] 644 + assert!(matches!(replica.window.slot_mut(4), SlotMutRef::Resolved(Ballot(1, 2), val) if val == "123")); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:51:31 [INFO] [stdout] | [INFO] [stdout] 51 | let lost_leadership = match self.state { [INFO] [stdout] | _______________________________^ [INFO] [stdout] 52 | | ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader => { [INFO] [stdout] 53 | | true [INFO] [stdout] ... | [INFO] [stdout] 56 | | }; [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 51 - let lost_leadership = match self.state { [INFO] [stdout] 52 - ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader => { [INFO] [stdout] 53 - true [INFO] [stdout] 54 - } [INFO] [stdout] 55 - _ => false, [INFO] [stdout] 56 - }; [INFO] [stdout] 51 + let lost_leadership = matches!(self.state, ProposerState::Candidate { .. } | ProposerState::Leader { .. } if !ballot_leader); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: replacing a value of type `T` with `T::default()` is better expressed using `std::mem::take` [INFO] [stdout] --> src/proposer.rs:143:9 [INFO] [stdout] | [INFO] [stdout] 143 | mem::replace(&mut self.proposal_queue, Vec::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `std::mem::take(&mut self.proposal_queue)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#mem_replace_with_default [INFO] [stdout] = note: `#[warn(clippy::mem_replace_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | if let ProposerState::Leader { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 176 - if let ProposerState::Leader { .. } = *self { true } else { false } [INFO] [stdout] 176 + matches!(*self, ProposerState::Leader { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:181:9 [INFO] [stdout] | [INFO] [stdout] 181 | if let ProposerState::Candidate { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 181 - if let ProposerState::Candidate { .. } = *self { true } else { false } [INFO] [stdout] 181 + matches!(*self, ProposerState::Candidate { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `if let .. else` expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:186:9 [INFO] [stdout] | [INFO] [stdout] 186 | if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 186 - if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] 186 + matches!(*self, ProposerState::Follower { .. }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: struct pattern is not needed for a unit variant [INFO] [stdout] --> src/proposer.rs:186:39 [INFO] [stdout] | [INFO] [stdout] 186 | if let ProposerState::Follower { .. } = *self { true } else { false } [INFO] [stdout] | ^^^^^^^ help: remove the struct pattern [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_struct_pattern [INFO] [stdout] = note: `#[warn(clippy::unneeded_struct_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:200:17 [INFO] [stdout] | [INFO] [stdout] 200 | assert!(match proposer.prepare() { [INFO] [stdout] | _________________^ [INFO] [stdout] 201 | | Ballot(101, 1) => true, [INFO] [stdout] 202 | | _ => false, [INFO] [stdout] 203 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 200 - assert!(match proposer.prepare() { [INFO] [stdout] 201 - Ballot(101, 1) => true, [INFO] [stdout] 202 - _ => false, [INFO] [stdout] 203 - }); [INFO] [stdout] 200 + assert!(matches!(proposer.prepare(), Ballot(101, 1))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:205:17 [INFO] [stdout] | [INFO] [stdout] 205 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 206 | | ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 207 | | _ => false, [INFO] [stdout] 208 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 205 - assert!(match proposer.state { [INFO] [stdout] 206 - ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 207 - _ => false, [INFO] [stdout] 208 - }); [INFO] [stdout] 205 + assert!(matches!(proposer.state, ProposerState::Candidate { proposal: Ballot(101, 1), .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:222:17 [INFO] [stdout] | [INFO] [stdout] 222 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 223 | | ProposerState::Candidate { proposal: Ballot(101, 1), ref promises, .. } [INFO] [stdout] 224 | | if promises.contains(1) => [INFO] [stdout] 225 | | true, [INFO] [stdout] 226 | | _ => false, [INFO] [stdout] 227 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 222 - assert!(match proposer.state { [INFO] [stdout] 223 - ProposerState::Candidate { proposal: Ballot(101, 1), ref promises, .. } [INFO] [stdout] 224 - if promises.contains(1) => [INFO] [stdout] 225 - true, [INFO] [stdout] 226 - _ => false, [INFO] [stdout] 227 - }); [INFO] [stdout] 222 + assert!(matches!(proposer.state, ProposerState::Candidate { proposal: Ballot(101, 1), ref promises, .. } if promises.contains(1))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:232:17 [INFO] [stdout] | [INFO] [stdout] 232 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 233 | | ProposerState::Leader { proposal: Ballot(101, 1) } => true, [INFO] [stdout] 234 | | _ => false, [INFO] [stdout] 235 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 232 - assert!(match proposer.state { [INFO] [stdout] 233 - ProposerState::Leader { proposal: Ballot(101, 1) } => true, [INFO] [stdout] 234 - _ => false, [INFO] [stdout] 235 - }); [INFO] [stdout] 232 + assert!(matches!(proposer.state, ProposerState::Leader { proposal: Ballot(101, 1) })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:246:17 [INFO] [stdout] | [INFO] [stdout] 246 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 247 | | ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 248 | | _ => false, [INFO] [stdout] 249 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 246 - assert!(match proposer.state { [INFO] [stdout] 247 - ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 248 - _ => false, [INFO] [stdout] 249 - }); [INFO] [stdout] 246 + assert!(matches!(proposer.state, ProposerState::Candidate { proposal: Ballot(101, 1), .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:255:17 [INFO] [stdout] | [INFO] [stdout] 255 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 256 | | ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 257 | | _ => false, [INFO] [stdout] 258 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 255 - assert!(match proposer.state { [INFO] [stdout] 256 - ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 257 - _ => false, [INFO] [stdout] 258 - }); [INFO] [stdout] 255 + assert!(matches!(proposer.state, ProposerState::Candidate { proposal: Ballot(101, 1), .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:264:17 [INFO] [stdout] | [INFO] [stdout] 264 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 265 | | ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 266 | | _ => false, [INFO] [stdout] 267 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 264 - assert!(match proposer.state { [INFO] [stdout] 265 - ProposerState::Candidate { proposal: Ballot(101, 1), .. } => true, [INFO] [stdout] 266 - _ => false, [INFO] [stdout] 267 - }); [INFO] [stdout] 264 + assert!(matches!(proposer.state, ProposerState::Candidate { proposal: Ballot(101, 1), .. })); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/proposer.rs:272:17 [INFO] [stdout] | [INFO] [stdout] 272 | assert!(match proposer.state { [INFO] [stdout] | _________________^ [INFO] [stdout] 273 | | ProposerState::Follower => true, [INFO] [stdout] 274 | | _ => false, [INFO] [stdout] 275 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 272 - assert!(match proposer.state { [INFO] [stdout] 273 - ProposerState::Follower => true, [INFO] [stdout] 274 - _ => false, [INFO] [stdout] 275 - }); [INFO] [stdout] 272 + assert!(matches!(proposer.state, ProposerState::Follower)); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: calls to `push` immediately after creation [INFO] [stdout] --> src/window.rs:32:9 [INFO] [stdout] | [INFO] [stdout] 32 | / let mut open = Vec::new(); [INFO] [stdout] 33 | | // add the first slot [INFO] [stdout] 34 | | open.push(Acceptor::new(None, quorum)); [INFO] [stdout] | |_______________________________________________^ help: consider using the `vec![]` macro: `let open = vec![..];` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#vec_init_then_push [INFO] [stdout] = note: `#[warn(clippy::vec_init_then_push)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/window.rs:191:36 [INFO] [stdout] | [INFO] [stdout] 191 | DecisionIterator { window: &self.window, i: 0, end: self.window.decided.len() } [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/window.rs:211:36 [INFO] [stdout] | [INFO] [stdout] 211 | DecisionIterator { window: &self.window, i: start, end } [INFO] [stdout] | ^^^^^^^^^^^^ help: change this to: `self.window` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/window.rs:308:17 [INFO] [stdout] | [INFO] [stdout] 308 | assert!(match window.slot_mut(0) { [INFO] [stdout] | _________________^ [INFO] [stdout] 309 | | SlotMutRef::Open(_) => true, [INFO] [stdout] 310 | | _ => false, [INFO] [stdout] 311 | | }); [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 308 - assert!(match window.slot_mut(0) { [INFO] [stdout] 309 - SlotMutRef::Open(_) => true, [INFO] [stdout] 310 - _ => false, [INFO] [stdout] 311 - }); [INFO] [stdout] 308 + assert!(matches!(window.slot_mut(0), SlotMutRef::Open(_))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/window.rs:366:51 [INFO] [stdout] | [INFO] [stdout] 366 | SlotMutRef::Open(ref mut slot) => !slot.acceptor().highest_value().is_some(), [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `slot.acceptor().highest_value().is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/window.rs:398:21 [INFO] [stdout] | [INFO] [stdout] 398 | assert!(match window.slot_mut(i) { [INFO] [stdout] | _____________________^ [INFO] [stdout] 399 | | SlotMutRef::Resolved(..) => true, [INFO] [stdout] 400 | | _ => false, [INFO] [stdout] 401 | | }) [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 398 - assert!(match window.slot_mut(i) { [INFO] [stdout] 399 - SlotMutRef::Resolved(..) => true, [INFO] [stdout] 400 - _ => false, [INFO] [stdout] 401 - }) [INFO] [stdout] 398 + assert!(matches!(window.slot_mut(i), SlotMutRef::Resolved(..))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: non-canonical implementation of `partial_cmp` on an `Ord` type [INFO] [stdout] --> src/lib.rs:71:1 [INFO] [stdout] | [INFO] [stdout] 71 | / impl PartialOrd for Ballot { [INFO] [stdout] 72 | | fn partial_cmp(&self, other: &Ballot) -> Option { [INFO] [stdout] 73 | | match self.0.cmp(&other.0) { [INFO] [stdout] 74 | | cmp::Ordering::Equal => self.1.partial_cmp(&other.1), [INFO] [stdout] ... | [INFO] [stdout] 78 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#non_canonical_partial_ord_impl [INFO] [stdout] = note: `#[warn(clippy::non_canonical_partial_ord_impl)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 72 - fn partial_cmp(&self, other: &Ballot) -> Option { [INFO] [stdout] 73 - match self.0.cmp(&other.0) { [INFO] [stdout] 74 - cmp::Ordering::Equal => self.1.partial_cmp(&other.1), [INFO] [stdout] 75 - o => Some(o), [INFO] [stdout] 76 - } [INFO] [stdout] 77 - } [INFO] [stdout] 72 + fn partial_cmp(&self, other: &Ballot) -> Option { Some(self.cmp(other)) } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:97:18 [INFO] [stdout] | [INFO] [stdout] 97 | fn decisions(&self) -> DecisionSet; [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 97 | fn decisions(&self) -> DecisionSet<'_>; [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: eliding a lifetime that's named elsewhere is confusing [INFO] [stdout] --> src/config.rs:56:65 [INFO] [stdout] | [INFO] [stdout] 56 | pub fn peers<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stdout] | -- ^^^^^^^^^^^^^ -- the same lifetime is named here [INFO] [stdout] | | | [INFO] [stdout] | the lifetime is named here the same lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: consistently use `'a` [INFO] [stdout] | [INFO] [stdout] 56 | pub fn peers<'a>(&'a self) -> impl Iterator + 'a { [INFO] [stdout] | ++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/liveness.rs:62:18 [INFO] [stdout] | [INFO] [stdout] 62 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 62 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/liveness.rs:220:22 [INFO] [stdout] | [INFO] [stdout] 220 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 220 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/node.rs:360:18 [INFO] [stdout] | [INFO] [stdout] 360 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 360 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/statemachine.rs:58:18 [INFO] [stdout] | [INFO] [stdout] 58 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 58 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/statemachine.rs:188:22 [INFO] [stdout] | [INFO] [stdout] 188 | fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 188 | fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:40:21 [INFO] [stdout] | [INFO] [stdout] 40 | pub fn slot_mut(&mut self, slot: Slot) -> SlotMutRef { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 40 | pub fn slot_mut(&mut self, slot: Slot) -> SlotMutRef<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:73:22 [INFO] [stdout] | [INFO] [stdout] 73 | pub fn next_slot(&mut self) -> OpenSlotMutRef { [INFO] [stdout] | ^^^^^^^^^ ^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 73 | pub fn next_slot(&mut self) -> OpenSlotMutRef<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:92:22 [INFO] [stdout] | [INFO] [stdout] 92 | pub fn decisions(&self) -> DecisionSet { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 92 | pub fn decisions(&self) -> DecisionSet<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:190:17 [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> DecisionIterator { [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 190 | pub fn iter(&self) -> DecisionIterator<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/window.rs:194:21 [INFO] [stdout] | [INFO] [stdout] 194 | pub fn range(&self, range: R) -> DecisionIterator [INFO] [stdout] | ^^^^^ ^^^^^^^^^^^^^^^^ the same lifetime is hidden here [INFO] [stdout] | | [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 194 | pub fn range(&self, range: R) -> DecisionIterator<'_> [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 30.56s [INFO] running `Command { std: "docker" "inspect" "26af2ff0d31b2ac3b36161d6e90b29ba8447e83ec98319a177a20e4d60a10f48", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "26af2ff0d31b2ac3b36161d6e90b29ba8447e83ec98319a177a20e4d60a10f48", kill_on_drop: false }` [INFO] [stdout] 26af2ff0d31b2ac3b36161d6e90b29ba8447e83ec98319a177a20e4d60a10f48