[INFO] cloning repository https://github.com/zornfeuer/sweep [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zornfeuer/sweep" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzornfeuer%2Fsweep", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzornfeuer%2Fsweep'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9fc130a464cb3cb00c29a747e3ff1822764f1632 [INFO] linting zornfeuer/sweep against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzornfeuer%2Fsweep" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zornfeuer/sweep [INFO] finished tweaking git repo https://github.com/zornfeuer/sweep [INFO] tweaked toml for git repo https://github.com/zornfeuer/sweep written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zornfeuer/sweep on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zornfeuer/sweep already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Blocking waiting for file lock on package cache [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded instability v0.3.9 [INFO] [stderr] Downloaded convert_case v0.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 30483a5dc2d1b955b872d06a210cb2fded77db74ff86339441049b101d3b8d4c [INFO] running `Command { std: "docker" "start" "-a" "30483a5dc2d1b955b872d06a210cb2fded77db74ff86339441049b101d3b8d4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "30483a5dc2d1b955b872d06a210cb2fded77db74ff86339441049b101d3b8d4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "30483a5dc2d1b955b872d06a210cb2fded77db74ff86339441049b101d3b8d4c", kill_on_drop: false }` [INFO] [stdout] 30483a5dc2d1b955b872d06a210cb2fded77db74ff86339441049b101d3b8d4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d8d01663a6ece11f1ef89c1957f9801ff45f546b6c785c787c62b614f5aab646 [INFO] running `Command { std: "docker" "start" "-a" "d8d01663a6ece11f1ef89c1957f9801ff45f546b6c785c787c62b614f5aab646", kill_on_drop: false }` [INFO] [stderr] Compiling signal-hook v0.3.18 [INFO] [stderr] Checking bitflags v2.9.4 [INFO] [stderr] Compiling convert_case v0.7.1 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Compiling instability v0.3.9 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking castaway v0.2.4 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Compiling litrs v0.4.2 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking winnow v0.7.13 [INFO] [stderr] Compiling indoc v2.0.6 [INFO] [stderr] Checking dirs-sys v0.5.0 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking lru v0.12.5 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Checking compact_str v0.8.1 [INFO] [stderr] Checking serde_spanned v1.0.3 [INFO] [stderr] Checking rustix v0.38.44 [INFO] [stderr] Checking toml_datetime v0.7.3 [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking dirs v6.0.0 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling document-features v0.2.11 [INFO] [stderr] Checking crossterm v0.28.1 [INFO] [stderr] Checking unicode-truncate v1.1.0 [INFO] [stderr] Checking toml_parser v1.0.4 [INFO] [stderr] Checking toml v0.9.8 [INFO] [stderr] Compiling darling_core v0.20.11 [INFO] [stderr] Compiling strum_macros v0.26.4 [INFO] [stderr] Compiling derive_more-impl v2.0.1 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Checking derive_more v2.0.1 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Checking strum v0.26.3 [INFO] [stderr] Compiling darling_macro v0.20.11 [INFO] [stderr] Compiling darling v0.20.11 [INFO] [stderr] Checking ratatui v0.29.0 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking sweep v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: fields `version` and `installed` are never read [INFO] [stdout] --> src/types.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Package { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 19 | pub name: String, [INFO] [stdout] 20 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 21 | pub description: String, [INFO] [stdout] 22 | pub installed: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Package` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `associated_package` is never read [INFO] [stdout] --> src/types.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct HomeArtifact { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 34 | pub path: std::path::PathBuf, [INFO] [stdout] 35 | pub associated_package: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HomeArtifact` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 65 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 66 | | match key.code { [INFO] [stdout] 67 | | KeyCode::Char('c') if key.modifiers.contains(KeyModifiers::CONTROL) => break false, [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 65 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 66 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 70 | / ... if !self.items.is_empty() { [INFO] [stdout] 71 | | ... self.selected[self.cursor] = !self.selected[self.cursor]; [INFO] [stdout] 72 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ c if self.config.keybindings.select.contains(&c) [INFO] [stdout] 70 ~ && !self.items.is_empty() => { [INFO] [stdout] 71 | self.selected[self.cursor] = !self.selected[self.cursor]; [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/tui.rs:78:72 [INFO] [stdout] | [INFO] [stdout] 78 | ... let is_all = self.selected.iter().all(|&x| x == true); [INFO] [stdout] | ^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 181 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 182 | | match key.code { [INFO] [stdout] 183 | | KeyCode::Char('y') | KeyCode::Char('Y') => break true, [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 180 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 181 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 182 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 186 | } [INFO] [stdout] 187 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/config.rs:180:19 [INFO] [stdout] | [INFO] [stdout] 180 | let hex = &s[1..]; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/config.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | if s.starts_with('#') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 179 ~ if let Some(hex) = s.strip_prefix('#') { [INFO] [stdout] 180 ~ match hex.len() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 - if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] 41 + if !(!cli.orphans && cli.residual) { [INFO] [stdout] | [INFO] [stdout] 41 - if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] 41 + if cli.orphans || !cli.residual { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 49 - if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] 49 + if !(!cli.residual && cli.orphans) { [INFO] [stdout] | [INFO] [stdout] 49 - if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] 49 + if cli.residual || !cli.orphans { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: fields `version` and `installed` are never read [INFO] [stdout] --> src/types.rs:20:9 [INFO] [stdout] | [INFO] [stdout] 18 | pub struct Package { [INFO] [stdout] | ------- fields in this struct [INFO] [stdout] 19 | pub name: String, [INFO] [stdout] 20 | pub version: String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] 21 | pub description: String, [INFO] [stdout] 22 | pub installed: bool, [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `Package` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] = note: `#[warn(dead_code)]` (part of `#[warn(unused)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field `associated_package` is never read [INFO] [stdout] --> src/types.rs:35:9 [INFO] [stdout] | [INFO] [stdout] 33 | pub struct HomeArtifact { [INFO] [stdout] | ------------ field in this struct [INFO] [stdout] 34 | pub path: std::path::PathBuf, [INFO] [stdout] 35 | pub associated_package: Option, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `HomeArtifact` has derived impls for the traits `Clone` and `Debug`, but these are intentionally ignored during dead code analysis [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:64:13 [INFO] [stdout] | [INFO] [stdout] 64 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 65 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 66 | | match key.code { [INFO] [stdout] 67 | | KeyCode::Char('c') if key.modifiers.contains(KeyModifiers::CONTROL) => break false, [INFO] [stdout] ... | [INFO] [stdout] 84 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 64 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 65 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 66 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 82 | } [INFO] [stdout] 83 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/tui.rs:70:29 [INFO] [stdout] | [INFO] [stdout] 70 | / ... if !self.items.is_empty() { [INFO] [stdout] 71 | | ... self.selected[self.cursor] = !self.selected[self.cursor]; [INFO] [stdout] 72 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 69 ~ c if self.config.keybindings.select.contains(&c) [INFO] [stdout] 70 ~ && !self.items.is_empty() => { [INFO] [stdout] 71 | self.selected[self.cursor] = !self.selected[self.cursor]; [INFO] [stdout] 72 ~ }, [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: equality checks against true are unnecessary [INFO] [stdout] --> src/tui.rs:78:72 [INFO] [stdout] | [INFO] [stdout] 78 | ... let is_all = self.selected.iter().all(|&x| x == true); [INFO] [stdout] | ^^^^^^^^^ help: try: `x` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_comparison)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/tui.rs:180:17 [INFO] [stdout] | [INFO] [stdout] 180 | / if let Event::Key(key) = event::read()? { [INFO] [stdout] 181 | | if key.kind == KeyEventKind::Press { [INFO] [stdout] 182 | | match key.code { [INFO] [stdout] 183 | | KeyCode::Char('y') | KeyCode::Char('Y') => break true, [INFO] [stdout] ... | [INFO] [stdout] 188 | | } [INFO] [stdout] | |_________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 180 ~ if let Event::Key(key) = event::read()? [INFO] [stdout] 181 ~ && key.kind == KeyEventKind::Press { [INFO] [stdout] 182 | match key.code { [INFO] [stdout] ... [INFO] [stdout] 186 | } [INFO] [stdout] 187 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/config.rs:180:19 [INFO] [stdout] | [INFO] [stdout] 180 | let hex = &s[1..]; [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/config.rs:179:5 [INFO] [stdout] | [INFO] [stdout] 179 | if s.starts_with('#') { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 179 ~ if let Some(hex) = s.strip_prefix('#') { [INFO] [stdout] 180 ~ match hex.len() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:41:16 [INFO] [stdout] | [INFO] [stdout] 41 | if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 41 - if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] 41 + if !(!cli.orphans && cli.residual) { [INFO] [stdout] | [INFO] [stdout] 41 - if cli.orphans || (!cli.orphans && !cli.residual) { [INFO] [stdout] 41 + if cli.orphans || !cli.residual { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:49:16 [INFO] [stdout] | [INFO] [stdout] 49 | if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 49 - if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] 49 + if !(!cli.residual && cli.orphans) { [INFO] [stdout] | [INFO] [stdout] 49 - if cli.residual || (!cli.orphans && !cli.residual) { [INFO] [stdout] 49 + if cli.residual || !cli.orphans { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 20.65s [INFO] running `Command { std: "docker" "inspect" "d8d01663a6ece11f1ef89c1957f9801ff45f546b6c785c787c62b614f5aab646", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d8d01663a6ece11f1ef89c1957f9801ff45f546b6c785c787c62b614f5aab646", kill_on_drop: false }` [INFO] [stdout] d8d01663a6ece11f1ef89c1957f9801ff45f546b6c785c787c62b614f5aab646