[INFO] cloning repository https://github.com/zn3x/castmedia [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zn3x/castmedia" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzn3x%2Fcastmedia", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzn3x%2Fcastmedia'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0c2ede1c685c25fd7368c4091925d397c1178b28 [INFO] linting zn3x/castmedia against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzn3x%2Fcastmedia" "/workspace/builds/worker-1-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-1-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zn3x/castmedia [INFO] finished tweaking git repo https://github.com/zn3x/castmedia [INFO] tweaked toml for git repo https://github.com/zn3x/castmedia written to /workspace/builds/worker-1-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zn3x/castmedia on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zn3x/castmedia already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://codeberg.org/zesty/qanat` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded redox_syscall v0.5.4 [INFO] [stderr] Downloaded serde_derive v1.0.205 [INFO] [stderr] Downloaded fastrand v2.1.0 [INFO] [stderr] Downloaded scrypt v0.11.0 [INFO] [stderr] Downloaded tinyvec v1.8.0 [INFO] [stderr] Downloaded diatomic-waker v0.1.0 [INFO] [stderr] Downloaded serde_with_macros v3.9.0 [INFO] [stderr] Downloaded passfd v0.1.6 [INFO] [stderr] Downloaded symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Downloaded bytemuck v1.16.3 [INFO] [stderr] Downloaded fancy-regex v0.11.0 [INFO] [stderr] Downloaded symphonia-core v0.5.4 [INFO] [stderr] Downloaded openssl-sys v0.9.103 [INFO] [stderr] Downloaded serde_with v3.9.0 [INFO] [stderr] Downloaded backtrace v0.3.73 [INFO] [stderr] Downloaded serde_json v1.0.122 [INFO] [stderr] Downloaded hyper v0.14.30 [INFO] [stderr] Downloaded mio v1.0.1 [INFO] [stderr] Downloaded chrono v0.4.38 [INFO] [stderr] Downloaded regex v1.10.6 [INFO] [stderr] Downloaded cc v1.1.8 [INFO] [stderr] Downloaded openssl v0.10.66 [INFO] [stderr] Downloaded bytes v1.7.1 [INFO] [stderr] Downloaded gimli v0.29.0 [INFO] [stderr] Downloaded tempfile v3.12.0 [INFO] [stderr] Downloaded object v0.36.3 [INFO] [stderr] Downloaded addr2line v0.22.0 [INFO] [stderr] Downloaded rustix v0.38.34 [INFO] [stderr] Downloaded socket2 v0.5.7 [INFO] [stderr] Downloaded serde v1.0.205 [INFO] [stderr] Downloaded zxcvbn v2.2.2 [INFO] [stderr] Downloaded url v2.5.2 [INFO] [stderr] Downloaded anyhow v1.0.86 [INFO] [stderr] Downloaded derive_builder v0.12.0 [INFO] [stderr] Downloaded seize v0.4.5 [INFO] [stderr] Downloaded derive_builder_core v0.12.0 [INFO] [stderr] Downloaded async-event v0.2.1 [INFO] [stderr] Downloaded rustversion v1.0.17 [INFO] [stderr] Downloaded diatomic-waker v0.2.0 [INFO] [stderr] Downloaded tokio v1.39.2 [INFO] [stderr] Downloaded httparse v1.9.4 [INFO] [stderr] Downloaded ipnet v2.10.0 [INFO] [stderr] Downloaded security-framework-sys v2.11.1 [INFO] [stderr] Downloaded symphonia-metadata v0.5.4 [INFO] [stderr] Downloaded inotify v0.10.2 [INFO] [stderr] Downloaded password-hash v0.5.0 [INFO] [stderr] Downloaded salsa20 v0.10.2 [INFO] [stderr] Downloaded derive_builder_macro v0.12.0 [INFO] [stderr] Downloaded errno v0.3.9 [INFO] [stderr] Downloaded symphonia v0.5.4 [INFO] [stderr] Downloaded encoding_rs v0.8.34 [INFO] [stderr] Downloaded openssl-src v300.3.1+3.3.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 9d785a789b6c5c9c8f0758244d62a0d4e59efc5d22814291bd3242c92c250017 [INFO] running `Command { std: "docker" "start" "-a" "9d785a789b6c5c9c8f0758244d62a0d4e59efc5d22814291bd3242c92c250017", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "9d785a789b6c5c9c8f0758244d62a0d4e59efc5d22814291bd3242c92c250017", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "9d785a789b6c5c9c8f0758244d62a0d4e59efc5d22814291bd3242c92c250017", kill_on_drop: false }` [INFO] [stdout] 9d785a789b6c5c9c8f0758244d62a0d4e59efc5d22814291bd3242c92c250017 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-1-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] d340a96acb9305614ef501521d65b0fe41d73a4b4966b984e27fddf254d2517f [INFO] running `Command { std: "docker" "start" "-a" "d340a96acb9305614ef501521d65b0fe41d73a4b4966b984e27fddf254d2517f", kill_on_drop: false }` [INFO] [stderr] warning: virtual workspace defaulting to `resolver = "1"` despite one or more workspace members being on edition 2021 which implies `resolver = "2"` [INFO] [stderr] | [INFO] [stderr] = note: to keep the current resolver, specify `workspace.resolver = "1"` in the workspace root's manifest [INFO] [stderr] = note: to use the edition 2021 resolver, specify `workspace.resolver = "2"` in the workspace root's manifest [INFO] [stderr] = note: for more details see https://doc.rust-lang.org/cargo/reference/resolver.html#resolver-versions [INFO] [stderr] Compiling syn v2.0.72 [INFO] [stderr] Compiling serde v1.0.205 [INFO] [stderr] Compiling cc v1.1.8 [INFO] [stderr] Checking bytes v1.7.1 [INFO] [stderr] Checking futures-core v0.3.30 [INFO] [stderr] Compiling fnv v1.0.7 [INFO] [stderr] Compiling vcpkg v0.2.15 [INFO] [stderr] Compiling ident_case v1.0.1 [INFO] [stderr] Compiling slab v0.4.9 [INFO] [stderr] Checking futures-sink v0.3.30 [INFO] [stderr] Checking parking_lot_core v0.9.10 [INFO] [stderr] Checking socket2 v0.5.7 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Checking mio v1.0.1 [INFO] [stderr] Checking tracing-core v0.1.32 [INFO] [stderr] Checking futures-io v0.3.30 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling openssl v0.10.66 [INFO] [stderr] Checking futures-channel v0.3.30 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Compiling strsim v0.10.0 [INFO] [stderr] Compiling httparse v1.9.4 [INFO] [stderr] Compiling native-tls v0.2.12 [INFO] [stderr] Checking tinyvec v1.8.0 [INFO] [stderr] Checking encoding_rs v0.8.34 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking regex-syntax v0.8.4 [INFO] [stderr] Checking unicode-bidi v0.3.15 [INFO] [stderr] Compiling strsim v0.11.1 [INFO] [stderr] Checking futures-util v0.3.30 [INFO] [stderr] Checking http v0.2.12 [INFO] [stderr] Compiling serde_json v1.0.122 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling anyhow v1.0.86 [INFO] [stderr] Checking base64 v0.21.7 [INFO] [stderr] Checking try-lock v0.2.5 [INFO] [stderr] Checking bytemuck v1.16.3 [INFO] [stderr] Checking want v0.3.1 [INFO] [stderr] Checking symphonia-core v0.5.4 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling openssl-src v300.3.1+3.3.1 [INFO] [stderr] Checking regex-syntax v0.6.29 [INFO] [stderr] Checking powerfmt v0.2.0 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking deranged v0.3.11 [INFO] [stderr] Checking time-core v0.1.2 [INFO] [stderr] Checking num-conv v0.1.0 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Checking cpufeatures v0.2.12 [INFO] [stderr] Checking password-hash v0.5.0 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking salsa20 v0.10.2 [INFO] [stderr] Checking http-body v0.4.6 [INFO] [stderr] Checking rustls-pemfile v1.0.4 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking unicode-normalization v0.1.23 [INFO] [stderr] Checking sharded-slab v0.1.7 [INFO] [stderr] Compiling openssl-sys v0.9.103 [INFO] [stderr] Checking inotify-sys v0.1.5 [INFO] [stderr] Checking itertools v0.10.5 [INFO] [stderr] Checking thread_local v1.1.8 [INFO] [stderr] Checking async-event v0.2.1 [INFO] [stderr] Checking unsafe-libyaml v0.2.11 [INFO] [stderr] Checking diatomic-waker v0.2.0 [INFO] [stderr] Checking ipnet v2.10.0 [INFO] [stderr] Checking iana-time-zone v0.1.60 [INFO] [stderr] Checking seize v0.4.5 [INFO] [stderr] Checking quick-error v2.0.1 [INFO] [stderr] Checking sync_wrapper v0.1.2 [INFO] [stderr] Checking scrypt v0.11.0 [INFO] [stderr] Checking passfd v0.1.6 [INFO] [stderr] Checking urlencoding v2.1.3 [INFO] [stderr] Checking diatomic-waker v0.1.0 [INFO] [stderr] Checking idna v0.5.0 [INFO] [stderr] Checking qanat v0.1.0 (https://codeberg.org/zesty/qanat#130e5b80) [INFO] [stderr] Checking regex-automata v0.1.10 [INFO] [stderr] Checking symphonia-metadata v0.5.4 [INFO] [stderr] Checking time v0.3.36 [INFO] [stderr] Checking regex-automata v0.4.7 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking symphonia-bundle-mp3 v0.5.4 [INFO] [stderr] Checking matchers v0.1.0 [INFO] [stderr] Checking symphonia v0.5.4 [INFO] [stderr] Checking futures-executor v0.3.30 [INFO] [stderr] Checking futures v0.3.30 [INFO] [stderr] Compiling darling_core v0.14.4 [INFO] [stderr] Checking regex v1.10.6 [INFO] [stderr] Checking fancy-regex v0.11.0 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.205 [INFO] [stderr] Compiling tokio-macros v2.4.0 [INFO] [stderr] Compiling tracing-attributes v0.1.27 [INFO] [stderr] Compiling openssl-macros v0.1.1 [INFO] [stderr] Checking tokio v1.39.2 [INFO] [stderr] Compiling darling_macro v0.14.4 [INFO] [stderr] Compiling darling v0.14.4 [INFO] [stderr] Compiling derive_builder_core v0.12.0 [INFO] [stderr] Checking tracing v0.1.40 [INFO] [stderr] Checking tracing-subscriber v0.3.18 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling serde_with_macros v3.9.0 [INFO] [stderr] Compiling derive_builder_macro v0.12.0 [INFO] [stderr] Checking derive_builder v0.12.0 [INFO] [stderr] Checking zxcvbn v2.2.2 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking url v2.5.2 [INFO] [stderr] Checking serde_urlencoded v0.7.1 [INFO] [stderr] Checking uuid v1.10.0 [INFO] [stderr] Checking tokio-util v0.7.12 [INFO] [stderr] Checking inotify v0.10.2 [INFO] [stderr] Checking indexmap v2.3.0 [INFO] [stderr] Checking serde_with v3.9.0 [INFO] [stderr] Checking h2 v0.3.26 [INFO] [stderr] Checking serde_yaml v0.9.34+deprecated [INFO] [stderr] Checking hyper v0.14.30 [INFO] [stderr] Checking tokio-native-tls v0.3.1 [INFO] [stderr] Checking hyper-tls v0.5.0 [INFO] [stderr] Checking castmedia v0.1.0 (/opt/rustwide/workdir/castmedia) [INFO] [stderr] Checking reqwest v0.11.27 [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> castmedia/src/http.rs:200:53 [INFO] [stdout] | [INFO] [stdout] 200 | } else if hex_len.ends_with(&[b'\r', b'\n']) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `b"\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking test-utils v0.1.0 (/opt/rustwide/workdir/test-utils) [INFO] [stdout] warning: can be more succinctly written as a byte str [INFO] [stdout] --> castmedia/src/http.rs:200:53 [INFO] [stdout] | [INFO] [stdout] 200 | } else if hex_len.ends_with(&[b'\r', b'\n']) { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `b"\r\n"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#byte_char_slices [INFO] [stdout] = note: `#[warn(clippy::byte_char_slices)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> castmedia/src/config.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 446 | if &address.bind as *const _ != &address1.bind as *const _ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!std::ptr::eq(&address.bind, &address1.bind)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/client.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | async fn listener_broadcast<'a>(session: &mut ClientSession, b: &mut BroadcastInfo) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> castmedia/src/client.rs:433:1 [INFO] [stdout] | [INFO] [stdout] 433 | / pub enum ClientInfo { [INFO] [stdout] 434 | | Source(SourceInfo), [INFO] [stdout] | | ------------------ the largest variant contains at least 448 bytes [INFO] [stdout] 435 | | Listener(ListenerInfo), [INFO] [stdout] | | ---------------------- the second-largest variant contains at least 104 bytes [INFO] [stdout] 436 | | MasterMountUpdates(MasterMountUpdatesInfo) [INFO] [stdout] 437 | | } [INFO] [stdout] | |_^ the entire enum is at least 448 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 434 - Source(SourceInfo), [INFO] [stdout] 434 + Source(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/client.rs:451:20 [INFO] [stdout] | [INFO] [stdout] 451 | pub broadcast: Option<(Sender>>, Receiver>>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/request.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !req.headers.first().is_some_and(|x| !x.name.is_empty()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `req.headers.first().is_none_or(|x| x.name.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/source.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | migrated: Option<(Sender>>, Receiver>>)>) -> (Self, SourceBroadcast, oneshot::Receiver<()>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> castmedia/src/stream.rs:446:1 [INFO] [stdout] | [INFO] [stdout] 446 | / async fn handle_relay_stream(stream: &mut dyn StreamReader, [INFO] [stdout] 447 | | server: &Server, mountpoint: &str, [INFO] [stdout] 448 | | broadcast: &mut SourceBroadcast, [INFO] [stdout] 449 | | queue_size: &mut usize, [INFO] [stdout] ... | [INFO] [stdout] 453 | | stats: &SourceStats, [INFO] [stdout] 454 | | on_demand: bool) -> Result<()> { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/admin.rs:378:29 [INFO] [stdout] | [INFO] [stdout] 378 | pub async fn handle_request<'a>(mut session: ClientSession, req: AdminRequest) -> Result<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/api.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | pub async fn handle_request<'a>(mut session: ClientSession, req: ApiRequest) -> Result<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous` after checking its variant with `is_some` [INFO] [stdout] --> castmedia/src/utils.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 37 | if previous.is_some() && !can_backtrack(previous.unwrap()) { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 38 | out.push(previous.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> castmedia/src/migrate.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 191 | if lock.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lock.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/relay.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | ... mut mounts: HashMap)>>>) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/relay.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | ... mounts: HashMap)>>>) -> ! { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/relay.rs:287:8 [INFO] [stdout] | [INFO] [stdout] 287 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/relay.rs:389:8 [INFO] [stdout] | [INFO] [stdout] 389 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/broadcast.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | pub async fn broadcast_metadata<'a>(source: &Source, title: &Option<&str>, url: &Option<&str>) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/broadcast.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | pub async fn relay_broadcast_metadata<'a>(src_metadata: &RwLock>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use `std::ptr::eq` when comparing raw pointers [INFO] [stdout] --> castmedia/src/config.rs:446:20 [INFO] [stdout] | [INFO] [stdout] 446 | if &address.bind as *const _ != &address1.bind as *const _ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `!std::ptr::eq(&address.bind, &address1.bind)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_eq [INFO] [stdout] = note: `#[warn(clippy::ptr_eq)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking castmediayp v0.1.0 (/opt/rustwide/workdir/yellowpages) [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/client.rs:246:29 [INFO] [stdout] | [INFO] [stdout] 246 | async fn listener_broadcast<'a>(session: &mut ClientSession, b: &mut BroadcastInfo) [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] = note: `#[warn(clippy::extra_unused_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: large size difference between variants [INFO] [stdout] --> castmedia/src/client.rs:433:1 [INFO] [stdout] | [INFO] [stdout] 433 | / pub enum ClientInfo { [INFO] [stdout] 434 | | Source(SourceInfo), [INFO] [stdout] | | ------------------ the largest variant contains at least 448 bytes [INFO] [stdout] 435 | | Listener(ListenerInfo), [INFO] [stdout] | | ---------------------- the second-largest variant contains at least 104 bytes [INFO] [stdout] 436 | | MasterMountUpdates(MasterMountUpdatesInfo) [INFO] [stdout] 437 | | } [INFO] [stdout] | |_^ the entire enum is at least 448 bytes [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#large_enum_variant [INFO] [stdout] = note: `#[warn(clippy::large_enum_variant)]` on by default [INFO] [stdout] help: consider boxing the large fields or introducing indirection in some other way to reduce the total size of the enum [INFO] [stdout] | [INFO] [stdout] 434 - Source(SourceInfo), [INFO] [stdout] 434 + Source(Box), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/client.rs:451:20 [INFO] [stdout] | [INFO] [stdout] 451 | pub broadcast: Option<(Sender>>, Receiver>>)>, [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/request.rs:95:8 [INFO] [stdout] | [INFO] [stdout] 95 | if !req.headers.first().is_some_and(|x| !x.name.is_empty()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `req.headers.first().is_none_or(|x| x.name.is_empty())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/source.rs:122:26 [INFO] [stdout] | [INFO] [stdout] 122 | migrated: Option<(Sender>>, Receiver>>)>) -> (Self, SourceBroadcast, oneshot::Receiver<()>) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> castmedia/tests/stream.rs:74:18 [INFO] [stdout] | [INFO] [stdout] 74 | .get(&format!("http://{}{}", BASE, MOUNT_SOURCE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("http://{}{}", BASE, MOUNT_SOURCE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> castmedia/tests/stream.rs:86:26 [INFO] [stdout] | [INFO] [stdout] 86 | ...et(&format!("http://{}@{}/admin/metadata?mode=updinfo&mount={}&url=url_here&song=title_here", AUTH_SOURCE, ADMIN, MOUNT_SOURCE)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `format!("http://{}@{}/admin/metadata?mode=updinfo&mount={}&url=url_here&song=title_here", AUTH_SOURCE, ADMIN, MOUNT_SOURCE)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> castmedia/src/stream.rs:446:1 [INFO] [stdout] | [INFO] [stdout] 446 | / async fn handle_relay_stream(stream: &mut dyn StreamReader, [INFO] [stdout] 447 | | server: &Server, mountpoint: &str, [INFO] [stdout] 448 | | broadcast: &mut SourceBroadcast, [INFO] [stdout] 449 | | queue_size: &mut usize, [INFO] [stdout] ... | [INFO] [stdout] 453 | | stats: &SourceStats, [INFO] [stdout] 454 | | on_demand: bool) -> Result<()> { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/admin.rs:378:29 [INFO] [stdout] | [INFO] [stdout] 378 | pub async fn handle_request<'a>(mut session: ClientSession, req: AdminRequest) -> Result<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/api.rs:69:29 [INFO] [stdout] | [INFO] [stdout] 69 | pub async fn handle_request<'a>(mut session: ClientSession, req: ApiRequest) -> Result<()> { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `previous` after checking its variant with `is_some` [INFO] [stdout] --> castmedia/src/utils.rs:38:30 [INFO] [stdout] | [INFO] [stdout] 37 | if previous.is_some() && !can_backtrack(previous.unwrap()) { [INFO] [stdout] | ------------------ the check is happening here [INFO] [stdout] 38 | out.push(previous.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> castmedia/src/migrate.rs:191:12 [INFO] [stdout] | [INFO] [stdout] 191 | if lock.len() == 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `lock.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/relay.rs:58:47 [INFO] [stdout] | [INFO] [stdout] 58 | ... mut mounts: HashMap)>>>) -> Result<()> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> castmedia/src/relay.rs:221:47 [INFO] [stdout] | [INFO] [stdout] 221 | ... mounts: HashMap)>>>) -> ! { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/relay.rs:287:8 [INFO] [stdout] | [INFO] [stdout] 287 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> castmedia/src/relay.rs:389:8 [INFO] [stdout] | [INFO] [stdout] 389 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/broadcast.rs:62:33 [INFO] [stdout] | [INFO] [stdout] 62 | pub async fn broadcast_metadata<'a>(source: &Source, title: &Option<&str>, url: &Option<&str>) { [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this lifetime isn't used in the function definition [INFO] [stdout] --> castmedia/src/broadcast.rs:76:39 [INFO] [stdout] | [INFO] [stdout] 76 | pub async fn relay_broadcast_metadata<'a>(src_metadata: &RwLock>, [INFO] [stdout] | ^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> yellowpages/src/main.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> yellowpages/src/main.rs:262:1 [INFO] [stdout] | [INFO] [stdout] 262 | / async fn touch_action(config: &Config, conf: &Directory, client: &Client, dir: &Url, [INFO] [stdout] 263 | | mount: &str, state: &Option, metadata: Option<&String>, [INFO] [stdout] 264 | | sid: &mut Option, tick: &mut tokio::time::Interval, [INFO] [stdout] 265 | | tx: &mut mpsc::UnboundedSender) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> yellowpages/src/main.rs:342:1 [INFO] [stdout] | [INFO] [stdout] 342 | / async fn add_action(config: &Config, conf: &Directory, client: &Client, dir: &Url, [INFO] [stdout] 343 | | mount: &str, properties: &IcyProperties, [INFO] [stdout] 344 | | sid: &mut Option, tick: &mut tokio::time::Interval, [INFO] [stdout] 345 | | tx: &mut mpsc::UnboundedSender) { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> yellowpages/src/main.rs:349:41 [INFO] [stdout] | [INFO] [stdout] 349 | if v.last().is_some_and(|x| (*x).eq("")) { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> yellowpages/src/main.rs:75:12 [INFO] [stdout] | [INFO] [stdout] 75 | if !resp.code.is_some_and(|c| c == 200) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `resp.code.is_none_or(|c| c != 200)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (10/7) [INFO] [stdout] --> yellowpages/src/main.rs:262:1 [INFO] [stdout] | [INFO] [stdout] 262 | / async fn touch_action(config: &Config, conf: &Directory, client: &Client, dir: &Url, [INFO] [stdout] 263 | | mount: &str, state: &Option, metadata: Option<&String>, [INFO] [stdout] 264 | | sid: &mut Option, tick: &mut tokio::time::Interval, [INFO] [stdout] 265 | | tx: &mut mpsc::UnboundedSender) { [INFO] [stdout] | |_____________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] = note: `#[warn(clippy::too_many_arguments)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this function has too many arguments (9/7) [INFO] [stdout] --> yellowpages/src/main.rs:342:1 [INFO] [stdout] | [INFO] [stdout] 342 | / async fn add_action(config: &Config, conf: &Directory, client: &Client, dir: &Url, [INFO] [stdout] 343 | | mount: &str, properties: &IcyProperties, [INFO] [stdout] 344 | | sid: &mut Option, tick: &mut tokio::time::Interval, [INFO] [stdout] 345 | | tx: &mut mpsc::UnboundedSender) { [INFO] [stdout] | |___________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: comparison to empty slice [INFO] [stdout] --> yellowpages/src/main.rs:349:41 [INFO] [stdout] | [INFO] [stdout] 349 | if v.last().is_some_and(|x| (*x).eq("")) { [INFO] [stdout] | ^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `x.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#comparison_to_empty [INFO] [stdout] = note: `#[warn(clippy::comparison_to_empty)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 19s [INFO] running `Command { std: "docker" "inspect" "d340a96acb9305614ef501521d65b0fe41d73a4b4966b984e27fddf254d2517f", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "d340a96acb9305614ef501521d65b0fe41d73a4b4966b984e27fddf254d2517f", kill_on_drop: false }` [INFO] [stdout] d340a96acb9305614ef501521d65b0fe41d73a4b4966b984e27fddf254d2517f