[INFO] cloning repository https://github.com/zaphar/sheetsui [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zaphar/sheetsui" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzaphar%2Fsheetsui", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzaphar%2Fsheetsui'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 0cd93b44c98e64b4514b98f2a2c4bf18be95dcc8 [INFO] linting zaphar/sheetsui against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzaphar%2Fsheetsui" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zaphar/sheetsui [INFO] finished tweaking git repo https://github.com/zaphar/sheetsui [INFO] tweaked toml for git repo https://github.com/zaphar/sheetsui written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zaphar/sheetsui on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zaphar/sheetsui already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Updating git repository `https://dev.zaphar.net/zaphar/slice-cursor-rs.git` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded instability v0.3.2 [INFO] [stderr] Downloaded indoc v2.0.5 [INFO] [stderr] Downloaded tui-markdown v0.3.7 [INFO] [stderr] Downloaded redox_syscall v0.5.7 [INFO] [stderr] Downloaded error-code v3.3.1 [INFO] [stderr] Downloaded os_pipe v1.2.1 [INFO] [stderr] Downloaded wayland-sys v0.31.5 [INFO] [stderr] Downloaded bitcode_derive v0.6.9 [INFO] [stderr] Downloaded objc2-io-surface v0.3.0 [INFO] [stderr] Downloaded anstyle v1.0.9 [INFO] [stderr] Downloaded wayland-protocols-wlr v0.3.4 [INFO] [stderr] Downloaded wl-clipboard-rs v0.9.1 [INFO] [stderr] Downloaded wayland-scanner v0.31.5 [INFO] [stderr] Downloaded objc2-core-graphics v0.3.0 [INFO] [stderr] Downloaded wayland-backend v0.3.7 [INFO] [stderr] Downloaded bitcode v0.6.9 [INFO] [stderr] Downloaded objc2-core-foundation v0.3.0 [INFO] [stderr] Downloaded flate2 v1.0.34 [INFO] [stderr] Downloaded parse-zoneinfo v0.3.1 [INFO] [stderr] Downloaded wayland-protocols v0.32.4 [INFO] [stderr] Downloaded statrs v0.18.0 [INFO] [stderr] Downloaded scc v2.4.0 [INFO] [stderr] Downloaded quick-xml v0.32.0 [INFO] [stderr] Downloaded cc v1.1.37 [INFO] [stderr] Downloaded ratatui-textarea v0.8.0 [INFO] [stderr] Downloaded objc2 v0.6.0 [INFO] [stderr] Downloaded ansi-to-tui v8.0.1 [INFO] [stderr] Downloaded objc2-foundation v0.3.0 [INFO] [stderr] Downloaded rstest_macros v0.26.1 [INFO] [stderr] Downloaded ironcalc_base v0.7.1 [INFO] [stderr] Downloaded chrono-tz v0.10.1 [INFO] [stderr] Downloaded rstest v0.26.1 [INFO] [stderr] Downloaded libloading v0.8.5 [INFO] [stderr] Downloaded wayland-client v0.31.6 [INFO] [stderr] Downloaded objc2-app-kit v0.3.0 [INFO] [stderr] Downloaded roxmltree v0.19.0 [INFO] [stderr] Downloaded bytemuck v1.19.0 [INFO] [stderr] Downloaded plist v1.7.0 [INFO] [stderr] Downloaded anstream v0.6.17 [INFO] [stderr] Downloaded glam v0.29.2 [INFO] [stderr] Downloaded anyhow v1.0.91 [INFO] [stderr] Downloaded sdd v3.0.10 [INFO] [stderr] Downloaded thiserror v1.0.65 [INFO] [stderr] Downloaded colorsys v0.6.7 [INFO] [stderr] Downloaded htmf v0.2.0 [INFO] [stderr] Downloaded getopts v0.2.21 [INFO] [stderr] Downloaded tui-prompts v0.6.1 [INFO] [stderr] Downloaded serial_test v3.4.0 [INFO] [stderr] Downloaded chrono-tz-build v0.4.0 [INFO] [stderr] Downloaded zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Downloaded phf_codegen v0.11.2 [INFO] [stderr] Downloaded cpufeatures v0.2.15 [INFO] [stderr] Downloaded serial_test_derive v3.4.0 [INFO] [stderr] Downloaded thiserror-impl v1.0.65 [INFO] [stderr] Downloaded allocator-api2 v0.2.18 [INFO] [stderr] Downloaded unicode-truncate v2.0.1 [INFO] [stderr] Downloaded ironcalc v0.7.1 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 5128e7aed0dbc302180e6d0239b04651633a5f09b226512d8e1b20698811aaec [INFO] running `Command { std: "docker" "start" "-a" "5128e7aed0dbc302180e6d0239b04651633a5f09b226512d8e1b20698811aaec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "5128e7aed0dbc302180e6d0239b04651633a5f09b226512d8e1b20698811aaec", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "5128e7aed0dbc302180e6d0239b04651633a5f09b226512d8e1b20698811aaec", kill_on_drop: false }` [INFO] [stdout] 5128e7aed0dbc302180e6d0239b04651633a5f09b226512d8e1b20698811aaec [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] a05210c1895b952413314c6db737e76413a2836dcfbef6985391fac7e3cbab73 [INFO] running `Command { std: "docker" "start" "-a" "a05210c1895b952413314c6db737e76413a2836dcfbef6985391fac7e3cbab73", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.106 [INFO] [stderr] Compiling unicode-ident v1.0.13 [INFO] [stderr] Compiling libc v0.2.182 [INFO] [stderr] Compiling pkg-config v0.3.31 [INFO] [stderr] Compiling memchr v2.7.4 [INFO] [stderr] Checking allocator-api2 v0.2.18 [INFO] [stderr] Checking bitflags v2.11.0 [INFO] [stderr] Checking foldhash v0.2.0 [INFO] [stderr] Checking itoa v1.0.11 [INFO] [stderr] Checking smallvec v1.13.2 [INFO] [stderr] Checking log v0.4.22 [INFO] [stderr] Checking ryu v1.0.18 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling rustversion v1.0.18 [INFO] [stderr] Checking hashbrown v0.16.1 [INFO] [stderr] Checking generic-array v0.14.7 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling syn v2.0.117 [INFO] [stderr] Checking futures-core v0.3.31 [INFO] [stderr] Checking deranged v0.5.8 [INFO] [stderr] Checking num_threads v0.1.7 [INFO] [stderr] Checking miniz_oxide v0.8.0 [INFO] [stderr] Checking itertools v0.14.0 [INFO] [stderr] Checking castaway v0.2.3 [INFO] [stderr] Compiling jobserver v0.1.32 [INFO] [stderr] Compiling lock_api v0.4.12 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Compiling parking_lot_core v0.9.10 [INFO] [stderr] Compiling rustix v0.38.37 [INFO] [stderr] Compiling cc v1.1.37 [INFO] [stderr] Checking once_cell v1.20.2 [INFO] [stderr] Checking compact_str v0.9.0 [INFO] [stderr] Compiling regex-automata v0.4.9 [INFO] [stderr] Checking lru v0.16.3 [INFO] [stderr] Checking time v0.3.47 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking linux-raw-sys v0.4.14 [INFO] [stderr] Compiling siphasher v0.3.11 [INFO] [stderr] Compiling indoc v2.0.5 [INFO] [stderr] Checking unicode-truncate v2.0.1 [INFO] [stderr] Compiling phf_shared v0.11.2 [INFO] [stderr] Checking getrandom v0.2.15 [INFO] [stderr] Compiling wayland-sys v0.31.5 [INFO] [stderr] Checking libloading v0.8.5 [INFO] [stderr] Checking crc32fast v1.4.2 [INFO] [stderr] Compiling signal-hook v0.3.17 [INFO] [stderr] Compiling semver v1.0.23 [INFO] [stderr] Compiling convert_case v0.10.0 [INFO] [stderr] Checking flate2 v1.0.34 [INFO] [stderr] Checking dlib v0.5.2 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking parking_lot v0.12.3 [INFO] [stderr] Compiling phf_generator v0.11.2 [INFO] [stderr] Checking signal-hook-registry v1.4.2 [INFO] [stderr] Compiling wayland-backend v0.3.7 [INFO] [stderr] Compiling zstd-sys v2.0.13+zstd.1.5.6 [INFO] [stderr] Checking indexmap v2.13.0 [INFO] [stderr] Checking block-buffer v0.10.4 [INFO] [stderr] Compiling rustix v1.1.4 [INFO] [stderr] Checking pin-project-lite v0.2.15 [INFO] [stderr] Checking futures-channel v0.3.31 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling regex v1.11.1 [INFO] [stderr] Compiling phf_codegen v0.11.2 [INFO] [stderr] Checking mio v1.0.2 [INFO] [stderr] Compiling quick-xml v0.36.2 [INFO] [stderr] Checking cpufeatures v0.2.15 [INFO] [stderr] Compiling wayland-client v0.31.6 [INFO] [stderr] Checking linux-raw-sys v0.12.1 [INFO] [stderr] Compiling parse-zoneinfo v0.3.1 [INFO] [stderr] Checking futures-io v0.3.31 [INFO] [stderr] Compiling chrono-tz-build v0.4.0 [INFO] [stderr] Compiling wayland-scanner v0.31.5 [INFO] [stderr] Checking signal-hook-mio v0.2.4 [INFO] [stderr] Compiling rustc_version v0.4.1 [INFO] [stderr] Compiling bzip2-sys v0.1.11+1.0.8 [INFO] [stderr] Compiling onig_sys v69.9.1 [INFO] [stderr] Checking line-clipping v0.3.5 [INFO] [stderr] Compiling thiserror v1.0.65 [INFO] [stderr] Compiling zstd-safe v5.0.2+zstd.1.5.2 [INFO] [stderr] Compiling toml_datetime v0.6.8 [INFO] [stderr] Compiling serde_json v1.0.133 [INFO] [stderr] Compiling winnow v0.6.20 [INFO] [stderr] Checking bytemuck v1.19.0 [INFO] [stderr] Compiling rstest_macros v0.26.1 [INFO] [stderr] Compiling chrono-tz v0.10.1 [INFO] [stderr] Checking inout v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.228 [INFO] [stderr] Compiling thiserror-impl v2.0.18 [INFO] [stderr] Compiling strum_macros v0.27.2 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling zerocopy-derive v0.7.35 [INFO] [stderr] Compiling instability v0.3.2 [INFO] [stderr] Compiling derive_more-impl v2.1.1 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Checking thiserror v2.0.18 [INFO] [stderr] Checking kasuari v0.4.11 [INFO] [stderr] Checking derive_more v2.1.1 [INFO] [stderr] Compiling toml_edit v0.22.22 [INFO] [stderr] Checking ppv-lite86 v0.2.20 [INFO] [stderr] Checking strum v0.27.2 [INFO] [stderr] Compiling thiserror-impl v1.0.65 [INFO] [stderr] Checking ratatui-core v0.1.0 [INFO] [stderr] Checking ratatui-widgets v0.3.0 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking serde v1.0.228 [INFO] [stderr] Checking base64ct v1.6.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking utf8parse v0.2.2 [INFO] [stderr] Checking iana-time-zone v0.1.61 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking chrono v0.4.38 [INFO] [stderr] Checking crossterm v0.29.0 [INFO] [stderr] Compiling proc-macro-crate v3.2.0 [INFO] [stderr] Checking anstyle-parse v0.2.6 [INFO] [stderr] Checking password-hash v0.4.2 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking wayland-protocols v0.32.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Compiling bitcode_derive v0.6.9 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking phf v0.11.2 [INFO] [stderr] Checking sha2 v0.10.8 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking csv-core v0.1.11 [INFO] [stderr] Checking quick-xml v0.32.0 [INFO] [stderr] Checking gimli v0.31.1 [INFO] [stderr] Checking anstyle v1.0.9 [INFO] [stderr] Checking colorchoice v1.0.3 [INFO] [stderr] Checking unicode-width v0.1.14 [INFO] [stderr] Checking linked-hash-map v0.5.6 [INFO] [stderr] Compiling pulldown-cmark v0.13.0 [INFO] [stderr] Checking is_terminal_polyfill v1.70.1 [INFO] [stderr] Checking anstyle-query v1.1.2 [INFO] [stderr] Checking fastrand v2.1.1 [INFO] [stderr] Compiling relative-path v1.9.3 [INFO] [stderr] Compiling glob v0.3.1 [INFO] [stderr] Checking home v0.5.9 [INFO] [stderr] Compiling cfg-if v1.0.4 [INFO] [stderr] Checking plist v1.7.0 [INFO] [stderr] Checking getopts v0.2.21 [INFO] [stderr] Checking tree_magic_mini v3.1.5 [INFO] [stderr] Checking tempfile v3.13.0 [INFO] [stderr] Checking yaml-rust v0.4.5 [INFO] [stderr] Checking anstream v0.6.17 [INFO] [stderr] Checking png v0.17.16 [INFO] [stderr] Checking bitcode v0.6.9 [INFO] [stderr] Checking wayland-protocols-wlr v0.3.4 [INFO] [stderr] Checking csv v1.3.1 [INFO] [stderr] Checking pbkdf2 v0.11.0 [INFO] [stderr] Checking statrs v0.18.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking bzip2 v0.4.4 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking addr2line v0.24.2 [INFO] [stderr] Checking ratatui-crossterm v0.1.0 [INFO] [stderr] Checking onig v6.5.1 [INFO] [stderr] Checking futures-executor v0.3.31 [INFO] [stderr] Checking bincode v1.3.3 [INFO] [stderr] Compiling tracing-attributes v0.1.31 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking tracing-core v0.1.36 [INFO] [stderr] Checking os_pipe v1.2.1 [INFO] [stderr] Checking nom v8.0.0 [INFO] [stderr] Checking object v0.36.5 [INFO] [stderr] Checking x11rb-protocol v0.13.1 [INFO] [stderr] Checking strsim v0.11.1 [INFO] [stderr] Checking diff v0.1.13 [INFO] [stderr] Checking constant_time_eq v0.1.5 [INFO] [stderr] Checking simdutf8 v0.1.5 [INFO] [stderr] Compiling anyhow v1.0.91 [INFO] [stderr] Checking clap_lex v0.7.2 [INFO] [stderr] Checking futures-timer v3.0.3 [INFO] [stderr] Checking pulldown-cmark-escape v0.11.0 [INFO] [stderr] Checking yansi v1.0.1 [INFO] [stderr] Checking pretty_assertions v1.4.1 [INFO] [stderr] Checking clap_builder v4.5.20 [INFO] [stderr] Checking tracing v0.1.44 [INFO] [stderr] Checking image v0.25.6 [INFO] [stderr] Checking rstest v0.26.1 [INFO] [stderr] Checking wl-clipboard-rs v0.9.1 [INFO] [stderr] Checking syntect v5.3.0 [INFO] [stderr] Checking ratatui-macros v0.7.0 [INFO] [stderr] Compiling clap_derive v4.5.18 [INFO] [stderr] Checking itertools v0.12.1 [INFO] [stderr] Checking backtrace v0.3.74 [INFO] [stderr] Checking ansi-to-tui v8.0.1 [INFO] [stderr] Checking zstd v0.11.2+zstd.1.5.2 [INFO] [stderr] Checking roxmltree v0.19.0 [INFO] [stderr] Checking sdd v3.0.10 [INFO] [stderr] Checking x11rb v0.13.1 [INFO] [stderr] Checking zip v0.6.6 [INFO] [stderr] Checking tui-markdown v0.3.7 [INFO] [stderr] Checking scc v2.4.0 [INFO] [stderr] Checking ironcalc_base v0.7.1 [INFO] [stderr] Checking tui-prompts v0.6.1 [INFO] [stderr] Checking futures v0.3.31 [INFO] [stderr] Checking ratatui v0.30.0 [INFO] [stderr] Checking ratatui-textarea v0.8.0 [INFO] [stderr] Compiling serial_test_derive v3.4.0 [INFO] [stderr] Checking colorsys v0.6.7 [INFO] [stderr] Checking htmf v0.2.0 [INFO] [stderr] Checking slice-utils v0.1.0 (https://dev.zaphar.net/zaphar/slice-cursor-rs.git#699df1c4) [INFO] [stderr] Checking arboard v3.5.0 [INFO] [stderr] Checking clap v4.5.20 [INFO] [stderr] Checking serial_test v3.4.0 [INFO] [stderr] Checking ironcalc v0.7.1 [INFO] [stderr] Checking sheetui v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use ratatui; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | const SHORT: &'static str = "w"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | const LONG: &'static str = "write"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | const LONG: &'static str = "export-csv"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:141:18 [INFO] [stdout] | [INFO] [stdout] 141 | const LONG: &'static str = "new-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 162 | const LONG: &'static str = "select-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:182:19 [INFO] [stdout] | [INFO] [stdout] 182 | const SHORT: &'static str = "cc"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 183 | const LONG: &'static str = "color-cell"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:201:19 [INFO] [stdout] | [INFO] [stdout] 201 | const SHORT: &'static str = "ir"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | const LONG: &'static str = "insert-rows"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:229:19 [INFO] [stdout] | [INFO] [stdout] 229 | const SHORT: &'static str = "ic"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:230:18 [INFO] [stdout] | [INFO] [stdout] 230 | const LONG: &'static str = "insert-cols"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | const SHORT: &'static str = "e"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:258:18 [INFO] [stdout] | [INFO] [stdout] 258 | const LONG: &'static str = "edit"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 281 | const SHORT: &'static str = "?"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | const LONG: &'static str = "help"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:306:19 [INFO] [stdout] | [INFO] [stdout] 306 | const SHORT: &'static str = "q"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:307:18 [INFO] [stdout] | [INFO] [stdout] 307 | const LONG: &'static str = "quit"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:326:18 [INFO] [stdout] | [INFO] [stdout] 326 | const LONG: &'static str = "system-paste"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:342:18 [INFO] [stdout] | [INFO] [stdout] 342 | const LONG: &'static str = "rename-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:362:18 [INFO] [stdout] | [INFO] [stdout] 362 | const LONG: &'static str = "color-rows"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:379:18 [INFO] [stdout] | [INFO] [stdout] 379 | const LONG: &'static str = "color-columns"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/render/viewport.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) const COLNAMES: [&'static str; 26] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:5:1 [INFO] [stdout] | [INFO] [stdout] 5 | use ratatui; [INFO] [stdout] | ^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:99:19 [INFO] [stdout] | [INFO] [stdout] 99 | const SHORT: &'static str = "w"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] = note: `#[warn(clippy::redundant_static_lifetimes)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:100:18 [INFO] [stdout] | [INFO] [stdout] 100 | const LONG: &'static str = "write"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:124:18 [INFO] [stdout] | [INFO] [stdout] 124 | const LONG: &'static str = "export-csv"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:141:18 [INFO] [stdout] | [INFO] [stdout] 141 | const LONG: &'static str = "new-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:162:18 [INFO] [stdout] | [INFO] [stdout] 162 | const LONG: &'static str = "select-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:182:19 [INFO] [stdout] | [INFO] [stdout] 182 | const SHORT: &'static str = "cc"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:183:18 [INFO] [stdout] | [INFO] [stdout] 183 | const LONG: &'static str = "color-cell"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:201:19 [INFO] [stdout] | [INFO] [stdout] 201 | const SHORT: &'static str = "ir"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:202:18 [INFO] [stdout] | [INFO] [stdout] 202 | const LONG: &'static str = "insert-rows"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:229:19 [INFO] [stdout] | [INFO] [stdout] 229 | const SHORT: &'static str = "ic"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:230:18 [INFO] [stdout] | [INFO] [stdout] 230 | const LONG: &'static str = "insert-cols"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:257:19 [INFO] [stdout] | [INFO] [stdout] 257 | const SHORT: &'static str = "e"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:258:18 [INFO] [stdout] | [INFO] [stdout] 258 | const LONG: &'static str = "edit"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:281:19 [INFO] [stdout] | [INFO] [stdout] 281 | const SHORT: &'static str = "?"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:282:18 [INFO] [stdout] | [INFO] [stdout] 282 | const LONG: &'static str = "help"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:306:19 [INFO] [stdout] | [INFO] [stdout] 306 | const SHORT: &'static str = "q"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:307:18 [INFO] [stdout] | [INFO] [stdout] 307 | const LONG: &'static str = "quit"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:326:18 [INFO] [stdout] | [INFO] [stdout] 326 | const LONG: &'static str = "system-paste"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:342:18 [INFO] [stdout] | [INFO] [stdout] 342 | const LONG: &'static str = "rename-sheet"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:362:18 [INFO] [stdout] | [INFO] [stdout] 362 | const LONG: &'static str = "color-rows"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/cmd.rs:379:18 [INFO] [stdout] | [INFO] [stdout] 379 | const LONG: &'static str = "color-columns"; [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: constants have by default a `'static` lifetime [INFO] [stdout] --> src/ui/render/viewport.rs:39:30 [INFO] [stdout] | [INFO] [stdout] 39 | pub(crate) const COLNAMES: [&'static str; 26] = [ [INFO] [stdout] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_static_lifetimes [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/book/sui.rs:593:36 [INFO] [stdout] | [INFO] [stdout] 593 | fn parse_style_decl(line: &str) -> Option<(usize, usize, Vec<(String, String)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | / (self.start.row..=self.end.row) [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.row..=self.end.row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let mut v = (self.start.row..=self.end.row) [INFO] [stdout] | _________________________^ [INFO] [stdout] 85 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.row..=self.end.row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | / (self.start.col..=self.end.col) [INFO] [stdout] 92 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.col..=self.end.col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | let mut v = (self.start.col..=self.end.col) [INFO] [stdout] | _________________________^ [INFO] [stdout] 96 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.col..=self.end.col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | Ok(self.get_export_rows_for_sheet(sheet)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 268 - Ok(self.get_export_rows_for_sheet(sheet)?) [INFO] [stdout] 268 + self.get_export_rows_for_sheet(sheet) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | / Ok(self [INFO] [stdout] 453 | | .model [INFO] [stdout] 454 | | .range_clear_contents(&Area { [INFO] [stdout] 455 | | sheet, [INFO] [stdout] ... | [INFO] [stdout] 460 | | }) [INFO] [stdout] 461 | | .map_err(|s| anyhow!("Unable to clear cell contents {}", s))?) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 452 ~ self [INFO] [stdout] 453 | .model [INFO] [stdout] ... [INFO] [stdout] 460 | }) [INFO] [stdout] 461 ~ .map_err(|s| anyhow!("Unable to clear cell contents {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 475 | / Ok(self [INFO] [stdout] 476 | | .model [INFO] [stdout] 477 | | .range_clear_all(&Area { [INFO] [stdout] 478 | | sheet, [INFO] [stdout] ... | [INFO] [stdout] 483 | | }) [INFO] [stdout] 484 | | .map_err(|s| anyhow!("Unable to clear cell contents {}", s))?) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 475 ~ self [INFO] [stdout] 476 | .model [INFO] [stdout] ... [INFO] [stdout] 483 | }) [INFO] [stdout] 484 ~ .map_err(|s| anyhow!("Unable to clear cell contents {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:498:9 [INFO] [stdout] | [INFO] [stdout] 498 | Ok(self.get_cell_addr_rendered(&self.location)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 498 - Ok(self.get_cell_addr_rendered(&self.location)?) [INFO] [stdout] 498 + self.get_cell_addr_rendered(&self.location) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/book/mod.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | / match self [INFO] [stdout] 506 | | .model [INFO] [stdout] 507 | | .get_cell_style(cell.sheet, cell.row as i32, cell.col as i32) [INFO] [stdout] ... | [INFO] [stdout] 510 | | Ok(s) => Some(s), [INFO] [stdout] 511 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] help: replace with [INFO] [stdout] | [INFO] [stdout] 505 ~ self [INFO] [stdout] 506 + .model [INFO] [stdout] 507 + .get_cell_style(cell.sheet, cell.row as i32, cell.col as i32).ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:609:9 [INFO] [stdout] | [INFO] [stdout] 609 | / Ok(self [INFO] [stdout] 610 | | .model [INFO] [stdout] 611 | | .get_formatted_cell_value(*sheet, *row as i32, *col as i32) [INFO] [stdout] 612 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 609 ~ self [INFO] [stdout] 610 | .model [INFO] [stdout] 611 | .get_formatted_cell_value(*sheet, *row as i32, *col as i32) [INFO] [stdout] 612 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:617:9 [INFO] [stdout] | [INFO] [stdout] 617 | / Ok(self [INFO] [stdout] 618 | | .model [INFO] [stdout] 619 | | .get_cell_content(*sheet, *row as i32, *col as i32) [INFO] [stdout] 620 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 617 ~ self [INFO] [stdout] 618 | .model [INFO] [stdout] 619 | .get_cell_content(*sheet, *row as i32, *col as i32) [INFO] [stdout] 620 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:625:9 [INFO] [stdout] | [INFO] [stdout] 625 | / Ok(self [INFO] [stdout] 626 | | .model [INFO] [stdout] 627 | | .get_cell_content( [INFO] [stdout] 628 | | self.location.sheet, [INFO] [stdout] ... | [INFO] [stdout] 632 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 625 ~ self [INFO] [stdout] 626 | .model [INFO] [stdout] ... [INFO] [stdout] 631 | ) [INFO] [stdout] 632 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/book/mod.rs:737:29 [INFO] [stdout] | [INFO] [stdout] 737 | let mut row_count = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/book/mod.rs:738:29 [INFO] [stdout] | [INFO] [stdout] 738 | let mut col_count = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:820:9 [INFO] [stdout] | [INFO] [stdout] 820 | / Ok(self [INFO] [stdout] 821 | | .model [INFO] [stdout] 822 | | .get_model() [INFO] [stdout] 823 | | .workbook [INFO] [stdout] ... | [INFO] [stdout] 831 | | })?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 820 ~ self [INFO] [stdout] 821 | .model [INFO] [stdout] ... [INFO] [stdout] 830 | ) [INFO] [stdout] 831 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/book/mod.rs:875:5 [INFO] [stdout] | [INFO] [stdout] 868 | / let area = Area { [INFO] [stdout] 869 | | sheet, [INFO] [stdout] 870 | | row: start.row as i32, [INFO] [stdout] 871 | | column: start.col as i32, [INFO] [stdout] 872 | | height: (end.row - start.row + 1) as i32, [INFO] [stdout] 873 | | width: (end.col - start.col + 1) as i32, [INFO] [stdout] 874 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 875 | area [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 868 ~ [INFO] [stdout] 869 ~ Area { [INFO] [stdout] 870 + sheet, [INFO] [stdout] 871 + row: start.row as i32, [INFO] [stdout] 872 + column: start.col as i32, [INFO] [stdout] 873 + height: (end.row - start.row + 1) as i32, [INFO] [stdout] 874 + width: (end.col - start.col + 1) as i32, [INFO] [stdout] 875 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/cmd.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] 86 | | input.next(); [INFO] [stdout] 87 | | true [INFO] [stdout] 88 | | } else { [INFO] [stdout] 89 | | false [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ Some(b) [INFO] [stdout] 85 ~ if (*b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8)) => { [INFO] [stdout] 86 | input.next(); [INFO] [stdout] 87 | true [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:43 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:65 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:87 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / return Ok(Some(Cmd::Write(if arg.is_empty() { [INFO] [stdout] 115 | | None [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | Some(arg) [INFO] [stdout] 118 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 ~ Ok(Some(Cmd::Write(if arg.is_empty() { [INFO] [stdout] 115 + None [INFO] [stdout] 116 + } else { [INFO] [stdout] 117 + Some(arg) [INFO] [stdout] 118 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return Ok(Some(Cmd::ExportCsv(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Ok(Some(Cmd::ExportCsv(arg))); [INFO] [stdout] 135 + Ok(Some(Cmd::ExportCsv(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | / return Ok(Some(Cmd::NewSheet(if arg.is_empty() { [INFO] [stdout] 153 | | None [INFO] [stdout] 154 | | } else { [INFO] [stdout] 155 | | Some(arg) [INFO] [stdout] 156 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ Ok(Some(Cmd::NewSheet(if arg.is_empty() { [INFO] [stdout] 153 + None [INFO] [stdout] 154 + } else { [INFO] [stdout] 155 + Some(arg) [INFO] [stdout] 156 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(Some(Cmd::SelectSheet(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(Some(Cmd::SelectSheet(arg))); [INFO] [stdout] 176 + Ok(Some(Cmd::SelectSheet(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | return Ok(Some(Cmd::ColorCell(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return Ok(Some(Cmd::ColorCell(arg))); [INFO] [stdout] 195 + Ok(Some(Cmd::ColorCell(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / return Ok(Some(Cmd::InsertRows(if arg.is_empty() { [INFO] [stdout] 216 | | 1 [INFO] [stdout] 217 | | } else { [INFO] [stdout] 218 | | if let Ok(count) = arg.parse() { [INFO] [stdout] ... | [INFO] [stdout] 223 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 ~ Ok(Some(Cmd::InsertRows(if arg.is_empty() { [INFO] [stdout] 216 + 1 [INFO] [stdout] 217 + } else { [INFO] [stdout] 218 + if let Ok(count) = arg.parse() { [INFO] [stdout] 219 + count [INFO] [stdout] 220 + } else { [INFO] [stdout] 221 + return Err("You must pass in a non negative number for the row count"); [INFO] [stdout] 222 + } [INFO] [stdout] 223 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | / return Ok(Some(Cmd::InsertColumns(if arg.is_empty() { [INFO] [stdout] 244 | | 1 [INFO] [stdout] 245 | | } else { [INFO] [stdout] 246 | | if let Ok(count) = arg.parse() { [INFO] [stdout] ... | [INFO] [stdout] 251 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 ~ Ok(Some(Cmd::InsertColumns(if arg.is_empty() { [INFO] [stdout] 244 + 1 [INFO] [stdout] 245 + } else { [INFO] [stdout] 246 + if let Ok(count) = arg.parse() { [INFO] [stdout] 247 + count [INFO] [stdout] 248 + } else { [INFO] [stdout] 249 + return Err("You must pass in a non negative number for the column count"); [INFO] [stdout] 250 + } [INFO] [stdout] 251 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / return Ok(Some(Cmd::Edit(if arg.is_empty() { [INFO] [stdout] 272 | | return Err("You must pass in a path to edit"); [INFO] [stdout] 273 | | } else { [INFO] [stdout] 274 | | arg [INFO] [stdout] 275 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 ~ Ok(Some(Cmd::Edit(if arg.is_empty() { [INFO] [stdout] 272 + return Err("You must pass in a path to edit"); [INFO] [stdout] 273 + } else { [INFO] [stdout] 274 + arg [INFO] [stdout] 275 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / return Ok(Some(Cmd::Help(if arg.is_empty() { [INFO] [stdout] 297 | | None [INFO] [stdout] 298 | | } else { [INFO] [stdout] 299 | | Some(arg) [INFO] [stdout] 300 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 ~ Ok(Some(Cmd::Help(if arg.is_empty() { [INFO] [stdout] 297 + None [INFO] [stdout] 298 + } else { [INFO] [stdout] 299 + Some(arg) [INFO] [stdout] 300 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:320:5 [INFO] [stdout] | [INFO] [stdout] 320 | return Ok(Some(Cmd::Quit)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return Ok(Some(Cmd::Quit)); [INFO] [stdout] 320 + Ok(Some(Cmd::Quit)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 336 | return Ok(Some(Cmd::SystemPaste)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - return Ok(Some(Cmd::SystemPaste)); [INFO] [stdout] 336 + Ok(Some(Cmd::SystemPaste)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 356 | return Ok(Some(Cmd::RenameSheet(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return Ok(Some(Cmd::RenameSheet(idx, arg))); [INFO] [stdout] 356 + Ok(Some(Cmd::RenameSheet(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:373:5 [INFO] [stdout] | [INFO] [stdout] 373 | return Ok(Some(Cmd::ColorRows(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return Ok(Some(Cmd::ColorRows(idx, arg))); [INFO] [stdout] 373 + Ok(Some(Cmd::ColorRows(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | return Ok(Some(Cmd::ColorColumns(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return Ok(Some(Cmd::ColorColumns(idx, arg))); [INFO] [stdout] 390 + Ok(Some(Cmd::ColorColumns(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ui/cmd.rs:444:8 [INFO] [stdout] | [INFO] [stdout] 444 | if out.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!out.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/viewport.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | Constraint::Length(value.length as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `value.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/render/viewport.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return (start..=end).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return (start..=end).collect(); [INFO] [stdout] 78 + (start..=end).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | start = start + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/render/viewport.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return Ok(visible); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Ok(visible); [INFO] [stdout] 122 + Ok(visible) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | length = length - first.length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length -= first.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | length = length - first.length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length -= first.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ui/render/viewport.rs:167:18 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|vc| Constraint::from(vc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Constraint::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/ui/render/viewport.rs:185:32 [INFO] [stdout] | [INFO] [stdout] 185 | col_constraints.extend(constraints.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 185 - col_constraints.extend(constraints.into_iter()); [INFO] [stdout] 185 + col_constraints.extend(constraints); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/ui/render/viewport.rs:220:38 [INFO] [stdout] | [INFO] [stdout] 220 | if let Some((start, end)) = &self.range_selection.map_or(None, |r| r.get_range()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `self.range_selection.and_then(|r| r.get_range())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/dialog.rs:47:33 [INFO] [stdout] | [INFO] [stdout] 47 | .saturating_sub(content_height as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `content_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/dialog.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | .saturating_sub(content_width as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `content_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u16, u16)` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/dialog.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | .scroll(self.scroll.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/render/markdown.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | / ... if !current_line.spans.is_empty() { [INFO] [stdout] 88 | | ... lines.push(current_line); [INFO] [stdout] 89 | | ... current_line = Line::default(); [INFO] [stdout] 90 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ Tag::Paragraph [INFO] [stdout] 87 ~ if !current_line.spans.is_empty() => { [INFO] [stdout] 88 | lines.push(current_line); [INFO] [stdout] 89 | current_line = Line::default(); [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/render/markdown.rs:195:29 [INFO] [stdout] | [INFO] [stdout] 195 | / ... if !current_line.spans.is_empty() { [INFO] [stdout] 196 | | ... lines.push(current_line); [INFO] [stdout] 197 | | ... current_line = Line::default(); [INFO] [stdout] 198 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 193 ~ TagEnd::Item [INFO] [stdout] 194 | // Push the current line to preserve the list item [INFO] [stdout] 195 ~ if !current_line.spans.is_empty() => { [INFO] [stdout] 196 | lines.push(current_line); [INFO] [stdout] 197 | current_line = Line::default(); [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ui/render/mod.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | ) -> Vec<(Rect, Box)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ui/render/mod.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let mut rs: Vec> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/mod.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | .split(area.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/ui/render/mod.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | .zip(rs.into_iter()) [INFO] [stdout] | _________________________________^ [INFO] [stdout] 92 | | .map(|(rect, f)| (rect, f)) [INFO] [stdout] | |_______________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/ui/render/mod.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | .zip(rs.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 91 - .zip(rs.into_iter()) [INFO] [stdout] 91 + .zip(rs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/mod.rs:140:52 [INFO] [stdout] | [INFO] [stdout] 140 | for (rect, f) in self.get_render_parts(area.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Iterator::fold` on a type that implements `Try` [INFO] [stdout] --> src/ui/mod.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 125 | .fold(Some(0 as usize), |acc, n| { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | acc?.checked_mul(10)?.checked_add(n as usize) [INFO] [stdout] 127 | | }) [INFO] [stdout] | |______________^ help: use `try_fold` instead: `try_fold(0 as usize, |acc, n| ...)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold [INFO] [stdout] = note: `#[warn(clippy::manual_try_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/ui/mod.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 125 | .fold(Some(0 as usize), |acc, n| { [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/ui/mod.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | book.dirty = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `book::Book { dirty: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/ui/mod.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | let mut book = Book::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return String::new(); [INFO] [stdout] 259 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/ui/mod.rs:241:22 [INFO] [stdout] | [INFO] [stdout] 241 | let a1 = format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 242 | | "{}{}", [INFO] [stdout] 243 | | start.to_range_part(), [INFO] [stdout] 244 | | format!(":{}", end.to_range_part()) [INFO] [stdout] 245 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/mod.rs:621:21 [INFO] [stdout] | [INFO] [stdout] 621 | / if self.update_range_selection()? { [INFO] [stdout] 622 | | self.exit_range_select_mode()?; [INFO] [stdout] 623 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ KeyCode::Char(' ') | KeyCode::Enter [INFO] [stdout] 621 ~ if self.update_range_selection()? => { [INFO] [stdout] 622 | self.exit_range_select_mode()?; [INFO] [stdout] 623 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ui/mod.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 567 | if self.state.numeric_prefix.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.state.numeric_prefix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:940:9 [INFO] [stdout] | [INFO] [stdout] 940 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 940 - return Ok(None); [INFO] [stdout] 940 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ri` is used to index `rows` [INFO] [stdout] --> src/ui/mod.rs:980:27 [INFO] [stdout] | [INFO] [stdout] 980 | for ri in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 980 - for ri in 0..row_len { [INFO] [stdout] 980 + for (ri, ) in rows.iter().enumerate().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ci` is used to index `columns` [INFO] [stdout] --> src/ui/mod.rs:983:31 [INFO] [stdout] | [INFO] [stdout] 983 | for ci in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 983 - for ci in 0..col_len { [INFO] [stdout] 983 + for (ci, ) in columns.iter().enumerate().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ri` is used to index `rows` [INFO] [stdout] --> src/ui/mod.rs:999:27 [INFO] [stdout] | [INFO] [stdout] 999 | for ri in 0..rows.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 999 - for ri in 0..rows.len() { [INFO] [stdout] 999 + for (ri, ) in rows.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ci` is used to index `columns` [INFO] [stdout] --> src/ui/mod.rs:1001:31 [INFO] [stdout] | [INFO] [stdout] 1001 | for ci in 0..columns.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1001 - for ci in 0..columns.len() { [INFO] [stdout] 1001 + for (ci, ) in columns.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:1035:9 [INFO] [stdout] | [INFO] [stdout] 1035 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1035 - return false; [INFO] [stdout] 1035 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:1151:9 [INFO] [stdout] | [INFO] [stdout] 1151 | return Ok(Some(ExitCode::SUCCESS)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1151 - return Ok(Some(ExitCode::SUCCESS)); [INFO] [stdout] 1151 + Ok(Some(ExitCode::SUCCESS)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/ui/mod.rs:1155:20 [INFO] [stdout] | [INFO] [stdout] 1155 | fn load_book(path: &PathBuf, locale: &str, tz: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1155 - fn load_book(path: &PathBuf, locale: &str, tz: &str) -> Result { [INFO] [stdout] 1155 + fn load_book(path: &Path, locale: &str, tz: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | writeln!(&log_file, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/book/sui.rs:593:36 [INFO] [stdout] | [INFO] [stdout] 593 | fn parse_style_decl(line: &str) -> Option<(usize, usize, Vec<(String, String)>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to one [INFO] [stdout] --> src/book/sui.rs:685:17 [INFO] [stdout] | [INFO] [stdout] 685 | assert!(names.len() >= 1, "book should have at least one sheet"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!names.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] = note: `#[warn(clippy::len_zero)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:80:13 [INFO] [stdout] | [INFO] [stdout] 80 | / (self.start.row..=self.end.row) [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.row..=self.end.row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:84:25 [INFO] [stdout] | [INFO] [stdout] 84 | let mut v = (self.start.row..=self.end.row) [INFO] [stdout] | _________________________^ [INFO] [stdout] 85 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.row..=self.end.row)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:91:13 [INFO] [stdout] | [INFO] [stdout] 91 | / (self.start.col..=self.end.col) [INFO] [stdout] 92 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.col..=self.end.col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeInclusive` [INFO] [stdout] --> src/book/mod.rs:95:25 [INFO] [stdout] | [INFO] [stdout] 95 | let mut v = (self.start.col..=self.end.col) [INFO] [stdout] | _________________________^ [INFO] [stdout] 96 | | .into_iter() [INFO] [stdout] | |____________________________^ help: consider removing `.into_iter()`: `(self.start.col..=self.end.col)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:268:9 [INFO] [stdout] | [INFO] [stdout] 268 | Ok(self.get_export_rows_for_sheet(sheet)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] = note: `#[warn(clippy::needless_question_mark)]` on by default [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 268 - Ok(self.get_export_rows_for_sheet(sheet)?) [INFO] [stdout] 268 + self.get_export_rows_for_sheet(sheet) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:452:9 [INFO] [stdout] | [INFO] [stdout] 452 | / Ok(self [INFO] [stdout] 453 | | .model [INFO] [stdout] 454 | | .range_clear_contents(&Area { [INFO] [stdout] 455 | | sheet, [INFO] [stdout] ... | [INFO] [stdout] 460 | | }) [INFO] [stdout] 461 | | .map_err(|s| anyhow!("Unable to clear cell contents {}", s))?) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 452 ~ self [INFO] [stdout] 453 | .model [INFO] [stdout] ... [INFO] [stdout] 460 | }) [INFO] [stdout] 461 ~ .map_err(|s| anyhow!("Unable to clear cell contents {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:475:9 [INFO] [stdout] | [INFO] [stdout] 475 | / Ok(self [INFO] [stdout] 476 | | .model [INFO] [stdout] 477 | | .range_clear_all(&Area { [INFO] [stdout] 478 | | sheet, [INFO] [stdout] ... | [INFO] [stdout] 483 | | }) [INFO] [stdout] 484 | | .map_err(|s| anyhow!("Unable to clear cell contents {}", s))?) [INFO] [stdout] | |__________________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 475 ~ self [INFO] [stdout] 476 | .model [INFO] [stdout] ... [INFO] [stdout] 483 | }) [INFO] [stdout] 484 ~ .map_err(|s| anyhow!("Unable to clear cell contents {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:498:9 [INFO] [stdout] | [INFO] [stdout] 498 | Ok(self.get_cell_addr_rendered(&self.location)?) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 498 - Ok(self.get_cell_addr_rendered(&self.location)?) [INFO] [stdout] 498 + self.get_cell_addr_rendered(&self.location) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of `ok` [INFO] [stdout] --> src/book/mod.rs:505:9 [INFO] [stdout] | [INFO] [stdout] 505 | / match self [INFO] [stdout] 506 | | .model [INFO] [stdout] 507 | | .get_cell_style(cell.sheet, cell.row as i32, cell.col as i32) [INFO] [stdout] ... | [INFO] [stdout] 510 | | Ok(s) => Some(s), [INFO] [stdout] 511 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_ok_err [INFO] [stdout] = note: `#[warn(clippy::manual_ok_err)]` on by default [INFO] [stdout] help: replace with [INFO] [stdout] | [INFO] [stdout] 505 ~ self [INFO] [stdout] 506 + .model [INFO] [stdout] 507 + .get_cell_style(cell.sheet, cell.row as i32, cell.col as i32).ok() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:609:9 [INFO] [stdout] | [INFO] [stdout] 609 | / Ok(self [INFO] [stdout] 610 | | .model [INFO] [stdout] 611 | | .get_formatted_cell_value(*sheet, *row as i32, *col as i32) [INFO] [stdout] 612 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 609 ~ self [INFO] [stdout] 610 | .model [INFO] [stdout] 611 | .get_formatted_cell_value(*sheet, *row as i32, *col as i32) [INFO] [stdout] 612 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:617:9 [INFO] [stdout] | [INFO] [stdout] 617 | / Ok(self [INFO] [stdout] 618 | | .model [INFO] [stdout] 619 | | .get_cell_content(*sheet, *row as i32, *col as i32) [INFO] [stdout] 620 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 617 ~ self [INFO] [stdout] 618 | .model [INFO] [stdout] 619 | .get_cell_content(*sheet, *row as i32, *col as i32) [INFO] [stdout] 620 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:625:9 [INFO] [stdout] | [INFO] [stdout] 625 | / Ok(self [INFO] [stdout] 626 | | .model [INFO] [stdout] 627 | | .get_cell_content( [INFO] [stdout] 628 | | self.location.sheet, [INFO] [stdout] ... | [INFO] [stdout] 632 | | .map_err(|s| anyhow!("Unable to format cell {}", s))?) [INFO] [stdout] | |__________________________________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 625 ~ self [INFO] [stdout] 626 | .model [INFO] [stdout] ... [INFO] [stdout] 631 | ) [INFO] [stdout] 632 ~ .map_err(|s| anyhow!("Unable to format cell {}", s)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/book/mod.rs:737:29 [INFO] [stdout] | [INFO] [stdout] 737 | let mut row_count = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] = note: `#[warn(clippy::unnecessary_cast)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `i32` is unnecessary [INFO] [stdout] --> src/book/mod.rs:738:29 [INFO] [stdout] | [INFO] [stdout] 738 | let mut col_count = 0 as i32; [INFO] [stdout] | ^^^^^^^^ help: try: `0_i32` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: enclosing `Ok` and `?` operator are unneeded [INFO] [stdout] --> src/book/mod.rs:820:9 [INFO] [stdout] | [INFO] [stdout] 820 | / Ok(self [INFO] [stdout] 821 | | .model [INFO] [stdout] 822 | | .get_model() [INFO] [stdout] 823 | | .workbook [INFO] [stdout] ... | [INFO] [stdout] 831 | | })?) [INFO] [stdout] | |________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_question_mark [INFO] [stdout] help: remove the enclosing `Ok` and `?` operator [INFO] [stdout] | [INFO] [stdout] 820 ~ self [INFO] [stdout] 821 | .model [INFO] [stdout] ... [INFO] [stdout] 830 | ) [INFO] [stdout] 831 ~ }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/book/mod.rs:875:5 [INFO] [stdout] | [INFO] [stdout] 868 | / let area = Area { [INFO] [stdout] 869 | | sheet, [INFO] [stdout] 870 | | row: start.row as i32, [INFO] [stdout] 871 | | column: start.col as i32, [INFO] [stdout] 872 | | height: (end.row - start.row + 1) as i32, [INFO] [stdout] 873 | | width: (end.col - start.col + 1) as i32, [INFO] [stdout] 874 | | }; [INFO] [stdout] | |______- unnecessary `let` binding [INFO] [stdout] 875 | area [INFO] [stdout] | ^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 868 ~ [INFO] [stdout] 869 ~ Area { [INFO] [stdout] 870 + sheet, [INFO] [stdout] 871 + row: start.row as i32, [INFO] [stdout] 872 + column: start.col as i32, [INFO] [stdout] 873 + height: (end.row - start.row + 1) as i32, [INFO] [stdout] 874 + width: (end.col - start.col + 1) as i32, [INFO] [stdout] 875 + } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/cmd.rs:85:13 [INFO] [stdout] | [INFO] [stdout] 85 | / if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] 86 | | input.next(); [INFO] [stdout] 87 | | true [INFO] [stdout] 88 | | } else { [INFO] [stdout] 89 | | false [INFO] [stdout] 90 | | } [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] = note: `#[warn(clippy::collapsible_match)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 84 ~ Some(b) [INFO] [stdout] 85 ~ if (*b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8)) => { [INFO] [stdout] 86 | input.next(); [INFO] [stdout] 87 | true [INFO] [stdout] 88 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:22 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^ help: use a byte literal instead: `b' '` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] = note: `#[warn(clippy::char_lit_as_u8)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:43 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\t'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:65 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\n'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting a character literal to `u8` truncates [INFO] [stdout] --> src/ui/cmd.rs:85:87 [INFO] [stdout] | [INFO] [stdout] 85 | if *b == (' ' as u8) || *b == ('\t' as u8) || *b == ('\n' as u8) || *b == ('\r' as u8) { [INFO] [stdout] | ^^^^^^^^^^^^ help: use a byte literal instead: `b'\r'` [INFO] [stdout] | [INFO] [stdout] = note: `char` is four bytes wide, but `u8` is a single byte [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#char_lit_as_u8 [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:114:5 [INFO] [stdout] | [INFO] [stdout] 114 | / return Ok(Some(Cmd::Write(if arg.is_empty() { [INFO] [stdout] 115 | | None [INFO] [stdout] 116 | | } else { [INFO] [stdout] 117 | | Some(arg) [INFO] [stdout] 118 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 ~ Ok(Some(Cmd::Write(if arg.is_empty() { [INFO] [stdout] 115 + None [INFO] [stdout] 116 + } else { [INFO] [stdout] 117 + Some(arg) [INFO] [stdout] 118 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:135:5 [INFO] [stdout] | [INFO] [stdout] 135 | return Ok(Some(Cmd::ExportCsv(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 135 - return Ok(Some(Cmd::ExportCsv(arg))); [INFO] [stdout] 135 + Ok(Some(Cmd::ExportCsv(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:152:5 [INFO] [stdout] | [INFO] [stdout] 152 | / return Ok(Some(Cmd::NewSheet(if arg.is_empty() { [INFO] [stdout] 153 | | None [INFO] [stdout] 154 | | } else { [INFO] [stdout] 155 | | Some(arg) [INFO] [stdout] 156 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 152 ~ Ok(Some(Cmd::NewSheet(if arg.is_empty() { [INFO] [stdout] 153 + None [INFO] [stdout] 154 + } else { [INFO] [stdout] 155 + Some(arg) [INFO] [stdout] 156 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:176:5 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(Some(Cmd::SelectSheet(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(Some(Cmd::SelectSheet(arg))); [INFO] [stdout] 176 + Ok(Some(Cmd::SelectSheet(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:195:5 [INFO] [stdout] | [INFO] [stdout] 195 | return Ok(Some(Cmd::ColorCell(arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 195 - return Ok(Some(Cmd::ColorCell(arg))); [INFO] [stdout] 195 + Ok(Some(Cmd::ColorCell(arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:215:5 [INFO] [stdout] | [INFO] [stdout] 215 | / return Ok(Some(Cmd::InsertRows(if arg.is_empty() { [INFO] [stdout] 216 | | 1 [INFO] [stdout] 217 | | } else { [INFO] [stdout] 218 | | if let Ok(count) = arg.parse() { [INFO] [stdout] ... | [INFO] [stdout] 223 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 215 ~ Ok(Some(Cmd::InsertRows(if arg.is_empty() { [INFO] [stdout] 216 + 1 [INFO] [stdout] 217 + } else { [INFO] [stdout] 218 + if let Ok(count) = arg.parse() { [INFO] [stdout] 219 + count [INFO] [stdout] 220 + } else { [INFO] [stdout] 221 + return Err("You must pass in a non negative number for the row count"); [INFO] [stdout] 222 + } [INFO] [stdout] 223 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:243:5 [INFO] [stdout] | [INFO] [stdout] 243 | / return Ok(Some(Cmd::InsertColumns(if arg.is_empty() { [INFO] [stdout] 244 | | 1 [INFO] [stdout] 245 | | } else { [INFO] [stdout] 246 | | if let Ok(count) = arg.parse() { [INFO] [stdout] ... | [INFO] [stdout] 251 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 243 ~ Ok(Some(Cmd::InsertColumns(if arg.is_empty() { [INFO] [stdout] 244 + 1 [INFO] [stdout] 245 + } else { [INFO] [stdout] 246 + if let Ok(count) = arg.parse() { [INFO] [stdout] 247 + count [INFO] [stdout] 248 + } else { [INFO] [stdout] 249 + return Err("You must pass in a non negative number for the column count"); [INFO] [stdout] 250 + } [INFO] [stdout] 251 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:271:5 [INFO] [stdout] | [INFO] [stdout] 271 | / return Ok(Some(Cmd::Edit(if arg.is_empty() { [INFO] [stdout] 272 | | return Err("You must pass in a path to edit"); [INFO] [stdout] 273 | | } else { [INFO] [stdout] 274 | | arg [INFO] [stdout] 275 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 271 ~ Ok(Some(Cmd::Edit(if arg.is_empty() { [INFO] [stdout] 272 + return Err("You must pass in a path to edit"); [INFO] [stdout] 273 + } else { [INFO] [stdout] 274 + arg [INFO] [stdout] 275 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:296:5 [INFO] [stdout] | [INFO] [stdout] 296 | / return Ok(Some(Cmd::Help(if arg.is_empty() { [INFO] [stdout] 297 | | None [INFO] [stdout] 298 | | } else { [INFO] [stdout] 299 | | Some(arg) [INFO] [stdout] 300 | | }))); [INFO] [stdout] | |________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 296 ~ Ok(Some(Cmd::Help(if arg.is_empty() { [INFO] [stdout] 297 + None [INFO] [stdout] 298 + } else { [INFO] [stdout] 299 + Some(arg) [INFO] [stdout] 300 ~ }))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:320:5 [INFO] [stdout] | [INFO] [stdout] 320 | return Ok(Some(Cmd::Quit)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 320 - return Ok(Some(Cmd::Quit)); [INFO] [stdout] 320 + Ok(Some(Cmd::Quit)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:336:5 [INFO] [stdout] | [INFO] [stdout] 336 | return Ok(Some(Cmd::SystemPaste)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 336 - return Ok(Some(Cmd::SystemPaste)); [INFO] [stdout] 336 + Ok(Some(Cmd::SystemPaste)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:356:5 [INFO] [stdout] | [INFO] [stdout] 356 | return Ok(Some(Cmd::RenameSheet(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 356 - return Ok(Some(Cmd::RenameSheet(idx, arg))); [INFO] [stdout] 356 + Ok(Some(Cmd::RenameSheet(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:373:5 [INFO] [stdout] | [INFO] [stdout] 373 | return Ok(Some(Cmd::ColorRows(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 373 - return Ok(Some(Cmd::ColorRows(idx, arg))); [INFO] [stdout] 373 + Ok(Some(Cmd::ColorRows(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/cmd.rs:390:5 [INFO] [stdout] | [INFO] [stdout] 390 | return Ok(Some(Cmd::ColorColumns(idx, arg))); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 - return Ok(Some(Cmd::ColorColumns(idx, arg))); [INFO] [stdout] 390 + Ok(Some(Cmd::ColorColumns(idx, arg))) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ui/cmd.rs:444:8 [INFO] [stdout] | [INFO] [stdout] 444 | if out.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!out.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/viewport.rs:22:28 [INFO] [stdout] | [INFO] [stdout] 22 | Constraint::Length(value.length as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `value.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/render/viewport.rs:78:9 [INFO] [stdout] | [INFO] [stdout] 78 | return (start..=end).collect(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 78 - return (start..=end).collect(); [INFO] [stdout] 78 + (start..=end).collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:72:17 [INFO] [stdout] | [INFO] [stdout] 72 | start = start + 1; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace it with: `start += 1` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] = note: `#[warn(clippy::assign_op_pattern)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/render/viewport.rs:122:9 [INFO] [stdout] | [INFO] [stdout] 122 | return Ok(visible); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 122 - return Ok(visible); [INFO] [stdout] 122 + Ok(visible) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:102:21 [INFO] [stdout] | [INFO] [stdout] 102 | length = length - first.length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length -= first.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manual implementation of an assign operation [INFO] [stdout] --> src/ui/render/viewport.rs:114:25 [INFO] [stdout] | [INFO] [stdout] 114 | length = length - first.length; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `length -= first.length` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/ui/render/viewport.rs:167:18 [INFO] [stdout] | [INFO] [stdout] 167 | .map(|vc| Constraint::from(vc)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `Constraint::from` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/ui/render/viewport.rs:185:32 [INFO] [stdout] | [INFO] [stdout] 185 | col_constraints.extend(constraints.into_iter()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/collect.rs:416:17 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 185 - col_constraints.extend(constraints.into_iter()); [INFO] [stdout] 185 + col_constraints.extend(constraints); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map_or(None, ..)` on an `Option` value [INFO] [stdout] --> src/ui/render/viewport.rs:220:38 [INFO] [stdout] | [INFO] [stdout] 220 | if let Some((start, end)) = &self.range_selection.map_or(None, |r| r.get_range()) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `and_then`: `self.range_selection.and_then(|r| r.get_range())` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#option_map_or_none [INFO] [stdout] = note: `#[warn(clippy::option_map_or_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/dialog.rs:47:33 [INFO] [stdout] | [INFO] [stdout] 47 | .saturating_sub(content_height as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `content_height` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting to the same type is unnecessary (`u16` -> `u16`) [INFO] [stdout] --> src/ui/render/dialog.rs:55:29 [INFO] [stdout] | [INFO] [stdout] 55 | .saturating_sub(content_width as u16) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `content_width` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `(u16, u16)` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/dialog.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | .scroll(self.scroll.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try removing the `clone` call: `self.scroll` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/render/markdown.rs:87:29 [INFO] [stdout] | [INFO] [stdout] 87 | / ... if !current_line.spans.is_empty() { [INFO] [stdout] 88 | | ... lines.push(current_line); [INFO] [stdout] 89 | | ... current_line = Line::default(); [INFO] [stdout] 90 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 86 ~ Tag::Paragraph [INFO] [stdout] 87 ~ if !current_line.spans.is_empty() => { [INFO] [stdout] 88 | lines.push(current_line); [INFO] [stdout] 89 | current_line = Line::default(); [INFO] [stdout] 90 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/render/markdown.rs:195:29 [INFO] [stdout] | [INFO] [stdout] 195 | / ... if !current_line.spans.is_empty() { [INFO] [stdout] 196 | | ... lines.push(current_line); [INFO] [stdout] 197 | | ... current_line = Line::default(); [INFO] [stdout] 198 | | ... } [INFO] [stdout] | |_______________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 193 ~ TagEnd::Item [INFO] [stdout] 194 | // Push the current line to preserve the list item [INFO] [stdout] 195 ~ if !current_line.spans.is_empty() => { [INFO] [stdout] 196 | lines.push(current_line); [INFO] [stdout] 197 | current_line = Line::default(); [INFO] [stdout] 198 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_visible_columns` doesn't need a mutable reference [INFO] [stdout] --> src/ui/render/test.rs:23:50 [INFO] [stdout] | [INFO] [stdout] 23 | .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] = note: `#[warn(clippy::unnecessary_mut_passed)]` on by default [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 23 - .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] 23 + .get_visible_columns((width + 5) as u16, &state) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_visible_rows` doesn't need a mutable reference [INFO] [stdout] --> src/ui/render/test.rs:42:57 [INFO] [stdout] | [INFO] [stdout] 42 | let rows = viewport.get_visible_rows(height as u16, &mut state); [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 42 - let rows = viewport.get_visible_rows(height as u16, &mut state); [INFO] [stdout] 42 + let rows = viewport.get_visible_rows(height as u16, &state); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_visible_columns` doesn't need a mutable reference [INFO] [stdout] --> src/ui/render/test.rs:67:54 [INFO] [stdout] | [INFO] [stdout] 67 | .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 67 - .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] 67 + .get_visible_columns((width + 5) as u16, &state) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the method `get_visible_columns` doesn't need a mutable reference [INFO] [stdout] --> src/ui/render/test.rs:83:54 [INFO] [stdout] | [INFO] [stdout] 83 | .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stdout] help: remove this `mut` [INFO] [stdout] | [INFO] [stdout] 83 - .get_visible_columns((width + 5) as u16, &mut state) [INFO] [stdout] 83 + .get_visible_columns((width + 5) as u16, &state) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ui/render/mod.rs:23:10 [INFO] [stdout] | [INFO] [stdout] 23 | ) -> Vec<(Rect, Box)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/ui/render/mod.rs:30:21 [INFO] [stdout] | [INFO] [stdout] 30 | let mut rs: Vec> = vec![ [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/mod.rs:86:24 [INFO] [stdout] | [INFO] [stdout] 86 | .split(area.clone()) [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary map of the identity function [INFO] [stdout] --> src/ui/render/mod.rs:91:33 [INFO] [stdout] | [INFO] [stdout] 91 | .zip(rs.into_iter()) [INFO] [stdout] | _________________________________^ [INFO] [stdout] 92 | | .map(|(rect, f)| (rect, f)) [INFO] [stdout] | |_______________________________________^ help: remove the call to `map` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_identity [INFO] [stdout] = note: `#[warn(clippy::map_identity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: explicit call to `.into_iter()` in function argument accepting `IntoIterator` [INFO] [stdout] --> src/ui/render/mod.rs:91:18 [INFO] [stdout] | [INFO] [stdout] 91 | .zip(rs.into_iter()) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: this parameter accepts any `IntoIterator`, so you don't need to call `.into_iter()` [INFO] [stdout] --> /rustc/91021ccc790478a1a89c003e7d32b8d155ae6aae/library/core/src/iter/traits/iterator.rs:629:11 [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] help: consider removing the `.into_iter()` [INFO] [stdout] | [INFO] [stdout] 91 - .zip(rs.into_iter()) [INFO] [stdout] 91 + .zip(rs) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `Rect` which implements the `Copy` trait [INFO] [stdout] --> src/ui/render/mod.rs:140:52 [INFO] [stdout] | [INFO] [stdout] 140 | for (rect, f) in self.get_render_parts(area.clone()) { [INFO] [stdout] | ^^^^^^^^^^^^ help: try removing the `clone` call: `area` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/ui/test.rs:1336:22 [INFO] [stdout] | [INFO] [stdout] 1336 | .expect(&format!("No background color set for {}:{}", ri, ci)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("No background color set for {}:{}", ri, ci))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/ui/test.rs:1366:18 [INFO] [stdout] | [INFO] [stdout] 1366 | .expect(&format!("No background color set for {}:{}", 1, ci)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("No background color set for {}:{}", 1, ci))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/ui/test.rs:1395:18 [INFO] [stdout] | [INFO] [stdout] 1395 | .expect(&format!("No background color set for {}:{}", ri, 1)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|| panic!("No background color set for {}:{}", ri, 1))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/ui/test.rs:1496:13 [INFO] [stdout] | [INFO] [stdout] 1496 | assert!(!result.is_some()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: try: `result.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: usage of `Iterator::fold` on a type that implements `Try` [INFO] [stdout] --> src/ui/mod.rs:125:14 [INFO] [stdout] | [INFO] [stdout] 125 | .fold(Some(0 as usize), |acc, n| { [INFO] [stdout] | ______________^ [INFO] [stdout] 126 | | acc?.checked_mul(10)?.checked_add(n as usize) [INFO] [stdout] 127 | | }) [INFO] [stdout] | |______________^ help: use `try_fold` instead: `try_fold(0 as usize, |acc, n| ...)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_try_fold [INFO] [stdout] = note: `#[warn(clippy::manual_try_fold)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting integer literal to `usize` is unnecessary [INFO] [stdout] --> src/ui/mod.rs:125:24 [INFO] [stdout] | [INFO] [stdout] 125 | .fold(Some(0 as usize), |acc, n| { [INFO] [stdout] | ^^^^^^^^^^ help: try: `0_usize` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_cast [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: field assignment outside of initializer for an instance created with Default::default() [INFO] [stdout] --> src/ui/mod.rs:218:9 [INFO] [stdout] | [INFO] [stdout] 218 | book.dirty = false; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: consider initializing the variable with `book::Book { dirty: false, ..Default::default() }` and removing relevant reassignments [INFO] [stdout] --> src/ui/mod.rs:217:9 [INFO] [stdout] | [INFO] [stdout] 217 | let mut book = Book::default(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#field_reassign_with_default [INFO] [stdout] = note: `#[warn(clippy::field_reassign_with_default)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:259:9 [INFO] [stdout] | [INFO] [stdout] 259 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 259 - return String::new(); [INFO] [stdout] 259 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: `format!` in `format!` args [INFO] [stdout] --> src/ui/mod.rs:241:22 [INFO] [stdout] | [INFO] [stdout] 241 | let a1 = format!( [INFO] [stdout] | ______________________^ [INFO] [stdout] 242 | | "{}{}", [INFO] [stdout] 243 | | start.to_range_part(), [INFO] [stdout] 244 | | format!(":{}", end.to_range_part()) [INFO] [stdout] 245 | | ); [INFO] [stdout] | |_____________^ [INFO] [stdout] | [INFO] [stdout] = help: combine the `format!(..)` arguments with the outer `format!(..)` call [INFO] [stdout] = help: or consider changing `format!` to `format_args!` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#format_in_format_args [INFO] [stdout] = note: `#[warn(clippy::format_in_format_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` can be collapsed into the outer `match` [INFO] [stdout] --> src/ui/mod.rs:621:21 [INFO] [stdout] | [INFO] [stdout] 621 | / if self.update_range_selection()? { [INFO] [stdout] 622 | | self.exit_range_select_mode()?; [INFO] [stdout] 623 | | } [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_match [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 620 ~ KeyCode::Char(' ') | KeyCode::Enter [INFO] [stdout] 621 ~ if self.update_range_selection()? => { [INFO] [stdout] 622 | self.exit_range_select_mode()?; [INFO] [stdout] 623 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: length comparison to zero [INFO] [stdout] --> src/ui/mod.rs:567:24 [INFO] [stdout] | [INFO] [stdout] 567 | if self.state.numeric_prefix.len() > 0 { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: using `!is_empty` is clearer and more explicit: `!self.state.numeric_prefix.is_empty()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:940:9 [INFO] [stdout] | [INFO] [stdout] 940 | return Ok(None); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 940 - return Ok(None); [INFO] [stdout] 940 + Ok(None) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ri` is used to index `rows` [INFO] [stdout] --> src/ui/mod.rs:980:27 [INFO] [stdout] | [INFO] [stdout] 980 | for ri in 0..row_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 980 - for ri in 0..row_len { [INFO] [stdout] 980 + for (ri, ) in rows.iter().enumerate().take(row_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ci` is used to index `columns` [INFO] [stdout] --> src/ui/mod.rs:983:31 [INFO] [stdout] | [INFO] [stdout] 983 | for ci in 0..col_len { [INFO] [stdout] | ^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 983 - for ci in 0..col_len { [INFO] [stdout] 983 + for (ci, ) in columns.iter().enumerate().take(col_len) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ri` is used to index `rows` [INFO] [stdout] --> src/ui/mod.rs:999:27 [INFO] [stdout] | [INFO] [stdout] 999 | for ri in 0..rows.len() { [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 999 - for ri in 0..rows.len() { [INFO] [stdout] 999 + for (ri, ) in rows.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `ci` is used to index `columns` [INFO] [stdout] --> src/ui/mod.rs:1001:31 [INFO] [stdout] | [INFO] [stdout] 1001 | for ci in 0..columns.len() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 1001 - for ci in 0..columns.len() { [INFO] [stdout] 1001 + for (ci, ) in columns.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:1035:9 [INFO] [stdout] | [INFO] [stdout] 1035 | return false; [INFO] [stdout] | ^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1035 - return false; [INFO] [stdout] 1035 + false [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/ui/mod.rs:1151:9 [INFO] [stdout] | [INFO] [stdout] 1151 | return Ok(Some(ExitCode::SUCCESS)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 1151 - return Ok(Some(ExitCode::SUCCESS)); [INFO] [stdout] 1151 + Ok(Some(ExitCode::SUCCESS)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/ui/mod.rs:1155:20 [INFO] [stdout] | [INFO] [stdout] 1155 | fn load_book(path: &PathBuf, locale: &str, tz: &str) -> Result { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 1155 - fn load_book(path: &PathBuf, locale: &str, tz: &str) -> Result { [INFO] [stdout] 1155 + fn load_book(path: &Path, locale: &str, tz: &str) -> Result { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: empty string literal in `writeln!` [INFO] [stdout] --> src/main.rs:41:17 [INFO] [stdout] | [INFO] [stdout] 41 | writeln!(&log_file, "")?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^----^ [INFO] [stdout] | | [INFO] [stdout] | help: remove the empty string [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#writeln_empty_string [INFO] [stdout] = note: `#[warn(clippy::writeln_empty_string)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2m 42s [INFO] running `Command { std: "docker" "inspect" "a05210c1895b952413314c6db737e76413a2836dcfbef6985391fac7e3cbab73", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "a05210c1895b952413314c6db737e76413a2836dcfbef6985391fac7e3cbab73", kill_on_drop: false }` [INFO] [stdout] a05210c1895b952413314c6db737e76413a2836dcfbef6985391fac7e3cbab73