[INFO] cloning repository https://github.com/zach-lawrence-1/Command-Line-Interface [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zach-lawrence-1/Command-Line-Interface" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzach-lawrence-1%2FCommand-Line-Interface", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzach-lawrence-1%2FCommand-Line-Interface'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 3eb150ecfb92faba26922c01c17a103cf6ba29ef [INFO] linting zach-lawrence-1/Command-Line-Interface against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fzach-lawrence-1%2FCommand-Line-Interface" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/zach-lawrence-1/Command-Line-Interface [INFO] finished tweaking git repo https://github.com/zach-lawrence-1/Command-Line-Interface [INFO] tweaked toml for git repo https://github.com/zach-lawrence-1/Command-Line-Interface written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zach-lawrence-1/Command-Line-Interface on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zach-lawrence-1/Command-Line-Interface already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] cd474b81b9bf4da71f9426ed0575446b28d1efd6e5b5f9ddac000e4b5dd507c5 [INFO] running `Command { std: "docker" "start" "-a" "cd474b81b9bf4da71f9426ed0575446b28d1efd6e5b5f9ddac000e4b5dd507c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "cd474b81b9bf4da71f9426ed0575446b28d1efd6e5b5f9ddac000e4b5dd507c5", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "cd474b81b9bf4da71f9426ed0575446b28d1efd6e5b5f9ddac000e4b5dd507c5", kill_on_drop: false }` [INFO] [stdout] cd474b81b9bf4da71f9426ed0575446b28d1efd6e5b5f9ddac000e4b5dd507c5 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6d8272bce62f89e1da41cd7313d12ef5ab63e15677c614518ad80fe8a60aaf46 [INFO] running `Command { std: "docker" "start" "-a" "6d8272bce62f89e1da41cd7313d12ef5ab63e15677c614518ad80fe8a60aaf46", kill_on_drop: false }` [INFO] [stderr] Checking command_interface v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !(commands.chars().filter(|c| *c == '"').count() % 2 == 0) || !(commands.chars().filter(|c| *c == '\'').count() % 2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(commands.chars().filter(|c| *c == '"').count() % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command.rs:14:70 [INFO] [stdout] | [INFO] [stdout] 14 | if !(commands.chars().filter(|c| *c == '"').count() % 2 == 0) || !(commands.chars().filter(|c| *c == '\'').count() % 2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(commands.chars().filter(|c| *c == '\'').count() % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return (pv, option_arg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return (pv, option_arg.to_string()); [INFO] [stdout] 117 + (pv, option_arg.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `indx` is used as a loop counter [INFO] [stdout] --> src/command.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | for ch in commands.chars() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (indx, ch) in (0_u8..).zip(commands.chars())` [INFO] [stdout] | [INFO] [stdout] = note: `indx` is of type `u8`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `commands_vec` [INFO] [stdout] --> src/command.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 82 | for i in 1..commands_vec.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 82 - for i in 1..commands_vec.len() [INFO] [stdout] 82 + for in commands_vec.iter().skip(1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is only used to index `path_vec` [INFO] [stdout] --> src/command.rs:101:26 [INFO] [stdout] | [INFO] [stdout] 101 | for p in 0..path_vec.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 101 - for p in 0..path_vec.len() [INFO] [stdout] 101 + for in &path_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return file_dir.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return file_dir.to_string(); [INFO] [stdout] 192 + file_dir.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command.rs:14:8 [INFO] [stdout] | [INFO] [stdout] 14 | if !(commands.chars().filter(|c| *c == '"').count() % 2 == 0) || !(commands.chars().filter(|c| *c == '\'').count() % 2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(commands.chars().filter(|c| *c == '"').count() % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | return file_dirs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - return file_dirs; [INFO] [stdout] 286 + file_dirs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/command.rs:14:70 [INFO] [stdout] | [INFO] [stdout] 14 | if !(commands.chars().filter(|c| *c == '"').count() % 2 == 0) || !(commands.chars().filter(|c| *c == '\'').count() % 2 == 0) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `(commands.chars().filter(|c| *c == '\'').count() % 2 != 0)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:117:5 [INFO] [stdout] | [INFO] [stdout] 117 | return (pv, option_arg.to_string()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return (pv, option_arg.to_string()); [INFO] [stdout] 117 + (pv, option_arg.to_string()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `indx` is used as a loop counter [INFO] [stdout] --> src/command.rs:27:9 [INFO] [stdout] | [INFO] [stdout] 27 | for ch in commands.chars() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (indx, ch) in (0_u8..).zip(commands.chars())` [INFO] [stdout] | [INFO] [stdout] = note: `indx` is of type `u8`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is only used to index `commands_vec` [INFO] [stdout] --> src/command.rs:82:22 [INFO] [stdout] | [INFO] [stdout] 82 | for i in 1..commands_vec.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 82 - for i in 1..commands_vec.len() [INFO] [stdout] 82 + for in commands_vec.iter().skip(1) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `p` is only used to index `path_vec` [INFO] [stdout] --> src/command.rs:101:26 [INFO] [stdout] | [INFO] [stdout] 101 | for p in 0..path_vec.len() [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator [INFO] [stdout] | [INFO] [stdout] 101 - for p in 0..path_vec.len() [INFO] [stdout] 101 + for in &path_vec [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:344:9 [INFO] [stdout] | [INFO] [stdout] 344 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] = note: `#[warn(clippy::bool_assert_comparison)]` on by default [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 344 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 344 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:192:5 [INFO] [stdout] | [INFO] [stdout] 192 | return file_dir.to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 192 - return file_dir.to_string(); [INFO] [stdout] 192 + file_dir.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 349 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 349 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/command.rs:286:5 [INFO] [stdout] | [INFO] [stdout] 286 | return file_dirs; [INFO] [stdout] | ^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 286 - return file_dirs; [INFO] [stdout] 286 + file_dirs [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:358:9 [INFO] [stdout] | [INFO] [stdout] 358 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 358 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 358 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:368:9 [INFO] [stdout] | [INFO] [stdout] 368 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 368 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 368 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:381:9 [INFO] [stdout] | [INFO] [stdout] 381 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 381 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 381 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: used `assert_eq!` with a literal bool [INFO] [stdout] --> src/command.rs:386:9 [INFO] [stdout] | [INFO] [stdout] 386 | assert_eq!(vec.is_empty(), true); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_assert_comparison [INFO] [stdout] help: replace it with `assert!(..)` [INFO] [stdout] | [INFO] [stdout] 386 - assert_eq!(vec.is_empty(), true); [INFO] [stdout] 386 + assert!(vec.is_empty()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 0.23s [INFO] running `Command { std: "docker" "inspect" "6d8272bce62f89e1da41cd7313d12ef5ab63e15677c614518ad80fe8a60aaf46", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6d8272bce62f89e1da41cd7313d12ef5ab63e15677c614518ad80fe8a60aaf46", kill_on_drop: false }` [INFO] [stdout] 6d8272bce62f89e1da41cd7313d12ef5ab63e15677c614518ad80fe8a60aaf46