[INFO] cloning repository https://github.com/zUnixorn/advent-of-code-2024 [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/zUnixorn/advent-of-code-2024" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FzUnixorn%2Fadvent-of-code-2024", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FzUnixorn%2Fadvent-of-code-2024'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 922529c479fa04deea3ae6f2592a909ed9fd99a0 [INFO] linting zUnixorn/advent-of-code-2024 against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FzUnixorn%2Fadvent-of-code-2024" "/workspace/builds/worker-2-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-2-tc1/source'... [INFO] [stderr] done. [INFO] removed /workspace/builds/worker-2-tc1/source/.cargo/config.toml [INFO] started tweaking git repo https://github.com/zUnixorn/advent-of-code-2024 [INFO] finished tweaking git repo https://github.com/zUnixorn/advent-of-code-2024 [INFO] tweaked toml for git repo https://github.com/zUnixorn/advent-of-code-2024 written to /workspace/builds/worker-2-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/zUnixorn/advent-of-code-2024 on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/zUnixorn/advent-of-code-2024 already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded tinyjson v2.5.1 [INFO] [stderr] Downloaded rstar v0.12.2 [INFO] [stderr] Downloaded hash32 v0.3.1 [INFO] [stderr] Downloaded wasm-bindgen-macro v0.2.89 [INFO] [stderr] Downloaded cached_proc_macro v0.23.0 [INFO] [stderr] Downloaded iana-time-zone v0.1.58 [INFO] [stderr] Downloaded wasm-bindgen-backend v0.2.89 [INFO] [stderr] Downloaded cached v0.54.0 [INFO] [stderr] Downloaded libm v0.2.11 [INFO] [stderr] Downloaded geo-types v0.7.14 [INFO] [stderr] Downloaded js-sys v0.3.66 [INFO] [stderr] Downloaded geographiclib-rs v0.2.4 [INFO] [stderr] Downloaded wasm-bindgen-shared v0.2.89 [INFO] [stderr] Downloaded wasm-bindgen-macro-support v0.2.89 [INFO] [stderr] Downloaded sys-info v0.9.1 [INFO] [stderr] Downloaded wasm-bindgen v0.2.89 [INFO] [stderr] Downloaded geo v0.29.3 [INFO] [stderr] Downloaded i_overlay v1.9.3 [INFO] [stderr] Downloaded syn v2.0.90 [INFO] [stderr] Downloaded dhat v0.3.3 [INFO] [stderr] Downloaded i_float v1.6.0 [INFO] [stderr] Downloaded heapless v0.8.0 [INFO] [stderr] Downloaded cached_proc_macro_types v0.1.1 [INFO] [stderr] Downloaded mintex v0.1.2 [INFO] [stderr] Downloaded float_next_after v1.0.0 [INFO] [stderr] Downloaded spade v2.12.1 [INFO] [stderr] Downloaded robust v1.1.0 [INFO] [stderr] Downloaded i_key_sort v0.2.0 [INFO] [stderr] Downloaded i_shape v1.6.0 [INFO] [stderr] Downloaded i_tree v0.8.3 [INFO] [stderr] Downloaded thousands v0.2.0 [INFO] [stderr] Downloaded earcutr v0.4.3 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0dff1242bb019d5ebc51e33b2ea216d101353492d999e1c8c3f1996561b47331 [INFO] running `Command { std: "docker" "start" "-a" "0dff1242bb019d5ebc51e33b2ea216d101353492d999e1c8c3f1996561b47331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0dff1242bb019d5ebc51e33b2ea216d101353492d999e1c8c3f1996561b47331", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0dff1242bb019d5ebc51e33b2ea216d101353492d999e1c8c3f1996561b47331", kill_on_drop: false }` [INFO] [stdout] 0dff1242bb019d5ebc51e33b2ea216d101353492d999e1c8c3f1996561b47331 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-2-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 66aba4da3076fc2ed39dad4308aba60027064be41f4e6a841d74ff4824c8d04a [INFO] running `Command { std: "docker" "start" "-a" "66aba4da3076fc2ed39dad4308aba60027064be41f4e6a841d74ff4824c8d04a", kill_on_drop: false }` [INFO] [stderr] Compiling proc-macro2 v1.0.92 [INFO] [stderr] Compiling libm v0.2.11 [INFO] [stderr] Compiling crossbeam-utils v0.8.20 [INFO] [stderr] Checking either v1.13.0 [INFO] [stderr] Compiling serde v1.0.193 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling ahash v0.8.11 [INFO] [stderr] Checking zerocopy v0.7.35 [INFO] [stderr] Compiling heapless v0.8.0 [INFO] [stderr] Checking byteorder v1.5.0 [INFO] [stderr] Checking memchr v2.6.4 [INFO] [stderr] Checking stable_deref_trait v1.2.0 [INFO] [stderr] Compiling radium v0.7.0 [INFO] [stderr] Checking i_key_sort v0.2.0 [INFO] [stderr] Checking tap v1.0.1 [INFO] [stderr] Checking i_tree v0.8.3 [INFO] [stderr] Checking hashbrown v0.15.2 [INFO] [stderr] Checking hash32 v0.3.1 [INFO] [stderr] Checking robust v1.1.0 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking itertools v0.11.0 [INFO] [stderr] Checking aho-corasick v1.1.3 [INFO] [stderr] Checking wyz v0.5.1 [INFO] [stderr] Checking funty v2.0.0 [INFO] [stderr] Checking cached_proc_macro_types v0.1.1 [INFO] [stderr] Checking float_next_after v1.0.0 [INFO] [stderr] Checking fixedbitset v0.4.2 [INFO] [stderr] Checking minimal-lexical v0.2.1 [INFO] [stderr] Checking web-time v1.1.0 [INFO] [stderr] Checking log v0.4.20 [INFO] [stderr] Checking nom v7.1.3 [INFO] [stderr] Checking itertools v0.13.0 [INFO] [stderr] Checking tinyjson v2.5.1 [INFO] [stderr] Checking pico-args v0.5.0 [INFO] [stderr] Compiling quote v1.0.37 [INFO] [stderr] Checking bitvec v1.0.1 [INFO] [stderr] Checking hashbrown v0.14.5 [INFO] [stderr] Checking geographiclib-rs v0.2.4 [INFO] [stderr] Compiling syn v2.0.90 [INFO] [stderr] Checking indexmap v2.7.0 [INFO] [stderr] Checking crossbeam-epoch v0.9.18 [INFO] [stderr] Checking rstar v0.12.2 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking crossbeam-deque v0.8.5 [INFO] [stderr] Checking spade v2.12.1 [INFO] [stderr] Checking rayon-core v1.12.1 [INFO] [stderr] Checking petgraph v0.6.5 [INFO] [stderr] Checking rayon v1.10.0 [INFO] [stderr] Checking earcutr v0.4.3 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking geo-types v0.7.14 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Compiling darling_core v0.20.10 [INFO] [stderr] Compiling serde_derive v1.0.193 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Compiling darling_macro v0.20.10 [INFO] [stderr] Compiling darling v0.20.10 [INFO] [stderr] Compiling cached_proc_macro v0.23.0 [INFO] [stderr] Checking cached v0.54.0 [INFO] [stderr] Checking i_float v1.6.0 [INFO] [stderr] Checking i_shape v1.6.0 [INFO] [stderr] Checking i_overlay v1.9.3 [INFO] [stderr] Checking geo v0.29.3 [INFO] [stderr] Checking advent_of_code v0.11.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/run_multi.rs:173:26 [INFO] [stdout] | [INFO] [stdout] 173 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 174 | | .split(" samples)") [INFO] [stdout] 175 | | .next()? [INFO] [stdout] 176 | | .split('(') [INFO] [stdout] 177 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 - .last()? [INFO] [stdout] 177 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/template/timings.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] 54 + data.sort_unstable_by_key(|a| a.day); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/bin/09.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|(i, (a, b))| { [INFO] [stdout] | __________^ [INFO] [stdout] 18 | | iter::repeat(Some(i)) [INFO] [stdout] 19 | | .take(*a as usize) [INFO] [stdout] 20 | | .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] 21 | | }) [INFO] [stdout] 22 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 17 ~ .flat_map(|(i, (a, b))| { [INFO] [stdout] 18 + iter::repeat(Some(i)) [INFO] [stdout] 19 + .take(*a as usize) [INFO] [stdout] 20 + .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] 21 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/bin/09.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | / iter::repeat(Some(i)) [INFO] [stdout] 19 | | .take(*a as usize) [INFO] [stdout] | |__________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Some(i), *a as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/bin/09.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(None, *b as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/bin/09.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | while let None = expanded[j] { [INFO] [stdout] | ----------^^^^-------------- help: try: `while expanded[j].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/09.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if expanded[i] == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `expanded[i].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `Iterator::last` on a `DoubleEndedIterator`; this will needlessly iterate the entire iterator [INFO] [stdout] --> src/template/run_multi.rs:173:26 [INFO] [stdout] | [INFO] [stdout] 173 | let str_timing = line [INFO] [stdout] | __________________________^ [INFO] [stdout] 174 | | .split(" samples)") [INFO] [stdout] 175 | | .next()? [INFO] [stdout] 176 | | .split('(') [INFO] [stdout] 177 | | .last()? [INFO] [stdout] | |___________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#double_ended_iterator_last [INFO] [stdout] = note: `#[warn(clippy::double_ended_iterator_last)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 177 - .last()? [INFO] [stdout] 177 + .next_back()? [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: consider using `sort_unstable_by_key` [INFO] [stdout] --> src/template/timings.rs:54:9 [INFO] [stdout] | [INFO] [stdout] 54 | data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_sort_by [INFO] [stdout] = note: `#[warn(clippy::unnecessary_sort_by)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 54 - data.sort_unstable_by(|a, b| a.day.cmp(&b.day)); [INFO] [stdout] 54 + data.sort_unstable_by_key(|a| a.day); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/05.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | fn parse(input: &str) -> IResult<&str, (HashMap>, Vec>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/05.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | rules.entry(key).or_insert_with(|| HashSet::new()).insert(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/05.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | fn split_updates(rules: &HashMap>, updates: &Vec>) -> (Vec>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn split_updates(rules: &HashMap>, updates: &Vec>) -> (Vec>, Vec>) { [INFO] [stdout] 23 + fn split_updates(rules: &HashMap>, updates: &[Vec]) -> (Vec>, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `copied` [INFO] [stdout] --> src/bin/05.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | for page in update.keys().copied() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: remove any references to the binding [INFO] [stdout] | [INFO] [stdout] 33 ~ for page in update.keys() { [INFO] [stdout] 34 ~ let page_index = *update.get(page).unwrap(); [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ if let Some(after_pages) = rules.get(page) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `copied` [INFO] [stdout] --> src/bin/05.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | for after_page in after_pages.iter().copied() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] help: remove any references to the binding [INFO] [stdout] | [INFO] [stdout] 37 ~ for after_page in after_pages { [INFO] [stdout] 38 ~ if page_index > *update.get(after_page).unwrap_or(&usize::MAX) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for y in 0..height { [INFO] [stdout] 26 + for (y, ) in parsed.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for x in 0..width { [INFO] [stdout] 27 + for (x, ) in parsed.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/08.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | .or_insert_with(|| HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 63 - for y in 0..height { [INFO] [stdout] 63 + for (y, ) in parsed.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:64:18 [INFO] [stdout] | [INFO] [stdout] 64 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 64 - for x in 0..width { [INFO] [stdout] 64 + for (x, ) in parsed.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/08.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | .or_insert_with(|| HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/07.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if !result.is_some_and(|r| r <= expected) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_none_or(|r| r > expected)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/07.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | if !result.is_some_and(|r| r <= expected) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_none_or(|r| r > expected)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/bin/08.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | / (0..) [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] | |____________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: very complex type used. Consider factoring parts into `type` definitions [INFO] [stdout] --> src/bin/05.rs:11:26 [INFO] [stdout] | [INFO] [stdout] 11 | fn parse(input: &str) -> IResult<&str, (HashMap>, Vec>)> { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity [INFO] [stdout] = note: `#[warn(clippy::type_complexity)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/05.rs:17:41 [INFO] [stdout] | [INFO] [stdout] 17 | rules.entry(key).or_insert_with(|| HashSet::new()).insert(value); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&Vec` instead of `&[_]` involves a new object where a slice will do [INFO] [stdout] --> src/bin/05.rs:23:63 [INFO] [stdout] | [INFO] [stdout] 23 | fn split_updates(rules: &HashMap>, updates: &Vec>) -> (Vec>, Vec>) { [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 23 - fn split_updates(rules: &HashMap>, updates: &Vec>) -> (Vec>, Vec>) { [INFO] [stdout] 23 + fn split_updates(rules: &HashMap>, updates: &[Vec]) -> (Vec>, Vec>) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `copied` [INFO] [stdout] --> src/bin/05.rs:33:21 [INFO] [stdout] | [INFO] [stdout] 33 | for page in update.keys().copied() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] = note: `#[warn(clippy::unnecessary_to_owned)]` on by default [INFO] [stdout] help: remove any references to the binding [INFO] [stdout] | [INFO] [stdout] 33 ~ for page in update.keys() { [INFO] [stdout] 34 ~ let page_index = *update.get(page).unwrap(); [INFO] [stdout] 35 | [INFO] [stdout] 36 ~ if let Some(after_pages) = rules.get(page) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unnecessary use of `copied` [INFO] [stdout] --> src/bin/05.rs:37:35 [INFO] [stdout] | [INFO] [stdout] 37 | for after_page in after_pages.iter().copied() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_to_owned [INFO] [stdout] help: remove any references to the binding [INFO] [stdout] | [INFO] [stdout] 37 ~ for after_page in after_pages { [INFO] [stdout] 38 ~ if page_index > *update.get(after_page).unwrap_or(&usize::MAX) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/07.rs:36:20 [INFO] [stdout] | [INFO] [stdout] 36 | if !result.is_some_and(|r| r <= expected) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_none_or(|r| r > expected)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/bin/07.rs:73:20 [INFO] [stdout] | [INFO] [stdout] 73 | if !result.is_some_and(|r| r <= expected) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `result.is_none_or(|r| r > expected)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:26:14 [INFO] [stdout] | [INFO] [stdout] 26 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 26 - for y in 0..height { [INFO] [stdout] 26 + for (y, ) in parsed.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:27:18 [INFO] [stdout] | [INFO] [stdout] 27 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 27 - for x in 0..width { [INFO] [stdout] 27 + for (x, ) in parsed.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/08.rs:31:37 [INFO] [stdout] | [INFO] [stdout] 31 | .or_insert_with(|| HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `y` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:63:14 [INFO] [stdout] | [INFO] [stdout] 63 | for y in 0..height { [INFO] [stdout] | ^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 63 - for y in 0..height { [INFO] [stdout] 63 + for (y, ) in parsed.iter().enumerate().take(height) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `x` is used to index `parsed` [INFO] [stdout] --> src/bin/08.rs:64:18 [INFO] [stdout] | [INFO] [stdout] 64 | for x in 0..width { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 64 - for x in 0..width { [INFO] [stdout] 64 + for (x, ) in parsed.iter().enumerate().take(width) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/bin/08.rs:68:37 [INFO] [stdout] | [INFO] [stdout] 68 | .or_insert_with(|| HashSet::new()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `HashSet::new` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless conversion to the same type: `std::ops::RangeFrom` [INFO] [stdout] --> src/bin/08.rs:80:21 [INFO] [stdout] | [INFO] [stdout] 80 | / (0..) [INFO] [stdout] 81 | | .into_iter() [INFO] [stdout] | |____________________________________^ help: consider removing `.into_iter()`: `(0..)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_conversion [INFO] [stdout] = note: `#[warn(clippy::useless_conversion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `map(..).flatten()` on `Iterator` [INFO] [stdout] --> src/bin/09.rs:17:10 [INFO] [stdout] | [INFO] [stdout] 17 | .map(|(i, (a, b))| { [INFO] [stdout] | __________^ [INFO] [stdout] 18 | | iter::repeat(Some(i)) [INFO] [stdout] 19 | | .take(*a as usize) [INFO] [stdout] 20 | | .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] 21 | | }) [INFO] [stdout] 22 | | .flatten() [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_flatten [INFO] [stdout] = note: `#[warn(clippy::map_flatten)]` on by default [INFO] [stdout] help: try replacing `map` with `flat_map` and remove the `.flatten()` [INFO] [stdout] | [INFO] [stdout] 17 ~ .flat_map(|(i, (a, b))| { [INFO] [stdout] 18 + iter::repeat(Some(i)) [INFO] [stdout] 19 + .take(*a as usize) [INFO] [stdout] 20 + .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] 21 + }) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/bin/09.rs:18:13 [INFO] [stdout] | [INFO] [stdout] 18 | / iter::repeat(Some(i)) [INFO] [stdout] 19 | | .take(*a as usize) [INFO] [stdout] | |__________________________________^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(Some(i), *a as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] = note: `#[warn(clippy::manual_repeat_n)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `repeat().take()` can be written more concisely [INFO] [stdout] --> src/bin/09.rs:20:24 [INFO] [stdout] | [INFO] [stdout] 20 | .chain(iter::repeat(None).take(*b as usize)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `repeat_n()` instead: `std::iter::repeat_n(None, *b as usize)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_repeat_n [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_none()` [INFO] [stdout] --> src/bin/09.rs:54:19 [INFO] [stdout] | [INFO] [stdout] 54 | while let None = expanded[j] { [INFO] [stdout] | ----------^^^^-------------- help: try: `while expanded[j].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/bin/09.rs:58:12 [INFO] [stdout] | [INFO] [stdout] 58 | if expanded[i] == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `expanded[i].is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 33.43s [INFO] running `Command { std: "docker" "inspect" "66aba4da3076fc2ed39dad4308aba60027064be41f4e6a841d74ff4824c8d04a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "66aba4da3076fc2ed39dad4308aba60027064be41f4e6a841d74ff4824c8d04a", kill_on_drop: false }` [INFO] [stdout] 66aba4da3076fc2ed39dad4308aba60027064be41f4e6a841d74ff4824c8d04a