[INFO] cloning repository https://github.com/z2oh/chromatic_confinement [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/z2oh/chromatic_confinement" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fz2oh%2Fchromatic_confinement", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fz2oh%2Fchromatic_confinement'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 7773f44ca986024b3c71784982c1549c9f1cfc90 [INFO] linting z2oh/chromatic_confinement against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fz2oh%2Fchromatic_confinement" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/z2oh/chromatic_confinement [INFO] finished tweaking git repo https://github.com/z2oh/chromatic_confinement [INFO] tweaked toml for git repo https://github.com/z2oh/chromatic_confinement written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/z2oh/chromatic_confinement on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/z2oh/chromatic_confinement already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded num-rational v0.1.40 [INFO] [stderr] Downloaded scoped_threadpool v0.1.8 [INFO] [stderr] Downloaded adler32 v1.0.2 [INFO] [stderr] Downloaded jpeg-decoder v0.1.13 [INFO] [stderr] Downloaded inflate v0.3.3 [INFO] [stderr] Downloaded either v1.4.0 [INFO] [stderr] Downloaded redox_syscall v0.1.37 [INFO] [stderr] Downloaded atty v0.2.6 [INFO] [stderr] Downloaded rayon-core v1.3.0 [INFO] [stderr] Downloaded ansi_term v0.10.2 [INFO] [stderr] Downloaded rand v0.3.20 [INFO] [stderr] Downloaded ego-tree v0.1.1 [INFO] [stderr] Downloaded rayon v0.8.2 [INFO] [stderr] Downloaded deflate v0.7.17 [INFO] [stderr] Downloaded clap v2.29.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] fa0ef7bb95e9308edbe05992b7c4e977142502e4a2c59d6269392093d3974c4c [INFO] running `Command { std: "docker" "start" "-a" "fa0ef7bb95e9308edbe05992b7c4e977142502e4a2c59d6269392093d3974c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "fa0ef7bb95e9308edbe05992b7c4e977142502e4a2c59d6269392093d3974c4c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "fa0ef7bb95e9308edbe05992b7c4e977142502e4a2c59d6269392093d3974c4c", kill_on_drop: false }` [INFO] [stdout] fa0ef7bb95e9308edbe05992b7c4e977142502e4a2c59d6269392093d3974c4c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 63a963b066ebf17bf2eb92d334b5b685b4b6fff95348c89240cadcfaf4b512d6 [INFO] running `Command { std: "docker" "start" "-a" "63a963b066ebf17bf2eb92d334b5b685b4b6fff95348c89240cadcfaf4b512d6", kill_on_drop: false }` [INFO] [stderr] warning: `package.edition` is unspecified, defaulting to `2015` while the latest is `2024` [INFO] [stderr] Checking libc v0.2.36 [INFO] [stderr] Checking num-traits v0.1.41 [INFO] [stderr] Compiling rayon-core v1.3.0 [INFO] [stderr] Checking either v1.4.0 [INFO] [stderr] Checking scopeguard v0.3.3 [INFO] [stderr] Checking adler32 v1.0.2 [INFO] [stderr] Checking byteorder v1.2.1 [INFO] [stderr] Checking lazy_static v0.2.11 [INFO] [stderr] Checking bitflags v1.0.1 [INFO] [stderr] Checking color_quant v1.0.0 [INFO] [stderr] Checking unicode-width v0.1.4 [INFO] [stderr] Checking ansi_term v0.10.2 [INFO] [stderr] Checking scoped_threadpool v0.1.8 [INFO] [stderr] Checking strsim v0.7.0 [INFO] [stderr] Checking vec_map v0.8.0 [INFO] [stderr] Checking ego-tree v0.1.1 [INFO] [stderr] Checking inflate v0.3.3 [INFO] [stderr] Checking coco v0.1.1 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Checking deflate v0.7.17 [INFO] [stderr] Checking num_cpus v1.8.0 [INFO] [stderr] Checking rand v0.3.20 [INFO] [stderr] Checking atty v0.2.6 [INFO] [stderr] Checking gif v0.9.2 [INFO] [stderr] Checking num-integer v0.1.35 [INFO] [stderr] Checking enum_primitive v0.1.1 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking num-iter v0.1.34 [INFO] [stderr] Checking num-rational v0.1.40 [INFO] [stderr] Checking png v0.11.0 [INFO] [stderr] Checking rayon v0.8.2 [INFO] [stderr] Checking jpeg-decoder v0.1.13 [INFO] [stderr] Checking image v0.18.0 [INFO] [stderr] Checking chromatic_confiner v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | v.description() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | let naive: bool = match matches.occurrences_of("naive") { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | 0 => false, [INFO] [stdout] 77 | | _ => true, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 75 - let naive: bool = match matches.occurrences_of("naive") { [INFO] [stdout] 76 - 0 => false, [INFO] [stdout] 77 - _ => true, [INFO] [stdout] 78 - }; [INFO] [stdout] 75 + let naive: bool = !matches!(matches.occurrences_of("naive"), 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !node_id_option.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `node_id_option.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node_id_option` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:234:71 [INFO] [stdout] | [INFO] [stdout] 232 | if !node_id_option.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 233 | let second_best_guess_node = [INFO] [stdout] 234 | query_nearest_neighbor(q, kd_tree, max_dimension, node_id_option.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/main.rs:224:31 [INFO] [stdout] | [INFO] [stdout] 224 | let plane_dist: u32 = (i32::from(parent_val[current_dim]) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 225 | | - i32::from(best_guess_node.value()[current_dim])) [INFO] [stdout] 226 | | .abs() as u32; [INFO] [stdout] | |_________________________^ help: replace with: `(i32::from(parent_val[current_dim]) - i32::from(best_guess_node.value()[current_dim])).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/main.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 177 | kd_tree: &'a Tree>, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_kd_tree` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/main.rs:234:47 [INFO] [stdout] | [INFO] [stdout] 234 | query_nearest_neighbor(q, kd_tree, max_dimension, node_id_option.unwrap()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:106:52 [INFO] [stdout] | [INFO] [stdout] 106 | println!("{} calls to distance function.", DIST_CALLS); [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of deprecated method `std::error::Error::description`: use the Display impl or to_string() [INFO] [stdout] --> src/main.rs:60:15 [INFO] [stdout] | [INFO] [stdout] 60 | v.description() [INFO] [stdout] | ^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = note: `#[warn(deprecated)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: match expression looks like `matches!` macro [INFO] [stdout] --> src/main.rs:75:23 [INFO] [stdout] | [INFO] [stdout] 75 | let naive: bool = match matches.occurrences_of("naive") { [INFO] [stdout] | _______________________^ [INFO] [stdout] 76 | | 0 => false, [INFO] [stdout] 77 | | _ => true, [INFO] [stdout] 78 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_like_matches_macro [INFO] [stdout] = note: `#[warn(clippy::match_like_matches_macro)]` on by default [INFO] [stdout] help: use `matches!` directly [INFO] [stdout] | [INFO] [stdout] 75 - let naive: bool = match matches.occurrences_of("naive") { [INFO] [stdout] 76 - 0 => false, [INFO] [stdout] 77 - _ => true, [INFO] [stdout] 78 - }; [INFO] [stdout] 75 + let naive: bool = !matches!(matches.occurrences_of("naive"), 0); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:232:16 [INFO] [stdout] | [INFO] [stdout] 232 | if !node_id_option.is_none() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `node_id_option.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `node_id_option` after checking its variant with `is_none` [INFO] [stdout] --> src/main.rs:234:71 [INFO] [stdout] | [INFO] [stdout] 232 | if !node_id_option.is_none() { [INFO] [stdout] | ------------------------ the check is happening here [INFO] [stdout] 233 | let second_best_guess_node = [INFO] [stdout] 234 | query_nearest_neighbor(q, kd_tree, max_dimension, node_id_option.unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: casting the result of `i32::abs()` to u32 [INFO] [stdout] --> src/main.rs:224:31 [INFO] [stdout] | [INFO] [stdout] 224 | let plane_dist: u32 = (i32::from(parent_val[current_dim]) [INFO] [stdout] | _______________________________^ [INFO] [stdout] 225 | | - i32::from(best_guess_node.value()[current_dim])) [INFO] [stdout] 226 | | .abs() as u32; [INFO] [stdout] | |_________________________^ help: replace with: `(i32::from(parent_val[current_dim]) - i32::from(best_guess_node.value()[current_dim])).unsigned_abs()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_abs_to_unsigned [INFO] [stdout] = note: `#[warn(clippy::cast_abs_to_unsigned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: parameter is only used in recursion [INFO] [stdout] --> src/main.rs:177:5 [INFO] [stdout] | [INFO] [stdout] 177 | kd_tree: &'a Tree>, [INFO] [stdout] | ^^^^^^^ help: if this is intentional, prefix it with an underscore: `_kd_tree` [INFO] [stdout] | [INFO] [stdout] note: parameter used here [INFO] [stdout] --> src/main.rs:234:47 [INFO] [stdout] | [INFO] [stdout] 234 | query_nearest_neighbor(q, kd_tree, max_dimension, node_id_option.unwrap()); [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#only_used_in_recursion [INFO] [stdout] = note: `#[warn(clippy::only_used_in_recursion)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: creating a shared reference to mutable static [INFO] [stdout] --> src/main.rs:106:52 [INFO] [stdout] | [INFO] [stdout] 106 | println!("{} calls to distance function.", DIST_CALLS); [INFO] [stdout] | ^^^^^^^^^^ shared reference to mutable static [INFO] [stdout] | [INFO] [stdout] = note: shared references to mutable statics are dangerous; it's undefined behavior if the static is mutated or if a mutable reference is created for it while the shared reference lives [INFO] [stdout] = note: for more information, see [INFO] [stdout] = note: `#[warn(static_mut_refs)]` (part of `#[warn(rust_2024_compatibility)]`) on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.98s [INFO] running `Command { std: "docker" "inspect" "63a963b066ebf17bf2eb92d334b5b685b4b6fff95348c89240cadcfaf4b512d6", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "63a963b066ebf17bf2eb92d334b5b685b4b6fff95348c89240cadcfaf4b512d6", kill_on_drop: false }` [INFO] [stdout] 63a963b066ebf17bf2eb92d334b5b685b4b6fff95348c89240cadcfaf4b512d6