[INFO] cloning repository https://github.com/ys4e/sniffer-tool [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/ys4e/sniffer-tool" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fys4e%2Fsniffer-tool", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fys4e%2Fsniffer-tool'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 032822cd1e88d55ffdf771aae4d097b4d0e7583f [INFO] linting ys4e/sniffer-tool against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fys4e%2Fsniffer-tool" "/workspace/builds/worker-0-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-0-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/ys4e/sniffer-tool [INFO] finished tweaking git repo https://github.com/ys4e/sniffer-tool [INFO] tweaked toml for git repo https://github.com/ys4e/sniffer-tool written to /workspace/builds/worker-0-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/ys4e/sniffer-tool on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/ys4e/sniffer-tool already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded logos-derive v0.15.0 [INFO] [stderr] Downloaded protox v0.9.0 [INFO] [stderr] Downloaded protoshark v2.0.0 [INFO] [stderr] Downloaded pcap v2.3.0 [INFO] [stderr] Downloaded logos-codegen v0.15.0 [INFO] [stderr] Downloaded protox-parse v0.9.0 [INFO] [stderr] Downloaded ys-kcp v1.2.1 [INFO] [stderr] Downloaded ys-sniffer v0.2.4 [INFO] [stderr] Downloaded prost-reflect v0.16.0 [INFO] [stderr] Downloaded logos v0.15.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] c68919d5656627fad41f197b0c47f23011676fb6d455556402ee95ff28580655 [INFO] running `Command { std: "docker" "start" "-a" "c68919d5656627fad41f197b0c47f23011676fb6d455556402ee95ff28580655", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "c68919d5656627fad41f197b0c47f23011676fb6d455556402ee95ff28580655", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "c68919d5656627fad41f197b0c47f23011676fb6d455556402ee95ff28580655", kill_on_drop: false }` [INFO] [stdout] c68919d5656627fad41f197b0c47f23011676fb6d455556402ee95ff28580655 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-0-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 998c5fd6fd14d61bc9ef420a36be5922e149f813eea469331be34b4bd172ce5b [INFO] running `Command { std: "docker" "start" "-a" "998c5fd6fd14d61bc9ef420a36be5922e149f813eea469331be34b4bd172ce5b", kill_on_drop: false }` [INFO] [stderr] Compiling anyhow v1.0.98 [INFO] [stderr] Compiling libc v0.2.174 [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking base64ct v1.8.0 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling aho-corasick v1.1.3 [INFO] [stderr] Compiling beef v0.5.2 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Compiling logos-codegen v0.15.0 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling rustix v1.0.8 [INFO] [stderr] Checking regex-syntax v0.8.5 [INFO] [stderr] Checking bitflags v2.9.1 [INFO] [stderr] Checking slab v0.4.10 [INFO] [stderr] Checking xxhash-rust v0.8.15 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking humantime v2.2.0 [INFO] [stderr] Checking unicode-width v0.2.1 [INFO] [stderr] Compiling serde_json v1.0.141 [INFO] [stderr] Checking ys-kcp v1.2.1 [INFO] [stderr] Checking pem-rfc7468 v0.7.0 [INFO] [stderr] Checking der v0.7.10 [INFO] [stderr] Checking num-integer v0.1.46 [INFO] [stderr] Checking ordered-float v2.10.1 [INFO] [stderr] Checking getrandom v0.3.3 [INFO] [stderr] Checking getrandom v0.2.16 [INFO] [stderr] Checking parking_lot_core v0.9.11 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking signal-hook-registry v1.4.5 [INFO] [stderr] Checking is-terminal v0.4.16 [INFO] [stderr] Checking errno v0.2.8 [INFO] [stderr] Checking console v0.15.11 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_core v0.9.3 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking signature v2.2.0 [INFO] [stderr] Checking num-iter v0.1.45 [INFO] [stderr] Checking regex-automata v0.4.9 [INFO] [stderr] Checking parking_lot v0.12.4 [INFO] [stderr] Checking rand_chacha v0.9.0 [INFO] [stderr] Checking spki v0.7.3 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rand v0.9.2 [INFO] [stderr] Checking pkcs8 v0.10.2 [INFO] [stderr] Checking pkcs1 v0.7.5 [INFO] [stderr] Checking tempfile v3.20.0 [INFO] [stderr] Checking num-bigint-dig v0.8.4 [INFO] [stderr] Checking rsa v0.9.8 [INFO] [stderr] Checking regex v1.11.1 [INFO] [stderr] Checking env_logger v0.10.2 [INFO] [stderr] Checking pretty_env_logger v0.5.0 [INFO] [stderr] Compiling pcap v2.3.0 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling prost-derive v0.14.1 [INFO] [stderr] Compiling thiserror-impl v2.0.12 [INFO] [stderr] Compiling miette-derive v7.6.0 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling futures-macro v0.3.31 [INFO] [stderr] Compiling thiserror-impl v1.0.69 [INFO] [stderr] Compiling serde_repr v0.1.20 [INFO] [stderr] Checking tokio v1.47.0 [INFO] [stderr] Compiling logos-derive v0.15.0 [INFO] [stderr] Checking thiserror v1.0.69 [INFO] [stderr] Checking dialoguer v0.11.0 [INFO] [stderr] Checking futures-util v0.3.31 [INFO] [stderr] Checking logos v0.15.0 [INFO] [stderr] Checking prost v0.14.1 [INFO] [stderr] Checking miette v7.6.0 [INFO] [stderr] Checking thiserror v2.0.12 [INFO] [stderr] Checking tungstenite v0.27.0 [INFO] [stderr] Checking prost-types v0.14.1 [INFO] [stderr] Checking serde v1.0.219 [INFO] [stderr] Checking protox-parse v0.9.0 [INFO] [stderr] Checking serde-value v0.7.0 [INFO] [stderr] Checking protoshark v2.0.0 [INFO] [stderr] Checking tokio-tungstenite v0.27.0 [INFO] [stderr] Checking ys-sniffer v0.2.4 [INFO] [stderr] Checking prost-reflect v0.16.0 [INFO] [stderr] Checking protox v0.9.0 [INFO] [stderr] Checking sniffer-tool v0.1.1 (/opt/rustwide/workdir) [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/device.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `.into_iter()` call is equivalent to `.iter()` and will not consume the `Vec` [INFO] [stdout] --> src/device.rs:27:14 [INFO] [stdout] | [INFO] [stdout] 27 | .into_iter() [INFO] [stdout] | ^^^^^^^^^ help: call directly: `iter` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stdout] = note: `#[warn(clippy::into_iter_on_ref)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/console.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 86 | match args.get(0).map(String::as_str) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/console.rs:86:19 [INFO] [stdout] | [INFO] [stdout] 86 | match args.get(0).map(String::as_str) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/console.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | match args.get(0).map(String::as_str) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `args.get(0)` [INFO] [stdout] --> src/console.rs:137:19 [INFO] [stdout] | [INFO] [stdout] 137 | match args.get(0).map(String::as_str) { [INFO] [stdout] | ^^^^^^^^^^^ help: try: `args.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/settings.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into for String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From for DisplayType { [INFO] [stdout] 13 ~ fn from(val: String) -> Self { [INFO] [stdout] 14 ~ match val.to_lowercase().as_str() { [INFO] [stdout] 15 | "all" => DisplayType::All, [INFO] [stdout] ... [INFO] [stdout] 18 | _ => { [INFO] [stdout] 19 ~ warn!("Unknown display type: {}", val); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true [INFO] [stdout] --> src/settings.rs:12:1 [INFO] [stdout] | [INFO] [stdout] 12 | impl Into for String { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into [INFO] [stdout] = note: `#[warn(clippy::from_over_into)]` on by default [INFO] [stdout] help: replace the `Into` implementation with `From` [INFO] [stdout] | [INFO] [stdout] 12 ~ impl From for DisplayType { [INFO] [stdout] 13 ~ fn from(val: String) -> Self { [INFO] [stdout] 14 ~ match val.to_lowercase().as_str() { [INFO] [stdout] 15 | "all" => DisplayType::All, [INFO] [stdout] ... [INFO] [stdout] 18 | _ => { [INFO] [stdout] 19 ~ warn!("Unknown display type: {}", val); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:16:61 [INFO] [stdout] | [INFO] [stdout] 16 | pub static START_TIME: LazyLock = LazyLock::new(|| SystemTime::now()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SystemTime::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !std::env::var("RUST_LOG").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RUST_LOG").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant closure [INFO] [stdout] --> src/main.rs:16:61 [INFO] [stdout] | [INFO] [stdout] 16 | pub static START_TIME: LazyLock = LazyLock::new(|| SystemTime::now()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: replace the closure with the associated function itself: `SystemTime::now` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stdout] = note: `#[warn(clippy::redundant_closure)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:21:8 [INFO] [stdout] | [INFO] [stdout] 21 | if !std::env::var("RUST_LOG").is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `std::env::var("RUST_LOG").is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 22.92s [INFO] [stderr] warning: the following packages contain code that will be rejected by a future version of Rust: num-bigint-dig v0.8.4 [INFO] [stderr] note: to see what the problems were, use the option `--future-incompat-report`, or run `cargo report future-incompatibilities --id 3` [INFO] running `Command { std: "docker" "inspect" "998c5fd6fd14d61bc9ef420a36be5922e149f813eea469331be34b4bd172ce5b", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "998c5fd6fd14d61bc9ef420a36be5922e149f813eea469331be34b4bd172ce5b", kill_on_drop: false }` [INFO] [stdout] 998c5fd6fd14d61bc9ef420a36be5922e149f813eea469331be34b4bd172ce5b