[INFO] cloning repository https://github.com/yousef452/FunLang [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/yousef452/FunLang" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyousef452%2FFunLang", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyousef452%2FFunLang'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 9abc3ed39ee33b73a88750ef43beaf80a159509d [INFO] linting yousef452/FunLang against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyousef452%2FFunLang" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/yousef452/FunLang [INFO] finished tweaking git repo https://github.com/yousef452/FunLang [INFO] tweaked toml for git repo https://github.com/yousef452/FunLang written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/yousef452/FunLang on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/yousef452/FunLang already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 28d8f971da7903f5b292eac9a7d200f9709e91478795031ad6484814d870f63a [INFO] running `Command { std: "docker" "start" "-a" "28d8f971da7903f5b292eac9a7d200f9709e91478795031ad6484814d870f63a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "28d8f971da7903f5b292eac9a7d200f9709e91478795031ad6484814d870f63a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "28d8f971da7903f5b292eac9a7d200f9709e91478795031ad6484814d870f63a", kill_on_drop: false }` [INFO] [stdout] 28d8f971da7903f5b292eac9a7d200f9709e91478795031ad6484814d870f63a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2c539baa037e83bac7ab72cf6d895cc9cb0a2c7c7b29d2fbec687e14972a6945 [INFO] running `Command { std: "docker" "start" "-a" "2c539baa037e83bac7ab72cf6d895cc9cb0a2c7c7b29d2fbec687e14972a6945", kill_on_drop: false }` [INFO] [stderr] Compiling num-traits v0.2.19 [INFO] [stderr] Checking ordered-float v5.0.0 [INFO] [stderr] Checking fun_lang v0.1.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: name `PRINT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | PRINT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Print` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MULT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MULT, // multiple * [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mult` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MIN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | MIN, //minus - [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Min` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIV` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | DIV, //divided / [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Div` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLUS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | PLUS, // plus + [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Plus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MOD` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | MOD, // modulus % [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mod` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | STRING, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | INT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | FLOAT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | LET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Let` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | IDENTIFIER, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EQUALS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | EQUALS, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Equals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEM` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | SEM, //semicolon [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMA` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | COMMA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAIN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | MAIN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Main` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FUN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | FUN, // function [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fun` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FOR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | FOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `For` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ELSE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | ELSE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Else` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ELF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | ELF, // else if [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Elf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHILE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | WHILE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `While` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | EOF [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | INT(i32), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | FLOAT(OrderedFloat), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | STRING(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | IDENTIFIER(String), [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | NONE [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return String::new(); [INFO] [stdout] 114 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] 128 + self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:128:53 [INFO] [stdout] | [INFO] [stdout] 128 | return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:206:24 [INFO] [stdout] | [INFO] [stdout] 206 | } else if self.current_char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 209 | while self.current_char.is_digit(10) || self.current_char == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | if alph == String::from("print") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"print"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:242:33 [INFO] [stdout] | [INFO] [stdout] 242 | else if alph == String::from("let") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"let"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 245 | else if alph == String::from("main") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"main"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:248:33 [INFO] [stdout] | [INFO] [stdout] 248 | else if alph == String::from("fun") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"fun"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 251 | else if alph == String::from("int") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"int"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:254:33 [INFO] [stdout] | [INFO] [stdout] 254 | else if alph == String::from("float") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"float"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:257:33 [INFO] [stdout] | [INFO] [stdout] 257 | else if alph == String::from("string") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"string"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:260:33 [INFO] [stdout] | [INFO] [stdout] 260 | else if alph == String::from("for") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"for"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:263:33 [INFO] [stdout] | [INFO] [stdout] 263 | else if alph == String::from("if") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"if"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:266:33 [INFO] [stdout] | [INFO] [stdout] 266 | else if alph == String::from("elf") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"elf"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:269:33 [INFO] [stdout] | [INFO] [stdout] 269 | else if alph == String::from("else") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"else"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:272:33 [INFO] [stdout] | [INFO] [stdout] 272 | else if alph == String::from("while") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"while"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `toks.get(0)` [INFO] [stdout] --> src/paser.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | let current_tok = toks.get(0) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `toks.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/paser.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(args); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(args); [INFO] [stdout] 176 + Ok(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/paser.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return Box::new(MainFuncNode::new(nodes)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Box::new(MainFuncNode::new(nodes)); [INFO] [stdout] 187 + Box::new(MainFuncNode::new(nodes)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/paser.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | if let Ok(_) = self.expect(TokenType::Annotation) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if self.expect(TokenType::Annotation).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/paser.rs:246:24 [INFO] [stdout] | [INFO] [stdout] 246 | if let Ok(_) = self.expect(TokenType::EQUALS) { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if self.expect(TokenType::EQUALS).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nodes.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if left.is_number() == !right.is_number() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.is_number() != right.is_number()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()); [INFO] [stdout] 49 + format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return match self.get_type() { [INFO] [stdout] 75 | | TokenType::INT => "int", [INFO] [stdout] 76 | | TokenType::FLOAT => "float", [INFO] [stdout] 77 | | TokenType::STRING => "char*", [INFO] [stdout] 78 | | _ => "int", [INFO] [stdout] 79 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ match self.get_type() { [INFO] [stdout] 75 + TokenType::INT => "int", [INFO] [stdout] 76 + TokenType::FLOAT => "float", [INFO] [stdout] 77 + TokenType::STRING => "char*", [INFO] [stdout] 78 + _ => "int", [INFO] [stdout] 79 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return format!("{}",self.token.extract_num().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return format!("{}",self.token.extract_num().unwrap()); [INFO] [stdout] 102 + format!("{}",self.token.extract_num().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return "%d".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return "%d".to_string(); [INFO] [stdout] 111 + "%d".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return self.token.tok_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return self.token.tok_type; [INFO] [stdout] 117 + self.token.tok_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / return match self.get_type() { [INFO] [stdout] 122 | | TokenType::INT => "int", [INFO] [stdout] 123 | | TokenType::FLOAT => "float", [INFO] [stdout] 124 | | TokenType::STRING => "char*", [INFO] [stdout] 125 | | _ => "int", [INFO] [stdout] 126 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ match self.get_type() { [INFO] [stdout] 122 + TokenType::INT => "int", [INFO] [stdout] 123 + TokenType::FLOAT => "float", [INFO] [stdout] 124 + TokenType::STRING => "char*", [INFO] [stdout] 125 + _ => "int", [INFO] [stdout] 126 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return format!("\"{}\"",self.token.extract_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return format!("\"{}\"",self.token.extract_str().unwrap()); [INFO] [stdout] 151 + format!("\"{}\"",self.token.extract_str().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return "%s".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return "%s".to_string(); [INFO] [stdout] 154 + "%s".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | return TokenType::STRING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return TokenType::STRING; [INFO] [stdout] 160 + TokenType::STRING [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / return match self.get_type() { [INFO] [stdout] 165 | | TokenType::INT => "int", [INFO] [stdout] 166 | | TokenType::FLOAT => "float", [INFO] [stdout] 167 | | TokenType::STRING => "char*", [INFO] [stdout] 168 | | _ => "int", [INFO] [stdout] 169 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 ~ match self.get_type() { [INFO] [stdout] 165 + TokenType::INT => "int", [INFO] [stdout] 166 + TokenType::FLOAT => "float", [INFO] [stdout] 167 + TokenType::STRING => "char*", [INFO] [stdout] 168 + _ => "int", [INFO] [stdout] 169 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/nodes.rs:242:17 [INFO] [stdout] | [INFO] [stdout] 242 | format!("{}", arg_node.generate()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `arg_node.generate().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / return match self.get_type() { [INFO] [stdout] 263 | | TokenType::INT => "int", [INFO] [stdout] 264 | | TokenType::FLOAT => "float", [INFO] [stdout] 265 | | TokenType::STRING => "char*", [INFO] [stdout] 266 | | _ => "int", [INFO] [stdout] 267 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 ~ match self.get_type() { [INFO] [stdout] 263 + TokenType::INT => "int", [INFO] [stdout] 264 + TokenType::FLOAT => "float", [INFO] [stdout] 265 + TokenType::STRING => "char*", [INFO] [stdout] 266 + _ => "int", [INFO] [stdout] 267 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | / ... return match self.declared_type.unwrap() { [INFO] [stdout] 328 | | ... TokenType::STRING => format!("char* {} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.gene... [INFO] [stdout] 329 | | ... TokenType::FLOAT => format!("float* {} = (float*) GC_MALLOC(sizeof(float));\n*{} = {};\n",name_str,name_str,self.node.... [INFO] [stdout] 330 | | ... TokenType::INT => format!("int* {} = (int*) GC_MALLOC(sizeof(int));\n*{} = {};\n",name_str,name_str,self.node.generate... [INFO] [stdout] ... | [INFO] [stdout] 334 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 ~ match self.declared_type.unwrap() { [INFO] [stdout] 328 + TokenType::STRING => format!("char* {} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),name_str,self.node.generate()), [INFO] [stdout] 329 + TokenType::FLOAT => format!("float* {} = (float*) GC_MALLOC(sizeof(float));\n*{} = {};\n",name_str,name_str,self.node.generate()), [INFO] [stdout] 330 + TokenType::INT => format!("int* {} = (int*) GC_MALLOC(sizeof(int));\n*{} = {};\n",name_str,name_str,self.node.generate()), [INFO] [stdout] 331 + _ => { [INFO] [stdout] 332 + panic!("Error : unknow type") [INFO] [stdout] 333 + } [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/nodes.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 318 | if self.declared_type == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.declared_type.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | / return match self.get_type() { [INFO] [stdout] 350 | | TokenType::INT => "int", [INFO] [stdout] 351 | | TokenType::FLOAT => "float", [INFO] [stdout] 352 | | TokenType::STRING => "char*", [INFO] [stdout] 353 | | _ => "int", [INFO] [stdout] 354 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 ~ match self.get_type() { [INFO] [stdout] 350 + TokenType::INT => "int", [INFO] [stdout] 351 + TokenType::FLOAT => "float", [INFO] [stdout] 352 + TokenType::STRING => "char*", [INFO] [stdout] 353 + _ => "int", [INFO] [stdout] 354 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | / ... return match self.node.get_type() { [INFO] [stdout] 391 | | ... TokenType::STRING => format!("{} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),... [INFO] [stdout] 392 | | ... _ => format!("*{} = {};\n",name_str,self.node.generate()) [INFO] [stdout] 393 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 ~ match self.node.get_type() { [INFO] [stdout] 391 + TokenType::STRING => format!("{} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),name_str,self.node.generate()), [INFO] [stdout] 392 + _ => format!("*{} = {};\n",name_str,self.node.generate()) [INFO] [stdout] 393 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | / return match self.get_type() { [INFO] [stdout] 407 | | TokenType::INT => "int", [INFO] [stdout] 408 | | TokenType::FLOAT => "float", [INFO] [stdout] 409 | | TokenType::STRING => "char*", [INFO] [stdout] 410 | | _ => "int", [INFO] [stdout] 411 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 ~ match self.get_type() { [INFO] [stdout] 407 + TokenType::INT => "int", [INFO] [stdout] 408 + TokenType::FLOAT => "float", [INFO] [stdout] 409 + TokenType::STRING => "char*", [INFO] [stdout] 410 + _ => "int", [INFO] [stdout] 411 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | return format!("{}{}",self.op_tok.ops_str(),self.node.generate()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return format!("{}{}",self.op_tok.ops_str(),self.node.generate()); [INFO] [stdout] 424 + format!("{}{}",self.op_tok.ops_str(),self.node.generate()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | return self.node.c_format(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return self.node.c_format(); [INFO] [stdout] 427 + self.node.c_format() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | / return match self.get_type() { [INFO] [stdout] 440 | | TokenType::INT => "int", [INFO] [stdout] 441 | | TokenType::FLOAT => "float", [INFO] [stdout] 442 | | TokenType::STRING => "char*", [INFO] [stdout] 443 | | _ => "int", [INFO] [stdout] 444 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 ~ match self.get_type() { [INFO] [stdout] 440 + TokenType::INT => "int", [INFO] [stdout] 441 + TokenType::FLOAT => "float", [INFO] [stdout] 442 + TokenType::STRING => "char*", [INFO] [stdout] 443 + _ => "int", [INFO] [stdout] 444 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/nodes.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 472 | return format!("{}",self.name.extract_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.name.extract_str().unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | / return match self.get_type() { [INFO] [stdout] 480 | | TokenType::INT => "%i", [INFO] [stdout] 481 | | TokenType::FLOAT => "%f", [INFO] [stdout] 482 | | TokenType::STRING => "%s", [INFO] [stdout] 483 | | _ => "int", [INFO] [stdout] 484 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 ~ match self.get_type() { [INFO] [stdout] 480 + TokenType::INT => "%i", [INFO] [stdout] 481 + TokenType::FLOAT => "%f", [INFO] [stdout] 482 + TokenType::STRING => "%s", [INFO] [stdout] 483 + _ => "int", [INFO] [stdout] 484 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:492:9 [INFO] [stdout] | [INFO] [stdout] 492 | return self.var_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 492 - return self.var_type; [INFO] [stdout] 492 + self.var_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | / return match self.get_type() { [INFO] [stdout] 497 | | TokenType::INT => "int", [INFO] [stdout] 498 | | TokenType::FLOAT => "float", [INFO] [stdout] 499 | | TokenType::STRING => "char*", [INFO] [stdout] 500 | | _ => "int", [INFO] [stdout] 501 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 496 ~ match self.get_type() { [INFO] [stdout] 497 + TokenType::INT => "int", [INFO] [stdout] 498 + TokenType::FLOAT => "float", [INFO] [stdout] 499 + TokenType::STRING => "char*", [INFO] [stdout] 500 + _ => "int", [INFO] [stdout] 501 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | return format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 531 - return format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge); [INFO] [stdout] 531 + format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | / return match self.get_type() { [INFO] [stdout] 536 | | TokenType::INT => "%i", [INFO] [stdout] 537 | | TokenType::FLOAT => "%f", [INFO] [stdout] 538 | | TokenType::STRING => "%s", [INFO] [stdout] 539 | | _ => "int", [INFO] [stdout] 540 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 ~ match self.get_type() { [INFO] [stdout] 536 + TokenType::INT => "%i", [INFO] [stdout] 537 + TokenType::FLOAT => "%f", [INFO] [stdout] 538 + TokenType::STRING => "%s", [INFO] [stdout] 539 + _ => "int", [INFO] [stdout] 540 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 548 | return TokenType::INT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 548 - return TokenType::INT; [INFO] [stdout] 548 + TokenType::INT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | / return match self.get_type() { [INFO] [stdout] 553 | | TokenType::INT => "int", [INFO] [stdout] 554 | | TokenType::FLOAT => "float", [INFO] [stdout] 555 | | TokenType::STRING => "char*", [INFO] [stdout] 556 | | _ => "int", [INFO] [stdout] 557 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 ~ match self.get_type() { [INFO] [stdout] 553 + TokenType::INT => "int", [INFO] [stdout] 554 + TokenType::FLOAT => "float", [INFO] [stdout] 555 + TokenType::STRING => "char*", [INFO] [stdout] 556 + _ => "int", [INFO] [stdout] 557 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nodes.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `step.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `step` after checking its variant with `is_none` [INFO] [stdout] --> src/nodes.rs:578:16 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 578 | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `step` after checking its variant with `is_none` [INFO] [stdout] --> src/nodes.rs:579:46 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 578 | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nodes.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 577 | / if !step.is_none(){ [INFO] [stdout] 578 | | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] 580 | | } [INFO] [stdout] 581 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 577 ~ if !step.is_none() [INFO] [stdout] 578 ~ && step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] 580 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:620:9 [INFO] [stdout] | [INFO] [stdout] 620 | / return match self.get_type() { [INFO] [stdout] 621 | | TokenType::INT => "%i", [INFO] [stdout] 622 | | TokenType::FLOAT => "%f", [INFO] [stdout] 623 | | TokenType::STRING => "%s", [INFO] [stdout] 624 | | _ => "int", [INFO] [stdout] 625 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 ~ match self.get_type() { [INFO] [stdout] 621 + TokenType::INT => "%i", [INFO] [stdout] 622 + TokenType::FLOAT => "%f", [INFO] [stdout] 623 + TokenType::STRING => "%s", [INFO] [stdout] 624 + _ => "int", [INFO] [stdout] 625 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:633:9 [INFO] [stdout] | [INFO] [stdout] 633 | return TokenType::NONE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 633 - return TokenType::NONE; [INFO] [stdout] 633 + TokenType::NONE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:637:9 [INFO] [stdout] | [INFO] [stdout] 637 | / return match self.get_type() { [INFO] [stdout] 638 | | TokenType::INT => "int", [INFO] [stdout] 639 | | TokenType::FLOAT => "float", [INFO] [stdout] 640 | | TokenType::STRING => "char*", [INFO] [stdout] 641 | | _ => "int", [INFO] [stdout] 642 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 637 ~ match self.get_type() { [INFO] [stdout] 638 + TokenType::INT => "int", [INFO] [stdout] 639 + TokenType::FLOAT => "float", [INFO] [stdout] 640 + TokenType::STRING => "char*", [INFO] [stdout] 641 + _ => "int", [INFO] [stdout] 642 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:713:9 [INFO] [stdout] | [INFO] [stdout] 713 | / return match self.get_type() { [INFO] [stdout] 714 | | TokenType::INT => "int", [INFO] [stdout] 715 | | TokenType::FLOAT => "float", [INFO] [stdout] 716 | | TokenType::STRING => "char*", [INFO] [stdout] 717 | | _ => "int", [INFO] [stdout] 718 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 713 ~ match self.get_type() { [INFO] [stdout] 714 + TokenType::INT => "int", [INFO] [stdout] 715 + TokenType::FLOAT => "float", [INFO] [stdout] 716 + TokenType::STRING => "char*", [INFO] [stdout] 717 + _ => "int", [INFO] [stdout] 718 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:766:9 [INFO] [stdout] | [INFO] [stdout] 766 | / return match self.get_type() { [INFO] [stdout] 767 | | TokenType::INT => "int", [INFO] [stdout] 768 | | TokenType::FLOAT => "float", [INFO] [stdout] 769 | | TokenType::STRING => "char*", [INFO] [stdout] 770 | | _ => "int", [INFO] [stdout] 771 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 766 ~ match self.get_type() { [INFO] [stdout] 767 + TokenType::INT => "int", [INFO] [stdout] 768 + TokenType::FLOAT => "float", [INFO] [stdout] 769 + TokenType::STRING => "char*", [INFO] [stdout] 770 + _ => "int", [INFO] [stdout] 771 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PRINT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:6:5 [INFO] [stdout] | [INFO] [stdout] 6 | PRINT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Print` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] = note: `#[warn(clippy::upper_case_acronyms)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MULT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:8:5 [INFO] [stdout] | [INFO] [stdout] 8 | MULT, // multiple * [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Mult` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MIN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:9:5 [INFO] [stdout] | [INFO] [stdout] 9 | MIN, //minus - [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Min` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `DIV` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:10:5 [INFO] [stdout] | [INFO] [stdout] 10 | DIV, //divided / [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Div` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `PLUS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:11:5 [INFO] [stdout] | [INFO] [stdout] 11 | PLUS, // plus + [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Plus` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MOD` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:12:5 [INFO] [stdout] | [INFO] [stdout] 12 | MOD, // modulus % [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Mod` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:19:5 [INFO] [stdout] | [INFO] [stdout] 19 | STRING, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:20:5 [INFO] [stdout] | [INFO] [stdout] 20 | INT, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:21:5 [INFO] [stdout] | [INFO] [stdout] 21 | FLOAT, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `LET` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:23:5 [INFO] [stdout] | [INFO] [stdout] 23 | LET, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Let` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:24:5 [INFO] [stdout] | [INFO] [stdout] 24 | IDENTIFIER, [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EQUALS` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:25:5 [INFO] [stdout] | [INFO] [stdout] 25 | EQUALS, [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Equals` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `SEM` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:27:5 [INFO] [stdout] | [INFO] [stdout] 27 | SEM, //semicolon [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Sem` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `COMMA` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:28:5 [INFO] [stdout] | [INFO] [stdout] 28 | COMMA, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Comma` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `MAIN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:36:5 [INFO] [stdout] | [INFO] [stdout] 36 | MAIN, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Main` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FUN` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:37:5 [INFO] [stdout] | [INFO] [stdout] 37 | FUN, // function [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Fun` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FOR` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:39:5 [INFO] [stdout] | [INFO] [stdout] 39 | FOR, [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `For` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ELSE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:44:5 [INFO] [stdout] | [INFO] [stdout] 44 | ELSE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `Else` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `ELF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:45:5 [INFO] [stdout] | [INFO] [stdout] 45 | ELF, // else if [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Elf` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `WHILE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:46:5 [INFO] [stdout] | [INFO] [stdout] 46 | WHILE, [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `While` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:48:5 [INFO] [stdout] | [INFO] [stdout] 48 | NONE, [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `EOF` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:49:5 [INFO] [stdout] | [INFO] [stdout] 49 | EOF [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter (notice the capitalization): `Eof` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `INT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:54:5 [INFO] [stdout] | [INFO] [stdout] 54 | INT(i32), [INFO] [stdout] | ^^^ help: consider making the acronym lowercase, except the initial letter: `Int` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `FLOAT` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:55:5 [INFO] [stdout] | [INFO] [stdout] 55 | FLOAT(OrderedFloat), [INFO] [stdout] | ^^^^^ help: consider making the acronym lowercase, except the initial letter: `Float` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `STRING` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:56:5 [INFO] [stdout] | [INFO] [stdout] 56 | STRING(String), [INFO] [stdout] | ^^^^^^ help: consider making the acronym lowercase, except the initial letter: `String` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `IDENTIFIER` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:57:5 [INFO] [stdout] | [INFO] [stdout] 57 | IDENTIFIER(String), [INFO] [stdout] | ^^^^^^^^^^ help: consider making the acronym lowercase, except the initial letter: `Identifier` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: name `NONE` contains a capitalized acronym [INFO] [stdout] --> src/lexer.rs:58:5 [INFO] [stdout] | [INFO] [stdout] 58 | NONE [INFO] [stdout] | ^^^^ help: consider making the acronym lowercase, except the initial letter: `None` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#upper_case_acronyms [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:114:9 [INFO] [stdout] | [INFO] [stdout] 114 | return String::new(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 114 - return String::new(); [INFO] [stdout] 114 + String::new() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/lexer.rs:128:9 [INFO] [stdout] | [INFO] [stdout] 128 | return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 128 - return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] 128 + self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_' [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:128:53 [INFO] [stdout] | [INFO] [stdout] 128 | return self.current_char.is_alphabetic() || self.current_char.is_digit(10) || self.current_char == '_'; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] = note: `#[warn(clippy::is_digit_ascii_radix)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:206:24 [INFO] [stdout] | [INFO] [stdout] 206 | } else if self.current_char.is_digit(10) { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: use of `char::is_digit` with literal radix of 10 [INFO] [stdout] --> src/lexer.rs:209:23 [INFO] [stdout] | [INFO] [stdout] 209 | while self.current_char.is_digit(10) || self.current_char == '.' { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `self.current_char.is_ascii_digit()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#is_digit_ascii_radix [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:239:28 [INFO] [stdout] | [INFO] [stdout] 239 | if alph == String::from("print") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"print"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] = note: `#[warn(clippy::cmp_owned)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:242:33 [INFO] [stdout] | [INFO] [stdout] 242 | else if alph == String::from("let") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"let"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:245:33 [INFO] [stdout] | [INFO] [stdout] 245 | else if alph == String::from("main") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"main"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:248:33 [INFO] [stdout] | [INFO] [stdout] 248 | else if alph == String::from("fun") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"fun"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:251:33 [INFO] [stdout] | [INFO] [stdout] 251 | else if alph == String::from("int") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"int"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:254:33 [INFO] [stdout] | [INFO] [stdout] 254 | else if alph == String::from("float") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"float"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:257:33 [INFO] [stdout] | [INFO] [stdout] 257 | else if alph == String::from("string") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `"string"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:260:33 [INFO] [stdout] | [INFO] [stdout] 260 | else if alph == String::from("for") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"for"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:263:33 [INFO] [stdout] | [INFO] [stdout] 263 | else if alph == String::from("if") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^ help: try: `"if"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:266:33 [INFO] [stdout] | [INFO] [stdout] 266 | else if alph == String::from("elf") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `"elf"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:269:33 [INFO] [stdout] | [INFO] [stdout] 269 | else if alph == String::from("else") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: try: `"else"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this creates an owned instance just for comparison [INFO] [stdout] --> src/lexer.rs:272:33 [INFO] [stdout] | [INFO] [stdout] 272 | else if alph == String::from("while") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `"while"` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cmp_owned [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: accessing first element with `toks.get(0)` [INFO] [stdout] --> src/paser.rs:22:27 [INFO] [stdout] | [INFO] [stdout] 22 | let current_tok = toks.get(0) [INFO] [stdout] | ^^^^^^^^^^^ help: try: `toks.first()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_first [INFO] [stdout] = note: `#[warn(clippy::get_first)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/paser.rs:176:9 [INFO] [stdout] | [INFO] [stdout] 176 | return Ok(args); [INFO] [stdout] | ^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 176 - return Ok(args); [INFO] [stdout] 176 + Ok(args) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/paser.rs:187:9 [INFO] [stdout] | [INFO] [stdout] 187 | return Box::new(MainFuncNode::new(nodes)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 187 - return Box::new(MainFuncNode::new(nodes)); [INFO] [stdout] 187 + Box::new(MainFuncNode::new(nodes)) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/paser.rs:209:24 [INFO] [stdout] | [INFO] [stdout] 209 | if let Ok(_) = self.expect(TokenType::Annotation) { [INFO] [stdout] | -------^^^^^------------------------------------- help: try: `if self.expect(TokenType::Annotation).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] = note: `#[warn(clippy::redundant_pattern_matching)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant pattern matching, consider using `is_ok()` [INFO] [stdout] --> src/paser.rs:246:24 [INFO] [stdout] | [INFO] [stdout] 246 | if let Ok(_) = self.expect(TokenType::EQUALS) { [INFO] [stdout] | -------^^^^^--------------------------------- help: try: `if self.expect(TokenType::EQUALS).is_ok()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nodes.rs:33:12 [INFO] [stdout] | [INFO] [stdout] 33 | if left.is_number() == !right.is_number() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `left.is_number() != right.is_number()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:49:9 [INFO] [stdout] | [INFO] [stdout] 49 | return format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 49 - return format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()); [INFO] [stdout] 49 + format!("{}{}{}",self.left.generate(),self.bin_op.ops_str(),self.right.generate()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:74:9 [INFO] [stdout] | [INFO] [stdout] 74 | / return match self.get_type() { [INFO] [stdout] 75 | | TokenType::INT => "int", [INFO] [stdout] 76 | | TokenType::FLOAT => "float", [INFO] [stdout] 77 | | TokenType::STRING => "char*", [INFO] [stdout] 78 | | _ => "int", [INFO] [stdout] 79 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 74 ~ match self.get_type() { [INFO] [stdout] 75 + TokenType::INT => "int", [INFO] [stdout] 76 + TokenType::FLOAT => "float", [INFO] [stdout] 77 + TokenType::STRING => "char*", [INFO] [stdout] 78 + _ => "int", [INFO] [stdout] 79 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:102:9 [INFO] [stdout] | [INFO] [stdout] 102 | return format!("{}",self.token.extract_num().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 102 - return format!("{}",self.token.extract_num().unwrap()); [INFO] [stdout] 102 + format!("{}",self.token.extract_num().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:111:9 [INFO] [stdout] | [INFO] [stdout] 111 | return "%d".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 111 - return "%d".to_string(); [INFO] [stdout] 111 + "%d".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:117:9 [INFO] [stdout] | [INFO] [stdout] 117 | return self.token.tok_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 117 - return self.token.tok_type; [INFO] [stdout] 117 + self.token.tok_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:121:9 [INFO] [stdout] | [INFO] [stdout] 121 | / return match self.get_type() { [INFO] [stdout] 122 | | TokenType::INT => "int", [INFO] [stdout] 123 | | TokenType::FLOAT => "float", [INFO] [stdout] 124 | | TokenType::STRING => "char*", [INFO] [stdout] 125 | | _ => "int", [INFO] [stdout] 126 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 121 ~ match self.get_type() { [INFO] [stdout] 122 + TokenType::INT => "int", [INFO] [stdout] 123 + TokenType::FLOAT => "float", [INFO] [stdout] 124 + TokenType::STRING => "char*", [INFO] [stdout] 125 + _ => "int", [INFO] [stdout] 126 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:151:9 [INFO] [stdout] | [INFO] [stdout] 151 | return format!("\"{}\"",self.token.extract_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 151 - return format!("\"{}\"",self.token.extract_str().unwrap()); [INFO] [stdout] 151 + format!("\"{}\"",self.token.extract_str().unwrap()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:154:9 [INFO] [stdout] | [INFO] [stdout] 154 | return "%s".to_string(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 154 - return "%s".to_string(); [INFO] [stdout] 154 + "%s".to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:160:9 [INFO] [stdout] | [INFO] [stdout] 160 | return TokenType::STRING; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 160 - return TokenType::STRING; [INFO] [stdout] 160 + TokenType::STRING [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:164:9 [INFO] [stdout] | [INFO] [stdout] 164 | / return match self.get_type() { [INFO] [stdout] 165 | | TokenType::INT => "int", [INFO] [stdout] 166 | | TokenType::FLOAT => "float", [INFO] [stdout] 167 | | TokenType::STRING => "char*", [INFO] [stdout] 168 | | _ => "int", [INFO] [stdout] 169 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 164 ~ match self.get_type() { [INFO] [stdout] 165 + TokenType::INT => "int", [INFO] [stdout] 166 + TokenType::FLOAT => "float", [INFO] [stdout] 167 + TokenType::STRING => "char*", [INFO] [stdout] 168 + _ => "int", [INFO] [stdout] 169 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/nodes.rs:242:17 [INFO] [stdout] | [INFO] [stdout] 242 | format!("{}", arg_node.generate()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `arg_node.generate().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] = note: `#[warn(clippy::useless_format)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:262:9 [INFO] [stdout] | [INFO] [stdout] 262 | / return match self.get_type() { [INFO] [stdout] 263 | | TokenType::INT => "int", [INFO] [stdout] 264 | | TokenType::FLOAT => "float", [INFO] [stdout] 265 | | TokenType::STRING => "char*", [INFO] [stdout] 266 | | _ => "int", [INFO] [stdout] 267 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 262 ~ match self.get_type() { [INFO] [stdout] 263 + TokenType::INT => "int", [INFO] [stdout] 264 + TokenType::FLOAT => "float", [INFO] [stdout] 265 + TokenType::STRING => "char*", [INFO] [stdout] 266 + _ => "int", [INFO] [stdout] 267 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:327:9 [INFO] [stdout] | [INFO] [stdout] 327 | / ... return match self.declared_type.unwrap() { [INFO] [stdout] 328 | | ... TokenType::STRING => format!("char* {} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.gene... [INFO] [stdout] 329 | | ... TokenType::FLOAT => format!("float* {} = (float*) GC_MALLOC(sizeof(float));\n*{} = {};\n",name_str,name_str,self.node.... [INFO] [stdout] 330 | | ... TokenType::INT => format!("int* {} = (int*) GC_MALLOC(sizeof(int));\n*{} = {};\n",name_str,name_str,self.node.generate... [INFO] [stdout] ... | [INFO] [stdout] 334 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 327 ~ match self.declared_type.unwrap() { [INFO] [stdout] 328 + TokenType::STRING => format!("char* {} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),name_str,self.node.generate()), [INFO] [stdout] 329 + TokenType::FLOAT => format!("float* {} = (float*) GC_MALLOC(sizeof(float));\n*{} = {};\n",name_str,name_str,self.node.generate()), [INFO] [stdout] 330 + TokenType::INT => format!("int* {} = (int*) GC_MALLOC(sizeof(int));\n*{} = {};\n",name_str,name_str,self.node.generate()), [INFO] [stdout] 331 + _ => { [INFO] [stdout] 332 + panic!("Error : unknow type") [INFO] [stdout] 333 + } [INFO] [stdout] 334 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: binary comparison to literal `Option::None` [INFO] [stdout] --> src/nodes.rs:318:12 [INFO] [stdout] | [INFO] [stdout] 318 | if self.declared_type == None { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: use `Option::is_none()` instead: `self.declared_type.is_none()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#partialeq_to_none [INFO] [stdout] = note: `#[warn(clippy::partialeq_to_none)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:349:9 [INFO] [stdout] | [INFO] [stdout] 349 | / return match self.get_type() { [INFO] [stdout] 350 | | TokenType::INT => "int", [INFO] [stdout] 351 | | TokenType::FLOAT => "float", [INFO] [stdout] 352 | | TokenType::STRING => "char*", [INFO] [stdout] 353 | | _ => "int", [INFO] [stdout] 354 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 349 ~ match self.get_type() { [INFO] [stdout] 350 + TokenType::INT => "int", [INFO] [stdout] 351 + TokenType::FLOAT => "float", [INFO] [stdout] 352 + TokenType::STRING => "char*", [INFO] [stdout] 353 + _ => "int", [INFO] [stdout] 354 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:390:9 [INFO] [stdout] | [INFO] [stdout] 390 | / ... return match self.node.get_type() { [INFO] [stdout] 391 | | ... TokenType::STRING => format!("{} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),... [INFO] [stdout] 392 | | ... _ => format!("*{} = {};\n",name_str,self.node.generate()) [INFO] [stdout] 393 | | ... }; [INFO] [stdout] | |_______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 390 ~ match self.node.get_type() { [INFO] [stdout] 391 + TokenType::STRING => format!("{} = (char*) GC_MALLOC(strlen({}) + 1);\nstrcpy({}, {});\n",name_str,self.node.generate(),name_str,self.node.generate()), [INFO] [stdout] 392 + _ => format!("*{} = {};\n",name_str,self.node.generate()) [INFO] [stdout] 393 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:406:9 [INFO] [stdout] | [INFO] [stdout] 406 | / return match self.get_type() { [INFO] [stdout] 407 | | TokenType::INT => "int", [INFO] [stdout] 408 | | TokenType::FLOAT => "float", [INFO] [stdout] 409 | | TokenType::STRING => "char*", [INFO] [stdout] 410 | | _ => "int", [INFO] [stdout] 411 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 406 ~ match self.get_type() { [INFO] [stdout] 407 + TokenType::INT => "int", [INFO] [stdout] 408 + TokenType::FLOAT => "float", [INFO] [stdout] 409 + TokenType::STRING => "char*", [INFO] [stdout] 410 + _ => "int", [INFO] [stdout] 411 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:424:9 [INFO] [stdout] | [INFO] [stdout] 424 | return format!("{}{}",self.op_tok.ops_str(),self.node.generate()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 424 - return format!("{}{}",self.op_tok.ops_str(),self.node.generate()); [INFO] [stdout] 424 + format!("{}{}",self.op_tok.ops_str(),self.node.generate()) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:427:9 [INFO] [stdout] | [INFO] [stdout] 427 | return self.node.c_format(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 427 - return self.node.c_format(); [INFO] [stdout] 427 + self.node.c_format() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:439:9 [INFO] [stdout] | [INFO] [stdout] 439 | / return match self.get_type() { [INFO] [stdout] 440 | | TokenType::INT => "int", [INFO] [stdout] 441 | | TokenType::FLOAT => "float", [INFO] [stdout] 442 | | TokenType::STRING => "char*", [INFO] [stdout] 443 | | _ => "int", [INFO] [stdout] 444 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 439 ~ match self.get_type() { [INFO] [stdout] 440 + TokenType::INT => "int", [INFO] [stdout] 441 + TokenType::FLOAT => "float", [INFO] [stdout] 442 + TokenType::STRING => "char*", [INFO] [stdout] 443 + _ => "int", [INFO] [stdout] 444 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: useless use of `format!` [INFO] [stdout] --> src/nodes.rs:472:24 [INFO] [stdout] | [INFO] [stdout] 472 | return format!("{}",self.name.extract_str().unwrap()); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.to_string()`: `self.name.extract_str().unwrap().to_string()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:479:9 [INFO] [stdout] | [INFO] [stdout] 479 | / return match self.get_type() { [INFO] [stdout] 480 | | TokenType::INT => "%i", [INFO] [stdout] 481 | | TokenType::FLOAT => "%f", [INFO] [stdout] 482 | | TokenType::STRING => "%s", [INFO] [stdout] 483 | | _ => "int", [INFO] [stdout] 484 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 479 ~ match self.get_type() { [INFO] [stdout] 480 + TokenType::INT => "%i", [INFO] [stdout] 481 + TokenType::FLOAT => "%f", [INFO] [stdout] 482 + TokenType::STRING => "%s", [INFO] [stdout] 483 + _ => "int", [INFO] [stdout] 484 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:492:9 [INFO] [stdout] | [INFO] [stdout] 492 | return self.var_type; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 492 - return self.var_type; [INFO] [stdout] 492 + self.var_type [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:496:9 [INFO] [stdout] | [INFO] [stdout] 496 | / return match self.get_type() { [INFO] [stdout] 497 | | TokenType::INT => "int", [INFO] [stdout] 498 | | TokenType::FLOAT => "float", [INFO] [stdout] 499 | | TokenType::STRING => "char*", [INFO] [stdout] 500 | | _ => "int", [INFO] [stdout] 501 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 496 ~ match self.get_type() { [INFO] [stdout] 497 + TokenType::INT => "int", [INFO] [stdout] 498 + TokenType::FLOAT => "float", [INFO] [stdout] 499 + TokenType::STRING => "char*", [INFO] [stdout] 500 + _ => "int", [INFO] [stdout] 501 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:531:9 [INFO] [stdout] | [INFO] [stdout] 531 | return format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 531 - return format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge); [INFO] [stdout] 531 + format!("int main() {{\nGC_INIT();\n{}return 0;\n}}\n",ge) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:535:9 [INFO] [stdout] | [INFO] [stdout] 535 | / return match self.get_type() { [INFO] [stdout] 536 | | TokenType::INT => "%i", [INFO] [stdout] 537 | | TokenType::FLOAT => "%f", [INFO] [stdout] 538 | | TokenType::STRING => "%s", [INFO] [stdout] 539 | | _ => "int", [INFO] [stdout] 540 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 535 ~ match self.get_type() { [INFO] [stdout] 536 + TokenType::INT => "%i", [INFO] [stdout] 537 + TokenType::FLOAT => "%f", [INFO] [stdout] 538 + TokenType::STRING => "%s", [INFO] [stdout] 539 + _ => "int", [INFO] [stdout] 540 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:548:9 [INFO] [stdout] | [INFO] [stdout] 548 | return TokenType::INT; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 548 - return TokenType::INT; [INFO] [stdout] 548 + TokenType::INT [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:552:9 [INFO] [stdout] | [INFO] [stdout] 552 | / return match self.get_type() { [INFO] [stdout] 553 | | TokenType::INT => "int", [INFO] [stdout] 554 | | TokenType::FLOAT => "float", [INFO] [stdout] 555 | | TokenType::STRING => "char*", [INFO] [stdout] 556 | | _ => "int", [INFO] [stdout] 557 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 552 ~ match self.get_type() { [INFO] [stdout] 553 + TokenType::INT => "int", [INFO] [stdout] 554 + TokenType::FLOAT => "float", [INFO] [stdout] 555 + TokenType::STRING => "char*", [INFO] [stdout] 556 + _ => "int", [INFO] [stdout] 557 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/nodes.rs:577:12 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try: `step.is_some()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `step` after checking its variant with `is_none` [INFO] [stdout] --> src/nodes.rs:578:16 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 578 | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `step` after checking its variant with `is_none` [INFO] [stdout] --> src/nodes.rs:579:46 [INFO] [stdout] | [INFO] [stdout] 577 | if !step.is_none(){ [INFO] [stdout] | -------------- the check is happening here [INFO] [stdout] 578 | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: try using `if let` or `match` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this `if` statement can be collapsed [INFO] [stdout] --> src/nodes.rs:577:9 [INFO] [stdout] | [INFO] [stdout] 577 | / if !step.is_none(){ [INFO] [stdout] 578 | | if step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] 580 | | } [INFO] [stdout] 581 | | } [INFO] [stdout] | |_________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stdout] = note: `#[warn(clippy::collapsible_if)]` on by default [INFO] [stdout] help: collapse nested if block [INFO] [stdout] | [INFO] [stdout] 577 ~ if !step.is_none() [INFO] [stdout] 578 ~ && step.as_ref().unwrap().get_type() != TokenType::INT { [INFO] [stdout] 579 | panic!("Error : step : {:?}",step.as_ref().unwrap().get_type()) [INFO] [stdout] 580 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:620:9 [INFO] [stdout] | [INFO] [stdout] 620 | / return match self.get_type() { [INFO] [stdout] 621 | | TokenType::INT => "%i", [INFO] [stdout] 622 | | TokenType::FLOAT => "%f", [INFO] [stdout] 623 | | TokenType::STRING => "%s", [INFO] [stdout] 624 | | _ => "int", [INFO] [stdout] 625 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 620 ~ match self.get_type() { [INFO] [stdout] 621 + TokenType::INT => "%i", [INFO] [stdout] 622 + TokenType::FLOAT => "%f", [INFO] [stdout] 623 + TokenType::STRING => "%s", [INFO] [stdout] 624 + _ => "int", [INFO] [stdout] 625 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:633:9 [INFO] [stdout] | [INFO] [stdout] 633 | return TokenType::NONE; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 633 - return TokenType::NONE; [INFO] [stdout] 633 + TokenType::NONE [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:637:9 [INFO] [stdout] | [INFO] [stdout] 637 | / return match self.get_type() { [INFO] [stdout] 638 | | TokenType::INT => "int", [INFO] [stdout] 639 | | TokenType::FLOAT => "float", [INFO] [stdout] 640 | | TokenType::STRING => "char*", [INFO] [stdout] 641 | | _ => "int", [INFO] [stdout] 642 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 637 ~ match self.get_type() { [INFO] [stdout] 638 + TokenType::INT => "int", [INFO] [stdout] 639 + TokenType::FLOAT => "float", [INFO] [stdout] 640 + TokenType::STRING => "char*", [INFO] [stdout] 641 + _ => "int", [INFO] [stdout] 642 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:713:9 [INFO] [stdout] | [INFO] [stdout] 713 | / return match self.get_type() { [INFO] [stdout] 714 | | TokenType::INT => "int", [INFO] [stdout] 715 | | TokenType::FLOAT => "float", [INFO] [stdout] 716 | | TokenType::STRING => "char*", [INFO] [stdout] 717 | | _ => "int", [INFO] [stdout] 718 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 713 ~ match self.get_type() { [INFO] [stdout] 714 + TokenType::INT => "int", [INFO] [stdout] 715 + TokenType::FLOAT => "float", [INFO] [stdout] 716 + TokenType::STRING => "char*", [INFO] [stdout] 717 + _ => "int", [INFO] [stdout] 718 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/nodes.rs:766:9 [INFO] [stdout] | [INFO] [stdout] 766 | / return match self.get_type() { [INFO] [stdout] 767 | | TokenType::INT => "int", [INFO] [stdout] 768 | | TokenType::FLOAT => "float", [INFO] [stdout] 769 | | TokenType::STRING => "char*", [INFO] [stdout] 770 | | _ => "int", [INFO] [stdout] 771 | | }.to_string(); [INFO] [stdout] | |_____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 766 ~ match self.get_type() { [INFO] [stdout] 767 + TokenType::INT => "int", [INFO] [stdout] 768 + TokenType::FLOAT => "float", [INFO] [stdout] 769 + TokenType::STRING => "char*", [INFO] [stdout] 770 + _ => "int", [INFO] [stdout] 771 ~ }.to_string() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 2.73s [INFO] running `Command { std: "docker" "inspect" "2c539baa037e83bac7ab72cf6d895cc9cb0a2c7c7b29d2fbec687e14972a6945", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2c539baa037e83bac7ab72cf6d895cc9cb0a2c7c7b29d2fbec687e14972a6945", kill_on_drop: false }` [INFO] [stdout] 2c539baa037e83bac7ab72cf6d895cc9cb0a2c7c7b29d2fbec687e14972a6945