[INFO] cloning repository https://github.com/yeweiyang96/g4_data_filter [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/yeweiyang96/g4_data_filter" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyeweiyang96%2Fg4_data_filter", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyeweiyang96%2Fg4_data_filter'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] c7827191dde9e8674a7e504a12cf36c2c73d6663 [INFO] linting yeweiyang96/g4_data_filter against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fyeweiyang96%2Fg4_data_filter" "/workspace/builds/worker-4-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-4-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/yeweiyang96/g4_data_filter [INFO] finished tweaking git repo https://github.com/yeweiyang96/g4_data_filter [INFO] tweaked toml for git repo https://github.com/yeweiyang96/g4_data_filter written to /workspace/builds/worker-4-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/yeweiyang96/g4_data_filter on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/yeweiyang96/g4_data_filter already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] f5c6e13014b4e0055be12d35e8ef2fe0cd5671553efc0712d4fb8716e331c16c [INFO] running `Command { std: "docker" "start" "-a" "f5c6e13014b4e0055be12d35e8ef2fe0cd5671553efc0712d4fb8716e331c16c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "f5c6e13014b4e0055be12d35e8ef2fe0cd5671553efc0712d4fb8716e331c16c", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "f5c6e13014b4e0055be12d35e8ef2fe0cd5671553efc0712d4fb8716e331c16c", kill_on_drop: false }` [INFO] [stdout] f5c6e13014b4e0055be12d35e8ef2fe0cd5671553efc0712d4fb8716e331c16c [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-4-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2092a3c8087c27856288233951859b2c40f31343bd1d78a051e4af055b4b3fba [INFO] running `Command { std: "docker" "start" "-a" "2092a3c8087c27856288233951859b2c40f31343bd1d78a051e4af055b4b3fba", kill_on_drop: false }` [INFO] [stderr] Compiling serde v1.0.163 [INFO] [stderr] Checking csv-core v0.1.10 [INFO] [stderr] Checking ryu v1.0.13 [INFO] [stderr] Checking itoa v1.0.6 [INFO] [stderr] Checking walkdir v2.3.3 [INFO] [stderr] Checking csv v1.2.1 [INFO] [stderr] Checking g4_data_filter v2.2.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 13 | / let m = HashMap::from([ [INFO] [stdout] 14 | | ("txt", 1), [INFO] [stdout] 15 | | ("add_gene.txt", 2), [INFO] [stdout] 16 | | ("add_gene.2.txt", 3), [INFO] [stdout] ... | [INFO] [stdout] 22 | | ("c.r.add_gene.2.txt", 9), [INFO] [stdout] 23 | | ]); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 24 | m [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ HashMap::from([ [INFO] [stdout] 15 + ("txt", 1), [INFO] [stdout] 16 + ("add_gene.txt", 2), [INFO] [stdout] 17 + ("add_gene.2.txt", 3), [INFO] [stdout] 18 + ("c.txt", 4), [INFO] [stdout] 19 + ("c.add_gene.txt", 5), [INFO] [stdout] 20 + ("c.add_gene.2.txt", 6), [INFO] [stdout] 21 + ("c.r.txt", 7), [INFO] [stdout] 22 + ("c.r.add_gene.txt", 8), [INFO] [stdout] 23 + ("c.r.add_gene.2.txt", 9), [INFO] [stdout] 24 + ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !fs::metadata(&new_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&new_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: returning the result of a `let` binding from a block [INFO] [stdout] --> src/main.rs:24:9 [INFO] [stdout] | [INFO] [stdout] 13 | / let m = HashMap::from([ [INFO] [stdout] 14 | | ("txt", 1), [INFO] [stdout] 15 | | ("add_gene.txt", 2), [INFO] [stdout] 16 | | ("add_gene.2.txt", 3), [INFO] [stdout] ... | [INFO] [stdout] 22 | | ("c.r.add_gene.2.txt", 9), [INFO] [stdout] 23 | | ]); [INFO] [stdout] | |___________- unnecessary `let` binding [INFO] [stdout] 24 | m [INFO] [stdout] | ^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stdout] = note: `#[warn(clippy::let_and_return)]` on by default [INFO] [stdout] help: return the expression directly [INFO] [stdout] | [INFO] [stdout] 13 ~ [INFO] [stdout] 14 ~ HashMap::from([ [INFO] [stdout] 15 + ("txt", 1), [INFO] [stdout] 16 + ("add_gene.txt", 2), [INFO] [stdout] 17 + ("add_gene.2.txt", 3), [INFO] [stdout] 18 + ("c.txt", 4), [INFO] [stdout] 19 + ("c.add_gene.txt", 5), [INFO] [stdout] 20 + ("c.add_gene.2.txt", 6), [INFO] [stdout] 21 + ("c.r.txt", 7), [INFO] [stdout] 22 + ("c.r.add_gene.txt", 8), [INFO] [stdout] 23 + ("c.r.add_gene.2.txt", 9), [INFO] [stdout] 24 + ]) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:53:8 [INFO] [stdout] | [INFO] [stdout] 53 | if !fs::metadata(&new_path).is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `fs::metadata(&new_path).is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:106:38 [INFO] [stdout] | [INFO] [stdout] 106 | fn build_path(s: String, child_path: &PathBuf) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 ~ fn build_path(s: String, child_path: &Path) -> PathBuf { [INFO] [stdout] 107 ~ let mut path = child_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 136 | wtr.write_record(&["ID", "T1", "T2", "T3", "T4", "TS", "GS", "SEQ", "Gene"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ID", "T1", "T2", "T3", "T4", "TS", "GS", "SEQ", "Gene"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:106:38 [INFO] [stdout] | [INFO] [stdout] 106 | fn build_path(s: String, child_path: &PathBuf) -> PathBuf { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 106 ~ fn build_path(s: String, child_path: &Path) -> PathBuf { [INFO] [stdout] 107 ~ let mut path = child_path.to_path_buf(); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | for part in line.split_whitespace() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (count, part) in (0_u8..).zip(line.split_whitespace())` [INFO] [stdout] | [INFO] [stdout] = note: `count` is of type `u8`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:136:22 [INFO] [stdout] | [INFO] [stdout] 136 | wtr.write_record(&["ID", "T1", "T2", "T3", "T4", "TS", "GS", "SEQ", "Gene"]) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `["ID", "T1", "T2", "T3", "T4", "TS", "GS", "SEQ", "Gene"]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the variable `count` is used as a loop counter [INFO] [stdout] --> src/main.rs:144:9 [INFO] [stdout] | [INFO] [stdout] 144 | for part in line.split_whitespace() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using: `for (count, part) in (0_u8..).zip(line.split_whitespace())` [INFO] [stdout] | [INFO] [stdout] = note: `count` is of type `u8`, making it ineligible for `Iterator::enumerate` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stdout] = note: `#[warn(clippy::explicit_counter_loop)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 5.35s [INFO] running `Command { std: "docker" "inspect" "2092a3c8087c27856288233951859b2c40f31343bd1d78a051e4af055b4b3fba", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2092a3c8087c27856288233951859b2c40f31343bd1d78a051e4af055b4b3fba", kill_on_drop: false }` [INFO] [stdout] 2092a3c8087c27856288233951859b2c40f31343bd1d78a051e4af055b4b3fba