[INFO] cloning repository https://github.com/xumarcus/tsp-ils [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xumarcus/tsp-ils" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxumarcus%2Ftsp-ils", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxumarcus%2Ftsp-ils'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] 1d5cf6b4f807b044c8f75bcf395135a6e1d6c241 [INFO] linting xumarcus/tsp-ils against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxumarcus%2Ftsp-ils" "/workspace/builds/worker-5-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-5-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xumarcus/tsp-ils [INFO] finished tweaking git repo https://github.com/xumarcus/tsp-ils [INFO] tweaked toml for git repo https://github.com/xumarcus/tsp-ils written to /workspace/builds/worker-5-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xumarcus/tsp-ils on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xumarcus/tsp-ils already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded matrixmultiply v0.3.8 [INFO] [stderr] Downloaded wide v0.7.13 [INFO] [stderr] Downloaded memoffset v0.9.0 [INFO] [stderr] Downloaded num-complex v0.4.4 [INFO] [stderr] Downloaded crossbeam-epoch v0.9.15 [INFO] [stderr] Downloaded bytemuck v1.14.0 [INFO] [stderr] Downloaded rayon-core v1.12.0 [INFO] [stderr] Downloaded crossbeam-utils v0.8.16 [INFO] [stderr] Downloaded statrs v0.16.0 [INFO] [stderr] Downloaded rayon v1.8.0 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] ef94a1da0dae3e42d556f5f943b558412463fa731d38e2b8a65e98717f09387a [INFO] running `Command { std: "docker" "start" "-a" "ef94a1da0dae3e42d556f5f943b558412463fa731d38e2b8a65e98717f09387a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "ef94a1da0dae3e42d556f5f943b558412463fa731d38e2b8a65e98717f09387a", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "ef94a1da0dae3e42d556f5f943b558412463fa731d38e2b8a65e98717f09387a", kill_on_drop: false }` [INFO] [stdout] ef94a1da0dae3e42d556f5f943b558412463fa731d38e2b8a65e98717f09387a [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-5-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 6ceff1fccbb39fceafc9ff19c616072e22f856c0314d9ee0a8204e40fa804fdc [INFO] running `Command { std: "docker" "start" "-a" "6ceff1fccbb39fceafc9ff19c616072e22f856c0314d9ee0a8204e40fa804fdc", kill_on_drop: false }` [INFO] [stderr] Compiling libm v0.2.8 [INFO] [stderr] Compiling num-traits v0.2.17 [INFO] [stderr] Compiling libc v0.2.150 [INFO] [stderr] Compiling proc-macro2 v1.0.70 [INFO] [stderr] Compiling memoffset v0.9.0 [INFO] [stderr] Compiling crossbeam-utils v0.8.16 [INFO] [stderr] Compiling num-integer v0.1.45 [INFO] [stderr] Compiling crossbeam-epoch v0.9.15 [INFO] [stderr] Checking bytemuck v1.14.0 [INFO] [stderr] Compiling paste v1.0.14 [INFO] [stderr] Compiling syn v1.0.109 [INFO] [stderr] Compiling matrixmultiply v0.3.8 [INFO] [stderr] Compiling num-rational v0.4.1 [INFO] [stderr] Compiling rayon-core v1.12.0 [INFO] [stderr] Checking rawpointer v0.2.1 [INFO] [stderr] Checking either v1.9.0 [INFO] [stderr] Checking tsp-ils v0.1.0 (/opt/rustwide/workdir) [INFO] [stderr] Checking safe_arch v0.7.1 [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / (c < b && b < a) || [INFO] [stdout] 38 | | (b < a && a < c) || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 - (c < b && b < a) || [INFO] [stdout] 38 - (b < a && a < c) || [INFO] [stdout] 37 + !(b >= a || c >= b && a >= c) || [INFO] [stdout] | [INFO] [stdout] 37 - (c < b && b < a) || [INFO] [stdout] 38 - (b < a && a < c) || [INFO] [stdout] 37 + (a < c || c < b) && b < a || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | let m = (self.seglen(x, y) + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.seglen(x, y).div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:435:27 [INFO] [stdout] | [INFO] [stdout] 435 | let t = Tour::new(&tsp); [INFO] [stdout] | ^^^^ help: change this to: `tsp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:485:21 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn solution(&self) -> &Tour { [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] | | || [INFO] [stdout] | | |the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 485 | pub fn solution(&self) -> &Tour<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Checking wide v0.7.13 [INFO] [stderr] Compiling quote v1.0.33 [INFO] [stderr] Checking getrandom v0.2.11 [INFO] [stderr] Checking crossbeam-deque v0.8.3 [INFO] [stderr] Checking rand_core v0.6.4 [INFO] [stderr] Checking rand_chacha v0.3.1 [INFO] [stderr] Checking rand v0.8.5 [INFO] [stderr] Checking rayon v1.8.0 [INFO] [stderr] Checking num-complex v0.4.4 [INFO] [stderr] Checking approx v0.5.1 [INFO] [stderr] Checking rand_distr v0.4.3 [INFO] [stderr] Checking simba v0.6.0 [INFO] [stderr] Compiling nalgebra-macros v0.1.0 [INFO] [stderr] Checking nalgebra v0.29.0 [INFO] [stderr] Checking statrs v0.16.0 [INFO] [stdout] warning: this can be `std::io::Error::other(_)` [INFO] [stdout] --> examples/example.rs:62:20 [INFO] [stdout] | [INFO] [stdout] 62 | .ok_or(Error::new(ErrorKind::Other, "Empty data"))?; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#io_other_error [INFO] [stdout] = note: `#[warn(clippy::io_other_error)]` on by default [INFO] [stdout] help: use `std::io::Error::other` [INFO] [stdout] | [INFO] [stdout] 62 - .ok_or(Error::new(ErrorKind::Other, "Empty data"))?; [INFO] [stdout] 62 + .ok_or(Error::other("Empty data"))?; [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/lib.rs:37:9 [INFO] [stdout] | [INFO] [stdout] 37 | / (c < b && b < a) || [INFO] [stdout] 38 | | (b < a && a < c) || [INFO] [stdout] | |________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 37 - (c < b && b < a) || [INFO] [stdout] 38 - (b < a && a < c) || [INFO] [stdout] 37 + !(b >= a || c >= b && a >= c) || [INFO] [stdout] | [INFO] [stdout] 37 - (c < b && b < a) || [INFO] [stdout] 38 - (b < a && a < c) || [INFO] [stdout] 37 + (a < c || c < b) && b < a || [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: manually reimplementing `div_ceil` [INFO] [stdout] --> src/lib.rs:134:17 [INFO] [stdout] | [INFO] [stdout] 134 | let m = (self.seglen(x, y) + 1) / 2; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using `.div_ceil()`: `self.seglen(x, y).div_ceil(2)` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_div_ceil [INFO] [stdout] = note: `#[warn(clippy::manual_div_ceil)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/lib.rs:435:27 [INFO] [stdout] | [INFO] [stdout] 435 | let t = Tour::new(&tsp); [INFO] [stdout] | ^^^^ help: change this to: `tsp` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the loop variable `i` is used to index `POINTS` [INFO] [stdout] --> src/lib.rs:593:18 [INFO] [stdout] | [INFO] [stdout] 593 | for i in 0..10 { [INFO] [stdout] | ^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stdout] = note: `#[warn(clippy::needless_range_loop)]` on by default [INFO] [stdout] help: consider using an iterator and enumerate() [INFO] [stdout] | [INFO] [stdout] 593 - for i in 0..10 { [INFO] [stdout] 593 + for (i, ) in POINTS.iter().enumerate() { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: hiding a lifetime that's elided elsewhere is confusing [INFO] [stdout] --> src/lib.rs:485:21 [INFO] [stdout] | [INFO] [stdout] 485 | pub fn solution(&self) -> &Tour { [INFO] [stdout] | ^^^^^ ^^^^^ [INFO] [stdout] | | || [INFO] [stdout] | | |the same lifetime is hidden here [INFO] [stdout] | | the same lifetime is elided here [INFO] [stdout] | the lifetime is elided here [INFO] [stdout] | [INFO] [stdout] = help: the same lifetime is referred to in inconsistent ways, making the signature confusing [INFO] [stdout] = note: `#[warn(mismatched_lifetime_syntaxes)]` on by default [INFO] [stdout] help: use `'_` for type paths [INFO] [stdout] | [INFO] [stdout] 485 | pub fn solution(&self) -> &Tour<'_> { [INFO] [stdout] | ++++ [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 19.49s [INFO] running `Command { std: "docker" "inspect" "6ceff1fccbb39fceafc9ff19c616072e22f856c0314d9ee0a8204e40fa804fdc", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "6ceff1fccbb39fceafc9ff19c616072e22f856c0314d9ee0a8204e40fa804fdc", kill_on_drop: false }` [INFO] [stdout] 6ceff1fccbb39fceafc9ff19c616072e22f856c0314d9ee0a8204e40fa804fdc