[INFO] cloning repository https://github.com/xspeed1989/file_deploy [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xspeed1989/file_deploy" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxspeed1989%2Ffile_deploy", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxspeed1989%2Ffile_deploy'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] e5d01641d102a0b959d1b7fccc29739b3eb901cd [INFO] linting xspeed1989/file_deploy against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2Fxspeed1989%2Ffile_deploy" "/workspace/builds/worker-6-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-6-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xspeed1989/file_deploy [INFO] finished tweaking git repo https://github.com/xspeed1989/file_deploy [INFO] tweaked toml for git repo https://github.com/xspeed1989/file_deploy written to /workspace/builds/worker-6-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xspeed1989/file_deploy on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xspeed1989/file_deploy already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded prost-types v0.14.1 [INFO] [stderr] Downloaded prost-derive v0.14.1 [INFO] [stderr] Downloaded prost v0.14.1 [INFO] [stderr] Downloaded prost-build v0.14.1 [INFO] [stderr] Downloaded rustls-webpki v0.103.7 [INFO] [stderr] Downloaded aws-lc-rs v1.14.1 [INFO] [stderr] Downloaded webpki-roots v1.0.2 [INFO] [stderr] Downloaded aws-lc-sys v0.32.2 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 24d522b2153e3fdb7e6a4800d72b62ddf7b97e54bc3fa8bea7a8a658179a7e37 [INFO] running `Command { std: "docker" "start" "-a" "24d522b2153e3fdb7e6a4800d72b62ddf7b97e54bc3fa8bea7a8a658179a7e37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "24d522b2153e3fdb7e6a4800d72b62ddf7b97e54bc3fa8bea7a8a658179a7e37", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "24d522b2153e3fdb7e6a4800d72b62ddf7b97e54bc3fa8bea7a8a658179a7e37", kill_on_drop: false }` [INFO] [stdout] 24d522b2153e3fdb7e6a4800d72b62ddf7b97e54bc3fa8bea7a8a658179a7e37 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-6-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 667857ccc94f6c4ea8a37eadf1e758ab9257b6ba2c3fc999c7fe574d17030565 [INFO] running `Command { std: "docker" "start" "-a" "667857ccc94f6c4ea8a37eadf1e758ab9257b6ba2c3fc999c7fe574d17030565", kill_on_drop: false }` [INFO] [stderr] Compiling quote v1.0.41 [INFO] [stderr] Compiling find-msvc-tools v0.1.3 [INFO] [stderr] Compiling dunce v1.0.5 [INFO] [stderr] Compiling fs_extra v1.3.0 [INFO] [stderr] Compiling either v1.15.0 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Compiling libloading v0.8.8 [INFO] [stderr] Compiling anyhow v1.0.100 [INFO] [stderr] Compiling rustix v1.1.2 [INFO] [stderr] Checking zeroize v1.8.2 [INFO] [stderr] Compiling aws-lc-rs v1.14.1 [INFO] [stderr] Compiling prettyplease v0.2.37 [INFO] [stderr] Compiling linux-raw-sys v0.11.0 [INFO] [stderr] Compiling regex-syntax v0.8.6 [INFO] [stderr] Compiling bytes v1.10.1 [INFO] [stderr] Compiling hashbrown v0.16.0 [INFO] [stderr] Compiling bitflags v2.9.4 [INFO] [stderr] Checking rustls-pki-types v1.12.0 [INFO] [stderr] Compiling fastrand v2.3.0 [INFO] [stderr] Checking log v0.4.28 [INFO] [stderr] Compiling fixedbitset v0.5.7 [INFO] [stderr] Compiling cc v1.2.40 [INFO] [stderr] Checking parking_lot_core v0.9.12 [INFO] [stderr] Compiling multimap v0.10.1 [INFO] [stderr] Compiling rustls v0.23.32 [INFO] [stderr] Checking anstyle-query v1.1.4 [INFO] [stderr] Checking parking_lot v0.12.5 [INFO] [stderr] Compiling itertools v0.14.0 [INFO] [stderr] Compiling crc32c v0.6.8 [INFO] [stderr] Checking crypto-common v0.1.6 [INFO] [stderr] Checking mio v1.0.4 [INFO] [stderr] Checking anstream v0.6.21 [INFO] [stderr] Checking signal-hook-registry v1.4.6 [INFO] [stderr] Checking socket2 v0.6.0 [INFO] [stderr] Checking clap_lex v0.7.5 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Compiling syn v2.0.106 [INFO] [stderr] Checking tracing-log v0.2.0 [INFO] [stderr] Checking webpki-roots v1.0.2 [INFO] [stderr] Checking clap_builder v4.5.48 [INFO] [stderr] Checking sha2 v0.10.9 [INFO] [stderr] Compiling indexmap v2.11.4 [INFO] [stderr] Compiling cmake v0.1.54 [INFO] [stderr] Compiling regex-automata v0.4.11 [INFO] [stderr] Compiling petgraph v0.7.1 [INFO] [stderr] Compiling aws-lc-sys v0.32.2 [INFO] [stderr] Compiling tempfile v3.23.0 [INFO] [stderr] Compiling regex v1.11.3 [INFO] [stderr] Checking matchers v0.2.0 [INFO] [stderr] Compiling prost-derive v0.14.1 [INFO] [stderr] Compiling tokio-macros v2.5.0 [INFO] [stderr] Compiling tracing-attributes v0.1.30 [INFO] [stderr] Compiling clap_derive v4.5.47 [INFO] [stderr] Compiling async-recursion v1.1.1 [INFO] [stderr] Checking tokio v1.47.1 [INFO] [stderr] Checking tracing v0.1.41 [INFO] [stderr] Checking tracing-subscriber v0.3.20 [INFO] [stderr] Compiling prost v0.14.1 [INFO] [stderr] Compiling prost-types v0.14.1 [INFO] [stderr] Checking clap v4.5.48 [INFO] [stderr] Compiling prost-build v0.14.1 [INFO] [stderr] Compiling file_deploy v0.1.2 (/opt/rustwide/workdir) [INFO] [stderr] Checking rustls-webpki v0.103.7 [INFO] [stderr] Checking tokio-rustls v0.26.4 [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/client/connection.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | const FILE_CHUNK_SIZE: usize = 1 * 1024 * 1024; // 1MB [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `1024` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/client/connection.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 212 | remote: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 ~ remote: &str, [INFO] [stdout] 213 | ) -> Result<(), Box> { [INFO] [stdout] 214 | let req = file_deploy::MkDirRequest { [INFO] [stdout] 215 ~ absolute_path: remote.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/client/connection.rs:305:16 [INFO] [stdout] | [INFO] [stdout] 305 | if (&local_path).is_dir() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `local_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/client/connection.rs:319:23 [INFO] [stdout] | [INFO] [stdout] 319 | } else if (&local_path).is_file() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `local_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this operation has no effect [INFO] [stdout] --> src/client/connection.rs:19:32 [INFO] [stdout] | [INFO] [stdout] 19 | const FILE_CHUNK_SIZE: usize = 1 * 1024 * 1024; // 1MB [INFO] [stdout] | ^^^^^^^^ help: consider reducing it to: `1024` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stdout] = note: `#[warn(clippy::identity_op)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/client.rs:104:15 [INFO] [stdout] | [INFO] [stdout] 104 | password: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 ~ password: &str, [INFO] [stdout] 105 | paths: Vec<&DeployPathPair>, [INFO] [stdout] ... [INFO] [stdout] 131 | let conn = Arc::new(connection::Connection::new( [INFO] [stdout] 132 ~ password.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Cmd` [INFO] [stdout] --> src/data_define.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub(crate) enum Command { [INFO] [stdout] 10 | | CmdAuthenticate = 1, [INFO] [stdout] 11 | | CmdMkDir, [INFO] [stdout] 12 | | CmdStartUpload, [INFO] [stdout] 13 | | CmdUploadChunk, [INFO] [stdout] 14 | | CmdAllDone, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `auth_req` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/session.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 62 | if auth_req.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = auth_req` [INFO] [stdout] 63 | let auth_req = auth_req.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/client/connection.rs:212:17 [INFO] [stdout] | [INFO] [stdout] 212 | remote: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 212 ~ remote: &str, [INFO] [stdout] 213 | ) -> Result<(), Box> { [INFO] [stdout] 214 | let req = file_deploy::MkDirRequest { [INFO] [stdout] 215 ~ absolute_path: remote.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if !mk_dir_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `mk_dir_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/client/connection.rs:305:16 [INFO] [stdout] | [INFO] [stdout] 305 | if (&local_path).is_dir() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `local_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 167 | if !start_upload_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_upload_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression borrows a value the compiler would automatically borrow [INFO] [stdout] --> src/client/connection.rs:319:23 [INFO] [stdout] | [INFO] [stdout] 319 | } else if (&local_path).is_file() { [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `local_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/client.rs:104:15 [INFO] [stdout] | [INFO] [stdout] 104 | password: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 104 ~ password: &str, [INFO] [stdout] 105 | paths: Vec<&DeployPathPair>, [INFO] [stdout] ... [INFO] [stdout] 131 | let conn = Arc::new(connection::Connection::new( [INFO] [stdout] 132 ~ password.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:259:12 [INFO] [stdout] | [INFO] [stdout] 259 | if !upload_chunk_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `upload_chunk_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: all variants have the same prefix: `Cmd` [INFO] [stdout] --> src/data_define.rs:9:1 [INFO] [stdout] | [INFO] [stdout] 9 | / pub(crate) enum Command { [INFO] [stdout] 10 | | CmdAuthenticate = 1, [INFO] [stdout] 11 | | CmdMkDir, [INFO] [stdout] 12 | | CmdStartUpload, [INFO] [stdout] 13 | | CmdUploadChunk, [INFO] [stdout] 14 | | CmdAllDone, [INFO] [stdout] 15 | | } [INFO] [stdout] | |_^ [INFO] [stdout] | [INFO] [stdout] = help: remove the prefixes and use full paths to the variants instead of glob imports [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#enum_variant_names [INFO] [stdout] = note: `#[warn(clippy::enum_variant_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: called `unwrap` on `auth_req` after checking its variant with `is_ok` [INFO] [stdout] --> src/server/session.rs:63:28 [INFO] [stdout] | [INFO] [stdout] 62 | if auth_req.is_ok() { [INFO] [stdout] | ------------------- help: try: `if let Ok() = auth_req` [INFO] [stdout] 63 | let auth_req = auth_req.unwrap(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_unwrap [INFO] [stdout] = note: `#[warn(clippy::unnecessary_unwrap)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/session.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 355 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 354 - error!("Failed to wait for script: {}", status.err().unwrap()); [INFO] [stdout] 355 - return; [INFO] [stdout] 354 + error!("Failed to wait for script: {}", status.err().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:101:12 [INFO] [stdout] | [INFO] [stdout] 101 | if !mk_dir_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^ help: try: `mk_dir_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/session.rs:340:22 [INFO] [stdout] | [INFO] [stdout] 340 | cmd.args(&["/C", &script]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["/C", &script]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:167:12 [INFO] [stdout] | [INFO] [stdout] 167 | if !start_upload_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `start_upload_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/server/session.rs:259:12 [INFO] [stdout] | [INFO] [stdout] 259 | if !upload_chunk_req.is_ok() { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `upload_chunk_req.is_err()` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/config.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return config.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return config.clone(); [INFO] [stdout] 29 + config.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/server.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | password: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ password: &str, [INFO] [stdout] 38 | paths: Vec<&PathBuf>, [INFO] [stdout] ... [INFO] [stdout] 45 | self::config::set_config( [INFO] [stdout] 46 ~ password.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/session.rs:355:13 [INFO] [stdout] | [INFO] [stdout] 355 | return; [INFO] [stdout] | ^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 354 - error!("Failed to wait for script: {}", status.err().unwrap()); [INFO] [stdout] 355 - return; [INFO] [stdout] 354 + error!("Failed to wait for script: {}", status.err().unwrap()); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/server/session.rs:340:22 [INFO] [stdout] | [INFO] [stdout] 340 | cmd.args(&["/C", &script]); [INFO] [stdout] | ^^^^^^^^^^^^^^^^ help: change this to: `["/C", &script]` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/server/config.rs:29:5 [INFO] [stdout] | [INFO] [stdout] 29 | return config.clone(); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 29 - return config.clone(); [INFO] [stdout] 29 + config.clone() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&String` instead of `&str` involves a new object where a slice will do [INFO] [stdout] --> src/server.rs:37:15 [INFO] [stdout] | [INFO] [stdout] 37 | password: &String, [INFO] [stdout] | ^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 37 ~ password: &str, [INFO] [stdout] 38 | paths: Vec<&PathBuf>, [INFO] [stdout] ... [INFO] [stdout] 45 | self::config::set_config( [INFO] [stdout] 46 ~ password.to_owned(), [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/lib.rs:67:58 [INFO] [stdout] | [INFO] [stdout] 67 | ... std::path::PathBuf::from(&path_str[4..]) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/lib.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... if path_str.starts_with(r"\\?\") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 66 ~ if let Some() = path_str.strip_prefix(r"\\?\") { [INFO] [stdout] 67 ~ std::path::PathBuf::from() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: stripping a prefix manually [INFO] [stdout] --> src/lib.rs:67:58 [INFO] [stdout] | [INFO] [stdout] 67 | ... std::path::PathBuf::from(&path_str[4..]) [INFO] [stdout] | ^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] note: the prefix was tested here [INFO] [stdout] --> src/lib.rs:66:29 [INFO] [stdout] | [INFO] [stdout] 66 | ... if path_str.starts_with(r"\\?\") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#manual_strip [INFO] [stdout] = note: `#[warn(clippy::manual_strip)]` on by default [INFO] [stdout] help: try using the `strip_prefix` method [INFO] [stdout] | [INFO] [stdout] 66 ~ if let Some() = path_str.strip_prefix(r"\\?\") { [INFO] [stdout] 67 ~ std::path::PathBuf::from() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 55.45s [INFO] running `Command { std: "docker" "inspect" "667857ccc94f6c4ea8a37eadf1e758ab9257b6ba2c3fc999c7fe574d17030565", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "667857ccc94f6c4ea8a37eadf1e758ab9257b6ba2c3fc999c7fe574d17030565", kill_on_drop: false }` [INFO] [stdout] 667857ccc94f6c4ea8a37eadf1e758ab9257b6ba2c3fc999c7fe574d17030565