[INFO] cloning repository https://github.com/xrEngine512/build_sync [INFO] running `Command { std: "git" "-c" "credential.helper=" "-c" "credential.helper=/workspace/cargo-home/bin/git-credential-null" "clone" "--bare" "https://github.com/xrEngine512/build_sync" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxrEngine512%2Fbuild_sync", kill_on_drop: false }` [INFO] [stderr] Cloning into bare repository '/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxrEngine512%2Fbuild_sync'... [INFO] running `Command { std: "git" "rev-parse" "HEAD", kill_on_drop: false }` [INFO] [stdout] d50585bfdfca39f676b2f603cabe3c53973d4587 [INFO] linting xrEngine512/build_sync against nightly for clippy-nonminimal_bool-denied [INFO] running `Command { std: "git" "clone" "/workspace/cache/git-repos/https%3A%2F%2Fgithub.com%2FxrEngine512%2Fbuild_sync" "/workspace/builds/worker-3-tc1/source", kill_on_drop: false }` [INFO] [stderr] Cloning into '/workspace/builds/worker-3-tc1/source'... [INFO] [stderr] done. [INFO] started tweaking git repo https://github.com/xrEngine512/build_sync [INFO] finished tweaking git repo https://github.com/xrEngine512/build_sync [INFO] tweaked toml for git repo https://github.com/xrEngine512/build_sync written to /workspace/builds/worker-3-tc1/source/Cargo.toml [INFO] validating manifest of git repo https://github.com/xrEngine512/build_sync on toolchain nightly [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "metadata" "--manifest-path" "Cargo.toml" "--no-deps", kill_on_drop: false }` [INFO] crate git repo https://github.com/xrEngine512/build_sync already has a lockfile, it will not be regenerated [INFO] running `Command { std: CARGO_HOME="/workspace/cargo-home" RUSTUP_HOME="/workspace/rustup-home" "/workspace/cargo-home/bin/cargo" "+nightly" "fetch" "--manifest-path" "Cargo.toml", kill_on_drop: false }` [INFO] [stderr] Updating crates.io index [INFO] [stderr] Downloading crates ... [INFO] [stderr] Downloaded liblzma v0.4.2 [INFO] [stderr] Downloaded read-stdin v1.1.1 [INFO] [stderr] Downloaded libz-rs-sys v0.5.1 [INFO] [stderr] Downloaded libbz2-rs-sys v0.2.1 [INFO] [stderr] Downloaded bzip2 v0.6.0 [INFO] [stderr] Downloaded ppmd-rust v1.2.1 [INFO] [stderr] Downloaded zopfli v0.8.2 [INFO] [stderr] Downloaded zlib-rs v0.5.1 [INFO] [stderr] Downloaded zip v4.3.0 [INFO] [stderr] Downloaded liblzma-sys v0.4.4 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "metadata" "--no-deps" "--format-version=1", kill_on_drop: false }` [INFO] [stdout] 0c3311cab1143cb076bd4f98f93289b1d0879a1cd69b8450556c54895dee7606 [INFO] running `Command { std: "docker" "start" "-a" "0c3311cab1143cb076bd4f98f93289b1d0879a1cd69b8450556c54895dee7606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "inspect" "0c3311cab1143cb076bd4f98f93289b1d0879a1cd69b8450556c54895dee7606", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "0c3311cab1143cb076bd4f98f93289b1d0879a1cd69b8450556c54895dee7606", kill_on_drop: false }` [INFO] [stdout] 0c3311cab1143cb076bd4f98f93289b1d0879a1cd69b8450556c54895dee7606 [INFO] running `Command { std: "docker" "create" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/target:/opt/rustwide/target:rw,Z" "-v" "/var/lib/crater-agent-workspace/builds/worker-3-tc1/source:/opt/rustwide/workdir:ro,Z" "-v" "/var/lib/crater-agent-workspace/cargo-home:/opt/rustwide/cargo-home:ro,Z" "-v" "/var/lib/crater-agent-workspace/rustup-home:/opt/rustwide/rustup-home:ro,Z" "-e" "SOURCE_DIR=/opt/rustwide/workdir" "-e" "CARGO_TARGET_DIR=/opt/rustwide/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "RUSTDOCFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/rustwide/cargo-home" "-e" "RUSTUP_HOME=/opt/rustwide/rustup-home" "-w" "/opt/rustwide/workdir" "-m" "1610612736" "--user" "0:0" "--network" "none" "ghcr.io/rust-lang/crates-build-env/linux@sha256:d429b63d4308055ea97f60fb1d3dfca48854a00942f1bd2ad806beaf015945ec" "/opt/rustwide/cargo-home/bin/cargo" "+nightly" "clippy" "--frozen" "--all" "--all-targets" "--message-format=json", kill_on_drop: false }` [INFO] [stdout] 2748a97cf42147fb5e650f8dd8312be7766464a190079cdab76559bfd0cfe0f2 [INFO] running `Command { std: "docker" "start" "-a" "2748a97cf42147fb5e650f8dd8312be7766464a190079cdab76559bfd0cfe0f2", kill_on_drop: false }` [INFO] [stderr] Checking zlib-rs v0.5.1 [INFO] [stderr] Compiling serde v1.0.219 [INFO] [stderr] Compiling jobserver v0.1.33 [INFO] [stderr] Checking crc32fast v1.5.0 [INFO] [stderr] Compiling getrandom v0.3.3 [INFO] [stderr] Checking deranged v0.4.0 [INFO] [stderr] Checking bumpalo v3.19.0 [INFO] [stderr] Compiling serde_json v1.0.140 [INFO] [stderr] Checking libbz2-rs-sys v0.2.1 [INFO] [stderr] Compiling syn v2.0.104 [INFO] [stderr] Checking inout v0.1.4 [INFO] [stderr] Checking digest v0.10.7 [INFO] [stderr] Checking hashbrown v0.15.4 [INFO] [stderr] Checking simd-adler32 v0.3.7 [INFO] [stderr] Checking time-core v0.1.4 [INFO] [stderr] Checking clap_builder v4.5.41 [INFO] [stderr] Checking ppmd-rust v1.2.1 [INFO] [stderr] Checking hmac v0.12.1 [INFO] [stderr] Checking sha1 v0.10.6 [INFO] [stderr] Checking deflate64 v0.1.9 [INFO] [stderr] Checking cipher v0.4.4 [INFO] [stderr] Checking pbkdf2 v0.12.2 [INFO] [stderr] Checking read-stdin v1.1.1 [INFO] [stderr] Compiling cc v1.2.29 [INFO] [stderr] Checking time v0.3.41 [INFO] [stderr] Checking zopfli v0.8.2 [INFO] [stderr] Checking indexmap v2.10.0 [INFO] [stderr] Checking aes v0.8.4 [INFO] [stderr] Checking bzip2 v0.6.0 [INFO] [stderr] Checking libz-rs-sys v0.5.1 [INFO] [stderr] Checking flate2 v1.1.2 [INFO] [stderr] Compiling zstd-sys v2.0.15+zstd.1.5.7 [INFO] [stderr] Compiling liblzma-sys v0.4.4 [INFO] [stderr] Compiling blake3 v1.8.2 [INFO] [stderr] Checking liblzma v0.4.2 [INFO] [stderr] Compiling serde_derive v1.0.219 [INFO] [stderr] Compiling zeroize_derive v1.4.2 [INFO] [stderr] Compiling clap_derive v4.5.41 [INFO] [stderr] Checking zeroize v1.8.1 [INFO] [stderr] Compiling zstd-safe v7.2.4 [INFO] [stderr] Checking zstd v0.13.3 [INFO] [stderr] Checking clap v4.5.41 [INFO] [stderr] Checking zip v4.3.0 [INFO] [stderr] Checking build_sync v1.0.0 (/opt/rustwide/workdir) [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use read_stdin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this import is redundant [INFO] [stdout] --> src/main.rs:11:1 [INFO] [stdout] | [INFO] [stdout] 11 | use read_stdin; [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: remove it entirely [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_component_path_imports [INFO] [stdout] = note: `#[warn(clippy::single_component_path_imports)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: redundant field names in struct initialization [INFO] [stdout] --> src/main.rs:67:9 [INFO] [stdout] | [INFO] [stdout] 67 | size: size, [INFO] [stdout] | ^^^^^^^^^^ help: replace it with: `size` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stdout] = note: `#[warn(clippy::redundant_field_names)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / return FileInfo { [INFO] [stdout] 67 | | size: size, [INFO] [stdout] 68 | | hash: hasher.finalize().to_string(), [INFO] [stdout] 69 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ FileInfo { [INFO] [stdout] 67 + size: size, [INFO] [stdout] 68 + hash: hasher.finalize().to_string(), [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return result; [INFO] [stdout] 75 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:73:38 [INFO] [stdout] | [INFO] [stdout] 73 | let file = File::open(file_path).expect(&format!("Failed to open {}", file_path.display())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to open {}", file_path.display()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:103:47 [INFO] [stdout] | [INFO] [stdout] 103 | let sub_snapshot = get_paths_impl(&root_build_dir_path, &path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return (path_str, info); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return (path_str, info); [INFO] [stdout] 126 + (path_str, info) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | let file = File::open(&path).expect("Failed to open file"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | / return get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 137 | | .into_par_iter() [INFO] [stdout] 138 | | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 139 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 ~ get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 137 + .into_par_iter() [INFO] [stdout] 138 + .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 139 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:138:52 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / return get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 147 | | .into_iter() [INFO] [stdout] 148 | | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 149 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 ~ get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 147 + .into_iter() [INFO] [stdout] 148 + .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 149 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:52 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | return build_snapshot_info; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 173 - return build_snapshot_info; [INFO] [stdout] 173 + build_snapshot_info [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:160:46 [INFO] [stdout] | [INFO] [stdout] 160 | generate_snapshot_info_parallel_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:160:63 [INFO] [stdout] | [INFO] [stdout] 160 | generate_snapshot_info_parallel_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:37 [INFO] [stdout] | [INFO] [stdout] 162 | generate_snapshot_info_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:54 [INFO] [stdout] | [INFO] [stdout] 162 | generate_snapshot_info_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:178:10 [INFO] [stdout] | [INFO] [stdout] 178 | .expect(&format!("Failed to create file {}", output_path.display())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to create file {}", output_path.display()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:179:44 [INFO] [stdout] | [INFO] [stdout] 179 | json::to_writer_pretty(file, snapshot).expect(&format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 180 | | "Failed to write JSON to file {}", [INFO] [stdout] 181 | | output_path.display() [INFO] [stdout] 182 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 ~ json::to_writer_pretty(file, snapshot).unwrap_or_else(|_| panic!("Failed to write JSON to file {}", [INFO] [stdout] 180 ~ output_path.display())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:187:57 [INFO] [stdout] | [INFO] [stdout] 187 | fn compress(file_relpaths: Vec, build_dir_path: &PathBuf, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 187 - fn compress(file_relpaths: Vec, build_dir_path: &PathBuf, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] 187 + fn compress(file_relpaths: Vec, build_dir_path: &Path, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:190:69 [INFO] [stdout] | [INFO] [stdout] 190 | let mut zip_writer = ZipWriter::new(File::create(&archive_path).expect(&format!( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 191 | | "Failed to create archive file {}", [INFO] [stdout] 192 | | archive_path.display() [INFO] [stdout] 193 | | ))); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ let mut zip_writer = ZipWriter::new(File::create(&archive_path).unwrap_or_else(|_| panic!("Failed to create archive file {}", [INFO] [stdout] 191 ~ archive_path.display()))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:190:54 [INFO] [stdout] | [INFO] [stdout] 190 | let mut zip_writer = ZipWriter::new(File::create(&archive_path).expect(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `archive_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:202:52 [INFO] [stdout] | [INFO] [stdout] 202 | File::open(build_dir_path.join(&path)).expect(&format!("Failed to open file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to open file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 212 | .expect(&format!("Failed to start file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to start file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FileOptions<'_, ()>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | .start_file(&path, options.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:219:18 [INFO] [stdout] | [INFO] [stdout] 219 | .expect(&format!("Failed to read file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | .expect(&format!("Failed to write file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | zip_writer.finish().expect(&format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 229 | | "Failed to finish archive {}", [INFO] [stdout] 230 | | archive_path.display() [INFO] [stdout] 231 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 228 ~ zip_writer.finish().unwrap_or_else(|_| panic!("Failed to finish archive {}", [INFO] [stdout] 229 ~ archive_path.display())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:241:57 [INFO] [stdout] | [INFO] [stdout] 241 | let build_snapshot_info = parse_build_snapshot_info(&build_snapshot_info_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_snapshot_info_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:243:32 [INFO] [stdout] | [INFO] [stdout] 243 | generate_snapshot_info(&build_dir_path, parallel_snapshot_generation); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/main.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | assert!(false, "Unsupported archive format"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:289:54 [INFO] [stdout] | [INFO] [stdout] 289 | let build_snapshot_info = generate_snapshot_info(&build_dir_path, parallel); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:290:46 [INFO] [stdout] | [INFO] [stdout] 290 | dump_snapshot_info(&build_snapshot_info, &build_snapshot_info_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_snapshot_info_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | if !args [INFO] [stdout] | ________^ [INFO] [stdout] 369 | | .build_snapshot_info_path [INFO] [stdout] 370 | | .extension() [INFO] [stdout] 371 | | .is_some_and(|ext| ext == "json") [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 368 ~ if args [INFO] [stdout] 369 + .build_snapshot_info_path [INFO] [stdout] 370 + .extension().is_none_or(|ext| ext != "json") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:401:12 [INFO] [stdout] | [INFO] [stdout] 401 | if !archive_path.extension().is_some_and(|ext| ext == "zip") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `archive_path.extension().is_none_or(|ext| ext != "zip")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CompressionMethod` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:409:34 [INFO] [stdout] | [INFO] [stdout] 409 | let compression_method = COMPRESSION_METHODS [INFO] [stdout] | __________________________________^ [INFO] [stdout] 410 | | .get( [INFO] [stdout] 411 | | args.compression_method [INFO] [stdout] 412 | | .trim() [INFO] [stdout] ... | [INFO] [stdout] 416 | | .expect("Unknown compression method specified") [INFO] [stdout] 417 | | .clone(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 409 ~ let compression_method = *COMPRESSION_METHODS [INFO] [stdout] 410 + .get( [INFO] [stdout] 411 + args.compression_method [INFO] [stdout] 412 + .trim() [INFO] [stdout] 413 + .to_lowercase() [INFO] [stdout] 414 + .as_str() [INFO] [stdout] 415 + ) [INFO] [stdout] 416 ~ .expect("Unknown compression method specified"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:66:5 [INFO] [stdout] | [INFO] [stdout] 66 | / return FileInfo { [INFO] [stdout] 67 | | size: size, [INFO] [stdout] 68 | | hash: hasher.finalize().to_string(), [INFO] [stdout] 69 | | }; [INFO] [stdout] | |_____^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] = note: `#[warn(clippy::needless_return)]` on by default [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 66 ~ FileInfo { [INFO] [stdout] 67 + size: size, [INFO] [stdout] 68 + hash: hasher.finalize().to_string(), [INFO] [stdout] 69 ~ } [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:75:5 [INFO] [stdout] | [INFO] [stdout] 75 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 75 - return result; [INFO] [stdout] 75 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:73:38 [INFO] [stdout] | [INFO] [stdout] 73 | let file = File::open(file_path).expect(&format!("Failed to open {}", file_path.display())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to open {}", file_path.display()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] = note: `#[warn(clippy::expect_fun_call)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:115:5 [INFO] [stdout] | [INFO] [stdout] 115 | return result; [INFO] [stdout] | ^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 115 - return result; [INFO] [stdout] 115 + result [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:103:47 [INFO] [stdout] | [INFO] [stdout] 103 | let sub_snapshot = get_paths_impl(&root_build_dir_path, &path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] = note: `#[warn(clippy::needless_borrow)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:126:5 [INFO] [stdout] | [INFO] [stdout] 126 | return (path_str, info); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 126 - return (path_str, info); [INFO] [stdout] 126 + (path_str, info) [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:120:27 [INFO] [stdout] | [INFO] [stdout] 120 | let file = File::open(&path).expect("Failed to open file"); [INFO] [stdout] | ^^^^^ help: change this to: `path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:136:5 [INFO] [stdout] | [INFO] [stdout] 136 | / return get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 137 | | .into_par_iter() [INFO] [stdout] 138 | | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 139 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 136 ~ get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 137 + .into_par_iter() [INFO] [stdout] 138 + .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 139 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:138:52 [INFO] [stdout] | [INFO] [stdout] 138 | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:146:5 [INFO] [stdout] | [INFO] [stdout] 146 | / return get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 147 | | .into_iter() [INFO] [stdout] 148 | | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 149 | | .collect(); [INFO] [stdout] | |__________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 146 ~ get_paths_impl(root_build_dir_path, build_dir_path) [INFO] [stdout] 147 + .into_iter() [INFO] [stdout] 148 + .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] 149 ~ .collect() [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:148:52 [INFO] [stdout] | [INFO] [stdout] 148 | .map(|path| get_snapshot_info_entry(&path, &root_build_dir_path)) [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^ help: change this to: `root_build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: unneeded `return` statement [INFO] [stdout] --> src/main.rs:173:5 [INFO] [stdout] | [INFO] [stdout] 173 | return build_snapshot_info; [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stdout] help: remove `return` [INFO] [stdout] | [INFO] [stdout] 173 - return build_snapshot_info; [INFO] [stdout] 173 + build_snapshot_info [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:160:46 [INFO] [stdout] | [INFO] [stdout] 160 | generate_snapshot_info_parallel_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:160:63 [INFO] [stdout] | [INFO] [stdout] 160 | generate_snapshot_info_parallel_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:37 [INFO] [stdout] | [INFO] [stdout] 162 | generate_snapshot_info_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:162:54 [INFO] [stdout] | [INFO] [stdout] 162 | generate_snapshot_info_impl(&build_dir_path, &build_dir_path) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:178:10 [INFO] [stdout] | [INFO] [stdout] 178 | .expect(&format!("Failed to create file {}", output_path.display())); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to create file {}", output_path.display()))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:179:44 [INFO] [stdout] | [INFO] [stdout] 179 | json::to_writer_pretty(file, snapshot).expect(&format!( [INFO] [stdout] | ____________________________________________^ [INFO] [stdout] 180 | | "Failed to write JSON to file {}", [INFO] [stdout] 181 | | output_path.display() [INFO] [stdout] 182 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 179 ~ json::to_writer_pretty(file, snapshot).unwrap_or_else(|_| panic!("Failed to write JSON to file {}", [INFO] [stdout] 180 ~ output_path.display())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: writing `&PathBuf` instead of `&Path` involves a new object where a slice will do [INFO] [stdout] --> src/main.rs:187:57 [INFO] [stdout] | [INFO] [stdout] 187 | fn compress(file_relpaths: Vec, build_dir_path: &PathBuf, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] | ^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stdout] = note: `#[warn(clippy::ptr_arg)]` on by default [INFO] [stdout] help: change this to [INFO] [stdout] | [INFO] [stdout] 187 - fn compress(file_relpaths: Vec, build_dir_path: &PathBuf, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] 187 + fn compress(file_relpaths: Vec, build_dir_path: &Path, archive_path: &PathBuf, compression_method: CompressionMethod) { [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:190:69 [INFO] [stdout] | [INFO] [stdout] 190 | let mut zip_writer = ZipWriter::new(File::create(&archive_path).expect(&format!( [INFO] [stdout] | _____________________________________________________________________^ [INFO] [stdout] 191 | | "Failed to create archive file {}", [INFO] [stdout] 192 | | archive_path.display() [INFO] [stdout] 193 | | ))); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 190 ~ let mut zip_writer = ZipWriter::new(File::create(&archive_path).unwrap_or_else(|_| panic!("Failed to create archive file {}", [INFO] [stdout] 191 ~ archive_path.display()))); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: the borrowed expression implements the required traits [INFO] [stdout] --> src/main.rs:190:54 [INFO] [stdout] | [INFO] [stdout] 190 | let mut zip_writer = ZipWriter::new(File::create(&archive_path).expect(&format!( [INFO] [stdout] | ^^^^^^^^^^^^^ help: change this to: `archive_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:202:52 [INFO] [stdout] | [INFO] [stdout] 202 | File::open(build_dir_path.join(&path)).expect(&format!("Failed to open file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to open file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:212:14 [INFO] [stdout] | [INFO] [stdout] 212 | .expect(&format!("Failed to start file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to start file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `FileOptions<'_, ()>` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:211:32 [INFO] [stdout] | [INFO] [stdout] 211 | .start_file(&path, options.clone()) [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: try removing the `clone` call: `options` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] = note: `#[warn(clippy::clone_on_copy)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:219:18 [INFO] [stdout] | [INFO] [stdout] 219 | .expect(&format!("Failed to read file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to read file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:225:18 [INFO] [stdout] | [INFO] [stdout] 225 | .expect(&format!("Failed to write file {}", path)); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `unwrap_or_else(|_| panic!("Failed to write file {}", path))` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: function call inside of `expect` [INFO] [stdout] --> src/main.rs:228:25 [INFO] [stdout] | [INFO] [stdout] 228 | zip_writer.finish().expect(&format!( [INFO] [stdout] | _________________________^ [INFO] [stdout] 229 | | "Failed to finish archive {}", [INFO] [stdout] 230 | | archive_path.display() [INFO] [stdout] 231 | | )); [INFO] [stdout] | |______^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 228 ~ zip_writer.finish().unwrap_or_else(|_| panic!("Failed to finish archive {}", [INFO] [stdout] 229 ~ archive_path.display())); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:241:57 [INFO] [stdout] | [INFO] [stdout] 241 | let build_snapshot_info = parse_build_snapshot_info(&build_snapshot_info_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_snapshot_info_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:243:32 [INFO] [stdout] | [INFO] [stdout] 243 | generate_snapshot_info(&build_dir_path, parallel_snapshot_generation); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this assertion is always `false` [INFO] [stdout] --> src/main.rs:279:9 [INFO] [stdout] | [INFO] [stdout] 279 | assert!(false, "Unsupported archive format"); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stdout] | [INFO] [stdout] = help: replace this with `panic!()` or `unreachable!()` [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assertions_on_constants [INFO] [stdout] = note: `#[warn(clippy::assertions_on_constants)]` on by default [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:289:54 [INFO] [stdout] | [INFO] [stdout] 289 | let build_snapshot_info = generate_snapshot_info(&build_dir_path, parallel); [INFO] [stdout] | ^^^^^^^^^^^^^^^ help: change this to: `build_dir_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this expression creates a reference which is immediately dereferenced by the compiler [INFO] [stdout] --> src/main.rs:290:46 [INFO] [stdout] | [INFO] [stdout] 290 | dump_snapshot_info(&build_snapshot_info, &build_snapshot_info_path); [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: change this to: `build_snapshot_info_path` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:368:8 [INFO] [stdout] | [INFO] [stdout] 368 | if !args [INFO] [stdout] | ________^ [INFO] [stdout] 369 | | .build_snapshot_info_path [INFO] [stdout] 370 | | .extension() [INFO] [stdout] 371 | | .is_some_and(|ext| ext == "json") [INFO] [stdout] | |_________________________________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] = note: `#[warn(clippy::nonminimal_bool)]` on by default [INFO] [stdout] help: try [INFO] [stdout] | [INFO] [stdout] 368 ~ if args [INFO] [stdout] 369 + .build_snapshot_info_path [INFO] [stdout] 370 + .extension().is_none_or(|ext| ext != "json") [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: this boolean expression can be simplified [INFO] [stdout] --> src/main.rs:401:12 [INFO] [stdout] | [INFO] [stdout] 401 | if !archive_path.extension().is_some_and(|ext| ext == "zip") { [INFO] [stdout] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `archive_path.extension().is_none_or(|ext| ext != "zip")` [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stdout] [INFO] [stdout] [INFO] [stdout] warning: using `clone` on type `CompressionMethod` which implements the `Copy` trait [INFO] [stdout] --> src/main.rs:409:34 [INFO] [stdout] | [INFO] [stdout] 409 | let compression_method = COMPRESSION_METHODS [INFO] [stdout] | __________________________________^ [INFO] [stdout] 410 | | .get( [INFO] [stdout] 411 | | args.compression_method [INFO] [stdout] 412 | | .trim() [INFO] [stdout] ... | [INFO] [stdout] 416 | | .expect("Unknown compression method specified") [INFO] [stdout] 417 | | .clone(); [INFO] [stdout] | |____________________^ [INFO] [stdout] | [INFO] [stdout] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy [INFO] [stdout] help: try dereferencing it [INFO] [stdout] | [INFO] [stdout] 409 ~ let compression_method = *COMPRESSION_METHODS [INFO] [stdout] 410 + .get( [INFO] [stdout] 411 + args.compression_method [INFO] [stdout] 412 + .trim() [INFO] [stdout] 413 + .to_lowercase() [INFO] [stdout] 414 + .as_str() [INFO] [stdout] 415 + ) [INFO] [stdout] 416 ~ .expect("Unknown compression method specified"); [INFO] [stdout] | [INFO] [stdout] [INFO] [stdout] [INFO] [stderr] Finished `dev` profile [unoptimized + debuginfo] target(s) in 28.27s [INFO] running `Command { std: "docker" "inspect" "2748a97cf42147fb5e650f8dd8312be7766464a190079cdab76559bfd0cfe0f2", kill_on_drop: false }` [INFO] running `Command { std: "docker" "rm" "-f" "2748a97cf42147fb5e650f8dd8312be7766464a190079cdab76559bfd0cfe0f2", kill_on_drop: false }` [INFO] [stdout] 2748a97cf42147fb5e650f8dd8312be7766464a190079cdab76559bfd0cfe0f2